Virtualization/openbios
1
0
Fork 0
mirror of https://gitlab.com/qemu-project/openbios.git synced 2024-02-13 08:34:06 +08:00
Code Issues Projects Releases Wiki Activity

loaders: fix open_ih return value checks

Browse Source 
open_ih() returns -1 on error and 0 is a valid return value.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>

git-svn-id: svn://coreboot.org/openbios/trunk/openbios-devel@839 f158a5a8-5612-0410-a976-696ce0be7e32
This commit is contained in:
Blue Swirl
2010-08-07 12:49:52 +00:00
parent 76715fe930
commit 988f780aa5
4 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
libopenbios/aout_load.c
View File

@@ -81,8 +81,9 @@ aout_load(struct sys_info *info, ihandle_t dev)
feval("0 state-valid !"); feval("0 state-valid !");
fd = open_ih(dev); fd = open_ih(dev);
if (!fd) if (fd == -1) {
goto out; goto out;
}
for (offset = 0; offset < 16 * 512; offset += 512) { for (offset = 0; offset < 16 * 512; offset += 512) {
seek_io(fd, offset); seek_io(fd, offset);

3
libopenbios/elf_load.c
View File

@@ -383,8 +383,9 @@ elf_load(struct sys_info *info, ihandle_t dev, const char *cmdline, void **boot_
feval("0 state-valid !"); feval("0 state-valid !");
fd = open_ih(dev); fd = open_ih(dev);
if (!fd) if (fd == -1) {
goto out; goto out;
}
offset = find_elf(&ehdr); offset = find_elf(&ehdr);
if (!offset) { if (!offset) {

3
libopenbios/fcode_load.c
View File

@@ -35,8 +35,9 @@ fcode_load(ihandle_t dev)
feval("0 state-valid !"); feval("0 state-valid !");
fd = open_ih(dev); fd = open_ih(dev);
if (!fd) if (fd == -1) {
goto out; goto out;
}
for (offset = 0; offset < 16 * 512; offset += 512) { for (offset = 0; offset < 16 * 512; offset += 512) {
seek_io(fd, offset); seek_io(fd, offset);

3
libopenbios/forth_load.c
View File

@@ -33,8 +33,9 @@ int forth_load(ihandle_t dev)
feval("0 state-valid !"); feval("0 state-valid !");
fd = open_ih(dev); fd = open_ih(dev);
if (!fd) if (fd == -1) {
goto out; goto out;
}
if (read_io(fd, magic, 2) != 2) { if (read_io(fd, magic, 2) != 2) {
debug("Can't read magic header\n"); debug("Can't read magic header\n");