This fixes various errors being caused by previous calls to CIF interpret throwing exceptions whilst in the Forth compile
state. Without this fix, subsequent calls to CIF interpret could be executed erroneusly in Forth compile state rather than the
Forth interpret state causing hard-to-detect Forth errors.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>
git-svn-id: svn://coreboot.org/openbios/trunk/openbios-devel@910 f158a5a8-5612-0410-a976-696ce0be7e32
According to IEEE 1275, "Size is either the actual size of the property,
or –1 if name does not exist."
The property might be larger than the client's buffer, so don't dup
the min used for writing into the buffer but the original proplen value.
Insert a comment to show what's going on.
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
git-svn-id: svn://coreboot.org/openbios/trunk/openbios-devel@894 f158a5a8-5612-0410-a976-696ce0be7e32
test-method for "instantiate-rtas" would fail on the /rtas node.
According to CHRP 1.5 draft, the stack order seems reversed.
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
git-svn-id: svn://coreboot.org/openbios/trunk/openbios-devel@891 f158a5a8-5612-0410-a976-696ce0be7e32
i) client-call-iface did not set a return value of 0 on success; hence the top stack argument was dropped as part of the status
check causing an off-by-one error.
ii) instead of setting pb->nret to be the number of arguments returned, the (random) value being passed in was being used to
control the number of arguments being returned.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>
git-svn-id: svn://coreboot.org/openbios/trunk/openbios-devel@732 f158a5a8-5612-0410-a976-696ce0be7e32
the private wordlist by default. This is required for executing Milax Fcode which defines package words which need to be externally
visible.
As a consequence, it is now possible to remove lots of "external" words used building the device tree since this is now the
default.
git-svn-id: svn://coreboot.org/openbios/trunk/openbios-devel@655 f158a5a8-5612-0410-a976-696ce0be7e32
are not in forth stack order but in reversed (heh!) order. Our implementation
confused this.
This second patch is fairly straightforward; probably the only unexpected part is
the need to rename the existing /openprom/client-services "claim" and
"release" words to "cif-claim" and "cif-release" respectively. This is
because we need to use the "claim" and "release" words in
forth/system/ciface.fs to reverse the argument order before calling the real
underlying words.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>
git-svn-id: svn://coreboot.org/openbios/trunk/openbios-devel@637 f158a5a8-5612-0410-a976-696ce0be7e32
are not in forth stack order but in reversed (heh!) order. Our implementation
confused this.
This might / will need some more work, but get this in so more people can test
easily.
From Mark Cave-Ayland and me.
git-svn-id: svn://coreboot.org/openbios/trunk/openbios-devel@624 f158a5a8-5612-0410-a976-696ce0be7e32
