Virtualization
/
opensbi
mirror of https://gitlab.com/qemu-project/opensbi.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

lib: utils/timer: Remove Allwinner D1 CLINT compatibles 

The allwinner,sun20i-d1-clint compatible string is not documented in any
official binding, so it should not be used by drivers.

The MSWI in the D1 CLINT is compatible with the ACLINT specification, so
it can take advantage of generic driver support. However, that is only
possible if the MSWI and MTIMER are split into separate DT nodes. This
means the final binding for this device is likely to be incompatible
with what is implemented here.

Remove this compatible string from the driver to prevent it from
appearing in a stable version and causing future issues.

Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Samuel Holland 2022-06-21 23:57:42 -05:00 committed by Anup Patel
parent d76a196bfc
commit 6f1fe98c2f
2 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/utils/ipi/fdt_ipi_mswi.c
View File

@ -54,7 +54,6 @@ static int ipi_mswi_cold_init(void *fdt, int nodeoff,
static const unsigned long clint_offset = CLINT_MSWI_OFFSET;
static const struct fdt_match ipi_mswi_match[] = {
{ .compatible = "allwinner,sun20i-d1-clint", .data = &clint_offset },
{ .compatible = "riscv,clint0", .data = &clint_offset },
{ .compatible = "sifive,clint0", .data = &clint_offset },
{ .compatible = "riscv,aclint-mswi" },

6
lib/utils/timer/fdt_timer_mtimer.c
View File

@ -109,18 +109,12 @@ static int timer_mtimer_cold_init(void *fdt, int nodeoff,
return 0;
}
static const struct timer_mtimer_quirks d1_clint_quirks = {
.mtime_offset = CLINT_MTIMER_OFFSET,
.has_64bit_mmio = false,
};
static const struct timer_mtimer_quirks sifive_clint_quirks = {
.mtime_offset = CLINT_MTIMER_OFFSET,
.has_64bit_mmio = true,
};
static const struct fdt_match timer_mtimer_match[] = {
{ .compatible = "allwinner,sun20i-d1-clint", .data = &d1_clint_quirks },
{ .compatible = "riscv,clint0", .data = &sifive_clint_quirks },
{ .compatible = "sifive,clint0", .data = &sifive_clint_quirks },
{ .compatible = "riscv,aclint-mtimer" },