Virtualization
/
opensbi
mirror of https://gitlab.com/qemu-project/opensbi.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

lib: utils/serial: Initialize platform_uart_data to zero 

While it doesn't look like there are any current cases of using
uninitialized data, let's zero all the UART data members to be
safe. Zero may not actually be better than a random number in
some cases, so all structure members should still be validated
before use, but at least zero is usually easier to debug than
some random stack garbage...

Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Andrew Jones 2022-07-18 19:20:26 +02:00 committed by Anup Patel
parent 8e86b23db9
commit 7d28d3be50
6 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/utils/serial/fdt_serial_gaisler.c
View File

@ -15,7 +15,7 @@ static int serial_gaisler_init(void *fdt, int nodeoff,
const struct fdt_match *match)
{
int rc;
struct platform_uart_data uart;
struct platform_uart_data uart = { 0 };
rc = fdt_parse_gaisler_uart_node(fdt, nodeoff, &uart);
if (rc)

2
lib/utils/serial/fdt_serial_shakti.c
View File

@ -13,7 +13,7 @@ static int serial_shakti_init(void *fdt, int nodeoff,
const struct fdt_match *match)
{
int rc;
struct platform_uart_data uart;
struct platform_uart_data uart = { 0 };
rc = fdt_parse_shakti_uart_node(fdt, nodeoff, &uart);
if (rc)

2
lib/utils/serial/fdt_serial_sifive.c
View File

@ -15,7 +15,7 @@ static int serial_sifive_init(void *fdt, int nodeoff,
const struct fdt_match *match)
{
int rc;
struct platform_uart_data uart;
struct platform_uart_data uart = { 0 };
rc = fdt_parse_sifive_uart_node(fdt, nodeoff, &uart);
if (rc)

2
lib/utils/serial/fdt_serial_uart8250.c
View File

@ -15,7 +15,7 @@ static int serial_uart8250_init(void *fdt, int nodeoff,
const struct fdt_match *match)
{
int rc;
struct platform_uart_data uart;
struct platform_uart_data uart = { 0 };
rc = fdt_parse_uart8250_node(fdt, nodeoff, &uart);
if (rc)

2
lib/utils/serial/fdt_serial_xlnx_uartlite.c
View File

@ -15,7 +15,7 @@ static int serial_xlnx_uartlite_init(void *fdt, int nodeoff,
const struct fdt_match *match)
{
int rc;
struct platform_uart_data uart;
struct platform_uart_data uart = { 0 };
rc = fdt_parse_xlnx_uartlite_node(fdt, nodeoff, &uart);
if (rc)

2
platform/fpga/openpiton/platform.c
View File

@ -69,7 +69,7 @@ static struct aclint_mtimer_data mtimer = {
static int openpiton_early_init(bool cold_boot)
{
void *fdt;
struct platform_uart_data uart_data;
struct platform_uart_data uart_data = { 0 };
struct plic_data plic_data;
unsigned long aclint_freq;
uint64_t clint_addr;