From 814f38dc1d9ec6cd7f75b0d6be15e861ddac9ac5 Mon Sep 17 00:00:00 2001 From: Anup Patel Date: Sat, 14 Mar 2020 19:26:22 +0530 Subject: [PATCH] lib: sbi_hsm: Don't use sbi_platform_hart_disabled() API Checking return value of sbi_hartid_to_scratch() is sufficient so no need to explicitly check for disabled HART using the sbi_platform_hart_disabled() API. Signed-off-by: Anup Patel Reviewed-by: Bin Meng Reviewed-by: Atish Patra --- lib/sbi/sbi_hsm.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index 4a457ce..10316c5 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -216,8 +216,6 @@ int sbi_hsm_hart_start(struct sbi_scratch *scratch, u32 hartid, if (!rscratch) return SBI_EINVAL; hdata = sbi_scratch_offset_ptr(rscratch, hart_data_offset); - if (sbi_platform_hart_disabled(plat, hartid)) - return SBI_EINVAL; hstate = arch_atomic_cmpxchg(&hdata->state, SBI_HART_STOPPED, SBI_HART_STARTING); if (hstate == SBI_HART_STARTED) @@ -254,12 +252,10 @@ int sbi_hsm_hart_stop(struct sbi_scratch *scratch, bool exitnow) { int oldstate; u32 hartid = current_hartid(); - const struct sbi_platform *plat = sbi_platform_ptr(scratch); struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch, hart_data_offset); - if (sbi_platform_hart_disabled(plat, hartid) || - !sbi_hsm_hart_started(hartid)) + if (!sbi_hsm_hart_started(hartid)) return SBI_EINVAL; oldstate = arch_atomic_cmpxchg(&hdata->state, SBI_HART_STARTED,