From ec1abf665737af032b8d58f8a5373bcaddedd902 Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Tue, 7 Jul 2020 11:56:55 +0200 Subject: [PATCH] include: sbi_bitops: Remove dead shift assignment in ffs/fls The value assigned to x by the shift assignment in the last if block of ffs/fls is never read. Remove it. Signed-off-by: Tobias Klauser Reviewed-by: Anup Patel --- include/sbi/sbi_bitops.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/include/sbi/sbi_bitops.h b/include/sbi/sbi_bitops.h index d920086..879430d 100644 --- a/include/sbi/sbi_bitops.h +++ b/include/sbi/sbi_bitops.h @@ -66,10 +66,8 @@ static inline int ffs(int x) x >>= 2; r += 2; } - if (!(x & 1)) { - x >>= 1; + if (!(x & 1)) r += 1; - } return r; } @@ -148,10 +146,8 @@ static inline int fls(int x) x <<= 2; r -= 2; } - if (!(x & 0x80000000u)) { - x <<= 1; + if (!(x & 0x80000000u)) r -= 1; - } return r; }