mirror of
https://gitlab.com/qemu-project/qemu.git
synced 2025-10-30 07:57:14 +08:00
ed26056d90
curl_easy_setopt takes a variable argument that depends on what
CURLOPT you are setting. Some require a long constant. Passing a
plain int constant is potentially wrong on some platforms.
With warnings enabled, multiple warnings like this were printed:
../block/curl.c: In function ‘curl_init_state’:
../block/curl.c:474:13: warning: call to ‘_curl_easy_setopt_err_long’ declared with attribute warning: curl_easy_setopt expects a long argument [-Wattribute-warning]
474 | curl_easy_setopt(state->curl, CURLOPT_AUTOREFERER, 1) ||
| ^
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Chenxi Mao <maochenxi@bosc.ac.cn>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20251009141026.4042021-2-rjones@redhat.com>
44 lines
1.0 KiB
C
44 lines
1.0 KiB
C
/*
|
|
* Copyright (c) 2018 Virtuozzo International GmbH
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
*
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include <curl/curl.h>
|
|
#include "download.h"
|
|
|
|
bool download_url(const char *name, const char *url)
|
|
{
|
|
bool success = false;
|
|
FILE *file;
|
|
CURL *curl = curl_easy_init();
|
|
|
|
if (!curl) {
|
|
return false;
|
|
}
|
|
|
|
file = fopen(name, "wb");
|
|
if (!file) {
|
|
goto out_curl;
|
|
}
|
|
|
|
if (curl_easy_setopt(curl, CURLOPT_URL, url) != CURLE_OK
|
|
|| curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, NULL) != CURLE_OK
|
|
|| curl_easy_setopt(curl, CURLOPT_WRITEDATA, file) != CURLE_OK
|
|
|| curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L) != CURLE_OK
|
|
|| curl_easy_setopt(curl, CURLOPT_NOPROGRESS, 0L) != CURLE_OK
|
|
|| curl_easy_perform(curl) != CURLE_OK) {
|
|
unlink(name);
|
|
fclose(file);
|
|
} else {
|
|
success = !fclose(file);
|
|
}
|
|
|
|
out_curl:
|
|
curl_easy_cleanup(curl);
|
|
|
|
return success;
|
|
}
|