intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-05 18:00:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: untrusted input

Browse Source 
Do not read an unlimited size of environment variables.

Signed-off-by: Kamil Kopryk <kamil.kopryk@intel.com>
This commit is contained in:
Kamil Kopryk
2025-02-07 13:56:19 +00:00
committed by Compute-Runtime-Automation
parent 7149743162
commit 03b56dc919
6 changed files with 67 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
shared/test/unit_test/os_interface/debug_env_reader_tests.cpp
View File

@@ -1,5 +1,5 @@
/*
* Copyright (C) 2018-2024 Intel Corporation
* Copyright (C) 2018-2025 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@@ -487,4 +487,35 @@ TEST_F(DebugEnvReaderTests, givenEnvironmentVariableReaderWhenCreateOsReaderWith
std::unique_ptr<SettingsReader> settingsReader(SettingsReader::createOsReader(false, ""));
EXPECT_NE(nullptr, settingsReader);
}
TEST_F(DebugEnvReaderTests, givenTooLongEnvValueWhenGetEnvironmentVariableIsCalledThenNullptrIsReturned) {
{
auto maxAllowedEnvVariableSize = CommonConstants::maxAllowedEnvVariableSize;
const char *testingVariableName = "test";
VariableBackup<uint32_t> mockGetenvCalledBackup(&IoFunctions::mockGetenvCalled, 0);
{
std::string veryLongPath(maxAllowedEnvVariableSize + 1u, 'a');
veryLongPath.back() = '\0';
std::unordered_map<std::string, std::string> mockableEnvs = {{testingVariableName, veryLongPath.c_str()}};
VariableBackup<std::unordered_map<std::string, std::string> *> mockableEnvValuesBackup(&IoFunctions::mockableEnvValues, &mockableEnvs);
auto envValue = IoFunctions::getEnvironmentVariable(testingVariableName);
ASSERT_NE(nullptr, veryLongPath.c_str());
EXPECT_EQ(nullptr, envValue);
}
{
std::string goodPath(maxAllowedEnvVariableSize, 'a');
goodPath.back() = '\0';
std::unordered_map<std::string, std::string> mockableEnvs = {{testingVariableName, goodPath.c_str()}};
VariableBackup<std::unordered_map<std::string, std::string> *> mockableEnvValuesBackup(&IoFunctions::mockableEnvValues, &mockableEnvs);
auto envValue = IoFunctions::getEnvironmentVariable(testingVariableName);
ASSERT_NE(nullptr, goodPath.c_str());
EXPECT_EQ(mockableEnvs.at(testingVariableName).c_str(), envValue);
}
}
}
} // namespace NEO