diff --git a/level_zero/core/source/cmdlist/cmdlist_hw.inl b/level_zero/core/source/cmdlist/cmdlist_hw.inl index 21b640f0c1..9d569031b0 100644 --- a/level_zero/core/source/cmdlist/cmdlist_hw.inl +++ b/level_zero/core/source/cmdlist/cmdlist_hw.inl @@ -1766,7 +1766,7 @@ ze_result_t CommandListCoreFamily::appendBlitFill(void *ptr, uint32_t numWaitEvents, ze_event_handle_t *phWaitEvents) { auto neoDevice = device->getNEODevice(); - if (NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily).getMaxFillPaternSizeForCopyEngine() < patternSize) { + if (NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily).getMaxFillPaternSizeForCopyEngine() < patternSize) { return ZE_RESULT_ERROR_INVALID_SIZE; } else { ze_result_t ret = addEventsToCmdList(numWaitEvents, phWaitEvents, true); @@ -2313,7 +2313,7 @@ ze_result_t CommandListCoreFamily::appendQueryKernelTimestamps( UNRECOVERABLE_IF(!result); Kernel *builtinKernel = nullptr; - auto useOnlyGlobalTimestamps = NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps() ? 1u : 0u; + auto useOnlyGlobalTimestamps = NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps() ? 1u : 0u; auto lock = device->getBuiltinFunctionsLib()->obtainUniqueOwnership(); if (pOffsets == nullptr) { diff --git a/level_zero/core/source/cmdlist/cmdlist_hw_base.inl b/level_zero/core/source/cmdlist/cmdlist_hw_base.inl index e5768f83c6..b0cf292da8 100644 --- a/level_zero/core/source/cmdlist/cmdlist_hw_base.inl +++ b/level_zero/core/source/cmdlist/cmdlist_hw_base.inl @@ -29,7 +29,7 @@ struct DeviceImp; template size_t CommandListCoreFamily::getReserveSshSize() { - auto &helper = NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily); + auto &helper = NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily); return helper.getRenderSurfaceStateSize(); } diff --git a/level_zero/core/source/cmdlist/cmdlist_hw_immediate.inl b/level_zero/core/source/cmdlist/cmdlist_hw_immediate.inl index f4075ebf5d..ead2c5c14a 100644 --- a/level_zero/core/source/cmdlist/cmdlist_hw_immediate.inl +++ b/level_zero/core/source/cmdlist/cmdlist_hw_immediate.inl @@ -631,7 +631,7 @@ bool CommandListCoreFamilyImmediate::preferCopyThroughLockedPtr(N if (NEO::DebugManager.flags.ExperimentalD2HCpuCopyThreshold.get() != -1) { d2HThreshold = NEO::DebugManager.flags.ExperimentalD2HCpuCopyThreshold.get(); } - if (NEO::HwHelper::get(this->device->getHwInfo().platform.eRenderCoreFamily).copyThroughLockedPtrEnabled(this->device->getHwInfo())) { + if (NEO::GfxCoreHelper::get(this->device->getHwInfo().platform.eRenderCoreFamily).copyThroughLockedPtrEnabled(this->device->getHwInfo())) { return (!srcFound && isSuitableUSMDeviceAlloc(dstAlloc, dstFound) && size <= h2DThreshold) || (!dstFound && isSuitableUSMDeviceAlloc(srcAlloc, srcFound) && size <= d2HThreshold); } diff --git a/level_zero/core/source/cmdlist/cmdlist_imp.cpp b/level_zero/core/source/cmdlist/cmdlist_imp.cpp index e377081daf..15543d012e 100644 --- a/level_zero/core/source/cmdlist/cmdlist_imp.cpp +++ b/level_zero/core/source/cmdlist/cmdlist_imp.cpp @@ -108,7 +108,7 @@ CommandList *CommandList::createImmediate(uint32_t productFamily, Device *device NEO::CommandStreamReceiver *csr = nullptr; auto deviceImp = static_cast(device); const auto &hwInfo = device->getHwInfo(); - auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); if (internalUsage) { if (NEO::EngineHelper::isCopyOnlyEngineType(engineGroupType) && deviceImp->getActiveDevice()->getInternalCopyEngine()) { csr = deviceImp->getActiveDevice()->getInternalCopyEngine()->commandStreamReceiver; @@ -117,7 +117,7 @@ CommandList *CommandList::createImmediate(uint32_t productFamily, Device *device csr = internalEngine.commandStreamReceiver; auto internalEngineType = internalEngine.getEngineType(); auto internalEngineUsage = internalEngine.getEngineUsage(); - engineGroupType = hwHelper.getEngineGroupType(internalEngineType, internalEngineUsage, hwInfo); + engineGroupType = gfxCoreHelper.getEngineGroupType(internalEngineType, internalEngineUsage, hwInfo); } } else { returnValue = device->getCsrForOrdinalAndIndex(&csr, desc->ordinal, desc->index); @@ -134,7 +134,7 @@ CommandList *CommandList::createImmediate(uint32_t productFamily, Device *device commandList->cmdListType = CommandListType::TYPE_IMMEDIATE; commandList->isSyncModeQueue = (desc->mode == ZE_COMMAND_QUEUE_MODE_SYNCHRONOUS); if (!internalUsage) { - commandList->isFlushTaskSubmissionEnabled = hwHelper.isPlatformFlushTaskEnabled(hwInfo); + commandList->isFlushTaskSubmissionEnabled = gfxCoreHelper.isPlatformFlushTaskEnabled(hwInfo); if (NEO::DebugManager.flags.EnableFlushTaskSubmission.get() != -1) { commandList->isFlushTaskSubmissionEnabled = !!NEO::DebugManager.flags.EnableFlushTaskSubmission.get(); } diff --git a/level_zero/core/source/cmdqueue/cmdqueue_hw.inl b/level_zero/core/source/cmdqueue/cmdqueue_hw.inl index 81ad8667ba..34f14f0d49 100644 --- a/level_zero/core/source/cmdqueue/cmdqueue_hw.inl +++ b/level_zero/core/source/cmdqueue/cmdqueue_hw.inl @@ -347,9 +347,9 @@ template void CommandQueueHw::programFrontEnd(uint64_t scratchAddress, uint32_t perThreadScratchSpaceSize, NEO::LinearStream &cmdStream, NEO::StreamProperties &streamProperties) { UNRECOVERABLE_IF(csr == nullptr); auto &hwInfo = device->getHwInfo(); - auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); - auto engineGroupType = hwHelper.getEngineGroupType(csr->getOsContext().getEngineType(), - csr->getOsContext().getEngineUsage(), hwInfo); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto engineGroupType = gfxCoreHelper.getEngineGroupType(csr->getOsContext().getEngineType(), + csr->getOsContext().getEngineUsage(), hwInfo); auto pVfeState = NEO::PreambleHelper::getSpaceForVfeState(&cmdStream, hwInfo, engineGroupType); NEO::PreambleHelper::programVfeState(pVfeState, hwInfo, diff --git a/level_zero/core/source/context/context_imp.cpp b/level_zero/core/source/context/context_imp.cpp index 217c0cda60..43c58fa17e 100644 --- a/level_zero/core/source/context/context_imp.cpp +++ b/level_zero/core/source/context/context_imp.cpp @@ -926,10 +926,10 @@ ze_result_t ContextImp::createImage(ze_device_handle_t hDevice, bool ContextImp::isAllocationSuitableForCompression(const StructuresLookupTable &structuresLookupTable, Device &device, size_t allocSize) { auto &hwInfo = device.getHwInfo(); - auto &hwHelper = device.getHwHelper(); + auto &gfxCoreHelper = device.getGfxCoreHelper(); auto &l0GfxCoreHelper = device.getNEODevice()->getRootDeviceEnvironment().getHelper(); - if (!l0GfxCoreHelper.usmCompressionSupported(hwInfo) || !hwHelper.isBufferSizeSuitableForCompression(allocSize, hwInfo) || structuresLookupTable.uncompressedHint) { + if (!l0GfxCoreHelper.usmCompressionSupported(hwInfo) || !gfxCoreHelper.isBufferSizeSuitableForCompression(allocSize, hwInfo) || structuresLookupTable.uncompressedHint) { return false; } diff --git a/level_zero/core/source/device/device.h b/level_zero/core/source/device/device.h index 7697976152..0139f5d923 100644 --- a/level_zero/core/source/device/device.h +++ b/level_zero/core/source/device/device.h @@ -21,7 +21,7 @@ namespace NEO { class CommandStreamReceiver; class DebuggerL0; class Device; -class HwHelper; +class GfxCoreHelper; class MemoryManager; class SourceLevelDebugger; struct DeviceInfo; @@ -91,7 +91,7 @@ struct Device : _ze_device_handle_t { virtual uint32_t getMOCS(bool l3enabled, bool l1enabled) = 0; virtual uint32_t getMaxNumHwThreads() const = 0; - virtual NEO::HwHelper &getHwHelper() = 0; + virtual NEO::GfxCoreHelper &getGfxCoreHelper() = 0; bool isImplicitScalingCapable() const { return implicitScalingCapable; } diff --git a/level_zero/core/source/device/device_imp.cpp b/level_zero/core/source/device/device_imp.cpp index 9cc0c2d50e..617510f143 100644 --- a/level_zero/core/source/device/device_imp.cpp +++ b/level_zero/core/source/device/device_imp.cpp @@ -223,10 +223,10 @@ void DeviceImp::adjustCommandQueueDesc(uint32_t &ordinal, uint32_t &index) { auto nodeOrdinal = NEO::DebugManager.flags.NodeOrdinal.get(); if (nodeOrdinal != -1) { const NEO::HardwareInfo &hwInfo = neoDevice->getHardwareInfo(); - const NEO::HwHelper &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + const NEO::GfxCoreHelper &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto &engineGroups = getActiveDevice()->getRegularEngineGroups(); - auto engineGroupType = hwHelper.getEngineGroupType(static_cast(nodeOrdinal), NEO::EngineUsage::Regular, hwInfo); + auto engineGroupType = gfxCoreHelper.getEngineGroupType(static_cast(nodeOrdinal), NEO::EngineUsage::Regular, hwInfo); uint32_t currentEngineIndex = 0u; for (const auto &engine : engineGroups) { if (engine.engineGroupType == engineGroupType) { @@ -304,13 +304,13 @@ uint32_t DeviceImp::getCopyQueueGroupsFromSubDevice(uint32_t numberOfSubDeviceCo return numSubDeviceCopyEngineGroups; } - auto &coreHelper = this->neoDevice->getRootDeviceEnvironment().getHelper(); + auto &gfxCoreHelper = this->neoDevice->getRootDeviceEnvironment().getHelper(); auto &l0GfxCoreHelper = this->neoDevice->getRootDeviceEnvironment().getHelper(); uint32_t subDeviceQueueGroupsIter = 0; for (; subDeviceQueueGroupsIter < std::min(numSubDeviceCopyEngineGroups, numberOfSubDeviceCopyEngineGroupsRequested); subDeviceQueueGroupsIter++) { pCommandQueueGroupProperties[subDeviceQueueGroupsIter].flags = ZE_COMMAND_QUEUE_GROUP_PROPERTY_FLAG_COPY; - pCommandQueueGroupProperties[subDeviceQueueGroupsIter].maxMemoryFillPatternSize = coreHelper.getMaxFillPaternSizeForCopyEngine(); + pCommandQueueGroupProperties[subDeviceQueueGroupsIter].maxMemoryFillPatternSize = gfxCoreHelper.getMaxFillPaternSizeForCopyEngine(); l0GfxCoreHelper.setAdditionalGroupProperty(pCommandQueueGroupProperties[subDeviceQueueGroupsIter], this->subDeviceCopyEngineGroups[subDeviceQueueGroupsIter]); pCommandQueueGroupProperties[subDeviceQueueGroupsIter].numQueues = static_cast(this->subDeviceCopyEngineGroups[subDeviceQueueGroupsIter].engines.size()); @@ -334,7 +334,7 @@ ze_result_t DeviceImp::getCommandQueueGroupProperties(uint32_t *pCount, return ZE_RESULT_SUCCESS; } - auto &coreHelper = this->neoDevice->getRootDeviceEnvironment().getHelper(); + auto &gfxCoreHelper = this->neoDevice->getRootDeviceEnvironment().getHelper(); auto &l0GfxCoreHelper = this->neoDevice->getRootDeviceEnvironment().getHelper(); *pCount = std::min(totalEngineGroups, *pCount); @@ -354,7 +354,7 @@ ze_result_t DeviceImp::getCommandQueueGroupProperties(uint32_t *pCount, } if (engineGroups[i].engineGroupType == NEO::EngineGroupType::Copy) { pCommandQueueGroupProperties[i].flags = ZE_COMMAND_QUEUE_GROUP_PROPERTY_FLAG_COPY; - pCommandQueueGroupProperties[i].maxMemoryFillPatternSize = coreHelper.getMaxFillPaternSizeForCopyEngine(); + pCommandQueueGroupProperties[i].maxMemoryFillPatternSize = gfxCoreHelper.getMaxFillPaternSizeForCopyEngine(); } l0GfxCoreHelper.setAdditionalGroupProperty(pCommandQueueGroupProperties[i], engineGroups[i]); pCommandQueueGroupProperties[i].numQueues = static_cast(engineGroups[i].engines.size()); @@ -643,7 +643,7 @@ static constexpr ze_device_fp_flags_t defaultFpFlags = static_castneoDevice->getHardwareInfo(); const auto &deviceInfo = this->neoDevice->getDeviceInfo(); - auto &hwHelper = NEO::HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); std::string ilVersion = deviceInfo.ilVersion; size_t majorVersionPos = ilVersion.find('_'); @@ -683,7 +683,7 @@ ze_result_t DeviceImp::getKernelProperties(ze_device_module_properties_t *pKerne pKernelProperties->nativeKernelSupported.id[0] = 0; - processAdditionalKernelProperties(hwHelper, pKernelProperties); + processAdditionalKernelProperties(gfxCoreHelper, pKernelProperties); pKernelProperties->maxArgumentsSize = static_cast(this->neoDevice->getDeviceInfo().maxParameterSize); @@ -741,7 +741,7 @@ ze_result_t DeviceImp::getKernelProperties(ze_device_module_properties_t *pKerne ze_result_t DeviceImp::getProperties(ze_device_properties_t *pDeviceProperties) { const auto &deviceInfo = this->neoDevice->getDeviceInfo(); const auto &hardwareInfo = this->neoDevice->getHardwareInfo(); - auto &hwHelper = NEO::HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); pDeviceProperties->type = ZE_DEVICE_TYPE_GPU; @@ -769,7 +769,7 @@ ze_result_t DeviceImp::getProperties(ze_device_properties_t *pDeviceProperties) pDeviceProperties->numThreadsPerEU = deviceInfo.numThreadsPerEU; - pDeviceProperties->physicalEUSimdWidth = hwHelper.getMinimalSIMDSize(); + pDeviceProperties->physicalEUSimdWidth = gfxCoreHelper.getMinimalSIMDSize(); pDeviceProperties->numEUsPerSubslice = hardwareInfo.gtSystemInfo.MaxEuPerSubSlice; @@ -1042,12 +1042,12 @@ void *DeviceImp::getExecEnvironment() { return execEnvironment; } BuiltinFunctionsLib *DeviceImp::getBuiltinFunctionsLib() { return builtins.get(); } uint32_t DeviceImp::getMOCS(bool l3enabled, bool l1enabled) { - return getHwHelper().getMocsIndex(*getNEODevice()->getGmmHelper(), l3enabled, l1enabled) << 1; + return getGfxCoreHelper().getMocsIndex(*getNEODevice()->getGmmHelper(), l3enabled, l1enabled) << 1; } -NEO::HwHelper &DeviceImp::getHwHelper() { +NEO::GfxCoreHelper &DeviceImp::getGfxCoreHelper() { const auto &hardwareInfo = neoDevice->getHardwareInfo(); - return NEO::HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + return NEO::GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); } NEO::OSInterface &DeviceImp::getOsInterface() { return *neoDevice->getRootDeviceEnvironment().osInterface; } @@ -1103,22 +1103,22 @@ Device *Device::create(DriverHandle *driverHandle, NEO::Device *neoDevice, bool neoDevice->incRefInternal(); auto &hwInfo = neoDevice->getHardwareInfo(); - auto &coreHelper = neoDevice->getRootDeviceEnvironment().getHelper(); + auto &gfxCoreHelper = neoDevice->getRootDeviceEnvironment().getHelper(); device->execEnvironment = (void *)neoDevice->getExecutionEnvironment(); device->allocationsForReuse = std::make_unique(); - bool platformImplicitScaling = coreHelper.platformSupportsImplicitScaling(hwInfo); + bool platformImplicitScaling = gfxCoreHelper.platformSupportsImplicitScaling(hwInfo); device->implicitScalingCapable = NEO::ImplicitScalingHelper::isImplicitScalingEnabled(neoDevice->getDeviceBitfield(), platformImplicitScaling); device->metricContext = MetricDeviceContext::create(*device); device->builtins = BuiltinFunctionsLib::create( device, neoDevice->getBuiltIns()); device->cacheReservation = CacheReservation::create(*device); - device->maxNumHwThreads = NEO::HwHelper::getMaxThreadsForVfe(hwInfo); + device->maxNumHwThreads = NEO::GfxCoreHelper::getMaxThreadsForVfe(hwInfo); auto osInterface = neoDevice->getRootDeviceEnvironment().osInterface.get(); device->driverInfo.reset(NEO::DriverInfo::create(&hwInfo, osInterface)); - auto debugSurfaceSize = coreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); + auto debugSurfaceSize = gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); std::vector stateSaveAreaHeader; if (neoDevice->getDebugger() || neoDevice->getPreemptionMode() == NEO::PreemptionMode::MidThread) { @@ -1474,7 +1474,7 @@ void DeviceImp::setDebugSession(DebugSession *session) { } bool DeviceImp::toPhysicalSliceId(const NEO::TopologyMap &topologyMap, uint32_t &slice, uint32_t &subslice, uint32_t &deviceIndex) { auto hwInfo = neoDevice->getRootDeviceEnvironment().getHardwareInfo(); - uint32_t subDeviceCount = NEO::HwHelper::getSubDevicesCount(hwInfo); + uint32_t subDeviceCount = NEO::GfxCoreHelper::getSubDevicesCount(hwInfo); auto deviceBitfield = neoDevice->getDeviceBitfield(); if (topologyMap.size() == subDeviceCount && !isSubdevice) { diff --git a/level_zero/core/source/device/device_imp.h b/level_zero/core/source/device/device_imp.h index 2925ec7013..bb9f13dd89 100644 --- a/level_zero/core/source/device/device_imp.h +++ b/level_zero/core/source/device/device_imp.h @@ -70,7 +70,7 @@ struct DeviceImp : public Device { void *getExecEnvironment() override; BuiltinFunctionsLib *getBuiltinFunctionsLib() override; uint32_t getMOCS(bool l3enabled, bool l1enabled) override; - NEO::HwHelper &getHwHelper() override; + NEO::GfxCoreHelper &getGfxCoreHelper() override; const NEO::HardwareInfo &getHwInfo() const override; NEO::OSInterface &getOsInterface() override; uint32_t getPlatformInfo() const override; @@ -90,7 +90,7 @@ struct DeviceImp : public Device { const NEO::DeviceInfo &getDeviceInfo() const override; void activateMetricGroups() override; - void processAdditionalKernelProperties(NEO::HwHelper &hwHelper, ze_device_module_properties_t *pKernelProperties); + void processAdditionalKernelProperties(NEO::GfxCoreHelper &gfxCoreHelper, ze_device_module_properties_t *pKernelProperties); NEO::GraphicsAllocation *getDebugSurface() const override { return debugSurface; } void setDebugSurface(NEO::GraphicsAllocation *debugSurface) { this->debugSurface = debugSurface; }; ~DeviceImp() override; diff --git a/level_zero/core/source/device/device_imp_helper.cpp b/level_zero/core/source/device/device_imp_helper.cpp index f8e023e3d3..d1ac09d7d2 100644 --- a/level_zero/core/source/device/device_imp_helper.cpp +++ b/level_zero/core/source/device/device_imp_helper.cpp @@ -12,7 +12,7 @@ namespace L0 { -void DeviceImp::processAdditionalKernelProperties(NEO::HwHelper &hwHelper, ze_device_module_properties_t *pKernelProperties) { +void DeviceImp::processAdditionalKernelProperties(NEO::GfxCoreHelper &gfxCoreHelper, ze_device_module_properties_t *pKernelProperties) { } DeviceImp::CmdListCreateFunPtrT DeviceImp::getCmdListCreateFunc(const ze_command_list_desc_t *desc) { diff --git a/level_zero/core/source/event/event.cpp b/level_zero/core/source/event/event.cpp index 3849292541..cf515e390a 100644 --- a/level_zero/core/source/event/event.cpp +++ b/level_zero/core/source/event/event.cpp @@ -162,16 +162,16 @@ ze_result_t EventPoolImp::createEvent(const ze_event_desc_t *desc, ze_event_hand void EventPoolImp::initializeSizeParameters(uint32_t numDevices, ze_device_handle_t *deviceHandles, DriverHandleImp &driver, const NEO::HardwareInfo &hwInfo) { auto &l0GfxCoreHelper = L0GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - setEventAlignment(static_cast(hwHelper.getTimestampPacketAllocatorAlignment())); + setEventAlignment(static_cast(gfxCoreHelper.getTimestampPacketAllocatorAlignment())); bool useDynamicEventPackets = l0GfxCoreHelper.useDynamicEventPacketsCount(hwInfo); eventPackets = EventPacketsCount::eventPackets; if (useDynamicEventPackets) { eventPackets = driver.getEventMaxPacketCount(numDevices, deviceHandles); } - setEventSize(static_cast(alignUp(eventPackets * hwHelper.getSingleTimestampPacketSize(), eventAlignment))); + setEventSize(static_cast(alignUp(eventPackets * gfxCoreHelper.getSingleTimestampPacketSize(), eventAlignment))); eventPoolSize = alignUp(this->numEvents * eventSize, MemoryConstants::pageSize64k); } diff --git a/level_zero/core/source/event/event_impl.inl b/level_zero/core/source/event/event_impl.inl index 8d7fe4bb09..d509071705 100644 --- a/level_zero/core/source/event/event_impl.inl +++ b/level_zero/core/source/event/event_impl.inl @@ -386,7 +386,7 @@ ze_result_t EventImp::queryKernelTimestamp(ze_kernel_timestamp_result_ memcpy_s(&(timestampFieldForWriting), sizeof(uint64_t), static_cast(×tampFieldToCopy), sizeof(uint64_t)); }; - if (!NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps()) { + if (!NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps()) { eventTsSetFunc(contextStartTS, result.context.kernelStart); eventTsSetFunc(globalStartTS, result.global.kernelStart); eventTsSetFunc(contextEndTS, result.context.kernelEnd); diff --git a/level_zero/core/source/hw_helpers/l0_hw_helper_pvc_and_later.inl b/level_zero/core/source/hw_helpers/l0_hw_helper_pvc_and_later.inl index b2a83c89a4..112e579195 100644 --- a/level_zero/core/source/hw_helpers/l0_hw_helper_pvc_and_later.inl +++ b/level_zero/core/source/hw_helpers/l0_hw_helper_pvc_and_later.inl @@ -23,7 +23,7 @@ void L0GfxCoreHelperHw::getAttentionBitmaskForSingleThreads(const std::v const uint32_t numThreadsPerEu = (hwInfo.gtSystemInfo.ThreadCount / hwInfo.gtSystemInfo.EUCount); const uint32_t bytesPerEu = alignUp(numThreadsPerEu, 8) / 8; const uint32_t threadsSizePerSlice = numSubslicesPerSlice * numEuPerSubslice * bytesPerEu; - const uint32_t highestEnabledSlice = NEO::HwHelper::getHighestEnabledSlice(hwInfo); + const uint32_t highestEnabledSlice = NEO::GfxCoreHelper::getHighestEnabledSlice(hwInfo); bitmaskSize = std::max(highestEnabledSlice, hwInfo.gtSystemInfo.MaxSlicesSupported) * numSubslicesPerSlice * numEuPerSubslice * bytesPerEu; bitmask = std::make_unique(bitmaskSize); @@ -47,7 +47,7 @@ std::vector L0GfxCoreHelperHw::getThreadsFromAttenti const uint32_t bytesPerEu = alignUp(numThreadsPerEu, 8) / 8; const uint32_t threadsSizePerSlice = numSubslicesPerSlice * numEuPerSubslice * bytesPerEu; const uint32_t threadsSizePerSubSlice = numEuPerSubslice * bytesPerEu; - const uint32_t highestEnabledSlice = NEO::HwHelper::getHighestEnabledSlice(hwInfo); + const uint32_t highestEnabledSlice = NEO::GfxCoreHelper::getHighestEnabledSlice(hwInfo); UNRECOVERABLE_IF(bytesPerEu != 1); std::vector threads; diff --git a/level_zero/core/source/hw_helpers/l0_hw_helper_skl_to_icllp.inl b/level_zero/core/source/hw_helpers/l0_hw_helper_skl_to_icllp.inl index c111416626..c14ea09559 100644 --- a/level_zero/core/source/hw_helpers/l0_hw_helper_skl_to_icllp.inl +++ b/level_zero/core/source/hw_helpers/l0_hw_helper_skl_to_icllp.inl @@ -25,7 +25,7 @@ void L0GfxCoreHelperHw::getAttentionBitmaskForSingleThreads(const std::v const uint32_t numThreadsPerEu = (hwInfo.gtSystemInfo.ThreadCount / hwInfo.gtSystemInfo.EUCount); const uint32_t bytesPerEu = alignUp(numThreadsPerEu, 8) / 8; const uint32_t threadsSizePerSlice = numSubslicesPerSlice * numEuPerSubslice * bytesPerEu; - const uint32_t highestEnabledSlice = NEO::HwHelper::getHighestEnabledSlice(hwInfo); + const uint32_t highestEnabledSlice = NEO::GfxCoreHelper::getHighestEnabledSlice(hwInfo); bitmaskSize = std::max(highestEnabledSlice, hwInfo.gtSystemInfo.MaxSlicesSupported) * numSubslicesPerSlice * numEuPerSubslice * bytesPerEu; bitmask = std::make_unique(bitmaskSize); @@ -49,7 +49,7 @@ std::vector L0GfxCoreHelperHw::getThreadsFromAttenti const uint32_t bytesPerEu = alignUp(numThreadsPerEu, 8) / 8; const uint32_t threadsSizePerSlice = numSubslicesPerSlice * numEuPerSubslice * bytesPerEu; const uint32_t threadsSizePerSubSlice = numEuPerSubslice * bytesPerEu; - const uint32_t highestEnabledSlice = NEO::HwHelper::getHighestEnabledSlice(hwInfo); + const uint32_t highestEnabledSlice = NEO::GfxCoreHelper::getHighestEnabledSlice(hwInfo); UNRECOVERABLE_IF(bytesPerEu != 1); std::vector threads; diff --git a/level_zero/core/source/hw_helpers/l0_hw_helper_tgllp_to_dg2.inl b/level_zero/core/source/hw_helpers/l0_hw_helper_tgllp_to_dg2.inl index cfb4992643..b898bc35e3 100644 --- a/level_zero/core/source/hw_helpers/l0_hw_helper_tgllp_to_dg2.inl +++ b/level_zero/core/source/hw_helpers/l0_hw_helper_tgllp_to_dg2.inl @@ -21,7 +21,7 @@ void L0GfxCoreHelperHw::getAttentionBitmaskForSingleThreads(const std::v const uint32_t bytesPerEu = alignUp(numThreadsPerEu, 8) / 8; const uint32_t numEuPerSubslice = std::min(hwInfo.gtSystemInfo.MaxEuPerSubSlice, 8u); const uint32_t threadsSizePerSlice = numSubslicesPerSlice * numEuPerSubslice * bytesPerEu; - const uint32_t highestEnabledSlice = NEO::HwHelper::getHighestEnabledSlice(hwInfo); + const uint32_t highestEnabledSlice = NEO::GfxCoreHelper::getHighestEnabledSlice(hwInfo); const uint32_t eusPerRow = 4; const uint32_t numberOfRows = 2; @@ -63,7 +63,7 @@ std::vector L0GfxCoreHelperHw::getThreadsFromAttenti const uint32_t threadsSizePerSubSlice = numEuPerSubslice * bytesPerEu; const uint32_t eusPerRow = 4; const uint32_t numberOfRows = 2; - const uint32_t highestEnabledSlice = NEO::HwHelper::getHighestEnabledSlice(hwInfo); + const uint32_t highestEnabledSlice = NEO::GfxCoreHelper::getHighestEnabledSlice(hwInfo); UNRECOVERABLE_IF(bytesPerEu != 1); std::vector threads; diff --git a/level_zero/core/source/image/image_hw.inl b/level_zero/core/source/image/image_hw.inl index 39e93a2f99..2cd593b137 100644 --- a/level_zero/core/source/image/image_hw.inl +++ b/level_zero/core/source/image/image_hw.inl @@ -225,13 +225,13 @@ void ImageCoreFamily::copyRedescribedSurfaceStateToSSH(void *surf template bool ImageCoreFamily::isSuitableForCompression(const StructuresLookupTable &structuresLookupTable, const NEO::ImageInfo &imgInfo) { auto &hwInfo = device->getHwInfo(); - auto &loCoreHelper = device->getNEODevice()->getRootDeviceEnvironment().getHelper(); + auto &loGfxCoreHelper = device->getNEODevice()->getRootDeviceEnvironment().getHelper(); if (structuresLookupTable.uncompressedHint) { return false; } - return (loCoreHelper.imageCompressionSupported(hwInfo) && !imgInfo.linearStorage); + return (loGfxCoreHelper.imageCompressionSupported(hwInfo) && !imgInfo.linearStorage); } } // namespace L0 diff --git a/level_zero/core/source/kernel/kernel_imp.cpp b/level_zero/core/source/kernel/kernel_imp.cpp index 5282869f0c..07f0f4d578 100644 --- a/level_zero/core/source/kernel/kernel_imp.cpp +++ b/level_zero/core/source/kernel/kernel_imp.cpp @@ -394,7 +394,7 @@ ze_result_t KernelImp::suggestMaxCooperativeGroupCount(uint32_t *totalGroupCount dssCount = hardwareInfo.gtSystemInfo.SubSliceCount; } - auto &helper = module->getDevice()->getNEODevice()->getRootDeviceEnvironment().getHelper(); + auto &helper = module->getDevice()->getNEODevice()->getRootDeviceEnvironment().getHelper(); auto &descriptor = kernelImmData->getDescriptor(); auto availableThreadCount = helper.calculateAvailableThreadCount(hardwareInfo, descriptor.kernelAttributes.numGrfRequired); @@ -737,8 +737,8 @@ ze_result_t KernelImp::getProperties(ze_kernel_properties_t *pKernelProperties) reinterpret_cast(extendedProperties); preferredGroupSizeProperties->preferredMultiple = this->kernelImmData->getKernelInfo()->getMaxSimdSize(); - auto &hwHelper = NEO::HwHelper::get(this->module->getDevice()->getHwInfo().platform.eRenderCoreFamily); - if (hwHelper.isFusedEuDispatchEnabled(this->module->getDevice()->getHwInfo(), kernelDescriptor.kernelAttributes.flags.requiresDisabledEUFusion)) { + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(this->module->getDevice()->getHwInfo().platform.eRenderCoreFamily); + if (gfxCoreHelper.isFusedEuDispatchEnabled(this->module->getDevice()->getHwInfo(), kernelDescriptor.kernelAttributes.flags.requiresDisabledEUFusion)) { preferredGroupSizeProperties->preferredMultiple *= 2; } } @@ -990,13 +990,13 @@ void KernelImp::setDebugSurface() { } } void *KernelImp::patchBindlessSurfaceState(NEO::GraphicsAllocation *alloc, uint32_t bindless) { - auto &hwHelper = NEO::HwHelper::get(this->module->getDevice()->getHwInfo().platform.eRenderCoreFamily); - auto surfaceStateSize = hwHelper.getRenderSurfaceStateSize(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(this->module->getDevice()->getHwInfo().platform.eRenderCoreFamily); + auto surfaceStateSize = gfxCoreHelper.getRenderSurfaceStateSize(); NEO::BindlessHeapsHelper *bindlessHeapsHelper = this->module->getDevice()->getNEODevice()->getBindlessHeapsHelper(); auto ssInHeap = bindlessHeapsHelper->allocateSSInHeap(surfaceStateSize, alloc, NEO::BindlessHeapsHelper::GLOBAL_SSH); this->residencyContainer.push_back(ssInHeap.heapAllocation); auto patchLocation = ptrOffset(getCrossThreadData(), bindless); - auto patchValue = hwHelper.getBindlessSurfaceExtendedMessageDescriptorValue(static_cast(ssInHeap.surfaceStateOffset)); + auto patchValue = gfxCoreHelper.getBindlessSurfaceExtendedMessageDescriptorValue(static_cast(ssInHeap.surfaceStateOffset)); patchWithRequiredSize(const_cast(patchLocation), sizeof(patchValue), patchValue); return ssInHeap.ssPtr; } diff --git a/level_zero/core/source/kernel/patch_with_implicit_surface.inl b/level_zero/core/source/kernel/patch_with_implicit_surface.inl index 2c1082fdf4..feaa855a57 100644 --- a/level_zero/core/source/kernel/patch_with_implicit_surface.inl +++ b/level_zero/core/source/kernel/patch_with_implicit_surface.inl @@ -19,7 +19,7 @@ inline void patchWithImplicitSurface(ArrayRef crossThreadData, ArrayRef size_t sizeToPatch = allocation.getUnderlyingBufferSize(); auto &hwInfo = device.getHardwareInfo(); - auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto isDebuggerActive = device.isDebuggerActive() || device.getDebugger() != nullptr; NEO::EncodeSurfaceStateArgs args; args.outMemory = surfaceState; @@ -30,10 +30,10 @@ inline void patchWithImplicitSurface(ArrayRef crossThreadData, ArrayRef args.useGlobalAtomics = useGlobalAtomics; args.numAvailableDevices = device.getNumGenericSubDevices(); args.areMultipleSubDevicesInContext = args.numAvailableDevices > 1; - args.mocs = hwHelper.getMocsIndex(*args.gmmHelper, true, false) << 1; + args.mocs = gfxCoreHelper.getMocsIndex(*args.gmmHelper, true, false) << 1; args.implicitScaling = implicitScaling; args.isDebuggerActive = isDebuggerActive; - hwHelper.encodeBufferSurfaceState(args); + gfxCoreHelper.encodeBufferSurfaceState(args); } } diff --git a/level_zero/core/test/aub_tests/fixtures/aub_fixture.cpp b/level_zero/core/test/aub_tests/fixtures/aub_fixture.cpp index ba8ac626b7..79d389f3ee 100644 --- a/level_zero/core/test/aub_tests/fixtures/aub_fixture.cpp +++ b/level_zero/core/test/aub_tests/fixtures/aub_fixture.cpp @@ -41,14 +41,14 @@ void AUBFixtureL0::setUp(const NEO::HardwareInfo *hardwareInfo, bool debuggingEn ASSERT_NE(nullptr, hardwareInfo); const auto &hwInfo = *hardwareInfo; - auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto engineType = getChosenEngineType(hwInfo); const ::testing::TestInfo *const testInfo = ::testing::UnitTest::GetInstance()->current_test_info(); std::stringstream strfilename; strfilename << NEO::ApiSpecificConfig::getAubPrefixForSpecificApi(); - strfilename << testInfo->test_case_name() << "_" << testInfo->name() << "_" << hwHelper.getCsTraits(engineType).name; + strfilename << testInfo->test_case_name() << "_" << testInfo->name() << "_" << gfxCoreHelper.getCsTraits(engineType).name; executionEnvironment = new NEO::ExecutionEnvironment(); executionEnvironment->prepareRootDeviceEnvironments(1u); diff --git a/level_zero/core/test/unit_tests/fixtures/cmdlist_fixture.cpp b/level_zero/core/test/unit_tests/fixtures/cmdlist_fixture.cpp index 81b90b4cb6..7b0859a4ad 100644 --- a/level_zero/core/test/unit_tests/fixtures/cmdlist_fixture.cpp +++ b/level_zero/core/test/unit_tests/fixtures/cmdlist_fixture.cpp @@ -98,7 +98,7 @@ void ModuleMutableCommandListFixture::setUpImpl(uint32_t revision) { false, returnValue)); - engineGroupType = NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily).getEngineGroupType(neoDevice->getDefaultEngine().getEngineType(), neoDevice->getDefaultEngine().getEngineUsage(), device->getHwInfo()); + engineGroupType = NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily).getEngineGroupType(neoDevice->getDefaultEngine().getEngineType(), neoDevice->getDefaultEngine().getEngineUsage(), device->getHwInfo()); commandList.reset(whiteboxCast(CommandList::create(productFamily, device, engineGroupType, 0u, returnValue))); commandListImmediate.reset(whiteboxCast(CommandList::createImmediate(productFamily, device, &queueDesc, false, engineGroupType, returnValue))); diff --git a/level_zero/core/test/unit_tests/mocks/mock_device.h b/level_zero/core/test/unit_tests/mocks/mock_device.h index e6dafa482a..883a2234f7 100644 --- a/level_zero/core/test/unit_tests/mocks/mock_device.h +++ b/level_zero/core/test/unit_tests/mocks/mock_device.h @@ -57,7 +57,7 @@ struct Mock : public Device { ADDMETHOD_NOBASE(systemBarrier, ze_result_t, ZE_RESULT_SUCCESS, ()); // Runtime internal methods ADDMETHOD_NOBASE(getExecEnvironment, void *, nullptr, ()); - ADDMETHOD_NOBASE_REFRETURN(getHwHelper, NEO::HwHelper &, ()); + ADDMETHOD_NOBASE_REFRETURN(getGfxCoreHelper, NEO::GfxCoreHelper &, ()); ADDMETHOD_NOBASE(getBuiltinFunctionsLib, BuiltinFunctionsLib *, nullptr, ()); ADDMETHOD_CONST_NOBASE(getMaxNumHwThreads, uint32_t, 16u, ()); ADDMETHOD_NOBASE(activateMetricGroupsDeferred, ze_result_t, ZE_RESULT_SUCCESS, (uint32_t count, zet_metric_group_handle_t *phMetricGroups)); diff --git a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_2.cpp b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_2.cpp index 7b1e898e9d..16d6e024bc 100644 --- a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_2.cpp +++ b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_2.cpp @@ -1297,7 +1297,7 @@ using SupportedPlatforms = IsWithinProducts; HWTEST2_F(CommandListCreate, givenCommandListThenSshCorrectlyReserved, SupportedPlatforms) { MockCommandListHw commandList; commandList.initialize(device, NEO::EngineGroupType::Compute, 0u); - auto &helper = NEO::HwHelper::get(commandList.device->getHwInfo().platform.eRenderCoreFamily); + auto &helper = NEO::GfxCoreHelper::get(commandList.device->getHwInfo().platform.eRenderCoreFamily); auto size = helper.getRenderSurfaceStateSize(); EXPECT_EQ(commandList.getReserveSshSize(), size); } diff --git a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_5.cpp b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_5.cpp index 7ac1217f81..47122cf350 100644 --- a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_5.cpp +++ b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_5.cpp @@ -94,7 +94,7 @@ HWTEST2_F(AppendQueryKernelTimestamps, givenCommandListWhenAppendQueryKernelTime EXPECT_EQ(1u, commandList.cmdListHelper.groupSize[1]); EXPECT_EQ(1u, commandList.cmdListHelper.groupSize[2]); - EXPECT_EQ(NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps() ? 1u : 0u, commandList.cmdListHelper.useOnlyGlobalTimestamp); + EXPECT_EQ(NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps() ? 1u : 0u, commandList.cmdListHelper.useOnlyGlobalTimestamp); EXPECT_EQ(1u, commandList.cmdListHelper.threadGroupDimensions.groupCountX); EXPECT_EQ(1u, commandList.cmdListHelper.threadGroupDimensions.groupCountY); @@ -160,7 +160,7 @@ HWTEST2_F(AppendQueryKernelTimestamps, givenCommandListWhenAppendQueryKernelTime EXPECT_EQ(1u, commandList.cmdListHelper.groupSize[1]); EXPECT_EQ(1u, commandList.cmdListHelper.groupSize[2]); - EXPECT_EQ(NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps() ? 1u : 0u, commandList.cmdListHelper.useOnlyGlobalTimestamp); + EXPECT_EQ(NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps() ? 1u : 0u, commandList.cmdListHelper.useOnlyGlobalTimestamp); EXPECT_EQ(1u, commandList.cmdListHelper.threadGroupDimensions.groupCountX); EXPECT_EQ(1u, commandList.cmdListHelper.threadGroupDimensions.groupCountY); @@ -215,7 +215,7 @@ HWTEST2_F(AppendQueryKernelTimestamps, EXPECT_EQ(groupSizeY, commandList.cmdListHelper.groupSize[1]); EXPECT_EQ(groupSizeZ, commandList.cmdListHelper.groupSize[2]); - EXPECT_EQ(NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps() ? 1u : 0u, commandList.cmdListHelper.useOnlyGlobalTimestamp); + EXPECT_EQ(NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps() ? 1u : 0u, commandList.cmdListHelper.useOnlyGlobalTimestamp); EXPECT_EQ(static_cast(eventCount) / groupSizeX, commandList.cmdListHelper.threadGroupDimensions.groupCountX); EXPECT_EQ(1u, commandList.cmdListHelper.threadGroupDimensions.groupCountY); @@ -269,7 +269,7 @@ HWTEST2_F(AppendQueryKernelTimestamps, EXPECT_EQ(groupSizeY, commandList.cmdListHelper.groupSize[1]); EXPECT_EQ(groupSizeZ, commandList.cmdListHelper.groupSize[2]); - EXPECT_EQ(NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps() ? 1u : 0u, commandList.cmdListHelper.useOnlyGlobalTimestamp); + EXPECT_EQ(NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps() ? 1u : 0u, commandList.cmdListHelper.useOnlyGlobalTimestamp); EXPECT_EQ(static_cast(eventCount) / groupSizeX, commandList.cmdListHelper.threadGroupDimensions.groupCountX); EXPECT_EQ(1u, commandList.cmdListHelper.threadGroupDimensions.groupCountY); diff --git a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_6.cpp b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_6.cpp index 8a527a066a..5100037562 100644 --- a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_6.cpp +++ b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_6.cpp @@ -57,7 +57,7 @@ HWTEST2_F(MultiTileCopyEngineCommandListTest, GivenMultiTileDeviceWhenCreatingCo using CommandListExecuteImmediate = Test; HWTEST2_F(CommandListExecuteImmediate, whenExecutingCommandListImmediateWithFlushTaskThenRequiredStreamStateIsCorrectlyReported, IsAtLeastSkl) { - auto &hwHelper = NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily); auto &hwInfoConfig = *NEO::HwInfoConfig::get(device->getHwInfo().platform.eProductFamily); std::unique_ptr commandList; const ze_command_queue_desc_t desc = {}; @@ -81,7 +81,7 @@ HWTEST2_F(CommandListExecuteImmediate, whenExecutingCommandListImmediateWithFlus hwInfoConfig.fillFrontEndPropertiesSupportStructure(frontEndPropertiesSupport, device->getHwInfo()); int expectedDisableOverdispatch = frontEndPropertiesSupport.disableOverdispatch; - int32_t expectedIsCoherencyRequired = scmPropertiesSupport.coherencyRequired ? hwHelper.forceNonGpuCoherencyWA(true) : -1; + int32_t expectedIsCoherencyRequired = scmPropertiesSupport.coherencyRequired ? gfxCoreHelper.forceNonGpuCoherencyWA(true) : -1; int expectedLargeGrfMode = scmPropertiesSupport.largeGrfMode ? 1 : -1; int expectedThreadArbitrationPolicy = scmPropertiesSupport.threadArbitrationPolicy ? NEO::ThreadArbitrationPolicy::RoundRobin : -1; diff --git a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_append_launch_kernel_2.cpp b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_append_launch_kernel_2.cpp index 257ccc4b94..40d297dd48 100644 --- a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_append_launch_kernel_2.cpp +++ b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_append_launch_kernel_2.cpp @@ -1358,8 +1358,8 @@ HWTEST2_F(CommandListAppendLaunchKernel, GivenDebugToggleSetWhenUpdateStreamProp DebugManagerStateRestore restorer; DebugManager.flags.ForceThreadArbitrationPolicyProgrammingWithScm.set(1); - auto &hwHelper = NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily); - auto defaultThreadArbitrationPolicy = hwHelper.getDefaultThreadArbitrationPolicy(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily); + auto defaultThreadArbitrationPolicy = gfxCoreHelper.getDefaultThreadArbitrationPolicy(); auto nonDefaultThreadArbitrationPolicy = defaultThreadArbitrationPolicy + 1; Mock<::L0::Kernel> kernel; diff --git a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_append_launch_kernel_3.cpp b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_append_launch_kernel_3.cpp index d617c4cba1..0cf068d150 100644 --- a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_append_launch_kernel_3.cpp +++ b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_append_launch_kernel_3.cpp @@ -311,10 +311,10 @@ HWTEST2_F(CommandListAppendLaunchKernel, givenKernelUsingSyncBufferWhenAppendLau auto pCommandList = std::make_unique>>(); auto &hwInfoConfig = *HwInfoConfig::get(defaultHwInfo->platform.eProductFamily); - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); auto engineGroupType = NEO::EngineGroupType::Compute; if (hwInfoConfig.isCooperativeEngineSupported(*defaultHwInfo)) { - engineGroupType = hwHelper.getEngineGroupType(aub_stream::EngineType::ENGINE_CCS, EngineUsage::Cooperative, *defaultHwInfo); + engineGroupType = gfxCoreHelper.getEngineGroupType(aub_stream::EngineType::ENGINE_CCS, EngineUsage::Cooperative, *defaultHwInfo); } pCommandList->initialize(device, engineGroupType, 0u); auto result = pCommandList->appendLaunchCooperativeKernel(kernel.toHandle(), &groupCount, nullptr, 0, nullptr); diff --git a/level_zero/core/test/unit_tests/sources/cmdqueue/test_cmdqueue_3.cpp b/level_zero/core/test/unit_tests/sources/cmdqueue/test_cmdqueue_3.cpp index 6039b2c762..c91b9fc302 100644 --- a/level_zero/core/test/unit_tests/sources/cmdqueue/test_cmdqueue_3.cpp +++ b/level_zero/core/test/unit_tests/sources/cmdqueue/test_cmdqueue_3.cpp @@ -89,8 +89,8 @@ HWTEST2_F(CommandQueueProgramSBATest, whenCreatingCommandQueueThenItIsInitialize uint32_t alignedSize = 4096u; NEO::LinearStream child(commandQueue->commandStream.getSpace(alignedSize), alignedSize); - auto &hwHelper = HwHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily); - const bool isaInLocalMemory = !hwHelper.useSystemMemoryPlacementForISA(neoDevice->getHardwareInfo()); + auto &gfxCoreHelper = GfxCoreHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily); + const bool isaInLocalMemory = !gfxCoreHelper.useSystemMemoryPlacementForISA(neoDevice->getHardwareInfo()); commandQueue->programStateBaseAddress(0u, true, child, true); @@ -637,8 +637,8 @@ struct EngineInstancedDeviceExecuteTests : public ::testing::Test { hwInfo->gtSystemInfo.CCSInfo.NumberOfCCSEnabled = numCcs; hwInfo->featureTable.flags.ftrCCSNode = (numCcs > 0); - auto &coreHelper = rootDeviceEnvironment.getHelper(); - coreHelper.adjustDefaultEngineType(hwInfo); + auto &gfxCoreHelper = rootDeviceEnvironment.getHelper(); + gfxCoreHelper.adjustDefaultEngineType(hwInfo); if (!multiCcsDevice(*hwInfo, numCcs)) { return false; @@ -652,7 +652,7 @@ struct EngineInstancedDeviceExecuteTests : public ::testing::Test { } bool multiCcsDevice(const HardwareInfo &hwInfo, uint32_t expectedNumCcs) { - auto gpgpuEngines = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); + auto gpgpuEngines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); uint32_t numCcs = 0; diff --git a/level_zero/core/test/unit_tests/sources/debugger/active_debugger_fixture.h b/level_zero/core/test/unit_tests/sources/debugger/active_debugger_fixture.h index e414bf3568..7d9aea659d 100644 --- a/level_zero/core/test/unit_tests/sources/debugger/active_debugger_fixture.h +++ b/level_zero/core/test/unit_tests/sources/debugger/active_debugger_fixture.h @@ -39,7 +39,7 @@ struct ActiveDebuggerFixture { executionEnvironment->rootDeviceEnvironments[0]->builtins.reset(mockBuiltIns); executionEnvironment->rootDeviceEnvironments[0]->initGmm(); - auto isHexadecimalArrayPreferred = HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSipKernelAsHexadecimalArrayPreferred(); + auto isHexadecimalArrayPreferred = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSipKernelAsHexadecimalArrayPreferred(); if (isHexadecimalArrayPreferred) { MockSipData::useMockSip = true; } diff --git a/level_zero/core/test/unit_tests/sources/debugger/l0_debugger_fixture.h b/level_zero/core/test/unit_tests/sources/debugger/l0_debugger_fixture.h index 10faf2da59..08e8c03dd0 100644 --- a/level_zero/core/test/unit_tests/sources/debugger/l0_debugger_fixture.h +++ b/level_zero/core/test/unit_tests/sources/debugger/l0_debugger_fixture.h @@ -35,7 +35,7 @@ struct L0DebuggerFixture { hwInfo = *NEO::defaultHwInfo.get(); hwInfo.featureTable.flags.ftrLocalMemory = true; - auto isHexadecimalArrayPreferred = HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSipKernelAsHexadecimalArrayPreferred(); + auto isHexadecimalArrayPreferred = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSipKernelAsHexadecimalArrayPreferred(); if (isHexadecimalArrayPreferred) { MockSipData::useMockSip = true; } diff --git a/level_zero/core/test/unit_tests/sources/debugger/test_l0_debugger_1.cpp b/level_zero/core/test/unit_tests/sources/debugger/test_l0_debugger_1.cpp index 5742ad7de3..2dfac91855 100644 --- a/level_zero/core/test/unit_tests/sources/debugger/test_l0_debugger_1.cpp +++ b/level_zero/core/test/unit_tests/sources/debugger/test_l0_debugger_1.cpp @@ -44,7 +44,7 @@ TEST_F(L0DebuggerTest, givenL0DebuggerWhenGettingSipAllocationThenValidSipTypeIs ASSERT_NE(nullptr, systemRoutine); auto sipType = SipKernel::getSipKernelType(*neoDevice); - auto isHexadecimalArrayPreferred = HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSipKernelAsHexadecimalArrayPreferred(); + auto isHexadecimalArrayPreferred = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSipKernelAsHexadecimalArrayPreferred(); auto expectedSipAllocation = isHexadecimalArrayPreferred ? NEO::MockSipData::mockSipKernel->getSipAllocation() @@ -126,7 +126,7 @@ HWTEST_F(L0DebuggerPerContextAddressSpaceTest, givenDebuggingEnabledWhenCommandL EXPECT_EQ(0u, debugModeRegisterCount); EXPECT_EQ(0u, tdDebugControlRegisterCount); - if (!HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSipWANeeded(hwInfo)) { + if (!GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSipWANeeded(hwInfo)) { auto stateSipCmds = findAll(cmdList.begin(), cmdList.end()); ASSERT_EQ(1u, stateSipCmds.size()); diff --git a/level_zero/core/test/unit_tests/sources/debugger/test_l0_debugger_2.cpp b/level_zero/core/test/unit_tests/sources/debugger/test_l0_debugger_2.cpp index 2d912afc2e..42f830afbd 100644 --- a/level_zero/core/test/unit_tests/sources/debugger/test_l0_debugger_2.cpp +++ b/level_zero/core/test/unit_tests/sources/debugger/test_l0_debugger_2.cpp @@ -190,8 +190,8 @@ HWTEST2_P(L0DebuggerWithBlitterTest, givenImmediateCommandListWhenExecutingWithF ASSERT_TRUE(FamilyType::PARSE::parseCommandBuffer( cmdList, commandList->csr->getCS().getCpuBase(), commandList->csr->getCS().getUsed())); - const auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - if (hwHelper.isSipWANeeded(hwInfo)) { + const auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + if (gfxCoreHelper.isSipWANeeded(hwInfo)) { auto miLoadImm = findAll(cmdList.begin(), cmdList.end()); @@ -536,7 +536,7 @@ HWTEST_P(L0DebuggerWithBlitterTest, givenDebuggingEnabledWhenCommandListIsExecut EXPECT_EQ(0u, tdDebugControlRegisterCount); EXPECT_EQ(0u, globalSipFound); - if (!HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSipWANeeded(hwInfo)) { + if (!GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSipWANeeded(hwInfo)) { auto stateSipCmds = findAll(cmdList.begin(), cmdList.end()); if (device->getDevicePreemptionMode() != PreemptionMode::MidThread) { diff --git a/level_zero/core/test/unit_tests/sources/debugger/test_module_with_debug.cpp b/level_zero/core/test/unit_tests/sources/debugger/test_module_with_debug.cpp index 034524c09c..2a1901a84f 100644 --- a/level_zero/core/test/unit_tests/sources/debugger/test_module_with_debug.cpp +++ b/level_zero/core/test/unit_tests/sources/debugger/test_module_with_debug.cpp @@ -322,8 +322,8 @@ HWTEST_F(KernelDebugSurfaceTest, givenDebuggerAndBindfulKernelWhenAppendingKerne neoDevice->getExecutionEnvironment()->rootDeviceEnvironments[0]->debugger.reset(debugger); auto &hwInfo = *NEO::defaultHwInfo.get(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - auto maxDbgSurfaceSize = hwHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto maxDbgSurfaceSize = gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); auto debugSurface = neoDevice->getMemoryManager()->allocateGraphicsMemoryWithProperties( {device->getRootDeviceIndex(), true, maxDbgSurfaceSize, diff --git a/level_zero/core/test/unit_tests/sources/device/test_device.cpp b/level_zero/core/test/unit_tests/sources/device/test_device.cpp index 0a5ed692dc..60e68e642c 100644 --- a/level_zero/core/test/unit_tests/sources/device/test_device.cpp +++ b/level_zero/core/test/unit_tests/sources/device/test_device.cpp @@ -51,7 +51,7 @@ #include namespace NEO { -extern HwHelper *hwHelperFactory[IGFX_MAX_CORE]; +extern GfxCoreHelper *gfxCoreHelperFactory[IGFX_MAX_CORE]; } // namespace NEO namespace L0 { @@ -1228,10 +1228,10 @@ TEST_F(DeviceTest, givenCallToDevicePropertiesThenMaximumMemoryToBeAllocatedIsCo device->getProperties(&deviceProperties); EXPECT_EQ(deviceProperties.maxMemAllocSize, this->neoDevice->getDeviceInfo().maxMemAllocSize); - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); auto expectedSize = this->neoDevice->getDeviceInfo().globalMemSize; if (!this->neoDevice->areSharedSystemAllocationsAllowed()) { - expectedSize = std::min(expectedSize, hwHelper.getMaxMemAllocSize()); + expectedSize = std::min(expectedSize, gfxCoreHelper.getMaxMemAllocSize()); } EXPECT_EQ(deviceProperties.maxMemAllocSize, expectedSize); } @@ -1275,15 +1275,15 @@ TEST_F(InvalidExtensionTest, givenInvalidExtensionPropertiesDuringDeviceGetPrope HWTEST_F(DeviceTest, givenNodeOrdinalFlagWhenCallAdjustCommandQueueDescThenDescOrdinalAndDescIndexProperlySet) { DebugManagerStateRestore restore; - struct MockHwHelper : NEO::HwHelperHw { + struct MockGfxCoreHelper : NEO::GfxCoreHelperHw { EngineGroupType getEngineGroupType(aub_stream::EngineType engineType, EngineUsage engineUsage, const HardwareInfo &hwInfo) const override { return EngineGroupType::Compute; } }; auto hwInfo = *defaultHwInfo.get(); - MockHwHelper hwHelper{}; - VariableBackup hwHelperFactoryBackup{&NEO::hwHelperFactory[static_cast(hwInfo.platform.eRenderCoreFamily)]}; - hwHelperFactoryBackup = &hwHelper; + MockGfxCoreHelper gfxCoreHelper{}; + VariableBackup gfxCoreHelperFactoryBackup{&NEO::gfxCoreHelperFactory[static_cast(hwInfo.platform.eRenderCoreFamily)]}; + gfxCoreHelperFactoryBackup = &gfxCoreHelper; hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 2; auto nodeOrdinal = EngineHelpers::remapEngineTypeToHwSpecific(aub_stream::EngineType::ENGINE_CCS2, hwInfo); @@ -3572,7 +3572,7 @@ TEST_F(DeviceTest, givenValidDeviceWhenCallingReleaseResourcesThenResourcesRelea } HWTEST_F(DeviceTest, givenCooperativeDispatchSupportedWhenQueryingPropertiesFlagsThenCooperativeKernelsAreSupported) { - struct MockHwHelper : NEO::HwHelperHw { + struct MockGfxCoreHelper : NEO::GfxCoreHelperHw { bool isCooperativeDispatchSupported(const EngineGroupType engineGroupType, const HardwareInfo &hwInfo) const override { return isCooperativeDispatchSupportedValue; } @@ -3587,9 +3587,9 @@ HWTEST_F(DeviceTest, givenCooperativeDispatchSupportedWhenQueryingPropertiesFlag rootDeviceIndex); Mock deviceImp(neoMockDevice, neoMockDevice->getExecutionEnvironment()); - MockHwHelper hwHelper{}; - VariableBackup hwHelperFactoryBackup{&NEO::hwHelperFactory[static_cast(hwInfo.platform.eRenderCoreFamily)]}; - hwHelperFactoryBackup = &hwHelper; + MockGfxCoreHelper gfxCoreHelper{}; + VariableBackup gfxCoreHelperFactoryBackup{&NEO::gfxCoreHelperFactory[static_cast(hwInfo.platform.eRenderCoreFamily)]}; + gfxCoreHelperFactoryBackup = &gfxCoreHelper; uint32_t count = 0; ze_result_t res = deviceImp.getCommandQueueGroupProperties(&count, nullptr); @@ -3597,7 +3597,7 @@ HWTEST_F(DeviceTest, givenCooperativeDispatchSupportedWhenQueryingPropertiesFlag NEO::EngineGroupType engineGroupTypes[] = {NEO::EngineGroupType::RenderCompute, NEO::EngineGroupType::Compute}; for (auto isCooperativeDispatchSupported : ::testing::Bool()) { - hwHelper.isCooperativeDispatchSupportedValue = isCooperativeDispatchSupported; + gfxCoreHelper.isCooperativeDispatchSupportedValue = isCooperativeDispatchSupported; std::vector properties(count); res = deviceImp.getCommandQueueGroupProperties(&count, properties.data()); @@ -3945,7 +3945,7 @@ struct MultiSubDeviceFixture : public DeviceFixture { using MultiSubDeviceTest = Test>; TEST_F(MultiSubDeviceTest, GivenApiSupportAndLocalMemoryEnabledWhenDeviceContainsSubDevicesThenItIsImplicitScalingCapable) { - if (NEO::HwHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily).platformSupportsImplicitScaling(neoDevice->getHardwareInfo())) { + if (NEO::GfxCoreHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily).platformSupportsImplicitScaling(neoDevice->getHardwareInfo())) { EXPECT_TRUE(device->isImplicitScalingCapable()); EXPECT_EQ(neoDevice, deviceImp->getActiveDevice()); } else { diff --git a/level_zero/core/test/unit_tests/sources/event/test_event.cpp b/level_zero/core/test/unit_tests/sources/event/test_event.cpp index a9d078defb..6b23e11b51 100644 --- a/level_zero/core/test/unit_tests/sources/event/test_event.cpp +++ b/level_zero/core/test/unit_tests/sources/event/test_event.cpp @@ -162,7 +162,7 @@ HWTEST_F(EventPoolCreate, givenTimestampEventsThenEventSizeSufficientForAllKerne auto &hwInfo = device->getHwInfo(); auto &l0GfxCoreHelper = L0GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); uint32_t maxPacketCount = EventPacketsCount::maxKernelSplit * NEO::TimestampPacketSizeControl::preferredPacketCount; if (l0GfxCoreHelper.useDynamicEventPacketsCount(hwInfo)) { @@ -170,7 +170,7 @@ HWTEST_F(EventPoolCreate, givenTimestampEventsThenEventSizeSufficientForAllKerne } uint32_t packetsSize = maxPacketCount * static_cast(NEO::TimestampPackets::getSinglePacketSize()); - uint32_t kernelTimestampsSize = static_cast(alignUp(packetsSize, hwHelper.getTimestampPacketAllocatorAlignment())); + uint32_t kernelTimestampsSize = static_cast(alignUp(packetsSize, gfxCoreHelper.getTimestampPacketAllocatorAlignment())); EXPECT_EQ(kernelTimestampsSize, eventPool->getEventSize()); } @@ -1522,8 +1522,8 @@ HWTEST2_F(TimestampEventCreateMultiKernel, givenOverflowingTimeStampDataOnTwoKer ze_kernel_timestamp_result_t results; event->queryKernelTimestamp(&results); - auto &hwHelper = HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily); - if (hwHelper.useOnlyGlobalTimestamps() == false) { + auto &gfxCoreHelper = GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily); + if (gfxCoreHelper.useOnlyGlobalTimestamps() == false) { EXPECT_EQ(static_cast(maxTimeStampValue - 2), results.context.kernelStart); EXPECT_EQ(static_cast(maxTimeStampValue + 2), results.context.kernelEnd); } @@ -2006,7 +2006,7 @@ HWTEST_F(EventSizeTests, whenCreatingEventPoolThenUseCorrectSizeAndAlignment) { ze_result_t result = ZE_RESULT_SUCCESS; eventPool.reset(static_cast(EventPool::create(device->getDriverHandle(), context, 1, &hDevice, &eventPoolDesc, result))); EXPECT_EQ(ZE_RESULT_SUCCESS, result); - auto &hwHelper = device->getHwHelper(); + auto &gfxCoreHelper = device->getGfxCoreHelper(); auto &hwInfo = device->getHwInfo(); auto &l0GfxCoreHelper = L0GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); @@ -2016,7 +2016,7 @@ HWTEST_F(EventSizeTests, whenCreatingEventPoolThenUseCorrectSizeAndAlignment) { packetCount = l0GfxCoreHelper.getEventBaseMaxPacketCount(hwInfo); } - auto expectedAlignment = static_cast(hwHelper.getTimestampPacketAllocatorAlignment()); + auto expectedAlignment = static_cast(gfxCoreHelper.getTimestampPacketAllocatorAlignment()); auto singlePacketSize = TimestampPackets::getSinglePacketSize(); auto expectedSize = static_cast(alignUp(packetCount * singlePacketSize, expectedAlignment)); @@ -2041,9 +2041,9 @@ HWTEST_F(EventSizeTests, whenCreatingEventPoolThenUseCorrectSizeAndAlignment) { } HWTEST_F(EventSizeTests, givenDebugFlagwhenCreatingEventPoolThenUseCorrectSizeAndAlignment) { - auto &hwHelper = device->getHwHelper(); + auto &gfxCoreHelper = device->getGfxCoreHelper(); auto &hwInfo = device->getHwInfo(); - auto expectedAlignment = static_cast(hwHelper.getTimestampPacketAllocatorAlignment()); + auto expectedAlignment = static_cast(gfxCoreHelper.getTimestampPacketAllocatorAlignment()); auto &l0GfxCoreHelper = L0GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); @@ -2428,7 +2428,7 @@ struct EventDynamicPacketUseFixture : public DeviceFixture { void testAllDevices() { auto &hwInfo = device->getHwInfo(); auto &l0GfxCoreHelper = L0GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); ze_event_pool_desc_t eventPoolDesc = { ZE_STRUCTURE_TYPE_EVENT_POOL_DESC, @@ -2449,7 +2449,7 @@ struct EventDynamicPacketUseFixture : public DeviceFixture { EXPECT_EQ(expectedPoolMaxPackets, eventPoolMaxPackets); auto eventSize = eventPool->getEventSize(); - auto expectedEventSize = static_cast(alignUp(expectedPoolMaxPackets * hwHelper.getSingleTimestampPacketSize(), hwHelper.getTimestampPacketAllocatorAlignment())); + auto expectedEventSize = static_cast(alignUp(expectedPoolMaxPackets * gfxCoreHelper.getSingleTimestampPacketSize(), gfxCoreHelper.getTimestampPacketAllocatorAlignment())); EXPECT_EQ(expectedEventSize, eventSize); ze_event_desc_t eventDesc = { @@ -2472,7 +2472,7 @@ struct EventDynamicPacketUseFixture : public DeviceFixture { auto &hwInfo = device->getHwInfo(); auto &l0GfxCoreHelper = L0GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); ze_event_pool_desc_t eventPoolDesc = { ZE_STRUCTURE_TYPE_EVENT_POOL_DESC, @@ -2504,7 +2504,7 @@ struct EventDynamicPacketUseFixture : public DeviceFixture { EXPECT_EQ(expectedPoolMaxPackets, eventPoolMaxPackets); auto eventSize = eventPool->getEventSize(); - auto expectedEventSize = static_cast(alignUp(expectedPoolMaxPackets * hwHelper.getSingleTimestampPacketSize(), hwHelper.getTimestampPacketAllocatorAlignment())); + auto expectedEventSize = static_cast(alignUp(expectedPoolMaxPackets * gfxCoreHelper.getSingleTimestampPacketSize(), gfxCoreHelper.getTimestampPacketAllocatorAlignment())); EXPECT_EQ(expectedEventSize, eventSize); ze_event_desc_t eventDesc = { diff --git a/level_zero/core/test/unit_tests/sources/helper/heap_assigner_l0_tests.cpp b/level_zero/core/test/unit_tests/sources/helper/heap_assigner_l0_tests.cpp index 95e72b41a6..6562367602 100644 --- a/level_zero/core/test/unit_tests/sources/helper/heap_assigner_l0_tests.cpp +++ b/level_zero/core/test/unit_tests/sources/helper/heap_assigner_l0_tests.cpp @@ -50,7 +50,7 @@ struct MockMemoryManagerAllocationHelper : public MemoryManagerMock { } bool passedUseLocalMem = false; }; -TEST_F(AlocationHelperTests, GivenLinearStreamAllocTypeWhenUseExternalAllocatorForSshAndDshEnabledThenUseLocalMemEqualHwHelperValue) { +TEST_F(AlocationHelperTests, GivenLinearStreamAllocTypeWhenUseExternalAllocatorForSshAndDshEnabledThenUseLocalMemEqualGfxCoreHelperValue) { DebugManagerStateRestore dbgRestorer; DebugManager.flags.UseExternalAllocatorForSshAndDsh.set(true); AllocationData allocationData; diff --git a/level_zero/core/test/unit_tests/sources/image/test_image.cpp b/level_zero/core/test/unit_tests/sources/image/test_image.cpp index e03b32a366..5a1d1a43da 100644 --- a/level_zero/core/test/unit_tests/sources/image/test_image.cpp +++ b/level_zero/core/test/unit_tests/sources/image/test_image.cpp @@ -470,7 +470,7 @@ HWTEST2_F(ImageCreate, givenImageDescWhenFailImageAllocationThenProperErrorIsRet desc.format.z = ZE_IMAGE_FORMAT_SWIZZLE_1; desc.format.w = ZE_IMAGE_FORMAT_SWIZZLE_X; - auto isHexadecimalArrayPreferred = NEO::HwHelper::get(NEO::defaultHwInfo->platform.eRenderCoreFamily).isSipKernelAsHexadecimalArrayPreferred(); + auto isHexadecimalArrayPreferred = NEO::GfxCoreHelper::get(NEO::defaultHwInfo->platform.eRenderCoreFamily).isSipKernelAsHexadecimalArrayPreferred(); if (isHexadecimalArrayPreferred) { backupSipInitType = true; } diff --git a/level_zero/core/test/unit_tests/sources/kernel/test_kernel.cpp b/level_zero/core/test/unit_tests/sources/kernel/test_kernel.cpp index a50d78a662..00d024cd46 100644 --- a/level_zero/core/test/unit_tests/sources/kernel/test_kernel.cpp +++ b/level_zero/core/test/unit_tests/sources/kernel/test_kernel.cpp @@ -82,8 +82,8 @@ TEST_F(KernelInitTest, givenKernelToInitWhenItHasTooBigPrivateSizeThenOutOfMemor TEST_F(KernelInitTest, givenKernelToInitWhenItHasTooBigScratchSizeThenInvalidBinaryIsRetutned) { auto globalSize = device->getNEODevice()->getRootDevice()->getGlobalMemorySize(static_cast(device->getNEODevice()->getDeviceBitfield().to_ulong())); uint32_t perHwThreadPrivateMemorySizeRequested = (static_cast((globalSize + device->getNEODevice()->getDeviceInfo().computeUnitsUsedForScratch) / device->getNEODevice()->getDeviceInfo().computeUnitsUsedForScratch)) / 2; - auto &hwHelper = NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily); - uint32_t maxScratchSize = hwHelper.getMaxScratchSize(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily); + uint32_t maxScratchSize = gfxCoreHelper.getMaxScratchSize(); std::unique_ptr mockKernelImmData = std::make_unique(perHwThreadPrivateMemorySizeRequested, maxScratchSize + 1, 0x100); @@ -1329,8 +1329,8 @@ TEST_F(KernelPropertiesTests, whenPassingPreferredGroupSizeStructToGetProperties ze_result_t res = kernel->getProperties(&kernelProperties); EXPECT_EQ(ZE_RESULT_SUCCESS, res); - auto &hwHelper = NEO::HwHelper::get(module->getDevice()->getHwInfo().platform.eRenderCoreFamily); - if (hwHelper.isFusedEuDispatchEnabled(module->getDevice()->getHwInfo(), false)) { + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(module->getDevice()->getHwInfo().platform.eRenderCoreFamily); + if (gfxCoreHelper.isFusedEuDispatchEnabled(module->getDevice()->getHwInfo(), false)) { EXPECT_EQ(preferredGroupProperties.preferredMultiple, static_cast(kernel->getImmutableData()->getKernelInfo()->getMaxSimdSize()) * 2); } else { EXPECT_EQ(preferredGroupProperties.preferredMultiple, static_cast(kernel->getImmutableData()->getKernelInfo()->getMaxSimdSize())); @@ -1766,7 +1766,7 @@ TEST_F(KernelIsaTests, givenKernelInfoWhenInitializingImmutableDataWithIsaThenPa KernelImmutableData kernelImmutableData(device); kernelImmutableData.initialize(&kernelInfo, device, 0, nullptr, nullptr, false); auto graphicsAllocation = kernelImmutableData.getIsaGraphicsAllocation(); - auto &helper = device->getNEODevice()->getRootDeviceEnvironment().getHelper(); + auto &helper = device->getNEODevice()->getRootDeviceEnvironment().getHelper(); size_t isaPadding = helper.getPaddingForISAAllocation(); EXPECT_EQ(graphicsAllocation->getUnderlyingBufferSize(), kernelInfo.heapInfo.KernelHeapSize + isaPadding); } @@ -1805,11 +1805,11 @@ TEST_F(KernelImpPatchBindlessTest, GivenKernelImpWhenPatchBindlessOffsetCalledTh kernel.module = &mockModule; NEO::MockGraphicsAllocation alloc; uint32_t bindless = 0x40; - auto &hwHelper = NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily); - size_t size = hwHelper.getRenderSurfaceStateSize(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily); + size_t size = gfxCoreHelper.getRenderSurfaceStateSize(); auto expectedSsInHeap = device->getNEODevice()->getBindlessHeapsHelper()->allocateSSInHeap(size, &alloc, NEO::BindlessHeapsHelper::GLOBAL_SSH); auto patchLocation = ptrOffset(kernel.getCrossThreadData(), bindless); - auto patchValue = hwHelper.getBindlessSurfaceExtendedMessageDescriptorValue(static_cast(expectedSsInHeap.surfaceStateOffset)); + auto patchValue = gfxCoreHelper.getBindlessSurfaceExtendedMessageDescriptorValue(static_cast(expectedSsInHeap.surfaceStateOffset)); auto ssPtr = kernel.patchBindlessSurfaceState(&alloc, bindless); @@ -1837,8 +1837,8 @@ HWTEST2_F(KernelImpPatchBindlessTest, GivenKernelImpWhenSetSurfaceStateBindlessT neoDevice->getRootDeviceIndex(), neoDevice->getDeviceBitfield()); - auto &hwHelper = NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily); - size_t size = hwHelper.getRenderSurfaceStateSize(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily); + size_t size = gfxCoreHelper.getRenderSurfaceStateSize(); uint64_t gpuAddress = 0x2000; void *buffer = reinterpret_cast(gpuAddress); @@ -1872,8 +1872,8 @@ HWTEST2_F(KernelImpPatchBindlessTest, GivenKernelImpWhenSetSurfaceStateBindfulTh neoDevice->getRootDeviceIndex(), neoDevice->getDeviceBitfield()); - auto &hwHelper = NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily); - size_t size = hwHelper.getRenderSurfaceStateSize(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily); + size_t size = gfxCoreHelper.getRenderSurfaceStateSize(); uint64_t gpuAddress = 0x2000; void *buffer = reinterpret_cast(gpuAddress); @@ -1908,8 +1908,8 @@ HWTEST2_F(KernelImpL3CachingTests, GivenKernelImpWhenSetSurfaceStateWithUnaligne neoDevice->getNumGenericSubDevices() > 1, neoDevice->getRootDeviceIndex(), neoDevice->getDeviceBitfield()); - auto &hwHelper = NEO::HwHelper::get(device->getHwInfo().platform.eRenderCoreFamily); - size_t size = hwHelper.getRenderSurfaceStateSize(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(device->getHwInfo().platform.eRenderCoreFamily); + size_t size = gfxCoreHelper.getRenderSurfaceStateSize(); uint64_t gpuAddress = 0x2000; void *buffer = reinterpret_cast(0x20123); @@ -2234,8 +2234,8 @@ HWTEST2_F(SetKernelArg, givenImageAndBindlessKernelWhenSetArgImageThenCopySurfac imageArg.bindful = undefined; ze_image_desc_t desc = {}; desc.stype = ZE_STRUCTURE_TYPE_IMAGE_DESC; - auto &hwHelper = NEO::HwHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily); - auto surfaceStateSize = hwHelper.getRenderSurfaceStateSize(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto surfaceStateSize = gfxCoreHelper.getRenderSurfaceStateSize(); auto imageHW = std::make_unique>(); auto ret = imageHW->initialize(device, &desc); diff --git a/level_zero/core/test/unit_tests/sources/kernel/test_kernel_2.cpp b/level_zero/core/test/unit_tests/sources/kernel/test_kernel_2.cpp index 7b4dfad206..c974b85207 100644 --- a/level_zero/core/test/unit_tests/sources/kernel/test_kernel_2.cpp +++ b/level_zero/core/test/unit_tests/sources/kernel/test_kernel_2.cpp @@ -14,7 +14,7 @@ #include "level_zero/core/test/unit_tests/mocks/mock_kernel.h" #include "level_zero/core/test/unit_tests/mocks/mock_module.h" namespace NEO { -extern HwHelper *hwHelperFactory[IGFX_MAX_CORE]; +extern GfxCoreHelper *gfxCoreHelperFactory[IGFX_MAX_CORE]; } namespace L0 { #include "level_zero/core/source/kernel/patch_with_implicit_surface.inl" @@ -278,7 +278,7 @@ TEST_F(KernelImp, GivenNumChannelsZeroWhenSettingGroupSizeThenLocalIdsNotGenerat } HWTEST_F(KernelImp, givenSurfaceStateHeapWhenPatchWithImplicitSurfaceCalledThenIsDebuggerActiveIsSetCorrectly) { - struct MockHwHelper : NEO::HwHelperHw { + struct MockGfxCoreHelper : NEO::GfxCoreHelperHw { void encodeBufferSurfaceState(EncodeSurfaceStateArgs &args) override { savedSurfaceStateArgs = args; ++encodeBufferSurfaceStateCalled; @@ -286,10 +286,10 @@ HWTEST_F(KernelImp, givenSurfaceStateHeapWhenPatchWithImplicitSurfaceCalledThenI EncodeSurfaceStateArgs savedSurfaceStateArgs; size_t encodeBufferSurfaceStateCalled{0}; }; - MockHwHelper hwHelper{}; + MockGfxCoreHelper gfxCoreHelper{}; auto hwInfo = *defaultHwInfo.get(); - VariableBackup hwHelperFactoryBackup{&NEO::hwHelperFactory[static_cast(hwInfo.platform.eRenderCoreFamily)]}; - hwHelperFactoryBackup = &hwHelper; + VariableBackup gfxCoreHelperFactoryBackup{&NEO::gfxCoreHelperFactory[static_cast(hwInfo.platform.eRenderCoreFamily)]}; + gfxCoreHelperFactoryBackup = &gfxCoreHelper; using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; @@ -299,13 +299,13 @@ HWTEST_F(KernelImp, givenSurfaceStateHeapWhenPatchWithImplicitSurfaceCalledThenI uintptr_t ptrToPatchInCrossThreadData = 0; NEO::MockGraphicsAllocation globalBuffer; ArgDescPointer ptr; - ASSERT_EQ(hwHelper.encodeBufferSurfaceStateCalled, 0u); + ASSERT_EQ(gfxCoreHelper.encodeBufferSurfaceStateCalled, 0u); { patchWithImplicitSurface(crossThreadDataArrayRef, surfaceStateHeapArrayRef, ptrToPatchInCrossThreadData, globalBuffer, ptr, *neoDevice, false, false); - EXPECT_EQ(hwHelper.encodeBufferSurfaceStateCalled, 0u); + EXPECT_EQ(gfxCoreHelper.encodeBufferSurfaceStateCalled, 0u); } { ptr.bindful = 1; @@ -313,8 +313,8 @@ HWTEST_F(KernelImp, givenSurfaceStateHeapWhenPatchWithImplicitSurfaceCalledThenI ptrToPatchInCrossThreadData, globalBuffer, ptr, *neoDevice, false, false); - ASSERT_EQ(hwHelper.encodeBufferSurfaceStateCalled, 1u); - EXPECT_FALSE(hwHelper.savedSurfaceStateArgs.isDebuggerActive); + ASSERT_EQ(gfxCoreHelper.encodeBufferSurfaceStateCalled, 1u); + EXPECT_FALSE(gfxCoreHelper.savedSurfaceStateArgs.isDebuggerActive); } { neoDevice->setDebuggerActive(true); @@ -322,8 +322,8 @@ HWTEST_F(KernelImp, givenSurfaceStateHeapWhenPatchWithImplicitSurfaceCalledThenI ptrToPatchInCrossThreadData, globalBuffer, ptr, *neoDevice, false, false); - ASSERT_EQ(hwHelper.encodeBufferSurfaceStateCalled, 2u); - EXPECT_TRUE(hwHelper.savedSurfaceStateArgs.isDebuggerActive); + ASSERT_EQ(gfxCoreHelper.encodeBufferSurfaceStateCalled, 2u); + EXPECT_TRUE(gfxCoreHelper.savedSurfaceStateArgs.isDebuggerActive); } { neoDevice->setDebuggerActive(false); @@ -333,8 +333,8 @@ HWTEST_F(KernelImp, givenSurfaceStateHeapWhenPatchWithImplicitSurfaceCalledThenI ptrToPatchInCrossThreadData, globalBuffer, ptr, *neoDevice, false, false); - ASSERT_EQ(hwHelper.encodeBufferSurfaceStateCalled, 3u); - EXPECT_TRUE(hwHelper.savedSurfaceStateArgs.isDebuggerActive); + ASSERT_EQ(gfxCoreHelper.encodeBufferSurfaceStateCalled, 3u); + EXPECT_TRUE(gfxCoreHelper.savedSurfaceStateArgs.isDebuggerActive); } } @@ -366,7 +366,7 @@ class KernelImpSuggestMaxCooperativeGroupCountTests : public KernelImp { KernelImp::SetUp(); kernelInfo.kernelDescriptor = &kernelDescriptor; auto &hardwareInfo = device->getHwInfo(); - auto &helper = device->getNEODevice()->getRootDeviceEnvironment().getHelper(); + auto &helper = device->getNEODevice()->getRootDeviceEnvironment().getHelper(); availableThreadCount = helper.calculateAvailableThreadCount(hardwareInfo, numGrf); dssCount = hardwareInfo.gtSystemInfo.DualSubSliceCount; diff --git a/level_zero/core/test/unit_tests/sources/memory/test_memory.cpp b/level_zero/core/test/unit_tests/sources/memory/test_memory.cpp index 9d1bbcb8c2..5d572ada53 100644 --- a/level_zero/core/test/unit_tests/sources/memory/test_memory.cpp +++ b/level_zero/core/test/unit_tests/sources/memory/test_memory.cpp @@ -341,7 +341,7 @@ HWTEST2_F(CompressionMemoryTest, givenDeviceUsmWhenAllocatingThenEnableCompressi device->getNEODevice()->getRootDeviceEnvironment().getMutableHardwareInfo()->capabilityTable.ftrRenderCompressedBuffers = true; auto &hwInfo = device->getHwInfo(); auto &l0GfxCoreHelper = device->getNEODevice()->getRootDeviceEnvironment().getHelper(); - auto &hwHelper = NEO::HwHelperHw::get(); + auto &gfxCoreHelper = NEO::GfxCoreHelperHw::get(); // Default path { @@ -366,7 +366,7 @@ HWTEST2_F(CompressionMemoryTest, givenDeviceUsmWhenAllocatingThenEnableCompressi auto allocation = allocDeviceMem(2048); - EXPECT_EQ(hwHelper.isBufferSizeSuitableForCompression(2048, hwInfo), allocation->isCompressionEnabled()); + EXPECT_EQ(gfxCoreHelper.isBufferSizeSuitableForCompression(2048, hwInfo), allocation->isCompressionEnabled()); context->freeMem(ptr); @@ -453,7 +453,7 @@ HWTEST2_F(CompressionMemoryTest, givenDeviceUsmWhenAllocatingThenEnableCompressi auto allocation = allocDeviceMem(1); - if (!hwHelper.isBufferSizeSuitableForCompression(1, hwInfo)) { + if (!gfxCoreHelper.isBufferSizeSuitableForCompression(1, hwInfo)) { EXPECT_FALSE(allocation->isCompressionEnabled()); } diff --git a/level_zero/core/test/unit_tests/xe_hpc_core/test_cmdlist_xe_hpc_core.cpp b/level_zero/core/test/unit_tests/xe_hpc_core/test_cmdlist_xe_hpc_core.cpp index 16276813f8..3207e71999 100644 --- a/level_zero/core/test/unit_tests/xe_hpc_core/test_cmdlist_xe_hpc_core.cpp +++ b/level_zero/core/test/unit_tests/xe_hpc_core/test_cmdlist_xe_hpc_core.cpp @@ -974,7 +974,7 @@ HWTEST2_F(CreateCommandListXeHpcTest, givenXeHpcPlatformsWhenImmediateCommandLis auto &hwInfo = device->getHwInfo(); auto &defaultEngine = neoDevice->getDefaultEngine(); - auto engineGroupType = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily).getEngineGroupType(defaultEngine.getEngineType(), defaultEngine.getEngineUsage(), hwInfo); + auto engineGroupType = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getEngineGroupType(defaultEngine.getEngineType(), defaultEngine.getEngineUsage(), hwInfo); ze_command_queue_desc_t queueDesc{}; queueDesc.ordinal = 0u; diff --git a/level_zero/core/test/unit_tests/xe_hpg_core/dg2/test_module_dg2.cpp b/level_zero/core/test/unit_tests/xe_hpg_core/dg2/test_module_dg2.cpp index 1a4d73e587..7dd8e1aa25 100644 --- a/level_zero/core/test/unit_tests/xe_hpg_core/dg2/test_module_dg2.cpp +++ b/level_zero/core/test/unit_tests/xe_hpg_core/dg2/test_module_dg2.cpp @@ -27,8 +27,8 @@ HWTEST2_F(KernelDebugSurfaceDG2Test, givenDebuggerWhenKernelInitializeCalledThen neoDevice->getExecutionEnvironment()->rootDeviceEnvironments[0]->debugger.reset(debugger); auto &hwInfo = *NEO::defaultHwInfo.get(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - auto maxDbgSurfaceSize = hwHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto maxDbgSurfaceSize = gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); auto debugSurface = neoDevice->getMemoryManager()->allocateGraphicsMemoryWithProperties( {device->getRootDeviceIndex(), true, maxDbgSurfaceSize, @@ -83,8 +83,8 @@ HWTEST2_F(KernelDebugSurfaceDG2Test, givenNoDebuggerButDebuggerActiveSetWhenPatc neoDevice->getExecutionEnvironment()->rootDeviceEnvironments[0]->debugger.reset(debugger); auto &hwInfo = *NEO::defaultHwInfo.get(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - auto maxDbgSurfaceSize = hwHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto maxDbgSurfaceSize = gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); auto debugSurface = neoDevice->getMemoryManager()->allocateGraphicsMemoryWithProperties( {device->getRootDeviceIndex(), true, maxDbgSurfaceSize, diff --git a/level_zero/tools/source/debug/debug_session_imp.cpp b/level_zero/tools/source/debug/debug_session_imp.cpp index e4b432af3f..a0546e0588 100644 --- a/level_zero/tools/source/debug/debug_session_imp.cpp +++ b/level_zero/tools/source/debug/debug_session_imp.cpp @@ -1016,8 +1016,8 @@ ze_result_t DebugSessionImp::readSbaRegisters(EuThread::ThreadId threadId, uint3 uint64_t bindingTableBaseAddress = ((r0[4] >> 5) << 5) + sbaBuffer.SurfaceStateBaseAddress; uint64_t scratchSpaceBaseAddress = 0; - auto &hwHelper = NEO::HwHelper::get(connectedDevice->getNEODevice()->getHardwareInfo().platform.eRenderCoreFamily); - if (hwHelper.isScratchSpaceSurfaceStateAccessible()) { + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(connectedDevice->getNEODevice()->getHardwareInfo().platform.eRenderCoreFamily); + if (gfxCoreHelper.isScratchSpaceSurfaceStateAccessible()) { auto surfaceStateForScratch = ((r0[5] >> 10) << 6); if (surfaceStateForScratch > 0) { @@ -1031,10 +1031,10 @@ ze_result_t DebugSessionImp::readSbaRegisters(EuThread::ThreadId threadId, uint3 return ret; } - auto scratchSpacePTSize = hwHelper.getRenderSurfaceStatePitch(renderSurfaceState.data()); + auto scratchSpacePTSize = gfxCoreHelper.getRenderSurfaceStatePitch(renderSurfaceState.data()); auto threadOffset = getPerThreadScratchOffset(scratchSpacePTSize, threadId); auto gmmHelper = connectedDevice->getNEODevice()->getGmmHelper(); - auto scratchAllocationBase = gmmHelper->decanonize(hwHelper.getRenderSurfaceStateBaseAddress(renderSurfaceState.data())); + auto scratchAllocationBase = gmmHelper->decanonize(gfxCoreHelper.getRenderSurfaceStateBaseAddress(renderSurfaceState.data())); if (scratchAllocationBase != 0) { scratchSpaceBaseAddress = threadOffset + scratchAllocationBase; } diff --git a/level_zero/tools/source/metrics/metric_oa_query_imp.cpp b/level_zero/tools/source/metrics/metric_oa_query_imp.cpp index 969b74770b..e898ee2bf6 100644 --- a/level_zero/tools/source/metrics/metric_oa_query_imp.cpp +++ b/level_zero/tools/source/metrics/metric_oa_query_imp.cpp @@ -241,8 +241,8 @@ void MetricsLibrary::getSubDeviceClientOptions( bool MetricsLibrary::createContext() { auto &device = metricSource.getDevice(); - const auto &hwHelper = device.getHwHelper(); - const auto &asyncComputeEngines = hwHelper.getGpgpuEngineInstances(device.getHwInfo()); + const auto &gfxCoreHelper = device.getGfxCoreHelper(); + const auto &asyncComputeEngines = gfxCoreHelper.getGpgpuEngineInstances(device.getHwInfo()); ContextCreateData_1_0 createData = {}; ClientOptionsData_1_0 clientOptions[6] = {}; ClientData_1_0 clientData = {}; @@ -292,8 +292,8 @@ bool MetricsLibrary::createContext() { } ClientGen MetricsLibrary::getGenType(const uint32_t gen) const { - auto &hwHelper = NEO::HwHelper::get(static_cast(gen)); - return static_cast(hwHelper.getMetricsLibraryGenId()); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(static_cast(gen)); + return static_cast(gfxCoreHelper.getMetricsLibraryGenId()); } uint32_t MetricsLibrary::getGpuCommandsSize(CommandBufferData_1_0 &commandBuffer) { diff --git a/level_zero/tools/source/sysman/sysman_imp.cpp b/level_zero/tools/source/sysman/sysman_imp.cpp index d5e205a9f1..bb794d3e1b 100644 --- a/level_zero/tools/source/sysman/sysman_imp.cpp +++ b/level_zero/tools/source/sysman/sysman_imp.cpp @@ -82,7 +82,7 @@ void SysmanDeviceImp::updateSubDeviceHandlesLocally() { void SysmanDeviceImp::getSysmanDeviceInfo(zes_device_handle_t hDevice, uint32_t &subdeviceId, ze_bool_t &onSubdevice) { NEO::Device *neoDevice = Device::fromHandle(hDevice)->getNEODevice(); onSubdevice = static_cast(false); - if (NEO::HwHelper::getSubDevicesCount(&neoDevice->getHardwareInfo()) > 1) { + if (NEO::GfxCoreHelper::getSubDevicesCount(&neoDevice->getHardwareInfo()) > 1) { onSubdevice = static_cast(true); } if (!neoDevice->isSubDevice()) { // To get physical device or subdeviceIndex Index in case when the device does not support tile architecture is single tile device diff --git a/level_zero/tools/test/unit_tests/sources/debug/debug_session_common.cpp b/level_zero/tools/test/unit_tests/sources/debug/debug_session_common.cpp index 94bcd7b1da..d6bdadf438 100644 --- a/level_zero/tools/test/unit_tests/sources/debug/debug_session_common.cpp +++ b/level_zero/tools/test/unit_tests/sources/debug/debug_session_common.cpp @@ -32,8 +32,8 @@ void initStateSaveArea(std::vector &stateSaveArea, SIP::version version) { pStateSaveAreaHeader->regHeader.num_subslices_per_slice * pStateSaveAreaHeader->regHeader.num_eus_per_subslice * pStateSaveAreaHeader->regHeader.num_threads_per_eu * pStateSaveAreaHeader->regHeader.state_save_size); } else { auto &hwInfo = *NEO::defaultHwInfo.get(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - stateSaveArea.resize(hwHelper.getSipKernelMaxDbgSurfaceSize(hwInfo) + MemoryConstants::pageSize); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + stateSaveArea.resize(gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo) + MemoryConstants::pageSize); } memcpy(stateSaveArea.data(), pStateSaveAreaHeader, sizeof(*pStateSaveAreaHeader)); diff --git a/level_zero/tools/test/unit_tests/sources/debug/debug_session_tests.cpp b/level_zero/tools/test/unit_tests/sources/debug/debug_session_tests.cpp index 0d3a166038..b018dec79a 100644 --- a/level_zero/tools/test/unit_tests/sources/debug/debug_session_tests.cpp +++ b/level_zero/tools/test/unit_tests/sources/debug/debug_session_tests.cpp @@ -688,8 +688,8 @@ HWTEST2_F(DebugSessionTest, givenErrorFromReadMemoryWhenReadSbaRegistersCalledTh auto result = sessionMock->readSbaRegisters(EuThread::ThreadId(0, thread), 0, 9, sba); - auto &hwHelper = HwHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily); - EXPECT_TRUE(hwHelper.isScratchSpaceSurfaceStateAccessible()); + auto &gfxCoreHelper = GfxCoreHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily); + EXPECT_TRUE(gfxCoreHelper.isScratchSpaceSurfaceStateAccessible()); EXPECT_EQ(ZE_RESULT_ERROR_UNKNOWN, result); } @@ -1907,7 +1907,7 @@ TEST_F(DebugSessionRegistersAccessTest, WhenReadingSbaRegistersThenCorrectAddres session->stateSaveAreaHeader.resize(size); } - auto &hwHelper = HwHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily); ze_device_thread_t thread = {0, 0, 0, 0}; ze_device_thread_t thread1 = {0, 0, 0, 1}; EuThread::ThreadId threadId(0, thread); @@ -1946,11 +1946,11 @@ TEST_F(DebugSessionRegistersAccessTest, WhenReadingSbaRegistersThenCorrectAddres session->sba.SurfaceStateBaseAddress = sbaExpected[ZET_DEBUG_SBA_SURFACE_STATE_INTEL_GPU]; auto scratchAllocationBase = 0ULL; - if (hwHelper.isScratchSpaceSurfaceStateAccessible()) { + if (gfxCoreHelper.isScratchSpaceSurfaceStateAccessible()) { const uint32_t ptss = 128; - hwHelper.setRenderSurfaceStateForScratchResource(neoDevice->getRootDeviceEnvironment(), - &session->readMemoryBuffer[1 * (hwHelper.getRenderSurfaceStateSize() / sizeof(std::decay::type))], 1, scratchAllocationBase, 0, - ptss, nullptr, false, 6, false, true); + gfxCoreHelper.setRenderSurfaceStateForScratchResource(neoDevice->getRootDeviceEnvironment(), + &session->readMemoryBuffer[1 * (gfxCoreHelper.getRenderSurfaceStateSize() / sizeof(std::decay::type))], 1, scratchAllocationBase, 0, + ptss, nullptr, false, 6, false, true); r0Thread0[5] = 1 << 10; // first surface state } else { @@ -1965,11 +1965,11 @@ TEST_F(DebugSessionRegistersAccessTest, WhenReadingSbaRegistersThenCorrectAddres auto gmmHelper = neoDevice->getGmmHelper(); auto scratchAllocationBase2Canonized = gmmHelper->canonize(scratchAllocationBase2); - if (hwHelper.isScratchSpaceSurfaceStateAccessible()) { + if (gfxCoreHelper.isScratchSpaceSurfaceStateAccessible()) { const uint32_t ptss = 128; - hwHelper.setRenderSurfaceStateForScratchResource(neoDevice->getRootDeviceEnvironment(), - &session->readMemoryBuffer[1 * (hwHelper.getRenderSurfaceStateSize() / sizeof(std::decay::type))], 1, scratchAllocationBase, 0, - ptss, nullptr, false, 6, false, true); + gfxCoreHelper.setRenderSurfaceStateForScratchResource(neoDevice->getRootDeviceEnvironment(), + &session->readMemoryBuffer[1 * (gfxCoreHelper.getRenderSurfaceStateSize() / sizeof(std::decay::type))], 1, scratchAllocationBase, 0, + ptss, nullptr, false, 6, false, true); r0Thread0[5] = 1 << 10; // first surface state @@ -1994,11 +1994,11 @@ TEST_F(DebugSessionRegistersAccessTest, WhenReadingSbaRegistersThenCorrectAddres EXPECT_EQ(sbaExpected[ZET_DEBUG_SBA_BINDING_TABLE_INTEL_GPU], sba[ZET_DEBUG_SBA_BINDING_TABLE_INTEL_GPU]); EXPECT_EQ(sbaExpected[ZET_DEBUG_SBA_SCRATCH_SPACE_INTEL_GPU], sba[ZET_DEBUG_SBA_SCRATCH_SPACE_INTEL_GPU]); - if (hwHelper.isScratchSpaceSurfaceStateAccessible()) { + if (gfxCoreHelper.isScratchSpaceSurfaceStateAccessible()) { const uint32_t ptss = 128; - hwHelper.setRenderSurfaceStateForScratchResource(neoDevice->getRootDeviceEnvironment(), - &session->readMemoryBuffer[2 * (hwHelper.getRenderSurfaceStateSize() / sizeof(std::decay::type))], 1, scratchAllocationBase2Canonized, 0, - ptss, nullptr, false, 6, false, true); + gfxCoreHelper.setRenderSurfaceStateForScratchResource(neoDevice->getRootDeviceEnvironment(), + &session->readMemoryBuffer[2 * (gfxCoreHelper.getRenderSurfaceStateSize() / sizeof(std::decay::type))], 1, scratchAllocationBase2Canonized, 0, + ptss, nullptr, false, 6, false, true); r0Thread1[5] = 2 << 10; // second surface state @@ -2023,11 +2023,11 @@ TEST_F(DebugSessionRegistersAccessTest, WhenReadingSbaRegistersThenCorrectAddres EXPECT_EQ(sbaExpected[ZET_DEBUG_SBA_BINDING_TABLE_INTEL_GPU], sba[ZET_DEBUG_SBA_BINDING_TABLE_INTEL_GPU]); EXPECT_EQ(sbaExpected[ZET_DEBUG_SBA_SCRATCH_SPACE_INTEL_GPU], sba[ZET_DEBUG_SBA_SCRATCH_SPACE_INTEL_GPU]); - if (hwHelper.isScratchSpaceSurfaceStateAccessible()) { + if (gfxCoreHelper.isScratchSpaceSurfaceStateAccessible()) { const uint32_t ptss = 0; - hwHelper.setRenderSurfaceStateForScratchResource(neoDevice->getRootDeviceEnvironment(), - &session->readMemoryBuffer[0], 1, 0xdeadbeef, 0, - ptss, nullptr, false, 6, false, true); + gfxCoreHelper.setRenderSurfaceStateForScratchResource(neoDevice->getRootDeviceEnvironment(), + &session->readMemoryBuffer[0], 1, 0xdeadbeef, 0, + ptss, nullptr, false, 6, false, true); r0Thread1[5] = 0; // Surface state at index 0 } else { diff --git a/level_zero/tools/test/unit_tests/sources/debug/linux/test_debug_api_linux.cpp b/level_zero/tools/test/unit_tests/sources/debug/linux/test_debug_api_linux.cpp index aea6c26691..71e5a047ae 100644 --- a/level_zero/tools/test/unit_tests/sources/debug/linux/test_debug_api_linux.cpp +++ b/level_zero/tools/test/unit_tests/sources/debug/linux/test_debug_api_linux.cpp @@ -6222,8 +6222,8 @@ struct DebugApiRegistersAccessFixture : public DebugApiLinuxFixture { session = std::make_unique(zet_debug_config_t{}, device, 0); session->clientHandle = MockDebugSessionLinux::mockClientHandle; session->clientHandleToConnection[MockDebugSessionLinux::mockClientHandle]->contextsCreated[ctxHandle].vm = vmHandle; - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - maxDbgSurfaceSize = hwHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + maxDbgSurfaceSize = gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); session->clientHandleToConnection[MockDebugSessionLinux::mockClientHandle]->vmToContextStateSaveAreaBindInfo[vmHandle] = {stateSaveAreaGpuVa, maxDbgSurfaceSize}; session->allThreadsStopped = true; session->allThreads[stoppedThreadId]->stopThread(1u); @@ -6632,8 +6632,8 @@ static_assert(64 == sizeof(MockRenderSurfaceState)); void sbaInit(std::vector &stateSaveArea, uint64_t stateSaveAreaGpuVa, SbaTrackedAddresses &sba, uint32_t r0[8]) { auto &hwInfo = *NEO::defaultHwInfo.get(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - auto maxDbgSurfaceSize = hwHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto maxDbgSurfaceSize = gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); uint64_t surfaceStateBaseAddress = stateSaveAreaGpuVa + maxDbgSurfaceSize + sizeof(SbaTrackedAddresses); uint32_t renderSurfaceStateOffset = 256; r0[4] = 0xAAAAAAAA; @@ -6729,8 +6729,8 @@ TEST_F(DebugApiRegistersAccessTest, GivenReadSbaRegistersCalledThenSbaRegistersA uint64_t expectedBindingTableBaseAddress = ((r0[4] >> 5) << 5) + sbaExpected.SurfaceStateBaseAddress; uint64_t expectedScratchSpaceBaseAddress = 0; - auto &hwHelper = HwHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily); - if (hwHelper.isScratchSpaceSurfaceStateAccessible()) { + auto &gfxCoreHelper = GfxCoreHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily); + if (gfxCoreHelper.isScratchSpaceSurfaceStateAccessible()) { expectedScratchSpaceBaseAddress = 0xBA5EBA5E; } else { expectedScratchSpaceBaseAddress = ((r0[5] >> 10) << 10) + sbaExpected.GeneralStateBaseAddress; @@ -6765,8 +6765,8 @@ TEST_F(DebugApiRegistersAccessTest, GivenScarcthPointerAndZeroAddressInSurfaceSt r0[4] = 0xAAAAAAAA; r0[5] = ((renderSurfaceStateOffset) >> 6) << 10; - auto &hwHelper = HwHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily); - if (!hwHelper.isScratchSpaceSurfaceStateAccessible()) { + auto &gfxCoreHelper = GfxCoreHelper::get(neoDevice->getHardwareInfo().platform.eRenderCoreFamily); + if (!gfxCoreHelper.isScratchSpaceSurfaceStateAccessible()) { r0[5] = 0; } sbaExpected.SurfaceStateBaseAddress = surfaceStateBaseAddress; diff --git a/opencl/source/api/api.cpp b/opencl/source/api/api.cpp index 4e9b78416f..9692631fdb 100644 --- a/opencl/source/api/api.cpp +++ b/opencl/source/api/api.cpp @@ -6044,10 +6044,10 @@ cl_int CL_API_CALL clEnqueueNDCountKernelINTEL(cl_command_queue commandQueue, } auto &hardwareInfo = device.getHardwareInfo(); - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - auto engineGroupType = hwHelper.getEngineGroupType(pCommandQueue->getGpgpuEngine().getEngineType(), - pCommandQueue->getGpgpuEngine().getEngineUsage(), hardwareInfo); - if (!hwHelper.isCooperativeDispatchSupported(engineGroupType, hardwareInfo)) { + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto engineGroupType = gfxCoreHelper.getEngineGroupType(pCommandQueue->getGpgpuEngine().getEngineType(), + pCommandQueue->getGpgpuEngine().getEngineUsage(), hardwareInfo); + if (!gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, hardwareInfo)) { retVal = CL_INVALID_COMMAND_QUEUE; return retVal; } diff --git a/opencl/source/cl_device/cl_device_caps.cpp b/opencl/source/cl_device/cl_device_caps.cpp index 6e6e2e5c4e..51bb8e69d4 100644 --- a/opencl/source/cl_device/cl_device_caps.cpp +++ b/opencl/source/cl_device/cl_device_caps.cpp @@ -65,7 +65,7 @@ void ClDevice::setupFp64Flags() { void ClDevice::initializeCaps() { auto &hwInfo = getHardwareInfo(); auto &productHelper = getRootDeviceEnvironment().getHelper(); - auto &coreHelper = getRootDeviceEnvironment().getHelper(); + auto &gfxCoreHelper = getRootDeviceEnvironment().getHelper(); auto &sharedDeviceInfo = getSharedDeviceInfo(); deviceExtensions.clear(); deviceExtensions.append(deviceExtensionsList); @@ -136,7 +136,7 @@ void ClDevice::initializeCaps() { auto simdSizeUsed = DebugManager.flags.UseMaxSimdSizeToDeduceMaxWorkgroupSize.get() ? CommonConstants::maximalSimdSize - : coreHelper.getMinimalSIMDSize(); + : gfxCoreHelper.getMinimalSIMDSize(); // calculate a maximum number of subgroups in a workgroup (for the required SIMD size) deviceInfo.maxNumOfSubGroups = static_cast(sharedDeviceInfo.maxWorkGroupSize / simdSizeUsed); @@ -223,7 +223,7 @@ void ClDevice::initializeCaps() { deviceExtensions += "cl_khr_pci_bus_info "; } - deviceExtensions += coreHelper.getExtensions(hwInfo); + deviceExtensions += gfxCoreHelper.getExtensions(hwInfo); deviceInfo.deviceExtensions = deviceExtensions.c_str(); std::vector exposedBuiltinKernelsVector; @@ -247,7 +247,7 @@ void ClDevice::initializeCaps() { deviceInfo.deviceType = CL_DEVICE_TYPE_GPU; deviceInfo.endianLittle = 1; - deviceInfo.hostUnifiedMemory = (false == coreHelper.isLocalMemoryEnabled(hwInfo)); + deviceInfo.hostUnifiedMemory = (false == gfxCoreHelper.isLocalMemoryEnabled(hwInfo)); deviceInfo.deviceAvailable = CL_TRUE; deviceInfo.compilerAvailable = CL_TRUE; deviceInfo.parentDevice = nullptr; @@ -321,11 +321,11 @@ void ClDevice::initializeCaps() { deviceInfo.localMemType = CL_LOCAL; - deviceInfo.image3DMaxWidth = coreHelper.getMax3dImageWidthOrHeight(); - deviceInfo.image3DMaxHeight = coreHelper.getMax3dImageWidthOrHeight(); + deviceInfo.image3DMaxWidth = gfxCoreHelper.getMax3dImageWidthOrHeight(); + deviceInfo.image3DMaxHeight = gfxCoreHelper.getMax3dImageWidthOrHeight(); // cl_khr_image2d_from_buffer - deviceInfo.imagePitchAlignment = coreHelper.getPitchAlignmentForImage(this->getRootDeviceEnvironment()); + deviceInfo.imagePitchAlignment = gfxCoreHelper.getPitchAlignmentForImage(this->getRootDeviceEnvironment()); deviceInfo.imageBaseAddressAlignment = 4; deviceInfo.queueOnHostProperties = CL_QUEUE_PROFILING_ENABLE | CL_QUEUE_OUT_OF_ORDER_EXEC_MODE_ENABLE; @@ -388,7 +388,7 @@ void ClDevice::initializeCaps() { deviceInfo.globalVariablePreferredTotalSize = ocl21FeaturesEnabled ? static_cast(sharedDeviceInfo.maxMemAllocSize) : 0; deviceInfo.planarYuvMaxWidth = 16384; - deviceInfo.planarYuvMaxHeight = coreHelper.getPlanarYuvMaxHeight(); + deviceInfo.planarYuvMaxHeight = gfxCoreHelper.getPlanarYuvMaxHeight(); deviceInfo.vmeAvcSupportsTextureSampler = hwInfo.capabilityTable.ftrSupportsVmeAvcTextureSampler; if (hwInfo.capabilityTable.supportsVme) { @@ -403,7 +403,7 @@ void ClDevice::initializeCaps() { deviceInfo.preferredLocalAtomicAlignment = MemoryConstants::cacheLineSize; deviceInfo.preferredPlatformAtomicAlignment = MemoryConstants::cacheLineSize; - deviceInfo.preferredWorkGroupSizeMultiple = coreHelper.isFusedEuDispatchEnabled(hwInfo, false) + deviceInfo.preferredWorkGroupSizeMultiple = gfxCoreHelper.isFusedEuDispatchEnabled(hwInfo, false) ? CommonConstants::maximalSimdSize * 2 : CommonConstants::maximalSimdSize; diff --git a/opencl/source/command_queue/cl_local_work_size.cpp b/opencl/source/command_queue/cl_local_work_size.cpp index 16efe34a2f..727c3177ba 100644 --- a/opencl/source/command_queue/cl_local_work_size.cpp +++ b/opencl/source/command_queue/cl_local_work_size.cpp @@ -26,10 +26,10 @@ Vec3 computeWorkgroupSize(const DispatchInfo &dispatchInfo) { if (kernel != nullptr) { auto &device = dispatchInfo.getClDevice(); const auto &hwInfo = device.getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); if (DebugManager.flags.EnableComputeWorkSizeND.get()) { WorkSizeInfo wsInfo = createWorkSizeInfoFromDispatchInfo(dispatchInfo); - if (wsInfo.slmTotalSize == 0 && !wsInfo.hasBarriers && !wsInfo.imgUsed && hwHelper.preferSmallWorkgroupSizeForKernel(kernel->getKernelInfo().heapInfo.KernelUnpaddedSize, hwInfo) && + if (wsInfo.slmTotalSize == 0 && !wsInfo.hasBarriers && !wsInfo.imgUsed && gfxCoreHelper.preferSmallWorkgroupSizeForKernel(kernel->getKernelInfo().heapInfo.KernelUnpaddedSize, hwInfo) && ((dispatchInfo.getDim() == 1) && (dispatchInfo.getGWS().x % wsInfo.simdSize * 2 == 0))) { wsInfo.maxWorkGroupSize = wsInfo.simdSize * 2; } diff --git a/opencl/source/command_queue/command_queue.cpp b/opencl/source/command_queue/command_queue.cpp index 75faca9849..67bcb5498c 100644 --- a/opencl/source/command_queue/command_queue.cpp +++ b/opencl/source/command_queue/command_queue.cpp @@ -84,11 +84,11 @@ CommandQueue::CommandQueue(Context *context, ClDevice *device, const cl_queue_pr if (device) { auto &hwInfo = device->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto hwInfoConfig = HwInfoConfig::get(hwInfo.platform.eProductFamily); bcsAllowed = hwInfoConfig->isBlitterFullySupported(hwInfo) && - hwHelper.isSubDeviceEngineSupported(hwInfo, device->getDeviceBitfield(), aub_stream::EngineType::ENGINE_BCS); + gfxCoreHelper.isSubDeviceEngineSupported(hwInfo, device->getDeviceBitfield(), aub_stream::EngineType::ENGINE_BCS); if (bcsAllowed || device->getDefaultEngine().commandStreamReceiver->peekTimestampPacketWriteEnabled()) { timestampPacketContainer = std::make_unique(); @@ -153,9 +153,9 @@ void CommandQueue::initializeGpgpu() const { std::lock_guard lock(mutex); if (gpgpuEngine == nullptr) { auto &hwInfo = device->getDevice().getHardwareInfo(); - auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - auto engineRoundRobinAvailable = hwHelper.isAssignEngineRoundRobinSupported(hwInfo) && + auto engineRoundRobinAvailable = gfxCoreHelper.isAssignEngineRoundRobinSupported(hwInfo) && this->isAssignEngineRoundRobinEnabled(); if (DebugManager.flags.EnableCmdQRoundRobindEngineAssign.get() != -1) { @@ -305,12 +305,12 @@ CommandStreamReceiver &CommandQueue::selectCsrForBuiltinOperation(const CsrSelec void CommandQueue::constructBcsEngine(bool internalUsage) { if (bcsAllowed && !bcsInitialized) { auto &hwInfo = device->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto &neoDevice = device->getNearestGenericSubDevice(0)->getDevice(); auto &selectorCopyEngine = neoDevice.getSelectorCopyEngine(); auto bcsEngineType = EngineHelpers::getBcsEngineType(hwInfo, device->getDeviceBitfield(), selectorCopyEngine, internalUsage); auto bcsIndex = EngineHelpers::getBcsIndex(bcsEngineType); - auto engineUsage = (internalUsage && hwHelper.preferInternalBcsEngine()) ? EngineUsage::Internal : EngineUsage::Regular; + auto engineUsage = (internalUsage && gfxCoreHelper.preferInternalBcsEngine()) ? EngineUsage::Internal : EngineUsage::Regular; bcsEngines[bcsIndex] = neoDevice.tryGetEngine(bcsEngineType, engineUsage); bcsEngineTypes.push_back(bcsEngineType); bcsInitialized = true; @@ -856,8 +856,8 @@ cl_uint CommandQueue::getQueueFamilyIndex() const { return queueFamilyIndex; } else { const auto &hwInfo = device->getHardwareInfo(); - const auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - const auto engineGroupType = hwHelper.getEngineGroupType(getGpgpuEngine().getEngineType(), getGpgpuEngine().getEngineUsage(), hwInfo); + const auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + const auto engineGroupType = gfxCoreHelper.getEngineGroupType(getGpgpuEngine().getEngineType(), getGpgpuEngine().getEngineUsage(), hwInfo); const auto familyIndex = device->getDevice().getEngineGroupIndexFromEngineGroupType(engineGroupType); return static_cast(familyIndex); } @@ -1096,9 +1096,9 @@ void CommandQueue::processProperties(const cl_queue_properties *properties) { if (nodeOrdinal != -1) { int currentEngineIndex = 0; const HardwareInfo &hwInfo = getDevice().getHardwareInfo(); - const HwHelper &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + const GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - auto engineGroupType = hwHelper.getEngineGroupType(static_cast(nodeOrdinal), EngineUsage::Regular, hwInfo); + auto engineGroupType = gfxCoreHelper.getEngineGroupType(static_cast(nodeOrdinal), EngineUsage::Regular, hwInfo); selectedQueueFamilyIndex = static_cast(getDevice().getEngineGroupIndexFromEngineGroupType(engineGroupType)); const auto &engines = getDevice().getRegularEngineGroups()[selectedQueueFamilyIndex].engines; for (const auto &engine : engines) { @@ -1136,8 +1136,8 @@ void CommandQueue::processProperties(const cl_queue_properties *properties) { void CommandQueue::overrideEngine(aub_stream::EngineType engineType, EngineUsage engineUsage) { const HardwareInfo &hwInfo = getDevice().getHardwareInfo(); - const HwHelper &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - const EngineGroupType engineGroupType = hwHelper.getEngineGroupType(engineType, engineUsage, hwInfo); + const GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + const EngineGroupType engineGroupType = gfxCoreHelper.getEngineGroupType(engineType, engineUsage, hwInfo); const bool isEngineCopyOnly = EngineHelper::isCopyOnlyEngineType(engineGroupType); if (isEngineCopyOnly) { @@ -1184,10 +1184,10 @@ void CommandQueue::assignDataToOverwrittenBcsNode(TagNodeBase *node) { } bool CommandQueue::isWaitForTimestampsEnabled() const { - const auto &hwHelper = HwHelper::get(getDevice().getHardwareInfo().platform.eRenderCoreFamily); + const auto &gfxCoreHelper = GfxCoreHelper::get(getDevice().getHardwareInfo().platform.eRenderCoreFamily); const auto &hwInfoConfig = *HwInfoConfig::get(getDevice().getHardwareInfo().platform.eProductFamily); auto enabled = CommandQueue::isTimestampWaitEnabled(); - enabled &= hwHelper.isTimestampWaitSupportedForQueues(); + enabled &= gfxCoreHelper.isTimestampWaitSupportedForQueues(); enabled &= !hwInfoConfig.isDcFlushAllowed(); switch (DebugManager.flags.EnableTimestampWaitForQueues.get()) { diff --git a/opencl/source/command_queue/enqueue_common.h b/opencl/source/command_queue/enqueue_common.h index 0ac55bdff5..e3316a8a9a 100644 --- a/opencl/source/command_queue/enqueue_common.h +++ b/opencl/source/command_queue/enqueue_common.h @@ -68,7 +68,7 @@ cl_int CommandQueueHw::enqueueHandler(Surface *(&surfaces)[surfaceCou kernelObjsForAuxTranslation = kernel->fillWithKernelObjsForAuxTranslation(); if (!kernelObjsForAuxTranslation->empty()) { - auxTranslationMode = HwHelperHw::get().getAuxTranslationMode(device->getHardwareInfo()); + auxTranslationMode = GfxCoreHelperHw::get().getAuxTranslationMode(device->getHardwareInfo()); } multiDispatchInfo.setKernelObjsForAuxTranslation(std::move(kernelObjsForAuxTranslation)); } @@ -1407,7 +1407,7 @@ template bool CommandQueueHw::isBlitAuxTranslationRequired(const MultiDispatchInfo &multiDispatchInfo) { return multiDispatchInfo.getKernelObjsForAuxTranslation() && (multiDispatchInfo.getKernelObjsForAuxTranslation()->size() > 0) && - (HwHelperHw::get().getAuxTranslationMode(device->getHardwareInfo()) == AuxTranslationMode::Blit); + (GfxCoreHelperHw::get().getAuxTranslationMode(device->getHardwareInfo()) == AuxTranslationMode::Blit); } } // namespace NEO diff --git a/opencl/source/command_queue/gpgpu_walker_base.inl b/opencl/source/command_queue/gpgpu_walker_base.inl index 21f7d6e49e..c33bce09e9 100644 --- a/opencl/source/command_queue/gpgpu_walker_base.inl +++ b/opencl/source/command_queue/gpgpu_walker_base.inl @@ -199,7 +199,7 @@ size_t EnqueueOperation::getTotalSizeRequiredCS(uint32_t eventType, c } } else if (isMarkerWithProfiling) { expectedSizeCS += 2 * MemorySynchronizationCommands::getSizeForSingleBarrier(false); - if (!HwHelper::get(hwInfo.platform.eRenderCoreFamily).useOnlyGlobalTimestamps()) { + if (!GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).useOnlyGlobalTimestamps()) { expectedSizeCS += 2 * EncodeStoreMMIO::size; } } diff --git a/opencl/source/command_queue/gpgpu_walker_bdw_and_later.inl b/opencl/source/command_queue/gpgpu_walker_bdw_and_later.inl index 50b9be8b82..243bcb4b7a 100644 --- a/opencl/source/command_queue/gpgpu_walker_bdw_and_later.inl +++ b/opencl/source/command_queue/gpgpu_walker_bdw_and_later.inl @@ -120,7 +120,7 @@ void GpgpuWalkerHelper::dispatchProfilingCommandsStart( hwInfo, args); - if (!HwHelper::get(hwInfo.platform.eRenderCoreFamily).useOnlyGlobalTimestamps()) { + if (!GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).useOnlyGlobalTimestamps()) { // MI_STORE_REGISTER_MEM for context local timestamp timeStampAddress = hwTimeStamps.getGpuAddress() + offsetof(HwTimeStamps, ContextStartTS); @@ -152,7 +152,7 @@ void GpgpuWalkerHelper::dispatchProfilingCommandsEnd( hwInfo, args); - if (!HwHelper::get(hwInfo.platform.eRenderCoreFamily).useOnlyGlobalTimestamps()) { + if (!GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).useOnlyGlobalTimestamps()) { // MI_STORE_REGISTER_MEM for context local timestamp uint64_t timeStampAddress = hwTimeStamps.getGpuAddress() + offsetof(HwTimeStamps, ContextEndTS); diff --git a/opencl/source/event/event.cpp b/opencl/source/event/event.cpp index 067856194b..7364649ef0 100644 --- a/opencl/source/event/event.cpp +++ b/opencl/source/event/event.cpp @@ -267,10 +267,10 @@ cl_ulong Event::getDelta(cl_ulong startTime, void Event::calculateSubmitTimestampData() { if (DebugManager.flags.EnableDeviceBasedTimestamps.get()) { auto &device = cmdQueue->getDevice(); - auto &hwHelper = HwHelper::get(device.getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(device.getHardwareInfo().platform.eRenderCoreFamily); double resolution = device.getDeviceInfo().profilingTimerResolution; - int64_t timerDiff = queueTimeStamp.CPUTimeinNS - hwHelper.getGpuTimeStampInNS(queueTimeStamp.GPUTimeStamp, resolution); + int64_t timerDiff = queueTimeStamp.CPUTimeinNS - gfxCoreHelper.getGpuTimeStampInNS(queueTimeStamp.GPUTimeStamp, resolution); submitTimeStamp.GPUTimeStamp = static_cast((submitTimeStamp.CPUTimeinNS - timerDiff) / resolution); } } @@ -286,10 +286,10 @@ uint64_t Event::getTimeInNSFromTimestampData(const TimeStampData ×tamp) con if (cmdQueue && DebugManager.flags.EnableDeviceBasedTimestamps.get()) { auto &device = cmdQueue->getDevice(); - auto &hwHelper = HwHelper::get(device.getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(device.getHardwareInfo().platform.eRenderCoreFamily); double resolution = device.getDeviceInfo().profilingTimerResolution; - return hwHelper.getGpuTimeStampInNS(timestamp.GPUTimeStamp, resolution); + return gfxCoreHelper.getGpuTimeStampInNS(timestamp.GPUTimeStamp, resolution); } return timestamp.CPUTimeinNS; @@ -324,7 +324,7 @@ bool Event::calcProfilingData() { calculateProfilingDataInternal(globalStartTS, globalEndTS, &globalEndTS, globalStartTS); } else if (timeStampNode) { - if (HwHelper::get(this->cmdQueue->getDevice().getHardwareInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps()) { + if (GfxCoreHelper::get(this->cmdQueue->getDevice().getHardwareInfo().platform.eRenderCoreFamily).useOnlyGlobalTimestamps()) { calculateProfilingDataInternal( timeStampNode->getGlobalStartValue(0), timeStampNode->getGlobalEndValue(0), @@ -350,20 +350,20 @@ void Event::calculateProfilingDataInternal(uint64_t contextStartTS, uint64_t con uint64_t cpuCompleteDuration = 0; auto &device = this->cmdQueue->getDevice(); - auto &hwHelper = HwHelper::get(device.getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(device.getHardwareInfo().platform.eRenderCoreFamily); auto frequency = device.getDeviceInfo().profilingTimerResolution; - auto gpuQueueTimeStamp = hwHelper.getGpuTimeStampInNS(queueTimeStamp.GPUTimeStamp, frequency); + auto gpuQueueTimeStamp = gfxCoreHelper.getGpuTimeStampInNS(queueTimeStamp.GPUTimeStamp, frequency); if (DebugManager.flags.EnableDeviceBasedTimestamps.get()) { startTimeStamp = static_cast(globalStartTS * frequency); if (startTimeStamp < gpuQueueTimeStamp) { - startTimeStamp += static_cast((1ULL << hwHelper.getGlobalTimeStampBits()) * frequency); + startTimeStamp += static_cast((1ULL << gfxCoreHelper.getGlobalTimeStampBits()) * frequency); } } else { int64_t c0 = queueTimeStamp.CPUTimeinNS - gpuQueueTimeStamp; startTimeStamp = static_cast(globalStartTS * frequency) + c0; if (startTimeStamp < queueTimeStamp.CPUTimeinNS) { - c0 += static_cast((1ULL << (hwHelper.getGlobalTimeStampBits())) * frequency); + c0 += static_cast((1ULL << (gfxCoreHelper.getGlobalTimeStampBits())) * frequency); startTimeStamp = static_cast(globalStartTS * frequency) + c0; } } diff --git a/opencl/source/gen11/gtpin_setup_gen11.cpp b/opencl/source/gen11/gtpin_setup_gen11.cpp index 7904f01302..ac1a1fdab9 100644 --- a/opencl/source/gen11/gtpin_setup_gen11.cpp +++ b/opencl/source/gen11/gtpin_setup_gen11.cpp @@ -15,21 +15,21 @@ namespace NEO { -extern GTPinHwHelper *gtpinHwHelperFactory[IGFX_MAX_CORE]; +extern GTPinGfxCoreHelper *gtpinGfxCoreHelperFactory[IGFX_MAX_CORE]; typedef Gen11Family Family; static const auto gfxFamily = IGFX_GEN11_CORE; template <> -uint32_t GTPinHwHelperHw::getGenVersion() { +uint32_t GTPinGfxCoreHelperHw::getGenVersion() { return gtpin::GTPIN_GEN_11; } -template class GTPinHwHelperHw; +template class GTPinGfxCoreHelperHw; struct GTPinEnableGen11 { GTPinEnableGen11() { - gtpinHwHelperFactory[gfxFamily] = >PinHwHelperHw::get(); + gtpinGfxCoreHelperFactory[gfxFamily] = >PinGfxCoreHelperHw::get(); } }; diff --git a/opencl/source/gen12lp/gtpin_setup_gen12lp.cpp b/opencl/source/gen12lp/gtpin_setup_gen12lp.cpp index ce2312911a..af12f8779d 100644 --- a/opencl/source/gen12lp/gtpin_setup_gen12lp.cpp +++ b/opencl/source/gen12lp/gtpin_setup_gen12lp.cpp @@ -15,21 +15,21 @@ namespace NEO { -extern GTPinHwHelper *gtpinHwHelperFactory[IGFX_MAX_CORE]; +extern GTPinGfxCoreHelper *gtpinGfxCoreHelperFactory[IGFX_MAX_CORE]; typedef Gen12LpFamily Family; static const auto gfxFamily = IGFX_GEN12LP_CORE; template <> -uint32_t GTPinHwHelperHw::getGenVersion() { +uint32_t GTPinGfxCoreHelperHw::getGenVersion() { return gtpin::GTPIN_GEN_12_1; } -template class GTPinHwHelperHw; +template class GTPinGfxCoreHelperHw; struct GTPinEnableGen12LP { GTPinEnableGen12LP() { - gtpinHwHelperFactory[gfxFamily] = >PinHwHelperHw::get(); + gtpinGfxCoreHelperFactory[gfxFamily] = >PinGfxCoreHelperHw::get(); } }; diff --git a/opencl/source/gen8/gtpin_setup_gen8.cpp b/opencl/source/gen8/gtpin_setup_gen8.cpp index 190991838e..43c3d41ac3 100644 --- a/opencl/source/gen8/gtpin_setup_gen8.cpp +++ b/opencl/source/gen8/gtpin_setup_gen8.cpp @@ -15,21 +15,21 @@ namespace NEO { -extern GTPinHwHelper *gtpinHwHelperFactory[IGFX_MAX_CORE]; +extern GTPinGfxCoreHelper *gtpinGfxCoreHelperFactory[IGFX_MAX_CORE]; typedef Gen8Family Family; static const auto gfxFamily = IGFX_GEN8_CORE; template <> -uint32_t GTPinHwHelperHw::getGenVersion() { +uint32_t GTPinGfxCoreHelperHw::getGenVersion() { return gtpin::GTPIN_GEN_8; } -template class GTPinHwHelperHw; +template class GTPinGfxCoreHelperHw; struct GTPinEnableGen8 { GTPinEnableGen8() { - gtpinHwHelperFactory[gfxFamily] = >PinHwHelperHw::get(); + gtpinGfxCoreHelperFactory[gfxFamily] = >PinGfxCoreHelperHw::get(); } }; diff --git a/opencl/source/gen9/gtpin_setup_gen9.cpp b/opencl/source/gen9/gtpin_setup_gen9.cpp index a542ca9bda..9408dbfcdb 100644 --- a/opencl/source/gen9/gtpin_setup_gen9.cpp +++ b/opencl/source/gen9/gtpin_setup_gen9.cpp @@ -15,21 +15,21 @@ namespace NEO { -extern GTPinHwHelper *gtpinHwHelperFactory[IGFX_MAX_CORE]; +extern GTPinGfxCoreHelper *gtpinGfxCoreHelperFactory[IGFX_MAX_CORE]; typedef Gen9Family Family; static const auto gfxFamily = IGFX_GEN9_CORE; template <> -uint32_t GTPinHwHelperHw::getGenVersion() { +uint32_t GTPinGfxCoreHelperHw::getGenVersion() { return gtpin::GTPIN_GEN_9; } -template class GTPinHwHelperHw; +template class GTPinGfxCoreHelperHw; struct GTPinEnableGen9 { GTPinEnableGen9() { - gtpinHwHelperFactory[gfxFamily] = >PinHwHelperHw::get(); + gtpinGfxCoreHelperFactory[gfxFamily] = >PinGfxCoreHelperHw::get(); } }; diff --git a/opencl/source/gtpin/gtpin_callbacks.cpp b/opencl/source/gtpin/gtpin_callbacks.cpp index e2b1febec6..70ef8afde0 100644 --- a/opencl/source/gtpin/gtpin_callbacks.cpp +++ b/opencl/source/gtpin/gtpin_callbacks.cpp @@ -46,7 +46,7 @@ void gtpinNotifyContextCreate(cl_context context) { auto pDevice = pContext->getDevice(0); UNRECOVERABLE_IF(pDevice == nullptr); GFXCORE_FAMILY genFamily = pDevice->getHardwareInfo().platform.eRenderCoreFamily; - GTPinHwHelper >pinHelper = GTPinHwHelper::get(genFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(genFamily); gtpinPlatformInfo.gen_version = (gtpin::GTPIN_GEN_VERSION)gtpinHelper.getGenVersion(); gtpinPlatformInfo.device_id = static_cast(pDevice->getHardwareInfo().platform.usDeviceID); (*GTPinCallbacks.onContextCreate)((context_handle_t)context, >pinPlatformInfo, &pIgcInit); @@ -70,7 +70,7 @@ void gtpinNotifyKernelCreate(cl_kernel kernel) { size_t gtpinBTI = pKernel->getNumberOfBindingTableStates(); // Enlarge local copy of SSH by 1 SS GFXCORE_FAMILY genFamily = device.getHardwareInfo().platform.eRenderCoreFamily; - GTPinHwHelper >pinHelper = GTPinHwHelper::get(genFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(genFamily); if (!gtpinHelper.addSurfaceState(pKernel)) { // Kernel with no SSH or Kernel EM, not supported return; @@ -144,7 +144,7 @@ void gtpinNotifyKernelSubmit(cl_kernel kernel, void *pCmdQueue) { if (!resource) { return; } - GTPinHwHelper >pinHelper = GTPinHwHelper::get(device.getHardwareInfo().platform.eRenderCoreFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(device.getHardwareInfo().platform.eRenderCoreFamily); size_t gtpinBTI = pKernel->getNumberOfBindingTableStates() - 1; void *pSurfaceState = gtpinHelper.getSurfaceState(pKernel, gtpinBTI); if (gtpinHelper.canUseSharedAllocation(device.getHardwareInfo())) { @@ -211,7 +211,7 @@ void gtpinNotifyMakeResident(void *pKernel, void *pCSR) { CommandStreamReceiver *pCommandStreamReceiver = reinterpret_cast(pCSR); GraphicsAllocation *pGfxAlloc = nullptr; Context &context = static_cast(pKernel)->getContext(); - GTPinHwHelper >pinHelper = GTPinHwHelper::get(context.getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(context.getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); if (gtpinHelper.canUseSharedAllocation(context.getDevice(0)->getHardwareInfo())) { auto allocData = reinterpret_cast(kernelExecQueue[n].gtpinResource); pGfxAlloc = allocData->gpuAllocations.getGraphicsAllocation(pCommandStreamReceiver->getRootDeviceIndex()); diff --git a/opencl/source/gtpin/gtpin_helpers.cpp b/opencl/source/gtpin/gtpin_helpers.cpp index db986f38ee..78cf84cd16 100644 --- a/opencl/source/gtpin/gtpin_helpers.cpp +++ b/opencl/source/gtpin/gtpin_helpers.cpp @@ -32,7 +32,7 @@ GTPIN_DI_STATUS GTPIN_DRIVER_CALLCONV gtpinCreateBuffer(context_handle_t context return GTPIN_DI_ERROR_INVALID_ARGUMENT; } size_t size = alignUp(reqSize, MemoryConstants::cacheLineSize); - GTPinHwHelper >pinHelper = GTPinHwHelper::get(pContext->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(pContext->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); if (gtpinHelper.canUseSharedAllocation(pContext->getDevice(0)->getHardwareInfo())) { void *unifiedMemorySharedAllocation = clSharedMemAllocINTEL(pContext, pContext->getDevice(0), 0, size, 0, &diag); auto allocationsManager = pContext->getSVMAllocsManager(); @@ -54,7 +54,7 @@ GTPIN_DI_STATUS GTPIN_DRIVER_CALLCONV gtpinFreeBuffer(context_handle_t context, if ((pContext == nullptr) || (resource == nullptr)) { return GTPIN_DI_ERROR_INVALID_ARGUMENT; } - GTPinHwHelper >pinHelper = GTPinHwHelper::get(pContext->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(pContext->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); if (gtpinHelper.canUseSharedAllocation(pContext->getDevice(0)->getHardwareInfo())) { auto allocData = reinterpret_cast(resource); clMemFreeINTEL(pContext, allocData->cpuAllocation->getUnderlyingBuffer()); @@ -75,7 +75,7 @@ GTPIN_DI_STATUS GTPIN_DRIVER_CALLCONV gtpinMapBuffer(context_handle_t context, r if ((pContext == nullptr) || (buffer == nullptr) || (pAddress == nullptr)) { return GTPIN_DI_ERROR_INVALID_ARGUMENT; } - GTPinHwHelper >pinHelper = GTPinHwHelper::get(pContext->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(pContext->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); if (gtpinHelper.canUseSharedAllocation(pContext->getDevice(0)->getHardwareInfo())) { auto allocData = reinterpret_cast(resource); *pAddress = reinterpret_cast(allocData->cpuAllocation->getUnderlyingBuffer()); @@ -94,7 +94,7 @@ GTPIN_DI_STATUS GTPIN_DRIVER_CALLCONV gtpinUnmapBuffer(context_handle_t context, if ((pContext == nullptr) || (resource == nullptr)) { return GTPIN_DI_ERROR_INVALID_ARGUMENT; } - GTPinHwHelper >pinHelper = GTPinHwHelper::get(pContext->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(pContext->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); if (!gtpinHelper.canUseSharedAllocation(pContext->getDevice(0)->getHardwareInfo())) { auto pMemObj = castToObject(resource); if (pMemObj == nullptr) { diff --git a/opencl/source/gtpin/gtpin_hw_helper.cpp b/opencl/source/gtpin/gtpin_hw_helper.cpp index 7f7929ec8e..0c530a624b 100644 --- a/opencl/source/gtpin/gtpin_hw_helper.cpp +++ b/opencl/source/gtpin/gtpin_hw_helper.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2018-2020 Intel Corporation + * Copyright (C) 2018-2022 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -8,9 +8,9 @@ #include "opencl/source/gtpin/gtpin_hw_helper.h" namespace NEO { -GTPinHwHelper *gtpinHwHelperFactory[IGFX_MAX_CORE] = {}; +GTPinGfxCoreHelper *gtpinGfxCoreHelperFactory[IGFX_MAX_CORE] = {}; -GTPinHwHelper >PinHwHelper::get(GFXCORE_FAMILY gfxCore) { - return *gtpinHwHelperFactory[gfxCore]; +GTPinGfxCoreHelper >PinGfxCoreHelper::get(GFXCORE_FAMILY gfxCore) { + return *gtpinGfxCoreHelperFactory[gfxCore]; } } // namespace NEO diff --git a/opencl/source/gtpin/gtpin_hw_helper.h b/opencl/source/gtpin/gtpin_hw_helper.h index 86a6364135..f59d5c815d 100644 --- a/opencl/source/gtpin/gtpin_hw_helper.h +++ b/opencl/source/gtpin/gtpin_hw_helper.h @@ -16,24 +16,24 @@ namespace NEO { class Kernel; struct HardwareInfo; -class GTPinHwHelper { +class GTPinGfxCoreHelper { public: - static GTPinHwHelper &get(GFXCORE_FAMILY gfxCore); + static GTPinGfxCoreHelper &get(GFXCORE_FAMILY gfxCore); virtual uint32_t getGenVersion() = 0; virtual bool addSurfaceState(Kernel *pKernel) = 0; virtual void *getSurfaceState(Kernel *pKernel, size_t bti) = 0; virtual bool canUseSharedAllocation(const HardwareInfo &hwInfo) const = 0; protected: - GTPinHwHelper(){}; + GTPinGfxCoreHelper(){}; }; template -class GTPinHwHelperHw : public GTPinHwHelper { +class GTPinGfxCoreHelperHw : public GTPinGfxCoreHelper { public: - static GTPinHwHelper &get() { - static GTPinHwHelperHw gtpinHwHelper; - return gtpinHwHelper; + static GTPinGfxCoreHelper &get() { + static GTPinGfxCoreHelperHw gtpinGfxCoreHelper; + return gtpinGfxCoreHelper; } uint32_t getGenVersion() override; bool addSurfaceState(Kernel *pKernel) override; @@ -41,6 +41,6 @@ class GTPinHwHelperHw : public GTPinHwHelper { bool canUseSharedAllocation(const HardwareInfo &hwInfo) const override; protected: - GTPinHwHelperHw(){}; + GTPinGfxCoreHelperHw(){}; }; } // namespace NEO diff --git a/opencl/source/gtpin/gtpin_hw_helper.inl b/opencl/source/gtpin/gtpin_hw_helper.inl index f988feaada..6baa91692c 100644 --- a/opencl/source/gtpin/gtpin_hw_helper.inl +++ b/opencl/source/gtpin/gtpin_hw_helper.inl @@ -13,7 +13,7 @@ namespace NEO { template -bool GTPinHwHelperHw::addSurfaceState(Kernel *pKernel) { +bool GTPinGfxCoreHelperHw::addSurfaceState(Kernel *pKernel) { using RENDER_SURFACE_STATE = typename GfxFamily::RENDER_SURFACE_STATE; using BINDING_TABLE_STATE = typename GfxFamily::BINDING_TABLE_STATE; @@ -43,7 +43,7 @@ bool GTPinHwHelperHw::addSurfaceState(Kernel *pKernel) { } template -void *GTPinHwHelperHw::getSurfaceState(Kernel *pKernel, size_t bti) { +void *GTPinGfxCoreHelperHw::getSurfaceState(Kernel *pKernel, size_t bti) { using BINDING_TABLE_STATE = typename GfxFamily::BINDING_TABLE_STATE; if ((nullptr == pKernel->getSurfaceStateHeap()) || (bti >= pKernel->getNumberOfBindingTableStates())) { diff --git a/opencl/source/gtpin/gtpin_hw_helper_bdw_and_later.inl b/opencl/source/gtpin/gtpin_hw_helper_bdw_and_later.inl index c710baef4d..f46018e065 100644 --- a/opencl/source/gtpin/gtpin_hw_helper_bdw_and_later.inl +++ b/opencl/source/gtpin/gtpin_hw_helper_bdw_and_later.inl @@ -1,5 +1,5 @@ /* - * Copyright (C) 2021 Intel Corporation + * Copyright (C) 2021-2022 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -12,7 +12,7 @@ namespace NEO { template -bool GTPinHwHelperHw::canUseSharedAllocation(const HardwareInfo &hwInfo) const { +bool GTPinGfxCoreHelperHw::canUseSharedAllocation(const HardwareInfo &hwInfo) const { bool canUseSharedAllocation = false; if (DebugManager.flags.GTPinAllocateBufferInSharedMemory.get() != -1) { canUseSharedAllocation = !!DebugManager.flags.GTPinAllocateBufferInSharedMemory.get(); diff --git a/opencl/source/gtpin/gtpin_hw_helper_xehp_and_later.inl b/opencl/source/gtpin/gtpin_hw_helper_xehp_and_later.inl index b2512dab95..21bed1cee9 100644 --- a/opencl/source/gtpin/gtpin_hw_helper_xehp_and_later.inl +++ b/opencl/source/gtpin/gtpin_hw_helper_xehp_and_later.inl @@ -1,5 +1,5 @@ /* - * Copyright (C) 2021 Intel Corporation + * Copyright (C) 2021-2022 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -12,7 +12,7 @@ namespace NEO { template -bool GTPinHwHelperHw::canUseSharedAllocation(const HardwareInfo &hwInfo) const { +bool GTPinGfxCoreHelperHw::canUseSharedAllocation(const HardwareInfo &hwInfo) const { bool canUseSharedAllocation = true; if (DebugManager.flags.GTPinAllocateBufferInSharedMemory.get() != -1) { canUseSharedAllocation = !!DebugManager.flags.GTPinAllocateBufferInSharedMemory.get(); diff --git a/opencl/source/helpers/hardware_commands_helper_base.inl b/opencl/source/helpers/hardware_commands_helper_base.inl index 5626927823..c888843c67 100644 --- a/opencl/source/helpers/hardware_commands_helper_base.inl +++ b/opencl/source/helpers/hardware_commands_helper_base.inl @@ -160,7 +160,7 @@ size_t HardwareCommandsHelper::sendInterfaceDescriptorData( EncodeDispatchKernel::adjustBindingTablePrefetch(interfaceDescriptor, numSamplers, bindingTablePrefetchSize); auto programmableIDSLMSize = - static_cast(HwHelperHw::get().computeSlmValues(hardwareInfo, slmTotalSize)); + static_cast(GfxCoreHelperHw::get().computeSlmValues(hardwareInfo, slmTotalSize)); if (DebugManager.flags.OverrideSlmAllocationSize.get() != -1) { programmableIDSLMSize = static_cast(DebugManager.flags.OverrideSlmAllocationSize.get()); diff --git a/opencl/source/helpers/hardware_commands_helper_xehp_and_later.inl b/opencl/source/helpers/hardware_commands_helper_xehp_and_later.inl index 8bdd7d5a27..7030218d7c 100644 --- a/opencl/source/helpers/hardware_commands_helper_xehp_and_later.inl +++ b/opencl/source/helpers/hardware_commands_helper_xehp_and_later.inl @@ -138,7 +138,7 @@ void HardwareCommandsHelper::programCacheFlushAfterWalkerCommand(Line // 1. make sure previous kernel finished PipeControlArgs args; auto &hardwareInfo = commandQueue.getDevice().getHardwareInfo(); - args.unTypedDataPortCacheFlush = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily).unTypedDataPortCacheFlushRequired(); + args.unTypedDataPortCacheFlush = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily).unTypedDataPortCacheFlushRequired(); MemorySynchronizationCommands::addSingleBarrier(*commandStream, args); diff --git a/opencl/source/kernel/kernel.cpp b/opencl/source/kernel/kernel.cpp index 24f43fc127..60994f53bc 100644 --- a/opencl/source/kernel/kernel.cpp +++ b/opencl/source/kernel/kernel.cpp @@ -141,14 +141,14 @@ cl_int Kernel::initialize() { reconfigureKernel(); auto &hwInfo = pClDevice->getHardwareInfo(); auto &rootDeviceEnvironment = pClDevice->getRootDeviceEnvironment(); - auto &coreHelper = rootDeviceEnvironment.getHelper(); + auto &gfxCoreHelper = rootDeviceEnvironment.getHelper(); auto &kernelDescriptor = kernelInfo.kernelDescriptor; const auto &implicitArgs = kernelDescriptor.payloadMappings.implicitArgs; const auto &explicitArgs = kernelDescriptor.payloadMappings.explicitArgs; auto maxSimdSize = kernelInfo.getMaxSimdSize(); const auto &heapInfo = kernelInfo.heapInfo; - if (maxSimdSize != 1 && maxSimdSize < coreHelper.getMinimalSIMDSize()) { + if (maxSimdSize != 1 && maxSimdSize < gfxCoreHelper.getMinimalSIMDSize()) { return CL_INVALID_KERNEL; } @@ -244,7 +244,7 @@ cl_int Kernel::initialize() { auto &threadArbitrationPolicy = const_cast(kernelInfo.kernelDescriptor.kernelAttributes.threadArbitrationPolicy); if (threadArbitrationPolicy == ThreadArbitrationPolicy::NotPresent) { - threadArbitrationPolicy = static_cast(coreHelper.getDefaultThreadArbitrationPolicy()); + threadArbitrationPolicy = static_cast(gfxCoreHelper.getDefaultThreadArbitrationPolicy()); } if (false == kernelInfo.kernelDescriptor.kernelAttributes.flags.requiresSubgroupIndependentForwardProgress) { threadArbitrationPolicy = ThreadArbitrationPolicy::AgeBased; @@ -252,7 +252,7 @@ cl_int Kernel::initialize() { auto &clGfxCoreHelper = rootDeviceEnvironment.getHelper(); - auxTranslationRequired = !program->getIsBuiltIn() && HwHelper::compressedBuffersSupported(hwInfo) && clGfxCoreHelper.requiresAuxResolves(kernelInfo, rootDeviceEnvironment); + auxTranslationRequired = !program->getIsBuiltIn() && GfxCoreHelper::compressedBuffersSupported(hwInfo) && clGfxCoreHelper.requiresAuxResolves(kernelInfo, rootDeviceEnvironment); if (DebugManager.flags.ForceAuxTranslationEnabled.get() != -1) { auxTranslationRequired &= !!DebugManager.flags.ForceAuxTranslationEnabled.get(); @@ -555,7 +555,7 @@ cl_int Kernel::getWorkGroupInfo(cl_kernel_work_group_info paramName, cl_ulong privateMemSize; size_t maxWorkgroupSize; const auto &hwInfo = clDevice.getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto &clGfxCoreHelper = clDevice.getRootDeviceEnvironment().getHelper(); GetInfoHelper info(paramValue, paramValueSize, paramValueSizeRet); @@ -586,7 +586,7 @@ cl_int Kernel::getWorkGroupInfo(cl_kernel_work_group_info paramName, case CL_KERNEL_PREFERRED_WORK_GROUP_SIZE_MULTIPLE: preferredWorkGroupSizeMultiple = kernelInfo.getMaxSimdSize(); - if (hwHelper.isFusedEuDispatchEnabled(hwInfo, kernelDescriptor.kernelAttributes.flags.requiresDisabledEUFusion)) { + if (gfxCoreHelper.isFusedEuDispatchEnabled(hwInfo, kernelDescriptor.kernelAttributes.flags.requiresDisabledEUFusion)) { preferredWorkGroupSizeMultiple *= 2; } srcSize = sizeof(preferredWorkGroupSizeMultiple); @@ -740,7 +740,7 @@ void Kernel::substituteKernelHeap(void *newKernelHeap, size_t newKernelHeapSize) auto currentAllocationSize = pKernelInfo->kernelAllocation->getUnderlyingBufferSize(); bool status = false; - auto &helper = clDevice.getRootDeviceEnvironment().getHelper(); + auto &helper = clDevice.getRootDeviceEnvironment().getHelper(); size_t isaPadding = helper.getPaddingForISAAllocation(); if (currentAllocationSize >= newKernelHeapSize + isaPadding) { @@ -1089,7 +1089,7 @@ void Kernel::getSuggestedLocalWorkSize(const cl_uint workDim, const size_t *glob uint32_t Kernel::getMaxWorkGroupCount(const cl_uint workDim, const size_t *localWorkSize, const CommandQueue *commandQueue) const { auto &hardwareInfo = getHardwareInfo(); - auto &helper = this->getDevice().getRootDeviceEnvironment().getHelper(); + auto &helper = this->getDevice().getRootDeviceEnvironment().getHelper(); auto engineGroupType = helper.getEngineGroupType(commandQueue->getGpgpuEngine().getEngineType(), commandQueue->getGpgpuEngine().getEngineUsage(), hardwareInfo); @@ -2030,7 +2030,7 @@ bool Kernel::hasIndirectStatelessAccessToHostMemory() const { } void Kernel::getAllocationsForCacheFlush(CacheFlushAllocationsVec &out) const { - if (false == HwHelper::cacheFlushAfterWalkerSupported(getHardwareInfo())) { + if (false == GfxCoreHelper::cacheFlushAfterWalkerSupported(getHardwareInfo())) { return; } for (GraphicsAllocation *alloc : this->kernelArgRequiresCacheFlush) { @@ -2087,21 +2087,21 @@ uint64_t Kernel::getKernelStartAddress(const bool localIdsGenerationByRuntime, c kernelStartOffset += getStartOffset(); auto &hardwareInfo = getHardwareInfo(); - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); - if (isCssUsed && hwHelper.isOffsetToSkipSetFFIDGPWARequired(hardwareInfo)) { + if (isCssUsed && gfxCoreHelper.isOffsetToSkipSetFFIDGPWARequired(hardwareInfo)) { kernelStartOffset += kernelInfo.kernelDescriptor.entryPoints.skipSetFFIDGP; } return kernelStartOffset; } void *Kernel::patchBindlessSurfaceState(NEO::GraphicsAllocation *alloc, uint32_t bindless) { - auto &hwHelper = HwHelper::get(getDevice().getHardwareInfo().platform.eRenderCoreFamily); - auto surfaceStateSize = hwHelper.getRenderSurfaceStateSize(); + auto &gfxCoreHelper = GfxCoreHelper::get(getDevice().getHardwareInfo().platform.eRenderCoreFamily); + auto surfaceStateSize = gfxCoreHelper.getRenderSurfaceStateSize(); NEO::BindlessHeapsHelper *bindlessHeapsHelper = getDevice().getDevice().getBindlessHeapsHelper(); auto ssInHeap = bindlessHeapsHelper->allocateSSInHeap(surfaceStateSize, alloc, NEO::BindlessHeapsHelper::GLOBAL_SSH); auto patchLocation = ptrOffset(getCrossThreadData(), bindless); - auto patchValue = hwHelper.getBindlessSurfaceExtendedMessageDescriptorValue(static_cast(ssInHeap.surfaceStateOffset)); + auto patchValue = gfxCoreHelper.getBindlessSurfaceExtendedMessageDescriptorValue(static_cast(ssInHeap.surfaceStateOffset)); patchWithRequiredSize(patchLocation, sizeof(patchValue), patchValue); return ssInHeap.ssPtr; } @@ -2116,10 +2116,10 @@ uint32_t Kernel::getAdditionalKernelExecInfo() const { bool Kernel::requiresWaDisableRccRhwoOptimization() const { auto &hardwareInfo = getHardwareInfo(); - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); auto rootDeviceIndex = getDevice().getRootDeviceIndex(); - if (hwHelper.isWaDisableRccRhwoOptimizationRequired() && isUsingSharedObjArgs()) { + if (gfxCoreHelper.isWaDisableRccRhwoOptimizationRequired() && isUsingSharedObjArgs()) { for (auto &arg : getKernelArguments()) { auto clMemObj = static_cast(arg.object); auto memObj = castToObject(clMemObj); @@ -2232,7 +2232,7 @@ void Kernel::reconfigureKernel() { } bool Kernel::requiresCacheFlushCommand(const CommandQueue &commandQueue) const { - if (false == HwHelper::cacheFlushAfterWalkerSupported(commandQueue.getDevice().getHardwareInfo())) { + if (false == GfxCoreHelper::cacheFlushAfterWalkerSupported(commandQueue.getDevice().getHardwareInfo())) { return false; } diff --git a/opencl/source/mem_obj/buffer.cpp b/opencl/source/mem_obj/buffer.cpp index c89fa17edf..d5798d747c 100644 --- a/opencl/source/mem_obj/buffer.cpp +++ b/opencl/source/mem_obj/buffer.cpp @@ -298,8 +298,8 @@ Buffer *Buffer::create(Context *context, auto hwInfo = (&memoryManager->peekExecutionEnvironment())->rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo(); - bool compressionEnabled = MemObjHelper::isSuitableForCompression(HwHelper::compressedBuffersSupported(*hwInfo), memoryProperties, *context, - HwHelper::get(hwInfo->platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(size, *hwInfo)); + bool compressionEnabled = MemObjHelper::isSuitableForCompression(GfxCoreHelper::compressedBuffersSupported(*hwInfo), memoryProperties, *context, + GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(size, *hwInfo)); allocationInfo.allocationType = getGraphicsAllocationTypeAndCompressionPreference(memoryProperties, *context, compressionEnabled, memoryManager->isLocalMemorySupported(rootDeviceIndex)); @@ -880,7 +880,7 @@ void Buffer::setSurfaceState(const Device *device, } void Buffer::provideCompressionHint(bool compressionEnabled, Context *context, Buffer *buffer) { - if (context->isProvidingPerformanceHints() && HwHelper::compressedBuffersSupported(context->getDevice(0)->getHardwareInfo())) { + if (context->isProvidingPerformanceHints() && GfxCoreHelper::compressedBuffersSupported(context->getDevice(0)->getHardwareInfo())) { if (compressionEnabled) { context->providePerformanceHint(CL_CONTEXT_DIAGNOSTICS_LEVEL_NEUTRAL_INTEL, BUFFER_IS_COMPRESSED, buffer); } else { diff --git a/opencl/source/mem_obj/image.cpp b/opencl/source/mem_obj/image.cpp index 4b8195236a..5fc48d7669 100644 --- a/opencl/source/mem_obj/image.cpp +++ b/opencl/source/mem_obj/image.cpp @@ -148,9 +148,9 @@ Image *Image::create(Context *context, : imageWidth * surfaceFormat->surfaceFormat.ImageElementSizeInBytes; const auto hostPtrSlicePitch = getHostPtrSlicePitch(*imageDesc, hostPtrRowPitch, imageHeight); - auto &defaultHwHelper = HwHelper::get(context->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); - imgInfo.linearStorage = defaultHwHelper.isLinearStoragePreferred(context->isSharedContext, Image::isImage1d(*imageDesc), - memoryProperties.flags.forceLinearStorage); + auto &defaultGfxCoreHelper = GfxCoreHelper::get(context->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); + imgInfo.linearStorage = defaultGfxCoreHelper.isLinearStoragePreferred(context->isSharedContext, Image::isImage1d(*imageDesc), + memoryProperties.flags.forceLinearStorage); // if device doesn't support images, it can create only linear images if (!context->getDevice(0)->getSharedDeviceInfo().imageSupport && !imgInfo.linearStorage) { @@ -184,12 +184,12 @@ Image *Image::create(Context *context, allocationInfo.zeroCopyAllowed = false; auto &hwInfo = *memoryManager->peekExecutionEnvironment().rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); if (imageFromBuffer) { // Image from buffer - we never allocate memory, we use what buffer provides setAllocationInfoFromParentBuffer(allocationInfo, hostPtr, hostPtrToSet, parentBuffer, imgInfo, rootDeviceIndex); - if (!hwHelper.checkResourceCompatibility(*allocationInfo.memory)) { + if (!gfxCoreHelper.checkResourceCompatibility(*allocationInfo.memory)) { cleanAllGraphicsAllocations(*context, *memoryManager, allocationInfos, isParentObject); errcodeRet = CL_INVALID_MEM_OBJECT; return nullptr; @@ -270,7 +270,7 @@ Image *Image::create(Context *context, } auto allocationInSystemMemory = MemoryPoolHelper::isSystemMemoryPool(allocationInfo.memory->getMemoryPool()); - bool isCpuTransferPreferred = imgInfo.linearStorage && defaultHwHelper.isCpuImageTransferPreferred(hwInfo); + bool isCpuTransferPreferred = imgInfo.linearStorage && defaultGfxCoreHelper.isCpuImageTransferPreferred(hwInfo); bool isCpuTransferPreferredInSystemMemory = imgInfo.linearStorage && allocationInSystemMemory; if (isCpuTransferPreferredInSystemMemory) { @@ -1208,7 +1208,7 @@ void Image::setAllocationInfoFromImageInfo(CreateMemObj::AllocationInfo &allocat } void Image::providePerformanceHintForCreateImage(Image *image, const HardwareInfo &hwInfo, CreateMemObj::AllocationInfo &allocationInfo, Context *context) { - if (HwHelper::compressedImagesSupported(hwInfo)) { + if (GfxCoreHelper::compressedImagesSupported(hwInfo)) { if (allocationInfo.memory->isCompressionEnabled()) { context->providePerformanceHint(CL_CONTEXT_DIAGNOSTICS_LEVEL_NEUTRAL_INTEL, IMAGE_IS_COMPRESSED, image); } else { diff --git a/opencl/source/mem_obj/image.h b/opencl/source/mem_obj/image.h index ee3b692995..6e75baba00 100644 --- a/opencl/source/mem_obj/image.h +++ b/opencl/source/mem_obj/image.h @@ -18,7 +18,7 @@ namespace NEO { class Image; struct KernelInfo; struct SurfaceFormatInfo; -class HwHelper; +class GfxCoreHelper; using ImageCreateFunc = Image *(*)(Context *context, const MemoryProperties &memoryProperties, diff --git a/opencl/source/program/program.cpp b/opencl/source/program/program.cpp index 9a6b0da68c..e51881731f 100644 --- a/opencl/source/program/program.cpp +++ b/opencl/source/program/program.cpp @@ -73,7 +73,7 @@ std::string Program::getInternalOptions() const { CompilerOptions::concatenateAppend(internalOptions, CompilerOptions::bindlessMode); } - auto enableStatelessToStatefulWithOffset = HwHelper::get(pClDevice->getHardwareInfo().platform.eRenderCoreFamily).isStatelessToStatefulWithOffsetSupported(); + auto enableStatelessToStatefulWithOffset = GfxCoreHelper::get(pClDevice->getHardwareInfo().platform.eRenderCoreFamily).isStatelessToStatefulWithOffsetSupported(); if (DebugManager.flags.EnableStatelessToStatefulBufferOffsetOpt.get() != -1) { enableStatelessToStatefulWithOffset = DebugManager.flags.EnableStatelessToStatefulBufferOffsetOpt.get() != 0; } diff --git a/opencl/source/sharings/d3d/d3d_texture.cpp b/opencl/source/sharings/d3d/d3d_texture.cpp index 832be2e81f..0401636236 100644 --- a/opencl/source/sharings/d3d/d3d_texture.cpp +++ b/opencl/source/sharings/d3d/d3d_texture.cpp @@ -108,13 +108,13 @@ Image *D3DTexture::create2d(Context *context, D3DTexture2d *d3dTexture, cl_ auto d3dTextureObj = new D3DTexture(context, d3dTexture, subresource, textureStaging, sharedResource); auto hwInfo = memoryManager->peekExecutionEnvironment().rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily); const ClSurfaceFormatInfo *clSurfaceFormat = nullptr; if ((textureDesc.Format == DXGI_FORMAT_NV12) || (textureDesc.Format == DXGI_FORMAT_P010) || (textureDesc.Format == DXGI_FORMAT_P016)) { clSurfaceFormat = findYuvSurfaceFormatInfo(textureDesc.Format, imagePlane, flags); imgInfo.surfaceFormat = &clSurfaceFormat->surfaceFormat; } else { - clSurfaceFormat = findSurfaceFormatInfo(alloc->getDefaultGmm()->gmmResourceInfo->getResourceFormat(), flags, context->getDevice(0)->getHardwareInfo().capabilityTable.supportsOcl21Features, hwHelper.packedFormatsSupported()); + clSurfaceFormat = findSurfaceFormatInfo(alloc->getDefaultGmm()->gmmResourceInfo->getResourceFormat(), flags, context->getDevice(0)->getHardwareInfo().capabilityTable.supportsOcl21Features, gfxCoreHelper.packedFormatsSupported()); imgInfo.surfaceFormat = &clSurfaceFormat->surfaceFormat; } @@ -198,9 +198,9 @@ Image *D3DTexture::create3d(Context *context, D3DTexture3d *d3dTexture, cl_ updateImgInfoAndDesc(alloc->getDefaultGmm(), imgInfo, ImagePlane::NO_PLANE, 0u); auto hwInfo = memoryManager->peekExecutionEnvironment().rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily); auto d3dTextureObj = new D3DTexture(context, d3dTexture, subresource, textureStaging, sharedResource); - auto *clSurfaceFormat = findSurfaceFormatInfo(alloc->getDefaultGmm()->gmmResourceInfo->getResourceFormat(), flags, context->getDevice(0)->getHardwareInfo().capabilityTable.supportsOcl21Features, hwHelper.packedFormatsSupported()); + auto *clSurfaceFormat = findSurfaceFormatInfo(alloc->getDefaultGmm()->gmmResourceInfo->getResourceFormat(), flags, context->getDevice(0)->getHardwareInfo().capabilityTable.supportsOcl21Features, gfxCoreHelper.packedFormatsSupported()); imgInfo.qPitch = alloc->getDefaultGmm()->queryQPitch(GMM_RESOURCE_TYPE::RESOURCE_3D); imgInfo.surfaceFormat = &clSurfaceFormat->surfaceFormat; diff --git a/opencl/source/xe_hp_core/cl_hw_helper_xe_hp_core.cpp b/opencl/source/xe_hp_core/cl_hw_helper_xe_hp_core.cpp index 25b47f2256..b207be2079 100644 --- a/opencl/source/xe_hp_core/cl_hw_helper_xe_hp_core.cpp +++ b/opencl/source/xe_hp_core/cl_hw_helper_xe_hp_core.cpp @@ -54,8 +54,8 @@ template <> inline bool ClGfxCoreHelperHw::allowCompressionForContext(const ClDevice &clDevice, const Context &context) const { auto rootDeviceIndex = clDevice.getRootDeviceIndex(); auto &hwInfo = clDevice.getHardwareInfo(); - auto &coreHelper = clDevice.getRootDeviceEnvironment().getHelper(); - if (context.containsMultipleSubDevices(rootDeviceIndex) && coreHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hwInfo)) { + auto &gfxCoreHelper = clDevice.getRootDeviceEnvironment().getHelper(); + if (context.containsMultipleSubDevices(rootDeviceIndex) && gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hwInfo)) { return false; } return true; diff --git a/opencl/source/xe_hp_core/gtpin_setup_xe_hp_core.cpp b/opencl/source/xe_hp_core/gtpin_setup_xe_hp_core.cpp index ce8c4f786c..ff28622521 100644 --- a/opencl/source/xe_hp_core/gtpin_setup_xe_hp_core.cpp +++ b/opencl/source/xe_hp_core/gtpin_setup_xe_hp_core.cpp @@ -15,21 +15,21 @@ namespace NEO { -extern GTPinHwHelper *gtpinHwHelperFactory[IGFX_MAX_CORE]; +extern GTPinGfxCoreHelper *gtpinGfxCoreHelperFactory[IGFX_MAX_CORE]; typedef XeHpFamily Family; static const auto gfxFamily = IGFX_XE_HP_CORE; template <> -uint32_t GTPinHwHelperHw::getGenVersion() { +uint32_t GTPinGfxCoreHelperHw::getGenVersion() { return gtpin::GTPIN_XEHP_CORE; } -template class GTPinHwHelperHw; +template class GTPinGfxCoreHelperHw; struct GTPinEnableXeHpCore { GTPinEnableXeHpCore() { - gtpinHwHelperFactory[gfxFamily] = >PinHwHelperHw::get(); + gtpinGfxCoreHelperFactory[gfxFamily] = >PinGfxCoreHelperHw::get(); } }; diff --git a/opencl/source/xe_hpc_core/gtpin_setup_xe_hpc_core.cpp b/opencl/source/xe_hpc_core/gtpin_setup_xe_hpc_core.cpp index 3bae0f56b1..c2610b8fa8 100644 --- a/opencl/source/xe_hpc_core/gtpin_setup_xe_hpc_core.cpp +++ b/opencl/source/xe_hpc_core/gtpin_setup_xe_hpc_core.cpp @@ -14,21 +14,21 @@ namespace NEO { -extern GTPinHwHelper *gtpinHwHelperFactory[IGFX_MAX_CORE]; +extern GTPinGfxCoreHelper *gtpinGfxCoreHelperFactory[IGFX_MAX_CORE]; using Family = XeHpcCoreFamily; static const auto gfxFamily = IGFX_XE_HPC_CORE; -template class GTPinHwHelperHw; +template class GTPinGfxCoreHelperHw; struct GTPinEnableXeHpcCore { GTPinEnableXeHpcCore() { - gtpinHwHelperFactory[gfxFamily] = >PinHwHelperHw::get(); + gtpinGfxCoreHelperFactory[gfxFamily] = >PinGfxCoreHelperHw::get(); } }; template <> -uint32_t GTPinHwHelperHw::getGenVersion() { +uint32_t GTPinGfxCoreHelperHw::getGenVersion() { return gtpin::GTPIN_XE_HPC_CORE; } diff --git a/opencl/source/xe_hpg_core/gtpin_setup_xe_hpg_core.cpp b/opencl/source/xe_hpg_core/gtpin_setup_xe_hpg_core.cpp index dc7bb68155..ab10bc4643 100644 --- a/opencl/source/xe_hpg_core/gtpin_setup_xe_hpg_core.cpp +++ b/opencl/source/xe_hpg_core/gtpin_setup_xe_hpg_core.cpp @@ -14,21 +14,21 @@ namespace NEO { -extern GTPinHwHelper *gtpinHwHelperFactory[IGFX_MAX_CORE]; +extern GTPinGfxCoreHelper *gtpinGfxCoreHelperFactory[IGFX_MAX_CORE]; typedef XeHpgCoreFamily Family; static const auto gfxFamily = IGFX_XE_HPG_CORE; -template class GTPinHwHelperHw; +template class GTPinGfxCoreHelperHw; struct GTPinEnableXeHpgCore { GTPinEnableXeHpgCore() { - gtpinHwHelperFactory[gfxFamily] = >PinHwHelperHw::get(); + gtpinGfxCoreHelperFactory[gfxFamily] = >PinGfxCoreHelperHw::get(); } }; template <> -uint32_t GTPinHwHelperHw::getGenVersion() { +uint32_t GTPinGfxCoreHelperHw::getGenVersion() { return gtpin::GTPIN_XE_HPG_CORE; } diff --git a/opencl/test/unit_test/api/cl_create_image_tests.cpp b/opencl/test/unit_test/api/cl_create_image_tests.cpp index 4979080bb4..d7bec35c94 100644 --- a/opencl/test/unit_test/api/cl_create_image_tests.cpp +++ b/opencl/test/unit_test/api/cl_create_image_tests.cpp @@ -419,13 +419,13 @@ TEST_F(clCreateImageTest, GivenNonZeroPitchWhenCreatingImageFromBufferThenImageI REQUIRE_IMAGES_OR_SKIP(pContext); auto buffer = clCreateBuffer(pContext, CL_MEM_READ_WRITE, 4096 * 9, nullptr, nullptr); - auto &coreHelper = pDevice->getRootDeviceEnvironment().getHelper(); + auto &gfxCoreHelper = pDevice->getRootDeviceEnvironment().getHelper(); imageDesc.mem_object = buffer; imageDesc.image_type = CL_MEM_OBJECT_IMAGE2D; imageDesc.image_width = 17; imageDesc.image_height = 17; - imageDesc.image_row_pitch = coreHelper.getPitchAlignmentForImage(pDevice->getRootDeviceEnvironment()) * 17; + imageDesc.image_row_pitch = gfxCoreHelper.getPitchAlignmentForImage(pDevice->getRootDeviceEnvironment()) * 17; auto image = clCreateImage( pContext, diff --git a/opencl/test/unit_test/aub_tests/command_queue/compression_aub_tests_xehp_and_later.cpp b/opencl/test/unit_test/aub_tests/command_queue/compression_aub_tests_xehp_and_later.cpp index c46afeca00..21c4404273 100644 --- a/opencl/test/unit_test/aub_tests/command_queue/compression_aub_tests_xehp_and_later.cpp +++ b/opencl/test/unit_test/aub_tests/command_queue/compression_aub_tests_xehp_and_later.cpp @@ -37,11 +37,11 @@ struct CompressionXeHPAndLater : public AUBFixture, DebugManager.flags.EnableLocalMemory.set(useLocalMemory); DebugManager.flags.NodeOrdinal.set(GetParam()); - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); auto expectedEngine = static_cast(GetParam()); bool engineSupported = false; - for (auto &engine : hwHelper.getGpgpuEngineInstances(*defaultHwInfo)) { + for (auto &engine : gfxCoreHelper.getGpgpuEngineInstances(*defaultHwInfo)) { if (engine.first == expectedEngine) { engineSupported = true; break; diff --git a/opencl/test/unit_test/aub_tests/command_queue/enqueue_kernel_aub_tests.cpp b/opencl/test/unit_test/aub_tests/command_queue/enqueue_kernel_aub_tests.cpp index 7368dc1199..96e6746969 100644 --- a/opencl/test/unit_test/aub_tests/command_queue/enqueue_kernel_aub_tests.cpp +++ b/opencl/test/unit_test/aub_tests/command_queue/enqueue_kernel_aub_tests.cpp @@ -122,7 +122,7 @@ struct AUBHelloWorldIntegrateTest : public HelloWorldFixtureplatform.eRenderCoreFamily).getMinimalSIMDSize()) { + if (KernelFixture::simd < GfxCoreHelper::get(NEO::defaultHwInfo->platform.eRenderCoreFamily).getMinimalSIMDSize()) { GTEST_SKIP(); } ParentClass::setUp(); @@ -313,7 +313,7 @@ struct AUBSimpleArgIntegrateTest : public SimpleArgFixtureplatform.eRenderCoreFamily).getMinimalSIMDSize()) { + if (simd < GfxCoreHelper::get(NEO::defaultHwInfo->platform.eRenderCoreFamily).getMinimalSIMDSize()) { GTEST_SKIP(); } ParentClass::setUp(); diff --git a/opencl/test/unit_test/aub_tests/command_stream/aub_command_stream_fixture.cpp b/opencl/test/unit_test/aub_tests/command_stream/aub_command_stream_fixture.cpp index 002137ae49..ed3cfc2fbf 100644 --- a/opencl/test/unit_test/aub_tests/command_stream/aub_command_stream_fixture.cpp +++ b/opencl/test/unit_test/aub_tests/command_stream/aub_command_stream_fixture.cpp @@ -25,14 +25,14 @@ void AUBCommandStreamFixture::setUp(CommandQueue *pCmdQ) { ASSERT_NE(pCmdQ, nullptr); auto &device = reinterpret_cast(pCmdQ->getDevice()); const auto &hwInfo = device.getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); const ::testing::TestInfo *const testInfo = ::testing::UnitTest::GetInstance()->current_test_info(); std::stringstream strfilename; auto engineType = pCmdQ->getGpgpuCommandStreamReceiver().getOsContext().getEngineType(); strfilename << ApiSpecificConfig::getAubPrefixForSpecificApi(); - strfilename << testInfo->test_case_name() << "_" << testInfo->name() << "_" << hwHelper.getCsTraits(engineType).name; + strfilename << testInfo->test_case_name() << "_" << testInfo->name() << "_" << gfxCoreHelper.getCsTraits(engineType).name; pCommandStreamReceiver = AUBFixture::prepareComputeEngine(device, strfilename.str()); ASSERT_NE(nullptr, pCommandStreamReceiver); diff --git a/opencl/test/unit_test/aub_tests/command_stream/aub_mem_dump_tests.cpp b/opencl/test/unit_test/aub_tests/command_stream/aub_mem_dump_tests.cpp index 3e204c5c02..96a1ae8ef1 100644 --- a/opencl/test/unit_test/aub_tests/command_stream/aub_mem_dump_tests.cpp +++ b/opencl/test/unit_test/aub_tests/command_stream/aub_mem_dump_tests.cpp @@ -88,7 +88,7 @@ HWTEST_F(AubMemDumpTests, GivenReserveMaxAddressThenExpectationsAreMet) { auto gAddress = static_cast(-1) - 4096; auto pAddress = static_cast(gAddress) & 0xFFFFFFFF; - auto enableLocalMemory = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getEnableLocalMemory(hwInfo); + auto enableLocalMemory = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getEnableLocalMemory(hwInfo); NEO::AubHelperHw aubHelperHw(enableLocalMemory); AUB::reserveAddressPPGTT(aubFile, gAddress, 4096, pAddress, 7, aubHelperHw); diff --git a/opencl/test/unit_test/aub_tests/fixtures/aub_fixture.h b/opencl/test/unit_test/aub_tests/fixtures/aub_fixture.h index cd3700dcd7..f79bbedf04 100644 --- a/opencl/test/unit_test/aub_tests/fixtures/aub_fixture.h +++ b/opencl/test/unit_test/aub_tests/fixtures/aub_fixture.h @@ -57,13 +57,13 @@ class AUBFixture : public CommandQueueHwFixture { void setUp(const HardwareInfo *hardwareInfo) { const HardwareInfo &hwInfo = hardwareInfo ? *hardwareInfo : *defaultHwInfo; - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto engineType = getChosenEngineType(hwInfo); const ::testing::TestInfo *const testInfo = ::testing::UnitTest::GetInstance()->current_test_info(); std::stringstream strfilename; strfilename << ApiSpecificConfig::getAubPrefixForSpecificApi(); - strfilename << testInfo->test_case_name() << "_" << testInfo->name() << "_" << hwHelper.getCsTraits(engineType).name; + strfilename << testInfo->test_case_name() << "_" << testInfo->name() << "_" << gfxCoreHelper.getCsTraits(engineType).name; executionEnvironment = platform()->peekExecutionEnvironment(); executionEnvironment->prepareRootDeviceEnvironments(1u); diff --git a/opencl/test/unit_test/aub_tests/fixtures/multicontext_aub_fixture.cpp b/opencl/test/unit_test/aub_tests/fixtures/multicontext_aub_fixture.cpp index 8a55a3aea9..38ed00e0ee 100644 --- a/opencl/test/unit_test/aub_tests/fixtures/multicontext_aub_fixture.cpp +++ b/opencl/test/unit_test/aub_tests/fixtures/multicontext_aub_fixture.cpp @@ -55,10 +55,10 @@ void MulticontextAubFixture::setUp(uint32_t numberOfTiles, EnabledCommandStreame localHwInfo.capabilityTable.blitterOperationsSupported = !!DebugManager.flags.EnableBlitterOperationsSupport.get(); } - auto &hwHelper = HwHelper::get(localHwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(localHwInfo.platform.eRenderCoreFamily); auto engineType = getChosenEngineType(localHwInfo); auto renderEngine = aub_stream::NUM_ENGINES; - for (auto &engine : hwHelper.getGpgpuEngineInstances(localHwInfo)) { + for (auto &engine : gfxCoreHelper.getGpgpuEngineInstances(localHwInfo)) { if (!EngineHelpers::isCcs(engine.first)) { renderEngine = engine.first; break; @@ -66,7 +66,7 @@ void MulticontextAubFixture::setUp(uint32_t numberOfTiles, EnabledCommandStreame } ASSERT_NE(aub_stream::NUM_ENGINES, renderEngine); - auto renderEngineName = hwHelper.getCsTraits(renderEngine).name; + auto renderEngineName = gfxCoreHelper.getCsTraits(renderEngine).name; std::stringstream strfilename; strfilename << ApiSpecificConfig::getAubPrefixForSpecificApi(); diff --git a/opencl/test/unit_test/aub_tests/mem_obj/create_image_aub_tests.cpp b/opencl/test/unit_test/aub_tests/mem_obj/create_image_aub_tests.cpp index 30ef4463d8..6bc018bb60 100644 --- a/opencl/test/unit_test/aub_tests/mem_obj/create_image_aub_tests.cpp +++ b/opencl/test/unit_test/aub_tests/mem_obj/create_image_aub_tests.cpp @@ -81,14 +81,14 @@ struct AUBCreateImageArray : public AUBCreateImage, }; HWTEST_F(AUBCreateImageArray, Given1DImageArrayThenExpectationsMet) { - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); imageDesc.image_type = CL_MEM_OBJECT_IMAGE1D_ARRAY; imageDesc.image_height = 1; cl_mem_flags flags = CL_MEM_COPY_HOST_PTR; auto surfaceFormat = Image::getSurfaceFormatFromTable(flags, &imageFormat, context->getDevice(0)->getHardwareInfo().capabilityTable.supportsOcl21Features); auto imageDescriptor = Image::convertDescriptor(imageDesc); auto imgInfo = MockGmm::initImgInfo(imageDescriptor, 0, &surfaceFormat->surfaceFormat); - imgInfo.linearStorage = hwHelper.isLinearStoragePreferred(false, Image::isImage1d(imageDesc), false); + imgInfo.linearStorage = gfxCoreHelper.isLinearStoragePreferred(false, Image::isImage1d(imageDesc), false); auto queryGmm = MockGmm::queryImgParams(pDevice->getGmmHelper(), imgInfo, false); //allocate host_ptr @@ -160,14 +160,14 @@ HWTEST_F(AUBCreateImageArray, Given1DImageArrayThenExpectationsMet) { } HWTEST_F(AUBCreateImageArray, Given2DImageArrayThenExpectationsMet) { - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); imageDesc.image_type = CL_MEM_OBJECT_IMAGE2D_ARRAY; cl_mem_flags flags = CL_MEM_COPY_HOST_PTR; auto surfaceFormat = Image::getSurfaceFormatFromTable(flags, &imageFormat, context->getDevice(0)->getHardwareInfo().capabilityTable.supportsOcl21Features); auto imageDescriptor = Image::convertDescriptor(imageDesc); auto imgInfo = MockGmm::initImgInfo(imageDescriptor, 0, &surfaceFormat->surfaceFormat); - imgInfo.linearStorage = hwHelper.isLinearStoragePreferred(false, Image::isImage1d(imageDesc), false); + imgInfo.linearStorage = gfxCoreHelper.isLinearStoragePreferred(false, Image::isImage1d(imageDesc), false); auto queryGmm = MockGmm::queryImgParams(pDevice->getGmmHelper(), imgInfo, false); //allocate host_ptr diff --git a/opencl/test/unit_test/command_queue/command_enqueue_fixture.h b/opencl/test/unit_test/command_queue/command_enqueue_fixture.h index 5c8eee65b3..a4f44e0b33 100644 --- a/opencl/test/unit_test/command_queue/command_enqueue_fixture.h +++ b/opencl/test/unit_test/command_queue/command_enqueue_fixture.h @@ -127,7 +127,7 @@ struct CommandQueueStateful : public CommandQueueHw { auto kernel = dispatchInfo.begin()->getKernel(); EXPECT_FALSE(kernel->getKernelInfo().kernelDescriptor.kernelAttributes.supportsBuffersBiggerThan4Gb()); - if (HwHelperHw::get().isStatelessToStatefulWithOffsetSupported()) { + if (GfxCoreHelperHw::get().isStatelessToStatefulWithOffsetSupported()) { EXPECT_TRUE(kernel->allBufferArgsStateful); } diff --git a/opencl/test/unit_test/command_queue/command_queue_tests.cpp b/opencl/test/unit_test/command_queue/command_queue_tests.cpp index 6b54282063..413bfab201 100644 --- a/opencl/test/unit_test/command_queue/command_queue_tests.cpp +++ b/opencl/test/unit_test/command_queue/command_queue_tests.cpp @@ -155,9 +155,9 @@ TEST(CommandQueue, givenEnableTimestampWaitWhenCheckIsTimestampWaitEnabledThenRe { DebugManager.flags.EnableTimestampWaitForQueues.set(-1); - const auto &hwHelper = HwHelper::get(mockDevice->getHardwareInfo().platform.eRenderCoreFamily); + const auto &gfxCoreHelper = GfxCoreHelper::get(mockDevice->getHardwareInfo().platform.eRenderCoreFamily); const auto &hwInfoConfig = *HwInfoConfig::get(mockDevice->getHardwareInfo().platform.eProductFamily); - EXPECT_EQ(cmdQ.isWaitForTimestampsEnabled(), hwHelper.isTimestampWaitSupportedForQueues() && !hwInfoConfig.isDcFlushAllowed()); + EXPECT_EQ(cmdQ.isWaitForTimestampsEnabled(), gfxCoreHelper.isTimestampWaitSupportedForQueues() && !hwInfoConfig.isDcFlushAllowed()); } { @@ -321,7 +321,7 @@ TEST(CommandQueue, whenCommandQueueWithInternalUsageIsCreatedThenInternalBcsEngi hwInfo.capabilityTable.blitterOperationsSupported = true; REQUIRE_FULL_BLITTER_OR_SKIP(&hwInfo); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto device = std::make_unique(MockDevice::createWithNewExecutionEnvironment(&hwInfo)); auto internalUsage = true; auto expectedEngineType = EngineHelpers::linkCopyEnginesSupported(hwInfo, device->getDeviceBitfield()) @@ -330,7 +330,7 @@ TEST(CommandQueue, whenCommandQueueWithInternalUsageIsCreatedThenInternalBcsEngi for (auto preferInternalBcsEngine : {0, 1}) { DebugManager.flags.PreferInternalBcsEngine.set(preferInternalBcsEngine); - auto engineUsage = hwHelper.preferInternalBcsEngine() ? EngineUsage::Internal : EngineUsage::Regular; + auto engineUsage = gfxCoreHelper.preferInternalBcsEngine() ? EngineUsage::Internal : EngineUsage::Regular; MockCommandQueue cmdQ(nullptr, device.get(), 0, internalUsage); auto &bcsEngine = device->getEngine(expectedEngineType, engineUsage); @@ -956,8 +956,8 @@ HWTEST_F(CommandQueueTests, givenNodeOrdinalSetWithRenderEngineWhenCreatingComma cl_queue_properties propertiesCooperativeQueue[] = {CL_QUEUE_FAMILY_INTEL, userPropertiesEngineGroupType, CL_QUEUE_INDEX_INTEL, userPropertiesEngineIndex, 0}; - const HwHelper &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - EXPECT_NE(hwHelper.getEngineGroupType(static_cast(forcedEngine), EngineUsage::Regular, *defaultHwInfo), + const GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + EXPECT_NE(gfxCoreHelper.getEngineGroupType(static_cast(forcedEngine), EngineUsage::Regular, *defaultHwInfo), static_cast(userPropertiesEngineGroupType)); EXPECT_NE(expectedEngineIndex, userPropertiesEngineIndex); @@ -985,12 +985,12 @@ HWTEST_F(CommandQueueTests, givenNodeOrdinalSetWithCcsEngineWhenCreatingCommandQ cl_queue_properties propertiesCooperativeQueue[] = {CL_QUEUE_FAMILY_INTEL, 0, CL_QUEUE_INDEX_INTEL, 0, 0}; - struct FakeHwHelper : HwHelperHw { + struct FakeGfxCoreHelper : GfxCoreHelperHw { EngineGroupType getEngineGroupType(aub_stream::EngineType engineType, EngineUsage engineUsage, const HardwareInfo &hwInfo) const override { return EngineGroupType::RenderCompute; } }; - RAIIHwHelperFactory overrideHwHelper{defaultHwInfo->platform.eRenderCoreFamily}; + RAIIGfxCoreHelperFactory overrideGfxCoreHelper{defaultHwInfo->platform.eRenderCoreFamily}; auto forcedEngine = EngineHelpers::remapEngineTypeToHwSpecific(aub_stream::EngineType::ENGINE_CCS, *defaultHwInfo); DebugManager.flags.NodeOrdinal.set(static_cast(forcedEngine)); @@ -1487,8 +1487,8 @@ HWTEST_F(CommandQueueCommandStreamTest, givenDebugKernelWhenSetupDebugSurfaceIsC auto &commandStreamReceiver = cmdQ.getGpgpuCommandStreamReceiver(); auto &hwInfo = *NEO::defaultHwInfo.get(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - cmdQ.getGpgpuCommandStreamReceiver().allocateDebugSurface(hwHelper.getSipKernelMaxDbgSurfaceSize(hwInfo)); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + cmdQ.getGpgpuCommandStreamReceiver().allocateDebugSurface(gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo)); cmdQ.setupDebugSurface(kernel.get()); auto debugSurface = commandStreamReceiver.getDebugSurfaceAllocation(); @@ -1508,8 +1508,8 @@ HWTEST_F(CommandQueueCommandStreamTest, givenCsrWithDebugSurfaceAllocatedWhenSet kernel->setSshLocal(nullptr, sizeof(RENDER_SURFACE_STATE) + systemThreadSurfaceAddress); auto &commandStreamReceiver = cmdQ.getGpgpuCommandStreamReceiver(); auto hwInfo = *NEO::defaultHwInfo.get(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - commandStreamReceiver.allocateDebugSurface(hwHelper.getSipKernelMaxDbgSurfaceSize(hwInfo)); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + commandStreamReceiver.allocateDebugSurface(gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo)); auto debugSurface = commandStreamReceiver.getDebugSurfaceAllocation(); ASSERT_NE(nullptr, debugSurface); @@ -2486,7 +2486,7 @@ struct CommandQueueOnSpecificEngineTests : ::testing::Test { } template - class MockHwHelper : public HwHelperHw { + class MockGfxCoreHelper : public GfxCoreHelperHw { public: const EngineInstancesContainer getGpgpuEngineInstances(const HardwareInfo &hwInfo) const override { EngineInstancesContainer result{}; @@ -2520,14 +2520,14 @@ struct CommandQueueOnSpecificEngineTests : ::testing::Test { } }; - template - auto overrideHwHelper() { - return RAIIHwHelperFactory{::defaultHwInfo->platform.eRenderCoreFamily}; + template + auto overrideGfxCoreHelper() { + return RAIIGfxCoreHelperFactory{::defaultHwInfo->platform.eRenderCoreFamily}; } }; HWTEST_F(CommandQueueOnSpecificEngineTests, givenMultipleFamiliesWhenCreatingQueueOnSpecificEngineThenUseCorrectEngine) { - auto raiiHwHelper = overrideHwHelper>(); + auto raiiGfxCoreHelper = overrideGfxCoreHelper>(); HardwareInfo hwInfo = *defaultHwInfo; hwInfo.capabilityTable.blitterOperationsSupported = true; MockDevice *device = MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0); @@ -2558,7 +2558,7 @@ HWTEST_F(CommandQueueOnSpecificEngineTests, givenMultipleFamiliesWhenCreatingQue HWTEST_F(CommandQueueOnSpecificEngineTests, givenRootDeviceAndMultipleFamiliesWhenCreatingQueueOnSpecificEngineThenUseDefaultEngine) { VariableBackup backupHwInfo(defaultHwInfo.get()); defaultHwInfo->capabilityTable.blitterOperationsSupported = true; - auto raiiHwHelper = overrideHwHelper>(); + auto raiiGfxCoreHelper = overrideGfxCoreHelper>(); UltClDeviceFactory deviceFactory{1, 2}; MockContext context{deviceFactory.rootDevices[0]}; cl_command_queue_properties properties[5] = {}; @@ -2574,7 +2574,7 @@ HWTEST_F(CommandQueueOnSpecificEngineTests, givenRootDeviceAndMultipleFamiliesWh } HWTEST_F(CommandQueueOnSpecificEngineTests, givenSubDeviceAndMultipleFamiliesWhenCreatingQueueOnSpecificEngineThenUseDefaultEngine) { - auto raiiHwHelper = overrideHwHelper>(); + auto raiiGfxCoreHelper = overrideGfxCoreHelper>(); VariableBackup backupHwInfo(defaultHwInfo.get()); defaultHwInfo->capabilityTable.blitterOperationsSupported = true; @@ -2603,7 +2603,7 @@ HWTEST_F(CommandQueueOnSpecificEngineTests, givenSubDeviceAndMultipleFamiliesWhe } HWTEST_F(CommandQueueOnSpecificEngineTests, givenBcsFamilySelectedWhenCreatingQueueOnSpecificEngineThenInitializeBcsProperly) { - auto raiiHwHelper = overrideHwHelper>(); + auto raiiGfxCoreHelper = overrideGfxCoreHelper>(); VariableBackup backupHwInfo(defaultHwInfo.get()); defaultHwInfo->capabilityTable.blitterOperationsSupported = true; @@ -2628,7 +2628,7 @@ HWTEST_F(CommandQueueOnSpecificEngineTests, givenNotInitializedRcsOsContextWhenC DebugManager.flags.DeferOsContextInitialization.set(1); DebugManager.flags.NodeOrdinal.set(static_cast(aub_stream::EngineType::ENGINE_CCS)); - auto raiiHwHelper = overrideHwHelper>(); + auto raiiGfxCoreHelper = overrideGfxCoreHelper>(); MockContext context{}; cl_command_queue_properties properties[5] = {}; @@ -2650,7 +2650,7 @@ HWTEST_F(CommandQueueOnSpecificEngineTests, givenNotInitializedCcsOsContextWhenC DebugManager.flags.NodeOrdinal.set(static_cast(aub_stream::EngineType::ENGINE_RCS)); DebugManager.flags.DeferOsContextInitialization.set(1); - auto raiiHwHelper = overrideHwHelper>(); + auto raiiGfxCoreHelper = overrideGfxCoreHelper>(); MockContext context{}; cl_command_queue_properties properties[5] = {}; diff --git a/opencl/test/unit_test/command_queue/enqueue_copy_buffer_rect_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_copy_buffer_rect_tests.cpp index f7ba0afa08..6bfc36130e 100644 --- a/opencl/test/unit_test/command_queue/enqueue_copy_buffer_rect_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_copy_buffer_rect_tests.cpp @@ -261,10 +261,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, When2DEnqueueIsDoneThenSt enqueueCopyBufferRect2D(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } @@ -386,10 +386,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, When3DEnqueueIsDoneThenSt enqueueCopyBufferRect3D(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/enqueue_copy_buffer_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_copy_buffer_tests.cpp index 703fd30971..9be3ab0735 100644 --- a/opencl/test/unit_test/command_queue/enqueue_copy_buffer_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_copy_buffer_tests.cpp @@ -272,10 +272,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferTest, WhenEnqueueIsDoneThenStateBas enqueueCopyBufferAndParse(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/enqueue_copy_buffer_to_image_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_copy_buffer_to_image_tests.cpp index 417c3e0dd7..243edcc4ee 100644 --- a/opencl/test/unit_test/command_queue/enqueue_copy_buffer_to_image_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_copy_buffer_to_image_tests.cpp @@ -104,10 +104,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferToImageTest, WhenEnqueueIsDoneThenS enqueueCopyBufferToImage(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/enqueue_copy_image_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_copy_image_tests.cpp index d855f9b1cd..fa2dc80e75 100644 --- a/opencl/test/unit_test/command_queue/enqueue_copy_image_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_copy_image_tests.cpp @@ -117,10 +117,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyImageTest, WhenEnqueueIsDoneThenStateBase enqueueCopyImage(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/enqueue_copy_image_to_buffer_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_copy_image_to_buffer_tests.cpp index 99e1df1f4d..9cb0a4b0b6 100644 --- a/opencl/test/unit_test/command_queue/enqueue_copy_image_to_buffer_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_copy_image_to_buffer_tests.cpp @@ -104,10 +104,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyImageToBufferTest, WhenEnqueueIsDoneThenS enqueueCopyImageToBuffer(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/enqueue_debug_kernel_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_debug_kernel_tests.cpp index e458bef48b..c2a724abd4 100644 --- a/opencl/test/unit_test/command_queue/enqueue_debug_kernel_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_debug_kernel_tests.cpp @@ -159,8 +159,8 @@ HWTEST_F(EnqueueDebugKernelSimpleTest, givenKernelFromProgramWithDebugEnabledWhe kernel->initialize(); std::unique_ptr> mockCmdQ(new MockCommandQueueHwSetupDebugSurface(context, pClDevice, 0)); auto hwInfo = *NEO::defaultHwInfo.get(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - mockCmdQ->getGpgpuCommandStreamReceiver().allocateDebugSurface(hwHelper.getSipKernelMaxDbgSurfaceSize(hwInfo)); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + mockCmdQ->getGpgpuCommandStreamReceiver().allocateDebugSurface(gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo)); mockCmdQ->setupDebugSurfaceParamsPassed.clear(); EXPECT_TRUE(isValidOffset(kernel->getKernelInfo().kernelDescriptor.payloadMappings.implicitArgs.systemThreadSurfaceAddress.bindful)); diff --git a/opencl/test/unit_test/command_queue/enqueue_fill_buffer_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_fill_buffer_tests.cpp index 1fee627681..70903eb975 100644 --- a/opencl/test/unit_test/command_queue/enqueue_fill_buffer_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_fill_buffer_tests.cpp @@ -216,10 +216,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueFillBufferCmdTests, WhenEnqueueIsDoneThenStat enqueueFillBuffer(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/enqueue_fill_image_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_fill_image_tests.cpp index 0d2e377445..4d90c5d8c9 100644 --- a/opencl/test/unit_test/command_queue/enqueue_fill_image_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_fill_image_tests.cpp @@ -129,10 +129,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueFillImageTest, WhenEnqueueIsDoneThenStateBase enqueueFillImage(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/enqueue_kernel_1_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_kernel_1_tests.cpp index acc8b32c74..1dc29d5906 100644 --- a/opencl/test/unit_test/command_queue/enqueue_kernel_1_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_kernel_1_tests.cpp @@ -310,10 +310,10 @@ TEST_F(EnqueueKernelTest, GivenNullKernelWhenEnqueuingNDCountKernelINTELThenInva using clEnqueueNDCountKernelTests = api_tests; TEST_F(clEnqueueNDCountKernelTests, GivenQueueIncapableWhenEnqueuingNDCountKernelINTELThenInvalidOperationIsReturned) { - auto &hwHelper = HwHelper::get(::defaultHwInfo->platform.eRenderCoreFamily); - auto engineGroupType = hwHelper.getEngineGroupType(pCommandQueue->getGpgpuEngine().getEngineType(), - pCommandQueue->getGpgpuEngine().getEngineUsage(), *::defaultHwInfo); - if (!hwHelper.isCooperativeDispatchSupported(engineGroupType, *::defaultHwInfo)) { + auto &gfxCoreHelper = GfxCoreHelper::get(::defaultHwInfo->platform.eRenderCoreFamily); + auto engineGroupType = gfxCoreHelper.getEngineGroupType(pCommandQueue->getGpgpuEngine().getEngineType(), + pCommandQueue->getGpgpuEngine().getEngineUsage(), *::defaultHwInfo); + if (!gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, *::defaultHwInfo)) { GTEST_SKIP(); } @@ -344,10 +344,10 @@ TEST_F(EnqueueKernelTest, givenKernelWhenAllArgsAreSetThenClEnqueueNDCountKernel cl_int retVal = CL_SUCCESS; CommandQueue *pCmdQ2 = createCommandQueue(pClDevice); - HwHelper &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - auto engineGroupType = hwHelper.getEngineGroupType(pCmdQ2->getGpgpuEngine().getEngineType(), - pCmdQ2->getGpgpuEngine().getEngineUsage(), hardwareInfo); - if (!hwHelper.isCooperativeDispatchSupported(engineGroupType, hardwareInfo)) { + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto engineGroupType = gfxCoreHelper.getEngineGroupType(pCmdQ2->getGpgpuEngine().getEngineType(), + pCmdQ2->getGpgpuEngine().getEngineUsage(), hardwareInfo); + if (!gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, hardwareInfo)) { pCmdQ2->getGpgpuEngine().osContext = pCmdQ2->getDevice().getEngine(aub_stream::ENGINE_CCS, EngineUsage::LowPriority).osContext; } @@ -392,10 +392,10 @@ TEST_F(EnqueueKernelTest, givenKernelWhenNotAllArgsAreSetButSetKernelArgIsCalled cl_int retVal = CL_SUCCESS; CommandQueue *pCmdQ2 = createCommandQueue(pClDevice); - HwHelper &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - auto engineGroupType = hwHelper.getEngineGroupType(pCmdQ2->getGpgpuEngine().getEngineType(), - pCmdQ2->getGpgpuEngine().getEngineUsage(), hardwareInfo); - if (!hwHelper.isCooperativeDispatchSupported(engineGroupType, hardwareInfo)) { + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto engineGroupType = gfxCoreHelper.getEngineGroupType(pCmdQ2->getGpgpuEngine().getEngineType(), + pCmdQ2->getGpgpuEngine().getEngineUsage(), hardwareInfo); + if (!gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, hardwareInfo)) { pCmdQ2->getGpgpuEngine().osContext = pCmdQ2->getDevice().getEngine(aub_stream::ENGINE_CCS, EngineUsage::LowPriority).osContext; } @@ -440,10 +440,10 @@ TEST_F(EnqueueKernelTest, givenKernelWhenSetKernelArgIsCalledForEachArgButAtLeas cl_int retVal = CL_SUCCESS; CommandQueue *pCmdQ2 = createCommandQueue(pClDevice); - HwHelper &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - auto engineGroupType = hwHelper.getEngineGroupType(pCmdQ2->getGpgpuEngine().getEngineType(), - pCmdQ2->getGpgpuEngine().getEngineUsage(), hardwareInfo); - if (!hwHelper.isCooperativeDispatchSupported(engineGroupType, hardwareInfo)) { + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto engineGroupType = gfxCoreHelper.getEngineGroupType(pCmdQ2->getGpgpuEngine().getEngineType(), + pCmdQ2->getGpgpuEngine().getEngineUsage(), hardwareInfo); + if (!gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, hardwareInfo)) { pCmdQ2->getGpgpuEngine().osContext = pCmdQ2->getDevice().getEngine(aub_stream::ENGINE_CCS, EngineUsage::LowPriority).osContext; } @@ -707,7 +707,7 @@ HWTEST_F(EnqueueKernelTest, whenEnqueueKernelWithNoStatelessWriteWhenSbaIsBeingP EXPECT_EQ(csr.recordedDispatchFlags.l3CacheSettings, L3CachingSettings::l3AndL1On); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); auto gmmHelper = this->pDevice->getGmmHelper(); auto expectedMocsIndex = helper.getMocsIndex(*gmmHelper, true, true); EXPECT_EQ(expectedMocsIndex, csr.latestSentStatelessMocsConfig); @@ -729,7 +729,7 @@ HWTEST_F(EnqueueKernelTest, whenEnqueueKernelWithNoStatelessWriteOnBlockedCodePa EXPECT_EQ(csr.recordedDispatchFlags.l3CacheSettings, L3CachingSettings::l3AndL1On); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); auto gmmHelper = this->pDevice->getGmmHelper(); auto expectedMocsIndex = helper.getMocsIndex(*gmmHelper, true, true); EXPECT_EQ(expectedMocsIndex, csr.latestSentStatelessMocsConfig); diff --git a/opencl/test/unit_test/command_queue/enqueue_kernel_2_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_kernel_2_tests.cpp index 12cd927074..b3182664df 100644 --- a/opencl/test/unit_test/command_queue/enqueue_kernel_2_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_kernel_2_tests.cpp @@ -190,10 +190,10 @@ HWCMDTEST_P(IGFX_GEN8_CORE, EnqueueWorkItemTestsWithLimitedParamSet, WhenEnqueue enqueueKernel(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, context->getMemoryManager()->peekForce32BitAllocations() ? context->getMemoryManager()->getExternalHeapBaseAddress(ultCsr.rootDeviceIndex, false) : 0llu); } @@ -758,7 +758,7 @@ HWTEST_F(EnqueueKernelTests, whenEnqueueingKernelThenCsrCorrectlySetsRequiredThr nullptr, nullptr); pCommandQueue->flush(); - EXPECT_EQ(HwHelperHw::get().getDefaultThreadArbitrationPolicy(), + EXPECT_EQ(GfxCoreHelperHw::get().getDefaultThreadArbitrationPolicy(), csr.streamProperties.stateComputeMode.threadArbitrationPolicy.value); pCommandQueue->enqueueKernel( @@ -784,7 +784,7 @@ HWTEST_F(EnqueueKernelTests, whenEnqueueingKernelThenCsrCorrectlySetsRequiredThr nullptr, nullptr); pCommandQueue->flush(); - EXPECT_EQ(HwHelperHw::get().getDefaultThreadArbitrationPolicy(), + EXPECT_EQ(GfxCoreHelperHw::get().getDefaultThreadArbitrationPolicy(), csr.streamProperties.stateComputeMode.threadArbitrationPolicy.value); } diff --git a/opencl/test/unit_test/command_queue/enqueue_read_buffer_rect_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_read_buffer_rect_tests.cpp index c7c9d657e7..d8571a1ffb 100644 --- a/opencl/test/unit_test/command_queue/enqueue_read_buffer_rect_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_read_buffer_rect_tests.cpp @@ -244,10 +244,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferRectTest, When2DEnqueueIsDoneThenSt enqueueReadBufferRect2D(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/enqueue_read_buffer_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_read_buffer_tests.cpp index d3f063c4f9..a23b52a359 100644 --- a/opencl/test/unit_test/command_queue/enqueue_read_buffer_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_read_buffer_tests.cpp @@ -192,10 +192,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, WhenEnqueueIsDoneThenStat enqueueReadBuffer(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/enqueue_read_image_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_read_image_tests.cpp index 2004a521b2..be94672a2e 100644 --- a/opencl/test/unit_test/command_queue/enqueue_read_image_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_read_image_tests.cpp @@ -575,10 +575,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadImageTest, WhenEnqueueIsDoneThenStateBase enqueueReadImage(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/enqueue_write_buffer_rect_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_write_buffer_rect_tests.cpp index 6a54bc67be..b90e6c4bb8 100644 --- a/opencl/test/unit_test/command_queue/enqueue_write_buffer_rect_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_write_buffer_rect_tests.cpp @@ -219,10 +219,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferRectTest, When2DEnqueueIsDoneThenS enqueueWriteBufferRect2D(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/enqueue_write_buffer_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_write_buffer_tests.cpp index 1dd8cd7d15..65d14eb319 100644 --- a/opencl/test/unit_test/command_queue/enqueue_write_buffer_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_write_buffer_tests.cpp @@ -190,10 +190,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, WhenEnqueueIsDoneThenSta enqueueWriteBuffer(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/enqueue_write_image_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_write_image_tests.cpp index 6a49fcc611..adf56627ba 100644 --- a/opencl/test/unit_test/command_queue/enqueue_write_image_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_write_image_tests.cpp @@ -129,10 +129,10 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, WhenEnqueueIsDoneThenStateBas enqueueWriteImage(); auto &ultCsr = this->pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); validateStateBaseAddress(ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, pIOH->getGraphicsAllocation()->isAllocatedInLocalMemoryPool()), - ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), + ultCsr.getMemoryManager()->getInternalHeapBaseAddress(ultCsr.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())), pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } diff --git a/opencl/test/unit_test/command_queue/get_command_queue_info_tests.cpp b/opencl/test/unit_test/command_queue/get_command_queue_info_tests.cpp index 817655e996..cf33e23066 100644 --- a/opencl/test/unit_test/command_queue/get_command_queue_info_tests.cpp +++ b/opencl/test/unit_test/command_queue/get_command_queue_info_tests.cpp @@ -133,9 +133,9 @@ TEST_F(GetCommandQueueFamilyInfoTests, givenQueueFamilyNotSelectedWhenGettingFam cl_int retVal{}; const auto &hwInfo = context.getDevice(0)->getHardwareInfo(); - const auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - const auto engineGroupType = hwHelper.getEngineGroupType(context.getDevice(0)->getDefaultEngine().getEngineType(), - context.getDevice(0)->getDefaultEngine().getEngineUsage(), hwInfo); + const auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + const auto engineGroupType = gfxCoreHelper.getEngineGroupType(context.getDevice(0)->getDefaultEngine().getEngineType(), + context.getDevice(0)->getDefaultEngine().getEngineUsage(), hwInfo); const auto expectedFamilyIndex = context.getDevice(0)->getDevice().getEngineGroupIndexFromEngineGroupType(engineGroupType); cl_uint familyIndex{}; diff --git a/opencl/test/unit_test/command_queue/local_work_size_tests.cpp b/opencl/test/unit_test/command_queue/local_work_size_tests.cpp index e135707f7a..59fe5792ac 100644 --- a/opencl/test/unit_test/command_queue/local_work_size_tests.cpp +++ b/opencl/test/unit_test/command_queue/local_work_size_tests.cpp @@ -32,8 +32,8 @@ TEST(localWorkSizeTest, givenDisableEUFusionWhenCreatingWorkSizeInfoThenCorrectM true // disableEUFusion ); - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - bool fusedDispatchEnabled = hwHelper.isFusedEuDispatchEnabled(*defaultHwInfo, true); + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + bool fusedDispatchEnabled = gfxCoreHelper.isFusedEuDispatchEnabled(*defaultHwInfo, true); auto wgsMultiple = fusedDispatchEnabled ? 2 : 1; uint32_t maxBarriersPerHSlice = (defaultHwInfo->platform.eRenderCoreFamily >= IGFX_GEN9_CORE) ? 32 : 16; diff --git a/opencl/test/unit_test/command_queue/sync_buffer_handler_tests.cpp b/opencl/test/unit_test/command_queue/sync_buffer_handler_tests.cpp index c664cc31c3..541866f723 100644 --- a/opencl/test/unit_test/command_queue/sync_buffer_handler_tests.cpp +++ b/opencl/test/unit_test/command_queue/sync_buffer_handler_tests.cpp @@ -98,10 +98,10 @@ class SyncBufferHandlerTest : public SyncBufferEnqueueHandlerTest { } bool isCooperativeDispatchSupported() { - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - auto engineGroupType = hwHelper.getEngineGroupType(commandQueue->getGpgpuEngine().getEngineType(), - commandQueue->getGpgpuEngine().getEngineUsage(), hardwareInfo); - return hwHelper.isCooperativeDispatchSupported(engineGroupType, pDevice->getHardwareInfo()); + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto engineGroupType = gfxCoreHelper.getEngineGroupType(commandQueue->getGpgpuEngine().getEngineType(), + commandQueue->getGpgpuEngine().getEngineUsage(), hardwareInfo); + return gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, pDevice->getHardwareInfo()); } const cl_uint workDim = 1; diff --git a/opencl/test/unit_test/command_stream/cl_command_stream_receiver_tests.cpp b/opencl/test/unit_test/command_stream/cl_command_stream_receiver_tests.cpp index c5ae8f9ddb..7852f54826 100644 --- a/opencl/test/unit_test/command_stream/cl_command_stream_receiver_tests.cpp +++ b/opencl/test/unit_test/command_stream/cl_command_stream_receiver_tests.cpp @@ -47,7 +47,7 @@ TEST(ClCommandStreamReceiverTest, WhenMakingResidentThenBufferResidencyFlagIsSet using ClCommandStreamReceiverTests = Test; HWTEST_F(ClCommandStreamReceiverTests, givenCommandStreamReceiverWhenFenceAllocationIsRequiredAndCreateGlobalFenceAllocationIsCalledThenFenceAllocationIsAllocated) { - RAIIHwHelperFactory> hwHelperBackup{pDevice->getHardwareInfo().platform.eRenderCoreFamily}; + RAIIGfxCoreHelperFactory> gfxCoreHelperBackup{pDevice->getHardwareInfo().platform.eRenderCoreFamily}; MockCsrHw csr(*pDevice->executionEnvironment, pDevice->getRootDeviceIndex(), pDevice->getDeviceBitfield()); csr.setupContext(*pDevice->getDefaultEngine().osContext); @@ -60,7 +60,7 @@ HWTEST_F(ClCommandStreamReceiverTests, givenCommandStreamReceiverWhenFenceAlloca } HWTEST_F(ClCommandStreamReceiverTests, givenCommandStreamReceiverWhenGettingFenceAllocationThenCorrectFenceAllocationIsReturned) { - RAIIHwHelperFactory> hwHelperBackup{pDevice->getHardwareInfo().platform.eRenderCoreFamily}; + RAIIGfxCoreHelperFactory> gfxCoreHelperBackup{pDevice->getHardwareInfo().platform.eRenderCoreFamily}; CommandStreamReceiverHw csr(*pDevice->executionEnvironment, pDevice->getRootDeviceIndex(), pDevice->getDeviceBitfield()); csr.setupContext(*pDevice->getDefaultEngine().osContext); diff --git a/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_1_tests.cpp b/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_1_tests.cpp index 15e2fcf3c7..5f4839ff86 100644 --- a/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_1_tests.cpp +++ b/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_1_tests.cpp @@ -550,8 +550,8 @@ HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, WhenFlushingTas ASSERT_NE(nullptr, cmdStateBaseAddress); auto &cmd = *reinterpret_cast(cmdStateBaseAddress); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); - auto instructionHeapBaseAddress = commandStreamReceiver.getMemoryManager()->getInternalHeapBaseAddress(commandStreamReceiver.rootDeviceIndex, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto instructionHeapBaseAddress = commandStreamReceiver.getMemoryManager()->getInternalHeapBaseAddress(commandStreamReceiver.rootDeviceIndex, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo())); EXPECT_EQ(dsh.getCpuBase(), reinterpret_cast(cmd.getDynamicStateBaseAddress())); EXPECT_EQ(instructionHeapBaseAddress, cmd.getInstructionBaseAddress()); diff --git a/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_2_tests.cpp b/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_2_tests.cpp index a35a1e178d..c1ae2e5bcc 100644 --- a/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_2_tests.cpp +++ b/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_2_tests.cpp @@ -441,7 +441,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenDefaultCommandStreamReceiverT EXPECT_EQ(ThreadArbitrationPolicy::NotPresent, pCommandStreamReceiver->peekThreadArbitrationPolicy()); flushTask(*pCommandStreamReceiver); - EXPECT_EQ(HwHelperHw::get().getDefaultThreadArbitrationPolicy(), pCommandStreamReceiver->peekThreadArbitrationPolicy()); + EXPECT_EQ(GfxCoreHelperHw::get().getDefaultThreadArbitrationPolicy(), pCommandStreamReceiver->peekThreadArbitrationPolicy()); } HWTEST_F(CommandStreamReceiverFlushTaskTests, GivenKernelWithSlmWhenPreviousSLML3WasSentThenDontProgramL3) { @@ -529,7 +529,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, WhenFlushingThenScratchAllocationI } HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCommandStreamReceiverWhenFenceAllocationIsRequiredAndFlushTaskIsCalledThenFenceAllocationIsMadeResident) { - RAIIHwHelperFactory> hwHelperBackup{pDevice->getHardwareInfo().platform.eRenderCoreFamily}; + RAIIGfxCoreHelperFactory> gfxCoreHelperBackup{pDevice->getHardwareInfo().platform.eRenderCoreFamily}; auto commandStreamReceiver = new MockCsrHw(*pDevice->executionEnvironment, pDevice->getRootDeviceIndex(), pDevice->getDeviceBitfield()); pDevice->resetCommandStreamReceiver(commandStreamReceiver); @@ -547,7 +547,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCommandStreamReceiverWhenFenc } HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCommandStreamReceiverWhenFenceAllocationIsRequiredAndCreatedThenItIsMadeResidentDuringFlushSmallTask) { - RAIIHwHelperFactory> hwHelperBackup{pDevice->getHardwareInfo().platform.eRenderCoreFamily}; + RAIIGfxCoreHelperFactory> gfxCoreHelperBackup{pDevice->getHardwareInfo().platform.eRenderCoreFamily}; MockCsrHw csr(*pDevice->executionEnvironment, pDevice->getRootDeviceIndex(), pDevice->getDeviceBitfield()); csr.setupContext(*pDevice->getDefaultEngine().osContext); @@ -568,7 +568,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCommandStreamReceiverWhenFenc } HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCommandStreamReceiverWhenFenceAllocationIsRequiredButNotCreatedThenItIsNotMadeResidentDuringFlushSmallTask) { - RAIIHwHelperFactory> hwHelperBackup{pDevice->getHardwareInfo().platform.eRenderCoreFamily}; + RAIIGfxCoreHelperFactory> gfxCoreHelperBackup{pDevice->getHardwareInfo().platform.eRenderCoreFamily}; MockCsrHw csr(*pDevice->executionEnvironment, pDevice->getRootDeviceIndex(), pDevice->getDeviceBitfield()); csr.setupContext(*pDevice->getDefaultEngine().osContext); diff --git a/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_4_tests.cpp b/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_4_tests.cpp index bc38049ba0..87fb538093 100644 --- a/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_4_tests.cpp +++ b/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_4_tests.cpp @@ -741,7 +741,7 @@ struct PreambleThreadArbitrationMatcher { HWTEST2_F(CommandStreamReceiverFlushTaskTests, givenPolicyValueChangedWhenFlushingTaskThenProgramThreadArbitrationPolicy, PreambleThreadArbitrationMatcher) { using MI_LOAD_REGISTER_IMM = typename FamilyType::MI_LOAD_REGISTER_IMM; - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); commandStreamReceiver.isPreambleSent = true; @@ -749,7 +749,7 @@ HWTEST2_F(CommandStreamReceiverFlushTaskTests, givenPolicyValueChangedWhenFlushi size_t parsingOffset = commandStreamReceiver.commandStream.getUsed(); for (auto arbitrationChanged : ::testing::Bool()) { commandStreamReceiver.streamProperties.stateComputeMode.threadArbitrationPolicy.value = - arbitrationChanged ? -1 : hwHelper.getDefaultThreadArbitrationPolicy(); + arbitrationChanged ? -1 : gfxCoreHelper.getDefaultThreadArbitrationPolicy(); flushTask(commandStreamReceiver); HardwareParse csHwParser; diff --git a/opencl/test/unit_test/command_stream/command_stream_receiver_hw_2_tests.cpp b/opencl/test/unit_test/command_stream/command_stream_receiver_hw_2_tests.cpp index 1e98bdc454..8257e39c90 100644 --- a/opencl/test/unit_test/command_stream/command_stream_receiver_hw_2_tests.cpp +++ b/opencl/test/unit_test/command_stream/command_stream_receiver_hw_2_tests.cpp @@ -511,7 +511,7 @@ HWTEST_F(BcsTests, givenInputAllocationsWhenBlitDispatchedThenMakeAllAllocations } HWTEST_F(BcsTests, givenFenceAllocationIsRequiredWhenBlitDispatchedThenMakeAllAllocationsResident) { - RAIIHwHelperFactory> hwHelperBackup{pDevice->getHardwareInfo().platform.eRenderCoreFamily}; + RAIIGfxCoreHelperFactory> gfxCoreHelperBackup{pDevice->getHardwareInfo().platform.eRenderCoreFamily}; auto bcsOsContext = std::unique_ptr(OsContext::create(nullptr, pDevice->getRootDeviceIndex(), 0, EngineDescriptorHelper::getDefaultDescriptor({aub_stream::ENGINE_BCS, EngineUsage::Regular}, pDevice->getDeviceBitfield()))); auto bcsCsr = std::make_unique>(*pDevice->getExecutionEnvironment(), pDevice->getRootDeviceIndex(), pDevice->getDeviceBitfield()); diff --git a/opencl/test/unit_test/command_stream/command_stream_receiver_hw_tests_dg2_and_later.cpp b/opencl/test/unit_test/command_stream/command_stream_receiver_hw_tests_dg2_and_later.cpp index 7721793172..bef5a0b6e9 100644 --- a/opencl/test/unit_test/command_stream/command_stream_receiver_hw_tests_dg2_and_later.cpp +++ b/opencl/test/unit_test/command_stream/command_stream_receiver_hw_tests_dg2_and_later.cpp @@ -93,8 +93,8 @@ HWTEST2_F(CommandStreamReceiverFlushTaskDg2AndLaterTests, givenProgramExtendedPi DispatchFlags dispatchFlags = DispatchFlagsHelper::createDefaultDispatchFlags(); dispatchFlags.preemptionMode = PreemptionHelper::getDefaultPreemptionMode(pDevice->getHardwareInfo()); dispatchFlags.usePerDssBackedBuffer = true; - auto &hwHelper = NEO::HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); - dispatchFlags.threadArbitrationPolicy = hwHelper.getDefaultThreadArbitrationPolicy(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + dispatchFlags.threadArbitrationPolicy = gfxCoreHelper.getDefaultThreadArbitrationPolicy(); commandStreamReceiver.streamProperties.stateComputeMode.setProperties(dispatchFlags.requiresCoherency, dispatchFlags.numGrfRequired, dispatchFlags.threadArbitrationPolicy, PreemptionMode::Disabled, *defaultHwInfo); diff --git a/opencl/test/unit_test/command_stream/command_stream_receiver_hw_tests_xehp_and_later.cpp b/opencl/test/unit_test/command_stream/command_stream_receiver_hw_tests_xehp_and_later.cpp index 6dce30c8f7..96a263b445 100644 --- a/opencl/test/unit_test/command_stream/command_stream_receiver_hw_tests_xehp_and_later.cpp +++ b/opencl/test/unit_test/command_stream/command_stream_receiver_hw_tests_xehp_and_later.cpp @@ -177,8 +177,8 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, CommandStreamReceiverHwTestXeHPAndLater, givenScrat auto &commandStreamCSR = commandStreamReceiver->getCS(); kernel.kernelInfo.kernelDescriptor.kernelAttributes.perThreadScratchSize[0] = 0x1000; - auto &coreHelper = pDevice->getRootDeviceEnvironment().getHelper(); - uint32_t computeUnits = coreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment()); + auto &gfxCoreHelper = pDevice->getRootDeviceEnvironment().getHelper(); + uint32_t computeUnits = gfxCoreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment()); size_t scratchSpaceSize = kernel.kernelInfo.kernelDescriptor.kernelAttributes.perThreadScratchSize[0] * computeUnits; commandQueue.enqueueKernel(kernel, 1, nullptr, &gws, nullptr, 0, nullptr, nullptr); diff --git a/opencl/test/unit_test/context/context_tests.cpp b/opencl/test/unit_test/context/context_tests.cpp index 0694a2345a..77dc630aa9 100644 --- a/opencl/test/unit_test/context/context_tests.cpp +++ b/opencl/test/unit_test/context/context_tests.cpp @@ -549,11 +549,11 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, ContextCreateTests, givenGpuHangOnFlushBcsTaskAndLo auto deviceBitfield = blitDevice->getDeviceBitfield(); const auto &hwInfo = testedDevice->getDevice().getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto internalUsage = true; auto bcsEngineType = EngineHelpers::getBcsEngineType(hwInfo, deviceBitfield, selectorCopyEngine, internalUsage); - auto bcsEngineUsage = hwHelper.preferInternalBcsEngine() ? EngineUsage::Internal : EngineUsage::Regular; + auto bcsEngineUsage = gfxCoreHelper.preferInternalBcsEngine() ? EngineUsage::Internal : EngineUsage::Regular; auto bcsEngine = blitDevice->tryGetEngine(bcsEngineType, bcsEngineUsage); ASSERT_NE(nullptr, bcsEngine); diff --git a/opencl/test/unit_test/context/driver_diagnostics_tests.cpp b/opencl/test/unit_test/context/driver_diagnostics_tests.cpp index 2a42b2330c..bfd7bd0110 100644 --- a/opencl/test/unit_test/context/driver_diagnostics_tests.cpp +++ b/opencl/test/unit_test/context/driver_diagnostics_tests.cpp @@ -693,8 +693,8 @@ HWTEST2_F(PerformanceHintTest, given64bitCompressedBufferWhenItsCreatedThenPrope Buffer::create(context.get(), ClMemoryPropertiesHelper::createMemoryProperties(0, 0, 0, &context->getDevice(0)->getDevice()), 0, 0, size, static_cast(NULL), retVal)); snprintf(expectedHint, DriverDiagnostics::maxHintStringSize, DriverDiagnostics::hintFormat[BUFFER_IS_COMPRESSED], buffer.get()); - auto compressionSupported = HwHelper::get(hwInfo.platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(size, hwInfo) && - HwHelper::compressedBuffersSupported(hwInfo); + auto compressionSupported = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(size, hwInfo) && + GfxCoreHelper::compressedBuffersSupported(hwInfo); if (compressionSupported) { EXPECT_TRUE(containsHint(expectedHint, userData)); } else { @@ -722,9 +722,9 @@ TEST_F(PerformanceHintTest, givenUncompressedBufferWhenItsCreatedThenProperPerfo bool isCompressed = true; if (context->getMemoryManager()) { isCompressed = MemObjHelper::isSuitableForCompression( - HwHelper::compressedBuffersSupported(hwInfo), + GfxCoreHelper::compressedBuffersSupported(hwInfo), memoryProperties, *context, - HwHelper::get(hwInfo.platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(size, hwInfo)) && + GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(size, hwInfo)) && !is32bit && !context->isSharedContext && (!memoryProperties.flags.useHostPtr || context->getMemoryManager()->isLocalMemorySupported(device->getRootDeviceIndex())) && !memoryProperties.flags.forceHostMemory; @@ -768,7 +768,7 @@ HWTEST_F(PerformanceHintTest, givenCompressedImageWhenItsCreatedThenProperPerfor graphicsAllocation->setDefaultGmm(gmm); - if (!HwHelperHw::get().checkResourceCompatibility(*graphicsAllocation)) { + if (!GfxCoreHelperHw::get().checkResourceCompatibility(*graphicsAllocation)) { GTEST_SKIP(); } @@ -802,7 +802,7 @@ HWTEST_F(PerformanceHintTest, givenCompressedImageWhenItsCreatedThenProperPerfor snprintf(expectedHint, DriverDiagnostics::maxHintStringSize, DriverDiagnostics::hintFormat[IMAGE_IS_COMPRESSED], image.get()); alignedFree(hostPtr); - if (HwHelper::compressedImagesSupported(hwInfo)) { + if (GfxCoreHelper::compressedImagesSupported(hwInfo)) { EXPECT_TRUE(containsHint(expectedHint, userData)); } else { EXPECT_FALSE(containsHint(expectedHint, userData)); @@ -865,7 +865,7 @@ TEST_F(PerformanceHintTest, givenUncompressedImageWhenItsCreatedThenProperPerfor snprintf(expectedHint, DriverDiagnostics::maxHintStringSize, DriverDiagnostics::hintFormat[IMAGE_IS_NOT_COMPRESSED], image.get()); alignedFree(hostPtr); - if (HwHelper::compressedImagesSupported(hwInfo)) { + if (GfxCoreHelper::compressedImagesSupported(hwInfo)) { EXPECT_TRUE(containsHint(expectedHint, userData)); } else { EXPECT_FALSE(containsHint(expectedHint, userData)); diff --git a/opencl/test/unit_test/device/device_caps_tests.cpp b/opencl/test/unit_test/device/device_caps_tests.cpp index a490065340..83fc2ddbf7 100644 --- a/opencl/test/unit_test/device/device_caps_tests.cpp +++ b/opencl/test/unit_test/device/device_caps_tests.cpp @@ -116,7 +116,7 @@ TEST_F(DeviceGetCapsTest, WhenCreatingDeviceThenCapsArePopulatedCorrectly) { const auto &caps = device->getDeviceInfo(); const auto &sharedCaps = device->getSharedDeviceInfo(); const auto &sysInfo = defaultHwInfo->gtSystemInfo; - auto &hwHelper = device->getRootDeviceEnvironment().getHelper(); + auto &gfxCoreHelper = device->getRootDeviceEnvironment().getHelper(); EXPECT_NE(nullptr, caps.builtInKernels); @@ -189,7 +189,7 @@ TEST_F(DeviceGetCapsTest, WhenCreatingDeviceThenCapsArePopulatedCorrectly) { EXPECT_EQ(sharedCaps.maxWorkItemSizes[0], sharedCaps.maxWorkGroupSize); EXPECT_EQ(sharedCaps.maxWorkItemSizes[1], sharedCaps.maxWorkGroupSize); EXPECT_EQ(sharedCaps.maxWorkItemSizes[2], sharedCaps.maxWorkGroupSize); - EXPECT_EQ(hwHelper.getMaxNumSamplers(), sharedCaps.maxSamplers); + EXPECT_EQ(gfxCoreHelper.getMaxNumSamplers(), sharedCaps.maxSamplers); // Minimum requirements for OpenCL 1.x EXPECT_EQ(static_cast(CL_FP_ROUND_TO_NEAREST), CL_FP_ROUND_TO_NEAREST & caps.singleFpConfig); @@ -213,14 +213,14 @@ TEST_F(DeviceGetCapsTest, WhenCreatingDeviceThenCapsArePopulatedCorrectly) { EXPECT_EQ(1u, caps.endianLittle); - auto expectedDeviceSubgroups = hwHelper.getDeviceSubGroupSizes(); + auto expectedDeviceSubgroups = gfxCoreHelper.getDeviceSubGroupSizes(); EXPECT_EQ(expectedDeviceSubgroups.size(), sharedCaps.maxSubGroups.size()); for (uint32_t i = 0; i < expectedDeviceSubgroups.size(); i++) { EXPECT_EQ(expectedDeviceSubgroups[i], sharedCaps.maxSubGroups[i]); } - auto expectedMaxNumOfSubGroups = device->areOcl21FeaturesEnabled() ? sharedCaps.maxWorkGroupSize / hwHelper.getMinimalSIMDSize() : 0u; + auto expectedMaxNumOfSubGroups = device->areOcl21FeaturesEnabled() ? sharedCaps.maxWorkGroupSize / gfxCoreHelper.getMinimalSIMDSize() : 0u; EXPECT_EQ(expectedMaxNumOfSubGroups, caps.maxNumOfSubGroups); EXPECT_EQ(0u, caps.maxOnDeviceEvents); @@ -244,7 +244,7 @@ TEST_F(DeviceGetCapsTest, WhenCreatingDeviceThenCapsArePopulatedCorrectly) { EXPECT_EQ(64u, caps.preferredPlatformAtomicAlignment); EXPECT_TRUE(caps.nonUniformWorkGroupSupport); - auto expectedPreferredWorkGroupSizeMultiple = hwHelper.isFusedEuDispatchEnabled(*defaultHwInfo, false) + auto expectedPreferredWorkGroupSizeMultiple = gfxCoreHelper.isFusedEuDispatchEnabled(*defaultHwInfo, false) ? CommonConstants::maximalSimdSize * 2 : CommonConstants::maximalSimdSize; EXPECT_EQ(expectedPreferredWorkGroupSizeMultiple, caps.preferredWorkGroupSizeMultiple); @@ -260,9 +260,9 @@ TEST_F(DeviceGetCapsTest, WhenCreatingDeviceThenCapsArePopulatedCorrectly) { HWTEST_F(DeviceGetCapsTest, givenDeviceWhenAskingForSubGroupSizesThenReturnCorrectValues) { auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(defaultHwInfo.get())); - auto &hwHelper = HwHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily); - auto deviceSubgroups = hwHelper.getDeviceSubGroupSizes(); + auto deviceSubgroups = gfxCoreHelper.getDeviceSubGroupSizes(); EXPECT_EQ(3u, deviceSubgroups.size()); EXPECT_EQ(8u, deviceSubgroups[0]); @@ -443,7 +443,7 @@ HWTEST_F(DeviceGetCapsTest, givenGlobalMemSizeAndSharedSystemAllocationsNotSuppo const auto &caps = device->getSharedDeviceInfo(); uint64_t expectedSize = std::max((caps.globalMemSize / 2), static_cast(128ULL * MemoryConstants::megaByte)); - expectedSize = std::min(expectedSize, HwHelperHw::get().getMaxMemAllocSize()); + expectedSize = std::min(expectedSize, GfxCoreHelperHw::get().getMaxMemAllocSize()); EXPECT_EQ(caps.maxMemAllocSize, expectedSize); } @@ -945,8 +945,8 @@ TEST_F(DeviceGetCapsTest, givenNotSupporteImagesWhenCreateExtentionsListThenDevi TEST_F(DeviceGetCapsTest, givenDeviceWhenGettingHostUnifiedMemoryCapThenItDependsOnLocalMemory) { auto device = std::make_unique(MockDevice::createWithNewExecutionEnvironment(defaultHwInfo.get())); const auto &caps = device->getDeviceInfo(); - auto &coreHelper = device->getRootDeviceEnvironment().getHelper(); - auto localMemoryEnabled = coreHelper.isLocalMemoryEnabled(*defaultHwInfo); + auto &gfxCoreHelper = device->getRootDeviceEnvironment().getHelper(); + auto localMemoryEnabled = gfxCoreHelper.isLocalMemoryEnabled(*defaultHwInfo); EXPECT_EQ((localMemoryEnabled == false), caps.hostUnifiedMemory); } @@ -1058,7 +1058,7 @@ HWTEST_F(DeviceGetCapsTest, givenDisabledFtrPooledEuWhenCalculatingMaxEuPerSSThe auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&myHwInfo)); auto &deviceInfo = device->deviceInfo; - auto simdSizeUsed = HwHelperHw::get().getMinimalSIMDSize(); + auto simdSizeUsed = GfxCoreHelperHw::get().getMinimalSIMDSize(); auto hwInfoConfig = HwInfoConfig::get(myHwInfo.platform.eProductFamily); auto expectedMaxWGS = hwInfoConfig->getMaxThreadsForWorkgroupInDSSOrSS(myHwInfo, static_cast(deviceInfo.maxNumEUsPerSubSlice), @@ -1110,15 +1110,15 @@ HWTEST_F(DeviceGetCapsTest, givenDeviceThatHasHighNumberOfExecutionUnitsWhenMaxW HardwareInfo myHwInfo = *defaultHwInfo; GT_SYSTEM_INFO &mySysInfo = myHwInfo.gtSystemInfo; - auto &hwHelper = HwHelper::get(myHwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(myHwInfo.platform.eRenderCoreFamily); mySysInfo.EUCount = 32; mySysInfo.SubSliceCount = 2; - mySysInfo.ThreadCount = 32 * hwHelper.getMinimalSIMDSize(); // 128 threads per subslice, in simd 8 gives 1024 + mySysInfo.ThreadCount = 32 * gfxCoreHelper.getMinimalSIMDSize(); // 128 threads per subslice, in simd 8 gives 1024 auto device = std::make_unique(MockDevice::createWithNewExecutionEnvironment(&myHwInfo)); EXPECT_EQ(1024u, device->getSharedDeviceInfo().maxWorkGroupSize); - EXPECT_EQ(device->getSharedDeviceInfo().maxWorkGroupSize / hwHelper.getMinimalSIMDSize(), device->getDeviceInfo().maxNumOfSubGroups); + EXPECT_EQ(device->getSharedDeviceInfo().maxWorkGroupSize / gfxCoreHelper.getMinimalSIMDSize(), device->getDeviceInfo().maxNumOfSubGroups); } TEST_F(DeviceGetCapsTest, givenSystemWithDriverInfoWhenGettingNameAndVersionThenReturnValuesFromDriverInfo) { @@ -1196,7 +1196,7 @@ TEST_F(DeviceGetCapsTest, givenPciBusInfoThenPciBusInfoExtensionAvailable) { static bool getPlanarYuvHeightCalled = false; template -class MyMockHwHelper : public HwHelperHw { +class MyMockGfxCoreHelper : public GfxCoreHelperHw { public: uint32_t getPlanarYuvMaxHeight() const override { getPlanarYuvHeightCalled = true; @@ -1207,7 +1207,7 @@ class MyMockHwHelper : public HwHelperHw { HWTEST_F(DeviceGetCapsTest, givenDeviceWhenInitializingCapsThenPlanarYuvHeightIsTakenFromHelper) { auto device = std::make_unique(MockDevice::createWithNewExecutionEnvironment(defaultHwInfo.get())); - RAIIHwHelperFactory> hwHelperBackup{device->getHardwareInfo().platform.eRenderCoreFamily}; + RAIIGfxCoreHelperFactory> gfxCoreHelperBackup{device->getHardwareInfo().platform.eRenderCoreFamily}; DriverInfoMock *driverInfoMock = new DriverInfoMock(); device->driverInfo.reset(driverInfoMock); @@ -1215,7 +1215,7 @@ HWTEST_F(DeviceGetCapsTest, givenDeviceWhenInitializingCapsThenPlanarYuvHeightIs EXPECT_TRUE(getPlanarYuvHeightCalled); getPlanarYuvHeightCalled = false; const auto &caps = device->getDeviceInfo(); - EXPECT_EQ(hwHelperBackup.mockHwHelper.dummyPlanarYuvValue, caps.planarYuvMaxHeight); + EXPECT_EQ(gfxCoreHelperBackup.mockGfxCoreHelper.dummyPlanarYuvValue, caps.planarYuvMaxHeight); } TEST_F(DeviceGetCapsTest, givenSystemWithNoDriverInfoWhenGettingNameAndVersionThenReturnDefaultValues) { @@ -1424,7 +1424,7 @@ TEST(Device_UseCaps, givenOverrideSlmSizeWhenWhenInitializeDeviceThenSlmSizeInDe EXPECT_EQ(newSlmSize, static_cast(deviceInfoWithForceSlmFlag.localMemSize / KB)); } -typedef HwHelperTest DeviceCapsWithModifiedHwInfoTest; +typedef GfxCoreHelperTest DeviceCapsWithModifiedHwInfoTest; TEST_F(DeviceCapsWithModifiedHwInfoTest, givenPlatformWithSourceLevelDebuggerNotSupportedWhenDeviceIsCreatedThenSourceLevelDebuggerActiveIsSetToFalse) { @@ -1511,8 +1511,8 @@ HWTEST2_F(DeviceGetCapsTest, givenSysInfoWhenDeviceCreatedThenMaxWorkGroupSizeIs mySysInfo.ThreadCount = 16 * 8; myPlatform.usRevId = 0x4; auto device = std::make_unique(MockDevice::createWithNewExecutionEnvironment(&myHwInfo)); - auto &hwHelper = HwHelper::get(myHwInfo.platform.eRenderCoreFamily); - auto minSimd = hwHelper.getMinimalSIMDSize(); + auto &gfxCoreHelper = GfxCoreHelper::get(myHwInfo.platform.eRenderCoreFamily); + auto minSimd = gfxCoreHelper.getMinimalSIMDSize(); size_t expectedWGSize = (mySysInfo.ThreadCount / mySysInfo.SubSliceCount) * minSimd; @@ -1531,8 +1531,8 @@ HWTEST2_F(DeviceGetCapsTest, givenSysInfoWhenDeviceCreatedThenMaxWorkGroupSizeIs mySysInfo.ThreadCount = 16 * 8; myPlatform.usRevId = 0x4; auto device = std::make_unique(MockDevice::createWithNewExecutionEnvironment(&myHwInfo)); - auto &hwHelper = HwHelper::get(myHwInfo.platform.eRenderCoreFamily); - auto minSimd = hwHelper.getMinimalSIMDSize(); + auto &gfxCoreHelper = GfxCoreHelper::get(myHwInfo.platform.eRenderCoreFamily); + auto minSimd = gfxCoreHelper.getMinimalSIMDSize(); size_t expectedWGSize = (mySysInfo.ThreadCount / mySysInfo.DualSubSliceCount) * minSimd; EXPECT_EQ(expectedWGSize, device->sharedDeviceInfo.maxWorkGroupSize); diff --git a/opencl/test/unit_test/device/device_tests.cpp b/opencl/test/unit_test/device/device_tests.cpp index 634652c920..814942a8b9 100644 --- a/opencl/test/unit_test/device/device_tests.cpp +++ b/opencl/test/unit_test/device/device_tests.cpp @@ -71,7 +71,7 @@ TEST_F(DeviceTest, givenDeviceWhenAskedForSpecificEngineThenReturnIt) { MockClDevice mockClDevice{MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)}; - auto &engines = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); for (uint32_t i = 0; i < engines.size(); i++) { auto &deviceEngine = mockClDevice.getEngine(engines[i].first, EngineUsage::Regular); EXPECT_EQ(deviceEngine.osContext->getEngineType(), engines[i].first); @@ -88,7 +88,7 @@ TEST_F(DeviceTest, givenDeviceWhenAskedForSpecificEngineThenReturnIt) { TEST_F(DeviceTest, givenDebugVariableToAlwaysChooseEngineZeroWhenNotExistingEngineSelectedThenIndexZeroEngineIsReturned) { DebugManagerStateRestore restore; DebugManager.flags.OverrideInvalidEngineWithDefault.set(true); - auto &engines = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo); + auto &engines = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo); auto &deviceEngine = pDevice->getEngine(engines[0].first, EngineUsage::Regular); auto ¬ExistingEngine = pDevice->getEngine(aub_stream::ENGINE_VCS, EngineUsage::Regular); EXPECT_EQ(¬ExistingEngine, &deviceEngine); @@ -269,7 +269,7 @@ TEST(DeviceCreation, givenDeviceWhenItIsCreatedThenOsContextIsRegistredInMemoryM hwInfo.capabilityTable.blitterOperationsSupported = true; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo)); auto memoryManager = device->getMemoryManager(); - auto numEnginesForDevice = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo).size(); + auto numEnginesForDevice = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo).size(); if (device->getNumGenericSubDevices() > 1) { numEnginesForDevice *= device->getNumGenericSubDevices(); numEnginesForDevice += device->allEngines.size(); @@ -301,7 +301,7 @@ TEST(DeviceCreation, givenMultiRootDeviceWhenTheyAreCreatedThenEachOsContextHasU auto ®isteredEngines = executionEnvironment->memoryManager->getRegisteredEngines(); auto &hwInfo = device1->getHardwareInfo(); - const auto &numGpgpuEngines = static_cast(HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo).size()); + const auto &numGpgpuEngines = static_cast(GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo).size()); size_t numExpectedGenericEnginesPerDevice = numGpgpuEngines; size_t numExpectedEngineInstancedEnginesPerDevice = 0; @@ -371,7 +371,7 @@ TEST(DeviceCreation, givenMultiRootDeviceWhenTheyAreCreatedThenEachDeviceHasSepe executionEnvironment->rootDeviceEnvironments[i]->getMutableHardwareInfo()->capabilityTable.blitterOperationsSupported = true; } auto hwInfo = *executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo(); - const auto &numGpgpuEngines = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo).size(); + const auto &numGpgpuEngines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo).size(); auto device1 = std::unique_ptr(Device::create(executionEnvironment, 0u)); auto device2 = std::unique_ptr(Device::create(executionEnvironment, 1u)); @@ -386,8 +386,8 @@ TEST(DeviceCreation, givenMultiRootDeviceWhenTheyAreCreatedThenEachDeviceHasSepe HWTEST_F(DeviceTest, givenDeviceWhenAskingForDefaultEngineThenReturnValidValue) { ExecutionEnvironment *executionEnvironment = platform()->peekExecutionEnvironment(); executionEnvironment->prepareRootDeviceEnvironments(1u); - auto &coreHelper = getHelper(); - coreHelper.adjustDefaultEngineType(executionEnvironment->rootDeviceEnvironments[0]->getMutableHardwareInfo()); + auto &gfxCoreHelper = getHelper(); + gfxCoreHelper.adjustDefaultEngineType(executionEnvironment->rootDeviceEnvironments[0]->getMutableHardwareInfo()); auto device = std::unique_ptr(Device::create(executionEnvironment, 0)); auto osContext = device->getDefaultEngine().osContext; @@ -451,8 +451,8 @@ HWTEST_F(DeviceTest, givenDebugFlagWhenCreatingRootDeviceWithoutSubDevicesThenWo TEST(DeviceCreation, givenDeviceWhenCheckingGpgpuEnginesCountThenNumberGreaterThanZeroIsReturned) { auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(nullptr)); - auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_GT(hwHelper.getGpgpuEngineInstances(device->getHardwareInfo()).size(), 0u); + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_GT(gfxCoreHelper.getGpgpuEngineInstances(device->getHardwareInfo()).size(), 0u); } TEST(DeviceCreation, givenDeviceWhenCheckingParentDeviceThenCorrectValueIsReturned) { @@ -499,7 +499,7 @@ TEST(DeviceCreation, whenCheckingEngineGroupsThenGroupsAreUnique) { using DeviceHwTest = ::testing::Test; -HWTEST_F(DeviceHwTest, givenHwHelperInputWhenInitializingCsrThenCreatePageTableManagerIfNeeded) { +HWTEST_F(DeviceHwTest, givenGfxCoreHelperInputWhenInitializingCsrThenCreatePageTableManagerIfNeeded) { HardwareInfo localHwInfo = *defaultHwInfo; localHwInfo.capabilityTable.ftrRenderCompressedBuffers = false; localHwInfo.capabilityTable.ftrRenderCompressedImages = false; @@ -557,7 +557,7 @@ HWTEST_F(DeviceHwTest, givenDeviceCreationWhenCsrFailsToCreateGlobalSyncAllocati } HWTEST_F(DeviceHwTest, givenBothCcsAndRcsEnginesInDeviceWhenGettingEngineGroupsThenReturnInCorrectOrder) { - struct MyHwHelper : HwHelperHw { + struct MyGfxCoreHelper : GfxCoreHelperHw { EngineGroupType getEngineGroupType(aub_stream::EngineType engineType, EngineUsage engineUsage, const HardwareInfo &hwInfo) const override { if (engineType == aub_stream::ENGINE_RCS) { return EngineGroupType::RenderCompute; @@ -568,7 +568,7 @@ HWTEST_F(DeviceHwTest, givenBothCcsAndRcsEnginesInDeviceWhenGettingEngineGroupsT UNRECOVERABLE_IF(true); } }; - RAIIHwHelperFactory overrideHwHelper{::defaultHwInfo->platform.eRenderCoreFamily}; + RAIIGfxCoreHelperFactory overrideGfxCoreHelper{::defaultHwInfo->platform.eRenderCoreFamily}; MockOsContext rcsContext(0, EngineDescriptorHelper::getDefaultDescriptor({aub_stream::EngineType::ENGINE_RCS, EngineUsage::Regular})); EngineControl rcsEngine{nullptr, &rcsContext}; @@ -733,7 +733,7 @@ TEST(ClDeviceHelperTest, givenNonZeroNumberOfTilesWhenPrepareDeviceEnvironmentsC HardwareInfo hwInfo{&platform, &skuTable, &waTable, &sysInfo, capTable}; DebugManager.flags.CreateMultipleSubDevices.set(0); - uint32_t devicesCount = HwHelper::getSubDevicesCount(&hwInfo); + uint32_t devicesCount = GfxCoreHelper::getSubDevicesCount(&hwInfo); EXPECT_EQ(devicesCount, 3u); } @@ -749,6 +749,6 @@ TEST(ClDeviceHelperTest, givenZeroNumberOfTilesWhenPrepareDeviceEnvironmentsCoun HardwareInfo hwInfo{&platform, &skuTable, &waTable, &sysInfo, capTable}; DebugManager.flags.CreateMultipleSubDevices.set(0); - uint32_t devicesCount = HwHelper::getSubDevicesCount(&hwInfo); + uint32_t devicesCount = GfxCoreHelper::getSubDevicesCount(&hwInfo); EXPECT_EQ(devicesCount, 1u); } diff --git a/opencl/test/unit_test/device/get_device_info_tests.cpp b/opencl/test/unit_test/device/get_device_info_tests.cpp index f773366504..bf1f6a90cd 100644 --- a/opencl/test/unit_test/device/get_device_info_tests.cpp +++ b/opencl/test/unit_test/device/get_device_info_tests.cpp @@ -672,7 +672,7 @@ TEST(GetDeviceInfo, WhenQueryingGenericAddressSpaceSupportThenProperValueIsRetur } template -class MockHwHelper : public HwHelperHw { +class MockGfxCoreHelper : public GfxCoreHelperHw { public: const EngineInstancesContainer getGpgpuEngineInstances(const HardwareInfo &hwInfo) const override { EngineInstancesContainer result{}; @@ -709,8 +709,8 @@ class MockHwHelper : public HwHelperHw { return true; } - static auto overrideHwHelper() { - return RAIIHwHelperFactory>{::defaultHwInfo->platform.eRenderCoreFamily}; + static auto overrideGfxCoreHelper() { + return RAIIGfxCoreHelperFactory>{::defaultHwInfo->platform.eRenderCoreFamily}; } uint64_t disableEngineSupportOnSubDevice = -1; // disabled by default @@ -720,7 +720,7 @@ class MockHwHelper : public HwHelperHw { using GetDeviceInfoQueueFamilyTest = ::testing::Test; HWTEST_F(GetDeviceInfoQueueFamilyTest, givenSingleDeviceWhenInitializingCapsThenReturnCorrectFamilies) { - auto raiiHwHelper = MockHwHelper::overrideHwHelper(); + auto raiiGfxCoreHelper = MockGfxCoreHelper::overrideGfxCoreHelper(); VariableBackup backupHwInfo(defaultHwInfo.get()); defaultHwInfo->capabilityTable.blitterOperationsSupported = true; UltClDeviceFactory deviceFactory{1, 0}; @@ -743,7 +743,7 @@ HWTEST_F(GetDeviceInfoQueueFamilyTest, givenSingleDeviceWhenInitializingCapsThen } HWTEST_F(GetDeviceInfoQueueFamilyTest, givenSubDeviceWhenInitializingCapsThenReturnCorrectFamilies) { - auto raiiHwHelper = MockHwHelper::overrideHwHelper(); + auto raiiGfxCoreHelper = MockGfxCoreHelper::overrideGfxCoreHelper(); VariableBackup backupHwInfo(defaultHwInfo.get()); defaultHwInfo->capabilityTable.blitterOperationsSupported = true; UltClDeviceFactory deviceFactory{1, 2}; @@ -768,13 +768,13 @@ HWTEST_F(GetDeviceInfoQueueFamilyTest, givenSubDeviceWhenInitializingCapsThenRet HWTEST_F(GetDeviceInfoQueueFamilyTest, givenSubDeviceWithoutSupportedEngineWhenInitializingCapsThenReturnCorrectFamilies) { constexpr int bcsCount = 1; - using MockHwHelperT = MockHwHelper; + using MockGfxCoreHelperT = MockGfxCoreHelper; - auto raiiHwHelper = MockHwHelperT::overrideHwHelper(); - MockHwHelperT &mockHwHelper = static_cast(raiiHwHelper.mockHwHelper); + auto raiiGfxCoreHelper = MockGfxCoreHelperT::overrideGfxCoreHelper(); + MockGfxCoreHelperT &mockGfxCoreHelper = static_cast(raiiGfxCoreHelper.mockGfxCoreHelper); - mockHwHelper.disableEngineSupportOnSubDevice = 0b10; // subdevice 1 - mockHwHelper.disabledSubDeviceEngineType = aub_stream::EngineType::ENGINE_BCS; + mockGfxCoreHelper.disableEngineSupportOnSubDevice = 0b10; // subdevice 1 + mockGfxCoreHelper.disabledSubDeviceEngineType = aub_stream::EngineType::ENGINE_BCS; VariableBackup backupHwInfo(defaultHwInfo.get()); defaultHwInfo->capabilityTable.blitterOperationsSupported = true; diff --git a/opencl/test/unit_test/device/sub_device_tests.cpp b/opencl/test/unit_test/device/sub_device_tests.cpp index da74df1b6b..f61812352b 100644 --- a/opencl/test/unit_test/device/sub_device_tests.cpp +++ b/opencl/test/unit_test/device/sub_device_tests.cpp @@ -235,7 +235,7 @@ TEST(SubDevicesTest, givenSubDevicesWhenGettingDeviceByIdZeroThenGetThisSubDevic TEST(RootDevicesTest, givenRootDeviceWithoutSubdevicesWhenCreateEnginesThenDeviceCreatesCorrectNumberOfEngines) { auto hwInfo = *defaultHwInfo; hwInfo.capabilityTable.blitterOperationsSupported = true; - auto &gpgpuEngines = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); + auto &gpgpuEngines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); auto executionEnvironment = new MockExecutionEnvironment; executionEnvironment->rootDeviceEnvironments[0]->setHwInfo(&hwInfo); @@ -332,8 +332,8 @@ struct EngineInstancedDeviceTests : public ::testing::Test { hwInfo->gtSystemInfo.CCSInfo.NumberOfCCSEnabled = numCcs; hwInfo->featureTable.flags.ftrCCSNode = (numCcs > 0); hwInfo->capabilityTable.blitterOperationsSupported = true; - auto &coreHelper = rootDeviceEnvironment.getHelper(); - coreHelper.adjustDefaultEngineType(hwInfo); + auto &gfxCoreHelper = rootDeviceEnvironment.getHelper(); + gfxCoreHelper.adjustDefaultEngineType(hwInfo); if (!multiCcsDevice(*hwInfo, numCcs)) { return false; @@ -367,7 +367,7 @@ struct EngineInstancedDeviceTests : public ::testing::Test { template bool hasAllEngines(MockDeviceT *device) { auto &hwInfo = device->getHardwareInfo(); - auto gpgpuEngines = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); + auto gpgpuEngines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); for (size_t i = 0; i < gpgpuEngines.size(); i++) { if (device->allEngines[i].getEngineType() != gpgpuEngines[i].first) { @@ -379,7 +379,7 @@ struct EngineInstancedDeviceTests : public ::testing::Test { } bool multiCcsDevice(const HardwareInfo &hwInfo, uint32_t expectedNumCcs) { - auto gpgpuEngines = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); + auto gpgpuEngines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); uint32_t numCcs = 0; @@ -584,7 +584,7 @@ TEST_F(EngineInstancedDeviceTests, givenEngineInstancedSubDeviceWhenEngineCreati auto subDevice = static_cast(rootDevice->getSubDevice(0)); auto &hwInfo = rootDevice->getHardwareInfo(); - auto gpgpuEngines = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); + auto gpgpuEngines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); subDevice->engineInstanced = true; subDevice->failOnCreateEngine = true; @@ -990,9 +990,9 @@ HWTEST_F(EngineInstancedDeviceTests, whenCreateMultipleCommandQueuesThenEnginesA } auto &hwInfo = rootDevice->getHardwareInfo(); - const auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + const auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - if (!hwHelper.isAssignEngineRoundRobinSupported(hwInfo)) { + if (!gfxCoreHelper.isAssignEngineRoundRobinSupported(hwInfo)) { GTEST_SKIP(); } @@ -1009,7 +1009,7 @@ HWTEST_F(EngineInstancedDeviceTests, whenCreateMultipleCommandQueuesThenEnginesA } const auto &defaultEngine = clRootDevice->getDefaultEngine(); - const auto engineGroupType = hwHelper.getEngineGroupType(defaultEngine.getEngineType(), defaultEngine.getEngineUsage(), hwInfo); + const auto engineGroupType = gfxCoreHelper.getEngineGroupType(defaultEngine.getEngineType(), defaultEngine.getEngineUsage(), hwInfo); auto defaultEngineGroupIndex = clRootDevice->getDevice().getEngineGroupIndexFromEngineGroupType(engineGroupType); auto engines = clRootDevice->getDevice().getRegularEngineGroups()[defaultEngineGroupIndex].engines; @@ -1036,9 +1036,9 @@ HWTEST_F(EngineInstancedDeviceTests, givenCmdQRoundRobindEngineAssignBitfieldwWe } auto &hwInfo = rootDevice->getHardwareInfo(); - const auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + const auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - if (!hwHelper.isAssignEngineRoundRobinSupported(hwInfo)) { + if (!gfxCoreHelper.isAssignEngineRoundRobinSupported(hwInfo)) { GTEST_SKIP(); } @@ -1055,7 +1055,7 @@ HWTEST_F(EngineInstancedDeviceTests, givenCmdQRoundRobindEngineAssignBitfieldwWe } const auto &defaultEngine = clRootDevice->getDefaultEngine(); - const auto engineGroupType = hwHelper.getEngineGroupType(defaultEngine.getEngineType(), defaultEngine.getEngineUsage(), hwInfo); + const auto engineGroupType = gfxCoreHelper.getEngineGroupType(defaultEngine.getEngineType(), defaultEngine.getEngineUsage(), hwInfo); auto defaultEngineGroupIndex = clRootDevice->getDevice().getEngineGroupIndexFromEngineGroupType(engineGroupType); auto engines = clRootDevice->getDevice().getRegularEngineGroups()[defaultEngineGroupIndex].engines; @@ -1085,9 +1085,9 @@ HWTEST_F(EngineInstancedDeviceTests, givenCmdQRoundRobindEngineAssignNTo1wWenCre } auto &hwInfo = rootDevice->getHardwareInfo(); - const auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + const auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - if (!hwHelper.isAssignEngineRoundRobinSupported(hwInfo)) { + if (!gfxCoreHelper.isAssignEngineRoundRobinSupported(hwInfo)) { GTEST_SKIP(); } @@ -1104,7 +1104,7 @@ HWTEST_F(EngineInstancedDeviceTests, givenCmdQRoundRobindEngineAssignNTo1wWenCre } const auto &defaultEngine = clRootDevice->getDefaultEngine(); - const auto engineGroupType = hwHelper.getEngineGroupType(defaultEngine.getEngineType(), defaultEngine.getEngineUsage(), hwInfo); + const auto engineGroupType = gfxCoreHelper.getEngineGroupType(defaultEngine.getEngineType(), defaultEngine.getEngineUsage(), hwInfo); auto defaultEngineGroupIndex = clRootDevice->getDevice().getEngineGroupIndexFromEngineGroupType(engineGroupType); auto engines = clRootDevice->getDevice().getRegularEngineGroups()[defaultEngineGroupIndex].engines; @@ -1132,9 +1132,9 @@ HWTEST_F(EngineInstancedDeviceTests, givenCmdQRoundRobindEngineAssignNTo1AndCmdQ } auto &hwInfo = rootDevice->getHardwareInfo(); - const auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + const auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - if (!hwHelper.isAssignEngineRoundRobinSupported(hwInfo)) { + if (!gfxCoreHelper.isAssignEngineRoundRobinSupported(hwInfo)) { GTEST_SKIP(); } @@ -1151,7 +1151,7 @@ HWTEST_F(EngineInstancedDeviceTests, givenCmdQRoundRobindEngineAssignNTo1AndCmdQ } const auto &defaultEngine = clRootDevice->getDefaultEngine(); - const auto engineGroupType = hwHelper.getEngineGroupType(defaultEngine.getEngineType(), defaultEngine.getEngineUsage(), hwInfo); + const auto engineGroupType = gfxCoreHelper.getEngineGroupType(defaultEngine.getEngineType(), defaultEngine.getEngineUsage(), hwInfo); auto defaultEngineGroupIndex = clRootDevice->getDevice().getEngineGroupIndexFromEngineGroupType(engineGroupType); auto engines = clRootDevice->getDevice().getRegularEngineGroups()[defaultEngineGroupIndex].engines; @@ -1180,9 +1180,9 @@ HWTEST_F(EngineInstancedDeviceTests, givenEnableCmdQRoundRobindEngineAssignDisab } auto &hwInfo = rootDevice->getHardwareInfo(); - const auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); + const auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - if (!hwHelper.isAssignEngineRoundRobinSupported(hwInfo)) { + if (!gfxCoreHelper.isAssignEngineRoundRobinSupported(hwInfo)) { GTEST_SKIP(); } diff --git a/opencl/test/unit_test/event/event_tests.cpp b/opencl/test/unit_test/event/event_tests.cpp index 1fc3e4b475..022ad0a1c1 100644 --- a/opencl/test/unit_test/event/event_tests.cpp +++ b/opencl/test/unit_test/event/event_tests.cpp @@ -829,8 +829,8 @@ TEST_F(InternalsEventTest, givenDeviceTimestampBaseNotEnabledWhenCalculateStartT event.getEventProfilingInfo(CL_PROFILING_COMMAND_START, sizeof(cl_ulong), &start, nullptr); auto resolution = pClDevice->getDevice().getDeviceInfo().profilingTimerResolution; - auto &hwHelper = HwHelper::get(pClDevice->getHardwareInfo().platform.eRenderCoreFamily); - auto c0 = event.queueTimeStamp.CPUTimeinNS - hwHelper.getGpuTimeStampInNS(event.queueTimeStamp.GPUTimeStamp, resolution); + auto &gfxCoreHelper = GfxCoreHelper::get(pClDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto c0 = event.queueTimeStamp.CPUTimeinNS - gfxCoreHelper.getGpuTimeStampInNS(event.queueTimeStamp.GPUTimeStamp, resolution); EXPECT_EQ(start, static_cast(timestamp.GlobalStartTS * resolution) + c0); event.timeStampNode = nullptr; @@ -888,9 +888,9 @@ TEST_F(InternalsEventTest, givenDeviceTimestampBaseEnabledAndGlobalStartTSSmalle uint64_t start = 0u; event.getEventProfilingInfo(CL_PROFILING_COMMAND_START, sizeof(cl_ulong), &start, nullptr); - auto &hwHelper = HwHelper::get(pClDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pClDevice->getHardwareInfo().platform.eRenderCoreFamily); auto resolution = pClDevice->getDevice().getDeviceInfo().profilingTimerResolution; - auto refStartTime = static_cast(timestamp.GlobalStartTS * resolution + (1ULL << hwHelper.getGlobalTimeStampBits()) * resolution); + auto refStartTime = static_cast(timestamp.GlobalStartTS * resolution + (1ULL << gfxCoreHelper.getGlobalTimeStampBits()) * resolution); EXPECT_EQ(start, refStartTime); event.timeStampNode = nullptr; diff --git a/opencl/test/unit_test/execution_environment/execution_environment_tests.cpp b/opencl/test/unit_test/execution_environment/execution_environment_tests.cpp index 32416db926..012d069b77 100644 --- a/opencl/test/unit_test/execution_environment/execution_environment_tests.cpp +++ b/opencl/test/unit_test/execution_environment/execution_environment_tests.cpp @@ -158,7 +158,7 @@ TEST(ExecutionEnvironment, givenExecutionEnvironmentWhenInitializeMemoryManagerI const HardwareInfo *hwInfo = defaultHwInfo.get(); auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(hwInfo)); auto executionEnvironment = device->getExecutionEnvironment(); - auto enableLocalMemory = HwHelper::get(hwInfo->platform.eRenderCoreFamily).getEnableLocalMemory(*hwInfo); + auto enableLocalMemory = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getEnableLocalMemory(*hwInfo); executionEnvironment->initializeMemoryManager(); EXPECT_EQ(enableLocalMemory, executionEnvironment->memoryManager->isLocalMemorySupported(device->getRootDeviceIndex())); } @@ -439,9 +439,9 @@ TEST(ExecutionEnvironment, whenCalculateMaxOsContexCountThenGlobalVariableHasPro for (const auto &rootDeviceEnvironment : executionEnvironment.rootDeviceEnvironments) { auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo->platform.eRenderCoreFamily); - auto osContextCount = hwHelper.getGpgpuEngineInstances(*hwInfo).size(); - auto subDevicesCount = HwHelper::getSubDevicesCount(hwInfo); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily); + auto osContextCount = gfxCoreHelper.getGpgpuEngineInstances(*hwInfo).size(); + auto subDevicesCount = GfxCoreHelper::getSubDevicesCount(hwInfo); bool hasRootCsr = subDevicesCount > 1; auto ccsCount = hwInfo->gtSystemInfo.CCSInfo.NumberOfCCSEnabled; diff --git a/opencl/test/unit_test/fixtures/cl_device_fixture.cpp b/opencl/test/unit_test/fixtures/cl_device_fixture.cpp index dffac35be5..d7f50d027c 100644 --- a/opencl/test/unit_test/fixtures/cl_device_fixture.cpp +++ b/opencl/test/unit_test/fixtures/cl_device_fixture.cpp @@ -55,6 +55,6 @@ HelperType &ClDeviceFixture::getHelper() const { } template ProductHelper &ClDeviceFixture::getHelper() const; -template CoreHelper &ClDeviceFixture::getHelper() const; +template GfxCoreHelper &ClDeviceFixture::getHelper() const; template ClGfxCoreHelper &ClDeviceFixture::getHelper() const; } // namespace NEO diff --git a/opencl/test/unit_test/fixtures/kernel_data_fixture.cpp b/opencl/test/unit_test/fixtures/kernel_data_fixture.cpp index a3cfabadce..f87f891c73 100644 --- a/opencl/test/unit_test/fixtures/kernel_data_fixture.cpp +++ b/opencl/test/unit_test/fixtures/kernel_data_fixture.cpp @@ -117,7 +117,7 @@ void KernelDataTest::buildAndDecode() { auto kernelAllocation = pKernelInfo->getGraphicsAllocation(); UNRECOVERABLE_IF(kernelAllocation == nullptr); auto &device = pContext->getDevice(0)->getDevice(); - auto &helper = device.getRootDeviceEnvironment().getHelper(); + auto &helper = device.getRootDeviceEnvironment().getHelper(); size_t isaPadding = helper.getPaddingForISAAllocation(); EXPECT_EQ(kernelAllocation->getUnderlyingBufferSize(), kernelHeapSize + isaPadding); auto kernelIsa = kernelAllocation->getUnderlyingBuffer(); diff --git a/opencl/test/unit_test/fixtures/ult_command_stream_receiver_fixture.h b/opencl/test/unit_test/fixtures/ult_command_stream_receiver_fixture.h index ce187f18c1..1daa7d927b 100644 --- a/opencl/test/unit_test/fixtures/ult_command_stream_receiver_fixture.h +++ b/opencl/test/unit_test/fixtures/ult_command_stream_receiver_fixture.h @@ -43,7 +43,7 @@ struct UltCommandStreamReceiverTest initHeaps(); - flushTaskFlags.threadArbitrationPolicy = NEO::HwHelper::get(hardwareInfo.platform.eRenderCoreFamily).getDefaultThreadArbitrationPolicy(); + flushTaskFlags.threadArbitrationPolicy = NEO::GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily).getDefaultThreadArbitrationPolicy(); pDevice->getGpgpuCommandStreamReceiver().setupContext(*pDevice->getDefaultEngine().osContext); } @@ -141,8 +141,8 @@ struct UltCommandStreamReceiverTest commandStreamReceiver.lastPreemptionMode = pDevice->getPreemptionMode(); commandStreamReceiver.setMediaVFEStateDirty(false); auto gmmHelper = pDevice->getGmmHelper(); - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eDisplayCoreFamily); - auto mocsIndex = hwHelper.getMocsIndex(*gmmHelper, true, isL1CacheEnabled); + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eDisplayCoreFamily); + auto mocsIndex = gfxCoreHelper.getMocsIndex(*gmmHelper, true, isL1CacheEnabled); commandStreamReceiver.latestSentStatelessMocsConfig = mocsIndex; commandStreamReceiver.lastSentL3Config = l3Config; @@ -153,7 +153,7 @@ struct UltCommandStreamReceiverTest commandStreamReceiver.lastSentUseGlobalAtomics = false; commandStreamReceiver.streamProperties.pipelineSelect.setProperties(true, false, false, *defaultHwInfo); commandStreamReceiver.streamProperties.stateComputeMode.setProperties(0, GrfConfig::DefaultGrfNumber, - hwHelper.getDefaultThreadArbitrationPolicy(), pDevice->getPreemptionMode(), *defaultHwInfo); + gfxCoreHelper.getDefaultThreadArbitrationPolicy(), pDevice->getPreemptionMode(), *defaultHwInfo); commandStreamReceiver.streamProperties.frontEndState.setProperties(false, false, false, -1, *defaultHwInfo); auto logicalStateHelper = commandStreamReceiver.getLogicalStateHelper(); diff --git a/opencl/test/unit_test/gen11/enqueue_kernel_gen11.cpp b/opencl/test/unit_test/gen11/enqueue_kernel_gen11.cpp index ca2a305f1c..7063024c50 100644 --- a/opencl/test/unit_test/gen11/enqueue_kernel_gen11.cpp +++ b/opencl/test/unit_test/gen11/enqueue_kernel_gen11.cpp @@ -35,7 +35,7 @@ GEN11TEST_F(Gen11EnqueueTest, givenKernelRequiringIndependentForwardProgressWhen auto cmd = findMmioCmd(hwParser.cmdList.begin(), hwParser.cmdList.end(), RowChickenReg4::address); ASSERT_NE(nullptr, cmd); - EXPECT_EQ(RowChickenReg4::regDataForArbitrationPolicy[HwHelperHw::get().getDefaultThreadArbitrationPolicy()], cmd->getDataDword()); + EXPECT_EQ(RowChickenReg4::regDataForArbitrationPolicy[GfxCoreHelperHw::get().getDefaultThreadArbitrationPolicy()], cmd->getDataDword()); EXPECT_EQ(1U, countMmio(hwParser.cmdList.begin(), hwParser.cmdList.end(), RowChickenReg4::address)); } diff --git a/opencl/test/unit_test/gen12lp/hw_helper_tests_gen12lp.inl b/opencl/test/unit_test/gen12lp/hw_helper_tests_gen12lp.inl index dbbce19c61..90d9d13850 100644 --- a/opencl/test/unit_test/gen12lp/hw_helper_tests_gen12lp.inl +++ b/opencl/test/unit_test/gen12lp/hw_helper_tests_gen12lp.inl @@ -66,34 +66,34 @@ GEN12LPTEST_F(ClGfxCoreHelperTestsGen12Lp, WhenGettingSupportedDeviceFeatureCapa EXPECT_EQ(expectedCapabilities, ClGfxCoreHelper::get(renderCoreFamily).getSupportedDeviceFeatureCapabilities(hardwareInfo)); } -using HwHelperTestGen12Lp = HwHelperTest; +using GfxCoreHelperTestGen12Lp = GfxCoreHelperTest; -GEN12LPTEST_F(HwHelperTestGen12Lp, WhenGettingMaxBarriersPerSliceThenCorrectSizeIsReturned) { - auto &helper = getHelper(); +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, WhenGettingMaxBarriersPerSliceThenCorrectSizeIsReturned) { + auto &helper = getHelper(); EXPECT_EQ(32u, helper.getMaxBarrierRegisterPerSlice()); } -GEN12LPTEST_F(HwHelperTestGen12Lp, WhenGettingPitchAlignmentForImageThenCorrectValueIsReturned) { - auto &coreHelper = getHelper(); +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, WhenGettingPitchAlignmentForImageThenCorrectValueIsReturned) { + auto &gfxCoreHelper = getHelper(); auto stepping = hardwareInfo.platform.usRevId; if (SpecialUltHelperGen12lp::shouldPerformimagePitchAlignment(hardwareInfo.platform.eProductFamily) && stepping == 0) { - EXPECT_EQ(64u, coreHelper.getPitchAlignmentForImage(pDevice->getRootDeviceEnvironment())); + EXPECT_EQ(64u, gfxCoreHelper.getPitchAlignmentForImage(pDevice->getRootDeviceEnvironment())); } else { - EXPECT_EQ(4u, coreHelper.getPitchAlignmentForImage(pDevice->getRootDeviceEnvironment())); + EXPECT_EQ(4u, gfxCoreHelper.getPitchAlignmentForImage(pDevice->getRootDeviceEnvironment())); } } -GEN12LPTEST_F(HwHelperTestGen12Lp, WhenAdjustingDefaultEngineTypeThenRcsIsSet) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, WhenAdjustingDefaultEngineTypeThenRcsIsSet) { hardwareInfo.featureTable.flags.ftrCCSNode = false; - auto &coreHelper = getHelper(); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + auto &gfxCoreHelper = getHelper(); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(aub_stream::ENGINE_RCS, hardwareInfo.capabilityTable.defaultEngineType); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenDifferentSizesOfAllocationWhenCheckingCompressionPreferenceThenReturnCorrectValue) { - auto &helper = HwHelper::get(renderCoreFamily); +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenDifferentSizesOfAllocationWhenCheckingCompressionPreferenceThenReturnCorrectValue) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); const size_t sizesToCheck[] = {128, 256, 512, 1023, 1024, 1025}; for (size_t size : sizesToCheck) { @@ -101,7 +101,7 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenDifferentSizesOfAllocationWhenCheckingCo } } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeNotSetAndBcsInfoSetWhenGetGpgpuEnginesThenReturnThreeRcsEnginesAndOneBcsEngine) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeNotSetAndBcsInfoSetWhenGetGpgpuEnginesThenReturnThreeRcsEnginesAndOneBcsEngine) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.flags.ftrCCSNode = false; hwInfo.featureTable.ftrBcsInfo = 1; @@ -110,7 +110,7 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeNotSetAndBcsInfoSetWhenGetGpgp auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(4u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(4u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[1].first); @@ -118,7 +118,7 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeNotSetAndBcsInfoSetWhenGetGpgp EXPECT_EQ(aub_stream::ENGINE_BCS, engines[3].first); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeNotSetAndCcsDefualtEngineWhenGetGpgpuEnginesThenReturnTwoRcsEnginesAndOneCcs) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeNotSetAndCcsDefualtEngineWhenGetGpgpuEnginesThenReturnTwoRcsEnginesAndOneCcs) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.flags.ftrCCSNode = false; hwInfo.featureTable.ftrBcsInfo = 0; @@ -126,14 +126,14 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeNotSetAndCcsDefualtEngineWhenG auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(3u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[1].first); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[2].first); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeNotSetWhenGetGpgpuEnginesThenReturnThreeRcsEngines) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeNotSetWhenGetGpgpuEnginesThenReturnThreeRcsEngines) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.flags.ftrCCSNode = false; hwInfo.featureTable.ftrBcsInfo = 0; @@ -141,7 +141,7 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeNotSetWhenGetGpgpuEnginesThenR auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(3u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[0].first); @@ -149,7 +149,7 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeNotSetWhenGetGpgpuEnginesThenR EXPECT_EQ(aub_stream::ENGINE_RCS, engines[2].first); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeSetWhenGetGpgpuEnginesThenReturnTwoRcsAndCcsEngines) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeSetWhenGetGpgpuEnginesThenReturnTwoRcsAndCcsEngines) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.flags.ftrCCSNode = true; hwInfo.featureTable.ftrBcsInfo = 0; @@ -157,7 +157,7 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeSetWhenGetGpgpuEnginesThenRetu auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(4u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(4u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[1].first); @@ -165,7 +165,7 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeSetWhenGetGpgpuEnginesThenRetu EXPECT_EQ(aub_stream::ENGINE_CCS, engines[3].first); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeSetFtrGpGpuMidThreadLevelPreemptSetWhenGetGpgpuEnginesThenReturn2RcsAndCcsEngines) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeSetFtrGpGpuMidThreadLevelPreemptSetWhenGetGpgpuEnginesThenReturn2RcsAndCcsEngines) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.flags.ftrCCSNode = true; hwInfo.featureTable.ftrBcsInfo = 0; @@ -174,14 +174,14 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeSetFtrGpGpuMidThreadLevelPreem auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(3u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[1].first); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[2].first); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeSetFtrGpGpuMidThreadLevelPreemptNotSetWhenGetGpgpuEnginesThenReturn2RcsAnd2CcsEngines) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeSetFtrGpGpuMidThreadLevelPreemptNotSetWhenGetGpgpuEnginesThenReturn2RcsAnd2CcsEngines) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.flags.ftrCCSNode = true; hwInfo.featureTable.ftrBcsInfo = 0; @@ -190,7 +190,7 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeSetFtrGpGpuMidThreadLevelPreem auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(4u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(4u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[1].first); @@ -198,7 +198,7 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeSetFtrGpGpuMidThreadLevelPreem EXPECT_EQ(aub_stream::ENGINE_CCS, engines[3].first); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeSetAndDefaultRcsWhenGetGpgpuEnginesThenReturnAppropriateNumberOfRcsEngines) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeSetAndDefaultRcsWhenGetGpgpuEnginesThenReturnAppropriateNumberOfRcsEngines) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.flags.ftrCCSNode = true; hwInfo.featureTable.ftrBcsInfo = 0; @@ -206,16 +206,16 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenFtrCcsNodeSetAndDefaultRcsWhenGetGpgpuEn auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(3u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[1].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[2].first); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenTgllpWhenIsFusedEuDispatchEnabledIsCalledThenResultIsCorrect) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenTgllpWhenIsFusedEuDispatchEnabledIsCalledThenResultIsCorrect) { DebugManagerStateRestore restorer; - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); auto &waTable = hardwareInfo.workaroundTable; std::tuple testParams[]{ @@ -233,7 +233,7 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenTgllpWhenIsFusedEuDispatchEnabledIsCalle } } -class HwHelperTestsGen12LpBuffer : public ::testing::Test { +class GfxCoreHelperTestsGen12LpBuffer : public ::testing::Test { public: void SetUp() override { ExecutionEnvironment *executionEnvironment = platform()->peekExecutionEnvironment(); @@ -249,8 +249,8 @@ class HwHelperTestsGen12LpBuffer : public ::testing::Test { std::unique_ptr buffer; }; -GEN12LPTEST_F(HwHelperTestsGen12LpBuffer, givenCompressedBufferThenCheckResourceCompatibilityReturnsFalse) { - auto &helper = HwHelper::get(renderCoreFamily); +GEN12LPTEST_F(GfxCoreHelperTestsGen12LpBuffer, givenCompressedBufferThenCheckResourceCompatibilityReturnsFalse) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); buffer.reset(Buffer::create(context.get(), 0, MemoryConstants::cacheLineSize, nullptr, retVal)); @@ -259,8 +259,8 @@ GEN12LPTEST_F(HwHelperTestsGen12LpBuffer, givenCompressedBufferThenCheckResource EXPECT_FALSE(helper.checkResourceCompatibility(*buffer->getGraphicsAllocation(rootDeviceIndex))); } -GEN12LPTEST_F(HwHelperTestsGen12LpBuffer, givenBufferThenCheckResourceCompatibilityReturnsTrue) { - auto &helper = HwHelper::get(renderCoreFamily); +GEN12LPTEST_F(GfxCoreHelperTestsGen12LpBuffer, givenBufferThenCheckResourceCompatibilityReturnsTrue) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); buffer.reset(Buffer::create(context.get(), 0, MemoryConstants::cacheLineSize, nullptr, retVal)); @@ -305,13 +305,13 @@ GEN12LPTEST_F(MemorySynchronizatiopCommandsTests, whenSettingCacheFlushExtraFiel EXPECT_FALSE(args.constantCacheInvalidationEnable); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenGen12WhenCallIsPackedSupportedThenReturnTrue) { - auto &helper = HwHelper::get(renderCoreFamily); +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenGen12WhenCallIsPackedSupportedThenReturnTrue) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_TRUE(helper.packedFormatsSupported()); } -GEN12LPTEST_F(HwHelperTestGen12Lp, whenRequestingMocsThenProperMocsIndicesAreBeingReturned) { - auto &helper = HwHelper::get(renderCoreFamily); +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, whenRequestingMocsThenProperMocsIndicesAreBeingReturned) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); auto gmmHelper = this->pDevice->getGmmHelper(); const auto mocsNoCache = gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER_CACHELINE_MISALIGNED) >> 1; @@ -323,11 +323,11 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, whenRequestingMocsThenProperMocsIndicesAreBei EXPECT_EQ(mocsL3, helper.getMocsIndex(*gmmHelper, true, true)); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenL1ForceEnabledWhenRequestingMocsThenProperMocsIndicesAreBeingReturned) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenL1ForceEnabledWhenRequestingMocsThenProperMocsIndicesAreBeingReturned) { DebugManagerStateRestore restore{}; DebugManager.flags.ForceL1Caching.set(1); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); auto gmmHelper = this->pDevice->getGmmHelper(); const auto mocsNoCache = gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER_CACHELINE_MISALIGNED) >> 1; @@ -340,11 +340,11 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenL1ForceEnabledWhenRequestingMocsThenProp EXPECT_EQ(mocsL1, helper.getMocsIndex(*gmmHelper, true, true)); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenL1ForceDisabledWhenRequestingMocsThenProperMocsIndicesAreBeingReturned) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenL1ForceDisabledWhenRequestingMocsThenProperMocsIndicesAreBeingReturned) { DebugManagerStateRestore restore{}; DebugManager.flags.ForceL1Caching.set(0); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); auto gmmHelper = this->pDevice->getGmmHelper(); const auto mocsNoCache = gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER_CACHELINE_MISALIGNED) >> 1; @@ -356,7 +356,7 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenL1ForceDisabledWhenRequestingMocsThenPro EXPECT_EQ(mocsL3, helper.getMocsIndex(*gmmHelper, true, true)); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenAllocationTypeWithCpuAccessRequiredWhenCpuAccessIsDisallowedThenSystemMemoryIsRequested) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenAllocationTypeWithCpuAccessRequiredWhenCpuAccessIsDisallowedThenSystemMemoryIsRequested) { DebugManagerStateRestore restore; DebugManager.flags.ForceLocalMemoryAccessMode.set(static_cast(LocalMemoryAccessMode::CpuAccessDisallowed)); @@ -389,7 +389,7 @@ GEN12LPTEST_F(HwHelperTestGen12Lp, givenAllocationTypeWithCpuAccessRequiredWhenC EXPECT_FALSE(allocData.flags.useSystemMemory); } -HWTEST2_F(HwHelperTestGen12Lp, givenRevisionEnumThenProperValueForIsWorkaroundRequiredIsReturned, IsRKL) { +HWTEST2_F(GfxCoreHelperTestGen12Lp, givenRevisionEnumThenProperValueForIsWorkaroundRequiredIsReturned, IsRKL) { std::vector steppings; HardwareInfo hardwareInfo = *defaultHwInfo; @@ -399,18 +399,18 @@ HWTEST2_F(HwHelperTestGen12Lp, givenRevisionEnumThenProperValueForIsWorkaroundRe for (auto stepping : steppings) { hardwareInfo.platform.usRevId = stepping; - HwHelper &hwHelper = HwHelper::get(renderCoreFamily); + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); if (stepping == 0x0) { - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); } else if (stepping == 0x1 || stepping == 0x5) { - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); } } } -HWTEST2_F(HwHelperTestGen12Lp, givenRevisionEnumThenProperValueForIsWorkaroundRequiredIsReturned, IsADLS) { +HWTEST2_F(GfxCoreHelperTestGen12Lp, givenRevisionEnumThenProperValueForIsWorkaroundRequiredIsReturned, IsADLS) { std::vector steppings; HardwareInfo hardwareInfo = *defaultHwInfo; @@ -420,29 +420,29 @@ HWTEST2_F(HwHelperTestGen12Lp, givenRevisionEnumThenProperValueForIsWorkaroundRe for (auto stepping : steppings) { hardwareInfo.platform.usRevId = stepping; - HwHelper &hwHelper = HwHelper::get(renderCoreFamily); + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); if (stepping == 0x0) { - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); } else if (stepping == 0x4 || stepping == 0x5) { - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); } } } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenLocalMemoryFeatureDisabledWhenIsLocalMemoryEnabledIsCalledThenTrueIsReturned) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenLocalMemoryFeatureDisabledWhenIsLocalMemoryEnabledIsCalledThenTrueIsReturned) { hardwareInfo.featureTable.flags.ftrLocalMemory = true; - auto &coreHelper = getHelper(); - EXPECT_TRUE(coreHelper.isLocalMemoryEnabled(hardwareInfo)); + auto &gfxCoreHelper = getHelper(); + EXPECT_TRUE(gfxCoreHelper.isLocalMemoryEnabled(hardwareInfo)); } -GEN12LPTEST_F(HwHelperTestGen12Lp, givenLocalMemoryFeatureEnabledWhenIsLocalMemoryEnabledIsCalledThenFalseIsReturned) { +GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenLocalMemoryFeatureEnabledWhenIsLocalMemoryEnabledIsCalledThenFalseIsReturned) { hardwareInfo.featureTable.flags.ftrLocalMemory = false; - auto &coreHelper = getHelper(); - EXPECT_FALSE(coreHelper.isLocalMemoryEnabled(hardwareInfo)); + auto &gfxCoreHelper = getHelper(); + EXPECT_FALSE(gfxCoreHelper.isLocalMemoryEnabled(hardwareInfo)); } diff --git a/opencl/test/unit_test/gen9/enqueue_kernel_gen9.cpp b/opencl/test/unit_test/gen9/enqueue_kernel_gen9.cpp index 859893939d..f086f32798 100644 --- a/opencl/test/unit_test/gen9/enqueue_kernel_gen9.cpp +++ b/opencl/test/unit_test/gen9/enqueue_kernel_gen9.cpp @@ -35,7 +35,7 @@ GEN9TEST_F(Gen9EnqueueTest, givenKernelRequiringIndependentForwardProgressWhenKe auto cmd = findMmioCmd(hwParser.cmdList.begin(), hwParser.cmdList.end(), DebugControlReg2::address); ASSERT_NE(nullptr, cmd); - EXPECT_EQ(DebugControlReg2::getRegData(HwHelperHw::get().getDefaultThreadArbitrationPolicy()), cmd->getDataDword()); + EXPECT_EQ(DebugControlReg2::getRegData(GfxCoreHelperHw::get().getDefaultThreadArbitrationPolicy()), cmd->getDataDword()); EXPECT_EQ(1U, countMmio(hwParser.cmdList.begin(), hwParser.cmdList.end(), DebugControlReg2::address)); } diff --git a/opencl/test/unit_test/gmm_helper/gmm_helper_tests.cpp b/opencl/test/unit_test/gmm_helper/gmm_helper_tests.cpp index d33188d152..1a3b883dc1 100644 --- a/opencl/test/unit_test/gmm_helper/gmm_helper_tests.cpp +++ b/opencl/test/unit_test/gmm_helper/gmm_helper_tests.cpp @@ -202,7 +202,7 @@ TEST_F(GmmTests, WhenQueryingImgParamsThenCorrectValuesAreReturned) { EXPECT_GT(imgInfo.qPitch, 0u); } - auto &hwHelper = HwHelper::get(hwinfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwinfo->platform.eRenderCoreFamily); EXPECT_EQ(queryGmm->resourceParams.Type, GMM_RESOURCE_TYPE::RESOURCE_3D); EXPECT_EQ(queryGmm->resourceParams.NoGfxMemory, 1u); @@ -215,7 +215,7 @@ TEST_F(GmmTests, WhenQueryingImgParamsThenCorrectValuesAreReturned) { EXPECT_EQ(queryGmm->resourceParams.BaseHeight, 17u); EXPECT_EQ(queryGmm->resourceParams.Depth, 17u); EXPECT_EQ(queryGmm->resourceParams.ArraySize, 1u); - EXPECT_EQ(!!queryGmm->resourceParams.Flags.Wa.__ForceOtherHVALIGN4, hwHelper.hvAlign4Required()); + EXPECT_EQ(!!queryGmm->resourceParams.Flags.Wa.__ForceOtherHVALIGN4, gfxCoreHelper.hvAlign4Required()); } TEST_F(GmmTests, givenWidthWhenCreatingResourceThenSetWidth64Field) { diff --git a/opencl/test/unit_test/gtpin/gtpin_tests.cpp b/opencl/test/unit_test/gtpin/gtpin_tests.cpp index d86c8e8f35..1cdcdba559 100644 --- a/opencl/test/unit_test/gtpin/gtpin_tests.cpp +++ b/opencl/test/unit_test/gtpin/gtpin_tests.cpp @@ -56,7 +56,7 @@ using namespace gtpin; namespace NEO { extern std::deque kernelExecQueue; -extern GTPinHwHelper *gtpinHwHelperFactory[IGFX_MAX_CORE]; +extern GTPinGfxCoreHelper *gtpinGfxCoreHelperFactory[IGFX_MAX_CORE]; } // namespace NEO namespace ULT { @@ -716,7 +716,7 @@ TEST_F(GTPinTests, givenInitializedGTPinInterfaceWhenContextIsCreatedThenCorrect EXPECT_EQ(CL_SUCCESS, retVal); EXPECT_NE(nullptr, context); GFXCORE_FAMILY genFamily = pDevice->getHardwareInfo().platform.eRenderCoreFamily; - GTPinHwHelper >pinHelper = GTPinHwHelper::get(genFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(genFamily); EXPECT_EQ(ULT::platformInfo.gen_version, static_cast(gtpinHelper.getGenVersion())); retVal = clReleaseContext(context); @@ -2141,7 +2141,7 @@ TEST_F(GTPinTests, givenKernelWithSSHThenVerifyThatSSHResizeWorksWell) { EXPECT_NE(0u, offsetBTS1); GFXCORE_FAMILY genFamily = pDevice->getHardwareInfo().platform.eRenderCoreFamily; - GTPinHwHelper >pinHelper = GTPinHwHelper::get(genFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(genFamily); void *pSS1 = gtpinHelper.getSurfaceState(pKernel, 0); EXPECT_NE(nullptr, pSS1); @@ -2263,9 +2263,9 @@ TEST_F(GTPinTests, givenKernelThenVerifyThatKernelCodeSubstitutionWorksWell) { EXPECT_EQ(CL_SUCCESS, retVal); } -TEST_F(GTPinTests, WhenGettingGtPinHwHelperThenValidPointerIsReturned) { +TEST_F(GTPinTests, WhenGettingGtPinGfxCoreHelperThenValidPointerIsReturned) { GFXCORE_FAMILY genFamily = pDevice->getHardwareInfo().platform.eRenderCoreFamily; - GTPinHwHelper *pGTPinHelper = >PinHwHelper::get(genFamily); + GTPinGfxCoreHelper *pGTPinHelper = >PinGfxCoreHelper::get(genFamily); EXPECT_NE(nullptr, pGTPinHelper); } @@ -2460,7 +2460,7 @@ using GTPinTestsWithLocalMemory = Test; TEST_F(GTPinTestsWithLocalMemory, whenPlatformHasNoSvmSupportThenGtPinBufferCantBeAllocatedInSharedMemory) { DebugManager.flags.GTPinAllocateBufferInSharedMemory.set(-1); - GTPinHwHelper >pinHelper = GTPinHwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); auto canUseSharedAllocation = gtpinHelper.canUseSharedAllocation(pDevice->getHardwareInfo()); if (!pDevice->getHardwareInfo().capabilityTable.ftrSvm) { EXPECT_FALSE(canUseSharedAllocation); @@ -2468,12 +2468,12 @@ TEST_F(GTPinTestsWithLocalMemory, whenPlatformHasNoSvmSupportThenGtPinBufferCant } HWTEST_F(GTPinTestsWithLocalMemory, givenGtPinWithSupportForSharedAllocationWhenGtPinHelperFunctionsAreCalledThenCheckIfSharedAllocationCabBeUsed) { - GTPinHwHelper >pinHelper = GTPinHwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); if (!gtpinHelper.canUseSharedAllocation(pDevice->getHardwareInfo())) { GTEST_SKIP(); } - class MockGTPinHwHelperHw : public GTPinHwHelperHw { + class MockGTPinGfxCoreHelperHw : public GTPinGfxCoreHelperHw { public: bool canUseSharedAllocation(const HardwareInfo &hwInfo) const override { canUseSharedAllocationCalled = true; @@ -2483,32 +2483,32 @@ HWTEST_F(GTPinTestsWithLocalMemory, givenGtPinWithSupportForSharedAllocationWhen }; const auto family = pDevice->getHardwareInfo().platform.eRenderCoreFamily; - MockGTPinHwHelperHw mockGTPinHwHelperHw; - VariableBackup gtpinHwHelperBackup{>pinHwHelperFactory[family], &mockGTPinHwHelperHw}; + MockGTPinGfxCoreHelperHw mockGTPinGfxCoreHelperHw; + VariableBackup gtpinGfxCoreHelperBackup{>pinGfxCoreHelperFactory[family], &mockGTPinGfxCoreHelperHw}; resource_handle_t resource = nullptr; cl_context ctxt = (cl_context)((Context *)pContext); - mockGTPinHwHelperHw.canUseSharedAllocationCalled = false; + mockGTPinGfxCoreHelperHw.canUseSharedAllocationCalled = false; gtpinCreateBuffer((gtpin::context_handle_t)ctxt, 256, &resource); - EXPECT_TRUE(mockGTPinHwHelperHw.canUseSharedAllocationCalled); + EXPECT_TRUE(mockGTPinGfxCoreHelperHw.canUseSharedAllocationCalled); - mockGTPinHwHelperHw.canUseSharedAllocationCalled = false; + mockGTPinGfxCoreHelperHw.canUseSharedAllocationCalled = false; uint8_t *address = nullptr; gtpinMapBuffer((gtpin::context_handle_t)ctxt, resource, &address); - EXPECT_TRUE(mockGTPinHwHelperHw.canUseSharedAllocationCalled); + EXPECT_TRUE(mockGTPinGfxCoreHelperHw.canUseSharedAllocationCalled); - mockGTPinHwHelperHw.canUseSharedAllocationCalled = false; + mockGTPinGfxCoreHelperHw.canUseSharedAllocationCalled = false; gtpinUnmapBuffer((gtpin::context_handle_t)ctxt, resource); - EXPECT_TRUE(mockGTPinHwHelperHw.canUseSharedAllocationCalled); + EXPECT_TRUE(mockGTPinGfxCoreHelperHw.canUseSharedAllocationCalled); - mockGTPinHwHelperHw.canUseSharedAllocationCalled = false; + mockGTPinGfxCoreHelperHw.canUseSharedAllocationCalled = false; gtpinFreeBuffer((gtpin::context_handle_t)ctxt, resource); - EXPECT_TRUE(mockGTPinHwHelperHw.canUseSharedAllocationCalled); + EXPECT_TRUE(mockGTPinGfxCoreHelperHw.canUseSharedAllocationCalled); } HWTEST_F(GTPinTestsWithLocalMemory, givenGtPinCanUseSharedAllocationWhenGtPinBufferIsCreatedThenAllocateBufferInSharedMemory) { - GTPinHwHelper >pinHelper = GTPinHwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); if (!gtpinHelper.canUseSharedAllocation(pDevice->getHardwareInfo())) { GTEST_SKIP(); } @@ -2544,7 +2544,7 @@ HWTEST_F(GTPinTestsWithLocalMemory, givenGtPinCanUseSharedAllocationWhenGtPinBuf } HWTEST_F(GTPinTestsWithLocalMemory, givenGtPinCanUseSharedAllocationWhenGtPinBufferIsAllocatedInSharedMemoryThenSetSurfaceStateForTheBufferAndMakeItResident) { - GTPinHwHelper >pinHelper = GTPinHwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); const auto &compilerProductHelper = *CompilerProductHelper::get(defaultHwInfo->platform.eProductFamily); if (!gtpinHelper.canUseSharedAllocation(pDevice->getHardwareInfo()) || compilerProductHelper.isForceToStatelessRequired() || !compilerProductHelper.isStatelessToStatefulBufferOffsetSupported()) { @@ -2659,11 +2659,11 @@ HWTEST_F(GTPinTestsWithLocalMemory, givenGtPinCanUseSharedAllocationWhenGtPinBuf EXPECT_EQ(CL_SUCCESS, retVal); } HWTEST_F(GTPinTestsWithLocalMemory, givenGtPinCanUseSharedAllocationWhenGtpinNotifyKernelSubmitThenMoveToAllocationDomainCalled) { - GTPinHwHelper >pinHelper = GTPinHwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + GTPinGfxCoreHelper >pinHelper = GTPinGfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); if (!gtpinHelper.canUseSharedAllocation(pDevice->getHardwareInfo())) { GTEST_SKIP(); } - class MockGTPinHwHelperHw : public GTPinHwHelperHw { + class MockGTPinGfxCoreHelperHw : public GTPinGfxCoreHelperHw { public: void *getSurfaceState(Kernel *pKernel, size_t bti) override { return data; @@ -2682,8 +2682,8 @@ HWTEST_F(GTPinTestsWithLocalMemory, givenGtPinCanUseSharedAllocationWhenGtpinNot static std::unique_ptr allocDataHandle; static std::unique_ptr mockGAHandle; const auto family = pDevice->getHardwareInfo().platform.eRenderCoreFamily; - MockGTPinHwHelperHw mockGTPinHwHelperHw; - VariableBackup gtpinHwHelperBackup{>pinHwHelperFactory[family], &mockGTPinHwHelperHw}; + MockGTPinGfxCoreHelperHw mockGTPinGfxCoreHelperHw; + VariableBackup gtpinGfxCoreHelperBackup{>pinGfxCoreHelperFactory[family], &mockGTPinGfxCoreHelperHw}; gtpinCallbacks.onContextCreate = onContextCreate; gtpinCallbacks.onContextDestroy = onContextDestroy; gtpinCallbacks.onKernelCreate = onKernelCreate; diff --git a/opencl/test/unit_test/helpers/cl_helper_tests.cpp b/opencl/test/unit_test/helpers/cl_helper_tests.cpp index 2074acfc2f..e3fc0091b6 100644 --- a/opencl/test/unit_test/helpers/cl_helper_tests.cpp +++ b/opencl/test/unit_test/helpers/cl_helper_tests.cpp @@ -68,7 +68,7 @@ TEST(ClHelper, whenCallGetStringWithCmdTypeFunctionThenGetProperCmdTypeAsString) EXPECT_STREQ("CL_COMMAND_GL_FENCE_SYNC_OBJECT_KHR", NEO::cmdTypetoString(CL_COMMAND_GL_FENCE_SYNC_OBJECT_KHR).c_str()); } -HWTEST_F(HwHelperTest, givenHwHelperWhenIsLinearStoragePreferredThenReturnValidValue) { +HWTEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenIsLinearStoragePreferredThenReturnValidValue) { bool tilingSupported = UnitTestHelper::tiledImagesSupported; const uint32_t numImageTypes = 6; @@ -79,7 +79,7 @@ HWTEST_F(HwHelperTest, givenHwHelperWhenIsLinearStoragePreferredThenReturnValidV cl_int retVal = CL_SUCCESS; auto buffer = std::unique_ptr(Buffer::create(&context, 0, 1, nullptr, retVal)); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); for (uint32_t i = 0; i < numImageTypes; i++) { imgDesc.image_type = imgTypes[i]; diff --git a/opencl/test/unit_test/helpers/test_preamble_xehp_and_later.cpp b/opencl/test/unit_test/helpers/test_preamble_xehp_and_later.cpp index 70ff1de068..da91a80d86 100644 --- a/opencl/test/unit_test/helpers/test_preamble_xehp_and_later.cpp +++ b/opencl/test/unit_test/helpers/test_preamble_xehp_and_later.cpp @@ -24,7 +24,7 @@ using namespace NEO; using ThreadArbitrationXeHPAndLater = PreambleFixture; HWTEST2_F(ThreadArbitrationXeHPAndLater, whenGetDefaultThreadArbitrationPolicyIsCalledThenCorrectPolicyIsReturned, IsXeHpOrXeHpgCore) { - EXPECT_EQ(ThreadArbitrationPolicy::AgeBased, HwHelperHw::get().getDefaultThreadArbitrationPolicy()); + EXPECT_EQ(ThreadArbitrationPolicy::AgeBased, GfxCoreHelperHw::get().getDefaultThreadArbitrationPolicy()); } using ProgramPipelineXeHPAndLater = PreambleFixture; @@ -137,7 +137,7 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, PreambleCfeStateXeHPAndLater, givenScratchEnabledWh using CFE_STATE = typename FamilyType::CFE_STATE; uint64_t expectedAddress = 1 << CFE_STATE::SCRATCHSPACEBUFFER_BIT_SHIFT; - uint32_t expectedMaxThreads = HwHelper::getMaxThreadsForVfe(*defaultHwInfo); + uint32_t expectedMaxThreads = GfxCoreHelper::getMaxThreadsForVfe(*defaultHwInfo); auto pVfeCmd = PreambleHelper::getSpaceForVfeState(&linearStream, *defaultHwInfo, EngineGroupType::RenderCompute); StreamProperties emptyProperties{}; PreambleHelper::programVfeState(pVfeCmd, *defaultHwInfo, 0u, expectedAddress, expectedMaxThreads, emptyProperties, nullptr); @@ -171,7 +171,7 @@ HWTEST2_F(PreambleCfeStateXeHPAndLater, givenNotSetDebugFlagWhenPreambleCfeState uint32_t overDispatchControl = static_cast(cfeState->getOverDispatchControl()); uint64_t expectedAddress = 1 << CFE_STATE::SCRATCHSPACEBUFFER_BIT_SHIFT; - uint32_t expectedMaxThreads = HwHelper::getMaxThreadsForVfe(*defaultHwInfo); + uint32_t expectedMaxThreads = GfxCoreHelper::getMaxThreadsForVfe(*defaultHwInfo); auto pVfeCmd = PreambleHelper::getSpaceForVfeState(&linearStream, *defaultHwInfo, EngineGroupType::RenderCompute); StreamProperties emptyProperties{}; PreambleHelper::programVfeState(pVfeCmd, *defaultHwInfo, 0u, expectedAddress, expectedMaxThreads, emptyProperties, nullptr); diff --git a/opencl/test/unit_test/kernel/kernel_arg_buffer_tests.cpp b/opencl/test/unit_test/kernel/kernel_arg_buffer_tests.cpp index 884a488d5f..4c037ff9ce 100644 --- a/opencl/test/unit_test/kernel/kernel_arg_buffer_tests.cpp +++ b/opencl/test/unit_test/kernel/kernel_arg_buffer_tests.cpp @@ -67,12 +67,12 @@ struct MultiDeviceKernelArgBufferTest : public ::testing::Test { kernelInfos[1] = pKernelInfosStorage[0].get(); kernelInfos[2] = pKernelInfosStorage[1].get(); - auto &hwHelper = HwHelper::get(renderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); for (auto i = 0u; i < 2; i++) { pKernelInfosStorage[i]->heapInfo.pSsh = pSshLocal[i]; pKernelInfosStorage[i]->heapInfo.SurfaceStateHeapSize = sizeof(pSshLocal[i]); - pKernelInfosStorage[i]->kernelDescriptor.kernelAttributes.simdSize = hwHelper.getMinimalSIMDSize(); + pKernelInfosStorage[i]->kernelDescriptor.kernelAttributes.simdSize = gfxCoreHelper.getMinimalSIMDSize(); auto crossThreadDataPointer = &pCrossThreadData[i]; memcpy_s(ptrOffset(&pCrossThreadData[i], i * sizeof(void *)), sizeof(void *), &crossThreadDataPointer, sizeof(void *)); diff --git a/opencl/test/unit_test/kernel/kernel_tests.cpp b/opencl/test/unit_test/kernel/kernel_tests.cpp index 2f91a7f0e2..ec2be5de6a 100644 --- a/opencl/test/unit_test/kernel/kernel_tests.cpp +++ b/opencl/test/unit_test/kernel/kernel_tests.cpp @@ -317,8 +317,8 @@ TEST_F(KernelTests, GivenRequiredDisabledEUFusionFlagWhenGettingPreferredWorkGro kernelInfo.kernelDescriptor.kernelAttributes.flags.requiresDisabledEUFusion = true; MockKernel kernel(pProgram, kernelInfo, *pClDevice); - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - bool fusedDispatchEnabled = hwHelper.isFusedEuDispatchEnabled(*defaultHwInfo, true); + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + bool fusedDispatchEnabled = gfxCoreHelper.isFusedEuDispatchEnabled(*defaultHwInfo, true); auto expectedValue = kernelInfo.getMaxSimdSize() * (fusedDispatchEnabled ? 2 : 1); cl_kernel_info paramName = CL_KERNEL_PREFERRED_WORK_GROUP_SIZE_MULTIPLE; @@ -345,8 +345,8 @@ TEST_F(KernelTests, GivenCFEFusedEUDispatchEnabledAndRequiredDisabledUEFusionWhe kernelInfo.kernelDescriptor.kernelAttributes.flags.requiresDisabledEUFusion = true; MockKernel kernel(pProgram, kernelInfo, *pClDevice); - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - bool fusedDispatchEnabled = hwHelper.isFusedEuDispatchEnabled(*defaultHwInfo, true); + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + bool fusedDispatchEnabled = gfxCoreHelper.isFusedEuDispatchEnabled(*defaultHwInfo, true); auto expectedValue = kernelInfo.getMaxSimdSize() * (fusedDispatchEnabled ? 2 : 1); cl_kernel_info paramName = CL_KERNEL_PREFERRED_WORK_GROUP_SIZE_MULTIPLE; @@ -793,8 +793,8 @@ TEST_F(KernelPrivateSurfaceTest, GivenKernelWhenPrivateSurfaceTooBigAndGpuPointe } TEST_F(KernelPrivateSurfaceTest, GivenKernelWhenScratchSizeIsGreaterThanMaxScratchSizeThenReturnInvalidKernel) { - auto &hwHelper = NEO::HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); - uint32_t maxScratchSize = hwHelper.getMaxScratchSize(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + uint32_t maxScratchSize = gfxCoreHelper.getMaxScratchSize(); auto pKernelInfo = std::make_unique(); pKernelInfo->kernelDescriptor.kernelAttributes.simdSize = 32; @@ -2353,7 +2353,7 @@ TEST(KernelInfoTest, GivenArgNameWhenGettingArgNumberByNameThenCorrectValueIsRet EXPECT_EQ(-1, info.getArgNumByName("arg1")); } -TEST(KernelInfoTest, givenHwHelperWhenCreatingKernelAllocationThenCorrectPaddingIsAdded) { +TEST(KernelInfoTest, givenGfxCoreHelperWhenCreatingKernelAllocationThenCorrectPaddingIsAdded) { auto clDevice = std::make_unique(MockDevice::createWithNewExecutionEnvironment(defaultHwInfo.get(), mockRootDeviceIndex)); auto context = std::make_unique(clDevice.get()); @@ -2365,7 +2365,7 @@ TEST(KernelInfoTest, givenHwHelperWhenCreatingKernelAllocationThenCorrectPadding mockKernel->kernelInfo.createKernelAllocation(clDevice->getDevice(), false); auto graphicsAllocation = mockKernel->kernelInfo.getGraphicsAllocation(); - auto &helper = clDevice->getRootDeviceEnvironment().getHelper(); + auto &helper = clDevice->getRootDeviceEnvironment().getHelper(); size_t isaPadding = helper.getPaddingForISAAllocation(); EXPECT_EQ(graphicsAllocation->getUnderlyingBufferSize(), mockKernel->kernelInfo.heapInfo.KernelHeapSize + isaPadding); clDevice->getMemoryManager()->freeGraphicsMemory(mockKernel->kernelInfo.getGraphicsAllocation()); @@ -2650,7 +2650,7 @@ TEST(KernelTest, whenNullAllocationThenAssignNullPointerToCacheFlushVector) { TEST(KernelTest, givenKernelCompiledWithSimdSizeLowerThanExpectedWhenInitializingThenReturnError) { auto device = clUniquePtr(new MockClDevice(MockDevice::createWithNewExecutionEnvironment(defaultHwInfo.get()))); - auto minSimd = HwHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily).getMinimalSIMDSize(); + auto minSimd = GfxCoreHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily).getMinimalSIMDSize(); MockKernelWithInternals kernel(*device); kernel.kernelInfo.kernelDescriptor.kernelAttributes.simdSize = 8; @@ -2964,8 +2964,8 @@ TEST(KernelTest, whenKernelIsInitializedThenThreadArbitrationPolicyIsSetToDefaul MockKernelWithInternals mockKernelWithInternals{*deviceFactory.rootDevices[0], sPatchExecEnv}; auto &mockKernel = *mockKernelWithInternals.mockKernel; - auto &hwHelper = HwHelper::get(deviceFactory.rootDevices[0]->getHardwareInfo().platform.eRenderCoreFamily); - EXPECT_EQ(hwHelper.getDefaultThreadArbitrationPolicy(), mockKernel.getDescriptor().kernelAttributes.threadArbitrationPolicy); + auto &gfxCoreHelper = GfxCoreHelper::get(deviceFactory.rootDevices[0]->getHardwareInfo().platform.eRenderCoreFamily); + EXPECT_EQ(gfxCoreHelper.getDefaultThreadArbitrationPolicy(), mockKernel.getDescriptor().kernelAttributes.threadArbitrationPolicy); } TEST(KernelTest, givenKernelWhenSettingAdditinalKernelExecInfoThenCorrectValueIsSet) { diff --git a/opencl/test/unit_test/kernel/substitute_kernel_heap_tests.cpp b/opencl/test/unit_test/kernel/substitute_kernel_heap_tests.cpp index 46bc3ae07b..ef265796a7 100644 --- a/opencl/test/unit_test/kernel/substitute_kernel_heap_tests.cpp +++ b/opencl/test/unit_test/kernel/substitute_kernel_heap_tests.cpp @@ -27,7 +27,7 @@ TEST_F(KernelSubstituteTest, givenKernelWhenSubstituteKernelHeapWithGreaterSizeT auto firstAllocation = kernel.kernelInfo.kernelAllocation; EXPECT_NE(nullptr, firstAllocation); auto firstAllocationSize = firstAllocation->getUnderlyingBufferSize(); - auto &helper = pClDevice->getRootDeviceEnvironment().getHelper(); + auto &helper = pClDevice->getRootDeviceEnvironment().getHelper(); size_t isaPadding = helper.getPaddingForISAAllocation(); EXPECT_EQ(firstAllocationSize, initialHeapSize + isaPadding); @@ -59,7 +59,7 @@ TEST_F(KernelSubstituteTest, givenKernelWhenSubstituteKernelHeapWithSameSizeThen auto firstAllocation = kernel.kernelInfo.kernelAllocation; EXPECT_NE(nullptr, firstAllocation); auto firstAllocationSize = firstAllocation->getUnderlyingBufferSize(); - auto &helper = pClDevice->getRootDeviceEnvironment().getHelper(); + auto &helper = pClDevice->getRootDeviceEnvironment().getHelper(); size_t isaPadding = helper.getPaddingForISAAllocation(); EXPECT_EQ(firstAllocationSize, initialHeapSize + isaPadding); @@ -90,7 +90,7 @@ TEST_F(KernelSubstituteTest, givenKernelWhenSubstituteKernelHeapWithSmallerSizeT auto firstAllocation = kernel.kernelInfo.kernelAllocation; EXPECT_NE(nullptr, firstAllocation); auto firstAllocationSize = firstAllocation->getUnderlyingBufferSize(); - auto &helper = pClDevice->getRootDeviceEnvironment().getHelper(); + auto &helper = pClDevice->getRootDeviceEnvironment().getHelper(); size_t isaPadding = helper.getPaddingForISAAllocation(); EXPECT_EQ(firstAllocationSize, initialHeapSize + isaPadding); diff --git a/opencl/test/unit_test/linux/main_linux_dll.cpp b/opencl/test/unit_test/linux/main_linux_dll.cpp index 6770723f93..b687f92970 100644 --- a/opencl/test/unit_test/linux/main_linux_dll.cpp +++ b/opencl/test/unit_test/linux/main_linux_dll.cpp @@ -708,7 +708,7 @@ TEST_F(DrmTests, whenDrmIsCreatedWithMultipleSubDevicesThenCreateMultipleVirtual GTEST_SKIP(); } - auto numSubDevices = HwHelper::getSubDevicesCount(rootDeviceEnvironment->getHardwareInfo()); + auto numSubDevices = GfxCoreHelper::getSubDevicesCount(rootDeviceEnvironment->getHardwareInfo()); for (auto id = 0u; id < numSubDevices; id++) { EXPECT_EQ(id + 1, drm->getVirtualMemoryAddressSpace(id)); } @@ -726,7 +726,7 @@ TEST_F(DrmTests, givenDebuggingEnabledWhenDrmIsCreatedThenPerContextVMIsTrueGetV if (drm->isVmBindAvailable()) { EXPECT_TRUE(drm->isPerContextVMRequired()); - auto numSubDevices = HwHelper::getSubDevicesCount(rootDeviceEnvironment->getHardwareInfo()); + auto numSubDevices = GfxCoreHelper::getSubDevicesCount(rootDeviceEnvironment->getHardwareInfo()); for (auto id = 0u; id < numSubDevices; id++) { EXPECT_EQ(0u, drm->getVirtualMemoryAddressSpace(id)); } @@ -755,7 +755,7 @@ TEST_F(DrmTests, givenEnabledDebuggingAndVmBindNotAvailableWhenDrmIsCreatedThenP GTEST_SKIP(); } - auto numSubDevices = HwHelper::getSubDevicesCount(rootDeviceEnvironment->getHardwareInfo()); + auto numSubDevices = GfxCoreHelper::getSubDevicesCount(rootDeviceEnvironment->getHardwareInfo()); for (auto id = 0u; id < numSubDevices; id++) { EXPECT_NE(0u, drm->getVirtualMemoryAddressSpace(id)); } diff --git a/opencl/test/unit_test/mem_obj/buffer_tests.cpp b/opencl/test/unit_test/mem_obj/buffer_tests.cpp index 2fcde067f4..678f20e6d4 100644 --- a/opencl/test/unit_test/mem_obj/buffer_tests.cpp +++ b/opencl/test/unit_test/mem_obj/buffer_tests.cpp @@ -705,7 +705,7 @@ TEST_F(CompressedBuffersTests, givenBufferNotCompressedAllocationAndNoHostPtrWhe hwInfo->capabilityTable.ftrRenderCompressedBuffers = true; buffer.reset(Buffer::create(context.get(), 0, bufferSize, nullptr, retVal)); allocation = buffer->getGraphicsAllocation(device->getRootDeviceIndex()); - if (HwHelper::get(context->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(bufferSize, *hwInfo)) { + if (GfxCoreHelper::get(context->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(bufferSize, *hwInfo)) { EXPECT_FALSE(buffer->isMemObjZeroCopy()); EXPECT_EQ(allocation->getAllocationType(), AllocationType::BUFFER); EXPECT_EQ(!memoryManager->allocate32BitGraphicsMemoryImplCalled, allocation->isCompressionEnabled()); @@ -723,7 +723,7 @@ TEST_F(CompressedBuffersTests, givenBufferCompressedAllocationWhenSharedContextI buffer.reset(Buffer::create(context.get(), CL_MEM_READ_WRITE, bufferSize, nullptr, retVal)); auto graphicsAllocation = buffer->getGraphicsAllocation(context->getDevice(0)->getRootDeviceIndex()); - if (HwHelper::get(context->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(bufferSize, *hwInfo)) { + if (GfxCoreHelper::get(context->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(bufferSize, *hwInfo)) { EXPECT_EQ(graphicsAllocation->getAllocationType(), AllocationType::BUFFER); EXPECT_EQ(!memoryManager->allocate32BitGraphicsMemoryImplCalled, graphicsAllocation->isCompressionEnabled()); } else { @@ -745,7 +745,7 @@ TEST_F(CompressedBuffersTests, givenDebugVariableSetWhenHwFlagIsNotSetThenSelect DebugManager.flags.RenderCompressedBuffersEnabled.set(1); buffer.reset(Buffer::create(context.get(), 0, bufferSize, nullptr, retVal)); auto graphicsAllocation = buffer->getGraphicsAllocation(context->getDevice(0)->getRootDeviceIndex()); - if (HwHelper::get(context->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(bufferSize, *hwInfo)) { + if (GfxCoreHelper::get(context->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(bufferSize, *hwInfo)) { EXPECT_EQ(graphicsAllocation->getAllocationType(), AllocationType::BUFFER); EXPECT_EQ(!memoryManager->allocate32BitGraphicsMemoryImplCalled, graphicsAllocation->isCompressionEnabled()); } else { @@ -803,7 +803,7 @@ TEST_F(CompressedBuffersCopyHostMemoryTests, givenCompressedBufferWhenCopyFromHo buffer.reset(Buffer::create(context.get(), CL_MEM_COPY_HOST_PTR, bufferSize, hostPtr, retVal)); auto graphicsAllocation = buffer->getGraphicsAllocation(context->getDevice(0)->getRootDeviceIndex()); - if (HwHelper::get(context->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(bufferSize, *hwInfo)) { + if (GfxCoreHelper::get(context->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(bufferSize, *hwInfo)) { EXPECT_TRUE(graphicsAllocation->isCompressionEnabled()); EXPECT_EQ(1u, mockCmdQ->writeBufferCounter); EXPECT_TRUE(mockCmdQ->writeBufferBlocking); @@ -843,7 +843,7 @@ TEST_F(CompressedBuffersCopyHostMemoryTests, givenNonCompressedBufferWhenCopyFro } TEST_F(CompressedBuffersCopyHostMemoryTests, givenCompressedBufferWhenWriteBufferFailsThenReturnErrorCode) { - if (is32bit || !HwHelper::get(context->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(bufferSize, *hwInfo)) { + if (is32bit || !GfxCoreHelper::get(context->getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily).isBufferSizeSuitableForCompression(bufferSize, *hwInfo)) { return; } hwInfo->capabilityTable.ftrRenderCompressedBuffers = true; diff --git a/opencl/test/unit_test/mem_obj/image2d_from_buffer_tests.cpp b/opencl/test/unit_test/mem_obj/image2d_from_buffer_tests.cpp index 4945e9f9ce..2e6b0eb948 100644 --- a/opencl/test/unit_test/mem_obj/image2d_from_buffer_tests.cpp +++ b/opencl/test/unit_test/mem_obj/image2d_from_buffer_tests.cpp @@ -23,7 +23,7 @@ using namespace NEO; namespace NEO { -extern HwHelper *hwHelperFactory[IGFX_MAX_CORE]; +extern GfxCoreHelper *gfxCoreHelperFactory[IGFX_MAX_CORE]; } // Tests for cl_khr_image2d_from_buffer @@ -333,14 +333,14 @@ TEST_F(Image2dFromBufferTest, givenBufferWhenImageFromBufferThenIsImageFromBuffe } HWTEST_F(Image2dFromBufferTest, givenBufferWhenImageFromBufferThenIsImageFromBufferSetAndAllocationTypeIsBufferNullptr) { - class MockHwHelperHw : public HwHelperHw { + class MockGfxCoreHelperHw : public GfxCoreHelperHw { public: bool checkResourceCompatibility(GraphicsAllocation &graphicsAllocation) override { return false; } }; - auto raiiFactory = RAIIHwHelperFactory(context.getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); + auto raiiFactory = RAIIGfxCoreHelperFactory(context.getDevice(0)->getHardwareInfo().platform.eRenderCoreFamily); cl_int errCode = CL_SUCCESS; auto buffer = Buffer::create(&context, 0, 1, nullptr, errCode); diff --git a/opencl/test/unit_test/mem_obj/mem_obj_helper_tests.cpp b/opencl/test/unit_test/mem_obj/mem_obj_helper_tests.cpp index 3e1fae6525..255cbf5bf4 100644 --- a/opencl/test/unit_test/mem_obj/mem_obj_helper_tests.cpp +++ b/opencl/test/unit_test/mem_obj/mem_obj_helper_tests.cpp @@ -388,7 +388,7 @@ TEST(MemObjHelper, givenDifferentCapabilityAndDebugFlagValuesWhenCheckingBufferC MemoryProperties memoryProperties = ClMemoryPropertiesHelper::createMemoryProperties(0, 0, 0, &device); - bool compressionEnabled = MemObjHelper::isSuitableForCompression(HwHelper::compressedBuffersSupported(*defaultHwInfo), memoryProperties, context, true); + bool compressionEnabled = MemObjHelper::isSuitableForCompression(GfxCoreHelper::compressedBuffersSupported(*defaultHwInfo), memoryProperties, context, true); MockPublicAccessBuffer::getGraphicsAllocationTypeAndCompressionPreference( memoryProperties, context, compressionEnabled, false); @@ -451,7 +451,7 @@ TEST(MemObjHelper, givenDifferentValuesWhenCheckingBufferCompressionSupportThenC MemoryProperties memoryProperties = ClMemoryPropertiesHelper::createMemoryProperties(flags, flagsIntel, 0, &device); - bool compressionEnabled = MemObjHelper::isSuitableForCompression(HwHelper::compressedBuffersSupported(*defaultHwInfo), memoryProperties, context, true); + bool compressionEnabled = MemObjHelper::isSuitableForCompression(GfxCoreHelper::compressedBuffersSupported(*defaultHwInfo), memoryProperties, context, true); MockPublicAccessBuffer::getGraphicsAllocationTypeAndCompressionPreference( memoryProperties, context, compressionEnabled, false); diff --git a/opencl/test/unit_test/memory_manager/mem_obj_surface_tests.cpp b/opencl/test/unit_test/memory_manager/mem_obj_surface_tests.cpp index ff53c80fcb..3b4d267096 100644 --- a/opencl/test/unit_test/memory_manager/mem_obj_surface_tests.cpp +++ b/opencl/test/unit_test/memory_manager/mem_obj_surface_tests.cpp @@ -44,7 +44,7 @@ HWTEST_F(SurfaceTest, GivenSurfaceWhenInterfaceIsUsedThenSurfaceBehavesCorrectly DeviceBitfield deviceBitfield(1); auto csr = std::make_unique>(execStamp, *executionEnvironment, 0, deviceBitfield); auto hwInfo = *defaultHwInfo; - auto engine = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0]; + auto engine = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0]; auto osContext = executionEnvironment->memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(engine, PreemptionHelper::getDefaultPreemptionMode(hwInfo))); csr->setupContext(*osContext); diff --git a/opencl/test/unit_test/memory_manager/memory_manager_tests.cpp b/opencl/test/unit_test/memory_manager/memory_manager_tests.cpp index 1ab305b147..c909dfc67e 100644 --- a/opencl/test/unit_test/memory_manager/memory_manager_tests.cpp +++ b/opencl/test/unit_test/memory_manager/memory_manager_tests.cpp @@ -239,7 +239,7 @@ TEST_F(MemoryAllocatorTest, GivenAlignmentWhenAllocatingSystemMemoryThenAllocate TEST_F(MemoryAllocatorTest, WhenAllocatingGraphicsMemoryThenAllocationHasCorrectProperties) { unsigned int alignment = 4096; - memoryManager->createAndRegisterOsContext(csr, EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + memoryManager->createAndRegisterOsContext(csr, EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); auto allocation = memoryManager->allocateGraphicsMemoryWithProperties(MockAllocationProperties{csr->getRootDeviceIndex(), MemoryConstants::pageSize}); @@ -602,19 +602,19 @@ TEST_F(MemoryAllocatorTest, given32BitDeviceWhenPrintfSurfaceIsCreatedThen32BitA } } HWTEST_F(MemoryAllocatorTest, givenSupportFor1MbAlignmentWhenAllocateGraphicsMemoryThenAlignmentIsSetCorrect) { - class MockHwHelperHw : public HwHelperHw { + class MockGfxCoreHelperHw : public GfxCoreHelperHw { public: - using HwHelperHw::HwHelperHw; + using GfxCoreHelperHw::GfxCoreHelperHw; bool is1MbAlignmentSupported(const HardwareInfo &hwInfo, bool isCompressionEnabled) const override { return isEnable; } bool isEnable = false; }; - auto raiiFactory = RAIIHwHelperFactory(defaultHwInfo->platform.eRenderCoreFamily); + auto raiiFactory = RAIIGfxCoreHelperFactory(defaultHwInfo->platform.eRenderCoreFamily); void *ptr = reinterpret_cast(0x1001); auto size = MemoryConstants::pageSize; - raiiFactory.mockHwHelper.isEnable = true; + raiiFactory.mockGfxCoreHelper.isEnable = true; auto osAgnosticMemoryManager = std::make_unique>(true, false, *executionEnvironment); osAgnosticMemoryManager->failInDevicePool = true; @@ -629,7 +629,7 @@ HWTEST_F(MemoryAllocatorTest, givenSupportFor1MbAlignmentWhenAllocateGraphicsMem osAgnosticMemoryManager->freeGraphicsMemory(allocationWithEnabled1MbAlignment); - raiiFactory.mockHwHelper.isEnable = false; + raiiFactory.mockGfxCoreHelper.isEnable = false; auto allocationWithoutEnabled1MbAlignment = osAgnosticMemoryManager->allocateGraphicsMemoryWithProperties(properties, ptr); ASSERT_NE(nullptr, allocationWithoutEnabled1MbAlignment); @@ -827,7 +827,7 @@ TEST(OsAgnosticMemoryManager, givenDestroyedTagAllocationWhenWaitForCompletiionT DeviceBitfield deviceBitfield(1); std::unique_ptr csr(createCommandStream(executionEnvironment, 0u, deviceBitfield)); executionEnvironment.memoryManager.reset(memoryManager); - auto osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + auto osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); auto allocation = memoryManager->allocateGraphicsMemoryWithProperties(MockAllocationProperties{0, MemoryConstants::pageSize}); @@ -1310,8 +1310,8 @@ TEST(OsAgnosticMemoryManager, givenLocalMemoryAndDebugModuleAreaTypeWhenCreating DebugManager.flags.EnableLocalMemory.set(true); MockExecutionEnvironment executionEnvironment(&hwInfo); - auto &coreHelper = executionEnvironment.rootDeviceEnvironments[0]->getHelper(); - if (!coreHelper.isLocalMemoryEnabled(hwInfo)) { + auto &gfxCoreHelper = executionEnvironment.rootDeviceEnvironments[0]->getHelper(); + if (!gfxCoreHelper.isLocalMemoryEnabled(hwInfo)) { GTEST_SKIP(); } @@ -1694,7 +1694,7 @@ TEST(OsAgnosticMemoryManager, givenMemoryManagerWhenGpuAddressIsSetThenAllocatio DeviceBitfield deviceBitfield(1); std::unique_ptr csr(createCommandStream(executionEnvironment, 0u, deviceBitfield)); executionEnvironment.memoryManager.reset(memoryManager); - auto osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + auto osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); MockAllocationProperties properties = {0, MemoryConstants::pageSize}; @@ -1971,7 +1971,7 @@ TEST_F(MemoryManagerWithCsrTest, givenAllocationThatWasUsedAndIsCompletedWhenche } TEST_F(MemoryManagerWithCsrTest, givenAllocationThatWasUsedAndIsNotCompletedWhencheckGpuUsageAndDestroyGraphicsAllocationsIsCalledThenItIsAddedToTemporaryAllocationList) { - memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); auto usedAllocationAndNotGpuCompleted = memoryManager->allocateGraphicsMemoryWithProperties(MockAllocationProperties{csr->getRootDeviceIndex(), MemoryConstants::pageSize}); @@ -2234,7 +2234,7 @@ TEST(ResidencyDataTest, givenOsContextWhenItIsRegisteredToMemoryManagerThenRefCo executionEnvironment.memoryManager.reset(memoryManager); DeviceBitfield deviceBitfield(1); std::unique_ptr csr(createCommandStream(executionEnvironment, 0u, deviceBitfield)); - memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); EXPECT_EQ(1u, memoryManager->getRegisteredEnginesCount()); EXPECT_EQ(1, memoryManager->registeredEngines[0].osContext->getRefInternalCount()); @@ -2261,7 +2261,7 @@ TEST(ResidencyDataTest, givenDeviceBitfieldWhenCreatingOsContextThenSetValidValu DeviceBitfield deviceBitfield(0b11); std::unique_ptr csr(createCommandStream(executionEnvironment, 0u, deviceBitfield)); PreemptionMode preemptionMode = PreemptionMode::MidThread; - memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], preemptionMode, deviceBitfield)); EXPECT_EQ(2u, memoryManager->registeredEngines[0].osContext->getNumSupportedDevices()); @@ -2276,9 +2276,9 @@ TEST(ResidencyDataTest, givenTwoOsContextsWhenTheyAreRegisteredFromHigherToLower DeviceBitfield deviceBitfield(1); std::unique_ptr csr(createCommandStream(executionEnvironment, 0u, deviceBitfield)); std::unique_ptr csr1(createCommandStream(executionEnvironment, 1u, deviceBitfield)); - memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); - memoryManager->createAndRegisterOsContext(csr1.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + memoryManager->createAndRegisterOsContext(csr1.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); EXPECT_EQ(2u, memoryManager->getRegisteredEnginesCount()); EXPECT_EQ(1, memoryManager->registeredEngines[0].osContext->getRefInternalCount()); @@ -2286,7 +2286,7 @@ TEST(ResidencyDataTest, givenTwoOsContextsWhenTheyAreRegisteredFromHigherToLower } TEST(ResidencyDataTest, givenGpgpuEnginesWhenAskedForMaxOsContextCountThenValueIsGreaterOrEqual) { - auto &engines = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo); + auto &engines = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo); EXPECT_TRUE(MemoryManager::maxOsContextCount >= engines.size()); } @@ -2298,9 +2298,9 @@ TEST(ResidencyDataTest, givenResidencyDataWhenUpdateCompletionDataIsCalledThenIt MockResidencyData residency(MemoryManager::maxOsContextCount); - MockOsContext osContext(0u, EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + MockOsContext osContext(0u, EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); - MockOsContext osContext2(1u, EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + MockOsContext osContext2(1u, EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); auto lastFenceValue = 45llu; @@ -2543,7 +2543,7 @@ TEST(MemoryManagerTest, givenCachelineAlignedPointerAndProperDescriptorValuesWhe TEST(MemoryManagerTest, givenForcedLinearImages3DImageAndProperDescriptorValuesWhenIsCopyRequiredIsCalledThenFalseIsReturned) { DebugManagerStateRestore dbgRestorer; DebugManager.flags.ForceLinearImages.set(true); - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); ImageInfo imgInfo{}; @@ -2565,7 +2565,7 @@ TEST(MemoryManagerTest, givenForcedLinearImages3DImageAndProperDescriptorValuesW imgInfo.rowPitch = imageDesc.image_width * surfaceFormat->surfaceFormat.ImageElementSizeInBytes; imgInfo.slicePitch = imgInfo.rowPitch * imageDesc.image_height; imgInfo.size = imgInfo.slicePitch; - imgInfo.linearStorage = hwHelper.isLinearStoragePreferred(false, Image::isImage1d(Image::convertDescriptor(imgInfo.imgDesc)), false); + imgInfo.linearStorage = gfxCoreHelper.isLinearStoragePreferred(false, Image::isImage1d(Image::convertDescriptor(imgInfo.imgDesc)), false); auto hostPtr = alignedMalloc(imgInfo.size, MemoryConstants::cacheLineSize); @@ -3000,7 +3000,7 @@ HWTEST_F(PageTableManagerTest, givenNullPageTableManagerWhenMapAuxGpuVaThenRetur executionEnvironment->memoryManager.reset(memoryManager); auto csr = std::unique_ptr(createCommandStream(*executionEnvironment, 1u, 1)); auto hwInfo = *defaultHwInfo; - memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0], + memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(hwInfo))); for (auto engine : memoryManager->getRegisteredEngines()) { diff --git a/opencl/test/unit_test/os_interface/device_factory_tests.cpp b/opencl/test/unit_test/os_interface/device_factory_tests.cpp index 650f0d264c..141a065290 100644 --- a/opencl/test/unit_test/os_interface/device_factory_tests.cpp +++ b/opencl/test/unit_test/os_interface/device_factory_tests.cpp @@ -203,9 +203,9 @@ TEST_F(DeviceFactoryTest, givenPointerToHwInfoWhenGetDevicedCalledThenRequiedSur ASSERT_TRUE(success); auto hwInfo = executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo(); - const auto &hwHelper = HwHelper::get(hwInfo->platform.eRenderCoreFamily); + const auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily); auto expextedSize = static_cast(hwInfo->gtSystemInfo.CsrSizeInMb * MemoryConstants::megaByte); - hwHelper.adjustPreemptionSurfaceSize(expextedSize); + gfxCoreHelper.adjustPreemptionSurfaceSize(expextedSize); EXPECT_EQ(expextedSize, hwInfo->capabilityTable.requiredPreemptionSurfaceSize); } diff --git a/opencl/test/unit_test/os_interface/linux/cl_mem_cache_clos_tests_xe_hpc.cpp b/opencl/test/unit_test/os_interface/linux/cl_mem_cache_clos_tests_xe_hpc.cpp index 8409128600..f52be19e48 100644 --- a/opencl/test/unit_test/os_interface/linux/cl_mem_cache_clos_tests_xe_hpc.cpp +++ b/opencl/test/unit_test/os_interface/linux/cl_mem_cache_clos_tests_xe_hpc.cpp @@ -96,8 +96,8 @@ XE_HPC_CORETEST_F(BuffersWithClMemCacheClosTests, givenDrmBuffersWhenTheyAreCrea cl_mem_alloc_flags_intel allocflags = 0; MemoryProperties memoryProperties = ClMemoryPropertiesHelper::createMemoryProperties(flags, flagsIntel, allocflags, device.get()); - auto &hwHelper = HwHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily); - auto numCacheRegions = hwHelper.getNumCacheRegions(); + auto &gfxCoreHelper = GfxCoreHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily); + auto numCacheRegions = gfxCoreHelper.getNumCacheRegions(); EXPECT_EQ(3u, numCacheRegions); for (uint32_t cacheRegion = 0; cacheRegion < numCacheRegions; cacheRegion++) { diff --git a/opencl/test/unit_test/os_interface/linux/drm_command_stream_tests_2.cpp b/opencl/test/unit_test/os_interface/linux/drm_command_stream_tests_2.cpp index dd2964ae12..23e0939e13 100644 --- a/opencl/test/unit_test/os_interface/linux/drm_command_stream_tests_2.cpp +++ b/opencl/test/unit_test/os_interface/linux/drm_command_stream_tests_2.cpp @@ -1376,7 +1376,7 @@ HWTEST_TEMPLATED_F(DrmCommandStreamEnhancedTest, givenMergeWithResidencyContaine operationHandler->mergeWithResidencyContainerResult = NEO::MemoryOperationsStatus::FAILED; auto osContext = std::make_unique(*mock, rootDeviceIndex, 0u, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); auto commandBuffer = mm->allocateGraphicsMemoryWithProperties(MockAllocationProperties{csr->getRootDeviceIndex(), MemoryConstants::pageSize}); @@ -1407,7 +1407,7 @@ HWTEST_TEMPLATED_F(DrmCommandStreamEnhancedTest, givenMergeWithResidencyContaine operationHandler->mergeWithResidencyContainerResult = NEO::MemoryOperationsStatus::OUT_OF_MEMORY; auto osContext = std::make_unique(*mock, rootDeviceIndex, 0u, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); auto commandBuffer = mm->allocateGraphicsMemoryWithProperties(MockAllocationProperties{csr->getRootDeviceIndex(), MemoryConstants::pageSize}); @@ -1441,7 +1441,7 @@ HWTEST_TEMPLATED_F(DrmCommandStreamEnhancedTest, givenNoAllocsInMemoryOperationH }; auto osContext = std::make_unique(*mock, rootDeviceIndex, 0u, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); auto commandBuffer = mm->allocateGraphicsMemoryWithProperties(MockAllocationProperties{csr->getRootDeviceIndex(), MemoryConstants::pageSize}); @@ -1472,7 +1472,7 @@ HWTEST_TEMPLATED_F(DrmCommandStreamEnhancedTest, givenAllocsInMemoryOperationHan }; auto osContext = std::make_unique(*mock, rootDeviceIndex, 0u, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); auto allocation = mm->allocateGraphicsMemoryWithProperties(MockAllocationProperties{csr->getRootDeviceIndex(), MemoryConstants::pageSize}); diff --git a/opencl/test/unit_test/os_interface/performance_counters_tests.cpp b/opencl/test/unit_test/os_interface/performance_counters_tests.cpp index 17c93a400f..2d0527af65 100644 --- a/opencl/test/unit_test/os_interface/performance_counters_tests.cpp +++ b/opencl/test/unit_test/os_interface/performance_counters_tests.cpp @@ -214,7 +214,7 @@ struct PerformanceCountersMetricsLibraryTest : public PerformanceCountersMetrics void SetUp() override { PerformanceCountersMetricsLibraryFixture::setUp(); auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - osContext = std::make_unique(0, EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + osContext = std::make_unique(0, EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*hwInfo))); queue->getGpgpuCommandStreamReceiver().setupContext(*osContext); } @@ -660,5 +660,5 @@ TEST_F(PerformanceCountersMetricsLibraryTest, GivenPerformanceCountersObjectIsNo TEST_F(PerformanceCountersTest, givenRenderCoreFamilyWhenGettingGenIdThenMetricsLibraryGenIdentifierAreValid) { const auto &hwInfo = device->getHardwareInfo(); const auto gen = hwInfo.platform.eRenderCoreFamily; - EXPECT_NE(ClientGen::Unknown, static_cast(HwHelper::get(gen).getMetricsLibraryGenId())); + EXPECT_NE(ClientGen::Unknown, static_cast(GfxCoreHelper::get(gen).getMetricsLibraryGenId())); } diff --git a/opencl/test/unit_test/os_interface/windows/wddm20_tests.cpp b/opencl/test/unit_test/os_interface/windows/wddm20_tests.cpp index 96a9132ca2..786d8a3338 100644 --- a/opencl/test/unit_test/os_interface/windows/wddm20_tests.cpp +++ b/opencl/test/unit_test/os_interface/windows/wddm20_tests.cpp @@ -657,7 +657,7 @@ struct WddmContextSchedulingPriorityTests : public Wddm20WithMockGdiDllTestsWith wddm->wddmInterface.reset(wddmMockInterface); auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - auto engine = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; + auto engine = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; auto engineDescriptor = EngineDescriptorHelper::getDefaultDescriptor(engine, preemptionMode); engineDescriptor.engineTypeUsage.second = lowPriority ? EngineUsage::LowPriority : EngineUsage::Regular; @@ -723,7 +723,7 @@ TEST_F(Wddm20WithMockGdiDllTestsWithoutWddmInit, givenUseNoRingFlushesKmdModeDeb TEST_F(Wddm20WithMockGdiDllTestsWithoutWddmInit, givenEngineTypeWhenCreatingContextThenPassCorrectNodeOrdinal) { init(); auto createContextParams = this->getCreateContextDataFcn(); - UINT expected = WddmEngineMapper::engineNodeMap(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0].first); + UINT expected = WddmEngineMapper::engineNodeMap(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0].first); EXPECT_EQ(expected, createContextParams->NodeOrdinal); } diff --git a/opencl/test/unit_test/os_interface/windows/wddm23_tests.cpp b/opencl/test/unit_test/os_interface/windows/wddm23_tests.cpp index 6c631e13c8..1736f68567 100644 --- a/opencl/test/unit_test/os_interface/windows/wddm23_tests.cpp +++ b/opencl/test/unit_test/os_interface/windows/wddm23_tests.cpp @@ -46,7 +46,7 @@ struct Wddm23TestsWithoutWddmInit : public ::testing::Test, GdiDllFixture { wddm->init(); wddm->wddmInterface.reset(wddmMockInterface); osContext = std::make_unique(*wddm, 0, 0u, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], preemptionMode)); + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], preemptionMode)); osContext->ensureContextInitialized(); } @@ -78,7 +78,7 @@ TEST_F(Wddm23Tests, whenCreateContextIsCalledThenEnableHwQueues) { } TEST_F(Wddm23Tests, givenPreemptionModeWhenCreateHwQueueCalledThenSetGpuTimeoutIfEnabled) { - auto defaultEngine = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0]; + auto defaultEngine = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0]; OsContextWin osContextWithoutPreemption(*wddm, 0, 0u, EngineDescriptorHelper::getDefaultDescriptor(defaultEngine, PreemptionMode::Disabled)); OsContextWin osContextWithPreemption(*wddm, 0, 0, EngineDescriptorHelper::getDefaultDescriptor(defaultEngine, PreemptionMode::MidBatch)); diff --git a/opencl/test/unit_test/os_interface/windows/wddm_memory_manager_tests.cpp b/opencl/test/unit_test/os_interface/windows/wddm_memory_manager_tests.cpp index 8e247bfa76..19463c0529 100644 --- a/opencl/test/unit_test/os_interface/windows/wddm_memory_manager_tests.cpp +++ b/opencl/test/unit_test/os_interface/windows/wddm_memory_manager_tests.cpp @@ -512,7 +512,7 @@ TEST_F(WddmMemoryManagerSimpleTest, givenNonZeroFenceValuesOnMultipleEnginesRegi auto hwInfo = executionEnvironment->rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo(); OsContext *osContext = memoryManager->createAndRegisterOsContext(csr.get(), - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[1], + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[1], PreemptionHelper::getDefaultPreemptionMode(*hwInfo), deviceBitfield)); osContext->ensureContextInitialized(); ASSERT_EQ(2u, memoryManager->getRegisteredEnginesCount()); @@ -547,7 +547,7 @@ TEST_F(WddmMemoryManagerSimpleTest, givenNonZeroFenceValueOnSomeOfMultipleEngine executionEnvironment->rootDeviceEnvironments[rootDeviceIndex]->memoryOperationsInterface = std::make_unique(wddm2); auto hwInfo = executionEnvironment->rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo(); - memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[1], + memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[1], PreemptionHelper::getDefaultPreemptionMode(*hwInfo), deviceBitfield)); ASSERT_EQ(2u, memoryManager->getRegisteredEnginesCount()); diff --git a/opencl/test/unit_test/os_interface/windows/wddm_memory_manager_tests.h b/opencl/test/unit_test/os_interface/windows/wddm_memory_manager_tests.h index 4011b810ec..3cd7c62f4d 100644 --- a/opencl/test/unit_test/os_interface/windows/wddm_memory_manager_tests.h +++ b/opencl/test/unit_test/os_interface/windows/wddm_memory_manager_tests.h @@ -67,7 +67,7 @@ class MockWddmMemoryManagerFixture { memoryManager = std::make_unique(*executionEnvironment); csr.reset(createCommandStream(*executionEnvironment, 0u, 1)); auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*hwInfo))); osContext->ensureContextInitialized(); @@ -120,7 +120,7 @@ class WddmMemoryManagerFixtureWithGmockWddm : public ExecutionEnvironmentFixture ASSERT_NE(nullptr, memoryManager); csr.reset(createCommandStream(*executionEnvironment, 0u, 1)); auto hwInfo = executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo(); - osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], preemptionMode)); osContext->incRefInternal(); } diff --git a/opencl/test/unit_test/os_interface/windows/wddm_residency_controller_tests.cpp b/opencl/test/unit_test/os_interface/windows/wddm_residency_controller_tests.cpp index b2a2e636ec..0ee61770bc 100644 --- a/opencl/test/unit_test/os_interface/windows/wddm_residency_controller_tests.cpp +++ b/opencl/test/unit_test/os_interface/windows/wddm_residency_controller_tests.cpp @@ -133,7 +133,7 @@ struct WddmResidencyControllerWithMockWddmTest : public WddmResidencyControllerT csr.reset(createCommandStream(*executionEnvironment, 0u, 1)); auto hwInfo = executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo(); - osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], preemptionMode)); osContext->ensureContextInitialized(); @@ -171,7 +171,7 @@ struct WddmResidencyControllerWithGdiAndMemoryManagerTest : ::testing::Test { memoryManager = std::make_unique(*executionEnvironment); csr.reset(createCommandStream(*executionEnvironment, 0u, 1)); auto hwInfo = executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo(); - osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); osContext->ensureContextInitialized(); diff --git a/opencl/test/unit_test/program/kernel_info_tests.cpp b/opencl/test/unit_test/program/kernel_info_tests.cpp index 23caee58f0..fdacebc49d 100644 --- a/opencl/test/unit_test/program/kernel_info_tests.cpp +++ b/opencl/test/unit_test/program/kernel_info_tests.cpp @@ -45,7 +45,7 @@ TEST(KernelInfoTest, givenKernelInfoWhenCreateKernelAllocationThenCopyWholeKerne EXPECT_TRUE(retVal); auto allocation = kernelInfo.kernelAllocation; EXPECT_EQ(0, memcmp(allocation->getUnderlyingBuffer(), heap, heapSize)); - auto &helper = device->getRootDeviceEnvironment().getHelper(); + auto &helper = device->getRootDeviceEnvironment().getHelper(); size_t isaPadding = helper.getPaddingForISAAllocation(); EXPECT_EQ(allocation->getUnderlyingBufferSize(), heapSize + isaPadding); device->getMemoryManager()->checkGpuUsageAndDestroyGraphicsAllocations(allocation); @@ -162,7 +162,7 @@ TEST(KernelInfo, givenNumbersOfSamplerWhenCheckSamplerStateCountAndSamplerStateA KernelInfo kernel = {}; uint8_t numSamplers = 5u; kernel.kernelDescriptor.payloadMappings.samplerTable.numSamplers = numSamplers; - auto samplerSize = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getSamplerStateSize(); + auto samplerSize = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getSamplerStateSize(); EXPECT_EQ(kernel.getSamplerStateArrayCount(), numSamplers); EXPECT_EQ(kernel.getSamplerStateArraySize(*defaultHwInfo), static_cast(numSamplers * samplerSize)); } diff --git a/opencl/test/unit_test/program/program_tests.cpp b/opencl/test/unit_test/program/program_tests.cpp index bddc791f25..81ee631a60 100644 --- a/opencl/test/unit_test/program/program_tests.cpp +++ b/opencl/test/unit_test/program/program_tests.cpp @@ -493,7 +493,7 @@ TEST_F(ProgramFromBinaryTest, givenProgramWhenItIsBeingBuildThenItContainsGraphi auto graphicsAllocation = kernelInfo->getGraphicsAllocation(); ASSERT_NE(nullptr, graphicsAllocation); EXPECT_TRUE(graphicsAllocation->is32BitAllocation()); - auto &helper = pDevice->getRootDeviceEnvironment().getHelper(); + auto &helper = pDevice->getRootDeviceEnvironment().getHelper(); size_t isaPadding = helper.getPaddingForISAAllocation(); EXPECT_EQ(graphicsAllocation->getUnderlyingBufferSize(), kernelInfo->heapInfo.KernelHeapSize + isaPadding); @@ -2135,7 +2135,7 @@ HWTEST_F(ProgramTests, givenNewProgramThenStatelessToStatefulBufferOffsetOptimiz MockProgram program(pContext, false, toClDeviceVector(*pClDevice)); auto internalOptions = program.getInternalOptions(); - if (HwHelperHw::get().isStatelessToStatefulWithOffsetSupported()) { + if (GfxCoreHelperHw::get().isStatelessToStatefulWithOffsetSupported()) { EXPECT_TRUE(CompilerOptions::contains(internalOptions, CompilerOptions::hasBufferOffsetArg)); } else { EXPECT_FALSE(CompilerOptions::contains(internalOptions, CompilerOptions::hasBufferOffsetArg)); diff --git a/opencl/test/unit_test/sharings/gl/windows/gl_os_sharing_tests.cpp b/opencl/test/unit_test/sharings/gl/windows/gl_os_sharing_tests.cpp index 5eac8f7153..333c9260a5 100644 --- a/opencl/test/unit_test/sharings/gl/windows/gl_os_sharing_tests.cpp +++ b/opencl/test/unit_test/sharings/gl/windows/gl_os_sharing_tests.cpp @@ -336,7 +336,7 @@ TEST_F(GlArbSyncEventOsTest, GivenCallToSignalArbSyncObjectWhenSignalSynchroniza auto preemptionMode = PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo); wddm->init(); OsContextWin osContext(*wddm, 0, 0u, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], preemptionMode)); + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], preemptionMode)); CL_GL_SYNC_INFO syncInfo = {}; syncInfo.serverSynchronizationObject = 0x5cU; @@ -395,7 +395,7 @@ TEST_F(GlArbSyncEventOsTest, GivenCallToSignalArbSyncObjectWhenSignalSynchroniza FailSignalSyncObjectMock::reset(); auto preemptionMode = PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo); wddm->init(); - OsContextWin osContext(*wddm, 0, 0u, EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], preemptionMode)); + OsContextWin osContext(*wddm, 0, 0u, EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], preemptionMode)); CL_GL_SYNC_INFO syncInfo = {}; syncInfo.submissionSynchronizationObject = 0x7cU; diff --git a/opencl/test/unit_test/xe_hp_core/hw_helper_tests_xe_hp_core.cpp b/opencl/test/unit_test/xe_hp_core/hw_helper_tests_xe_hp_core.cpp index 257f36fbdd..ce0d25dda5 100644 --- a/opencl/test/unit_test/xe_hp_core/hw_helper_tests_xe_hp_core.cpp +++ b/opencl/test/unit_test/xe_hp_core/hw_helper_tests_xe_hp_core.cpp @@ -74,13 +74,13 @@ XE_HP_CORE_TEST_F(ClGfxCoreHelperTestsXeHpCore, WhenGettingDeviceIpVersionThenMa EXPECT_EQ(ClGfxCoreHelperMock::makeDeviceIpVersion(12, 5, 1), clGfxCoreHelper.getDeviceIpVersion(*defaultHwInfo)); } -using HwHelperTestXE_HP_CORE = HwHelperTest; +using GfxCoreHelperTestXE_HP_CORE = GfxCoreHelperTest; -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenDifferentBufferSizesWhenEnableStatelessCompressionThenEveryBufferSizeIsSuitableForCompression) { +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, givenDifferentBufferSizesWhenEnableStatelessCompressionThenEveryBufferSizeIsSuitableForCompression) { DebugManagerStateRestore restore; DebugManager.flags.EnableStatelessCompression.set(1); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); const size_t sizesToCheck[] = {1, 128, 256, 1024, 2048}; for (size_t size : sizesToCheck) { @@ -88,24 +88,24 @@ XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenDifferentBufferSizesWhenEnableSta } } -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenStatelessCompressionEnabledWhenSetExtraAllocationDataThenDontRequireCpuAccessNorMakeResourceLocableForCompressedAllocations) { +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, givenStatelessCompressionEnabledWhenSetExtraAllocationDataThenDontRequireCpuAccessNorMakeResourceLocableForCompressedAllocations) { DebugManagerStateRestore restore; DebugManager.flags.EnableStatelessCompression.set(1); HardwareInfo hwInfo = *defaultHwInfo; - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); for (auto allocType : {AllocationType::CONSTANT_SURFACE, AllocationType::GLOBAL_SURFACE, AllocationType::PRINTF_SURFACE}) { AllocationData allocData; AllocationProperties allocProperties(mockRootDeviceIndex, true, allocType, mockDeviceBitfield); - hwHelper.setExtraAllocationData(allocData, allocProperties, hwInfo); + gfxCoreHelper.setExtraAllocationData(allocData, allocProperties, hwInfo); EXPECT_FALSE(allocData.flags.requiresCpuAccess); EXPECT_FALSE(allocData.storageInfo.isLockable); } } -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenRevisionEnumAndPlatformFamilyTypeThenProperValueForIsWorkaroundRequiredIsReturned) { +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, givenRevisionEnumAndPlatformFamilyTypeThenProperValueForIsWorkaroundRequiredIsReturned) { uint32_t steppings[] = { REVISION_A0, REVISION_A1, @@ -114,7 +114,7 @@ XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenRevisionEnumAndPlatformFamilyType CommonConstants::invalidStepping, }; - const auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + const auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); const auto &hwInfoConfig = *HwInfoConfig::get(hardwareInfo.platform.eProductFamily); for (auto stepping : steppings) { @@ -122,21 +122,21 @@ XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenRevisionEnumAndPlatformFamilyType if (hardwareInfo.platform.eProductFamily == IGFX_XE_HP_SDV) { if (stepping == REVISION_A0) { - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); } else if (stepping == REVISION_A1) { - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); } else if (stepping == REVISION_C || stepping == REVISION_D) { // undefined - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); } } else { - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); } } } -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenRevisionEnumThenProperMaxThreadsForWorkgroupIsReturned) { +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, givenRevisionEnumThenProperMaxThreadsForWorkgroupIsReturned) { const auto &hwInfoConfig = *HwInfoConfig::get(hardwareInfo.platform.eProductFamily); hardwareInfo.platform.usRevId = hwInfoConfig.getHwRevIdFromStepping(REVISION_A0, hardwareInfo); EXPECT_EQ(64u, hwInfoConfig.getMaxThreadsForWorkgroupInDSSOrSS(hardwareInfo, 64u, 64u)); @@ -146,7 +146,7 @@ XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenRevisionEnumThenProperMaxThreadsF EXPECT_EQ(64u * numThreadsPerEU, hwInfoConfig.getMaxThreadsForWorkgroupInDSSOrSS(hardwareInfo, 64u, 64u)); } -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenDisablePipeControlFlagIsDefaultWhenLocalMemoryIsEnabledThenReturnFalseAndDoNotProgramPipeControl) { +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, givenDisablePipeControlFlagIsDefaultWhenLocalMemoryIsEnabledThenReturnFalseAndDoNotProgramPipeControl) { hardwareInfo.featureTable.flags.ftrLocalMemory = true; EXPECT_FALSE(MemorySynchronizationCommands::isBarrierWaRequired(hardwareInfo)); @@ -158,7 +158,7 @@ XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenDisablePipeControlFlagIsDefaultWh EXPECT_EQ(0u, cmdStream.getUsed()); } -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenDisablePipeControlFlagIsDisabledWhenLocalMemoryIsEnabledThenReturnFalseAndDoNotProgramPipeControl) { +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, givenDisablePipeControlFlagIsDisabledWhenLocalMemoryIsEnabledThenReturnFalseAndDoNotProgramPipeControl) { DebugManagerStateRestore restore; DebugManager.flags.DisablePipeControlPrecedingPostSyncCommand.set(0); @@ -172,7 +172,7 @@ XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenDisablePipeControlFlagIsDisabledW EXPECT_EQ(0u, cmdStream.getUsed()); } -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenDisablePipeControlFlagIsEnabledWhenLocalMemoryIsEnabledThenReturnTrueAndProgramPipeControl) { +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, givenDisablePipeControlFlagIsEnabledWhenLocalMemoryIsEnabledThenReturnTrueAndProgramPipeControl) { using PIPE_CONTROL = typename FamilyType::PIPE_CONTROL; DebugManagerStateRestore restore; DebugManager.flags.DisablePipeControlPrecedingPostSyncCommand.set(1); @@ -187,7 +187,7 @@ XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenDisablePipeControlFlagIsEnabledWh EXPECT_EQ(sizeof(PIPE_CONTROL), cmdStream.getUsed()); } -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenDisablePipeControlFlagIsEnabledWhenLocalMemoryIsDisabledThenReturnTrueAndDoNotProgramPipeControl) { +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, givenDisablePipeControlFlagIsEnabledWhenLocalMemoryIsDisabledThenReturnTrueAndDoNotProgramPipeControl) { DebugManagerStateRestore restore; DebugManager.flags.DisablePipeControlPrecedingPostSyncCommand.set(1); @@ -201,9 +201,9 @@ XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenDisablePipeControlFlagIsEnabledWh EXPECT_EQ(0u, cmdStream.getUsed()); } -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenXeHPAndLaterPlatformWhenCheckAssignEngineRoundRobinSupportedThenReturnFalse) { - auto &hwHelper = HwHelperHw::get(); - EXPECT_FALSE(hwHelper.isAssignEngineRoundRobinSupported(*defaultHwInfo)); +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, givenXeHPAndLaterPlatformWhenCheckAssignEngineRoundRobinSupportedThenReturnFalse) { + auto &gfxCoreHelper = GfxCoreHelperHw::get(); + EXPECT_FALSE(gfxCoreHelper.isAssignEngineRoundRobinSupported(*defaultHwInfo)); } using HwInfoConfigTestXE_HP_CORE = Test; @@ -261,26 +261,26 @@ XE_HP_CORE_TEST_F(LriHelperTestsXE_HP_CORE, whenProgrammingLriCommandThenExpectM EXPECT_TRUE(memcmp(lri, &expectedLri, sizeof(MI_LOAD_REGISTER_IMM)) == 0); } -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, GivenVariousValuesWhenAlignSlmSizeIsCalledThenCorrectValueIsReturned) { - EXPECT_EQ(0u, HwHelperHw::get().alignSlmSize(0)); - EXPECT_EQ(1024u, HwHelperHw::get().alignSlmSize(1)); - EXPECT_EQ(1024u, HwHelperHw::get().alignSlmSize(1024)); - EXPECT_EQ(2048u, HwHelperHw::get().alignSlmSize(1025)); - EXPECT_EQ(2048u, HwHelperHw::get().alignSlmSize(2048)); - EXPECT_EQ(4096u, HwHelperHw::get().alignSlmSize(2049)); - EXPECT_EQ(4096u, HwHelperHw::get().alignSlmSize(4096)); - EXPECT_EQ(8192u, HwHelperHw::get().alignSlmSize(4097)); - EXPECT_EQ(8192u, HwHelperHw::get().alignSlmSize(8192)); - EXPECT_EQ(16384u, HwHelperHw::get().alignSlmSize(8193)); - EXPECT_EQ(16384u, HwHelperHw::get().alignSlmSize(16384)); - EXPECT_EQ(32768u, HwHelperHw::get().alignSlmSize(16385)); - EXPECT_EQ(32768u, HwHelperHw::get().alignSlmSize(32768)); - EXPECT_EQ(65536u, HwHelperHw::get().alignSlmSize(32769)); - EXPECT_EQ(65536u, HwHelperHw::get().alignSlmSize(65536)); +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, GivenVariousValuesWhenAlignSlmSizeIsCalledThenCorrectValueIsReturned) { + EXPECT_EQ(0u, GfxCoreHelperHw::get().alignSlmSize(0)); + EXPECT_EQ(1024u, GfxCoreHelperHw::get().alignSlmSize(1)); + EXPECT_EQ(1024u, GfxCoreHelperHw::get().alignSlmSize(1024)); + EXPECT_EQ(2048u, GfxCoreHelperHw::get().alignSlmSize(1025)); + EXPECT_EQ(2048u, GfxCoreHelperHw::get().alignSlmSize(2048)); + EXPECT_EQ(4096u, GfxCoreHelperHw::get().alignSlmSize(2049)); + EXPECT_EQ(4096u, GfxCoreHelperHw::get().alignSlmSize(4096)); + EXPECT_EQ(8192u, GfxCoreHelperHw::get().alignSlmSize(4097)); + EXPECT_EQ(8192u, GfxCoreHelperHw::get().alignSlmSize(8192)); + EXPECT_EQ(16384u, GfxCoreHelperHw::get().alignSlmSize(8193)); + EXPECT_EQ(16384u, GfxCoreHelperHw::get().alignSlmSize(16384)); + EXPECT_EQ(32768u, GfxCoreHelperHw::get().alignSlmSize(16385)); + EXPECT_EQ(32768u, GfxCoreHelperHw::get().alignSlmSize(32768)); + EXPECT_EQ(65536u, GfxCoreHelperHw::get().alignSlmSize(32769)); + EXPECT_EQ(65536u, GfxCoreHelperHw::get().alignSlmSize(65536)); } -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenHwHelperWhenGettingThreadsPerEUConfigsThenCorrectConfigsAreReturned) { - auto &helper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, givenGfxCoreHelperWhenGettingThreadsPerEUConfigsThenCorrectConfigsAreReturned) { + auto &helper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); EXPECT_NE(nullptr, &helper); auto &configs = helper.getThreadsPerEUConfigs(); @@ -290,7 +290,7 @@ XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, givenHwHelperWhenGettingThreadsPerEUCo EXPECT_EQ(8U, configs[1]); } -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, givenDebugFlagAndLocalMemoryIsNotAvailableWhenProgrammingPostSyncPipeControlThenExpectNotAddingWaPipeControl) { using PIPE_CONTROL = typename FamilyType::PIPE_CONTROL; @@ -327,7 +327,7 @@ XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, EXPECT_EQ(immediateValue, pipeControl->getImmediateData()); } -XE_HP_CORE_TEST_F(HwHelperTestXE_HP_CORE, +XE_HP_CORE_TEST_F(GfxCoreHelperTestXE_HP_CORE, givenDebugFlagAndLocalMemoryIsAvailableWhenProgrammingPostSyncPipeControlThenExpectAddingWaPipeControl) { using PIPE_CONTROL = typename FamilyType::PIPE_CONTROL; diff --git a/opencl/test/unit_test/xe_hp_core/test_device_caps_xe_hp_core.cpp b/opencl/test/unit_test/xe_hp_core/test_device_caps_xe_hp_core.cpp index 204917903a..347d8686c2 100644 --- a/opencl/test/unit_test/xe_hp_core/test_device_caps_xe_hp_core.cpp +++ b/opencl/test/unit_test/xe_hp_core/test_device_caps_xe_hp_core.cpp @@ -142,20 +142,20 @@ XE_HP_CORE_TEST_F(XE_HP_COREDeviceCaps, givenHwInfoWhenRequestedComputeUnitsUsed HardwareInfo &hwInfo = *pDevice->getRootDeviceEnvironment().getMutableHardwareInfo(); GT_SYSTEM_INFO &testSysInfo = hwInfo.gtSystemInfo; testSysInfo.MaxSubSlicesSupported = 24; - auto &coreHelper = pClDevice->getRootDeviceEnvironment().getHelper(); + auto &gfxCoreHelper = pClDevice->getRootDeviceEnvironment().getHelper(); uint32_t minMaxSubSlicesSupported = 32; uint32_t minCalculation = minMaxSubSlicesSupported * hwInfo.gtSystemInfo.MaxEuPerSubSlice * hwInfo.gtSystemInfo.ThreadCount / hwInfo.gtSystemInfo.EUCount; EXPECT_LE(testSysInfo.MaxSubSlicesSupported, minMaxSubSlicesSupported); - EXPECT_EQ(minCalculation, coreHelper.getComputeUnitsUsedForScratch(pClDevice->getRootDeviceEnvironment())); + EXPECT_EQ(minCalculation, gfxCoreHelper.getComputeUnitsUsedForScratch(pClDevice->getRootDeviceEnvironment())); } XE_HP_CORE_TEST_F(XE_HP_COREDeviceCaps, givenHwInfoWhenRequestedComputeUnitsUsedForScratchAndMaxSubSlicesSupportedIsGreaterThanMinMaxSubSlicesSupportedThenReturnValidValue) { HardwareInfo &hwInfo = *pDevice->getRootDeviceEnvironment().getMutableHardwareInfo(); GT_SYSTEM_INFO &testSysInfo = hwInfo.gtSystemInfo; testSysInfo.MaxSubSlicesSupported = 40; - auto &coreHelper = pClDevice->getRootDeviceEnvironment().getHelper(); + auto &gfxCoreHelper = pClDevice->getRootDeviceEnvironment().getHelper(); uint32_t minMaxSubSlicesSupported = 32; uint32_t minCalculation = minMaxSubSlicesSupported * hwInfo.gtSystemInfo.MaxEuPerSubSlice * hwInfo.gtSystemInfo.ThreadCount / hwInfo.gtSystemInfo.EUCount; @@ -164,7 +164,7 @@ XE_HP_CORE_TEST_F(XE_HP_COREDeviceCaps, givenHwInfoWhenRequestedComputeUnitsUsed EXPECT_GT(testSysInfo.MaxSubSlicesSupported, minMaxSubSlicesSupported); EXPECT_GT(properCalculation, minCalculation); - EXPECT_EQ(properCalculation, coreHelper.getComputeUnitsUsedForScratch(pClDevice->getRootDeviceEnvironment())); + EXPECT_EQ(properCalculation, gfxCoreHelper.getComputeUnitsUsedForScratch(pClDevice->getRootDeviceEnvironment())); } HWTEST_EXCLUDE_PRODUCT(DeviceGetCapsTest, givenEnabledFtrPooledEuWhenCalculatingMaxEuPerSSThenDontIgnoreEuCountPerPoolMin, IGFX_XE_HP_CORE); diff --git a/opencl/test/unit_test/xe_hp_core/xehp/hw_helper_tests_xehp.inl b/opencl/test/unit_test/xe_hp_core/xehp/hw_helper_tests_xehp.inl index 8c822a6758..dbfabeea2f 100644 --- a/opencl/test/unit_test/xe_hp_core/xehp/hw_helper_tests_xehp.inl +++ b/opencl/test/unit_test/xe_hp_core/xehp/hw_helper_tests_xehp.inl @@ -7,11 +7,11 @@ #include "shared/test/common/helpers/hw_helper_tests.h" -using HwHelperTestsXeHP = HwHelperTest; +using GfxCoreHelperTestsXeHP = GfxCoreHelperTest; -XEHPTEST_F(HwHelperTestsXeHP, givenXEHPWhenIsBankOverrideRequiredIsCalledThenCorrectValueIsReturned) { +XEHPTEST_F(GfxCoreHelperTestsXeHP, givenXEHPWhenIsBankOverrideRequiredIsCalledThenCorrectValueIsReturned) { DebugManagerStateRestore restore; - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); const auto &hwInfoConfig = *HwInfoConfig::get(productFamily); auto hwInfo = *defaultHwInfo; hwInfo.gtSystemInfo.MultiTileArchInfo.IsValid = true; @@ -45,7 +45,7 @@ XEHPTEST_F(HwHelperTestsXeHP, givenXEHPWhenIsBankOverrideRequiredIsCalledThenCor } } -XEHPTEST_F(HwHelperTestsXeHP, givenRcsDisabledWhenGetGpgpuEnginesCalledThenDontSetRcs) { +XEHPTEST_F(GfxCoreHelperTestsXeHP, givenRcsDisabledWhenGetGpgpuEnginesCalledThenDontSetRcs) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.flags.ftrCCSNode = true; hwInfo.featureTable.ftrBcsInfo = 1; @@ -57,7 +57,7 @@ XEHPTEST_F(HwHelperTestsXeHP, givenRcsDisabledWhenGetGpgpuEnginesCalledThenDontS auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(8u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(8u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); @@ -70,7 +70,7 @@ XEHPTEST_F(HwHelperTestsXeHP, givenRcsDisabledWhenGetGpgpuEnginesCalledThenDontS EXPECT_EQ(aub_stream::ENGINE_BCS, engines[7].first); } -XEHPTEST_F(HwHelperTestsXeHP, givenRcsDisabledButDebugVariableSetWhenGetGpgpuEnginesCalledThenSetRcs) { +XEHPTEST_F(GfxCoreHelperTestsXeHP, givenRcsDisabledButDebugVariableSetWhenGetGpgpuEnginesCalledThenSetRcs) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.flags.ftrCCSNode = true; hwInfo.featureTable.ftrBcsInfo = 1; @@ -85,7 +85,7 @@ XEHPTEST_F(HwHelperTestsXeHP, givenRcsDisabledButDebugVariableSetWhenGetGpgpuEng auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(9u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(9u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); @@ -99,10 +99,10 @@ XEHPTEST_F(HwHelperTestsXeHP, givenRcsDisabledButDebugVariableSetWhenGetGpgpuEng EXPECT_EQ(aub_stream::ENGINE_BCS, engines[8].first); } -XEHPTEST_F(HwHelperTestsXeHP, GivenVariousValuesWhenComputeSlmSizeIsCalledThenCorrectValueIsReturned) { +XEHPTEST_F(GfxCoreHelperTestsXeHP, GivenVariousValuesWhenComputeSlmSizeIsCalledThenCorrectValueIsReturned) { auto &hwInfo = pDevice->getHardwareInfo(); for (auto &testInput : computeSlmValuesXeHPAndLaterTestsInput) { - EXPECT_EQ(testInput.expected, HwHelperHw::get().computeSlmValues(hwInfo, testInput.slmSize)); + EXPECT_EQ(testInput.expected, GfxCoreHelperHw::get().computeSlmValues(hwInfo, testInput.slmSize)); } } diff --git a/opencl/test/unit_test/xe_hp_core/xehp/test_hw_info_config_xehp.inl b/opencl/test/unit_test/xe_hp_core/xehp/test_hw_info_config_xehp.inl index 2c8a700656..c83605c0d8 100644 --- a/opencl/test/unit_test/xe_hp_core/xehp/test_hw_info_config_xehp.inl +++ b/opencl/test/unit_test/xe_hp_core/xehp/test_hw_info_config_xehp.inl @@ -82,9 +82,9 @@ XEHPTEST_F(XeHPHwInfoConfig, givenA0OrA1SteppingWhenAskingIfExtraParametersAreIn } } -using XeHPHwHelperTest = HwHelperTest; +using XeHPGfxCoreHelperTest = GfxCoreHelperTest; -XEHPTEST_F(XeHPHwHelperTest, givenXeHPMultiConfigWhenAllowCompressionIsCalledThenCorrectValueIsReturned) { +XEHPTEST_F(XeHPGfxCoreHelperTest, givenXeHPMultiConfigWhenAllowCompressionIsCalledThenCorrectValueIsReturned) { auto hwInfoConfig = HwInfoConfig::get(productFamily); HardwareInfo hwInfo = *defaultHwInfo; diff --git a/opencl/test/unit_test/xe_hpc_core/excludes_ocl_xe_hpc_core.cpp b/opencl/test/unit_test/xe_hpc_core/excludes_ocl_xe_hpc_core.cpp index 218d65fdc0..959d29a6d5 100644 --- a/opencl/test/unit_test/xe_hpc_core/excludes_ocl_xe_hpc_core.cpp +++ b/opencl/test/unit_test/xe_hpc_core/excludes_ocl_xe_hpc_core.cpp @@ -9,7 +9,7 @@ HWTEST_EXCLUDE_PRODUCT(BufferSetSurfaceTests, givenAlignedCacheableReadOnlyBufferThenChoseOclBufferPolicy, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(BufferSetSurfaceTests, givenBufferSetSurfaceThatMemoryIsUnalignedToCachelineButReadOnlyThenL3CacheShouldBeStillOn, IGFX_XE_HPC_CORE); -HWTEST_EXCLUDE_PRODUCT(HwHelperTestXeHPAndLater, givenVariousCachesRequestProperMOCSIndexesAreBeingReturned, IGFX_XE_HPC_CORE); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTestXeHPAndLater, givenVariousCachesRequestProperMOCSIndexesAreBeingReturned, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(PipeControlHelperTestsXeHPAndLater, WhenAddingPipeControlWAThenCorrectCommandsAreProgrammed, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(QueueFamilyNameTest, givenRcsWhenGettingQueueFamilyNameThenReturnProperValue, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(EnqueueCopyBufferToImageStatelessTest, givenBigBufferWhenCopyingBufferToImageStatelessThenSuccessIsReturned, IGFX_XE_HPC_CORE); @@ -25,10 +25,10 @@ HWTEST_EXCLUDE_PRODUCT(HardwareCommandsTest, GivenVariousValuesWhenAlignSlmSizeI HWTEST_EXCLUDE_PRODUCT(HardwareCommandsTest, GivenVariousValuesWhenComputeSlmSizeIsCalledThenCorrectValueIsReturned, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(XeHPAndLaterDeviceCapsTests, givenHwInfoWhenSlmSizeIsRequiredThenReturnCorrectValue, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(DeviceGetCapsTest, givenDeviceWhenAskingForSubGroupSizesThenReturnCorrectValues, IGFX_XE_HPC_CORE); -HWTEST_EXCLUDE_PRODUCT(HwHelperTestXeHPAndLater, givenAllFlagsSetWhenGetGpgpuEnginesThenReturnThreeRcsEnginesFourCcsEnginesAndOneBcsEngine, IGFX_XE_HPC_CORE); -HWTEST_EXCLUDE_PRODUCT(HwHelperTestXeHPAndLater, givenCcsDisabledWhenGetGpgpuEnginesThenReturnRcsAndOneBcsEngine, IGFX_XE_HPC_CORE); -HWTEST_EXCLUDE_PRODUCT(HwHelperTestXeHPAndLater, givenBcsDisabledWhenGetGpgpuEnginesThenReturnThreeRcsEnginesFourCcsEngines, IGFX_XE_HPC_CORE); -HWTEST_EXCLUDE_PRODUCT(HwHelperTestXeHPAndLater, givenCcsDisabledAndNumberOfCcsEnabledWhenGetGpgpuEnginesThenReturnRcsAndOneBcsEngine, IGFX_XE_HPC_CORE); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTestXeHPAndLater, givenAllFlagsSetWhenGetGpgpuEnginesThenReturnThreeRcsEnginesFourCcsEnginesAndOneBcsEngine, IGFX_XE_HPC_CORE); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTestXeHPAndLater, givenCcsDisabledWhenGetGpgpuEnginesThenReturnRcsAndOneBcsEngine, IGFX_XE_HPC_CORE); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTestXeHPAndLater, givenBcsDisabledWhenGetGpgpuEnginesThenReturnThreeRcsEnginesFourCcsEngines, IGFX_XE_HPC_CORE); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTestXeHPAndLater, givenCcsDisabledAndNumberOfCcsEnabledWhenGetGpgpuEnginesThenReturnRcsAndOneBcsEngine, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(PipeControlHelperTestsXeHPAndLater, WhenGettingSizeForAdditionalSynchronizationThenCorrectValueIsReturned, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(MultiDeviceStorageInfoTest, givenSingleTileCsrWhenAllocatingCsrSpecificAllocationsThenStoreThemInSystemMemory, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(ClGfxCoreHelperTest, givenKernelInfoWhenCheckingRequiresAuxResolvesThenCorrectValuesAreReturned, IGFX_XE_HPC_CORE); diff --git a/opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp b/opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp index 220652ac3f..c67e9c5358 100644 --- a/opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp +++ b/opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp @@ -39,13 +39,13 @@ XE_HPC_CORETEST_F(ClGfxCoreHelperTestsXeHpcCore, WhenCheckingPreferenceForBlitte EXPECT_FALSE(clGfxCoreHelper.preferBlitterForLocalToLocalTransfers()); } -using HwHelperTestsXeHpcCore = Test; +using GfxCoreHelperTestsXeHpcCore = Test; -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenHwHelperwhenAskingForDcFlushThenReturnFalse) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenGfxCoreHelperwhenAskingForDcFlushThenReturnFalse) { EXPECT_FALSE(MemorySynchronizationCommands::getDcFlushEnable(true, *defaultHwInfo)); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCommandBufferAllocationTypeWhenGetAllocationDataIsCalledThenLocalMemoryIsRequested) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCommandBufferAllocationTypeWhenGetAllocationDataIsCalledThenLocalMemoryIsRequested) { AllocationData allocData; AllocationProperties properties(mockRootDeviceIndex, true, 10, AllocationType::COMMAND_BUFFER, false, mockDeviceBitfield); @@ -55,7 +55,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCommandBufferAllocationTypeWhenGe EXPECT_FALSE(allocData.flags.useSystemMemory); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenSingleTileBdA0CsrWhenAllocatingCsrSpecificAllocationsThenStoreThemInProperMemoryPool) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenSingleTileBdA0CsrWhenAllocatingCsrSpecificAllocationsThenStoreThemInProperMemoryPool) { const uint32_t numDevices = 4u; const uint32_t tileIndex = 2u; [[maybe_unused]] const DeviceBitfield tile0Mask = 1; @@ -91,30 +91,30 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenSingleTileBdA0CsrWhenAllocatingCs EXPECT_EQ(commandBufferAllocation->getMemoryPool(), MemoryPool::LocalMemory); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenXeHpcWhenAskedForMinimialSimdThen16IsReturned) { - auto &helper = HwHelper::get(renderCoreFamily); +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenXeHpcWhenAskedForMinimialSimdThen16IsReturned) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_EQ(16u, helper.getMinimalSIMDSize()); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, whenQueryingMaxNumSamplersThenReturnZero) { - auto &coreHelper = getHelper(); - EXPECT_EQ(0u, coreHelper.getMaxNumSamplers()); +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, whenQueryingMaxNumSamplersThenReturnZero) { + auto &gfxCoreHelper = getHelper(); + EXPECT_EQ(0u, gfxCoreHelper.getMaxNumSamplers()); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, GivenBarrierEncodingWhenCallingGetBarriersCountFromHasBarrierThenNumberOfBarriersIsReturned) { - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, GivenBarrierEncodingWhenCallingGetBarriersCountFromHasBarrierThenNumberOfBarriersIsReturned) { + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); - EXPECT_EQ(0u, hwHelper.getBarriersCountFromHasBarriers(0u)); - EXPECT_EQ(1u, hwHelper.getBarriersCountFromHasBarriers(1u)); - EXPECT_EQ(2u, hwHelper.getBarriersCountFromHasBarriers(2u)); - EXPECT_EQ(4u, hwHelper.getBarriersCountFromHasBarriers(3u)); - EXPECT_EQ(8u, hwHelper.getBarriersCountFromHasBarriers(4u)); - EXPECT_EQ(16u, hwHelper.getBarriersCountFromHasBarriers(5u)); - EXPECT_EQ(24u, hwHelper.getBarriersCountFromHasBarriers(6u)); - EXPECT_EQ(32u, hwHelper.getBarriersCountFromHasBarriers(7u)); + EXPECT_EQ(0u, gfxCoreHelper.getBarriersCountFromHasBarriers(0u)); + EXPECT_EQ(1u, gfxCoreHelper.getBarriersCountFromHasBarriers(1u)); + EXPECT_EQ(2u, gfxCoreHelper.getBarriersCountFromHasBarriers(2u)); + EXPECT_EQ(4u, gfxCoreHelper.getBarriersCountFromHasBarriers(3u)); + EXPECT_EQ(8u, gfxCoreHelper.getBarriersCountFromHasBarriers(4u)); + EXPECT_EQ(16u, gfxCoreHelper.getBarriersCountFromHasBarriers(5u)); + EXPECT_EQ(24u, gfxCoreHelper.getBarriersCountFromHasBarriers(6u)); + EXPECT_EQ(32u, gfxCoreHelper.getBarriersCountFromHasBarriers(7u)); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCccsDisabledButDebugVariableSetWhenIsCooperativeEngineSupportedEnabledAndGetGpgpuEnginesCalledThenSetCccsProperly) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCccsDisabledButDebugVariableSetWhenIsCooperativeEngineSupportedEnabledAndGetGpgpuEnginesCalledThenSetCccsProperly) { HardwareInfo hwInfo = *defaultHwInfo; const auto &hwInfoConfig = *HwInfoConfig::get(hardwareInfo.platform.eProductFamily); hwInfo.platform.usRevId = hwInfoConfig.getHwRevIdFromStepping(REVISION_B, hwInfo); @@ -131,7 +131,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCccsDisabledButDebugVariableSetWh auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(13u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(13u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); @@ -149,7 +149,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCccsDisabledButDebugVariableSetWh EXPECT_EQ(aub_stream::ENGINE_BCS, engines[12].first); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCccsDisabledWhenIsCooperativeEngineSupportedEnabledAndGetGpgpuEnginesCalledThenDontSetCccs) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCccsDisabledWhenIsCooperativeEngineSupportedEnabledAndGetGpgpuEnginesCalledThenDontSetCccs) { HardwareInfo hwInfo = *defaultHwInfo; const auto &hwInfoConfig = *HwInfoConfig::get(hardwareInfo.platform.eProductFamily); hwInfo.platform.usRevId = hwInfoConfig.getHwRevIdFromStepping(REVISION_B, hwInfo); @@ -163,7 +163,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCccsDisabledWhenIsCooperativeEngi auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(12u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(12u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); @@ -180,7 +180,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCccsDisabledWhenIsCooperativeEngi EXPECT_EQ(aub_stream::ENGINE_BCS, engines[11].first); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenBcsDisabledWhenIsCooperativeEngineSupportedEnabledAndGetEnginesCalledThenDontCreateAnyBcs) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenBcsDisabledWhenIsCooperativeEngineSupportedEnabledAndGetEnginesCalledThenDontCreateAnyBcs) { const size_t numEngines = 11; HardwareInfo hwInfo = *defaultHwInfo; @@ -194,7 +194,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenBcsDisabledWhenIsCooperativeEngin auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -224,7 +224,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenBcsDisabledWhenIsCooperativeEngin } } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenOneBcsEnabledWhenIsCooperativeEngineSupportedEnabledAndGetEnginesCalledThenCreateOnlyOneBcs) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenOneBcsEnabledWhenIsCooperativeEngineSupportedEnabledAndGetEnginesCalledThenCreateOnlyOneBcs) { const size_t numEngines = 13; HardwareInfo hwInfo = *defaultHwInfo; @@ -239,7 +239,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenOneBcsEnabledWhenIsCooperativeEng auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -271,7 +271,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenOneBcsEnabledWhenIsCooperativeEng } } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenNotAllCopyEnginesWhenIsCooperativeEngineSupportedEnabledAndSettingEngineTableThenDontAddUnsupported) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenNotAllCopyEnginesWhenIsCooperativeEngineSupportedEnabledAndSettingEngineTableThenDontAddUnsupported) { const size_t numEngines = 10; HardwareInfo hwInfo = *defaultHwInfo; @@ -290,7 +290,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenNotAllCopyEnginesWhenIsCooperativ auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -319,7 +319,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenNotAllCopyEnginesWhenIsCooperativ } } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenOneCcsEnabledWhenIsCooperativeEngineSupportedEnabledAndGetEnginesCalledThenCreateOnlyOneCcs) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenOneCcsEnabledWhenIsCooperativeEngineSupportedEnabledAndGetEnginesCalledThenCreateOnlyOneCcs) { const size_t numEngines = 16; HardwareInfo hwInfo = *defaultHwInfo; @@ -334,7 +334,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenOneCcsEnabledWhenIsCooperativeEng auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -369,7 +369,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenOneCcsEnabledWhenIsCooperativeEng } } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCccsAsDefaultEngineWhenIsCooperativeEngineSupportedEnabledAndGetEnginesCalledThenChangeDefaultEngine) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCccsAsDefaultEngineWhenIsCooperativeEngineSupportedEnabledAndGetEnginesCalledThenChangeDefaultEngine) { const size_t numEngines = 22; HardwareInfo hwInfo = *defaultHwInfo; @@ -384,7 +384,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCccsAsDefaultEngineWhenIsCooperat auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -425,7 +425,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCccsAsDefaultEngineWhenIsCooperat } } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, whenIsCooperativeEngineSupportedEnabledAndGetGpgpuEnginesThenReturnTwoCccsEnginesAndFourCcsEnginesAndEightLinkCopyEngines) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, whenIsCooperativeEngineSupportedEnabledAndGetGpgpuEnginesThenReturnTwoCccsEnginesAndFourCcsEnginesAndEightLinkCopyEngines) { const size_t numEngines = 22; HardwareInfo hwInfo = *defaultHwInfo; @@ -440,7 +440,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, whenIsCooperativeEngineSupportedEnable auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -481,7 +481,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, whenIsCooperativeEngineSupportedEnable } } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, whenIsCooperativeEngineSupportedEnabledAndGetGpgpuEnginesThenReturnTwoCccsEnginesAndFourCcsEnginesAndLinkCopyEngines) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, whenIsCooperativeEngineSupportedEnabledAndGetGpgpuEnginesThenReturnTwoCccsEnginesAndFourCcsEnginesAndLinkCopyEngines) { const size_t numEngines = 22; HardwareInfo hwInfo = *defaultHwInfo; @@ -496,7 +496,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, whenIsCooperativeEngineSupportedEnable auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -537,7 +537,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, whenIsCooperativeEngineSupportedEnable } } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCcsDisabledAndNumberOfCcsEnabledWhenGetGpgpuEnginesThenReturnCccsEngines) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCcsDisabledAndNumberOfCcsEnabledWhenGetGpgpuEnginesThenReturnCccsEngines) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.flags.ftrCCSNode = false; hwInfo.featureTable.ftrBcsInfo = 0; @@ -547,7 +547,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCcsDisabledAndNumberOfCcsEnabledW auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(3u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCCS, engines[0].first); @@ -555,7 +555,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCcsDisabledAndNumberOfCcsEnabledW EXPECT_EQ(aub_stream::ENGINE_CCCS, engines[2].first); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCcsDisabledWhenGetGpgpuEnginesThenReturnCccsEngines) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCcsDisabledWhenGetGpgpuEnginesThenReturnCccsEngines) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.flags.ftrCCSNode = false; hwInfo.featureTable.ftrBcsInfo = 0; @@ -565,7 +565,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCcsDisabledWhenGetGpgpuEnginesThe auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(3u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCCS, engines[0].first); @@ -573,11 +573,11 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCcsDisabledWhenGetGpgpuEnginesThe EXPECT_EQ(aub_stream::ENGINE_CCCS, engines[2].first); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, whenNonBcsEngineIsVerifiedThenReturnFalse) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, whenNonBcsEngineIsVerifiedThenReturnFalse) { EXPECT_FALSE(EngineHelpers::isBcs(static_cast(aub_stream::ENGINE_BCS8 + 1))); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, whenPipecontrolWaIsProgrammedThenFlushL1Cache) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, whenPipecontrolWaIsProgrammedThenFlushL1Cache) { DebugManagerStateRestore restorer; DebugManager.flags.DisablePipeControlPrecedingPostSyncCommand.set(1); using PIPE_CONTROL = typename FamilyType::PIPE_CONTROL; @@ -594,39 +594,39 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, whenPipecontrolWaIsProgrammedThenFlush EXPECT_TRUE(pipeControl->getUnTypedDataPortCacheFlush()); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenHwHelperWhenAskedIfFenceAllocationRequiredThenReturnCorrectValue) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenGfxCoreHelperWhenAskedIfFenceAllocationRequiredThenReturnCorrectValue) { DebugManagerStateRestore dbgRestore; auto hwInfo = *defaultHwInfo; - auto &coreHelper = getHelper(); + auto &gfxCoreHelper = getHelper(); DebugManager.flags.ProgramGlobalFenceAsMiMemFenceCommandInCommandStream.set(-1); DebugManager.flags.ProgramGlobalFenceAsPostSyncOperationInComputeWalker.set(-1); DebugManager.flags.ProgramGlobalFenceAsKernelInstructionInEUKernel.set(-1); - EXPECT_TRUE(coreHelper.isFenceAllocationRequired(hwInfo)); + EXPECT_TRUE(gfxCoreHelper.isFenceAllocationRequired(hwInfo)); DebugManager.flags.ProgramGlobalFenceAsMiMemFenceCommandInCommandStream.set(0); DebugManager.flags.ProgramGlobalFenceAsPostSyncOperationInComputeWalker.set(0); DebugManager.flags.ProgramGlobalFenceAsKernelInstructionInEUKernel.set(0); - EXPECT_FALSE(coreHelper.isFenceAllocationRequired(hwInfo)); + EXPECT_FALSE(gfxCoreHelper.isFenceAllocationRequired(hwInfo)); DebugManager.flags.ProgramGlobalFenceAsMiMemFenceCommandInCommandStream.set(1); DebugManager.flags.ProgramGlobalFenceAsPostSyncOperationInComputeWalker.set(0); DebugManager.flags.ProgramGlobalFenceAsKernelInstructionInEUKernel.set(0); - EXPECT_TRUE(coreHelper.isFenceAllocationRequired(hwInfo)); + EXPECT_TRUE(gfxCoreHelper.isFenceAllocationRequired(hwInfo)); DebugManager.flags.ProgramGlobalFenceAsMiMemFenceCommandInCommandStream.set(0); DebugManager.flags.ProgramGlobalFenceAsPostSyncOperationInComputeWalker.set(1); DebugManager.flags.ProgramGlobalFenceAsKernelInstructionInEUKernel.set(0); - EXPECT_TRUE(coreHelper.isFenceAllocationRequired(hwInfo)); + EXPECT_TRUE(gfxCoreHelper.isFenceAllocationRequired(hwInfo)); DebugManager.flags.ProgramGlobalFenceAsMiMemFenceCommandInCommandStream.set(0); DebugManager.flags.ProgramGlobalFenceAsPostSyncOperationInComputeWalker.set(0); DebugManager.flags.ProgramGlobalFenceAsKernelInstructionInEUKernel.set(1); - EXPECT_TRUE(coreHelper.isFenceAllocationRequired(hwInfo)); + EXPECT_TRUE(gfxCoreHelper.isFenceAllocationRequired(hwInfo)); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenDontProgramGlobalFenceAsMiMemFenceCommandInCommandStreamWhenGettingSizeForAdditionalSynchronizationThenCorrectValueIsReturned) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenDontProgramGlobalFenceAsMiMemFenceCommandInCommandStreamWhenGettingSizeForAdditionalSynchronizationThenCorrectValueIsReturned) { DebugManagerStateRestore debugRestorer; DebugManager.flags.ProgramGlobalFenceAsMiMemFenceCommandInCommandStream.set(0); @@ -637,7 +637,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenDontProgramGlobalFenceAsMiMemFenc EXPECT_EQ(sizeof(MI_SEMAPHORE_WAIT), MemorySynchronizationCommands::getSizeForAdditonalSynchronization(hardwareInfo)); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenProgramGlobalFenceAsMiMemFenceCommandInCommandStreamWhenGettingSizeForAdditionalSynchronizationThenCorrectValueIsReturned) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenProgramGlobalFenceAsMiMemFenceCommandInCommandStreamWhenGettingSizeForAdditionalSynchronizationThenCorrectValueIsReturned) { DebugManagerStateRestore debugRestorer; DebugManager.flags.ProgramGlobalFenceAsMiMemFenceCommandInCommandStream.set(1); @@ -648,8 +648,8 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenProgramGlobalFenceAsMiMemFenceCom EXPECT_EQ(sizeof(MI_MEM_FENCE), MemorySynchronizationCommands::getSizeForAdditonalSynchronization(hardwareInfo)); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenHwHelperWhenGettingThreadsPerEUConfigsThenCorrectConfigsAreReturned) { - auto &helper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenGfxCoreHelperWhenGettingThreadsPerEUConfigsThenCorrectConfigsAreReturned) { + auto &helper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); EXPECT_NE(nullptr, &helper); auto &configs = helper.getThreadsPerEUConfigs(); @@ -721,15 +721,15 @@ XE_HPC_CORETEST_F(LriHelperTestsXeHpcCore, whenProgrammingLriCommandThenExpectMm EXPECT_TRUE(memcmp(lri, &expectedLri, sizeof(MI_LOAD_REGISTER_IMM)) == 0); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, WhenCheckingSipWAThenFalseIsReturned) { - EXPECT_FALSE(HwHelper::get(renderCoreFamily).isSipWANeeded(*defaultHwInfo)); +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, WhenCheckingSipWAThenFalseIsReturned) { + EXPECT_FALSE(GfxCoreHelper::get(renderCoreFamily).isSipWANeeded(*defaultHwInfo)); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenBdA0WhenBcsSubDeviceSupportIsCheckedThenReturnFalse) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenBdA0WhenBcsSubDeviceSupportIsCheckedThenReturnFalse) { DebugManagerStateRestore restore; HardwareInfo hwInfo = *defaultHwInfo; - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto hwInfoConfig = HwInfoConfig::get(productFamily); constexpr uint8_t bdRev[4] = {0, 0b111001, 0b101001, 0b000101}; @@ -744,7 +744,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenBdA0WhenBcsSubDeviceSupportIsChec for (uint32_t engineType = 0; engineType < static_cast(aub_stream::EngineType::NUM_ENGINES); engineType++) { auto engineTypeT = static_cast(engineType); - bool result = hwHelper.isSubDeviceEngineSupported(hwInfo, DeviceBitfield(1llu << subDevice), engineTypeT); + bool result = gfxCoreHelper.isSubDeviceEngineSupported(hwInfo, DeviceBitfield(1llu << subDevice), engineTypeT); bool affectedEngine = ((subDevice == 1) && (aub_stream::ENGINE_BCS == engineTypeT || @@ -763,11 +763,11 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenBdA0WhenBcsSubDeviceSupportIsChec } } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenBdA0WhenAllocatingOnNonTileZeroThenForceTile0) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenBdA0WhenAllocatingOnNonTileZeroThenForceTile0) { DebugManagerStateRestore restore; HardwareInfo hwInfo = *defaultHwInfo; - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto hwInfoConfig = HwInfoConfig::get(productFamily); constexpr uint8_t bdRev[4] = {0, 0b111001, 0b101001, 0b000101}; @@ -792,7 +792,7 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenBdA0WhenAllocatingOnNonTileZeroTh allocData.flags.requiresCpuAccess = true; allocData.storageInfo.memoryBanks = originalMask; - hwHelper.setExtraAllocationData(allocData, allocProperties, hwInfo); + gfxCoreHelper.setExtraAllocationData(allocData, allocProperties, hwInfo); bool applyWa = (isBdA0 || (debugFlag == 1)); applyWa &= (debugFlag != 0); @@ -807,9 +807,9 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenBdA0WhenAllocatingOnNonTileZeroTh } } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCommandBufferAllocationWhenSetExtraAllocationDataThenUseSystemLocalMemoryOnlyForImplicitScalingCommandBuffers) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCommandBufferAllocationWhenSetExtraAllocationDataThenUseSystemLocalMemoryOnlyForImplicitScalingCommandBuffers) { HardwareInfo hwInfo = *defaultHwInfo; - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); constexpr DeviceBitfield singleTileBitfield = 0b0100; constexpr DeviceBitfield allTilesBitfield = 0b1111; @@ -820,14 +820,14 @@ XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, givenCommandBufferAllocationWhenSetExt AllocationData allocData; allocData.flags.useSystemMemory = false; - hwHelper.setExtraAllocationData(allocData, singleTileAllocProperties, hwInfo); + gfxCoreHelper.setExtraAllocationData(allocData, singleTileAllocProperties, hwInfo); EXPECT_FALSE(allocData.flags.useSystemMemory); - hwHelper.setExtraAllocationData(allocData, allTilesAllocProperties, hwInfo); + gfxCoreHelper.setExtraAllocationData(allocData, allTilesAllocProperties, hwInfo); EXPECT_FALSE(allocData.flags.useSystemMemory); } -XE_HPC_CORETEST_F(HwHelperTestsXeHpcCore, WhenGettingDeviceIpVersionThenMakeCorrectDeviceIpVersion) { +XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, WhenGettingDeviceIpVersionThenMakeCorrectDeviceIpVersion) { auto &clGfxCoreHelper = getHelper(); EXPECT_EQ(ClGfxCoreHelperMock::makeDeviceIpVersion(12, 8, 1), clGfxCoreHelper.getDeviceIpVersion(*defaultHwInfo)); diff --git a/opencl/test/unit_test/xe_hpg_core/dg2/excludes_ocl_dg2.cpp b/opencl/test/unit_test/xe_hpg_core/dg2/excludes_ocl_dg2.cpp index 9c915081d9..0c7892328f 100644 --- a/opencl/test/unit_test/xe_hpg_core/dg2/excludes_ocl_dg2.cpp +++ b/opencl/test/unit_test/xe_hpg_core/dg2/excludes_ocl_dg2.cpp @@ -9,7 +9,7 @@ HWTEST_EXCLUDE_PRODUCT(HwInfoConfigTestXeHpAndLater, givenXeHPAndLaterPlatformWhenAskedIfTile64With3DSurfaceOnBCSIsSupportedThenFalseIsReturned, IGFX_DG2); HWTEST_EXCLUDE_PRODUCT(WddmMemoryManagerSimpleTest, givenLinearStreamWhenItIsAllocatedThenItIsInLocalMemoryHasCpuPointerAndHasStandardHeap64kbAsGpuAddress, IGFX_DG2); -HWTEST_EXCLUDE_PRODUCT(HwHelperTestXeHPAndLater, GiveCcsNodeThenDefaultEngineTypeIsCcs, IGFX_DG2); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTestXeHPAndLater, GiveCcsNodeThenDefaultEngineTypeIsCcs, IGFX_DG2); HWTEST_EXCLUDE_PRODUCT(XeHPAndLaterDeviceCapsTests, givenHwInfoWhenRequestedComputeUnitsUsedForScratchThenReturnValidValue, IGFX_DG2); HWTEST_EXCLUDE_PRODUCT(ProgramTests, givenAtLeastXeHpgCoreWhenGetInternalOptionsThenCorrectBuildOptionIsSet_IsAtLeastXeHpgCore, IGFX_DG2); HWTEST_EXCLUDE_PRODUCT(CmdsProgrammingTestsXeHpgCore, givenL3ToL1DebugFlagWhenStatelessMocsIsProgrammedThenItHasL1CachingOn, IGFX_DG2); diff --git a/shared/source/aub/aub_center.cpp b/shared/source/aub/aub_center.cpp index 3a079a0145..5cc72950eb 100644 --- a/shared/source/aub/aub_center.cpp +++ b/shared/source/aub/aub_center.cpp @@ -24,7 +24,7 @@ extern aub_stream::AubManager *createAubManager(const aub_stream::AubManagerOpti AubCenter::AubCenter(const RootDeviceEnvironment &rootDeviceEnvironment, bool localMemoryEnabled, const std::string &aubFileName, CommandStreamReceiverType csrType) { if (DebugManager.flags.UseAubStream.get()) { auto hwInfo = rootDeviceEnvironment.getHardwareInfo(); - auto devicesCount = HwHelper::getSubDevicesCount(hwInfo); + auto devicesCount = GfxCoreHelper::getSubDevicesCount(hwInfo); auto memoryBankSize = AubHelper::getPerTileLocalMemorySize(hwInfo); CommandStreamReceiverType type = csrType; if (DebugManager.flags.SetCommandStreamReceiver.get() >= CommandStreamReceiverType::CSR_HW) { @@ -33,7 +33,7 @@ AubCenter::AubCenter(const RootDeviceEnvironment &rootDeviceEnvironment, bool lo aubStreamMode = getAubStreamMode(aubFileName, type); - auto &coreHelper = rootDeviceEnvironment.getHelper(); + auto &gfxCoreHelper = rootDeviceEnvironment.getHelper(); const auto &productHelper = rootDeviceEnvironment.getHelper(); auto aubStreamProductFamily = productHelper.getAubStreamProductFamily(); @@ -41,7 +41,7 @@ AubCenter::AubCenter(const RootDeviceEnvironment &rootDeviceEnvironment, bool lo stepping = productHelper.getAubStreamSteppingFromHwRevId(*hwInfo); auto gmmHelper = rootDeviceEnvironment.getGmmHelper(); - aub_stream::MMIOList extraMmioList = coreHelper.getExtraMmioList(*hwInfo, *gmmHelper); + aub_stream::MMIOList extraMmioList = gfxCoreHelper.getExtraMmioList(*hwInfo, *gmmHelper); aub_stream::MMIOList debugMmioList = AubHelper::getAdditionalMmioList(); extraMmioList.insert(extraMmioList.end(), debugMmioList.begin(), debugMmioList.end()); diff --git a/shared/source/aub/aub_helper.cpp b/shared/source/aub/aub_helper.cpp index 16563a8366..64155f07b6 100644 --- a/shared/source/aub/aub_helper.cpp +++ b/shared/source/aub/aub_helper.cpp @@ -46,6 +46,6 @@ uint64_t AubHelper::getPerTileLocalMemorySize(const HardwareInfo *pHwInfo) { if (DebugManager.flags.HBMSizePerTileInGigabytes.get() > 0) { return DebugManager.flags.HBMSizePerTileInGigabytes.get() * MemoryConstants::gigaByte; } - return getTotalMemBankSize() / HwHelper::getSubDevicesCount(pHwInfo); + return getTotalMemBankSize() / GfxCoreHelper::getSubDevicesCount(pHwInfo); } } // namespace NEO diff --git a/shared/source/built_ins/built_ins_storage.cpp b/shared/source/built_ins/built_ins_storage.cpp index e7d49b08f7..6e2907fbe6 100644 --- a/shared/source/built_ins/built_ins_storage.cpp +++ b/shared/source/built_ins/built_ins_storage.cpp @@ -80,7 +80,7 @@ std::string createBuiltinResourceName(EBuiltInOps::Type builtin, const std::stri StackVec getBuiltinResourceNames(EBuiltInOps::Type builtin, BuiltinCode::ECodeType type, const Device &device) { auto &hwInfo = device.getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto &productHelper = device.getRootDeviceEnvironment().getHelper(); const auto platformName = getFamilyNameWithType(hwInfo); @@ -114,7 +114,7 @@ StackVec getBuiltinResourceNames(EBuiltInOps::Type builtin, Buil StackVec resourcesToLookup = {}; resourcesToLookup.push_back(createBuiltinResourceName(platformName, revisionId, addressingMode, builtinName, extension)); - const bool requiresSpecificResource = (BuiltinCode::ECodeType::Binary == type && hwHelper.isRevisionSpecificBinaryBuiltinRequired()); + const bool requiresSpecificResource = (BuiltinCode::ECodeType::Binary == type && gfxCoreHelper.isRevisionSpecificBinaryBuiltinRequired()); if (false == requiresSpecificResource) { const auto defaultRevisionId = std::to_string(productHelper.getDefaultRevisionId()); resourcesToLookup.push_back(createBuiltinResourceName(platformName, defaultRevisionId, addressingMode, builtinName, extension)); diff --git a/shared/source/built_ins/sip.cpp b/shared/source/built_ins/sip.cpp index c1dd1e4f41..f563b5c538 100644 --- a/shared/source/built_ins/sip.cpp +++ b/shared/source/built_ins/sip.cpp @@ -73,8 +73,8 @@ const std::vector &SipKernel::getStateSaveAreaHeader() const { size_t SipKernel::getStateSaveAreaSize(Device *device) const { auto &hwInfo = device->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - auto maxDbgSurfaceSize = hwHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto maxDbgSurfaceSize = gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo); const auto &stateSaveAreaHeader = getStateSaveAreaHeader(); if (stateSaveAreaHeader.empty()) { return maxDbgSurfaceSize; @@ -105,8 +105,8 @@ SipKernelType SipKernel::getSipKernelType(Device &device) { } SipKernelType SipKernel::getSipKernelType(Device &device, bool debuggingEnabled) { - auto &hwHelper = HwHelper::get(device.getHardwareInfo().platform.eRenderCoreFamily); - return hwHelper.getSipKernelType(debuggingEnabled); + auto &gfxCoreHelper = GfxCoreHelper::get(device.getHardwareInfo().platform.eRenderCoreFamily); + return gfxCoreHelper.getSipKernelType(debuggingEnabled); } bool SipKernel::initBuiltinsSipKernel(SipKernelType type, Device &device) { @@ -191,9 +191,9 @@ bool SipKernel::initHexadecimalArraySipKernel(SipKernelType type, Device &device uint32_t *sipKernelBinary = nullptr; size_t kernelBinarySize = 0u; auto &hwInfo = device.getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - hwHelper.setSipKernelData(sipKernelBinary, kernelBinarySize); + gfxCoreHelper.setSipKernelData(sipKernelBinary, kernelBinarySize); const auto allocType = AllocationType::KERNEL_ISA_INTERNAL; AllocationProperties properties = {rootDeviceIndex, kernelBinarySize, allocType, device.getDeviceBitfield()}; properties.flags.use32BitFrontWindow = false; @@ -225,7 +225,7 @@ void SipKernel::freeSipKernels(RootDeviceEnvironment *rootDeviceEnvironment, Mem void SipKernel::selectSipClassType(std::string &fileName, const HardwareInfo &hwInfo) { const std::string unknown("unk"); if (fileName.compare(unknown) == 0) { - SipKernel::classType = HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSipKernelAsHexadecimalArrayPreferred() + SipKernel::classType = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSipKernelAsHexadecimalArrayPreferred() ? SipClassType::HexadecimalHeaderFile : SipClassType::Builtins; } else { diff --git a/shared/source/command_container/cmdcontainer.cpp b/shared/source/command_container/cmdcontainer.cpp index f3411af21e..5b9e71c119 100644 --- a/shared/source/command_container/cmdcontainer.cpp +++ b/shared/source/command_container/cmdcontainer.cpp @@ -77,9 +77,9 @@ CommandContainer::ErrorCode CommandContainer::initialize(Device *device, Allocat cmdBufferAllocations.push_back(cmdBufferAllocation); const auto &hardwareInfo = device->getHardwareInfo(); - auto &hwHelper = NEO::HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); commandStream = std::make_unique(cmdBufferAllocation->getUnderlyingBuffer(), - alignedSize - cmdBufferReservedSize, this, hwHelper.getBatchBufferEndSize()); + alignedSize - cmdBufferReservedSize, this, gfxCoreHelper.getBatchBufferEndSize()); commandStream->replaceGraphicsAllocation(cmdBufferAllocation); @@ -296,10 +296,10 @@ void CommandContainer::allocateNextCommandBuffer() { } void CommandContainer::closeAndAllocateNextCommandBuffer() { - auto &hwHelper = NEO::HwHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily); - auto bbEndSize = hwHelper.getBatchBufferEndSize(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily); + auto bbEndSize = gfxCoreHelper.getBatchBufferEndSize(); auto ptr = commandStream->getSpace(0u); - memcpy_s(ptr, bbEndSize, hwHelper.getBatchBufferEndReference(), bbEndSize); + memcpy_s(ptr, bbEndSize, gfxCoreHelper.getBatchBufferEndReference(), bbEndSize); allocateNextCommandBuffer(); currentLinearStreamStartOffset = 0u; } @@ -383,8 +383,8 @@ GraphicsAllocation *CommandContainer::allocateCommandBuffer() { void CommandContainer::fillReusableAllocationLists() { this->immediateReusableAllocationList = std::make_unique(); const auto &hardwareInfo = device->getHardwareInfo(); - auto &hwHelper = NEO::HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - auto amountToFill = hwHelper.getAmountOfAllocationsToFill(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto amountToFill = gfxCoreHelper.getAmountOfAllocationsToFill(); if (amountToFill == 0u) { return; } diff --git a/shared/source/command_container/command_encoder_bdw_and_later.inl b/shared/source/command_container/command_encoder_bdw_and_later.inl index ed8669bfb1..af87a5be77 100644 --- a/shared/source/command_container/command_encoder_bdw_and_later.inl +++ b/shared/source/command_container/command_encoder_bdw_and_later.inl @@ -84,7 +84,7 @@ void EncodeDispatchKernel::encode(CommandContainer &container, EncodeDis kernelDescriptor.kernelAttributes.barrierCount, hwInfo); auto slmSize = static_cast( - HwHelperHw::get().computeSlmValues(hwInfo, args.dispatchInterface->getSlmTotalSize())); + GfxCoreHelperHw::get().computeSlmValues(hwInfo, args.dispatchInterface->getSlmTotalSize())); idd.setSharedLocalMemorySize(slmSize); uint32_t bindingTableStateCount = kernelDescriptor.payloadMappings.bindingTable.numEntries; diff --git a/shared/source/command_container/command_encoder_xehp_and_later.inl b/shared/source/command_container/command_encoder_xehp_and_later.inl index 20063b0cf1..97a7f8e396 100644 --- a/shared/source/command_container/command_encoder_xehp_and_later.inl +++ b/shared/source/command_container/command_encoder_xehp_and_later.inl @@ -102,7 +102,7 @@ void EncodeDispatchKernel::encode(CommandContainer &container, EncodeDis hwInfo); auto slmSize = static_cast( - HwHelperHw::get().computeSlmValues(hwInfo, args.dispatchInterface->getSlmTotalSize())); + GfxCoreHelperHw::get().computeSlmValues(hwInfo, args.dispatchInterface->getSlmTotalSize())); if (DebugManager.flags.OverrideSlmAllocationSize.get() != -1) { slmSize = static_cast(DebugManager.flags.OverrideSlmAllocationSize.get()); diff --git a/shared/source/command_container/implicit_scaling_xehp_and_later.inl b/shared/source/command_container/implicit_scaling_xehp_and_later.inl index 58a1f356a5..14145d1b00 100644 --- a/shared/source/command_container/implicit_scaling_xehp_and_later.inl +++ b/shared/source/command_container/implicit_scaling_xehp_and_later.inl @@ -234,7 +234,7 @@ inline void ImplicitScalingDispatch::dispatchOffsetRegister(LinearStr template inline uint32_t ImplicitScalingDispatch::getPostSyncOffset() { - return static_cast(HwHelperHw::getSingleTimestampPacketSizeHw()); + return static_cast(GfxCoreHelperHw::getSingleTimestampPacketSizeHw()); } template diff --git a/shared/source/command_stream/aub_command_stream_receiver.cpp b/shared/source/command_stream/aub_command_stream_receiver.cpp index b6050b813e..0485871ff8 100644 --- a/shared/source/command_stream/aub_command_stream_receiver.cpp +++ b/shared/source/command_stream/aub_command_stream_receiver.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2018-2021 Intel Corporation + * Copyright (C) 2018-2022 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -30,7 +30,7 @@ std::string AUBCommandStreamReceiver::createFullFilePath(const HardwareInfo &hwI // Generate the full filename const auto >SystemInfo = hwInfo.gtSystemInfo; std::stringstream strfilename; - auto subDevicesCount = HwHelper::getSubDevicesCount(&hwInfo); + auto subDevicesCount = GfxCoreHelper::getSubDevicesCount(&hwInfo); uint32_t subSlicesPerSlice = gtSystemInfo.SubSliceCount / gtSystemInfo.SliceCount; strfilename << hwPrefix << "_"; if (subDevicesCount > 1) { diff --git a/shared/source/command_stream/command_stream_receiver.cpp b/shared/source/command_stream/command_stream_receiver.cpp index 982ed22407..f5de432e2a 100644 --- a/shared/source/command_stream/command_stream_receiver.cpp +++ b/shared/source/command_stream/command_stream_receiver.cpp @@ -71,7 +71,7 @@ CommandStreamReceiver::CommandStreamReceiver(ExecutionEnvironment &executionEnvi internalAllocationStorage = std::make_unique(*this); const auto &hwInfo = peekHwInfo(); uint32_t subDeviceCount = static_cast(deviceBitfield.count()); - bool platformImplicitScaling = HwHelper::get(hwInfo.platform.eRenderCoreFamily).platformSupportsImplicitScaling(hwInfo); + bool platformImplicitScaling = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).platformSupportsImplicitScaling(hwInfo); if (NEO::ImplicitScalingHelper::isImplicitScalingEnabled(deviceBitfield, platformImplicitScaling) && subDeviceCount > 1 && DebugManager.flags.EnableStaticPartitioning.get() != 0) { @@ -241,7 +241,7 @@ void CommandStreamReceiver::ensureCommandBufferAllocation(LinearStream &commandS } void CommandStreamReceiver::fillReusableAllocationsList() { - auto amountToFill = HwHelper::get(peekHwInfo().platform.eRenderCoreFamily).getAmountOfAllocationsToFill(); + auto amountToFill = GfxCoreHelper::get(peekHwInfo().platform.eRenderCoreFamily).getAmountOfAllocationsToFill(); for (auto i = 0u; i < amountToFill; i++) { const AllocationProperties commandStreamAllocationProperties{rootDeviceIndex, true, MemoryConstants::pageSize64k, AllocationType::COMMAND_BUFFER, isMultiOsContextCapable(), false, deviceBitfield}; @@ -744,9 +744,9 @@ bool CommandStreamReceiver::createWorkPartitionAllocation(const Device &device) bool CommandStreamReceiver::createGlobalFenceAllocation() { auto &rootDevicEnvironment = *executionEnvironment.rootDeviceEnvironments[rootDeviceIndex].get(); - auto &coreHelper = rootDevicEnvironment.getHelper(); + auto &gfxCoreHelper = rootDevicEnvironment.getHelper(); auto &hwInfo = *rootDevicEnvironment.getHardwareInfo(); - if (!coreHelper.isFenceAllocationRequired(hwInfo)) { + if (!gfxCoreHelper.isFenceAllocationRequired(hwInfo)) { return true; } @@ -763,7 +763,7 @@ bool CommandStreamReceiver::createPreemptionAllocation() { } AllocationProperties properties{rootDeviceIndex, true, preemptionSurfaceSize, AllocationType::PREEMPTION, isMultiOsContextCapable(), false, deviceBitfield}; properties.flags.uncacheable = hwInfo->workaroundTable.flags.waCSRUncachable; - properties.alignment = HwHelper::get(hwInfo->platform.eRenderCoreFamily).getPreemptionAllocationAlignment(); + properties.alignment = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getPreemptionAllocationAlignment(); this->preemptionAllocation = getMemoryManager()->allocateGraphicsMemoryWithProperties(properties); return this->preemptionAllocation != nullptr; } diff --git a/shared/source/command_stream/command_stream_receiver_hw_base.inl b/shared/source/command_stream/command_stream_receiver_hw_base.inl index 433be29b75..d9457e8b9a 100644 --- a/shared/source/command_stream/command_stream_receiver_hw_base.inl +++ b/shared/source/command_stream/command_stream_receiver_hw_base.inl @@ -60,8 +60,8 @@ CommandStreamReceiverHw::CommandStreamReceiverHw(ExecutionEnvironment : CommandStreamReceiver(executionEnvironment, rootDeviceIndex, deviceBitfield) { const auto &hwInfo = peekHwInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - localMemoryEnabled = hwHelper.getEnableLocalMemory(hwInfo); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + localMemoryEnabled = gfxCoreHelper.getEnableLocalMemory(hwInfo); resetKmdNotifyHelper(new KmdNotifyHelper(&hwInfo.capabilityTable.kmdNotifyProperties)); @@ -71,7 +71,7 @@ CommandStreamReceiverHw::CommandStreamReceiverHw(ExecutionEnvironment defaultSshSize = getSshHeapSize(); canUse4GbHeaps = are4GbHeapsAvailable(); - timestampPacketWriteEnabled = hwHelper.timestampPacketWriteSupported(); + timestampPacketWriteEnabled = gfxCoreHelper.timestampPacketWriteSupported(); if (DebugManager.flags.EnableTimestampPacket.get() != -1) { timestampPacketWriteEnabled = !!DebugManager.flags.EnableTimestampPacket.get(); } @@ -292,7 +292,7 @@ CompletionStamp CommandStreamReceiverHw::flushTask( } const auto &hwInfo = peekHwInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); if (dispatchFlags.blocking || dispatchFlags.dcFlush || dispatchFlags.guardCommandBufferWithPipeControl || this->heapStorageReqiuresRecyclingTag) { if (this->dispatchMode == DispatchMode::ImmediateDispatch) { @@ -356,7 +356,7 @@ CompletionStamp CommandStreamReceiverHw::flushTask( dispatchFlags.pipelineSelectArgs.systolicPipelineSelectSupport = this->pipelineSupportFlags.systolicMode; handlePipelineSelectStateTransition(dispatchFlags); - auto requiresCoherency = hwHelper.forceNonGpuCoherencyWA(dispatchFlags.requiresCoherency); + auto requiresCoherency = gfxCoreHelper.forceNonGpuCoherencyWA(dispatchFlags.requiresCoherency); this->streamProperties.stateComputeMode.setProperties(requiresCoherency, dispatchFlags.numGrfRequired, dispatchFlags.threadArbitrationPolicy, device.getPreemptionMode(), hwInfo); @@ -445,7 +445,7 @@ CompletionStamp CommandStreamReceiverHw::flushTask( if (dispatchFlags.l3CacheSettings != L3CachingSettings::NotApplicable) { auto l3On = dispatchFlags.l3CacheSettings != L3CachingSettings::l3CacheOff; auto l1On = dispatchFlags.l3CacheSettings == L3CachingSettings::l3AndL1On; - mocsIndex = hwHelper.getMocsIndex(*device.getGmmHelper(), l3On, l1On); + mocsIndex = gfxCoreHelper.getMocsIndex(*device.getGmmHelper(), l3On, l1On); } if (mocsIndex != latestSentStatelessMocsConfig) { @@ -1082,8 +1082,8 @@ inline void CommandStreamReceiverHw::programVFEState(LinearStream &cs auto disableOverdispatch = (dispatchFlags.additionalKernelExecInfo != AdditionalKernelExecInfo::NotSet); streamProperties.frontEndState.setProperties(isCooperative, dispatchFlags.disableEUFusion, disableOverdispatch, osContext->isEngineInstanced(), hwInfo); - auto &hwHelper = NEO::HwHelper::get(hwInfo.platform.eRenderCoreFamily); - auto engineGroupType = hwHelper.getEngineGroupType(getOsContext().getEngineType(), getOsContext().getEngineUsage(), hwInfo); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto engineGroupType = gfxCoreHelper.getEngineGroupType(getOsContext().getEngineType(), getOsContext().getEngineUsage(), hwInfo); auto pVfeState = PreambleHelper::getSpaceForVfeState(&csr, hwInfo, engineGroupType); PreambleHelper::programVfeState( pVfeState, hwInfo, requiredScratchSize, getScratchPatchAddress(), @@ -1394,8 +1394,8 @@ inline SubmissionStatus CommandStreamReceiverHw::flushHandler(BatchBu template inline bool CommandStreamReceiverHw::isUpdateTagFromWaitEnabled() { - auto &hwHelper = HwHelper::get(peekHwInfo().platform.eRenderCoreFamily); - auto enabled = hwHelper.isUpdateTaskCountFromWaitSupported(); + auto &gfxCoreHelper = GfxCoreHelper::get(peekHwInfo().platform.eRenderCoreFamily); + auto enabled = gfxCoreHelper.isUpdateTaskCountFromWaitSupported(); enabled &= this->isAnyDirectSubmissionEnabled(); switch (DebugManager.flags.UpdateTaskCountFromWait.get()) { @@ -1514,10 +1514,10 @@ inline bool CommandStreamReceiverHw::initDirectSubmission() { template TagAllocatorBase *CommandStreamReceiverHw::getTimestampPacketAllocator() { if (timestampPacketAllocator.get() == nullptr) { - auto &hwHelper = HwHelper::get(peekHwInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(peekHwInfo().platform.eRenderCoreFamily); const RootDeviceIndicesContainer rootDeviceIndices = {rootDeviceIndex}; - timestampPacketAllocator = hwHelper.createTimestampPacketAllocator(rootDeviceIndices, getMemoryManager(), getPreferredTagPoolSize(), getType(), osContext->getDeviceBitfield()); + timestampPacketAllocator = gfxCoreHelper.createTimestampPacketAllocator(rootDeviceIndices, getMemoryManager(), getPreferredTagPoolSize(), getType(), osContext->getDeviceBitfield()); } return timestampPacketAllocator.get(); } diff --git a/shared/source/command_stream/command_stream_receiver_hw_xehp_and_later.inl b/shared/source/command_stream/command_stream_receiver_hw_xehp_and_later.inl index 2695da7dc9..def8928883 100644 --- a/shared/source/command_stream/command_stream_receiver_hw_xehp_and_later.inl +++ b/shared/source/command_stream/command_stream_receiver_hw_xehp_and_later.inl @@ -139,7 +139,7 @@ inline void CommandStreamReceiverHw::programActivePartitionConfig(Lin template inline void CommandStreamReceiverHw::addPipeControlBeforeStateSip(LinearStream &commandStream, Device &device) { auto &hwInfo = peekHwInfo(); - HwHelper &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto hwInfoConfig = HwInfoConfig::get(hwInfo.platform.eProductFamily); bool debuggingEnabled = device.getDebugger() != nullptr; PipeControlArgs args; @@ -147,7 +147,7 @@ inline void CommandStreamReceiverHw::addPipeControlBeforeStateSip(Lin const auto &[isBasicWARequired, isExtendedWARequired] = hwInfoConfig->isPipeControlPriorToNonPipelinedStateCommandsWARequired(hwInfo, isRcs()); std::ignore = isExtendedWARequired; - if (isBasicWARequired && debuggingEnabled && !hwHelper.isSipWANeeded(hwInfo)) { + if (isBasicWARequired && debuggingEnabled && !gfxCoreHelper.isSipWANeeded(hwInfo)) { NEO::EncodeWA::addPipeControlPriorToNonPipelinedStateCommand(commandStream, args, hwInfo, isRcs()); } } diff --git a/shared/source/command_stream/command_stream_receiver_simulated_hw.h b/shared/source/command_stream/command_stream_receiver_simulated_hw.h index 12b6d01e39..4d86ae2247 100644 --- a/shared/source/command_stream/command_stream_receiver_simulated_hw.h +++ b/shared/source/command_stream/command_stream_receiver_simulated_hw.h @@ -85,7 +85,7 @@ class CommandStreamReceiverSimulatedHw : public CommandStreamReceiverSimulatedCo } PhysicalAddressAllocator *createPhysicalAddressAllocator(const HardwareInfo *hwInfo) { const auto bankSize = AubHelper::getPerTileLocalMemorySize(hwInfo); - const auto devicesCount = HwHelper::getSubDevicesCount(hwInfo); + const auto devicesCount = GfxCoreHelper::getSubDevicesCount(hwInfo); return new PhysicalAddressAllocatorHw(bankSize, devicesCount); } void writeMemoryWithAubManager(GraphicsAllocation &graphicsAllocation) override { diff --git a/shared/source/command_stream/preemption_xehp_and_later.inl b/shared/source/command_stream/preemption_xehp_and_later.inl index 91259e1e63..7022ac158a 100644 --- a/shared/source/command_stream/preemption_xehp_and_later.inl +++ b/shared/source/command_stream/preemption_xehp_and_later.inl @@ -18,10 +18,10 @@ void PreemptionHelper::programStateSip(LinearStream &preambleCmdStrea bool debuggingEnabled = device.getDebugger() != nullptr; if (debuggingEnabled) { - HwHelper &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto sipAllocation = SipKernel::getSipKernel(device).getSipAllocation(); - if (hwHelper.isSipWANeeded(hwInfo)) { + if (gfxCoreHelper.isSipWANeeded(hwInfo)) { auto mmio = reinterpret_cast(preambleCmdStream.getSpace(sizeof(MI_LOAD_REGISTER_IMM))); MI_LOAD_REGISTER_IMM cmd = GfxFamily::cmdInitLoadRegisterImm; @@ -47,8 +47,8 @@ void PreemptionHelper::programStateSipEndWa(LinearStream &cmdStream, using MI_LOAD_REGISTER_IMM = typename GfxFamily::MI_LOAD_REGISTER_IMM; if (debuggerActive) { - HwHelper &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - if (hwHelper.isSipWANeeded(hwInfo)) { + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + if (gfxCoreHelper.isSipWANeeded(hwInfo)) { NEO::PipeControlArgs args; NEO::MemorySynchronizationCommands::addSingleBarrier(cmdStream, args); @@ -75,9 +75,9 @@ size_t PreemptionHelper::getRequiredStateSipCmdSize(Device &device, b auto &hwInfo = device.getHardwareInfo(); if (debuggingEnabled) { - HwHelper &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - if (hwHelper.isSipWANeeded(hwInfo)) { + if (gfxCoreHelper.isSipWANeeded(hwInfo)) { size += MemorySynchronizationCommands::getSizeForSingleBarrier(false); size += 2 * sizeof(typename GfxFamily::MI_LOAD_REGISTER_IMM); } else { diff --git a/shared/source/command_stream/scratch_space_controller.cpp b/shared/source/command_stream/scratch_space_controller.cpp index e01b0cb594..893cf55d74 100644 --- a/shared/source/command_stream/scratch_space_controller.cpp +++ b/shared/source/command_stream/scratch_space_controller.cpp @@ -19,8 +19,8 @@ ScratchSpaceController::ScratchSpaceController(uint32_t rootDeviceIndex, Executi : rootDeviceIndex(rootDeviceIndex), executionEnvironment(environment), csrAllocationStorage(allocationStorage) { auto &rootDeviceEnvironment = *executionEnvironment.rootDeviceEnvironments[rootDeviceIndex]; - auto &coreHelper = rootDeviceEnvironment.getHelper(); - computeUnitsUsedForScratch = coreHelper.getComputeUnitsUsedForScratch(rootDeviceEnvironment); + auto &gfxCoreHelper = rootDeviceEnvironment.getHelper(); + computeUnitsUsedForScratch = gfxCoreHelper.getComputeUnitsUsedForScratch(rootDeviceEnvironment); } ScratchSpaceController::~ScratchSpaceController() { diff --git a/shared/source/command_stream/scratch_space_controller_base.cpp b/shared/source/command_stream/scratch_space_controller_base.cpp index 75d5b49db5..1f4f0d3b62 100644 --- a/shared/source/command_stream/scratch_space_controller_base.cpp +++ b/shared/source/command_stream/scratch_space_controller_base.cpp @@ -76,8 +76,8 @@ uint64_t ScratchSpaceControllerBase::getScratchPatchAddress() { void ScratchSpaceControllerBase::reserveHeap(IndirectHeap::Type heapType, IndirectHeap *&indirectHeap) { if (heapType == IndirectHeap::Type::SURFACE_STATE) { - auto &hwHelper = HwHelper::get(executionEnvironment.rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo()->platform.eRenderCoreFamily); - auto surfaceStateSize = hwHelper.getRenderSurfaceStateSize(); + auto &gfxCoreHelper = GfxCoreHelper::get(executionEnvironment.rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo()->platform.eRenderCoreFamily); + auto surfaceStateSize = gfxCoreHelper.getRenderSurfaceStateSize(); indirectHeap->getSpace(surfaceStateSize); } } diff --git a/shared/source/command_stream/scratch_space_controller_xehp_and_later.cpp b/shared/source/command_stream/scratch_space_controller_xehp_and_later.cpp index 7877e81237..54f98e6dde 100644 --- a/shared/source/command_stream/scratch_space_controller_xehp_and_later.cpp +++ b/shared/source/command_stream/scratch_space_controller_xehp_and_later.cpp @@ -26,8 +26,8 @@ ScratchSpaceControllerXeHPAndLater::ScratchSpaceControllerXeHPAndLater(uint32_t ExecutionEnvironment &environment, InternalAllocationStorage &allocationStorage) : ScratchSpaceController(rootDeviceIndex, environment, allocationStorage) { - auto &coreHelper = environment.rootDeviceEnvironments[rootDeviceIndex]->getHelper(); - singleSurfaceStateSize = coreHelper.getRenderSurfaceStateSize(); + auto &gfxCoreHelper = environment.rootDeviceEnvironments[rootDeviceIndex]->getHelper(); + singleSurfaceStateSize = gfxCoreHelper.getRenderSurfaceStateSize(); if (DebugManager.flags.EnablePrivateScratchSlot1.get() != -1) { privateScratchSpaceSupported = !!DebugManager.flags.EnablePrivateScratchSlot1.get(); } @@ -81,14 +81,14 @@ void ScratchSpaceControllerXeHPAndLater::programSurfaceState() { } void ScratchSpaceControllerXeHPAndLater::programSurfaceStateAtPtr(void *surfaceStateForScratchAllocation) { - auto &coreHelper = executionEnvironment.rootDeviceEnvironments[rootDeviceIndex]->getHelper(); + auto &gfxCoreHelper = executionEnvironment.rootDeviceEnvironments[rootDeviceIndex]->getHelper(); uint64_t scratchAllocationAddress = 0u; if (scratchAllocation) { scratchAllocationAddress = scratchAllocation->getGpuAddress(); } - coreHelper.setRenderSurfaceStateForScratchResource(*executionEnvironment.rootDeviceEnvironments[rootDeviceIndex], - surfaceStateForScratchAllocation, computeUnitsUsedForScratch, scratchAllocationAddress, 0, - perThreadScratchSize, nullptr, false, scratchType, false, true); + gfxCoreHelper.setRenderSurfaceStateForScratchResource(*executionEnvironment.rootDeviceEnvironments[rootDeviceIndex], + surfaceStateForScratchAllocation, computeUnitsUsedForScratch, scratchAllocationAddress, 0, + perThreadScratchSize, nullptr, false, scratchType, false, true); if (privateScratchSpaceSupported) { void *surfaceStateForPrivateScratchAllocation = ptrOffset(surfaceStateForScratchAllocation, singleSurfaceStateSize); @@ -97,10 +97,10 @@ void ScratchSpaceControllerXeHPAndLater::programSurfaceStateAtPtr(void *surfaceS if (privateScratchAllocation) { privateScratchAllocationAddress = privateScratchAllocation->getGpuAddress(); } - coreHelper.setRenderSurfaceStateForScratchResource(*executionEnvironment.rootDeviceEnvironments[rootDeviceIndex], - surfaceStateForPrivateScratchAllocation, computeUnitsUsedForScratch, - privateScratchAllocationAddress, 0, perThreadPrivateScratchSize, nullptr, false, - scratchType, false, true); + gfxCoreHelper.setRenderSurfaceStateForScratchResource(*executionEnvironment.rootDeviceEnvironments[rootDeviceIndex], + surfaceStateForPrivateScratchAllocation, computeUnitsUsedForScratch, + privateScratchAllocationAddress, 0, perThreadPrivateScratchSize, nullptr, false, + scratchType, false, true); } } diff --git a/shared/source/command_stream/stream_properties.cpp b/shared/source/command_stream/stream_properties.cpp index 6cf16edd66..a3e6b16d8b 100644 --- a/shared/source/command_stream/stream_properties.cpp +++ b/shared/source/command_stream/stream_properties.cpp @@ -24,7 +24,7 @@ void StateComputeModeProperties::setProperties(bool requiresCoherency, uint32_t this->propertiesSupportLoaded = true; } - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); clearIsDirty(); if (this->scmPropertiesSupport.coherencyRequired) { @@ -58,7 +58,7 @@ void StateComputeModeProperties::setProperties(bool requiresCoherency, uint32_t (NEO::DebugManager.flags.ForceDefaultThreadArbitrationPolicyIfNotSpecified.get() || (this->threadArbitrationPolicy.value == ThreadArbitrationPolicy::NotPresent)); if (setDefaultThreadArbitrationPolicy) { - threadArbitrationPolicy = hwHelper.getDefaultThreadArbitrationPolicy(); + threadArbitrationPolicy = gfxCoreHelper.getDefaultThreadArbitrationPolicy(); } if (DebugManager.flags.OverrideThreadArbitrationPolicy.get() != -1) { threadArbitrationPolicy = DebugManager.flags.OverrideThreadArbitrationPolicy.get(); diff --git a/shared/source/command_stream/tbx_command_stream_receiver_hw.inl b/shared/source/command_stream/tbx_command_stream_receiver_hw.inl index c61b35457b..90f6b7562f 100644 --- a/shared/source/command_stream/tbx_command_stream_receiver_hw.inl +++ b/shared/source/command_stream/tbx_command_stream_receiver_hw.inl @@ -166,10 +166,10 @@ CommandStreamReceiver *TbxCommandStreamReceiverHw::create(const std:: const DeviceBitfield deviceBitfield) { TbxCommandStreamReceiverHw *csr; auto &hwInfo = *(executionEnvironment.rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo()); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); const auto &hwInfoConfig = *HwInfoConfig::get(hwInfo.platform.eProductFamily); if (withAubDump) { - auto localMemoryEnabled = hwHelper.getEnableLocalMemory(hwInfo); + auto localMemoryEnabled = gfxCoreHelper.getEnableLocalMemory(hwInfo); auto fullName = AUBCommandStreamReceiver::createFullFilePath(hwInfo, baseName, rootDeviceIndex); if (DebugManager.flags.AUBDumpCaptureFileName.get() != "unk") { fullName.assign(DebugManager.flags.AUBDumpCaptureFileName.get()); diff --git a/shared/source/debugger/debugger.cpp b/shared/source/debugger/debugger.cpp index 76e60fb917..3bf070093b 100644 --- a/shared/source/debugger/debugger.cpp +++ b/shared/source/debugger/debugger.cpp @@ -22,9 +22,9 @@ std::unique_ptr Debugger::create(const RootDeviceEnvironment &rootDevi sourceLevelDebugger.reset(SourceLevelDebugger::create()); } if (sourceLevelDebugger) { - auto &coreHelper = rootDeviceEnvironment.getHelper(); + auto &gfxCoreHelper = rootDeviceEnvironment.getHelper(); - bool localMemorySipAvailable = (SipKernelType::DbgCsrLocal == coreHelper.getSipKernelType(true)); + bool localMemorySipAvailable = (SipKernelType::DbgCsrLocal == gfxCoreHelper.getSipKernelType(true)); sourceLevelDebugger->initialize(localMemorySipAvailable); if (sourceLevelDebugger->isDebuggerActive()) { diff --git a/shared/source/debugger/debugger_l0.cpp b/shared/source/debugger/debugger_l0.cpp index d27d7af227..c11d7f6626 100644 --- a/shared/source/debugger/debugger_l0.cpp +++ b/shared/source/debugger/debugger_l0.cpp @@ -76,7 +76,7 @@ void DebuggerL0::initialize() { { auto &hwInfo = device->getHardwareInfo(); - auto &coreHelper = device->getRootDeviceEnvironment().getHelper(); + auto &gfxCoreHelper = device->getRootDeviceEnvironment().getHelper(); NEO::AllocationProperties properties{device->getRootDeviceIndex(), true, MemoryConstants::pageSize64k, NEO::AllocationType::DEBUG_MODULE_AREA, false, @@ -100,7 +100,7 @@ void DebuggerL0::initialize() { NEO::MemoryTransferHelper::transferMemoryToAllocation(hwInfoConfig.isBlitCopyRequiredForLocalMemory(hwInfo, *moduleDebugArea), *device, moduleDebugArea, 0, &debugArea, sizeof(DebugAreaHeader)); - if (coreHelper.disableL3CacheForDebug(hwInfo)) { + if (gfxCoreHelper.disableL3CacheForDebug(hwInfo)) { device->getGmmHelper()->forceAllResourcesUncached(); } diff --git a/shared/source/device/device.cpp b/shared/source/device/device.cpp index e53ec878cc..c15467f270 100644 --- a/shared/source/device/device.cpp +++ b/shared/source/device/device.cpp @@ -77,7 +77,7 @@ SubDevice *Device::createEngineInstancedSubDevice(uint32_t subDeviceIndex, aub_s bool Device::genericSubDevicesAllowed() { auto deviceMask = executionEnvironment->rootDeviceEnvironments[getRootDeviceIndex()]->deviceAffinityMask.getGenericSubDevicesMask(); - uint32_t subDeviceCount = HwHelper::getSubDevicesCount(&getHardwareInfo()); + uint32_t subDeviceCount = GfxCoreHelper::getSubDevicesCount(&getHardwareInfo()); deviceBitfield = maxNBitValue(subDeviceCount); deviceBitfield &= deviceMask; numSubDevices = static_cast(deviceBitfield.count()); @@ -92,7 +92,7 @@ bool Device::engineInstancedSubDevicesAllowed() { bool notAllowed = !DebugManager.flags.EngineInstancedSubDevices.get(); notAllowed |= engineInstanced; notAllowed |= (getHardwareInfo().gtSystemInfo.CCSInfo.NumberOfCCSEnabled < 2); - notAllowed |= ((HwHelper::getSubDevicesCount(&getHardwareInfo()) < 2) && (!DebugManager.flags.AllowSingleTileEngineInstancedSubDevices.get())); + notAllowed |= ((GfxCoreHelper::getSubDevicesCount(&getHardwareInfo()) < 2) && (!DebugManager.flags.AllowSingleTileEngineInstancedSubDevices.get())); if (notAllowed) { return false; @@ -140,7 +140,7 @@ bool Device::createEngineInstancedSubDevices() { bool Device::createGenericSubDevices() { UNRECOVERABLE_IF(!subdevices.empty()); - uint32_t subDeviceCount = HwHelper::getSubDevicesCount(&getHardwareInfo()); + uint32_t subDeviceCount = GfxCoreHelper::getSubDevicesCount(&getHardwareInfo()); subdevices.resize(subDeviceCount, nullptr); @@ -214,8 +214,8 @@ bool Device::createDeviceImpl() { this->executionEnvironment->rootDeviceEnvironments[getRootDeviceIndex()]->initDebugger(); } - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - if (getDebugger() && hwHelper.disableL3CacheForDebug(hwInfo)) { + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + if (getDebugger() && gfxCoreHelper.disableL3CacheForDebug(hwInfo)) { getGmmHelper()->forceAllResourcesUncached(); } @@ -269,7 +269,7 @@ bool Device::createDeviceImpl() { uuid.isValid = false; if (DebugManager.flags.EnableChipsetUniqueUUID.get() != 0) { - if (HwHelper::get(hwInfo.platform.eRenderCoreFamily).isChipsetUniqueUUIDSupported()) { + if (GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isChipsetUniqueUUIDSupported()) { uuid.isValid = HwInfoConfig::get(hardwareInfo->platform.eProductFamily)->getUuid(this, uuid.id); } } @@ -289,7 +289,7 @@ bool Device::createEngines() { } auto &hwInfo = getHardwareInfo(); - auto gpgpuEngines = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); + auto gpgpuEngines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); uint32_t deviceCsrIndex = 0; for (auto &engine : gpgpuEngines) { @@ -302,10 +302,10 @@ bool Device::createEngines() { void Device::addEngineToEngineGroup(EngineControl &engine) { const HardwareInfo &hardwareInfo = this->getHardwareInfo(); - const HwHelper &hwHelper = NEO::HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - const EngineGroupType engineGroupType = hwHelper.getEngineGroupType(engine.getEngineType(), engine.getEngineUsage(), hardwareInfo); + const GfxCoreHelper &gfxCoreHelper = NEO::GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + const EngineGroupType engineGroupType = gfxCoreHelper.getEngineGroupType(engine.getEngineType(), engine.getEngineUsage(), hardwareInfo); - if (!hwHelper.isSubDeviceEngineSupported(hardwareInfo, getDeviceBitfield(), engine.getEngineType())) { + if (!gfxCoreHelper.isSubDeviceEngineSupported(hardwareInfo, getDeviceBitfield(), engine.getEngineType())) { return; } @@ -591,8 +591,8 @@ EngineControl &Device::getNextEngineForCommandQueue() { const auto &defaultEngine = this->getDefaultEngine(); const auto &hardwareInfo = this->getHardwareInfo(); - const auto &hwHelper = NEO::HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - const auto engineGroupType = hwHelper.getEngineGroupType(defaultEngine.getEngineType(), defaultEngine.getEngineUsage(), hardwareInfo); + const auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + const auto engineGroupType = gfxCoreHelper.getEngineGroupType(defaultEngine.getEngineType(), defaultEngine.getEngineUsage(), hardwareInfo); const auto defaultEngineGroupIndex = this->getEngineGroupIndexFromEngineGroupType(engineGroupType); auto &engineGroup = this->getRegularEngineGroups()[defaultEngineGroupIndex]; @@ -757,7 +757,7 @@ void Device::allocateRTDispatchGlobals(uint32_t maxBvhLevels) { bool allocFailed = false; - const auto deviceCount = HwHelper::getSubDevicesCount(executionEnvironment->rootDeviceEnvironments[getRootDeviceIndex()]->getHardwareInfo()); + const auto deviceCount = GfxCoreHelper::getSubDevicesCount(executionEnvironment->rootDeviceEnvironments[getRootDeviceIndex()]->getHardwareInfo()); auto dispatchGlobalsSize = deviceCount * dispatchGlobalsStride; auto rtStackSize = RayTracingHelper::getRTStackSizePerTile(*this, deviceCount, maxBvhLevels, extraBytesLocal, extraBytesGlobal); diff --git a/shared/source/device/device_caps.cpp b/shared/source/device/device_caps.cpp index 90c2644242..924e6ed8d7 100644 --- a/shared/source/device/device_caps.cpp +++ b/shared/source/device/device_caps.cpp @@ -39,7 +39,7 @@ void Device::initializeCaps() { auto addressing32bitAllowed = is64bit; auto &productHelper = this->getRootDeviceEnvironment().getHelper(); - auto &coreHelper = this->getRootDeviceEnvironment().getHelper(); + auto &gfxCoreHelper = this->getRootDeviceEnvironment().getHelper(); bool ocl21FeaturesEnabled = hwInfo.capabilityTable.supportsOcl21Features; if (DebugManager.flags.ForceOCLVersion.get() != 0) { @@ -81,9 +81,9 @@ void Device::initializeCaps() { deviceInfo.globalMemSize = alignDown(deviceInfo.globalMemSize, MemoryConstants::pageSize); deviceInfo.maxMemAllocSize = std::min(deviceInfo.globalMemSize, deviceInfo.maxMemAllocSize); // if globalMemSize was reduced for 32b - uint32_t subDeviceCount = coreHelper.getSubDevicesCount(&getHardwareInfo()); + uint32_t subDeviceCount = gfxCoreHelper.getSubDevicesCount(&getHardwareInfo()); - bool platformImplicitScaling = coreHelper.platformSupportsImplicitScaling(hwInfo); + bool platformImplicitScaling = gfxCoreHelper.platformSupportsImplicitScaling(hwInfo); if (((NEO::ImplicitScalingHelper::isImplicitScalingEnabled( getDeviceBitfield(), platformImplicitScaling))) && @@ -93,7 +93,7 @@ void Device::initializeCaps() { if (!areSharedSystemAllocationsAllowed()) { deviceInfo.maxMemAllocSize = ApiSpecificConfig::getReducedMaxAllocSize(deviceInfo.maxMemAllocSize); - deviceInfo.maxMemAllocSize = std::min(deviceInfo.maxMemAllocSize, coreHelper.getMaxMemAllocSize()); + deviceInfo.maxMemAllocSize = std::min(deviceInfo.maxMemAllocSize, gfxCoreHelper.getMaxMemAllocSize()); } // Some specific driver model configurations may impose additional limitations @@ -120,7 +120,7 @@ void Device::initializeCaps() { deviceInfo.numThreadsPerEU = 0; auto simdSizeUsed = DebugManager.flags.UseMaxSimdSizeToDeduceMaxWorkgroupSize.get() ? CommonConstants::maximalSimdSize - : coreHelper.getMinimalSIMDSize(); + : gfxCoreHelper.getMinimalSIMDSize(); deviceInfo.maxNumEUsPerSubSlice = (systemInfo.EuCountPerPoolMin == 0 || hwInfo.featureTable.flags.ftrPooledEuEnabled == 0) ? (systemInfo.EUCount / systemInfo.SubSliceCount) @@ -134,7 +134,7 @@ void Device::initializeCaps() { deviceInfo.maxNumEUsPerDualSubSlice = deviceInfo.maxNumEUsPerSubSlice; } deviceInfo.numThreadsPerEU = systemInfo.ThreadCount / systemInfo.EUCount; - deviceInfo.threadsPerEUConfigs = coreHelper.getThreadsPerEUConfigs(); + deviceInfo.threadsPerEUConfigs = gfxCoreHelper.getThreadsPerEUConfigs(); auto maxWS = productHelper.getMaxThreadsForWorkgroupInDSSOrSS(hwInfo, static_cast(deviceInfo.maxNumEUsPerSubSlice), static_cast(deviceInfo.maxNumEUsPerDualSubSlice)) * simdSizeUsed; maxWS = Math::prevPowerOfTwo(maxWS); @@ -147,10 +147,10 @@ void Device::initializeCaps() { deviceInfo.maxWorkItemSizes[0] = deviceInfo.maxWorkGroupSize; deviceInfo.maxWorkItemSizes[1] = deviceInfo.maxWorkGroupSize; deviceInfo.maxWorkItemSizes[2] = deviceInfo.maxWorkGroupSize; - deviceInfo.maxSamplers = coreHelper.getMaxNumSamplers(); + deviceInfo.maxSamplers = gfxCoreHelper.getMaxNumSamplers(); - deviceInfo.computeUnitsUsedForScratch = coreHelper.getComputeUnitsUsedForScratch(this->getRootDeviceEnvironment()); - deviceInfo.maxFrontEndThreads = coreHelper.getMaxThreadsForVfe(hwInfo); + deviceInfo.computeUnitsUsedForScratch = gfxCoreHelper.getComputeUnitsUsedForScratch(this->getRootDeviceEnvironment()); + deviceInfo.maxFrontEndThreads = gfxCoreHelper.getMaxThreadsForVfe(hwInfo); deviceInfo.localMemSize = hwInfo.capabilityTable.slmSize * KB; if (DebugManager.flags.OverrideSlmSize.get() != -1) { @@ -166,7 +166,7 @@ void Device::initializeCaps() { deviceInfo.printfBufferSize = 4 * MB; deviceInfo.maxClockFrequency = hwInfo.capabilityTable.maxRenderFrequency; - deviceInfo.maxSubGroups = coreHelper.getDeviceSubGroupSizes(); + deviceInfo.maxSubGroups = gfxCoreHelper.getDeviceSubGroupSizes(); deviceInfo.vmeAvcSupportsPreemption = hwInfo.capabilityTable.ftrSupportsVmeAvcPreemption; diff --git a/shared/source/device_binary_format/device_binary_format_patchtokens.cpp b/shared/source/device_binary_format/device_binary_format_patchtokens.cpp index d70e405f97..79eba5e88a 100644 --- a/shared/source/device_binary_format/device_binary_format_patchtokens.cpp +++ b/shared/source/device_binary_format/device_binary_format_patchtokens.cpp @@ -63,10 +63,10 @@ DecodeError decodeSingleDeviceBinary(Progr // set barrierCount to number of barriers decoded from hasBarriers token UNRECOVERABLE_IF(src.targetDevice.coreFamily == IGFX_UNKNOWN_CORE); - auto &hwHelper = NEO::HwHelper::get(src.targetDevice.coreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(src.targetDevice.coreFamily); for (auto &ki : dst.kernelInfos) { auto &kd = ki->kernelDescriptor; - kd.kernelAttributes.barrierCount = hwHelper.getBarriersCountFromHasBarriers(kd.kernelAttributes.barrierCount); + kd.kernelAttributes.barrierCount = gfxCoreHelper.getBarriersCountFromHasBarriers(kd.kernelAttributes.barrierCount); } return DecodeError::Success; diff --git a/shared/source/device_binary_format/device_binary_formats.cpp b/shared/source/device_binary_format/device_binary_formats.cpp index a38c139090..69c3ed3249 100644 --- a/shared/source/device_binary_format/device_binary_formats.cpp +++ b/shared/source/device_binary_format/device_binary_formats.cpp @@ -30,7 +30,7 @@ TargetDevice targetDeviceFromHwInfo(const HardwareInfo &hwInfo) { targetDevice.stepping = hwInfo.platform.usRevId; targetDevice.maxPointerSizeInBytes = sizeof(uintptr_t); targetDevice.grfSize = hwInfo.capabilityTable.grfSize; - targetDevice.minScratchSpaceSize = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getMinimalScratchSpaceSize(); + targetDevice.minScratchSpaceSize = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getMinimalScratchSpaceSize(); return targetDevice; } } // namespace NEO diff --git a/shared/source/direct_submission/direct_submission_hw.inl b/shared/source/direct_submission/direct_submission_hw.inl index 4e8bae449d..42875ce539 100644 --- a/shared/source/direct_submission/direct_submission_hw.inl +++ b/shared/source/direct_submission/direct_submission_hw.inl @@ -78,7 +78,7 @@ DirectSubmissionHw::DirectSubmissionHw(const DirectSubmis dcFlushRequired = MemorySynchronizationCommands::getDcFlushEnable(true, *hwInfo); - relaxedOrderingEnabled = HwHelperHw::get().isRelaxedOrderingSupported(); + relaxedOrderingEnabled = GfxCoreHelperHw::get().isRelaxedOrderingSupported(); if (DebugManager.flags.DirectSubmissionRelaxedOrdering.get() != -1) { relaxedOrderingEnabled = (DebugManager.flags.DirectSubmissionRelaxedOrdering.get() == 1); diff --git a/shared/source/dll/linux/drm_neo_create.cpp b/shared/source/dll/linux/drm_neo_create.cpp index 0280e85504..d6c8b4dc90 100644 --- a/shared/source/dll/linux/drm_neo_create.cpp +++ b/shared/source/dll/linux/drm_neo_create.cpp @@ -114,7 +114,7 @@ Drm *Drm::create(std::unique_ptr &&hwDeviceId, RootDeviceEnvironm drm->isSetPairAvailable(); if (!drm->isPerContextVMRequired()) { - if (!drm->createVirtualMemoryAddressSpace(HwHelper::getSubDevicesCount(rootDeviceEnvironment.getHardwareInfo()))) { + if (!drm->createVirtualMemoryAddressSpace(GfxCoreHelper::getSubDevicesCount(rootDeviceEnvironment.getHardwareInfo()))) { printDebugString(DebugManager.flags.PrintDebugMessages.get(), stderr, "%s", "INFO: Device doesn't support GEM Virtual Memory\n"); } } diff --git a/shared/source/execution_environment/execution_environment.cpp b/shared/source/execution_environment/execution_environment.cpp index 028fd7edab..d6ddae1bd4 100644 --- a/shared/source/execution_environment/execution_environment.cpp +++ b/shared/source/execution_environment/execution_environment.cpp @@ -82,9 +82,9 @@ void ExecutionEnvironment::calculateMaxOsContextCount() { MemoryManager::maxOsContextCount = 0u; for (const auto &rootDeviceEnvironment : this->rootDeviceEnvironments) { auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - auto &coreHelper = rootDeviceEnvironment->getHelper(); - auto osContextCount = static_cast(coreHelper.getGpgpuEngineInstances(*hwInfo).size()); - auto subDevicesCount = HwHelper::getSubDevicesCount(hwInfo); + auto &gfxCoreHelper = rootDeviceEnvironment->getHelper(); + auto osContextCount = static_cast(gfxCoreHelper.getGpgpuEngineInstances(*hwInfo).size()); + auto subDevicesCount = GfxCoreHelper::getSubDevicesCount(hwInfo); auto ccsCount = hwInfo->gtSystemInfo.CCSInfo.NumberOfCCSEnabled; bool hasRootCsr = subDevicesCount > 1; @@ -157,7 +157,7 @@ void ExecutionEnvironment::parseAffinityMask() { if (rootDeviceIndex < numRootDevices) { auto hwInfo = rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo(); - auto subDevicesCount = HwHelper::getSubDevicesCount(hwInfo); + auto subDevicesCount = GfxCoreHelper::getSubDevicesCount(hwInfo); if (subEntries.size() > 1) { uint32_t subDeviceIndex = StringHelpers::toUint32t(subEntries[1]); diff --git a/shared/source/execution_environment/root_device_environment.cpp b/shared/source/execution_environment/root_device_environment.cpp index 31a1f75d49..adc4450347 100644 --- a/shared/source/execution_environment/root_device_environment.cpp +++ b/shared/source/execution_environment/root_device_environment.cpp @@ -173,13 +173,13 @@ HelperType &RootDeviceEnvironment::getHelper() const { auto &hwInfoConfig = *HwInfoConfig::get(this->getHardwareInfo()->platform.eProductFamily); return hwInfoConfig; } else { - static_assert(std::is_same_v, "Only ProductHelper and CoreHelper are supported"); - auto &hwHelper = HwHelper::get(this->getHardwareInfo()->platform.eRenderCoreFamily); - return hwHelper; + static_assert(std::is_same_v, "Only ProductHelper and GfxCoreHelper are supported"); + auto &gfxCoreHelper = GfxCoreHelper::get(this->getHardwareInfo()->platform.eRenderCoreFamily); + return gfxCoreHelper; } } template ProductHelper &RootDeviceEnvironment::getHelper() const; -template CoreHelper &RootDeviceEnvironment::getHelper() const; +template GfxCoreHelper &RootDeviceEnvironment::getHelper() const; } // namespace NEO diff --git a/shared/source/execution_environment/root_device_environment.h b/shared/source/execution_environment/root_device_environment.h index ea372834e7..ec83ab990f 100644 --- a/shared/source/execution_environment/root_device_environment.h +++ b/shared/source/execution_environment/root_device_environment.h @@ -32,10 +32,10 @@ class OSTime; class SipKernel; class SWTagsManager; class HwInfoConfig; -class HwHelper; +class GfxCoreHelper; struct HardwareInfo; -using CoreHelper = HwHelper; +using GfxCoreHelper = GfxCoreHelper; using ProductHelper = HwInfoConfig; struct RootDeviceEnvironment { diff --git a/shared/source/gen11/enable_family_full_core_gen11.cpp b/shared/source/gen11/enable_family_full_core_gen11.cpp index 9ff703044e..54d4780a39 100644 --- a/shared/source/gen11/enable_family_full_core_gen11.cpp +++ b/shared/source/gen11/enable_family_full_core_gen11.cpp @@ -15,14 +15,14 @@ namespace NEO { -extern HwHelper *hwHelperFactory[IGFX_MAX_CORE]; +extern GfxCoreHelper *gfxCoreHelperFactory[IGFX_MAX_CORE]; using Family = Gen11Family; static auto gfxFamily = IGFX_GEN11_CORE; struct EnableCoreGen11 { EnableCoreGen11() { - hwHelperFactory[gfxFamily] = &HwHelperHw::get(); + gfxCoreHelperFactory[gfxFamily] = &GfxCoreHelperHw::get(); populateFactoryTable>(); populateFactoryTable>(); populateFactoryTable>(); diff --git a/shared/source/gen11/hw_helper_gen11.cpp b/shared/source/gen11/hw_helper_gen11.cpp index 98720ff773..44e2fd00d8 100644 --- a/shared/source/gen11/hw_helper_gen11.cpp +++ b/shared/source/gen11/hw_helper_gen11.cpp @@ -17,27 +17,27 @@ namespace NEO { typedef Gen11Family Family; template <> -uint32_t HwHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const { +uint32_t GfxCoreHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const { auto hwInfo = rootDeviceEnvironment.getHardwareInfo(); return hwInfo->gtSystemInfo.MaxSubSlicesSupported * hwInfo->gtSystemInfo.MaxEuPerSubSlice * 8; } template <> -std::string HwHelperHw::getExtensions(const HardwareInfo &hwInfo) const { +std::string GfxCoreHelperHw::getExtensions(const HardwareInfo &hwInfo) const { return "cl_intel_subgroup_local_block_io "; } template <> -int32_t HwHelperHw::getDefaultThreadArbitrationPolicy() const { +int32_t GfxCoreHelperHw::getDefaultThreadArbitrationPolicy() const { return ThreadArbitrationPolicy::RoundRobinAfterDependency; } template <> -bool HwHelperHw::packedFormatsSupported() const { +bool GfxCoreHelperHw::packedFormatsSupported() const { return true; } -template class HwHelperHw; +template class GfxCoreHelperHw; template class FlatBatchBufferHelperHw; template struct MemorySynchronizationCommands; template struct LriHelper; diff --git a/shared/source/gen12lp/dg1/os_agnostic_hw_info_config_dg1.inl b/shared/source/gen12lp/dg1/os_agnostic_hw_info_config_dg1.inl index 50761ad452..02652d3675 100644 --- a/shared/source/gen12lp/dg1/os_agnostic_hw_info_config_dg1.inl +++ b/shared/source/gen12lp/dg1/os_agnostic_hw_info_config_dg1.inl @@ -37,17 +37,17 @@ uint32_t HwInfoConfigHw::getSteppingFromHwRevId(const HardwareInfo & template <> bool HwInfoConfigHw::pipeControlWARequired(const HardwareInfo &hwInfo) const { - return HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); + return GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> bool HwInfoConfigHw::imagePitchAlignmentWARequired(const HardwareInfo &hwInfo) const { - return HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); + return GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> bool HwInfoConfigHw::isForceEmuInt32DivRemSPWARequired(const HardwareInfo &hwInfo) const { - return HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); + return GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> diff --git a/shared/source/gen12lp/enable_family_full_core_gen12lp.cpp b/shared/source/gen12lp/enable_family_full_core_gen12lp.cpp index 878cf8c01d..81cba22003 100644 --- a/shared/source/gen12lp/enable_family_full_core_gen12lp.cpp +++ b/shared/source/gen12lp/enable_family_full_core_gen12lp.cpp @@ -15,14 +15,14 @@ namespace NEO { -extern HwHelper *hwHelperFactory[IGFX_MAX_CORE]; +extern GfxCoreHelper *gfxCoreHelperFactory[IGFX_MAX_CORE]; using Family = Gen12LpFamily; static auto gfxFamily = IGFX_GEN12LP_CORE; struct EnableCoreGen12LP { EnableCoreGen12LP() { - hwHelperFactory[gfxFamily] = &HwHelperHw::get(); + gfxCoreHelperFactory[gfxFamily] = &GfxCoreHelperHw::get(); populateFactoryTable>(); populateFactoryTable>(); populateFactoryTable>(); diff --git a/shared/source/gen12lp/hw_helper_gen12lp.cpp b/shared/source/gen12lp/hw_helper_gen12lp.cpp index 7b065f41c6..ae78756fff 100644 --- a/shared/source/gen12lp/hw_helper_gen12lp.cpp +++ b/shared/source/gen12lp/hw_helper_gen12lp.cpp @@ -20,7 +20,7 @@ using Family = NEO::Gen12LpFamily; namespace NEO { template <> -inline bool HwHelperHw::isFusedEuDispatchEnabled(const HardwareInfo &hwInfo, bool disableEUFusionForKernel) const { +inline bool GfxCoreHelperHw::isFusedEuDispatchEnabled(const HardwareInfo &hwInfo, bool disableEUFusionForKernel) const { auto fusedEuDispatchEnabled = !hwInfo.workaroundTable.flags.waDisableFusedThreadScheduling; fusedEuDispatchEnabled &= hwInfo.capabilityTable.fusedEuEnabled; @@ -34,27 +34,27 @@ inline bool HwHelperHw::isFusedEuDispatchEnabled(const HardwareInfo &hwI } template <> -size_t HwHelperHw::getMax3dImageWidthOrHeight() const { +size_t GfxCoreHelperHw::getMax3dImageWidthOrHeight() const { return 2048; } template <> -bool HwHelperHw::isOffsetToSkipSetFFIDGPWARequired(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isOffsetToSkipSetFFIDGPWARequired(const HardwareInfo &hwInfo) const { return isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> -bool HwHelperHw::isWaDisableRccRhwoOptimizationRequired() const { +bool GfxCoreHelperHw::isWaDisableRccRhwoOptimizationRequired() const { return true; } template <> -bool HwHelperHw::isAdditionalFeatureFlagRequired(const FeatureTable *featureTable) const { +bool GfxCoreHelperHw::isAdditionalFeatureFlagRequired(const FeatureTable *featureTable) const { return featureTable->flags.ftrGpGpuMidThreadLevelPreempt; } template <> -uint32_t HwHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const { +uint32_t GfxCoreHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const { /* For ICL+ maxThreadCount equals (EUCount * 8). ThreadCount/EUCount=7 is no longer valid, so we have to force 8 in below formula. This is required to allocate enough scratch space. */ @@ -63,12 +63,12 @@ uint32_t HwHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvir } template <> -bool HwHelperHw::isLocalMemoryEnabled(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isLocalMemoryEnabled(const HardwareInfo &hwInfo) const { return hwInfo.featureTable.flags.ftrLocalMemory; } template <> -bool HwHelperHw::isBufferSizeSuitableForCompression(const size_t size, const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isBufferSizeSuitableForCompression(const size_t size, const HardwareInfo &hwInfo) const { if (DebugManager.flags.OverrideBufferSuitableForRenderCompression.get() != -1) { return !!DebugManager.flags.OverrideBufferSuitableForRenderCompression.get(); } @@ -76,12 +76,12 @@ bool HwHelperHw::isBufferSizeSuitableForCompression(const size_t size, c } template <> -bool HwHelperHw::checkResourceCompatibility(GraphicsAllocation &graphicsAllocation) { +bool GfxCoreHelperHw::checkResourceCompatibility(GraphicsAllocation &graphicsAllocation) { return !graphicsAllocation.isCompressionEnabled(); } template <> -uint32_t HwHelperHw::getPitchAlignmentForImage(const RootDeviceEnvironment &rootDeviceEnvironment) const { +uint32_t GfxCoreHelperHw::getPitchAlignmentForImage(const RootDeviceEnvironment &rootDeviceEnvironment) const { auto &productHelper = rootDeviceEnvironment.getHelper(); auto &hwInfo = *rootDeviceEnvironment.getHardwareInfo(); if (productHelper.imagePitchAlignmentWARequired(hwInfo)) { @@ -91,12 +91,12 @@ uint32_t HwHelperHw::getPitchAlignmentForImage(const RootDeviceEnvironme } template <> -uint32_t HwHelperHw::getMetricsLibraryGenId() const { +uint32_t GfxCoreHelperHw::getMetricsLibraryGenId() const { return static_cast(MetricsLibraryApi::ClientGen::Gen12); } template <> -const EngineInstancesContainer HwHelperHw::getGpgpuEngineInstances(const HardwareInfo &hwInfo) const { +const EngineInstancesContainer GfxCoreHelperHw::getGpgpuEngineInstances(const HardwareInfo &hwInfo) const { auto defaultEngine = getChosenEngineType(hwInfo); EngineInstancesContainer engines; @@ -119,7 +119,7 @@ const EngineInstancesContainer HwHelperHw::getGpgpuEngineInstances(const }; template <> -EngineGroupType HwHelperHw::getEngineGroupType(aub_stream::EngineType engineType, EngineUsage engineUsage, const HardwareInfo &hwInfo) const { +EngineGroupType GfxCoreHelperHw::getEngineGroupType(aub_stream::EngineType engineType, EngineUsage engineUsage, const HardwareInfo &hwInfo) const { switch (engineType) { case aub_stream::ENGINE_RCS: return EngineGroupType::RenderCompute; @@ -133,7 +133,7 @@ EngineGroupType HwHelperHw::getEngineGroupType(aub_stream::EngineType en } template <> -std::string HwHelperHw::getExtensions(const HardwareInfo &hwInfo) const { +std::string GfxCoreHelperHw::getExtensions(const HardwareInfo &hwInfo) const { std::string extensions; extensions += "cl_intel_subgroup_local_block_io "; @@ -161,12 +161,12 @@ void MemorySynchronizationCommands::setCacheFlushExtraProperties(PipeCon } template <> -bool HwHelperHw::useOnlyGlobalTimestamps() const { +bool GfxCoreHelperHw::useOnlyGlobalTimestamps() const { return true; } template <> -uint32_t HwHelperHw::getMocsIndex(const GmmHelper &gmmHelper, bool l3enabled, bool l1enabled) const { +uint32_t GfxCoreHelperHw::getMocsIndex(const GmmHelper &gmmHelper, bool l3enabled, bool l1enabled) const { if (l3enabled) { if (DebugManager.flags.ForceL1Caching.get() != 1) { l1enabled = false; @@ -193,7 +193,7 @@ bool MemorySynchronizationCommands::isBarrierlPriorToPipelineSelectWaReq } template <> -void HwHelperHw::setExtraAllocationData(AllocationData &allocationData, const AllocationProperties &properties, const HardwareInfo &hwInfo) const { +void GfxCoreHelperHw::setExtraAllocationData(AllocationData &allocationData, const AllocationProperties &properties, const HardwareInfo &hwInfo) const { const auto &hwInfoConfig = *HwInfoConfig::get(hwInfo.platform.eProductFamily); if (hwInfoConfig.getLocalMemoryAccessMode(hwInfo) == LocalMemoryAccessMode::CpuAccessDisallowed) { if (GraphicsAllocation::isCpuAccessRequired(properties.allocationType)) { @@ -208,11 +208,11 @@ void HwHelperHw::setExtraAllocationData(AllocationData &allocationData, } template <> -bool HwHelperHw::forceNonGpuCoherencyWA(bool requiresCoherency) const { +bool GfxCoreHelperHw::forceNonGpuCoherencyWA(bool requiresCoherency) const { return false; } -template class HwHelperHw; +template class GfxCoreHelperHw; template class FlatBatchBufferHelperHw; template struct MemorySynchronizationCommands; template struct LriHelper; diff --git a/shared/source/gen12lp/hw_info_config_adls.inl b/shared/source/gen12lp/hw_info_config_adls.inl index b9d653c26f..eca346bc06 100644 --- a/shared/source/gen12lp/hw_info_config_adls.inl +++ b/shared/source/gen12lp/hw_info_config_adls.inl @@ -1,5 +1,5 @@ /* - * Copyright (C) 2020-2021 Intel Corporation + * Copyright (C) 2020-2022 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -17,8 +17,8 @@ int HwInfoConfigHw::configureHardwareCustom(HardwareInfo *hwIn GT_SYSTEM_INFO *gtSystemInfo = &hwInfo->gtSystemInfo; gtSystemInfo->SliceCount = 1; - HwHelper &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - hwInfo->featureTable.flags.ftrGpGpuMidThreadLevelPreempt = (hwInfo->platform.usRevId >= hwHelper.getHwRevIdFromStepping(REVISION_C, *hwInfo)); + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + hwInfo->featureTable.flags.ftrGpGpuMidThreadLevelPreempt = (hwInfo->platform.usRevId >= gfxCoreHelper.getHwRevIdFromStepping(REVISION_C, *hwInfo)); return 0; } diff --git a/shared/source/gen12lp/preamble_gen12lp.cpp b/shared/source/gen12lp/preamble_gen12lp.cpp index 1e3b73e631..49cc7ccc23 100644 --- a/shared/source/gen12lp/preamble_gen12lp.cpp +++ b/shared/source/gen12lp/preamble_gen12lp.cpp @@ -89,8 +89,8 @@ template <> void PreambleHelper::appendProgramVFEState(const HardwareInfo &hwInfo, const StreamProperties &streamProperties, void *cmd) { VFE_STATE_TYPE *mediaVfeState = static_cast(cmd); bool disableEUFusion = streamProperties.frontEndState.disableEUFusion.value == 1; - auto &hwHelper = HwHelperHw::get(); - if (!hwHelper.isFusedEuDispatchEnabled(hwInfo, disableEUFusion)) { + auto &gfxCoreHelper = GfxCoreHelperHw::get(); + if (!gfxCoreHelper.isFusedEuDispatchEnabled(hwInfo, disableEUFusion)) { mediaVfeState->setDisableSlice0Subslice2(true); } if (DebugManager.flags.MediaVfeStateMaxSubSlices.get() != -1) { diff --git a/shared/source/gen12lp/rkl/os_agnostic_hw_info_config_rkl.inl b/shared/source/gen12lp/rkl/os_agnostic_hw_info_config_rkl.inl index 8b72e3adf7..55a87446aa 100644 --- a/shared/source/gen12lp/rkl/os_agnostic_hw_info_config_rkl.inl +++ b/shared/source/gen12lp/rkl/os_agnostic_hw_info_config_rkl.inl @@ -39,7 +39,7 @@ uint32_t HwInfoConfigHw::getSteppingFromHwRevId(const HardwareInfo & template <> bool HwInfoConfigHw::isForceEmuInt32DivRemSPWARequired(const HardwareInfo &hwInfo) const { - return HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_C, hwInfo); + return GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_C, hwInfo); } template <> diff --git a/shared/source/gen12lp/tgllp/os_agnostic_hw_info_config_tgllp.inl b/shared/source/gen12lp/tgllp/os_agnostic_hw_info_config_tgllp.inl index 4af6dcfd1c..f217eb1793 100644 --- a/shared/source/gen12lp/tgllp/os_agnostic_hw_info_config_tgllp.inl +++ b/shared/source/gen12lp/tgllp/os_agnostic_hw_info_config_tgllp.inl @@ -41,17 +41,17 @@ uint32_t HwInfoConfigHw::getSteppingFromHwRevId(const HardwareInfo & template <> bool HwInfoConfigHw::pipeControlWARequired(const HardwareInfo &hwInfo) const { - return HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); + return GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> bool HwInfoConfigHw::imagePitchAlignmentWARequired(const HardwareInfo &hwInfo) const { - return HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); + return GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> bool HwInfoConfigHw::isForceEmuInt32DivRemSPWARequired(const HardwareInfo &hwInfo) const { - return HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); + return GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> diff --git a/shared/source/gen12lp/windows/hw_info_config_tgllp.cpp b/shared/source/gen12lp/windows/hw_info_config_tgllp.cpp index 086526f458..743b846cfe 100644 --- a/shared/source/gen12lp/windows/hw_info_config_tgllp.cpp +++ b/shared/source/gen12lp/windows/hw_info_config_tgllp.cpp @@ -23,8 +23,8 @@ namespace NEO { template <> void HwInfoConfigHw::setCapabilityCoherencyFlag(const HardwareInfo &hwInfo, bool &coherencyFlag) { coherencyFlag = true; - HwHelper &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - if (hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo)) { + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + if (gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo)) { // stepping A devices - turn off coherency coherencyFlag = false; } diff --git a/shared/source/gen8/enable_family_full_core_gen8.cpp b/shared/source/gen8/enable_family_full_core_gen8.cpp index f891cf55a1..cff9076361 100644 --- a/shared/source/gen8/enable_family_full_core_gen8.cpp +++ b/shared/source/gen8/enable_family_full_core_gen8.cpp @@ -17,14 +17,14 @@ namespace NEO { -extern HwHelper *hwHelperFactory[IGFX_MAX_CORE]; +extern GfxCoreHelper *gfxCoreHelperFactory[IGFX_MAX_CORE]; using Family = Gen8Family; static const auto gfxFamily = IGFX_GEN8_CORE; struct EnableCoreGen8 { EnableCoreGen8() { - hwHelperFactory[gfxFamily] = &HwHelperHw::get(); + gfxCoreHelperFactory[gfxFamily] = &GfxCoreHelperHw::get(); populateFactoryTable>(); populateFactoryTable>(); populateFactoryTable>(); diff --git a/shared/source/gen8/hw_helper_gen8.cpp b/shared/source/gen8/hw_helper_gen8.cpp index 2cfd35b299..85fff113df 100644 --- a/shared/source/gen8/hw_helper_gen8.cpp +++ b/shared/source/gen8/hw_helper_gen8.cpp @@ -20,7 +20,7 @@ typedef Gen8Family Family; static uint32_t slmSizeId[] = {0, 1, 2, 4, 4, 8, 8, 8, 8, 16, 16, 16, 16, 16, 16, 16}; template <> -uint32_t HwHelperHw::alignSlmSize(uint32_t slmSize) { +uint32_t GfxCoreHelperHw::alignSlmSize(uint32_t slmSize) { if (slmSize == 0u) { return 0u; } @@ -30,7 +30,7 @@ uint32_t HwHelperHw::alignSlmSize(uint32_t slmSize) { } template <> -uint32_t HwHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32_t slmSize) { +uint32_t GfxCoreHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32_t slmSize) { slmSize += (4 * KB - 1); slmSize = slmSize >> 12; slmSize = std::min(slmSize, 15u); @@ -39,22 +39,22 @@ uint32_t HwHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32 } template <> -size_t HwHelperHw::getMaxBarrierRegisterPerSlice() const { +size_t GfxCoreHelperHw::getMaxBarrierRegisterPerSlice() const { return 16; } template <> -size_t HwHelperHw::getMax3dImageWidthOrHeight() const { +size_t GfxCoreHelperHw::getMax3dImageWidthOrHeight() const { return 2048; } template <> -uint64_t HwHelperHw::getMaxMemAllocSize() const { +uint64_t GfxCoreHelperHw::getMaxMemAllocSize() const { return (2 * MemoryConstants::gigaByte) - (8 * MemoryConstants::kiloByte); } template <> -bool HwHelperHw::isStatelessToStatefulWithOffsetSupported() const { +bool GfxCoreHelperHw::isStatelessToStatefulWithOffsetSupported() const { return false; } @@ -73,7 +73,7 @@ void MemorySynchronizationCommands::addSingleBarrier(LinearStream &comma *cmdBuffer = cmd; } -template class HwHelperHw; +template class GfxCoreHelperHw; template class FlatBatchBufferHelperHw; template struct MemorySynchronizationCommands; template struct LriHelper; diff --git a/shared/source/gen9/enable_family_full_core_gen9.cpp b/shared/source/gen9/enable_family_full_core_gen9.cpp index 6edcfc39ee..acd479bc68 100644 --- a/shared/source/gen9/enable_family_full_core_gen9.cpp +++ b/shared/source/gen9/enable_family_full_core_gen9.cpp @@ -17,14 +17,14 @@ namespace NEO { -extern HwHelper *hwHelperFactory[IGFX_MAX_CORE]; +extern GfxCoreHelper *gfxCoreHelperFactory[IGFX_MAX_CORE]; using Family = Gen9Family; static const auto gfxFamily = IGFX_GEN9_CORE; struct EnableCoreGen9 { EnableCoreGen9() { - hwHelperFactory[gfxFamily] = &HwHelperHw::get(); + gfxCoreHelperFactory[gfxFamily] = &GfxCoreHelperHw::get(); populateFactoryTable>(); populateFactoryTable>(); populateFactoryTable>(); diff --git a/shared/source/gen9/hw_helper_gen9.cpp b/shared/source/gen9/hw_helper_gen9.cpp index 538b1d4eac..6ae33f065b 100644 --- a/shared/source/gen9/hw_helper_gen9.cpp +++ b/shared/source/gen9/hw_helper_gen9.cpp @@ -19,7 +19,7 @@ namespace NEO { typedef Gen9Family Family; template <> -SipKernelType HwHelperHw::getSipKernelType(bool debuggingActive) const { +SipKernelType GfxCoreHelperHw::getSipKernelType(bool debuggingActive) const { if (!debuggingActive) { return SipKernelType::Csr; } @@ -27,12 +27,12 @@ SipKernelType HwHelperHw::getSipKernelType(bool debuggingActive) const { } template <> -uint32_t HwHelperHw::getMetricsLibraryGenId() const { +uint32_t GfxCoreHelperHw::getMetricsLibraryGenId() const { return static_cast(MetricsLibraryApi::ClientGen::Gen9); } template <> -int32_t HwHelperHw::getDefaultThreadArbitrationPolicy() const { +int32_t GfxCoreHelperHw::getDefaultThreadArbitrationPolicy() const { return ThreadArbitrationPolicy::RoundRobin; } @@ -40,11 +40,11 @@ template <> bool MemorySynchronizationCommands::isBarrierWaRequired(const HardwareInfo &hwInfo) { return true; } template <> -bool HwHelperHw::isTimestampShiftRequired() const { +bool GfxCoreHelperHw::isTimestampShiftRequired() const { return false; } -template class HwHelperHw; +template class GfxCoreHelperHw; template class FlatBatchBufferHelperHw; template struct MemorySynchronizationCommands; template struct LriHelper; diff --git a/shared/source/gmm_helper/gmm.cpp b/shared/source/gmm_helper/gmm.cpp index ea867aa050..ed8e174d87 100644 --- a/shared/source/gmm_helper/gmm.cpp +++ b/shared/source/gmm_helper/gmm.cpp @@ -116,7 +116,7 @@ void Gmm::setupImageResourceParams(ImageInfo &imgInfo, bool preferCompressed) { resourceParams.Flags.Info.Linear = imgInfo.linearStorage; - auto &hwHelper = HwHelper::get(gmmHelper->getClientContext()->getHardwareInfo()->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(gmmHelper->getClientContext()->getHardwareInfo()->platform.eRenderCoreFamily); resourceParams.NoGfxMemory = 1; // dont allocate, only query for params @@ -128,7 +128,7 @@ void Gmm::setupImageResourceParams(ImageInfo &imgInfo, bool preferCompressed) { resourceParams.BaseHeight = imageHeight; resourceParams.Depth = imageDepth; resourceParams.ArraySize = imageCount; - resourceParams.Flags.Wa.__ForceOtherHVALIGN4 = hwHelper.hvAlign4Required(); + resourceParams.Flags.Wa.__ForceOtherHVALIGN4 = gfxCoreHelper.hvAlign4Required(); resourceParams.MaxLod = imgInfo.baseMipLevel + imgInfo.mipCount; applyAuxFlagsForImage(imgInfo, preferCompressed); @@ -136,17 +136,17 @@ void Gmm::setupImageResourceParams(ImageInfo &imgInfo, bool preferCompressed) { void Gmm::applyAuxFlagsForBuffer(bool preferCompression) { auto hardwareInfo = gmmHelper->getClientContext()->getHardwareInfo(); - bool allowCompression = HwHelper::compressedBuffersSupported(*hardwareInfo) && + bool allowCompression = GfxCoreHelper::compressedBuffersSupported(*hardwareInfo) && preferCompression; - auto &hwHelper = HwHelper::get(hardwareInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo->platform.eRenderCoreFamily); if (allowCompression) { - hwHelper.applyRenderCompressionFlag(*this, 1); + gfxCoreHelper.applyRenderCompressionFlag(*this, 1); resourceParams.Flags.Gpu.CCS = 1; resourceParams.Flags.Gpu.UnifiedAuxSurface = 1; isCompressionEnabled = true; } - hwHelper.applyAdditionalCompressionSettings(*this, !isCompressionEnabled); + gfxCoreHelper.applyAdditionalCompressionSettings(*this, !isCompressionEnabled); } void Gmm::applyAuxFlagsForImage(ImageInfo &imgInfo, bool preferCompressed) { @@ -171,24 +171,24 @@ void Gmm::applyAuxFlagsForImage(ImageInfo &imgInfo, bool preferCompressed) { auto hwInfo = gmmHelper->getClientContext()->getHardwareInfo(); - bool allowCompression = HwHelper::compressedImagesSupported(*hwInfo) && + bool allowCompression = GfxCoreHelper::compressedImagesSupported(*hwInfo) && preferCompressed && compressionFormatSupported && imgInfo.surfaceFormat->GMMSurfaceFormat != GMM_RESOURCE_FORMAT::GMM_FORMAT_NV12 && imgInfo.plane == GMM_YUV_PLANE_ENUM::GMM_NO_PLANE && !isPackedYuv; - auto &hwHelper = HwHelper::get(hwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily); if (imgInfo.useLocalMemory || !hwInfo->featureTable.flags.ftrLocalMemory) { if (allowCompression) { - hwHelper.applyRenderCompressionFlag(*this, 1); + gfxCoreHelper.applyRenderCompressionFlag(*this, 1); this->resourceParams.Flags.Gpu.CCS = 1; this->resourceParams.Flags.Gpu.UnifiedAuxSurface = 1; this->resourceParams.Flags.Gpu.IndirectClearColor = 1; this->isCompressionEnabled = true; } } - hwHelper.applyAdditionalCompressionSettings(*this, !isCompressionEnabled); + gfxCoreHelper.applyAdditionalCompressionSettings(*this, !isCompressionEnabled); } void Gmm::queryImageParams(ImageInfo &imgInfo) { diff --git a/shared/source/helpers/blit_commands_helper.cpp b/shared/source/helpers/blit_commands_helper.cpp index ea6d3c0bc7..3f6969bb04 100644 --- a/shared/source/helpers/blit_commands_helper.cpp +++ b/shared/source/helpers/blit_commands_helper.cpp @@ -177,7 +177,7 @@ BlitOperationResult BlitHelper::blitMemoryToAllocationBanks(const Device &device if (!hwInfo.capabilityTable.blitterOperationsSupported) { return BlitOperationResult::Unsupported; } - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); UNRECOVERABLE_IF(memoryBanks.none()); @@ -194,7 +194,7 @@ BlitOperationResult BlitHelper::blitMemoryToAllocationBanks(const Device &device auto deviceBitfield = pDeviceForBlit->getDeviceBitfield(); auto internalUsage = true; auto bcsEngineType = EngineHelpers::getBcsEngineType(hwInfo, deviceBitfield, selectorCopyEngine, internalUsage); - auto bcsEngineUsage = hwHelper.preferInternalBcsEngine() ? EngineUsage::Internal : EngineUsage::Regular; + auto bcsEngineUsage = gfxCoreHelper.preferInternalBcsEngine() ? EngineUsage::Internal : EngineUsage::Regular; auto bcsEngine = pDeviceForBlit->tryGetEngine(bcsEngineType, bcsEngineUsage); if (!bcsEngine) { return BlitOperationResult::Unsupported; diff --git a/shared/source/helpers/cache_flush.inl b/shared/source/helpers/cache_flush.inl index 8632124773..3725fe5b5e 100644 --- a/shared/source/helpers/cache_flush.inl +++ b/shared/source/helpers/cache_flush.inl @@ -18,8 +18,8 @@ inline void flushGpuCache(LinearStream *commandStream, const Range &ran using L3_FLUSH_EVICTION_POLICY = typename GfxFamily::L3_FLUSH_ADDRESS_RANGE::L3_FLUSH_EVICTION_POLICY; auto templ = GfxFamily::cmdInitL3ControlWithPostSync; templ.getBase().setHdcPipelineFlush(true); - HwHelper &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - auto isA0Stepping = hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto isA0Stepping = gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); for (const L3Range *it = &*ranges.begin(), *last = &*ranges.rbegin(), *end = &*ranges.end(); it != end; ++it) { if ((it == last) && (postSyncAddress != 0)) { diff --git a/shared/source/helpers/engine_node_helper.cpp b/shared/source/helpers/engine_node_helper.cpp index c03423ac1f..ef362590ba 100644 --- a/shared/source/helpers/engine_node_helper.cpp +++ b/shared/source/helpers/engine_node_helper.cpp @@ -132,7 +132,7 @@ void releaseBcsEngineType(aub_stream::EngineType engineType, SelectorCopyEngine } aub_stream::EngineType remapEngineTypeToHwSpecific(aub_stream::EngineType inputType, const HardwareInfo &hwInfo) { - bool isExpectedProduct = HwHelper::get(hwInfo.platform.eRenderCoreFamily).isEngineTypeRemappingToHwSpecificRequired(); + bool isExpectedProduct = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isEngineTypeRemappingToHwSpecificRequired(); if (isExpectedProduct && inputType == aub_stream::EngineType::ENGINE_RCS) { return aub_stream::EngineType::ENGINE_CCCS; @@ -168,7 +168,7 @@ bool isBcsEnabled(const HardwareInfo &hwInfo, aub_stream::EngineType engineType) } bool linkCopyEnginesSupported(const HardwareInfo &hwInfo, const DeviceBitfield &deviceBitfield) { - const aub_stream::EngineType engine1 = HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, aub_stream::ENGINE_BCS1) + const aub_stream::EngineType engine1 = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, aub_stream::ENGINE_BCS1) ? aub_stream::ENGINE_BCS1 : aub_stream::ENGINE_BCS4; const aub_stream::EngineType engine2 = aub_stream::ENGINE_BCS2; @@ -216,14 +216,14 @@ aub_stream::EngineType selectLinkCopyEngine(const HardwareInfo &hwInfo, const De engineType = static_cast(aub_stream::EngineType::ENGINE_BCS1 + selectEngineValue); } - } while (!HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, engineType) || !hwInfo.featureTable.ftrBcsInfo.test(engineType == aub_stream::EngineType::ENGINE_BCS - ? 0 - : engineType - aub_stream::EngineType::ENGINE_BCS1 + 1)); + } while (!GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, engineType) || !hwInfo.featureTable.ftrBcsInfo.test(engineType == aub_stream::EngineType::ENGINE_BCS + ? 0 + : engineType - aub_stream::EngineType::ENGINE_BCS1 + 1)); return engineType; } - const aub_stream::EngineType engine1 = HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, aub_stream::ENGINE_BCS1) + const aub_stream::EngineType engine1 = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, aub_stream::ENGINE_BCS1) ? aub_stream::ENGINE_BCS1 : aub_stream::ENGINE_BCS4; const aub_stream::EngineType engine2 = aub_stream::ENGINE_BCS2; diff --git a/shared/source/helpers/extra_allocation_data_xehp_and_later.inl b/shared/source/helpers/extra_allocation_data_xehp_and_later.inl index ebcd3cffd4..3827d53875 100644 --- a/shared/source/helpers/extra_allocation_data_xehp_and_later.inl +++ b/shared/source/helpers/extra_allocation_data_xehp_and_later.inl @@ -13,7 +13,7 @@ namespace NEO { template <> -void HwHelperHw::setExtraAllocationData(AllocationData &allocationData, const AllocationProperties &properties, const HardwareInfo &hwInfo) const { +void GfxCoreHelperHw::setExtraAllocationData(AllocationData &allocationData, const AllocationProperties &properties, const HardwareInfo &hwInfo) const { const auto &hwInfoConfig = *HwInfoConfig::get(hwInfo.platform.eProductFamily); if (LocalMemoryAccessMode::CpuAccessDisallowed == hwInfoConfig.getLocalMemoryAccessMode(hwInfo)) { diff --git a/shared/source/helpers/hw_helper.cpp b/shared/source/helpers/hw_helper.cpp index 59a3902055..bc0178233e 100644 --- a/shared/source/helpers/hw_helper.cpp +++ b/shared/source/helpers/hw_helper.cpp @@ -13,27 +13,27 @@ #include namespace NEO { -HwHelper *hwHelperFactory[IGFX_MAX_CORE] = {}; +GfxCoreHelper *gfxCoreHelperFactory[IGFX_MAX_CORE] = {}; -HwHelper &HwHelper::get(GFXCORE_FAMILY gfxCore) { - return *hwHelperFactory[gfxCore]; +GfxCoreHelper &GfxCoreHelper::get(GFXCORE_FAMILY gfxCore) { + return *gfxCoreHelperFactory[gfxCore]; } -bool HwHelper::compressedBuffersSupported(const HardwareInfo &hwInfo) { +bool GfxCoreHelper::compressedBuffersSupported(const HardwareInfo &hwInfo) { if (DebugManager.flags.RenderCompressedBuffersEnabled.get() != -1) { return !!DebugManager.flags.RenderCompressedBuffersEnabled.get(); } return hwInfo.capabilityTable.ftrRenderCompressedBuffers; } -bool HwHelper::compressedImagesSupported(const HardwareInfo &hwInfo) { +bool GfxCoreHelper::compressedImagesSupported(const HardwareInfo &hwInfo) { if (DebugManager.flags.RenderCompressedImagesEnabled.get() != -1) { return !!DebugManager.flags.RenderCompressedImagesEnabled.get(); } return hwInfo.capabilityTable.ftrRenderCompressedImages; } -bool HwHelper::cacheFlushAfterWalkerSupported(const HardwareInfo &hwInfo) { +bool GfxCoreHelper::cacheFlushAfterWalkerSupported(const HardwareInfo &hwInfo) { int32_t dbgFlag = DebugManager.flags.EnableCacheFlushAfterWalker.get(); if (dbgFlag == 1) { return true; @@ -43,7 +43,7 @@ bool HwHelper::cacheFlushAfterWalkerSupported(const HardwareInfo &hwInfo) { return hwInfo.capabilityTable.supportCacheFlushAfterWalker; } -uint32_t HwHelper::getMaxThreadsForVfe(const HardwareInfo &hwInfo) { +uint32_t GfxCoreHelper::getMaxThreadsForVfe(const HardwareInfo &hwInfo) { uint32_t threadsPerEU = (hwInfo.gtSystemInfo.ThreadCount / hwInfo.gtSystemInfo.EUCount) + hwInfo.capabilityTable.extraQuantityThreadsPerEU; auto maxHwThreadsCapable = hwInfo.gtSystemInfo.EUCount * threadsPerEU; auto maxHwThreadsReturned = maxHwThreadsCapable; @@ -56,7 +56,7 @@ uint32_t HwHelper::getMaxThreadsForVfe(const HardwareInfo &hwInfo) { return maxHwThreadsReturned; } -uint32_t HwHelper::getSubDevicesCount(const HardwareInfo *pHwInfo) { +uint32_t GfxCoreHelper::getSubDevicesCount(const HardwareInfo *pHwInfo) { if (DebugManager.flags.CreateMultipleSubDevices.get() > 0) { return DebugManager.flags.CreateMultipleSubDevices.get(); } else if (pHwInfo->gtSystemInfo.MultiTileArchInfo.IsValid && pHwInfo->gtSystemInfo.MultiTileArchInfo.TileCount > 0u) { @@ -66,7 +66,7 @@ uint32_t HwHelper::getSubDevicesCount(const HardwareInfo *pHwInfo) { } } -uint32_t HwHelper::getHighestEnabledSlice(const HardwareInfo &hwInfo) { +uint32_t GfxCoreHelper::getHighestEnabledSlice(const HardwareInfo &hwInfo) { uint32_t highestEnabledSlice = 0; if (!hwInfo.gtSystemInfo.IsDynamicallyPopulated) { return hwInfo.gtSystemInfo.MaxSlicesSupported; diff --git a/shared/source/helpers/hw_helper.h b/shared/source/helpers/hw_helper.h index 9461637830..bf2910a99e 100644 --- a/shared/source/helpers/hw_helper.h +++ b/shared/source/helpers/hw_helper.h @@ -40,10 +40,18 @@ struct AllocationProperties; struct EncodeSurfaceStateArgs; struct RootDeviceEnvironment; struct PipeControlArgs; +class GfxCoreHelper; +template +class GfxCoreHelperHw; -class HwHelper { +using HwHelper = GfxCoreHelper; + +template +using HwHelperHw = GfxCoreHelperHw; + +class GfxCoreHelper { public: - static HwHelper &get(GFXCORE_FAMILY gfxCore); + static GfxCoreHelper &get(GFXCORE_FAMILY gfxCore); virtual size_t getMaxBarrierRegisterPerSlice() const = 0; virtual size_t getPaddingForISAAllocation() const = 0; virtual uint32_t getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const = 0; @@ -164,15 +172,15 @@ class HwHelper { virtual bool isRelaxedOrderingSupported() const = 0; protected: - HwHelper() = default; + GfxCoreHelper() = default; }; template -class HwHelperHw : public HwHelper { +class GfxCoreHelperHw : public GfxCoreHelper { public: - static HwHelperHw &get() { - static HwHelperHw hwHelper; - return hwHelper; + static GfxCoreHelperHw &get() { + static GfxCoreHelperHw gfxCoreHelper; + return gfxCoreHelper; } size_t getRenderSurfaceStateSize() const override { @@ -382,7 +390,7 @@ class HwHelperHw : public HwHelper { protected: static const AuxTranslationMode defaultAuxTranslationMode; - HwHelperHw() = default; + GfxCoreHelperHw() = default; }; struct DwordBuilder { diff --git a/shared/source/helpers/hw_helper_base.inl b/shared/source/helpers/hw_helper_base.inl index e75db242ce..bfdb71e7f6 100644 --- a/shared/source/helpers/hw_helper_base.inl +++ b/shared/source/helpers/hw_helper_base.inl @@ -27,10 +27,10 @@ namespace NEO { template -const AuxTranslationMode HwHelperHw::defaultAuxTranslationMode = AuxTranslationMode::Builtin; +const AuxTranslationMode GfxCoreHelperHw::defaultAuxTranslationMode = AuxTranslationMode::Builtin; template -bool HwHelperHw::isBufferSizeSuitableForCompression(const size_t size, const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isBufferSizeSuitableForCompression(const size_t size, const HardwareInfo &hwInfo) const { if (DebugManager.flags.OverrideBufferSuitableForRenderCompression.get() != -1) { return !!DebugManager.flags.OverrideBufferSuitableForRenderCompression.get(); } @@ -38,24 +38,24 @@ bool HwHelperHw::isBufferSizeSuitableForCompression(const size_t size, c } template -size_t HwHelperHw::getMax3dImageWidthOrHeight() const { +size_t GfxCoreHelperHw::getMax3dImageWidthOrHeight() const { return 16384; } template -uint64_t HwHelperHw::getMaxMemAllocSize() const { +uint64_t GfxCoreHelperHw::getMaxMemAllocSize() const { // With stateful messages we have an allocation cap of 4GB // Reason to subtract 8KB is that driver may pad the buffer with addition pages for over fetching return (4ULL * MemoryConstants::gigaByte) - (8ULL * MemoryConstants::kiloByte); } template -bool HwHelperHw::isStatelessToStatefulWithOffsetSupported() const { +bool GfxCoreHelperHw::isStatelessToStatefulWithOffsetSupported() const { return true; } template -SipKernelType HwHelperHw::getSipKernelType(bool debuggingActive) const { +SipKernelType GfxCoreHelperHw::getSipKernelType(bool debuggingActive) const { if (!debuggingActive) { return SipKernelType::Csr; } @@ -63,12 +63,12 @@ SipKernelType HwHelperHw::getSipKernelType(bool debuggingActive) const { } template -size_t HwHelperHw::getMaxBarrierRegisterPerSlice() const { +size_t GfxCoreHelperHw::getMaxBarrierRegisterPerSlice() const { return 32; } template -size_t HwHelperHw::getPaddingForISAAllocation() const { +size_t GfxCoreHelperHw::getPaddingForISAAllocation() const { if (DebugManager.flags.ForceExtendedKernelIsaSize.get() >= 1) { return 512 + (MemoryConstants::pageSize * DebugManager.flags.ForceExtendedKernelIsaSize.get()); } @@ -76,42 +76,42 @@ size_t HwHelperHw::getPaddingForISAAllocation() const { } template -uint32_t HwHelperHw::getPitchAlignmentForImage(const RootDeviceEnvironment &rootDeviceEnvironment) const { +uint32_t GfxCoreHelperHw::getPitchAlignmentForImage(const RootDeviceEnvironment &rootDeviceEnvironment) const { return 4u; } template -uint32_t HwHelperHw::getMaxNumSamplers() const { +uint32_t GfxCoreHelperHw::getMaxNumSamplers() const { return 16; } template -const AubMemDump::LrcaHelper &HwHelperHw::getCsTraits(aub_stream::EngineType engineType) const { +const AubMemDump::LrcaHelper &GfxCoreHelperHw::getCsTraits(aub_stream::EngineType engineType) const { return *AUBFamilyMapper::csTraits[engineType]; } template -bool HwHelperHw::isFenceAllocationRequired(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isFenceAllocationRequired(const HardwareInfo &hwInfo) const { return false; } template -inline bool HwHelperHw::checkResourceCompatibility(GraphicsAllocation &graphicsAllocation) { +inline bool GfxCoreHelperHw::checkResourceCompatibility(GraphicsAllocation &graphicsAllocation) { return true; } template -void HwHelperHw::setRenderSurfaceStateForScratchResource(const RootDeviceEnvironment &rootDeviceEnvironment, - void *surfaceStateBuffer, - size_t bufferSize, - uint64_t gpuVa, - size_t offset, - uint32_t pitch, - GraphicsAllocation *gfxAlloc, - bool isReadOnly, - uint32_t surfaceType, - bool forceNonAuxMode, - bool useL1Cache) { +void GfxCoreHelperHw::setRenderSurfaceStateForScratchResource(const RootDeviceEnvironment &rootDeviceEnvironment, + void *surfaceStateBuffer, + size_t bufferSize, + uint64_t gpuVa, + size_t offset, + uint32_t pitch, + GraphicsAllocation *gfxAlloc, + bool isReadOnly, + uint32_t surfaceType, + bool forceNonAuxMode, + bool useL1Cache) { using RENDER_SURFACE_STATE = typename Family::RENDER_SURFACE_STATE; using SURFACE_FORMAT = typename RENDER_SURFACE_STATE::SURFACE_FORMAT; using AUXILIARY_SURFACE_MODE = typename RENDER_SURFACE_STATE::AUXILIARY_SURFACE_MODE; @@ -174,10 +174,10 @@ void HwHelperHw::setRenderSurfaceStateForScratchResource(const RootDevic } template -void NEO::HwHelperHw::setL1CachePolicy(bool useL1Cache, typename GfxFamily::RENDER_SURFACE_STATE *surfaceState, const HardwareInfo *hwInfo) {} +void NEO::GfxCoreHelperHw::setL1CachePolicy(bool useL1Cache, typename GfxFamily::RENDER_SURFACE_STATE *surfaceState, const HardwareInfo *hwInfo) {} template -bool HwHelperHw::getEnableLocalMemory(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::getEnableLocalMemory(const HardwareInfo &hwInfo) const { if (DebugManager.flags.EnableLocalMemory.get() != -1) { return DebugManager.flags.EnableLocalMemory.get(); } else if (DebugManager.flags.AUBDumpForceAllToLocalMemory.get()) { @@ -188,13 +188,13 @@ bool HwHelperHw::getEnableLocalMemory(const HardwareInfo &hwInfo) const } template -bool HwHelperHw::is1MbAlignmentSupported(const HardwareInfo &hwInfo, bool isCompressionEnabled) const { +bool GfxCoreHelperHw::is1MbAlignmentSupported(const HardwareInfo &hwInfo, bool isCompressionEnabled) const { return false; } template -AuxTranslationMode HwHelperHw::getAuxTranslationMode(const HardwareInfo &hwInfo) { - auto mode = HwHelperHw::defaultAuxTranslationMode; +AuxTranslationMode GfxCoreHelperHw::getAuxTranslationMode(const HardwareInfo &hwInfo) { + auto mode = GfxCoreHelperHw::defaultAuxTranslationMode; if (DebugManager.flags.ForceAuxTranslationMode.get() != -1) { mode = static_cast(DebugManager.flags.ForceAuxTranslationMode.get()); } @@ -405,12 +405,12 @@ inline size_t MemorySynchronizationCommands::getSizeForAdditonalSynch } template -uint32_t HwHelperHw::getMetricsLibraryGenId() const { +uint32_t GfxCoreHelperHw::getMetricsLibraryGenId() const { return static_cast(MetricsLibraryApi::ClientGen::Gen9); } template -bool HwHelperHw::isLinearStoragePreferred(bool isSharedContext, bool isImage1d, bool forceLinearStorage) { +bool GfxCoreHelperHw::isLinearStoragePreferred(bool isSharedContext, bool isImage1d, bool forceLinearStorage) { if (DebugManager.flags.ForceLinearImages.get() || forceLinearStorage || isSharedContext || isImage1d) { return true; } @@ -418,7 +418,7 @@ bool HwHelperHw::isLinearStoragePreferred(bool isSharedContext, bool } template -uint32_t HwHelperHw::alignSlmSize(uint32_t slmSize) { +uint32_t GfxCoreHelperHw::alignSlmSize(uint32_t slmSize) { if (slmSize == 0u) { return 0u; } @@ -429,7 +429,7 @@ uint32_t HwHelperHw::alignSlmSize(uint32_t slmSize) { } template -uint32_t HwHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32_t slmSize) { +uint32_t GfxCoreHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32_t slmSize) { auto value = std::max(slmSize, 1024u); value = Math::nextPowerOfTwo(value); value = Math::getMinLsbSet(value); @@ -439,17 +439,17 @@ uint32_t HwHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uin } template -uint8_t HwHelperHw::getBarriersCountFromHasBarriers(uint8_t hasBarriers) const { +uint8_t GfxCoreHelperHw::getBarriersCountFromHasBarriers(uint8_t hasBarriers) const { return hasBarriers; } template -inline bool HwHelperHw::isOffsetToSkipSetFFIDGPWARequired(const HardwareInfo &hwInfo) const { +inline bool GfxCoreHelperHw::isOffsetToSkipSetFFIDGPWARequired(const HardwareInfo &hwInfo) const { return false; } template -bool HwHelperHw::isWorkaroundRequired(uint32_t lowestSteppingWithBug, uint32_t steppingWithFix, const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isWorkaroundRequired(uint32_t lowestSteppingWithBug, uint32_t steppingWithFix, const HardwareInfo &hwInfo) const { const auto hwInfoConfig = HwInfoConfig::get(hwInfo.platform.eProductFamily); auto lowestHwRevIdWithBug = hwInfoConfig->getHwRevIdFromStepping(lowestSteppingWithBug, hwInfo); auto hwRevIdWithFix = hwInfoConfig->getHwRevIdFromStepping(steppingWithFix, hwInfo); @@ -460,23 +460,23 @@ bool HwHelperHw::isWorkaroundRequired(uint32_t lowestSteppingWithBug, } template -bool HwHelperHw::isForceDefaultRCSEngineWARequired(const HardwareInfo &hwInfo) { +bool GfxCoreHelperHw::isForceDefaultRCSEngineWARequired(const HardwareInfo &hwInfo) { return false; } template -bool HwHelperHw::isWaDisableRccRhwoOptimizationRequired() const { +bool GfxCoreHelperHw::isWaDisableRccRhwoOptimizationRequired() const { return false; } template -inline uint32_t HwHelperHw::getMinimalSIMDSize() { +inline uint32_t GfxCoreHelperHw::getMinimalSIMDSize() { return 8u; } template -std::unique_ptr HwHelperHw::createTimestampPacketAllocator(const RootDeviceIndicesContainer &rootDeviceIndices, MemoryManager *memoryManager, - size_t initialTagCount, CommandStreamReceiverType csrType, DeviceBitfield deviceBitfield) const { +std::unique_ptr GfxCoreHelperHw::createTimestampPacketAllocator(const RootDeviceIndicesContainer &rootDeviceIndices, MemoryManager *memoryManager, + size_t initialTagCount, CommandStreamReceiverType csrType, DeviceBitfield deviceBitfield) const { bool doNotReleaseNodes = (csrType > CommandStreamReceiverType::CSR_HW) || DebugManager.flags.DisableTimestampPacketOptimizations.get(); @@ -501,17 +501,17 @@ std::unique_ptr HwHelperHw::createTimestampPacketAl } template -size_t HwHelperHw::getTimestampPacketAllocatorAlignment() const { +size_t GfxCoreHelperHw::getTimestampPacketAllocatorAlignment() const { return MemoryConstants::cacheLineSize * 4; } template -size_t HwHelperHw::getSingleTimestampPacketSize() const { - return HwHelperHw::getSingleTimestampPacketSizeHw(); +size_t GfxCoreHelperHw::getSingleTimestampPacketSize() const { + return GfxCoreHelperHw::getSingleTimestampPacketSizeHw(); } template -size_t HwHelperHw::getSingleTimestampPacketSizeHw() { +size_t GfxCoreHelperHw::getSingleTimestampPacketSizeHw() { if (DebugManager.flags.OverrideTimestampPacketSize.get() != -1) { if (DebugManager.flags.OverrideTimestampPacketSize.get() == 4) { return TimestampPackets::getSinglePacketSize(); @@ -546,40 +546,40 @@ void MemorySynchronizationCommands::addFullCacheFlush(LinearStream &c } template -const StackVec HwHelperHw::getDeviceSubGroupSizes() const { +const StackVec GfxCoreHelperHw::getDeviceSubGroupSizes() const { return {8, 16, 32}; } template -const StackVec HwHelperHw::getThreadsPerEUConfigs() const { +const StackVec GfxCoreHelperHw::getThreadsPerEUConfigs() const { return {}; } template -void HwHelperHw::setExtraAllocationData(AllocationData &allocationData, const AllocationProperties &properties, const HardwareInfo &hwInfo) const {} +void GfxCoreHelperHw::setExtraAllocationData(AllocationData &allocationData, const AllocationProperties &properties, const HardwareInfo &hwInfo) const {} template -bool HwHelperHw::isBankOverrideRequired(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isBankOverrideRequired(const HardwareInfo &hwInfo) const { return false; } template -int32_t HwHelperHw::getDefaultThreadArbitrationPolicy() const { +int32_t GfxCoreHelperHw::getDefaultThreadArbitrationPolicy() const { return 0; } template -bool HwHelperHw::useOnlyGlobalTimestamps() const { +bool GfxCoreHelperHw::useOnlyGlobalTimestamps() const { return false; } template -bool HwHelperHw::useSystemMemoryPlacementForISA(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::useSystemMemoryPlacementForISA(const HardwareInfo &hwInfo) const { return !getEnableLocalMemory(hwInfo); } template -bool HwHelperHw::isCpuImageTransferPreferred(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isCpuImageTransferPreferred(const HardwareInfo &hwInfo) const { return false; } @@ -589,122 +589,122 @@ bool MemorySynchronizationCommands::isBarrierlPriorToPipelineSelectWa } template -bool HwHelperHw::isRcsAvailable(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isRcsAvailable(const HardwareInfo &hwInfo) const { return true; } template -bool HwHelperHw::isCooperativeDispatchSupported(const EngineGroupType engineGroupType, const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isCooperativeDispatchSupported(const EngineGroupType engineGroupType, const HardwareInfo &hwInfo) const { return true; } template -uint32_t HwHelperHw::adjustMaxWorkGroupCount(uint32_t maxWorkGroupCount, const EngineGroupType engineGroupType, - const HardwareInfo &hwInfo, bool isEngineInstanced) const { +uint32_t GfxCoreHelperHw::adjustMaxWorkGroupCount(uint32_t maxWorkGroupCount, const EngineGroupType engineGroupType, + const HardwareInfo &hwInfo, bool isEngineInstanced) const { return maxWorkGroupCount; } template -bool HwHelperHw::isKmdMigrationSupported(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isKmdMigrationSupported(const HardwareInfo &hwInfo) const { return false; } template -bool HwHelperHw::isSipWANeeded(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isSipWANeeded(const HardwareInfo &hwInfo) const { return false; } template -bool HwHelperHw::isAdditionalFeatureFlagRequired(const FeatureTable *featureTable) const { +bool GfxCoreHelperHw::isAdditionalFeatureFlagRequired(const FeatureTable *featureTable) const { return false; } template -uint32_t HwHelperHw::getNumCacheRegions() const { +uint32_t GfxCoreHelperHw::getNumCacheRegions() const { return 0; } template -bool HwHelperHw::isSubDeviceEngineSupported(const HardwareInfo &hwInfo, const DeviceBitfield &deviceBitfield, aub_stream::EngineType engineType) const { +bool GfxCoreHelperHw::isSubDeviceEngineSupported(const HardwareInfo &hwInfo, const DeviceBitfield &deviceBitfield, aub_stream::EngineType engineType) const { return true; } template -size_t HwHelperHw::getPreemptionAllocationAlignment() const { +size_t GfxCoreHelperHw::getPreemptionAllocationAlignment() const { return 256 * MemoryConstants::kiloByte; } template -void HwHelperHw::applyAdditionalCompressionSettings(Gmm &gmm, bool isNotCompressed) const {} +void GfxCoreHelperHw::applyAdditionalCompressionSettings(Gmm &gmm, bool isNotCompressed) const {} template -void HwHelperHw::applyRenderCompressionFlag(Gmm &gmm, uint32_t isCompressed) const { +void GfxCoreHelperHw::applyRenderCompressionFlag(Gmm &gmm, uint32_t isCompressed) const { gmm.resourceParams.Flags.Info.RenderCompressed = isCompressed; } template -bool HwHelperHw::isEngineTypeRemappingToHwSpecificRequired() const { +bool GfxCoreHelperHw::isEngineTypeRemappingToHwSpecificRequired() const { return false; } template -bool HwHelperHw::isSipKernelAsHexadecimalArrayPreferred() const { +bool GfxCoreHelperHw::isSipKernelAsHexadecimalArrayPreferred() const { return false; } template -void HwHelperHw::setSipKernelData(uint32_t *&sipKernelBinary, size_t &kernelBinarySize) const { +void GfxCoreHelperHw::setSipKernelData(uint32_t *&sipKernelBinary, size_t &kernelBinarySize) const { } template -size_t HwHelperHw::getSipKernelMaxDbgSurfaceSize(const HardwareInfo &hwInfo) const { +size_t GfxCoreHelperHw::getSipKernelMaxDbgSurfaceSize(const HardwareInfo &hwInfo) const { return 0x1800000; } template -void HwHelperHw::adjustPreemptionSurfaceSize(size_t &csrSize) const { +void GfxCoreHelperHw::adjustPreemptionSurfaceSize(size_t &csrSize) const { } template -void HwHelperHw::encodeBufferSurfaceState(EncodeSurfaceStateArgs &args) { +void GfxCoreHelperHw::encodeBufferSurfaceState(EncodeSurfaceStateArgs &args) { EncodeSurfaceState::encodeBuffer(args); } template -bool HwHelperHw::disableL3CacheForDebug(const HardwareInfo &) const { +bool GfxCoreHelperHw::disableL3CacheForDebug(const HardwareInfo &) const { return false; } template -bool HwHelperHw::isRevisionSpecificBinaryBuiltinRequired() const { +bool GfxCoreHelperHw::isRevisionSpecificBinaryBuiltinRequired() const { return false; } template -bool HwHelperHw::forceNonGpuCoherencyWA(bool requiresCoherency) const { +bool GfxCoreHelperHw::forceNonGpuCoherencyWA(bool requiresCoherency) const { return requiresCoherency; } template -size_t HwHelperHw::getBatchBufferEndSize() const { +size_t GfxCoreHelperHw::getBatchBufferEndSize() const { return sizeof(typename GfxFamily::MI_BATCH_BUFFER_END); } template -const void *HwHelperHw::getBatchBufferEndReference() const { +const void *GfxCoreHelperHw::getBatchBufferEndReference() const { return reinterpret_cast(&GfxFamily::cmdInitBatchBufferEnd); } template -bool HwHelperHw::isPlatformFlushTaskEnabled(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isPlatformFlushTaskEnabled(const HardwareInfo &hwInfo) const { const auto &hwInfoConfig = *NEO::HwInfoConfig::get(hwInfo.platform.eProductFamily); return hwInfoConfig.isFlushTaskAllowed(); } template -uint64_t HwHelperHw::getPatIndex(CacheRegion cacheRegion, CachePolicy cachePolicy) const { +uint64_t GfxCoreHelperHw::getPatIndex(CacheRegion cacheRegion, CachePolicy cachePolicy) const { UNRECOVERABLE_IF(true); return -1; } template -bool HwHelperHw::copyThroughLockedPtrEnabled(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::copyThroughLockedPtrEnabled(const HardwareInfo &hwInfo) const { if (DebugManager.flags.ExperimentalCopyThroughLock.get() != -1) { return DebugManager.flags.ExperimentalCopyThroughLock.get() == 1; } @@ -712,7 +712,7 @@ bool HwHelperHw::copyThroughLockedPtrEnabled(const HardwareInfo &hwI } template -uint32_t HwHelperHw::getAmountOfAllocationsToFill() const { +uint32_t GfxCoreHelperHw::getAmountOfAllocationsToFill() const { if (DebugManager.flags.SetAmountOfReusableAllocations.get() != -1) { return DebugManager.flags.SetAmountOfReusableAllocations.get(); } @@ -720,17 +720,17 @@ uint32_t HwHelperHw::getAmountOfAllocationsToFill() const { } template -bool HwHelperHw::isChipsetUniqueUUIDSupported() const { +bool GfxCoreHelperHw::isChipsetUniqueUUIDSupported() const { return false; } template -bool HwHelperHw::isTimestampShiftRequired() const { +bool GfxCoreHelperHw::isTimestampShiftRequired() const { return true; } template -bool HwHelperHw::isRelaxedOrderingSupported() const { +bool GfxCoreHelperHw::isRelaxedOrderingSupported() const { return false; } diff --git a/shared/source/helpers/hw_helper_bdw_and_later.inl b/shared/source/helpers/hw_helper_bdw_and_later.inl index 17fc93cb56..71e4e520a7 100644 --- a/shared/source/helpers/hw_helper_bdw_and_later.inl +++ b/shared/source/helpers/hw_helper_bdw_and_later.inl @@ -11,53 +11,53 @@ namespace NEO { template -void HwHelperHw::adjustDefaultEngineType(HardwareInfo *pHwInfo) { +void GfxCoreHelperHw::adjustDefaultEngineType(HardwareInfo *pHwInfo) { } template -uint32_t HwHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const { +uint32_t GfxCoreHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const { auto hwInfo = rootDeviceEnvironment.getHardwareInfo(); return hwInfo->gtSystemInfo.MaxSubSlicesSupported * hwInfo->gtSystemInfo.MaxEuPerSubSlice * hwInfo->gtSystemInfo.ThreadCount / hwInfo->gtSystemInfo.EUCount; } template -inline uint32_t HwHelperHw::getGlobalTimeStampBits() const { +inline uint32_t GfxCoreHelperHw::getGlobalTimeStampBits() const { return 36; } template -bool HwHelperHw::isLocalMemoryEnabled(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isLocalMemoryEnabled(const HardwareInfo &hwInfo) const { return false; } template -bool HwHelperHw::hvAlign4Required() const { +bool GfxCoreHelperHw::hvAlign4Required() const { return true; } template -bool HwHelperHw::timestampPacketWriteSupported() const { +bool GfxCoreHelperHw::timestampPacketWriteSupported() const { return false; } template -bool HwHelperHw::isTimestampWaitSupportedForQueues() const { +bool GfxCoreHelperHw::isTimestampWaitSupportedForQueues() const { return false; } template -bool HwHelperHw::isUpdateTaskCountFromWaitSupported() const { +bool GfxCoreHelperHw::isUpdateTaskCountFromWaitSupported() const { return false; } template -bool HwHelperHw::isAssignEngineRoundRobinSupported(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isAssignEngineRoundRobinSupported(const HardwareInfo &hwInfo) const { return false; } template -const EngineInstancesContainer HwHelperHw::getGpgpuEngineInstances(const HardwareInfo &hwInfo) const { +const EngineInstancesContainer GfxCoreHelperHw::getGpgpuEngineInstances(const HardwareInfo &hwInfo) const { return { {aub_stream::ENGINE_RCS, EngineUsage::Regular}, {aub_stream::ENGINE_RCS, EngineUsage::LowPriority}, @@ -66,7 +66,7 @@ const EngineInstancesContainer HwHelperHw::getGpgpuEngineInstances(co } template -EngineGroupType HwHelperHw::getEngineGroupType(aub_stream::EngineType engineType, EngineUsage engineUsage, const HardwareInfo &hwInfo) const { +EngineGroupType GfxCoreHelperHw::getEngineGroupType(aub_stream::EngineType engineType, EngineUsage engineUsage, const HardwareInfo &hwInfo) const { switch (engineType) { case aub_stream::ENGINE_RCS: return EngineGroupType::RenderCompute; @@ -76,12 +76,12 @@ EngineGroupType HwHelperHw::getEngineGroupType(aub_stream::EngineType } template -std::string HwHelperHw::getExtensions(const HardwareInfo &hwInfo) const { +std::string GfxCoreHelperHw::getExtensions(const HardwareInfo &hwInfo) const { return ""; } template -uint32_t HwHelperHw::getMocsIndex(const GmmHelper &gmmHelper, bool l3enabled, bool l1enabled) const { +uint32_t GfxCoreHelperHw::getMocsIndex(const GmmHelper &gmmHelper, bool l3enabled, bool l1enabled) const { if (l3enabled) { return gmmHelper.getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER) >> 1; } @@ -89,29 +89,29 @@ uint32_t HwHelperHw::getMocsIndex(const GmmHelper &gmmHelper, bool l3 } template -uint32_t HwHelperHw::calculateAvailableThreadCount(const HardwareInfo &hwInfo, uint32_t grfCount) { +uint32_t GfxCoreHelperHw::calculateAvailableThreadCount(const HardwareInfo &hwInfo, uint32_t grfCount) { return hwInfo.gtSystemInfo.ThreadCount; } template -uint64_t HwHelperHw::getGpuTimeStampInNS(uint64_t timeStamp, double frequency) const { +uint64_t GfxCoreHelperHw::getGpuTimeStampInNS(uint64_t timeStamp, double frequency) const { return static_cast(timeStamp * frequency); } template -inline bool HwHelperHw::preferSmallWorkgroupSizeForKernel(const size_t size, const HardwareInfo &hwInfo) const { +inline bool GfxCoreHelperHw::preferSmallWorkgroupSizeForKernel(const size_t size, const HardwareInfo &hwInfo) const { return false; } constexpr uint32_t planarYuvMaxHeight = 16352; template -uint32_t HwHelperHw::getPlanarYuvMaxHeight() const { +uint32_t GfxCoreHelperHw::getPlanarYuvMaxHeight() const { return planarYuvMaxHeight; } template -aub_stream::MMIOList HwHelperHw::getExtraMmioList(const HardwareInfo &hwInfo, const GmmHelper &gmmHelper) const { +aub_stream::MMIOList GfxCoreHelperHw::getExtraMmioList(const HardwareInfo &hwInfo, const GmmHelper &gmmHelper) const { return {}; } @@ -136,32 +136,32 @@ inline void MemorySynchronizationCommands::setBarrierWaFlags(void *ba } template -bool HwHelperHw::unTypedDataPortCacheFlushRequired() const { +bool GfxCoreHelperHw::unTypedDataPortCacheFlushRequired() const { return false; } template -bool HwHelperHw::isScratchSpaceSurfaceStateAccessible() const { +bool GfxCoreHelperHw::isScratchSpaceSurfaceStateAccessible() const { return false; } template -uint32_t HwHelperHw::getMaxScratchSize() const { +uint32_t GfxCoreHelperHw::getMaxScratchSize() const { return 2 * MB; } template -inline bool HwHelperHw::platformSupportsImplicitScaling(const NEO::HardwareInfo &hwInfo) const { +inline bool GfxCoreHelperHw::platformSupportsImplicitScaling(const NEO::HardwareInfo &hwInfo) const { return false; } template -inline bool HwHelperHw::preferInternalBcsEngine() const { +inline bool GfxCoreHelperHw::preferInternalBcsEngine() const { return false; } template -uint32_t HwHelperHw::getMinimalScratchSpaceSize() const { +uint32_t GfxCoreHelperHw::getMinimalScratchSpaceSize() const { return 1024U; } } // namespace NEO diff --git a/shared/source/helpers/hw_helper_bdw_to_icllp.inl b/shared/source/helpers/hw_helper_bdw_to_icllp.inl index bb8d4f3a47..132032031e 100644 --- a/shared/source/helpers/hw_helper_bdw_to_icllp.inl +++ b/shared/source/helpers/hw_helper_bdw_to_icllp.inl @@ -11,7 +11,7 @@ namespace NEO { template -inline bool HwHelperHw::isFusedEuDispatchEnabled(const HardwareInfo &hwInfo, bool disableEUFusionForKernel) const { +inline bool GfxCoreHelperHw::isFusedEuDispatchEnabled(const HardwareInfo &hwInfo, bool disableEUFusionForKernel) const { return false; } @@ -26,12 +26,12 @@ void LriHelper::program(LinearStream *cmdStream, uint32_t address, ui } template -bool HwHelperHw::packedFormatsSupported() const { +bool GfxCoreHelperHw::packedFormatsSupported() const { return false; } template -size_t HwHelperHw::getMaxFillPaternSizeForCopyEngine() const { +size_t GfxCoreHelperHw::getMaxFillPaternSizeForCopyEngine() const { return sizeof(uint32_t); } diff --git a/shared/source/helpers/hw_helper_dg2_and_later.inl b/shared/source/helpers/hw_helper_dg2_and_later.inl index af8a0fbb72..4fb4a930c9 100644 --- a/shared/source/helpers/hw_helper_dg2_and_later.inl +++ b/shared/source/helpers/hw_helper_dg2_and_later.inl @@ -57,12 +57,12 @@ void MemorySynchronizationCommands::setBarrierWaFlags(void *barrierCm } template <> -bool HwHelperHw::isUpdateTaskCountFromWaitSupported() const { +bool GfxCoreHelperHw::isUpdateTaskCountFromWaitSupported() const { return true; } template <> -bool HwHelperHw::unTypedDataPortCacheFlushRequired() const { +bool GfxCoreHelperHw::unTypedDataPortCacheFlushRequired() const { return true; } } // namespace NEO diff --git a/shared/source/helpers/hw_helper_pvc_and_later.inl b/shared/source/helpers/hw_helper_pvc_and_later.inl index 3dee40077e..e792e56887 100644 --- a/shared/source/helpers/hw_helper_pvc_and_later.inl +++ b/shared/source/helpers/hw_helper_pvc_and_later.inl @@ -11,7 +11,7 @@ namespace NEO { template <> -bool HwHelperHw::isFenceAllocationRequired(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isFenceAllocationRequired(const HardwareInfo &hwInfo) const { if ((DebugManager.flags.ProgramGlobalFenceAsMiMemFenceCommandInCommandStream.get() == 0) && (DebugManager.flags.ProgramGlobalFenceAsPostSyncOperationInComputeWalker.get() == 0) && (DebugManager.flags.ProgramGlobalFenceAsKernelInstructionInEUKernel.get() == 0)) { @@ -21,19 +21,19 @@ bool HwHelperHw::isFenceAllocationRequired(const HardwareInfo &hwInfo) c } template <> -bool HwHelperHw::isCpuImageTransferPreferred(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isCpuImageTransferPreferred(const HardwareInfo &hwInfo) const { return !hwInfo.capabilityTable.supportsImages; } template <> -bool HwHelperHw::isRcsAvailable(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isRcsAvailable(const HardwareInfo &hwInfo) const { auto defaultEngine = getChosenEngineType(hwInfo); return (defaultEngine == aub_stream::EngineType::ENGINE_RCS) || (defaultEngine == aub_stream::EngineType::ENGINE_CCCS) || hwInfo.featureTable.flags.ftrRcsNode; } template <> -bool HwHelperHw::isCooperativeDispatchSupported(const EngineGroupType engineGroupType, const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isCooperativeDispatchSupported(const EngineGroupType engineGroupType, const HardwareInfo &hwInfo) const { auto &hwInfoConfig = *HwInfoConfig::get(hwInfo.platform.eProductFamily); if (hwInfoConfig.isCooperativeEngineSupported(hwInfo)) { if (engineGroupType == EngineGroupType::RenderCompute) { @@ -48,8 +48,8 @@ bool HwHelperHw::isCooperativeDispatchSupported(const EngineGroupType en } template <> -uint32_t HwHelperHw::adjustMaxWorkGroupCount(uint32_t maxWorkGroupCount, const EngineGroupType engineGroupType, - const HardwareInfo &hwInfo, bool isEngineInstanced) const { +uint32_t GfxCoreHelperHw::adjustMaxWorkGroupCount(uint32_t maxWorkGroupCount, const EngineGroupType engineGroupType, + const HardwareInfo &hwInfo, bool isEngineInstanced) const { if ((DebugManager.flags.ForceTheoreticalMaxWorkGroupCount.get()) || (DebugManager.flags.OverrideMaxWorkGroupCount.get() != -1)) { return maxWorkGroupCount; @@ -70,12 +70,12 @@ uint32_t HwHelperHw::adjustMaxWorkGroupCount(uint32_t maxWorkGroupCount, } template <> -bool HwHelperHw::isEngineTypeRemappingToHwSpecificRequired() const { +bool GfxCoreHelperHw::isEngineTypeRemappingToHwSpecificRequired() const { return true; } template <> -size_t HwHelperHw::getPaddingForISAAllocation() const { +size_t GfxCoreHelperHw::getPaddingForISAAllocation() const { if (DebugManager.flags.ForceExtendedKernelIsaSize.get() >= 1) { return 0xE00 + (MemoryConstants::pageSize * DebugManager.flags.ForceExtendedKernelIsaSize.get()); } @@ -83,7 +83,7 @@ size_t HwHelperHw::getPaddingForISAAllocation() const { } template <> -uint32_t HwHelperHw::calculateAvailableThreadCount(const HardwareInfo &hwInfo, uint32_t grfCount) { +uint32_t GfxCoreHelperHw::calculateAvailableThreadCount(const HardwareInfo &hwInfo, uint32_t grfCount) { auto maxThreadsPerEuCount = 1024u / grfCount; return maxThreadsPerEuCount * hwInfo.gtSystemInfo.EUCount; } diff --git a/shared/source/helpers/hw_helper_tgllp_and_later.inl b/shared/source/helpers/hw_helper_tgllp_and_later.inl index a58796215c..da73da94e1 100644 --- a/shared/source/helpers/hw_helper_tgllp_and_later.inl +++ b/shared/source/helpers/hw_helper_tgllp_and_later.inl @@ -11,7 +11,7 @@ namespace NEO { template -inline bool HwHelperHw::isFusedEuDispatchEnabled(const HardwareInfo &hwInfo, bool disableEUFusionForKernel) const { +inline bool GfxCoreHelperHw::isFusedEuDispatchEnabled(const HardwareInfo &hwInfo, bool disableEUFusionForKernel) const { auto fusedEuDispatchEnabled = !hwInfo.workaroundTable.flags.waDisableFusedThreadScheduling; fusedEuDispatchEnabled &= hwInfo.capabilityTable.fusedEuEnabled; @@ -33,12 +33,12 @@ void LriHelper::program(LinearStream *cmdStream, uint32_t address, ui } template -bool HwHelperHw::packedFormatsSupported() const { +bool GfxCoreHelperHw::packedFormatsSupported() const { return true; } template -size_t HwHelperHw::getMaxFillPaternSizeForCopyEngine() const { +size_t GfxCoreHelperHw::getMaxFillPaternSizeForCopyEngine() const { return 4 * sizeof(uint32_t); } diff --git a/shared/source/helpers/hw_helper_xehp_and_later.inl b/shared/source/helpers/hw_helper_xehp_and_later.inl index c255df77b8..912956c1a7 100644 --- a/shared/source/helpers/hw_helper_xehp_and_later.inl +++ b/shared/source/helpers/hw_helper_xehp_and_later.inl @@ -19,14 +19,14 @@ namespace NEO { template -void HwHelperHw::adjustDefaultEngineType(HardwareInfo *pHwInfo) { +void GfxCoreHelperHw::adjustDefaultEngineType(HardwareInfo *pHwInfo) { if (!pHwInfo->featureTable.flags.ftrCCSNode) { pHwInfo->capabilityTable.defaultEngineType = aub_stream::ENGINE_RCS; } } template -uint32_t HwHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const { +uint32_t GfxCoreHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const { if (DebugManager.flags.OverrideNumComputeUnitsForScratch.get() != -1) { return static_cast(DebugManager.flags.OverrideNumComputeUnitsForScratch.get()); } @@ -39,37 +39,37 @@ uint32_t HwHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEn } template -inline uint32_t HwHelperHw::getGlobalTimeStampBits() const { +inline uint32_t GfxCoreHelperHw::getGlobalTimeStampBits() const { return 32; } template -bool HwHelperHw::isLocalMemoryEnabled(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isLocalMemoryEnabled(const HardwareInfo &hwInfo) const { return hwInfo.featureTable.flags.ftrLocalMemory; } template -bool HwHelperHw::hvAlign4Required() const { +bool GfxCoreHelperHw::hvAlign4Required() const { return false; } template -bool HwHelperHw::timestampPacketWriteSupported() const { +bool GfxCoreHelperHw::timestampPacketWriteSupported() const { return true; } template -bool HwHelperHw::isTimestampWaitSupportedForQueues() const { +bool GfxCoreHelperHw::isTimestampWaitSupportedForQueues() const { return false; } template -bool HwHelperHw::isUpdateTaskCountFromWaitSupported() const { +bool GfxCoreHelperHw::isUpdateTaskCountFromWaitSupported() const { return false; } template -const EngineInstancesContainer HwHelperHw::getGpgpuEngineInstances(const HardwareInfo &hwInfo) const { +const EngineInstancesContainer GfxCoreHelperHw::getGpgpuEngineInstances(const HardwareInfo &hwInfo) const { auto defaultEngine = getChosenEngineType(hwInfo); EngineInstancesContainer engines; @@ -97,7 +97,7 @@ const EngineInstancesContainer HwHelperHw::getGpgpuEngineInstances(co }; template -EngineGroupType HwHelperHw::getEngineGroupType(aub_stream::EngineType engineType, EngineUsage engineUsage, const HardwareInfo &hwInfo) const { +EngineGroupType GfxCoreHelperHw::getEngineGroupType(aub_stream::EngineType engineType, EngineUsage engineUsage, const HardwareInfo &hwInfo) const { if (engineType == aub_stream::ENGINE_RCS) { return EngineGroupType::RenderCompute; } @@ -111,7 +111,7 @@ EngineGroupType HwHelperHw::getEngineGroupType(aub_stream::EngineType } template -uint32_t HwHelperHw::getMocsIndex(const GmmHelper &gmmHelper, bool l3enabled, bool l1enabled) const { +uint32_t GfxCoreHelperHw::getMocsIndex(const GmmHelper &gmmHelper, bool l3enabled, bool l1enabled) const { if (l3enabled) { if (DebugManager.flags.ForceL1Caching.get() == 0) { if (l1enabled) { @@ -127,7 +127,7 @@ uint32_t HwHelperHw::getMocsIndex(const GmmHelper &gmmHelper, bool l3 } template -uint32_t HwHelperHw::calculateAvailableThreadCount(const HardwareInfo &hwInfo, uint32_t grfCount) { +uint32_t GfxCoreHelperHw::calculateAvailableThreadCount(const HardwareInfo &hwInfo, uint32_t grfCount) { if (grfCount > GrfConfig::DefaultGrfNumber) { return hwInfo.gtSystemInfo.ThreadCount / 2u; } @@ -135,7 +135,7 @@ uint32_t HwHelperHw::calculateAvailableThreadCount(const HardwareInfo } template -uint64_t HwHelperHw::getGpuTimeStampInNS(uint64_t timeStamp, double frequency) const { +uint64_t GfxCoreHelperHw::getGpuTimeStampInNS(uint64_t timeStamp, double frequency) const { constexpr uint64_t mask = static_cast(std::numeric_limits::max()); return static_cast((timeStamp & mask) * frequency); @@ -144,17 +144,17 @@ uint64_t HwHelperHw::getGpuTimeStampInNS(uint64_t timeStamp, double f constexpr uint32_t planarYuvMaxHeight = 16128; template -uint32_t HwHelperHw::getPlanarYuvMaxHeight() const { +uint32_t GfxCoreHelperHw::getPlanarYuvMaxHeight() const { return planarYuvMaxHeight; } template -bool HwHelperHw::isAssignEngineRoundRobinSupported(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isAssignEngineRoundRobinSupported(const HardwareInfo &hwInfo) const { return false; } template -aub_stream::MMIOList HwHelperHw::getExtraMmioList(const HardwareInfo &hwInfo, const GmmHelper &gmmHelper) const { +aub_stream::MMIOList GfxCoreHelperHw::getExtraMmioList(const HardwareInfo &hwInfo, const GmmHelper &gmmHelper) const { aub_stream::MMIOList mmioList; if (DebugManager.flags.EnableStatelessCompressionWithUnifiedMemory.get()) { @@ -182,7 +182,7 @@ bool MemorySynchronizationCommands::isBarrierWaRequired(const Hardwar } template -inline bool HwHelperHw::preferSmallWorkgroupSizeForKernel(const size_t size, const HardwareInfo &hwInfo) const { +inline bool GfxCoreHelperHw::preferSmallWorkgroupSizeForKernel(const size_t size, const HardwareInfo &hwInfo) const { if (HwInfoConfig::get(hwInfo.platform.eProductFamily)->getSteppingFromHwRevId(hwInfo) >= REVISION_B) { return false; } @@ -199,21 +199,21 @@ inline bool HwHelperHw::preferSmallWorkgroupSizeForKernel(const size_ } template -bool HwHelperHw::isScratchSpaceSurfaceStateAccessible() const { +bool GfxCoreHelperHw::isScratchSpaceSurfaceStateAccessible() const { return true; } template -uint32_t HwHelperHw::getMaxScratchSize() const { +uint32_t GfxCoreHelperHw::getMaxScratchSize() const { return 256 * KB; } template -inline bool HwHelperHw::platformSupportsImplicitScaling(const NEO::HardwareInfo &hwInfo) const { +inline bool GfxCoreHelperHw::platformSupportsImplicitScaling(const NEO::HardwareInfo &hwInfo) const { return ImplicitScalingDispatch::platformSupportsImplicitScaling(hwInfo); } template -inline bool HwHelperHw::preferInternalBcsEngine() const { +inline bool GfxCoreHelperHw::preferInternalBcsEngine() const { auto preferInternalBcsEngine = true; if (DebugManager.flags.PreferInternalBcsEngine.get() != -1) { preferInternalBcsEngine = static_cast(DebugManager.flags.PreferInternalBcsEngine.get()); @@ -223,12 +223,12 @@ inline bool HwHelperHw::preferInternalBcsEngine() const { } template -uint32_t HwHelperHw::getMinimalScratchSpaceSize() const { +uint32_t GfxCoreHelperHw::getMinimalScratchSpaceSize() const { return 64U; } template <> -bool HwHelperHw::isChipsetUniqueUUIDSupported() const { +bool GfxCoreHelperHw::isChipsetUniqueUUIDSupported() const { return true; } diff --git a/shared/source/helpers/kernel_helpers.cpp b/shared/source/helpers/kernel_helpers.cpp index 570096e780..ecb18286d9 100644 --- a/shared/source/helpers/kernel_helpers.cpp +++ b/shared/source/helpers/kernel_helpers.cpp @@ -49,8 +49,8 @@ uint32_t KernelHelper::getMaxWorkGroupCount(uint32_t simd, uint32_t availableThr } KernelHelper::ErrorCode KernelHelper::checkIfThereIsSpaceForScratchOrPrivate(KernelDescriptor::KernelAttributes attributes, Device *device) { - auto &coreHelper = device->getRootDeviceEnvironment().getHelper(); - uint32_t maxScratchSize = coreHelper.getMaxScratchSize(); + auto &gfxCoreHelper = device->getRootDeviceEnvironment().getHelper(); + uint32_t maxScratchSize = gfxCoreHelper.getMaxScratchSize(); if ((attributes.perThreadScratchSize[0] > maxScratchSize) || (attributes.perThreadScratchSize[1] > maxScratchSize)) { return KernelHelper::ErrorCode::INVALID_KERNEL; } diff --git a/shared/source/memory_manager/definitions/storage_info.cpp b/shared/source/memory_manager/definitions/storage_info.cpp index e2461f89fa..70e5bce398 100644 --- a/shared/source/memory_manager/definitions/storage_info.cpp +++ b/shared/source/memory_manager/definitions/storage_info.cpp @@ -20,7 +20,7 @@ StorageInfo MemoryManager::createStorageInfoFromProperties(const AllocationPrope return {}; } - const auto deviceCount = HwHelper::getSubDevicesCount(executionEnvironment.rootDeviceEnvironments[properties.rootDeviceIndex]->getHardwareInfo()); + const auto deviceCount = GfxCoreHelper::getSubDevicesCount(executionEnvironment.rootDeviceEnvironments[properties.rootDeviceIndex]->getHardwareInfo()); const auto leastOccupiedBank = getLocalMemoryUsageBankSelector(properties.allocationType, properties.rootDeviceIndex)->getLeastOccupiedBank(properties.subDevicesBitfield); const auto subDevicesMask = executionEnvironment.rootDeviceEnvironments[properties.rootDeviceIndex]->deviceAffinityMask.getGenericSubDevicesMask().to_ulong(); diff --git a/shared/source/memory_manager/memory_manager.cpp b/shared/source/memory_manager/memory_manager.cpp index aeb8ea0729..790c514067 100644 --- a/shared/source/memory_manager/memory_manager.cpp +++ b/shared/source/memory_manager/memory_manager.cpp @@ -50,9 +50,9 @@ MemoryManager::MemoryManager(ExecutionEnvironment &executionEnvironment) : execu for (uint32_t rootDeviceIndex = 0; rootDeviceIndex < rootEnvCount; ++rootDeviceIndex) { auto hwInfo = executionEnvironment.rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo(); - internalLocalMemoryUsageBankSelector.emplace_back(new LocalMemoryUsageBankSelector(HwHelper::getSubDevicesCount(hwInfo))); - externalLocalMemoryUsageBankSelector.emplace_back(new LocalMemoryUsageBankSelector(HwHelper::getSubDevicesCount(hwInfo))); - this->localMemorySupported.push_back(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getEnableLocalMemory(*hwInfo)); + internalLocalMemoryUsageBankSelector.emplace_back(new LocalMemoryUsageBankSelector(GfxCoreHelper::getSubDevicesCount(hwInfo))); + externalLocalMemoryUsageBankSelector.emplace_back(new LocalMemoryUsageBankSelector(GfxCoreHelper::getSubDevicesCount(hwInfo))); + this->localMemorySupported.push_back(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getEnableLocalMemory(*hwInfo)); this->enable64kbpages.push_back(OSInterface::osEnabled64kbPages && hwInfo->capabilityTable.ftr64KBpages && !!DebugManager.flags.Enable64kbpages.get()); gfxPartitions.push_back(std::make_unique(reservedCpuAddressRange)); @@ -312,7 +312,7 @@ bool MemoryManager::getAllocationData(AllocationData &allocationData, const Allo auto &rootDeviceEnvironments = *executionEnvironment.rootDeviceEnvironments[properties.rootDeviceIndex]; auto &hwInfo = *rootDeviceEnvironments.getHardwareInfo(); - auto &helper = rootDeviceEnvironments.getHelper(); + auto &helper = rootDeviceEnvironments.getHelper(); bool allow64KbPages = false; bool allow32Bit = false; diff --git a/shared/source/memory_manager/os_agnostic_memory_manager.cpp b/shared/source/memory_manager/os_agnostic_memory_manager.cpp index da2e7d54b1..518977d49b 100644 --- a/shared/source/memory_manager/os_agnostic_memory_manager.cpp +++ b/shared/source/memory_manager/os_agnostic_memory_manager.cpp @@ -109,7 +109,7 @@ GraphicsAllocation *OsAgnosticMemoryManager::allocateGraphicsMemoryWithAlignment } auto pHwInfo = executionEnvironment.rootDeviceEnvironments[allocationData.rootDeviceIndex]->getHardwareInfo(); - if (HwHelper::get(pHwInfo->platform.eRenderCoreFamily).compressedBuffersSupported(*pHwInfo) && + if (GfxCoreHelper::get(pHwInfo->platform.eRenderCoreFamily).compressedBuffersSupported(*pHwInfo) && allocationData.flags.preferCompressed) { auto gmm = std::make_unique(executionEnvironment.rootDeviceEnvironments[allocationData.rootDeviceIndex]->getGmmHelper(), allocationData.hostPtr, @@ -158,8 +158,8 @@ GraphicsAllocation *OsAgnosticMemoryManager::allocateGraphicsMemory64kb(const Al allocationDataAlign.size = alignUp(allocationData.size, MemoryConstants::pageSize64k); auto &rootDeviceEnvironment = *executionEnvironment.rootDeviceEnvironments[allocationData.rootDeviceIndex].get(); auto hwInfo = rootDeviceEnvironment.getHardwareInfo(); - auto &coreHelper = rootDeviceEnvironment.getHelper(); - allocationDataAlign.alignment = coreHelper.is1MbAlignmentSupported(*hwInfo, allocationData.flags.preferCompressed) + auto &gfxCoreHelper = rootDeviceEnvironment.getHelper(); + allocationDataAlign.alignment = gfxCoreHelper.is1MbAlignmentSupported(*hwInfo, allocationData.flags.preferCompressed) ? MemoryConstants::megaByte : MemoryConstants::pageSize64k; auto memoryAllocation = allocateGraphicsMemoryWithAlignment(allocationDataAlign); diff --git a/shared/source/os_interface/device_factory.cpp b/shared/source/os_interface/device_factory.cpp index 6c7c47aa33..e52acb7c62 100644 --- a/shared/source/os_interface/device_factory.cpp +++ b/shared/source/os_interface/device_factory.cpp @@ -89,8 +89,8 @@ bool DeviceFactory::prepareDeviceEnvironmentsForProductFamilyOverride(ExecutionE auto csrType = DebugManager.flags.SetCommandStreamReceiver.get(); if (csrType > 0) { - auto &hwHelper = HwHelper::get(hardwareInfo->platform.eRenderCoreFamily); - auto localMemoryEnabled = hwHelper.getEnableLocalMemory(*hardwareInfo); + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo->platform.eRenderCoreFamily); + auto localMemoryEnabled = gfxCoreHelper.getEnableLocalMemory(*hardwareInfo); rootDeviceEnvironment.initGmm(); rootDeviceEnvironment.initAubCenter(localMemoryEnabled, "", static_cast(csrType)); auto aubCenter = rootDeviceEnvironment.aubCenter.get(); diff --git a/shared/source/os_interface/linux/drm_command_stream.inl b/shared/source/os_interface/linux/drm_command_stream.inl index ff6929e3c5..c1edefa403 100644 --- a/shared/source/os_interface/linux/drm_command_stream.inl +++ b/shared/source/os_interface/linux/drm_command_stream.inl @@ -55,7 +55,7 @@ DrmCommandStreamReceiver::DrmCommandStreamReceiver(ExecutionEnvironme } auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - auto localMemoryEnabled = HwHelper::get(hwInfo->platform.eRenderCoreFamily).getEnableLocalMemory(*hwInfo); + auto localMemoryEnabled = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getEnableLocalMemory(*hwInfo); this->dispatchMode = localMemoryEnabled ? DispatchMode::BatchedDispatch : DispatchMode::ImmediateDispatch; diff --git a/shared/source/os_interface/linux/drm_memory_manager.cpp b/shared/source/os_interface/linux/drm_memory_manager.cpp index 1505188a5c..e155596d5b 100644 --- a/shared/source/os_interface/linux/drm_memory_manager.cpp +++ b/shared/source/os_interface/linux/drm_memory_manager.cpp @@ -220,9 +220,9 @@ void DrmMemoryManager::releaseGpuRange(void *address, size_t unmapSize, uint32_t bool DrmMemoryManager::isKmdMigrationAvailable(uint32_t rootDeviceIndex) { auto hwInfo = executionEnvironment.rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo(); - auto &hwHelper = NEO::HwHelper::get(hwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily); - auto useKmdMigration = hwHelper.isKmdMigrationSupported(*hwInfo); + auto useKmdMigration = gfxCoreHelper.isKmdMigrationSupported(*hwInfo); if (DebugManager.flags.UseKmdMigration.get() != -1) { useKmdMigration = DebugManager.flags.UseKmdMigration.get(); @@ -1277,7 +1277,7 @@ uint64_t DrmMemoryManager::getLocalMemorySize(uint32_t rootDeviceIndex, uint32_t } auto hwInfo = executionEnvironment.rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo(); - uint32_t subDevicesCount = HwHelper::getSubDevicesCount(hwInfo); + uint32_t subDevicesCount = GfxCoreHelper::getSubDevicesCount(hwInfo); size_t size = 0; for (uint32_t i = 0; i < subDevicesCount; i++) { diff --git a/shared/source/os_interface/linux/drm_memory_operations_handler_bind.cpp b/shared/source/os_interface/linux/drm_memory_operations_handler_bind.cpp index 4807b8a810..be7c5e0e7f 100644 --- a/shared/source/os_interface/linux/drm_memory_operations_handler_bind.cpp +++ b/shared/source/os_interface/linux/drm_memory_operations_handler_bind.cpp @@ -163,7 +163,7 @@ MemoryOperationsStatus DrmMemoryOperationsHandlerBind::evictUnusedAllocationsImp const auto &engines = this->rootDeviceEnvironment.executionEnvironment.memoryManager->getRegisteredEngines(); std::vector evictCandidates; - for (auto subdeviceIndex = 0u; subdeviceIndex < HwHelper::getSubDevicesCount(rootDeviceEnvironment.getHardwareInfo()); subdeviceIndex++) { + for (auto subdeviceIndex = 0u; subdeviceIndex < GfxCoreHelper::getSubDevicesCount(rootDeviceEnvironment.getHardwareInfo()); subdeviceIndex++) { for (auto &allocation : allocationsForEviction) { bool evict = true; diff --git a/shared/source/os_interface/linux/drm_neo.cpp b/shared/source/os_interface/linux/drm_neo.cpp index 5e27617c60..9271e58019 100644 --- a/shared/source/os_interface/linux/drm_neo.cpp +++ b/shared/source/os_interface/linux/drm_neo.cpp @@ -925,9 +925,9 @@ void Drm::setupSystemInfo(HardwareInfo *hwInfo, SystemInfo *sysInfo) { } void Drm::setupCacheInfo(const HardwareInfo &hwInfo) { - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); - if (DebugManager.flags.ClosEnabled.get() == 0 || hwHelper.getNumCacheRegions() == 0) { + if (DebugManager.flags.ClosEnabled.get() == 0 || gfxCoreHelper.getNumCacheRegions() == 0) { this->cacheInfo.reset(new CacheInfo(*this, 0, 0, 0)); return; } @@ -940,7 +940,7 @@ void Drm::setupCacheInfo(const HardwareInfo &hwInfo) { constexpr uint16_t maxReservationNumWays = std::min(globalReservationLimit, clientReservationLimit); const size_t totalCacheSize = gtSysInfo->L3CacheSizeInKb * MemoryConstants::kiloByte; const size_t maxReservationCacheSize = (totalCacheSize * maxReservationNumWays) / maxNumWays; - const uint32_t maxReservationNumCacheRegions = hwHelper.getNumCacheRegions() - 1; + const uint32_t maxReservationNumCacheRegions = gfxCoreHelper.getNumCacheRegions() - 1; this->cacheInfo.reset(new CacheInfo(*this, maxReservationCacheSize, maxReservationNumCacheRegions, maxReservationNumWays)); } @@ -1335,7 +1335,7 @@ uint64_t Drm::getPatIndex(Gmm *gmm, AllocationType allocationType, CacheRegion c return CommonConstants::unsupportedPatIndex; } - auto &hwHelper = HwHelper::get(hwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily); GMM_RESOURCE_INFO *resourceInfo = nullptr; GMM_RESOURCE_USAGE_TYPE usageType = CacheSettingsHelper::getGmmUsageType(allocationType, false, *hwInfo); @@ -1358,7 +1358,7 @@ uint64_t Drm::getPatIndex(Gmm *gmm, AllocationType allocationType, CacheRegion c } if (closEnabled) { - patIndex = hwHelper.getPatIndex(cacheRegion, cachePolicy); + patIndex = gfxCoreHelper.getPatIndex(cacheRegion, cachePolicy); } return patIndex; @@ -1486,7 +1486,7 @@ int Drm::createDrmVirtualMemory(uint32_t &drmVmId) { auto hwInfo = this->getRootDeviceEnvironment().getHardwareInfo(); auto memInfo = this->getMemoryInfo(); if (DebugManager.flags.UseTileMemoryBankInVirtualMemoryCreation.get() != 0) { - if (memInfo && HwHelper::get(hwInfo->platform.eRenderCoreFamily).getEnableLocalMemory(*hwInfo)) { + if (memInfo && GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getEnableLocalMemory(*hwInfo)) { regionInstanceClass = memInfo->getMemoryRegionClassAndInstance(memoryBank, *this->rootDeviceEnvironment.getHardwareInfo()); } } diff --git a/shared/source/os_interface/linux/hw_info_config_drm.cpp b/shared/source/os_interface/linux/hw_info_config_drm.cpp index e391dee497..11c98e6ba5 100644 --- a/shared/source/os_interface/linux/hw_info_config_drm.cpp +++ b/shared/source/os_interface/linux/hw_info_config_drm.cpp @@ -141,10 +141,10 @@ int HwInfoConfig::configureHwInfoDrm(const HardwareInfo *inHwInfo, HardwareInfo outHwInfo->capabilityTable.maxRenderFrequency = maxGpuFreq; outHwInfo->capabilityTable.ftrSvm = featureTable->flags.ftrSVM; - HwHelper &hwHelper = HwHelper::get(platform->eRenderCoreFamily); + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(platform->eRenderCoreFamily); outHwInfo->capabilityTable.ftrSupportsCoherency = false; - hwHelper.adjustDefaultEngineType(outHwInfo); + gfxCoreHelper.adjustDefaultEngineType(outHwInfo); outHwInfo->capabilityTable.defaultEngineType = getChosenEngineType(*outHwInfo); drm->checkQueueSliceSupport(); @@ -158,7 +158,7 @@ int HwInfoConfig::configureHwInfoDrm(const HardwareInfo *inHwInfo, HardwareInfo static_cast(outHwInfo->featureTable.flags.ftrGpGpuMidBatchPreempt) && preemption); outHwInfo->capabilityTable.requiredPreemptionSurfaceSize = outHwInfo->gtSystemInfo.CsrSizeInMb * MemoryConstants::megaByte; - hwHelper.adjustPreemptionSurfaceSize(outHwInfo->capabilityTable.requiredPreemptionSurfaceSize); + gfxCoreHelper.adjustPreemptionSurfaceSize(outHwInfo->capabilityTable.requiredPreemptionSurfaceSize); auto &kmdNotifyProperties = outHwInfo->capabilityTable.kmdNotifyProperties; KmdNotifyHelper::overrideFromDebugVariable(DebugManager.flags.OverrideEnableKmdNotify.get(), kmdNotifyProperties.enableKmdNotify); diff --git a/shared/source/os_interface/linux/ioctl_helper_prelim.cpp b/shared/source/os_interface/linux/ioctl_helper_prelim.cpp index 4116d550ae..8fcdb937f1 100644 --- a/shared/source/os_interface/linux/ioctl_helper_prelim.cpp +++ b/shared/source/os_interface/linux/ioctl_helper_prelim.cpp @@ -31,8 +31,8 @@ namespace NEO { IoctlHelperPrelim20::IoctlHelperPrelim20(Drm &drmArg) : IoctlHelper(drmArg) { - auto hwHelper = HwInfoConfig::get(this->drm.getRootDeviceEnvironment().getHardwareInfo()->platform.eProductFamily); - handleExecBufferInNonBlockMode = hwHelper && hwHelper->isNonBlockingGpuSubmissionSupported(); + auto gfxCoreHelper = HwInfoConfig::get(this->drm.getRootDeviceEnvironment().getHardwareInfo()->platform.eProductFamily); + handleExecBufferInNonBlockMode = gfxCoreHelper && gfxCoreHelper->isNonBlockingGpuSubmissionSupported(); if (DebugManager.flags.ForceNonblockingExecbufferCalls.get() != -1) { handleExecBufferInNonBlockMode = DebugManager.flags.ForceNonblockingExecbufferCalls.get(); } diff --git a/shared/source/os_interface/linux/memory_info.cpp b/shared/source/os_interface/linux/memory_info.cpp index 536512f740..8f512efadc 100644 --- a/shared/source/os_interface/linux/memory_info.cpp +++ b/shared/source/os_interface/linux/memory_info.cpp @@ -61,9 +61,9 @@ uint32_t MemoryInfo::createGemExt(const MemRegionsVec &memClassInstances, size_t } uint32_t MemoryInfo::getTileIndex(uint32_t memoryBank, const HardwareInfo &hwInfo) { - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto tileIndex = Math::log2(memoryBank); - tileIndex = hwHelper.isBankOverrideRequired(hwInfo) ? 0 : tileIndex; + tileIndex = gfxCoreHelper.isBankOverrideRequired(hwInfo) ? 0 : tileIndex; if (DebugManager.flags.OverrideDrmRegion.get() != -1) { tileIndex = DebugManager.flags.OverrideDrmRegion.get(); } @@ -71,8 +71,8 @@ uint32_t MemoryInfo::getTileIndex(uint32_t memoryBank, const HardwareInfo &hwInf } MemoryClassInstance MemoryInfo::getMemoryRegionClassAndInstance(uint32_t memoryBank, const HardwareInfo &hwInfo) { - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - if (!hwHelper.getEnableLocalMemory(hwInfo) || memoryBank == 0) { + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + if (!gfxCoreHelper.getEnableLocalMemory(hwInfo) || memoryBank == 0) { return systemMemoryRegion.region; } diff --git a/shared/source/os_interface/linux/performance_counters_linux.cpp b/shared/source/os_interface/linux/performance_counters_linux.cpp index 0337383546..f1f3db681a 100644 --- a/shared/source/os_interface/linux/performance_counters_linux.cpp +++ b/shared/source/os_interface/linux/performance_counters_linux.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2018-2021 Intel Corporation + * Copyright (C) 2018-2022 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -21,7 +21,7 @@ std::unique_ptr PerformanceCounters::create(Device *device) auto counter = std::make_unique(); auto drm = device->getOSTime()->getOSInterface()->getDriverModel()->as(); auto gen = device->getHardwareInfo().platform.eRenderCoreFamily; - auto &hwHelper = HwHelper::get(gen); + auto &gfxCoreHelper = GfxCoreHelper::get(gen); UNRECOVERABLE_IF(counter == nullptr); if (!device->isSubDevice()) { @@ -44,7 +44,7 @@ std::unique_ptr PerformanceCounters::create(Device *device) counter->clientData.Linux.Adapter = &(counter->adapter); // Gen data. - counter->clientType.Gen = static_cast(hwHelper.getMetricsLibraryGenId()); + counter->clientType.Gen = static_cast(gfxCoreHelper.getMetricsLibraryGenId()); return counter; } diff --git a/shared/source/os_interface/windows/device_time_wddm.cpp b/shared/source/os_interface/windows/device_time_wddm.cpp index a11e97f167..89a373316c 100644 --- a/shared/source/os_interface/windows/device_time_wddm.cpp +++ b/shared/source/os_interface/windows/device_time_wddm.cpp @@ -72,8 +72,8 @@ uint64_t DeviceTimeWddm::getDynamicDeviceTimerClock(HardwareInfo const &hwInfo) } void DeviceTimeWddm::convertTimestampsFromOaToCsDomain(HardwareInfo const &hwInfo, uint64_t ×tampData, uint64_t freqOA, uint64_t freqCS) { - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - if (hwHelper.isTimestampShiftRequired() && freqCS > 0 && freqOA > 0) { + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + if (gfxCoreHelper.isTimestampShiftRequired() && freqCS > 0 && freqOA > 0) { auto freqRatio = static_cast(freqOA) / static_cast(freqCS); timestampData = static_cast(timestampData / freqRatio); } diff --git a/shared/source/os_interface/windows/hw_info_config_wddm.cpp b/shared/source/os_interface/windows/hw_info_config_wddm.cpp index c37644e096..fb5a144abe 100644 --- a/shared/source/os_interface/windows/hw_info_config_wddm.cpp +++ b/shared/source/os_interface/windows/hw_info_config_wddm.cpp @@ -19,12 +19,12 @@ namespace NEO { int HwInfoConfig::configureHwInfoWddm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironemnt) { - auto &coreHelper = rootDeviceEnvironemnt.getHelper(); + auto &gfxCoreHelper = rootDeviceEnvironemnt.getHelper(); auto &productHelper = rootDeviceEnvironemnt.getHelper(); auto compilerProductHelper = CompilerProductHelper::get(outHwInfo->platform.eProductFamily); outHwInfo->capabilityTable.ftrSvm = outHwInfo->featureTable.flags.ftrSVM; - coreHelper.adjustDefaultEngineType(outHwInfo); + gfxCoreHelper.adjustDefaultEngineType(outHwInfo); outHwInfo->capabilityTable.defaultEngineType = getChosenEngineType(*outHwInfo); productHelper.setCapabilityCoherencyFlag(*outHwInfo, outHwInfo->capabilityTable.ftrSupportsCoherency); @@ -39,7 +39,7 @@ int HwInfoConfig::configureHwInfoWddm(const HardwareInfo *inHwInfo, HardwareInfo outHwInfo->gtSystemInfo.CsrSizeInMb = static_cast(DebugManager.flags.OverridePreemptionSurfaceSizeInMb.get()); } outHwInfo->capabilityTable.requiredPreemptionSurfaceSize = outHwInfo->gtSystemInfo.CsrSizeInMb * MemoryConstants::megaByte; - coreHelper.adjustPreemptionSurfaceSize(outHwInfo->capabilityTable.requiredPreemptionSurfaceSize); + gfxCoreHelper.adjustPreemptionSurfaceSize(outHwInfo->capabilityTable.requiredPreemptionSurfaceSize); auto &kmdNotifyProperties = outHwInfo->capabilityTable.kmdNotifyProperties; KmdNotifyHelper::overrideFromDebugVariable(DebugManager.flags.OverrideEnableKmdNotify.get(), kmdNotifyProperties.enableKmdNotify); diff --git a/shared/source/os_interface/windows/performance_counters_win.cpp b/shared/source/os_interface/windows/performance_counters_win.cpp index 4377ee768b..bcf94d7983 100644 --- a/shared/source/os_interface/windows/performance_counters_win.cpp +++ b/shared/source/os_interface/windows/performance_counters_win.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2018-2021 Intel Corporation + * Copyright (C) 2018-2022 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -21,7 +21,7 @@ std::unique_ptr PerformanceCounters::create(Device *device) auto counter = std::make_unique(); auto wddm = device->getOSTime()->getOSInterface()->getDriverModel()->as(); auto gen = device->getHardwareInfo().platform.eRenderCoreFamily; - auto &hwHelper = HwHelper::get(gen); + auto &gfxCoreHelper = GfxCoreHelper::get(gen); UNRECOVERABLE_IF(counter == nullptr); counter->clientData.Windows.Adapter = reinterpret_cast(static_cast(wddm->getAdapter())); @@ -29,7 +29,7 @@ std::unique_ptr PerformanceCounters::create(Device *device) counter->clientData.Windows.Escape = wddm->getEscapeHandle(); counter->clientData.Windows.KmdInstrumentationEnabled = device->getHardwareInfo().capabilityTable.instrumentationEnabled; counter->contextData.ClientData = &counter->clientData; - counter->clientType.Gen = static_cast(hwHelper.getMetricsLibraryGenId()); + counter->clientType.Gen = static_cast(gfxCoreHelper.getMetricsLibraryGenId()); return counter; } diff --git a/shared/source/os_interface/windows/wddm/wddm.cpp b/shared/source/os_interface/windows/wddm/wddm.cpp index 4ede83c116..65f62ad3ee 100644 --- a/shared/source/os_interface/windows/wddm/wddm.cpp +++ b/shared/source/os_interface/windows/wddm/wddm.cpp @@ -171,7 +171,7 @@ bool Wddm::translateTopologyInfo(TopologyMapping &mapping) { auto gtSystemInfo = rootDeviceEnvironment.getHardwareInfo()->gtSystemInfo; sliceIndices.reserve(gtSystemInfo.SliceCount); auto hwInfo = rootDeviceEnvironment.getHardwareInfo(); - const uint32_t highestEnabledSlice = NEO::HwHelper::getHighestEnabledSlice(*hwInfo); + const uint32_t highestEnabledSlice = NEO::GfxCoreHelper::getHighestEnabledSlice(*hwInfo); for (uint32_t x = 0; x < std::max(highestEnabledSlice, hwInfo->gtSystemInfo.MaxSlicesSupported); x++) { if (!gtSystemInfo.SliceInfo[x].Enabled) { diff --git a/shared/source/os_interface/windows/wddm_memory_manager.cpp b/shared/source/os_interface/windows/wddm_memory_manager.cpp index 13a335a56e..21c5c9868e 100644 --- a/shared/source/os_interface/windows/wddm_memory_manager.cpp +++ b/shared/source/os_interface/windows/wddm_memory_manager.cpp @@ -1172,7 +1172,7 @@ bool WddmMemoryManager::mapGpuVirtualAddress(WddmAllocation *allocation, const v uint64_t WddmMemoryManager::getLocalMemorySize(uint32_t rootDeviceIndex, uint32_t deviceBitfield) { auto hwInfo = executionEnvironment.rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo(); - uint64_t subDevicesCount = HwHelper::getSubDevicesCount(hwInfo); + uint64_t subDevicesCount = GfxCoreHelper::getSubDevicesCount(hwInfo); auto singleRegionSize = getWddm(rootDeviceIndex).getDedicatedVideoMemory() / subDevicesCount; diff --git a/shared/source/program/kernel_info.cpp b/shared/source/program/kernel_info.cpp index f4a173155f..9ca4b728eb 100644 --- a/shared/source/program/kernel_info.cpp +++ b/shared/source/program/kernel_info.cpp @@ -70,8 +70,8 @@ void WorkSizeInfo::setMinWorkGroupSize(const HardwareInfo *hwInfo, bool disableE minWorkGroupSize = std::max(maxWorkGroupSize / ((localMemSize / slmTotalSize)), minWorkGroupSize); } - const auto &hwHelper = HwHelper::get(hwInfo->platform.eRenderCoreFamily); - if (hwHelper.isFusedEuDispatchEnabled(*hwInfo, disableEUFusion)) { + const auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily); + if (gfxCoreHelper.isFusedEuDispatchEnabled(*hwInfo, disableEUFusion)) { minWorkGroupSize *= 2; } } @@ -96,7 +96,7 @@ size_t KernelInfo::getSamplerStateArrayCount() const { return kernelDescriptor.payloadMappings.samplerTable.numSamplers; } size_t KernelInfo::getSamplerStateArraySize(const HardwareInfo &hwInfo) const { - size_t samplerStateArraySize = getSamplerStateArrayCount() * HwHelper::get(hwInfo.platform.eRenderCoreFamily).getSamplerStateSize(); + size_t samplerStateArraySize = getSamplerStateArrayCount() * GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getSamplerStateSize(); return samplerStateArraySize; } diff --git a/shared/source/xe_hp_core/command_stream_receiver_hw_xe_hp_core.cpp b/shared/source/xe_hp_core/command_stream_receiver_hw_xe_hp_core.cpp index 3ff558a448..330650aa7e 100644 --- a/shared/source/xe_hp_core/command_stream_receiver_hw_xe_hp_core.cpp +++ b/shared/source/xe_hp_core/command_stream_receiver_hw_xe_hp_core.cpp @@ -97,10 +97,10 @@ void BlitCommandsHelper::appendExtraMemoryProperties(typename Family::XY using XY_BLOCK_COPY_BLT = typename Family::XY_BLOCK_COPY_BLT; auto hwInfo = rootDeviceEnvironment.getHardwareInfo(); - auto &hwHelper = HwHelperHw::get(); + auto &gfxCoreHelper = GfxCoreHelperHw::get(); const auto &hwInfoConfig = *HwInfoConfig::get(hwInfo->platform.eProductFamily); - if (hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, *hwInfo) && + if (gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, *hwInfo) && hwInfoConfig.getLocalMemoryAccessMode(*hwInfo) == LocalMemoryAccessMode::CpuAccessAllowed) { blitCmd.setSourceTargetMemory(XY_BLOCK_COPY_BLT::TARGET_MEMORY::TARGET_MEMORY_SYSTEM_MEM); blitCmd.setDestinationTargetMemory(XY_BLOCK_COPY_BLT::TARGET_MEMORY::TARGET_MEMORY_SYSTEM_MEM); @@ -112,10 +112,10 @@ void BlitCommandsHelper::appendExtraMemoryProperties(typename Family::XY using XY_COLOR_BLT = typename Family::XY_COLOR_BLT; auto hwInfo = rootDeviceEnvironment.getHardwareInfo(); - auto &hwHelper = HwHelperHw::get(); + auto &gfxCoreHelper = GfxCoreHelperHw::get(); const auto &hwInfoConfig = *HwInfoConfig::get(hwInfo->platform.eProductFamily); - if (hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, *hwInfo) && + if (gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, *hwInfo) && hwInfoConfig.getLocalMemoryAccessMode(*hwInfo) == LocalMemoryAccessMode::CpuAccessAllowed) { blitCmd.setDestinationTargetMemory(XY_COLOR_BLT::DESTINATION_TARGET_MEMORY::DESTINATION_TARGET_MEMORY_SYSTEM_MEM); } diff --git a/shared/source/xe_hp_core/enable_family_full_core_xe_hp_core.cpp b/shared/source/xe_hp_core/enable_family_full_core_xe_hp_core.cpp index 3e3aefd097..d880b529ad 100644 --- a/shared/source/xe_hp_core/enable_family_full_core_xe_hp_core.cpp +++ b/shared/source/xe_hp_core/enable_family_full_core_xe_hp_core.cpp @@ -15,14 +15,14 @@ namespace NEO { -extern HwHelper *hwHelperFactory[IGFX_MAX_CORE]; +extern GfxCoreHelper *gfxCoreHelperFactory[IGFX_MAX_CORE]; using Family = XeHpFamily; static auto gfxFamily = IGFX_XE_HP_CORE; struct EnableCoreXeHpCore { EnableCoreXeHpCore() { - hwHelperFactory[gfxFamily] = &HwHelperHw::get(); + gfxCoreHelperFactory[gfxFamily] = &GfxCoreHelperHw::get(); populateFactoryTable>(); populateFactoryTable>(); populateFactoryTable>(); diff --git a/shared/source/xe_hp_core/hw_helper_xe_hp_core.cpp b/shared/source/xe_hp_core/hw_helper_xe_hp_core.cpp index 9962a9245c..1facf81827 100644 --- a/shared/source/xe_hp_core/hw_helper_xe_hp_core.cpp +++ b/shared/source/xe_hp_core/hw_helper_xe_hp_core.cpp @@ -22,15 +22,15 @@ using Family = NEO::XeHpFamily; namespace NEO { template <> -const AuxTranslationMode HwHelperHw::defaultAuxTranslationMode = AuxTranslationMode::Blit; +const AuxTranslationMode GfxCoreHelperHw::defaultAuxTranslationMode = AuxTranslationMode::Blit; template <> -uint32_t HwHelperHw::getMetricsLibraryGenId() const { +uint32_t GfxCoreHelperHw::getMetricsLibraryGenId() const { return static_cast(MetricsLibraryApi::ClientGen::XeHP); } template <> -uint32_t HwHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const { +uint32_t GfxCoreHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const { if (DebugManager.flags.OverrideNumComputeUnitsForScratch.get() != -1) { return static_cast(DebugManager.flags.OverrideNumComputeUnitsForScratch.get()); } @@ -41,7 +41,7 @@ uint32_t HwHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvir } template <> -uint32_t HwHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32_t slmSize) { +uint32_t GfxCoreHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32_t slmSize) { using SHARED_LOCAL_MEMORY_SIZE = typename Family::INTERFACE_DESCRIPTOR_DATA::SHARED_LOCAL_MEMORY_SIZE; auto slmValue = std::max(slmSize, 1024u); @@ -55,13 +55,13 @@ uint32_t HwHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32 } template <> -void HwHelperHw::setL1CachePolicy(bool useL1Cache, typename Family::RENDER_SURFACE_STATE *surfaceState, const HardwareInfo *hwInfo) { +void GfxCoreHelperHw::setL1CachePolicy(bool useL1Cache, typename Family::RENDER_SURFACE_STATE *surfaceState, const HardwareInfo *hwInfo) { } template <> -bool HwHelperHw::isBankOverrideRequired(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isBankOverrideRequired(const HardwareInfo &hwInfo) const { - bool forceOverrideMemoryBankIndex = (HwHelper::getSubDevicesCount(&hwInfo) == 4 && + bool forceOverrideMemoryBankIndex = (GfxCoreHelper::getSubDevicesCount(&hwInfo) == 4 && isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo)); if (DebugManager.flags.ForceMemoryBankIndexOverride.get() != -1) { @@ -71,12 +71,12 @@ bool HwHelperHw::isBankOverrideRequired(const HardwareInfo &hwInfo) cons } template <> -bool HwHelperHw::isSipWANeeded(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isSipWANeeded(const HardwareInfo &hwInfo) const { return hwInfo.platform.usRevId <= HwInfoConfig::get(hwInfo.platform.eProductFamily)->getHwRevIdFromStepping(REVISION_B, hwInfo); } template <> -bool HwHelperHw::isBufferSizeSuitableForCompression(const size_t size, const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isBufferSizeSuitableForCompression(const size_t size, const HardwareInfo &hwInfo) const { if (DebugManager.flags.OverrideBufferSuitableForRenderCompression.get() != -1) { return !!DebugManager.flags.OverrideBufferSuitableForRenderCompression.get(); } @@ -88,12 +88,12 @@ bool HwHelperHw::isBufferSizeSuitableForCompression(const size_t size, c } template <> -const StackVec HwHelperHw::getThreadsPerEUConfigs() const { +const StackVec GfxCoreHelperHw::getThreadsPerEUConfigs() const { return {4, 8}; } template <> -std::string HwHelperHw::getExtensions(const HardwareInfo &hwInfo) const { +std::string GfxCoreHelperHw::getExtensions(const HardwareInfo &hwInfo) const { std::string extensions; extensions += "cl_intel_dot_accumulate "; extensions += "cl_intel_subgroup_local_block_io "; @@ -143,16 +143,16 @@ void MemorySynchronizationCommands::setCacheFlushExtraProperties(PipeCon } template <> -bool HwHelperHw::unTypedDataPortCacheFlushRequired() const { +bool GfxCoreHelperHw::unTypedDataPortCacheFlushRequired() const { return false; } template <> -bool HwHelperHw::disableL3CacheForDebug(const HardwareInfo &) const { +bool GfxCoreHelperHw::disableL3CacheForDebug(const HardwareInfo &) const { return true; } -template class HwHelperHw; +template class GfxCoreHelperHw; template class FlatBatchBufferHelperHw; template struct MemorySynchronizationCommands; template struct LriHelper; diff --git a/shared/source/xe_hp_core/linux/hw_info_config_xe_hp_sdv.cpp b/shared/source/xe_hp_core/linux/hw_info_config_xe_hp_sdv.cpp index a083d3cc85..5ed2f26da6 100644 --- a/shared/source/xe_hp_core/linux/hw_info_config_xe_hp_sdv.cpp +++ b/shared/source/xe_hp_core/linux/hw_info_config_xe_hp_sdv.cpp @@ -56,8 +56,8 @@ int HwInfoConfigHw::configureHardwareCustom(HardwareInfo *hwInfo, OS template <> bool HwInfoConfigHw::getHostMemCapabilitiesSupported(const HardwareInfo *hwInfo) { - HwHelper &hwHelper = HwHelper::get(hwInfo->platform.eRenderCoreFamily); - if (hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, *hwInfo) && (getLocalMemoryAccessMode(*hwInfo) == LocalMemoryAccessMode::CpuAccessAllowed)) { + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily); + if (gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, *hwInfo) && (getLocalMemoryAccessMode(*hwInfo) == LocalMemoryAccessMode::CpuAccessAllowed)) { return false; } diff --git a/shared/source/xe_hp_core/os_agnostic_hw_info_config_xe_hp_core.inl b/shared/source/xe_hp_core/os_agnostic_hw_info_config_xe_hp_core.inl index 77202318f5..f6e23fc5e5 100644 --- a/shared/source/xe_hp_core/os_agnostic_hw_info_config_xe_hp_core.inl +++ b/shared/source/xe_hp_core/os_agnostic_hw_info_config_xe_hp_core.inl @@ -92,7 +92,7 @@ bool HwInfoConfigHw::allowStatelessCompression(const HardwareInfo &h if (!hwInfo.capabilityTable.ftrRenderCompressedBuffers) { return false; } - if (HwHelper::getSubDevicesCount(&hwInfo) > 1) { + if (GfxCoreHelper::getSubDevicesCount(&hwInfo) > 1) { return DebugManager.flags.EnableMultiTileCompression.get() > 0 ? true : false; } if (hwInfo.platform.usRevId < getHwRevIdFromStepping(REVISION_B, hwInfo)) { @@ -103,7 +103,7 @@ bool HwInfoConfigHw::allowStatelessCompression(const HardwareInfo &h template <> LocalMemoryAccessMode HwInfoConfigHw::getDefaultLocalMemoryAccessMode(const HardwareInfo &hwInfo) const { - if (HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo)) { + if (GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo)) { return LocalMemoryAccessMode::CpuAccessDisallowed; } return LocalMemoryAccessMode::Default; @@ -123,12 +123,12 @@ std::pair HwInfoConfigHw::isPipeControlPriorToNonPipelin template <> bool HwInfoConfigHw::heapInLocalMem(const HardwareInfo &hwInfo) const { - return !HwHelper::get(hwInfo.platform.eDisplayCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); + return !GfxCoreHelper::get(hwInfo.platform.eDisplayCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> bool HwInfoConfigHw::extraParametersInvalid(const HardwareInfo &hwInfo) const { - return HwHelper::get(hwInfo.platform.eDisplayCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); + return GfxCoreHelper::get(hwInfo.platform.eDisplayCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> diff --git a/shared/source/xe_hp_core/preamble_xe_hp_core.cpp b/shared/source/xe_hp_core/preamble_xe_hp_core.cpp index 5496aebe0d..da47569a17 100644 --- a/shared/source/xe_hp_core/preamble_xe_hp_core.cpp +++ b/shared/source/xe_hp_core/preamble_xe_hp_core.cpp @@ -35,8 +35,8 @@ void PreambleHelper::appendProgramVFEState(const HardwareInfo &hwInfo, c command->setSingleSliceDispatchCcsMode(DebugManager.flags.CFESingleSliceDispatchCCSMode.get()); } - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - if (!hwHelper.isFusedEuDispatchEnabled(hwInfo, false)) { + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + if (!gfxCoreHelper.isFusedEuDispatchEnabled(hwInfo, false)) { command->setFusedEuDispatch(true); } diff --git a/shared/source/xe_hp_core/windows/hw_info_config_xe_hp_sdv.cpp b/shared/source/xe_hp_core/windows/hw_info_config_xe_hp_sdv.cpp index 684bac623c..af0cc1ce00 100644 --- a/shared/source/xe_hp_core/windows/hw_info_config_xe_hp_sdv.cpp +++ b/shared/source/xe_hp_core/windows/hw_info_config_xe_hp_sdv.cpp @@ -34,8 +34,8 @@ int HwInfoConfigHw::configureHardwareCustom(HardwareInfo *hwInfo, OS template <> bool HwInfoConfigHw::getHostMemCapabilitiesSupported(const HardwareInfo *hwInfo) { - HwHelper &hwHelper = HwHelper::get(hwInfo->platform.eRenderCoreFamily); - if (hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, *hwInfo) && (getLocalMemoryAccessMode(*hwInfo) == LocalMemoryAccessMode::CpuAccessAllowed)) { + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily); + if (gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, *hwInfo) && (getLocalMemoryAccessMode(*hwInfo) == LocalMemoryAccessMode::CpuAccessAllowed)) { return false; } diff --git a/shared/source/xe_hpc_core/command_encoder_xe_hpc_core.cpp b/shared/source/xe_hpc_core/command_encoder_xe_hpc_core.cpp index 9257089b2a..a187f87cb1 100644 --- a/shared/source/xe_hpc_core/command_encoder_xe_hpc_core.cpp +++ b/shared/source/xe_hpc_core/command_encoder_xe_hpc_core.cpp @@ -45,8 +45,8 @@ void EncodeDispatchKernel::adjustInterfaceDescriptorData(INTERFACE_DESCR constexpr uint32_t maxThreadsInTGForTGDispatchSize8 = 16u; constexpr uint32_t maxThreadsInTGForTGDispatchSize4 = 32u; - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - uint32_t availableThreadCount = hwHelper.calculateAvailableThreadCount(hwInfo, numGrf); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + uint32_t availableThreadCount = gfxCoreHelper.calculateAvailableThreadCount(hwInfo, numGrf); if (ImplicitScalingHelper::isImplicitScalingEnabled(device.getDeviceBitfield(), true)) { const uint32_t tilesCount = device.getNumSubDevices(); availableThreadCount *= tilesCount; @@ -256,7 +256,7 @@ void EncodeDispatchKernel::appendAdditionalIDDFields(INTERFACE_DESCRIPTO const uint32_t threadsPerDssCount = hwInfo.gtSystemInfo.ThreadCount / hwInfo.gtSystemInfo.DualSubSliceCount; const uint32_t workGroupCountPerDss = static_cast(Math::divideAndRoundUp(threadsPerDssCount, threadsPerThreadGroup)); - const uint32_t workgroupSlmSize = HwHelperHw::get().alignSlmSize(slmTotalSize); + const uint32_t workgroupSlmSize = GfxCoreHelperHw::get().alignSlmSize(slmTotalSize); uint32_t slmSize = 0u; diff --git a/shared/source/xe_hpc_core/enable_family_full_core_xe_hpc_core.cpp b/shared/source/xe_hpc_core/enable_family_full_core_xe_hpc_core.cpp index 93cc71da6b..c3222c843e 100644 --- a/shared/source/xe_hpc_core/enable_family_full_core_xe_hpc_core.cpp +++ b/shared/source/xe_hpc_core/enable_family_full_core_xe_hpc_core.cpp @@ -15,14 +15,14 @@ namespace NEO { -extern HwHelper *hwHelperFactory[IGFX_MAX_CORE]; +extern GfxCoreHelper *gfxCoreHelperFactory[IGFX_MAX_CORE]; using Family = XeHpcCoreFamily; static auto gfxFamily = IGFX_XE_HPC_CORE; struct EnableCoreXeHpcCore { EnableCoreXeHpcCore() { - hwHelperFactory[gfxFamily] = &HwHelperHw::get(); + gfxCoreHelperFactory[gfxFamily] = &GfxCoreHelperHw::get(); populateFactoryTable>(); populateFactoryTable>(); populateFactoryTable>(); diff --git a/shared/source/xe_hpc_core/hw_helper_xe_hpc_core.cpp b/shared/source/xe_hpc_core/hw_helper_xe_hpc_core.cpp index b0f94d391e..c0603844c1 100644 --- a/shared/source/xe_hpc_core/hw_helper_xe_hpc_core.cpp +++ b/shared/source/xe_hpc_core/hw_helper_xe_hpc_core.cpp @@ -22,10 +22,10 @@ using Family = NEO::XeHpcCoreFamily; namespace NEO { template <> -const AuxTranslationMode HwHelperHw::defaultAuxTranslationMode = AuxTranslationMode::Blit; +const AuxTranslationMode GfxCoreHelperHw::defaultAuxTranslationMode = AuxTranslationMode::Blit; template <> -uint8_t HwHelperHw::getBarriersCountFromHasBarriers(uint8_t hasBarriers) const { +uint8_t GfxCoreHelperHw::getBarriersCountFromHasBarriers(uint8_t hasBarriers) const { static constexpr uint8_t possibleBarriersCounts[] = { 0u, // 0 1u, // 1 @@ -40,7 +40,7 @@ uint8_t HwHelperHw::getBarriersCountFromHasBarriers(uint8_t hasBarriers) } template <> -const EngineInstancesContainer HwHelperHw::getGpgpuEngineInstances(const HardwareInfo &hwInfo) const { +const EngineInstancesContainer GfxCoreHelperHw::getGpgpuEngineInstances(const HardwareInfo &hwInfo) const { auto defaultEngine = getChosenEngineType(hwInfo); auto &hwInfoConfig = *HwInfoConfig::get(hwInfo.platform.eProductFamily); @@ -88,7 +88,7 @@ const EngineInstancesContainer HwHelperHw::getGpgpuEngineInstances(const }; template <> -EngineGroupType HwHelperHw::getEngineGroupType(aub_stream::EngineType engineType, EngineUsage engineUsage, const HardwareInfo &hwInfo) const { +EngineGroupType GfxCoreHelperHw::getEngineGroupType(aub_stream::EngineType engineType, EngineUsage engineUsage, const HardwareInfo &hwInfo) const { if (engineType == aub_stream::ENGINE_CCCS) { return EngineGroupType::RenderCompute; } @@ -108,29 +108,29 @@ EngineGroupType HwHelperHw::getEngineGroupType(aub_stream::EngineType en } template <> -void HwHelperHw::adjustDefaultEngineType(HardwareInfo *pHwInfo) { +void GfxCoreHelperHw::adjustDefaultEngineType(HardwareInfo *pHwInfo) { if (!pHwInfo->featureTable.flags.ftrCCSNode) { pHwInfo->capabilityTable.defaultEngineType = aub_stream::EngineType::ENGINE_CCCS; } } template <> -bool HwHelperHw::isLinearStoragePreferred(bool isSharedContext, bool isImage1d, bool forceLinearStorage) { +bool GfxCoreHelperHw::isLinearStoragePreferred(bool isSharedContext, bool isImage1d, bool forceLinearStorage) { return true; } template <> -uint32_t HwHelperHw::getMetricsLibraryGenId() const { +uint32_t GfxCoreHelperHw::getMetricsLibraryGenId() const { return static_cast(MetricsLibraryApi::ClientGen::XeHPC); } template <> -uint32_t HwHelperHw::getMinimalSIMDSize() { +uint32_t GfxCoreHelperHw::getMinimalSIMDSize() { return 16u; } template <> -uint32_t HwHelperHw::getMocsIndex(const GmmHelper &gmmHelper, bool l3enabled, bool l1enabled) const { +uint32_t GfxCoreHelperHw::getMocsIndex(const GmmHelper &gmmHelper, bool l3enabled, bool l1enabled) const { if (l3enabled) { return gmmHelper.getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER) >> 1; } @@ -138,17 +138,17 @@ uint32_t HwHelperHw::getMocsIndex(const GmmHelper &gmmHelper, bool l3ena } template <> -const StackVec HwHelperHw::getDeviceSubGroupSizes() const { +const StackVec GfxCoreHelperHw::getDeviceSubGroupSizes() const { return {16, 32}; } template <> -const StackVec HwHelperHw::getThreadsPerEUConfigs() const { +const StackVec GfxCoreHelperHw::getThreadsPerEUConfigs() const { return {4, 8}; } template <> -uint32_t HwHelperHw::getMaxNumSamplers() const { +uint32_t GfxCoreHelperHw::getMaxNumSamplers() const { return 0; } @@ -210,7 +210,7 @@ size_t MemorySynchronizationCommands::getSizeForAdditonalSynchronization } template <> -void HwHelperHw::setL1CachePolicy(bool useL1Cache, typename Family::RENDER_SURFACE_STATE *surfaceState, const HardwareInfo *hwInfo) { +void GfxCoreHelperHw::setL1CachePolicy(bool useL1Cache, typename Family::RENDER_SURFACE_STATE *surfaceState, const HardwareInfo *hwInfo) { if (useL1Cache) { surfaceState->setL1CachePolicyL1CacheControl(Family::RENDER_SURFACE_STATE::L1_CACHE_POLICY_WB); if (DebugManager.flags.OverrideL1CacheControlInSurfaceStateForScratchSpace.get() != -1) { @@ -220,7 +220,7 @@ void HwHelperHw::setL1CachePolicy(bool useL1Cache, typename Family::REND } template <> -void HwHelperHw::setExtraAllocationData(AllocationData &allocationData, const AllocationProperties &properties, const HardwareInfo &hwInfo) const { +void GfxCoreHelperHw::setExtraAllocationData(AllocationData &allocationData, const AllocationProperties &properties, const HardwareInfo &hwInfo) const { if (properties.allocationType == AllocationType::TIMESTAMP_PACKET_TAG_BUFFER || properties.allocationType == AllocationType::COMMAND_BUFFER) { allocationData.flags.useSystemMemory = false; } @@ -260,7 +260,7 @@ void HwHelperHw::setExtraAllocationData(AllocationData &allocationData, } template <> -uint32_t HwHelperHw::getNumCacheRegions() const { +uint32_t GfxCoreHelperHw::getNumCacheRegions() const { constexpr uint32_t numSharedCacheRegions = 1; constexpr uint32_t numReservedCacheRegions = 2; constexpr uint32_t numTotalCacheRegions = numSharedCacheRegions + numReservedCacheRegions; @@ -268,7 +268,7 @@ uint32_t HwHelperHw::getNumCacheRegions() const { } template <> -std::string HwHelperHw::getExtensions(const HardwareInfo &hwInfo) const { +std::string GfxCoreHelperHw::getExtensions(const HardwareInfo &hwInfo) const { std::string extensions; extensions += "cl_intel_create_buffer_with_properties "; @@ -283,7 +283,7 @@ std::string HwHelperHw::getExtensions(const HardwareInfo &hwInfo) const } template <> -uint32_t HwHelperHw::alignSlmSize(uint32_t slmSize) { +uint32_t GfxCoreHelperHw::alignSlmSize(uint32_t slmSize) { const uint32_t alignedSlmSizes[] = { 0u, 1u * KB, @@ -310,7 +310,7 @@ uint32_t HwHelperHw::alignSlmSize(uint32_t slmSize) { } template <> -uint32_t HwHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32_t slmSize) { +uint32_t GfxCoreHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32_t slmSize) { using SHARED_LOCAL_MEMORY_SIZE = typename Family::INTERFACE_DESCRIPTOR_DATA::SHARED_LOCAL_MEMORY_SIZE; if (slmSize == 0u) { return SHARED_LOCAL_MEMORY_SIZE::SHARED_LOCAL_MEMORY_SIZE_ENCODES_0K; @@ -352,17 +352,17 @@ uint32_t HwHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32 } template <> -int32_t HwHelperHw::getDefaultThreadArbitrationPolicy() const { +int32_t GfxCoreHelperHw::getDefaultThreadArbitrationPolicy() const { return ThreadArbitrationPolicy::RoundRobinAfterDependency; } template <> -bool HwHelperHw::isAssignEngineRoundRobinSupported(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isAssignEngineRoundRobinSupported(const HardwareInfo &hwInfo) const { return HwInfoConfig::get(hwInfo.platform.eProductFamily)->isAssignEngineRoundRobinSupported(); } template <> -bool HwHelperHw::isSubDeviceEngineSupported(const HardwareInfo &hwInfo, const DeviceBitfield &deviceBitfield, aub_stream::EngineType engineType) const { +bool GfxCoreHelperHw::isSubDeviceEngineSupported(const HardwareInfo &hwInfo, const DeviceBitfield &deviceBitfield, aub_stream::EngineType engineType) const { constexpr uint64_t tile1Bitfield = 0b10; bool affectedEngine = (deviceBitfield.to_ulong() == tile1Bitfield) && @@ -374,7 +374,7 @@ bool HwHelperHw::isSubDeviceEngineSupported(const HardwareInfo &hwInfo, } template <> -uint32_t HwHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const { +uint32_t GfxCoreHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvironment &rootDeviceEnvironment) const { if (DebugManager.flags.OverrideNumComputeUnitsForScratch.get() != -1) { return static_cast(DebugManager.flags.OverrideNumComputeUnitsForScratch.get()); } @@ -387,22 +387,22 @@ uint32_t HwHelperHw::getComputeUnitsUsedForScratch(const RootDeviceEnvir } template <> -bool HwHelperHw::isRevisionSpecificBinaryBuiltinRequired() const { +bool GfxCoreHelperHw::isRevisionSpecificBinaryBuiltinRequired() const { return true; } template <> -size_t HwHelperHw::getSipKernelMaxDbgSurfaceSize(const HardwareInfo &hwInfo) const { +size_t GfxCoreHelperHw::getSipKernelMaxDbgSurfaceSize(const HardwareInfo &hwInfo) const { return 0x2800000; } template <> -bool HwHelperHw::isTimestampWaitSupportedForQueues() const { +bool GfxCoreHelperHw::isTimestampWaitSupportedForQueues() const { return true; } template <> -uint64_t HwHelperHw::getPatIndex(CacheRegion cacheRegion, CachePolicy cachePolicy) const { +uint64_t GfxCoreHelperHw::getPatIndex(CacheRegion cacheRegion, CachePolicy cachePolicy) const { /* PAT Index CLOS MemType SHARED @@ -428,7 +428,7 @@ uint64_t HwHelperHw::getPatIndex(CacheRegion cacheRegion, CachePolicy ca } template <> -bool HwHelperHw::copyThroughLockedPtrEnabled(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::copyThroughLockedPtrEnabled(const HardwareInfo &hwInfo) const { if (DebugManager.flags.ExperimentalCopyThroughLock.get() != -1) { return DebugManager.flags.ExperimentalCopyThroughLock.get() == 1; } @@ -436,7 +436,7 @@ bool HwHelperHw::copyThroughLockedPtrEnabled(const HardwareInfo &hwInfo) } template <> -uint32_t HwHelperHw::getAmountOfAllocationsToFill() const { +uint32_t GfxCoreHelperHw::getAmountOfAllocationsToFill() const { if (DebugManager.flags.SetAmountOfReusableAllocations.get() != -1) { return DebugManager.flags.SetAmountOfReusableAllocations.get(); } @@ -444,7 +444,7 @@ uint32_t HwHelperHw::getAmountOfAllocationsToFill() const { } template <> -bool HwHelperHw::isRelaxedOrderingSupported() const { +bool GfxCoreHelperHw::isRelaxedOrderingSupported() const { return true; } @@ -453,7 +453,7 @@ bool HwHelperHw::isRelaxedOrderingSupported() const { #include "shared/source/helpers/hw_helper_pvc_and_later.inl" namespace NEO { -template class HwHelperHw; +template class GfxCoreHelperHw; template class FlatBatchBufferHelperHw; template struct MemorySynchronizationCommands; template struct LriHelper; diff --git a/shared/source/xe_hpg_core/command_encoder_xe_hpg_core.cpp b/shared/source/xe_hpg_core/command_encoder_xe_hpg_core.cpp index 50ecac74a4..bb6fb58980 100644 --- a/shared/source/xe_hpg_core/command_encoder_xe_hpg_core.cpp +++ b/shared/source/xe_hpg_core/command_encoder_xe_hpg_core.cpp @@ -37,7 +37,7 @@ void EncodeDispatchKernel::appendAdditionalIDDFields(INTERFACE_DESCRIPTO const uint32_t threadsPerDssCount = hwInfo.gtSystemInfo.ThreadCount / hwInfo.gtSystemInfo.DualSubSliceCount; const uint32_t workGroupCountPerDss = threadsPerDssCount / threadsPerThreadGroup; - const uint32_t workgroupSlmSize = HwHelperHw::get().alignSlmSize(slmTotalSize); + const uint32_t workgroupSlmSize = GfxCoreHelperHw::get().alignSlmSize(slmTotalSize); uint32_t slmSize = 0u; diff --git a/shared/source/xe_hpg_core/dg2/os_agnostic_hw_info_config_dg2.inl b/shared/source/xe_hpg_core/dg2/os_agnostic_hw_info_config_dg2.inl index 633d1e39bb..1a65ac93a8 100644 --- a/shared/source/xe_hpg_core/dg2/os_agnostic_hw_info_config_dg2.inl +++ b/shared/source/xe_hpg_core/dg2/os_agnostic_hw_info_config_dg2.inl @@ -18,10 +18,10 @@ void HwInfoConfigHw::adjustSamplerState(void *sampler, const Hardwar samplerState->setLowQualityFilter(SAMPLER_STATE::LOW_QUALITY_FILTER_ENABLE); } - HwHelper &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto isMirrorAddressMode = SAMPLER_STATE::TEXTURE_COORDINATE_MODE_MIRROR == samplerState->getTcxAddressControlMode(); auto isNearestFilter = SAMPLER_STATE::MIN_MODE_FILTER_NEAREST == samplerState->getMinModeFilter(); - if (isNearestFilter && isMirrorAddressMode && hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hwInfo)) { + if (isNearestFilter && isMirrorAddressMode && gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hwInfo)) { samplerState->setRAddressMinFilterRoundingEnable(true); samplerState->setRAddressMagFilterRoundingEnable(true); } @@ -102,7 +102,7 @@ void HwInfoConfigHw::setForceNonCoherent(void *const statePtr, const template <> bool HwInfoConfigHw::isDefaultEngineTypeAdjustmentRequired(const HardwareInfo &hwInfo) const { - return HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); + return GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> @@ -112,7 +112,7 @@ bool HwInfoConfigHw::isDisableOverdispatchAvailable(const HardwareIn template <> bool HwInfoConfigHw::allowCompression(const HardwareInfo &hwInfo) const { - if (HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_A1, hwInfo) && + if (GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_A1, hwInfo) && (hwInfo.gtSystemInfo.EUCount != 128)) { return false; } @@ -121,7 +121,7 @@ bool HwInfoConfigHw::allowCompression(const HardwareInfo &hwInfo) co template <> LocalMemoryAccessMode HwInfoConfigHw::getDefaultLocalMemoryAccessMode(const HardwareInfo &hwInfo) const { - if (HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo)) { + if (GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo)) { return LocalMemoryAccessMode::CpuAccessDisallowed; } return LocalMemoryAccessMode::Default; @@ -129,12 +129,12 @@ LocalMemoryAccessMode HwInfoConfigHw::getDefaultLocalMemoryAccessMod template <> bool HwInfoConfigHw::isAllocationSizeAdjustmentRequired(const HardwareInfo &hwInfo) const { - return HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); + return GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> bool HwInfoConfigHw::isPrefetchDisablingRequired(const HardwareInfo &hwInfo) const { - return HwHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); + return GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> @@ -161,7 +161,7 @@ bool HwInfoConfigHw::isTile64With3DSurfaceOnBCSSupported(const Hardw template <> uint32_t HwInfoConfigHw::computeMaxNeededSubSliceSpace(const HardwareInfo &hwInfo) const { - const uint32_t highestEnabledSlice = NEO::HwHelper::getHighestEnabledSlice(hwInfo); + const uint32_t highestEnabledSlice = NEO::GfxCoreHelper::getHighestEnabledSlice(hwInfo); auto subSlicesPerSlice = hwInfo.gtSystemInfo.MaxSubSlicesSupported / hwInfo.gtSystemInfo.MaxSlicesSupported; auto maxSubSlice = highestEnabledSlice * subSlicesPerSlice; diff --git a/shared/source/xe_hpg_core/enable_family_full_core_xe_hpg_core.cpp b/shared/source/xe_hpg_core/enable_family_full_core_xe_hpg_core.cpp index e68bc7f5bb..04bafa9b81 100644 --- a/shared/source/xe_hpg_core/enable_family_full_core_xe_hpg_core.cpp +++ b/shared/source/xe_hpg_core/enable_family_full_core_xe_hpg_core.cpp @@ -15,14 +15,14 @@ namespace NEO { -extern HwHelper *hwHelperFactory[IGFX_MAX_CORE]; +extern GfxCoreHelper *gfxCoreHelperFactory[IGFX_MAX_CORE]; using Family = XeHpgCoreFamily; static auto gfxFamily = IGFX_XE_HPG_CORE; struct EnableCoreXeHpgCore { EnableCoreXeHpgCore() { - hwHelperFactory[gfxFamily] = &HwHelperHw::get(); + gfxCoreHelperFactory[gfxFamily] = &GfxCoreHelperHw::get(); populateFactoryTable>(); populateFactoryTable>(); populateFactoryTable>(); diff --git a/shared/source/xe_hpg_core/hw_helper_xe_hpg_core.cpp b/shared/source/xe_hpg_core/hw_helper_xe_hpg_core.cpp index 668f4977d4..87fd069e2e 100644 --- a/shared/source/xe_hpg_core/hw_helper_xe_hpg_core.cpp +++ b/shared/source/xe_hpg_core/hw_helper_xe_hpg_core.cpp @@ -21,10 +21,10 @@ using Family = NEO::XeHpgCoreFamily; namespace NEO { template <> -const AuxTranslationMode HwHelperHw::defaultAuxTranslationMode = AuxTranslationMode::Blit; +const AuxTranslationMode GfxCoreHelperHw::defaultAuxTranslationMode = AuxTranslationMode::Blit; template <> -inline bool HwHelperHw::isFusedEuDispatchEnabled(const HardwareInfo &hwInfo, bool disableEUFusionForKernel) const { +inline bool GfxCoreHelperHw::isFusedEuDispatchEnabled(const HardwareInfo &hwInfo, bool disableEUFusionForKernel) const { auto fusedEuDispatchEnabled = !hwInfo.workaroundTable.flags.waDisableFusedThreadScheduling; fusedEuDispatchEnabled &= hwInfo.capabilityTable.fusedEuEnabled; @@ -38,12 +38,12 @@ inline bool HwHelperHw::isFusedEuDispatchEnabled(const HardwareInfo &hwI } template <> -uint32_t HwHelperHw::getMetricsLibraryGenId() const { +uint32_t GfxCoreHelperHw::getMetricsLibraryGenId() const { return static_cast(MetricsLibraryApi::ClientGen::XeHPG); } template <> -void HwHelperHw::adjustDefaultEngineType(HardwareInfo *pHwInfo) { +void GfxCoreHelperHw::adjustDefaultEngineType(HardwareInfo *pHwInfo) { if (!pHwInfo->featureTable.flags.ftrCCSNode) { pHwInfo->capabilityTable.defaultEngineType = aub_stream::ENGINE_RCS; } @@ -53,12 +53,12 @@ void HwHelperHw::adjustDefaultEngineType(HardwareInfo *pHwInfo) { } template <> -bool HwHelperHw::is1MbAlignmentSupported(const HardwareInfo &hwInfo, bool isCompressionEnabled) const { +bool GfxCoreHelperHw::is1MbAlignmentSupported(const HardwareInfo &hwInfo, bool isCompressionEnabled) const { return !hwInfo.workaroundTable.flags.waAuxTable64KGranular && isCompressionEnabled; } template <> -void HwHelperHw::setL1CachePolicy(bool useL1Cache, typename Family::RENDER_SURFACE_STATE *surfaceState, const HardwareInfo *hwInfo) { +void GfxCoreHelperHw::setL1CachePolicy(bool useL1Cache, typename Family::RENDER_SURFACE_STATE *surfaceState, const HardwareInfo *hwInfo) { if (useL1Cache) { surfaceState->setL1CachePolicyL1CacheControl(Family::RENDER_SURFACE_STATE::L1_CACHE_POLICY_WB); if (DebugManager.flags.OverrideL1CacheControlInSurfaceStateForScratchSpace.get() != -1) { @@ -68,7 +68,7 @@ void HwHelperHw::setL1CachePolicy(bool useL1Cache, typename Family::REND } template <> -bool HwHelperHw::isBankOverrideRequired(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isBankOverrideRequired(const HardwareInfo &hwInfo) const { bool forceOverrideMemoryBankIndex = false; @@ -91,12 +91,12 @@ void MemorySynchronizationCommands::addAdditionalSynchronizationForDirec } template <> -const StackVec HwHelperHw::getThreadsPerEUConfigs() const { +const StackVec GfxCoreHelperHw::getThreadsPerEUConfigs() const { return {4, 8}; } template <> -std::string HwHelperHw::getExtensions(const HardwareInfo &hwInfo) const { +std::string GfxCoreHelperHw::getExtensions(const HardwareInfo &hwInfo) const { std::string extensions; extensions += "cl_intel_create_buffer_with_properties "; extensions += "cl_intel_dot_accumulate "; @@ -112,7 +112,7 @@ std::string HwHelperHw::getExtensions(const HardwareInfo &hwInfo) const } template <> -bool HwHelperHw::isBufferSizeSuitableForCompression(const size_t size, const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::isBufferSizeSuitableForCompression(const size_t size, const HardwareInfo &hwInfo) const { if (DebugManager.flags.OverrideBufferSuitableForRenderCompression.get() != -1) { return !!DebugManager.flags.OverrideBufferSuitableForRenderCompression.get(); } @@ -125,7 +125,7 @@ bool HwHelperHw::isBufferSizeSuitableForCompression(const size_t size, c } template <> -uint32_t HwHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32_t slmSize) { +uint32_t GfxCoreHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32_t slmSize) { using SHARED_LOCAL_MEMORY_SIZE = typename Family::INTERFACE_DESCRIPTOR_DATA::SHARED_LOCAL_MEMORY_SIZE; auto slmValue = std::max(slmSize, 1024u); @@ -138,19 +138,19 @@ uint32_t HwHelperHw::computeSlmValues(const HardwareInfo &hwInfo, uint32 } template <> -bool HwHelperHw::disableL3CacheForDebug(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::disableL3CacheForDebug(const HardwareInfo &hwInfo) const { return isWorkaroundRequired(REVISION_A0, REVISION_B, hwInfo); } template <> -bool HwHelperHw::copyThroughLockedPtrEnabled(const HardwareInfo &hwInfo) const { +bool GfxCoreHelperHw::copyThroughLockedPtrEnabled(const HardwareInfo &hwInfo) const { if (DebugManager.flags.ExperimentalCopyThroughLock.get() != -1) { return DebugManager.flags.ExperimentalCopyThroughLock.get() == 1; } return this->isLocalMemoryEnabled(hwInfo); } -template class HwHelperHw; +template class GfxCoreHelperHw; template class FlatBatchBufferHelperHw; template struct MemorySynchronizationCommands; template struct LriHelper; diff --git a/shared/source/xe_hpg_core/preamble_xe_hpg_core.cpp b/shared/source/xe_hpg_core/preamble_xe_hpg_core.cpp index 8e1f7478b7..886a893db8 100644 --- a/shared/source/xe_hpg_core/preamble_xe_hpg_core.cpp +++ b/shared/source/xe_hpg_core/preamble_xe_hpg_core.cpp @@ -30,8 +30,8 @@ void PreambleHelper::appendProgramVFEState(const HardwareInfo &hwInfo, c command->setSingleSliceDispatchCcsMode(DebugManager.flags.CFESingleSliceDispatchCCSMode.get()); } - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - if (!hwHelper.isFusedEuDispatchEnabled(hwInfo, streamProperties.frontEndState.disableEUFusion.value == 1)) { + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + if (!gfxCoreHelper.isFusedEuDispatchEnabled(hwInfo, streamProperties.frontEndState.disableEUFusion.value == 1)) { command->setFusedEuDispatch(true); } diff --git a/shared/test/common/fixtures/device_fixture.cpp b/shared/test/common/fixtures/device_fixture.cpp index aebaa90c2f..ec08bb1bb3 100644 --- a/shared/test/common/fixtures/device_fixture.cpp +++ b/shared/test/common/fixtures/device_fixture.cpp @@ -46,6 +46,6 @@ HelperType &DeviceFixture::getHelper() const { } template ProductHelper &DeviceFixture::getHelper() const; -template CoreHelper &DeviceFixture::getHelper() const; +template GfxCoreHelper &DeviceFixture::getHelper() const; } // namespace NEO diff --git a/shared/test/common/fixtures/memory_allocator_fixture.h b/shared/test/common/fixtures/memory_allocator_fixture.h index 2fb4c75448..5e951bd195 100644 --- a/shared/test/common/fixtures/memory_allocator_fixture.h +++ b/shared/test/common/fixtures/memory_allocator_fixture.h @@ -32,7 +32,7 @@ class MemoryAllocatorFixture : public MemoryManagementFixture { executionEnvironment->memoryManager.reset(memoryManager); csr = &device->getGpgpuCommandStreamReceiver(); auto &hwInfo = device->getHardwareInfo(); - auto engineType = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0].first; + auto engineType = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0].first; auto osContext = memoryManager->createAndRegisterOsContext(csr, EngineDescriptorHelper::getDefaultDescriptor({engineType, EngineUsage::Regular}, PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); csr->setupContext(*osContext); diff --git a/shared/test/common/fixtures/memory_manager_fixture.cpp b/shared/test/common/fixtures/memory_manager_fixture.cpp index aa3bc9de64..3524586dd0 100644 --- a/shared/test/common/fixtures/memory_manager_fixture.cpp +++ b/shared/test/common/fixtures/memory_manager_fixture.cpp @@ -25,7 +25,7 @@ void MemoryManagerWithCsrFixture::setUp() { executionEnvironment.memoryManager.reset(memoryManager); csr->tagAddress = ¤tGpuTag; auto hwInfo = executionEnvironment.rootDeviceEnvironments[0]->getHardwareInfo(); - auto engine = HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; + auto engine = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; auto osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor({engine.first, EngineUsage::Regular}, PreemptionHelper::getDefaultPreemptionMode(*hwInfo))); csr->setupContext(*osContext); diff --git a/shared/test/common/helpers/hw_helper_tests.h b/shared/test/common/helpers/hw_helper_tests.h index 22c3afea11..4bac548b0b 100644 --- a/shared/test/common/helpers/hw_helper_tests.h +++ b/shared/test/common/helpers/hw_helper_tests.h @@ -13,7 +13,7 @@ using namespace NEO; -using HwHelperTest = Test; +using GfxCoreHelperTest = Test; struct ComputeSlmTestInput { uint32_t expected; diff --git a/shared/test/common/helpers/raii_hw_helper.h b/shared/test/common/helpers/raii_hw_helper.h index 343073b27b..5725120b54 100644 --- a/shared/test/common/helpers/raii_hw_helper.h +++ b/shared/test/common/helpers/raii_hw_helper.h @@ -10,23 +10,23 @@ #include "shared/source/helpers/hw_helper.h" namespace NEO { -extern HwHelper *hwHelperFactory[IGFX_MAX_CORE]; +extern GfxCoreHelper *gfxCoreHelperFactory[IGFX_MAX_CORE]; template -class RAIIHwHelperFactory { +class RAIIGfxCoreHelperFactory { public: GFXCORE_FAMILY gfxCoreFamily; - HwHelper *hwHelper; - MockHelper mockHwHelper; + GfxCoreHelper *gfxCoreHelper; + MockHelper mockGfxCoreHelper; - RAIIHwHelperFactory(GFXCORE_FAMILY gfxCoreFamily) { + RAIIGfxCoreHelperFactory(GFXCORE_FAMILY gfxCoreFamily) { this->gfxCoreFamily = gfxCoreFamily; - hwHelper = hwHelperFactory[this->gfxCoreFamily]; - hwHelperFactory[this->gfxCoreFamily] = &mockHwHelper; + gfxCoreHelper = gfxCoreHelperFactory[this->gfxCoreFamily]; + gfxCoreHelperFactory[this->gfxCoreFamily] = &mockGfxCoreHelper; } - ~RAIIHwHelperFactory() { - hwHelperFactory[this->gfxCoreFamily] = hwHelper; + ~RAIIGfxCoreHelperFactory() { + gfxCoreHelperFactory[this->gfxCoreFamily] = gfxCoreHelper; } }; } // namespace NEO \ No newline at end of file diff --git a/shared/test/common/helpers/sip_init.cpp b/shared/test/common/helpers/sip_init.cpp index 3ffc059c10..7410e451c5 100644 --- a/shared/test/common/helpers/sip_init.cpp +++ b/shared/test/common/helpers/sip_init.cpp @@ -128,8 +128,8 @@ std::vector createStateSaveAreaHeader(uint32_t version) { bool SipKernel::initSipKernel(SipKernelType type, Device &device) { if (MockSipData::useMockSip) { - auto &hwHelper = HwHelper::get(device.getRootDeviceEnvironment().getHardwareInfo()->platform.eRenderCoreFamily); - if (hwHelper.isSipKernelAsHexadecimalArrayPreferred()) { + auto &gfxCoreHelper = GfxCoreHelper::get(device.getRootDeviceEnvironment().getHardwareInfo()->platform.eRenderCoreFamily); + if (gfxCoreHelper.isSipKernelAsHexadecimalArrayPreferred()) { SipKernel::classType = SipClassType::HexadecimalHeaderFile; } else { SipKernel::classType = SipClassType::Builtins; diff --git a/shared/test/common/libult/linux/drm_mock.cpp b/shared/test/common/libult/linux/drm_mock.cpp index 02265090ff..ef768fb7e5 100644 --- a/shared/test/common/libult/linux/drm_mock.cpp +++ b/shared/test/common/libult/linux/drm_mock.cpp @@ -28,7 +28,7 @@ DrmMock::DrmMock(int fd, RootDeviceEnvironment &rootDeviceEnvironment) : Drm(std setupIoctlHelper(rootDeviceEnvironment.getHardwareInfo()->platform.eProductFamily); if (!isPerContextVMRequired()) { - createVirtualMemoryAddressSpace(HwHelper::getSubDevicesCount(rootDeviceEnvironment.getHardwareInfo())); + createVirtualMemoryAddressSpace(GfxCoreHelper::getSubDevicesCount(rootDeviceEnvironment.getHardwareInfo())); } storedPreemptionSupport = I915_SCHEDULER_CAP_ENABLED | diff --git a/shared/test/common/mocks/mock_hw_helper.h b/shared/test/common/mocks/mock_hw_helper.h index 063e74e174..474fcfa8bf 100644 --- a/shared/test/common/mocks/mock_hw_helper.h +++ b/shared/test/common/mocks/mock_hw_helper.h @@ -1,5 +1,5 @@ /* - * Copyright (C) 2020-2021 Intel Corporation + * Copyright (C) 2020-2022 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -12,7 +12,7 @@ namespace NEO { template -class MockHwHelperWithFenceAllocation : public HwHelperHw { +class MockGfxCoreHelperWithFenceAllocation : public GfxCoreHelperHw { public: bool isFenceAllocationRequired(const HardwareInfo &hwInfo) const override { return true; @@ -20,7 +20,7 @@ class MockHwHelperWithFenceAllocation : public HwHelperHw { }; template -class MockHwHelperWithLocalMemory : public HwHelperHw { +class MockGfxCoreHelperWithLocalMemory : public GfxCoreHelperHw { public: bool isLocalMemoryEnabled(const HardwareInfo &hwInfo) const override { return true; diff --git a/shared/test/common/mocks/ult_device_factory.cpp b/shared/test/common/mocks/ult_device_factory.cpp index 3b6109b911..4709ae50c7 100644 --- a/shared/test/common/mocks/ult_device_factory.cpp +++ b/shared/test/common/mocks/ult_device_factory.cpp @@ -69,7 +69,7 @@ void UltDeviceFactory::prepareDeviceEnvironments(ExecutionEnvironment &execution } bool UltDeviceFactory::initializeMemoryManager(ExecutionEnvironment &executionEnvironment) { if (executionEnvironment.memoryManager == nullptr) { - bool enableLocalMemory = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getEnableLocalMemory(*defaultHwInfo); + bool enableLocalMemory = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getEnableLocalMemory(*defaultHwInfo); bool aubUsage = (testMode == TestMode::AubTests) || (testMode == TestMode::AubTestsWithTbx); executionEnvironment.memoryManager.reset(new MockMemoryManager(false, enableLocalMemory, aubUsage, executionEnvironment)); } diff --git a/shared/test/common/os_interface/linux/device_command_stream_fixture.cpp b/shared/test/common/os_interface/linux/device_command_stream_fixture.cpp index ba31d2e8b6..32ad85bb77 100644 --- a/shared/test/common/os_interface/linux/device_command_stream_fixture.cpp +++ b/shared/test/common/os_interface/linux/device_command_stream_fixture.cpp @@ -220,10 +220,10 @@ int DrmMockCustom::ioctl(DrmIoctl request, void *arg) { DrmMockCustom::DrmMockCustom(RootDeviceEnvironment &rootDeviceEnvironment) : Drm(std::make_unique(mockFd, mockPciPath), rootDeviceEnvironment) { reset(); - ioctl_expected.contextCreate = static_cast(NEO::HwHelper::get(NEO::defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*NEO::defaultHwInfo).size()); + ioctl_expected.contextCreate = static_cast(NEO::GfxCoreHelper::get(NEO::defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*NEO::defaultHwInfo).size()); ioctl_expected.contextDestroy = ioctl_expected.contextCreate.load(); setupIoctlHelper(rootDeviceEnvironment.getHardwareInfo()->platform.eProductFamily); - createVirtualMemoryAddressSpace(NEO::HwHelper::getSubDevicesCount(rootDeviceEnvironment.getHardwareInfo())); + createVirtualMemoryAddressSpace(NEO::GfxCoreHelper::getSubDevicesCount(rootDeviceEnvironment.getHardwareInfo())); isVmBindAvailable(); // NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) reset(); } diff --git a/shared/test/common/os_interface/linux/drm_command_stream_fixture.h b/shared/test/common/os_interface/linux/drm_command_stream_fixture.h index e9bab7b48c..70bead106f 100644 --- a/shared/test/common/os_interface/linux/drm_command_stream_fixture.h +++ b/shared/test/common/os_interface/linux/drm_command_stream_fixture.h @@ -48,9 +48,9 @@ class DrmCommandStreamTest : public ::testing::Test { executionEnvironment.rootDeviceEnvironments[0]->initGmm(); gmmHelper = executionEnvironment.rootDeviceEnvironments[0]->getGmmHelper(); - mock->createVirtualMemoryAddressSpace(HwHelper::getSubDevicesCount(hwInfo)); + mock->createVirtualMemoryAddressSpace(GfxCoreHelper::getSubDevicesCount(hwInfo)); osContext = std::make_unique(*mock, 0, 0u, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*hwInfo))); osContext->ensureContextInitialized(); diff --git a/shared/test/common/os_interface/linux/drm_neo_create.cpp b/shared/test/common/os_interface/linux/drm_neo_create.cpp index aaabfe98da..227f38c6a2 100644 --- a/shared/test/common/os_interface/linux/drm_neo_create.cpp +++ b/shared/test/common/os_interface/linux/drm_neo_create.cpp @@ -53,7 +53,7 @@ Drm *Drm::create(std::unique_ptr &&hwDeviceId, RootDeviceEnvironm } if (!drm->isPerContextVMRequired()) { - drm->createVirtualMemoryAddressSpace(HwHelper::getSubDevicesCount(hwInfo)); + drm->createVirtualMemoryAddressSpace(GfxCoreHelper::getSubDevicesCount(hwInfo)); } return drm; diff --git a/shared/test/common/os_interface/windows/wddm_fixture.h b/shared/test/common/os_interface/windows/wddm_fixture.h index 49d5e264f1..c7a0794271 100644 --- a/shared/test/common/os_interface/windows/wddm_fixture.h +++ b/shared/test/common/os_interface/windows/wddm_fixture.h @@ -46,7 +46,7 @@ struct WddmFixture : public Test { auto preemptionMode = PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo); wddm->init(); auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - auto engine = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; + auto engine = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; osContext = std::make_unique(*osInterface->getDriverModel()->as(), 0, 0u, EngineDescriptorHelper::getDefaultDescriptor(engine, preemptionMode)); osContext->ensureContextInitialized(); mockTemporaryResources = static_cast(wddm->temporaryResources.get()); @@ -77,7 +77,7 @@ struct WddmFixtureLuid : public Test { auto preemptionMode = PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo); wddm->init(); auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - auto engine = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; + auto engine = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; osContext = std::make_unique(*osInterface->getDriverModel()->as(), 0, 0u, EngineDescriptorHelper::getDefaultDescriptor(engine, preemptionMode)); osContext->ensureContextInitialized(); mockTemporaryResources = static_cast(wddm->temporaryResources.get()); @@ -114,7 +114,7 @@ struct WddmFixtureWithMockGdiDll : public GdiDllFixture, public MockExecutionEnv wddm->wddmInterface.reset(wddmMockInterface); auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - auto engine = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; + auto engine = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; osContext = std::make_unique(*osInterface->getDriverModel()->as(), 0, 0u, EngineDescriptorHelper::getDefaultDescriptor(engine, preemptionMode)); osContext->ensureContextInitialized(); } @@ -162,7 +162,7 @@ struct WddmFixtureWithMockGdiDllWddmNoCleanup : public GdiDllFixture, public Moc wddm->wddmInterface.reset(wddmMockInterface); auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - auto engine = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; + auto engine = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; osContext = std::make_unique(*osInterface->getDriverModel()->as(), 0, 0u, EngineDescriptorHelper::getDefaultDescriptor(engine, preemptionMode)); osContext->ensureContextInitialized(); } diff --git a/shared/test/common/test_macros/test_checks_shared.cpp b/shared/test/common/test_macros/test_checks_shared.cpp index f2eb53f37a..b1ff49000d 100644 --- a/shared/test/common/test_macros/test_checks_shared.cpp +++ b/shared/test/common/test_macros/test_checks_shared.cpp @@ -14,7 +14,7 @@ using namespace NEO; bool TestChecks::supportsBlitter(const HardwareInfo *pHardwareInfo) { - auto engines = HwHelper::get(::renderCoreFamily).getGpgpuEngineInstances(*pHardwareInfo); + auto engines = GfxCoreHelper::get(::renderCoreFamily).getGpgpuEngineInstances(*pHardwareInfo); for (const auto &engine : engines) { if (engine.first == aub_stream::EngineType::ENGINE_BCS) { return pHardwareInfo->capabilityTable.blitterOperationsSupported; @@ -24,7 +24,7 @@ bool TestChecks::supportsBlitter(const HardwareInfo *pHardwareInfo) { } bool TestChecks::fullySupportsBlitter(const HardwareInfo *pHardwareInfo) { - auto engines = HwHelper::get(::renderCoreFamily).getGpgpuEngineInstances(*pHardwareInfo); + auto engines = GfxCoreHelper::get(::renderCoreFamily).getGpgpuEngineInstances(*pHardwareInfo); for (const auto &engine : engines) { if (engine.first == aub_stream::EngineType::ENGINE_BCS) { return HwInfoConfig::get(pHardwareInfo->platform.eProductFamily)->isBlitterFullySupported(*pHardwareInfo); diff --git a/shared/test/unit_test/aub/aub_helper_tests.cpp b/shared/test/unit_test/aub/aub_helper_tests.cpp index 60fde4ee6f..94aaa88010 100644 --- a/shared/test/unit_test/aub/aub_helper_tests.cpp +++ b/shared/test/unit_test/aub/aub_helper_tests.cpp @@ -42,11 +42,11 @@ TEST(AubHelper, GivenMultipleSubDevicesWhenGettingDeviceCountThenCorrectValueIsR HardwareInfo hwInfo{&platform, &featureTable, &workaroundTable, &sysInfo, capTable}; DebugManager.flags.CreateMultipleSubDevices.set(2); - uint32_t devicesCount = HwHelper::getSubDevicesCount(&hwInfo); + uint32_t devicesCount = GfxCoreHelper::getSubDevicesCount(&hwInfo); EXPECT_EQ(devicesCount, 2u); DebugManager.flags.CreateMultipleSubDevices.set(0); - devicesCount = HwHelper::getSubDevicesCount(&hwInfo); + devicesCount = GfxCoreHelper::getSubDevicesCount(&hwInfo); EXPECT_EQ(devicesCount, 1u); } diff --git a/shared/test/unit_test/built_ins/sip_tests.cpp b/shared/test/unit_test/built_ins/sip_tests.cpp index 2196bed072..e756aadad5 100644 --- a/shared/test/unit_test/built_ins/sip_tests.cpp +++ b/shared/test/unit_test/built_ins/sip_tests.cpp @@ -341,16 +341,16 @@ TEST_F(StateSaveAreaSipTest, givenEmptyStateSaveAreaHeaderWhenGetStateSaveAreaSi MockSipData::useMockSip = true; MockSipData::mockSipKernel->mockStateSaveAreaHeader.clear(); auto hwInfo = *NEO::defaultHwInfo.get(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - EXPECT_EQ(hwHelper.getSipKernelMaxDbgSurfaceSize(hwInfo), SipKernel::getSipKernel(*pDevice).getStateSaveAreaSize(pDevice)); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + EXPECT_EQ(gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo), SipKernel::getSipKernel(*pDevice).getStateSaveAreaSize(pDevice)); } TEST_F(StateSaveAreaSipTest, givenCorruptedStateSaveAreaHeaderWhenGetStateSaveAreaSizeCalledThenMaxDbgSurfaceSizeIsReturned) { MockSipData::useMockSip = true; MockSipData::mockSipKernel->mockStateSaveAreaHeader = {'g', 'a', 'r', 'b', 'a', 'g', 'e'}; auto hwInfo = *NEO::defaultHwInfo.get(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - EXPECT_EQ(hwHelper.getSipKernelMaxDbgSurfaceSize(hwInfo), SipKernel::getSipKernel(*pDevice).getStateSaveAreaSize(pDevice)); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + EXPECT_EQ(gfxCoreHelper.getSipKernelMaxDbgSurfaceSize(hwInfo), SipKernel::getSipKernel(*pDevice).getStateSaveAreaSize(pDevice)); } TEST_F(StateSaveAreaSipTest, givenCorrectStateSaveAreaHeaderWhenGetStateSaveAreaSizeCalledThenCorrectDbgSurfaceSizeIsReturned) { diff --git a/shared/test/unit_test/command_container/command_container_tests.cpp b/shared/test/unit_test/command_container/command_container_tests.cpp index 7610f7aa0f..475945fca6 100644 --- a/shared/test/unit_test/command_container/command_container_tests.cpp +++ b/shared/test/unit_test/command_container/command_container_tests.cpp @@ -139,10 +139,10 @@ TEST_F(CommandContainerTest, givenCommandContainerWhenInitializeThenEverythingIs EXPECT_EQ(cmdContainer.getIddBlock(), nullptr); EXPECT_EQ(cmdContainer.getNumIddPerBlock(), defaultNumIddsPerBlock); - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); EXPECT_EQ(cmdContainer.getInstructionHeapBaseAddress(), - pDevice->getMemoryManager()->getInternalHeapBaseAddress(0, !hwHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo()))); + pDevice->getMemoryManager()->getInternalHeapBaseAddress(0, !gfxCoreHelper.useSystemMemoryPlacementForISA(pDevice->getHardwareInfo()))); } TEST_F(CommandContainerTest, givenCommandContainerWhenHeapNotRequiredThenHeapIsNotInitialized) { @@ -721,18 +721,18 @@ TEST_F(CommandContainerHeaps, givenCommandContainerForDifferentRootDevicesThenIn auto device0 = std::unique_ptr(Device::create(executionEnvironment, 0u)); auto device1 = std::unique_ptr(Device::create(executionEnvironment, 1u)); - auto &hwHelper0 = HwHelper::get(device0->getHardwareInfo().platform.eRenderCoreFamily); - auto &hwHelper1 = HwHelper::get(device1->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper0 = GfxCoreHelper::get(device0->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper1 = GfxCoreHelper::get(device1->getHardwareInfo().platform.eRenderCoreFamily); CommandContainer cmdContainer0; cmdContainer0.initialize(device0.get(), nullptr, true); - bool useLocalMemory0 = !hwHelper0.useSystemMemoryPlacementForISA(device0->getHardwareInfo()); + bool useLocalMemory0 = !gfxCoreHelper0.useSystemMemoryPlacementForISA(device0->getHardwareInfo()); uint64_t baseAddressHeapDevice0 = device0->getMemoryManager()->getInternalHeapBaseAddress(device0->getRootDeviceIndex(), useLocalMemory0); EXPECT_EQ(cmdContainer0.getInstructionHeapBaseAddress(), baseAddressHeapDevice0); CommandContainer cmdContainer1; cmdContainer1.initialize(device1.get(), nullptr, true); - bool useLocalMemory1 = !hwHelper1.useSystemMemoryPlacementForISA(device0->getHardwareInfo()); + bool useLocalMemory1 = !gfxCoreHelper1.useSystemMemoryPlacementForISA(device0->getHardwareInfo()); uint64_t baseAddressHeapDevice1 = device1->getMemoryManager()->getInternalHeapBaseAddress(device1->getRootDeviceIndex(), useLocalMemory1); EXPECT_EQ(cmdContainer1.getInstructionHeapBaseAddress(), baseAddressHeapDevice1); } @@ -836,10 +836,10 @@ TEST_F(CommandContainerTest, givenCmdContainerWhenCloseAndAllocateNextCommandBuf CommandContainer cmdContainer; cmdContainer.initialize(pDevice, nullptr, true); auto &hwInfo = pDevice->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto ptr = cmdContainer.getCommandStream()->getSpace(0u); cmdContainer.closeAndAllocateNextCommandBuffer(); - EXPECT_EQ(memcmp(ptr, hwHelper.getBatchBufferEndReference(), hwHelper.getBatchBufferEndSize()), 0); + EXPECT_EQ(memcmp(ptr, gfxCoreHelper.getBatchBufferEndReference(), gfxCoreHelper.getBatchBufferEndSize()), 0); } TEST_F(CommandContainerTest, givenCmdContainerWhenCloseAndAllocateNextCommandBufferCalledThenNewCmdBufferAllocationCreated) { diff --git a/shared/test/unit_test/command_stream/aub_command_stream_receiver_1_tests.cpp b/shared/test/unit_test/command_stream/aub_command_stream_receiver_1_tests.cpp index 8eaa463846..12391d28b8 100644 --- a/shared/test/unit_test/command_stream/aub_command_stream_receiver_1_tests.cpp +++ b/shared/test/unit_test/command_stream/aub_command_stream_receiver_1_tests.cpp @@ -253,7 +253,7 @@ HWTEST_F(AubCommandStreamReceiverTests, givenAubCommandStreamReceiverWhenMultipl pDevice->executionEnvironment->rootDeviceEnvironments[0]->aubCenter.reset(new AubCenter()); auto &hwInfo = pDevice->getHardwareInfo(); - auto engineInstance = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0]; + auto engineInstance = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0]; MockOsContext osContext(0, EngineDescriptorHelper::getDefaultDescriptor(engineInstance)); auto aubCsr1 = std::make_unique>("", true, *pDevice->executionEnvironment, pDevice->getRootDeviceIndex(), pDevice->getDeviceBitfield()); diff --git a/shared/test/unit_test/command_stream/aub_command_stream_receiver_2_tests.cpp b/shared/test/unit_test/command_stream/aub_command_stream_receiver_2_tests.cpp index 774d30f95d..3b2608b591 100644 --- a/shared/test/unit_test/command_stream/aub_command_stream_receiver_2_tests.cpp +++ b/shared/test/unit_test/command_stream/aub_command_stream_receiver_2_tests.cpp @@ -588,7 +588,7 @@ HWTEST_F(AubCommandStreamReceiverNoHostPtrTests, givenAubCommandStreamReceiverWh auto memoryManager = new OsAgnosticMemoryManagerForImagesWithNoHostPtr(*executionEnvironment); executionEnvironment->memoryManager.reset(memoryManager); auto hwInfo = executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo(); - auto engineInstance = HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; + auto engineInstance = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; UltDeviceFactory deviceFactory{1, 0, *executionEnvironment}; DeviceBitfield deviceBitfield(1); MockOsContext osContext(0, EngineDescriptorHelper::getDefaultDescriptor(engineInstance, deviceBitfield)); @@ -841,7 +841,7 @@ HWTEST_F(AubCommandStreamReceiverTests, whenAubCommandStreamReceiverIsCreatedThe HWTEST_F(AubCommandStreamReceiverTests, givenAubCommandStreamReceiverWhenEngineIsInitializedThenDumpHandleIsGenerated) { MockExecutionEnvironment executionEnvironment(defaultHwInfo.get()); auto hwInfo = executionEnvironment.rootDeviceEnvironments[0]->getHardwareInfo(); - auto engineInstance = HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; + auto engineInstance = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; DeviceBitfield deviceBitfield(1); MockOsContext osContext(0, EngineDescriptorHelper::getDefaultDescriptor(engineInstance, deviceBitfield)); executionEnvironment.initializeMemoryManager(); diff --git a/shared/test/unit_test/command_stream/aub_command_stream_receiver_tests_xehp_and_later.cpp b/shared/test/unit_test/command_stream/aub_command_stream_receiver_tests_xehp_and_later.cpp index 6a360418fb..98dcc6fb4f 100644 --- a/shared/test/unit_test/command_stream/aub_command_stream_receiver_tests_xehp_and_later.cpp +++ b/shared/test/unit_test/command_stream/aub_command_stream_receiver_tests_xehp_and_later.cpp @@ -359,7 +359,7 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterAubCommandStreamReceiverTests, givenAub EXPECT_EQ(mmioList[21], MMIOPair(0x0000B134, 0xA0000000)); } -using XeHPAndLaterAubCommandStreamReceiverTests2 = HwHelperTest; +using XeHPAndLaterAubCommandStreamReceiverTests2 = GfxCoreHelperTest; HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterAubCommandStreamReceiverTests2, givenLocalMemoryEnabledInCSRWhenGetGTTDataIsCalledThenLocalMemoryIsSet) { DebugManagerStateRestore debugRestorer; diff --git a/shared/test/unit_test/command_stream/command_stream_receiver_simulated_tests.cpp b/shared/test/unit_test/command_stream/command_stream_receiver_simulated_tests.cpp index 507596da54..3869b245a4 100644 --- a/shared/test/unit_test/command_stream/command_stream_receiver_simulated_tests.cpp +++ b/shared/test/unit_test/command_stream/command_stream_receiver_simulated_tests.cpp @@ -26,7 +26,7 @@ #include using namespace NEO; -using CommandStreamSimulatedTests = HwHelperTest; +using CommandStreamSimulatedTests = GfxCoreHelperTest; HWTEST_F(CommandStreamSimulatedTests, givenLocalMemoryAndAllocationWithStorageInfoNonZeroWhenMemoryBankIsQueriedThenBankForAllocationDeviceIsReturned) { ExecutionEnvironment executionEnvironment; diff --git a/shared/test/unit_test/command_stream/command_stream_receiver_tests.cpp b/shared/test/unit_test/command_stream/command_stream_receiver_tests.cpp index ba1aa7beed..99b36b4f71 100644 --- a/shared/test/unit_test/command_stream/command_stream_receiver_tests.cpp +++ b/shared/test/unit_test/command_stream/command_stream_receiver_tests.cpp @@ -698,11 +698,11 @@ HWTEST_F(CommandStreamReceiverTest, givenUpdateTaskCountFromWaitWhenCheckTaskCou HWTEST_F(CommandStreamReceiverTest, givenUpdateTaskCountFromWaitWhenCheckIfEnabledThenCanBeEnabledOnlyWithDirectSubmission) { auto &csr = pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(csr.peekHwInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(csr.peekHwInfo().platform.eRenderCoreFamily); { csr.directSubmissionAvailable = true; - EXPECT_EQ(csr.isUpdateTagFromWaitEnabled(), hwHelper.isUpdateTaskCountFromWaitSupported()); + EXPECT_EQ(csr.isUpdateTagFromWaitEnabled(), gfxCoreHelper.isUpdateTaskCountFromWaitSupported()); } { @@ -719,11 +719,11 @@ HWTEST_F(CommandStreamReceiverTest, givenUpdateTaskCountFromWaitInMultiRootDevic SetUp(); auto &csr = pDevice->getUltCommandStreamReceiver(); - auto &hwHelper = HwHelper::get(csr.peekHwInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(csr.peekHwInfo().platform.eRenderCoreFamily); { csr.directSubmissionAvailable = true; - EXPECT_EQ(csr.isUpdateTagFromWaitEnabled(), hwHelper.isUpdateTaskCountFromWaitSupported()); + EXPECT_EQ(csr.isUpdateTagFromWaitEnabled(), gfxCoreHelper.isUpdateTaskCountFromWaitSupported()); } { diff --git a/shared/test/unit_test/command_stream/command_stream_receiver_with_aub_dump_tests.cpp b/shared/test/unit_test/command_stream/command_stream_receiver_with_aub_dump_tests.cpp index 080eb6b6fd..5f468dc9d0 100644 --- a/shared/test/unit_test/command_stream/command_stream_receiver_with_aub_dump_tests.cpp +++ b/shared/test/unit_test/command_stream/command_stream_receiver_with_aub_dump_tests.cpp @@ -188,7 +188,7 @@ HWTEST_F(CommandStreamReceiverWithAubDumpSimpleTest, givenCsrWithAubDumpWhenSett CommandStreamReceiverWithAUBDump> csrWithAubDump("aubfile", *executionEnvironment, 0, deviceBitfield); auto hwInfo = executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo(); - MockOsContext osContext(0, EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + MockOsContext osContext(0, EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*hwInfo))); csrWithAubDump.setupContext(osContext); @@ -370,7 +370,7 @@ struct CommandStreamReceiverTagTests : public ::testing::Test { bool isTimestampPacketNodeReleasable(Args &&...args) { CsrT csr(std::forward(args)...); auto hwInfo = csr.peekExecutionEnvironment().rootDeviceEnvironments[0]->getHardwareInfo(); - MockOsContext osContext(0, EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + MockOsContext osContext(0, EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*hwInfo))); csr.setupContext(osContext); diff --git a/shared/test/unit_test/command_stream/compute_mode_tests.h b/shared/test/unit_test/command_stream/compute_mode_tests.h index e863f33f21..789a85caf8 100644 --- a/shared/test/unit_test/command_stream/compute_mode_tests.h +++ b/shared/test/unit_test/command_stream/compute_mode_tests.h @@ -42,9 +42,9 @@ struct ComputeModeRequirements : public ::testing::Test { uint32_t numGrfRequired = 128u) { overrideComputeModeRequest(reqestChanged, requireCoherency, hasSharedHandles, numGrfRequiredChanged, numGrfRequired); if (modifyThreadArbitrationPolicy) { - auto &hwHelper = NEO::HwHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily); auto csrHw = getCsrHw(); - csrHw->streamProperties.stateComputeMode.threadArbitrationPolicy.value = hwHelper.getDefaultThreadArbitrationPolicy(); + csrHw->streamProperties.stateComputeMode.threadArbitrationPolicy.value = gfxCoreHelper.getDefaultThreadArbitrationPolicy(); csrHw->streamProperties.stateComputeMode.threadArbitrationPolicy.isDirty = true; } } diff --git a/shared/test/unit_test/command_stream/linear_stream_tests.cpp b/shared/test/unit_test/command_stream/linear_stream_tests.cpp index 28459ae18e..5e92ca7cbd 100644 --- a/shared/test/unit_test/command_stream/linear_stream_tests.cpp +++ b/shared/test/unit_test/command_stream/linear_stream_tests.cpp @@ -170,10 +170,10 @@ TEST_F(CommandContainerLinearStreamTest, givenLinearStreamWithCmdContainerWhenTh CommandContainer cmdContainer; cmdContainer.initialize(pDevice, nullptr, true); auto &hwInfo = pDevice->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto stream = reinterpret_cast(cmdContainer.getCommandStream()); size_t dummyCommandSize = 2; - stream->sizeUsed = stream->getMaxAvailableSpace() - hwHelper.getBatchBufferEndSize() - (dummyCommandSize - 1); + stream->sizeUsed = stream->getMaxAvailableSpace() - gfxCoreHelper.getBatchBufferEndSize() - (dummyCommandSize - 1); EXPECT_EQ(cmdContainer.getCmdBufferAllocations().size(), 1u); stream->getSpace(dummyCommandSize); EXPECT_EQ(cmdContainer.getCmdBufferAllocations().size(), 2u); @@ -183,10 +183,10 @@ TEST_F(CommandContainerLinearStreamTest, givenLinearStreamWithCmdContainerWhenTh CommandContainer cmdContainer; cmdContainer.initialize(pDevice, nullptr, true); auto &hwInfo = pDevice->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto stream = reinterpret_cast(cmdContainer.getCommandStream()); size_t dummyCommandSize = 2; - stream->sizeUsed = stream->getMaxAvailableSpace() - hwHelper.getBatchBufferEndSize() - (dummyCommandSize - 1); + stream->sizeUsed = stream->getMaxAvailableSpace() - gfxCoreHelper.getBatchBufferEndSize() - (dummyCommandSize - 1); auto oldBuffer = stream->getCpuBase(); stream->getSpace(dummyCommandSize); auto newBuffer = stream->getCpuBase(); @@ -197,10 +197,10 @@ TEST_F(CommandContainerLinearStreamTest, givenLinearStreamWithCmdContainerWhenTh CommandContainer cmdContainer; cmdContainer.initialize(pDevice, nullptr, true); auto &hwInfo = pDevice->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto stream = reinterpret_cast(cmdContainer.getCommandStream()); size_t dummyCommandSize = 2; - stream->sizeUsed = stream->getMaxAvailableSpace() - hwHelper.getBatchBufferEndSize() - (dummyCommandSize - 1); + stream->sizeUsed = stream->getMaxAvailableSpace() - gfxCoreHelper.getBatchBufferEndSize() - (dummyCommandSize - 1); auto ptr = stream->getSpace(dummyCommandSize); auto buffer = stream->getCpuBase(); EXPECT_EQ(buffer, ptr); @@ -210,10 +210,10 @@ TEST_F(CommandContainerLinearStreamTest, givenLinearStreamWithCmdContainerWhenTh CommandContainer cmdContainer; cmdContainer.initialize(pDevice, nullptr, true); auto &hwInfo = pDevice->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto stream = reinterpret_cast(cmdContainer.getCommandStream()); size_t dummyCommandSize = 2; - stream->sizeUsed = stream->getMaxAvailableSpace() - hwHelper.getBatchBufferEndSize() - (dummyCommandSize); + stream->sizeUsed = stream->getMaxAvailableSpace() - gfxCoreHelper.getBatchBufferEndSize() - (dummyCommandSize); EXPECT_EQ(cmdContainer.getCmdBufferAllocations().size(), 1u); stream->getSpace(dummyCommandSize); EXPECT_EQ(cmdContainer.getCmdBufferAllocations().size(), 1u); @@ -223,11 +223,11 @@ TEST_F(CommandContainerLinearStreamTest, givenLinearStreamWithCmdContainerWhenTh CommandContainer cmdContainer; cmdContainer.initialize(pDevice, nullptr, true); auto &hwInfo = pDevice->getHardwareInfo(); - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); auto stream = reinterpret_cast(cmdContainer.getCommandStream()); size_t dummyCommandSize = 2; - stream->sizeUsed = stream->getMaxAvailableSpace() - hwHelper.getBatchBufferEndSize() - (dummyCommandSize - 1); + stream->sizeUsed = stream->getMaxAvailableSpace() - gfxCoreHelper.getBatchBufferEndSize() - (dummyCommandSize - 1); auto ptr = stream->getSpace(0u); stream->getSpace(dummyCommandSize); - EXPECT_EQ(memcmp(ptr, hwHelper.getBatchBufferEndReference(), hwHelper.getBatchBufferEndSize()), 0); + EXPECT_EQ(memcmp(ptr, gfxCoreHelper.getBatchBufferEndReference(), gfxCoreHelper.getBatchBufferEndSize()), 0); } diff --git a/shared/test/unit_test/command_stream/tbx_command_stream_tests.cpp b/shared/test/unit_test/command_stream/tbx_command_stream_tests.cpp index 4074b7136c..f2a4579742 100644 --- a/shared/test/unit_test/command_stream/tbx_command_stream_tests.cpp +++ b/shared/test/unit_test/command_stream/tbx_command_stream_tests.cpp @@ -563,7 +563,7 @@ HWTEST_F(TbxCommandStreamTests, givenTbxCsrWhenHardwareContextIsCreatedThenTbxSt HWTEST_F(TbxCommandStreamTests, givenTbxCsrWhenOsContextIsSetThenCreateHardwareContext) { auto hwInfo = pDevice->getHardwareInfo(); - MockOsContext osContext(0, EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0], pDevice->getDeviceBitfield())); + MockOsContext osContext(0, EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0], pDevice->getDeviceBitfield())); std::string fileName = ""; MockAubManager *mockManager = new MockAubManager(); MockAubCenter *mockAubCenter = new MockAubCenter(pDevice->getRootDeviceEnvironment(), false, fileName, CommandStreamReceiverType::CSR_TBX); diff --git a/shared/test/unit_test/debugger/test_l0_debugger.cpp b/shared/test/unit_test/debugger/test_l0_debugger.cpp index 36ab4fe11e..377f0cf051 100644 --- a/shared/test/unit_test/debugger/test_l0_debugger.cpp +++ b/shared/test/unit_test/debugger/test_l0_debugger.cpp @@ -66,7 +66,7 @@ TEST(Debugger, givenL0DebuggerOFFWhenGettingStateSaveAreaHeaderThenValidSipTypeI auto executionEnvironment = new NEO::ExecutionEnvironment(); executionEnvironment->prepareRootDeviceEnvironments(1); - auto isHexadecimalArrayPreferred = NEO::HwHelper::get(NEO::defaultHwInfo->platform.eRenderCoreFamily).isSipKernelAsHexadecimalArrayPreferred(); + auto isHexadecimalArrayPreferred = NEO::GfxCoreHelper::get(NEO::defaultHwInfo->platform.eRenderCoreFamily).isSipKernelAsHexadecimalArrayPreferred(); if (!isHexadecimalArrayPreferred) { auto mockBuiltIns = new NEO::MockBuiltins(); executionEnvironment->rootDeviceEnvironments[0]->builtins.reset(mockBuiltIns); diff --git a/shared/test/unit_test/device/windows/neo_device_windows_tests.cpp b/shared/test/unit_test/device/windows/neo_device_windows_tests.cpp index e2d019de39..1fd21c3599 100644 --- a/shared/test/unit_test/device/windows/neo_device_windows_tests.cpp +++ b/shared/test/unit_test/device/windows/neo_device_windows_tests.cpp @@ -79,7 +79,7 @@ TEST_F(MockOSTimeWinTest, whenCreatingTimerThenResolutionIsSetCorrectly) { } template -class TestMockHwHelper : public HwHelperHw { +class TestMockGfxCoreHelper : public GfxCoreHelperHw { public: bool isTimestampShiftRequired() const override { return shiftRequired; @@ -94,7 +94,7 @@ HWTEST_F(MockOSTimeWinTest, whenConvertingTimestampsToCsDomainThenTimestampDataA auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(nullptr)); wddmMock->init(); auto hwInfo = wddmMock->getRootDeviceEnvironment().getHardwareInfo(); - RAIIHwHelperFactory> hwHelperBackup{hwInfo->platform.eRenderCoreFamily}; + RAIIGfxCoreHelperFactory> gfxCoreHelperBackup{hwInfo->platform.eRenderCoreFamily}; std::unique_ptr timeWin(new MockOSTimeWin(wddmMock)); uint64_t timestampData = 0x1234; uint64_t freqOA = 5; @@ -124,7 +124,7 @@ HWTEST_F(MockOSTimeWinTest, whenConvertingTimestampsToCsDomainThenTimestampDataA timeWin->convertTimestampsFromOaToCsDomain(*hwInfo, timestampData, freqOA, freqCS); EXPECT_EQ(expectedGpuTicksWhenNotChange, timestampData); - hwHelperBackup.mockHwHelper.shiftRequired = false; + gfxCoreHelperBackup.mockGfxCoreHelper.shiftRequired = false; freqOA = 1; freqCS = 0; expectedGpuTicksWhenNotChange = timestampData; diff --git a/shared/test/unit_test/direct_submission/direct_submission_tests_1.cpp b/shared/test/unit_test/direct_submission/direct_submission_tests_1.cpp index 15dce61155..308a1dd4ce 100644 --- a/shared/test/unit_test/direct_submission/direct_submission_tests_1.cpp +++ b/shared/test/unit_test/direct_submission/direct_submission_tests_1.cpp @@ -133,7 +133,7 @@ HWTEST_F(DirectSubmissionTest, givenDirectSubmissionWithoutCompletionFenceAlloca EXPECT_EQ(nullptr, directSubmission.completionFenceAllocation); size_t expectedAllocationsCnt = 3; - if (HwHelperHw::get().isRelaxedOrderingSupported()) { + if (GfxCoreHelperHw::get().isRelaxedOrderingSupported()) { expectedAllocationsCnt += 2; } @@ -164,7 +164,7 @@ HWTEST_F(DirectSubmissionTest, givenDirectSubmissionWithCompletionFenceAllocatio EXPECT_EQ(&completionFenceAllocation, directSubmission.completionFenceAllocation); size_t expectedAllocationsCnt = 4; - if (HwHelperHw::get().isRelaxedOrderingSupported()) { + if (GfxCoreHelperHw::get().isRelaxedOrderingSupported()) { expectedAllocationsCnt += 2; } diff --git a/shared/test/unit_test/direct_submission/direct_submission_tests_2.cpp b/shared/test/unit_test/direct_submission/direct_submission_tests_2.cpp index 07c73e6ff1..8eb148be48 100644 --- a/shared/test/unit_test/direct_submission/direct_submission_tests_2.cpp +++ b/shared/test/unit_test/direct_submission/direct_submission_tests_2.cpp @@ -2131,13 +2131,13 @@ HWTEST2_F(DirectSubmissionRelaxedOrderingTests, WhenStoppingRingWithoutSubmissio HWTEST_F(DirectSubmissionRelaxedOrderingTests, givenDebugFlagSetWhenAskingForRelaxedOrderingSupportThenEnable) { auto ultCsr = static_cast *>(pDevice->getDefaultEngine().commandStreamReceiver); - auto &hwHelper = HwHelperHw::get(); + auto &gfxCoreHelper = GfxCoreHelperHw::get(); { DebugManager.flags.DirectSubmissionRelaxedOrdering.set(-1); MockDirectSubmissionHw> directSubmission(*ultCsr); - EXPECT_EQ(hwHelper.isRelaxedOrderingSupported(), directSubmission.isRelaxedOrderingEnabled()); + EXPECT_EQ(gfxCoreHelper.isRelaxedOrderingSupported(), directSubmission.isRelaxedOrderingEnabled()); } { diff --git a/shared/test/unit_test/direct_submission/windows/wddm_direct_submission_tests.cpp b/shared/test/unit_test/direct_submission/windows/wddm_direct_submission_tests.cpp index 17c4bec8fd..579a7df8e7 100644 --- a/shared/test/unit_test/direct_submission/windows/wddm_direct_submission_tests.cpp +++ b/shared/test/unit_test/direct_submission/windows/wddm_direct_submission_tests.cpp @@ -60,7 +60,7 @@ HWTEST_F(WddmDirectSubmissionTest, givenWddmWhenDirectIsInitializedAndStartedThe EXPECT_NE(nullptr, wddmDirectSubmission->semaphores); size_t expectedAllocationsCnt = 3; - if (HwHelperHw::get().isRelaxedOrderingSupported()) { + if (GfxCoreHelperHw::get().isRelaxedOrderingSupported()) { expectedAllocationsCnt += 2; } @@ -96,7 +96,7 @@ HWTEST_F(WddmDirectSubmissionNoPreemptionTest, givenWddmWhenDirectIsInitializedA EXPECT_NE(nullptr, wddmDirectSubmission->semaphores); size_t expectedAllocationsCnt = 3; - if (HwHelperHw::get().isRelaxedOrderingSupported()) { + if (GfxCoreHelperHw::get().isRelaxedOrderingSupported()) { expectedAllocationsCnt += 2; } @@ -139,7 +139,7 @@ HWTEST_F(WddmDirectSubmissionTest, givenWddmWhenAllocateOsResourcesThenExpectRin EXPECT_TRUE(ret); size_t expectedAllocationsCnt = 3; - if (HwHelperHw::get().isRelaxedOrderingSupported()) { + if (GfxCoreHelperHw::get().isRelaxedOrderingSupported()) { expectedAllocationsCnt += 2; } @@ -183,7 +183,7 @@ HWTEST_F(WddmDirectSubmissionTest, givenWddmWhenAllocateOsResourcesResidencyFail EXPECT_FALSE(ret); size_t expectedAllocationsCnt = 3; - if (HwHelperHw::get().isRelaxedOrderingSupported()) { + if (GfxCoreHelperHw::get().isRelaxedOrderingSupported()) { expectedAllocationsCnt += 2; } diff --git a/shared/test/unit_test/encoders/test_encode_dispatch_kernel.cpp b/shared/test/unit_test/encoders/test_encode_dispatch_kernel.cpp index 9b8e3e89a7..4c8f1589b8 100644 --- a/shared/test/unit_test/encoders/test_encode_dispatch_kernel.cpp +++ b/shared/test/unit_test/encoders/test_encode_dispatch_kernel.cpp @@ -251,7 +251,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, CommandEncodeStatesTest, givenSlmTotalSizeGraterThan auto interfaceDescriptorData = static_cast(cmdContainer->getIddBlock()); uint32_t expectedValue = static_cast( - HwHelperHw::get().computeSlmValues(pDevice->getHardwareInfo(), slmTotalSize)); + GfxCoreHelperHw::get().computeSlmValues(pDevice->getHardwareInfo(), slmTotalSize)); EXPECT_EQ(expectedValue, interfaceDescriptorData->getSharedLocalMemorySize()); } diff --git a/shared/test/unit_test/encoders/test_encode_dispatch_kernel_xehp_and_later.cpp b/shared/test/unit_test/encoders/test_encode_dispatch_kernel_xehp_and_later.cpp index 46e770bb43..50d7857ca3 100644 --- a/shared/test/unit_test/encoders/test_encode_dispatch_kernel_xehp_and_later.cpp +++ b/shared/test/unit_test/encoders/test_encode_dispatch_kernel_xehp_and_later.cpp @@ -54,7 +54,7 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, CommandEncodeStatesTest, givenSlmTotalSizeGraterTha auto &idd = cmd->getInterfaceDescriptor(); uint32_t expectedValue = static_cast( - HwHelperHw::get().computeSlmValues(pDevice->getHardwareInfo(), slmTotalSize)); + GfxCoreHelperHw::get().computeSlmValues(pDevice->getHardwareInfo(), slmTotalSize)); EXPECT_EQ(expectedValue, idd.getSharedLocalMemorySize()); } diff --git a/shared/test/unit_test/gen11/hw_helper_tests_gen11.cpp b/shared/test/unit_test/gen11/hw_helper_tests_gen11.cpp index f068c4cbb4..2f06b466c5 100644 --- a/shared/test/unit_test/gen11/hw_helper_tests_gen11.cpp +++ b/shared/test/unit_test/gen11/hw_helper_tests_gen11.cpp @@ -11,26 +11,26 @@ #include "shared/test/common/test_macros/header/per_product_test_definitions.h" #include "shared/test/unit_test/helpers/get_gpgpu_engines_tests.inl" -using HwHelperTestGen11 = HwHelperTest; +using GfxCoreHelperTestGen11 = GfxCoreHelperTest; -GEN11TEST_F(HwHelperTestGen11, WhenGettingMaxBarriersPerSliceThenCorrectSizeIsReturned) { - auto &helper = getHelper(); +GEN11TEST_F(GfxCoreHelperTestGen11, WhenGettingMaxBarriersPerSliceThenCorrectSizeIsReturned) { + auto &helper = getHelper(); EXPECT_EQ(32u, helper.getMaxBarrierRegisterPerSlice()); } -GEN11TEST_F(HwHelperTestGen11, WhenGettingPitchAlignmentForImageThenCorrectValueIsReturned) { - auto &coreHelper = getHelper(); - EXPECT_EQ(4u, coreHelper.getPitchAlignmentForImage(pDevice->getRootDeviceEnvironment())); +GEN11TEST_F(GfxCoreHelperTestGen11, WhenGettingPitchAlignmentForImageThenCorrectValueIsReturned) { + auto &gfxCoreHelper = getHelper(); + EXPECT_EQ(4u, gfxCoreHelper.getPitchAlignmentForImage(pDevice->getRootDeviceEnvironment())); } -GEN11TEST_F(HwHelperTestGen11, WhenAdjustingDefaultEngineTypeThenEngineTypeIsSet) { +GEN11TEST_F(GfxCoreHelperTestGen11, WhenAdjustingDefaultEngineTypeThenEngineTypeIsSet) { auto engineType = hardwareInfo.capabilityTable.defaultEngineType; - auto &coreHelper = getHelper(); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + auto &gfxCoreHelper = getHelper(); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(engineType, hardwareInfo.capabilityTable.defaultEngineType); } -GEN11TEST_F(HwHelperTestGen11, whenGetGpgpuEnginesThenReturnThreeRcsEngines) { +GEN11TEST_F(GfxCoreHelperTestGen11, whenGetGpgpuEnginesThenReturnThreeRcsEngines) { whenGetGpgpuEnginesThenReturnTwoRcsEngines(pDevice->getHardwareInfo()); EXPECT_EQ(3u, pDevice->allEngines.size()); } @@ -48,6 +48,6 @@ GEN11TEST_F(MemorySynchronizatiopCommandsTestsGen11, WhenProgrammingCacheFlushTh } GEN11TEST_F(MemorySynchronizatiopCommandsTestsGen11, givenGen11WhenCallIsPackedSupportedThenReturnTrue) { - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_TRUE(helper.packedFormatsSupported()); } diff --git a/shared/test/unit_test/gen11/test_device_caps_gen11.cpp b/shared/test/unit_test/gen11/test_device_caps_gen11.cpp index 86f4ad279d..002c7632a5 100644 --- a/shared/test/unit_test/gen11/test_device_caps_gen11.cpp +++ b/shared/test/unit_test/gen11/test_device_caps_gen11.cpp @@ -42,17 +42,17 @@ GEN11TEST_F(Gen11DeviceCaps, WhenCheckingCompressionThenItIsDisabled) { GEN11TEST_F(Gen11DeviceCaps, givenHwInfoWhenRequestedComputeUnitsUsedForScratchThenReturnValidValue) { const auto &hwInfo = pDevice->getHardwareInfo(); - auto &coreHelper = getHelper(); + auto &gfxCoreHelper = getHelper(); uint32_t expectedValue = hwInfo.gtSystemInfo.MaxSubSlicesSupported * hwInfo.gtSystemInfo.MaxEuPerSubSlice * 8; - EXPECT_EQ(expectedValue, coreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment())); + EXPECT_EQ(expectedValue, gfxCoreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment())); EXPECT_EQ(expectedValue, pDevice->getDeviceInfo().computeUnitsUsedForScratch); } GEN11TEST_F(Gen11DeviceCaps, givenHwInfoWhenRequestedMaxFrontEndThreadsThenReturnValidValue) { const auto &hwInfo = pDevice->getHardwareInfo(); - EXPECT_EQ(HwHelper::getMaxThreadsForVfe(hwInfo), pDevice->getDeviceInfo().maxFrontEndThreads); + EXPECT_EQ(GfxCoreHelper::getMaxThreadsForVfe(hwInfo), pDevice->getDeviceInfo().maxFrontEndThreads); } GEN11TEST_F(Gen11DeviceCaps, givenGen11WhenCheckSupportCacheFlushAfterWalkerThenFalse) { diff --git a/shared/test/unit_test/gen11/test_preamble_gen11.cpp b/shared/test/unit_test/gen11/test_preamble_gen11.cpp index d31f97caca..c0cb5080d2 100644 --- a/shared/test/unit_test/gen11/test_preamble_gen11.cpp +++ b/shared/test/unit_test/gen11/test_preamble_gen11.cpp @@ -159,7 +159,7 @@ GEN11TEST_F(ThreadArbitrationGen11, whenThreadArbitrationPolicyIsProgrammedThenC } GEN11TEST_F(ThreadArbitrationGen11, GivenDefaultWhenProgrammingPreambleThenArbitrationPolicyIsRoundRobin) { - EXPECT_EQ(ThreadArbitrationPolicy::RoundRobinAfterDependency, HwHelperHw::get().getDefaultThreadArbitrationPolicy()); + EXPECT_EQ(ThreadArbitrationPolicy::RoundRobinAfterDependency, GfxCoreHelperHw::get().getDefaultThreadArbitrationPolicy()); } GEN11TEST_F(ThreadArbitrationGen11, whenGetSupportThreadArbitrationPoliciesIsCalledThenAllPoliciesAreReturned) { diff --git a/shared/test/unit_test/gen12lp/dg1/hw_helper_tests_dg1.cpp b/shared/test/unit_test/gen12lp/dg1/hw_helper_tests_dg1.cpp index fff92480ff..124135f3b4 100644 --- a/shared/test/unit_test/gen12lp/dg1/hw_helper_tests_dg1.cpp +++ b/shared/test/unit_test/gen12lp/dg1/hw_helper_tests_dg1.cpp @@ -13,30 +13,30 @@ #include "shared/test/common/mocks/mock_graphics_allocation.h" #include "shared/test/common/test_macros/header/per_product_test_definitions.h" -using HwHelperTestDg1 = HwHelperTest; +using GfxCoreHelperTestDg1 = GfxCoreHelperTest; -DG1TEST_F(HwHelperTestDg1, givenDg1SteppingA0WhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { - auto &coreHelper = getHelper(); +DG1TEST_F(GfxCoreHelperTestDg1, givenDg1SteppingA0WhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { + auto &gfxCoreHelper = getHelper(); const auto &productHelper = getHelper(); hardwareInfo.featureTable.flags.ftrCCSNode = true; hardwareInfo.platform.usRevId = productHelper.getHwRevIdFromStepping(REVISION_A0, hardwareInfo); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(aub_stream::ENGINE_RCS, hardwareInfo.capabilityTable.defaultEngineType); } -DG1TEST_F(HwHelperTestDg1, givenDg1SteppingBWhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { - auto &coreHelper = getHelper(); +DG1TEST_F(GfxCoreHelperTestDg1, givenDg1SteppingBWhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { + auto &gfxCoreHelper = getHelper(); const auto &productHelper = getHelper(); hardwareInfo.featureTable.flags.ftrCCSNode = true; hardwareInfo.platform.usRevId = productHelper.getHwRevIdFromStepping(REVISION_B, hardwareInfo); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(aub_stream::ENGINE_RCS, hardwareInfo.capabilityTable.defaultEngineType); } -DG1TEST_F(HwHelperTestDg1, givenDg1AndVariousSteppingsWhenGettingIsWorkaroundRequiredThenCorrectValueIsReturned) { - const auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); +DG1TEST_F(GfxCoreHelperTestDg1, givenDg1AndVariousSteppingsWhenGettingIsWorkaroundRequiredThenCorrectValueIsReturned) { + const auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); const auto &hwInfoConfig = *HwInfoConfig::get(hardwareInfo.platform.eProductFamily); uint32_t steppings[] = { REVISION_A0, @@ -48,33 +48,33 @@ DG1TEST_F(HwHelperTestDg1, givenDg1AndVariousSteppingsWhenGettingIsWorkaroundReq switch (stepping) { case REVISION_A0: - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); [[fallthrough]]; default: - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); } } } -DG1TEST_F(HwHelperTestDg1, givenBufferAllocationTypeWhenSetExtraAllocationDataIsCalledThenIsLockableIsSet) { - auto &hwHelper = HwHelper::get(renderCoreFamily); +DG1TEST_F(GfxCoreHelperTestDg1, givenBufferAllocationTypeWhenSetExtraAllocationDataIsCalledThenIsLockableIsSet) { + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); AllocationData allocData{}; allocData.flags.useSystemMemory = true; AllocationProperties allocProperties(0, 1, AllocationType::BUFFER, {}); allocData.storageInfo.isLockable = false; allocProperties.flags.shareable = false; - hwHelper.setExtraAllocationData(allocData, allocProperties, *defaultHwInfo); + gfxCoreHelper.setExtraAllocationData(allocData, allocProperties, *defaultHwInfo); EXPECT_TRUE(allocData.storageInfo.isLockable); } -DG1TEST_F(HwHelperTestDg1, givenBufferAllocationTypeWhenSetExtraAllocationDataIsCalledWithShareableSetThenIsLockableIsFalse) { - auto &hwHelper = HwHelper::get(renderCoreFamily); +DG1TEST_F(GfxCoreHelperTestDg1, givenBufferAllocationTypeWhenSetExtraAllocationDataIsCalledWithShareableSetThenIsLockableIsFalse) { + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); AllocationData allocData{}; allocData.flags.useSystemMemory = true; AllocationProperties allocProperties(0, 1, AllocationType::BUFFER, {}); allocData.storageInfo.isLockable = false; allocProperties.flags.shareable = true; - hwHelper.setExtraAllocationData(allocData, allocProperties, *defaultHwInfo); + gfxCoreHelper.setExtraAllocationData(allocData, allocProperties, *defaultHwInfo); EXPECT_FALSE(allocData.storageInfo.isLockable); } diff --git a/shared/test/unit_test/gen12lp/rkl/test_hw_helper_rkl.cpp b/shared/test/unit_test/gen12lp/rkl/test_hw_helper_rkl.cpp index e1753fabae..cef3cc3721 100644 --- a/shared/test/unit_test/gen12lp/rkl/test_hw_helper_rkl.cpp +++ b/shared/test/unit_test/gen12lp/rkl/test_hw_helper_rkl.cpp @@ -11,31 +11,31 @@ #include "shared/test/common/helpers/hw_helper_tests.h" #include "shared/test/common/test_macros/header/per_product_test_definitions.h" -using HwHelperTestRkl = HwHelperTest; +using GfxCoreHelperTestRkl = GfxCoreHelperTest; -RKLTEST_F(HwHelperTestRkl, givenRklSteppingA0WhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { - auto &coreHelper = getHelper(); +RKLTEST_F(GfxCoreHelperTestRkl, givenRklSteppingA0WhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { + auto &gfxCoreHelper = getHelper(); const auto &productHelper = getHelper(); hardwareInfo.featureTable.flags.ftrCCSNode = true; hardwareInfo.platform.usRevId = productHelper.getHwRevIdFromStepping(REVISION_A0, hardwareInfo); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(aub_stream::ENGINE_RCS, hardwareInfo.capabilityTable.defaultEngineType); } -RKLTEST_F(HwHelperTestRkl, givenRklSteppingBWhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { - auto &coreHelper = getHelper(); +RKLTEST_F(GfxCoreHelperTestRkl, givenRklSteppingBWhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { + auto &gfxCoreHelper = getHelper(); const auto &productHelper = getHelper(); hardwareInfo.featureTable.flags.ftrCCSNode = true; hardwareInfo.platform.usRevId = productHelper.getHwRevIdFromStepping(REVISION_B, hardwareInfo); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(aub_stream::ENGINE_RCS, hardwareInfo.capabilityTable.defaultEngineType); } -RKLTEST_F(HwHelperTestRkl, givenRklWhenRequestedVmeFlagsThenReturnFalse) { +RKLTEST_F(GfxCoreHelperTestRkl, givenRklWhenRequestedVmeFlagsThenReturnFalse) { EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.supportsVme); EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.ftrSupportsVmeAvcTextureSampler); EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.ftrSupportsVmeAvcPreemption); diff --git a/shared/test/unit_test/gen12lp/test_device_caps_gen12lp.inl b/shared/test/unit_test/gen12lp/test_device_caps_gen12lp.inl index d1e7fbc645..466a7c22b1 100644 --- a/shared/test/unit_test/gen12lp/test_device_caps_gen12lp.inl +++ b/shared/test/unit_test/gen12lp/test_device_caps_gen12lp.inl @@ -36,11 +36,11 @@ GEN12LPTEST_F(Gen12LpDeviceCaps, WhenCheckingCapsThenCompressionIsDisabled) { GEN12LPTEST_F(Gen12LpDeviceCaps, givenHwInfoWhenRequestedComputeUnitsUsedForScratchThenReturnValidValue) { const auto &hwInfo = pDevice->getHardwareInfo(); - auto &coreHelperl = getHelper(); + auto &gfxCoreHelperl = getHelper(); uint32_t expectedValue = hwInfo.gtSystemInfo.MaxSubSlicesSupported * hwInfo.gtSystemInfo.MaxEuPerSubSlice * 8; - EXPECT_EQ(expectedValue, coreHelperl.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment())); + EXPECT_EQ(expectedValue, gfxCoreHelperl.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment())); EXPECT_EQ(expectedValue, pDevice->getDeviceInfo().computeUnitsUsedForScratch); } diff --git a/shared/test/unit_test/gen12lp/test_preamble_gen12lp.cpp b/shared/test/unit_test/gen12lp/test_preamble_gen12lp.cpp index a6eb7820d1..01508802e6 100644 --- a/shared/test/unit_test/gen12lp/test_preamble_gen12lp.cpp +++ b/shared/test/unit_test/gen12lp/test_preamble_gen12lp.cpp @@ -214,7 +214,7 @@ HWTEST2_F(Gen12LpPreambleVfeState, givenDisableEUFusionAndCFEFusedEUDispatchWhen using ThreadArbitrationGen12Lp = PreambleFixture; GEN12LPTEST_F(ThreadArbitrationGen12Lp, whenGetDefaultThreadArbitrationPolicyIsCalledThenCorrectPolicyIsReturned) { - EXPECT_EQ(ThreadArbitrationPolicy::AgeBased, HwHelperHw::get().getDefaultThreadArbitrationPolicy()); + EXPECT_EQ(ThreadArbitrationPolicy::AgeBased, GfxCoreHelperHw::get().getDefaultThreadArbitrationPolicy()); } GEN12LPTEST_F(ThreadArbitrationGen12Lp, whenGetSupportThreadArbitrationPoliciesIsCalledThenEmptyVectorIsReturned) { diff --git a/shared/test/unit_test/gen12lp/tgllp/test_hw_helper_tgllp.cpp b/shared/test/unit_test/gen12lp/tgllp/test_hw_helper_tgllp.cpp index d471c5c6b3..a765c38bcd 100644 --- a/shared/test/unit_test/gen12lp/tgllp/test_hw_helper_tgllp.cpp +++ b/shared/test/unit_test/gen12lp/tgllp/test_hw_helper_tgllp.cpp @@ -11,44 +11,44 @@ #include "shared/test/common/helpers/hw_helper_tests.h" #include "shared/test/common/test_macros/header/per_product_test_definitions.h" -using HwHelperTestGen12Lp = HwHelperTest; +using GfxCoreHelperTestGen12Lp = GfxCoreHelperTest; -TGLLPTEST_F(HwHelperTestGen12Lp, givenTgllpSteppingA0WhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { - auto &coreHelper = getHelper(); +TGLLPTEST_F(GfxCoreHelperTestGen12Lp, givenTgllpSteppingA0WhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { + auto &gfxCoreHelper = getHelper(); const auto &productHelper = getHelper(); hardwareInfo.featureTable.flags.ftrCCSNode = true; hardwareInfo.platform.usRevId = productHelper.getHwRevIdFromStepping(REVISION_A0, hardwareInfo); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(aub_stream::ENGINE_RCS, hardwareInfo.capabilityTable.defaultEngineType); } -TGLLPTEST_F(HwHelperTestGen12Lp, givenTgllpSteppingBWhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { - auto &coreHelper = getHelper(); +TGLLPTEST_F(GfxCoreHelperTestGen12Lp, givenTgllpSteppingBWhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { + auto &gfxCoreHelper = getHelper(); const auto &productHelper = getHelper(); hardwareInfo.featureTable.flags.ftrCCSNode = true; hardwareInfo.platform.usRevId = productHelper.getHwRevIdFromStepping(REVISION_A1, hardwareInfo); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(aub_stream::ENGINE_RCS, hardwareInfo.capabilityTable.defaultEngineType); } -TGLLPTEST_F(HwHelperTestGen12Lp, givenTgllWhenWaForDefaultEngineIsNotAppliedThenCcsIsReturned) { - auto &coreHelper = getHelper(); +TGLLPTEST_F(GfxCoreHelperTestGen12Lp, givenTgllWhenWaForDefaultEngineIsNotAppliedThenCcsIsReturned) { + auto &gfxCoreHelper = getHelper(); const auto &productHelper = getHelper(); hardwareInfo.featureTable.flags.ftrCCSNode = true; hardwareInfo.platform.usRevId = productHelper.getHwRevIdFromStepping(REVISION_A0, hardwareInfo); hardwareInfo.platform.eProductFamily = IGFX_UNKNOWN; - coreHelper.adjustDefaultEngineType(&hardwareInfo); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(aub_stream::ENGINE_RCS, hardwareInfo.capabilityTable.defaultEngineType); } -TGLLPTEST_F(HwHelperTestGen12Lp, givenTgllpAndVariousSteppingsWhenGettingIsWorkaroundRequiredThenCorrectValueIsReturned) { - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); +TGLLPTEST_F(GfxCoreHelperTestGen12Lp, givenTgllpAndVariousSteppingsWhenGettingIsWorkaroundRequiredThenCorrectValueIsReturned) { + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); const auto &hwInfoConfig = *HwInfoConfig::get(hardwareInfo.platform.eProductFamily); uint32_t steppings[] = { REVISION_A0, @@ -61,14 +61,14 @@ TGLLPTEST_F(HwHelperTestGen12Lp, givenTgllpAndVariousSteppingsWhenGettingIsWorka switch (stepping) { case REVISION_A0: - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); [[fallthrough]]; case REVISION_B: - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); [[fallthrough]]; default: - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); } } } diff --git a/shared/test/unit_test/gen8/hw_helper_tests_gen8.cpp b/shared/test/unit_test/gen8/hw_helper_tests_gen8.cpp index cce1e3a726..c1c7506b1d 100644 --- a/shared/test/unit_test/gen8/hw_helper_tests_gen8.cpp +++ b/shared/test/unit_test/gen8/hw_helper_tests_gen8.cpp @@ -13,27 +13,27 @@ #include "shared/test/common/test_macros/header/per_product_test_definitions.h" #include "shared/test/unit_test/helpers/get_gpgpu_engines_tests.inl" -using HwHelperTestGen8 = HwHelperTest; +using GfxCoreHelperTestGen8 = GfxCoreHelperTest; -GEN8TEST_F(HwHelperTestGen8, WhenGettingMaxBarriersPerSliceThenCorrectSizeIsReturned) { - auto &helper = getHelper(); +GEN8TEST_F(GfxCoreHelperTestGen8, WhenGettingMaxBarriersPerSliceThenCorrectSizeIsReturned) { + auto &helper = getHelper(); EXPECT_EQ(16u, helper.getMaxBarrierRegisterPerSlice()); } -GEN8TEST_F(HwHelperTestGen8, WhenGettingPitchAlignmentForImageThenCorrectValueIsReturned) { - auto &coreHelper = getHelper(); - EXPECT_EQ(4u, coreHelper.getPitchAlignmentForImage(pDevice->getRootDeviceEnvironment())); +GEN8TEST_F(GfxCoreHelperTestGen8, WhenGettingPitchAlignmentForImageThenCorrectValueIsReturned) { + auto &gfxCoreHelper = getHelper(); + EXPECT_EQ(4u, gfxCoreHelper.getPitchAlignmentForImage(pDevice->getRootDeviceEnvironment())); } -GEN8TEST_F(HwHelperTestGen8, WhenAdjustingDefaultEngineTypeThenEngineTypeIsSet) { +GEN8TEST_F(GfxCoreHelperTestGen8, WhenAdjustingDefaultEngineTypeThenEngineTypeIsSet) { auto engineType = hardwareInfo.capabilityTable.defaultEngineType; - auto &coreHelper = getHelper(); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + auto &gfxCoreHelper = getHelper(); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(engineType, hardwareInfo.capabilityTable.defaultEngineType); } -GEN8TEST_F(HwHelperTestGen8, whenGetGpgpuEnginesThenReturnThreeEngines) { +GEN8TEST_F(GfxCoreHelperTestGen8, whenGetGpgpuEnginesThenReturnThreeEngines) { whenGetGpgpuEnginesThenReturnTwoRcsEngines(pDevice->getHardwareInfo()); EXPECT_EQ(3u, pDevice->allEngines.size()); } diff --git a/shared/test/unit_test/gen8/test_device_caps_gen8.cpp b/shared/test/unit_test/gen8/test_device_caps_gen8.cpp index b0eaaf953e..15c4246797 100644 --- a/shared/test/unit_test/gen8/test_device_caps_gen8.cpp +++ b/shared/test/unit_test/gen8/test_device_caps_gen8.cpp @@ -26,19 +26,19 @@ GEN8TEST_F(Gen8DeviceCaps, BdwProfilingTimerResolution) { GEN8TEST_F(Gen8DeviceCaps, givenHwInfoWhenRequestedComputeUnitsUsedForScratchThenReturnValidValue) { const auto &hwInfo = pDevice->getHardwareInfo(); - auto &coreHelper = getHelper(); + auto &gfxCoreHelper = getHelper(); uint32_t expectedValue = hwInfo.gtSystemInfo.MaxSubSlicesSupported * hwInfo.gtSystemInfo.MaxEuPerSubSlice * hwInfo.gtSystemInfo.ThreadCount / hwInfo.gtSystemInfo.EUCount; - EXPECT_EQ(expectedValue, coreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment())); + EXPECT_EQ(expectedValue, gfxCoreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment())); EXPECT_EQ(expectedValue, pDevice->getDeviceInfo().computeUnitsUsedForScratch); } GEN8TEST_F(Gen8DeviceCaps, givenHwInfoWhenRequestedMaxFrontEndThreadsThenReturnValidValue) { const auto &hwInfo = pDevice->getHardwareInfo(); - EXPECT_EQ(HwHelper::getMaxThreadsForVfe(hwInfo), pDevice->getDeviceInfo().maxFrontEndThreads); + EXPECT_EQ(GfxCoreHelper::getMaxThreadsForVfe(hwInfo), pDevice->getDeviceInfo().maxFrontEndThreads); } GEN8TEST_F(Gen8DeviceCaps, GivenBdwWhenCheckftr64KBpagesThenFalse) { diff --git a/shared/test/unit_test/gen8/test_preamble_gen8.cpp b/shared/test/unit_test/gen8/test_preamble_gen8.cpp index 70c72f286c..012849f3af 100644 --- a/shared/test/unit_test/gen8/test_preamble_gen8.cpp +++ b/shared/test/unit_test/gen8/test_preamble_gen8.cpp @@ -71,7 +71,7 @@ BDWTEST_F(ThreadArbitrationGen8, givenPolicyWhenThreadArbitrationProgrammedThenD MockDevice device; EXPECT_EQ(0u, PreambleHelper::getAdditionalCommandsSize(device)); - EXPECT_EQ(ThreadArbitrationPolicy::AgeBased, HwHelperHw::get().getDefaultThreadArbitrationPolicy()); + EXPECT_EQ(ThreadArbitrationPolicy::AgeBased, GfxCoreHelperHw::get().getDefaultThreadArbitrationPolicy()); } BDWTEST_F(ThreadArbitrationGen8, whenGetSupportThreadArbitrationPoliciesIsCalledThenEmptyVectorIsReturned) { diff --git a/shared/test/unit_test/gen9/hw_helper_tests_gen9.cpp b/shared/test/unit_test/gen9/hw_helper_tests_gen9.cpp index 10350df881..0a86b49592 100644 --- a/shared/test/unit_test/gen9/hw_helper_tests_gen9.cpp +++ b/shared/test/unit_test/gen9/hw_helper_tests_gen9.cpp @@ -11,45 +11,45 @@ #include "shared/test/common/test_macros/header/per_product_test_definitions.h" #include "shared/test/unit_test/helpers/get_gpgpu_engines_tests.inl" -using HwHelperTestGen9 = HwHelperTest; +using GfxCoreHelperTestGen9 = GfxCoreHelperTest; -GEN9TEST_F(HwHelperTestGen9, WhenGettingMaxBarriersPerSliceThenCorrectSizeIsReturned) { - auto &helper = getHelper(); +GEN9TEST_F(GfxCoreHelperTestGen9, WhenGettingMaxBarriersPerSliceThenCorrectSizeIsReturned) { + auto &helper = getHelper(); EXPECT_EQ(32u, helper.getMaxBarrierRegisterPerSlice()); } -GEN9TEST_F(HwHelperTestGen9, givenGen9WhenCallIsPackedSupportedThenReturnFalse) { - auto &helper = HwHelper::get(renderCoreFamily); +GEN9TEST_F(GfxCoreHelperTestGen9, givenGen9WhenCallIsPackedSupportedThenReturnFalse) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_FALSE(helper.packedFormatsSupported()); } -GEN9TEST_F(HwHelperTestGen9, WhenGettingPitchAlignmentForImageThenCorrectValueIsReturned) { - auto &coreHelper = getHelper(); - EXPECT_EQ(4u, coreHelper.getPitchAlignmentForImage(pDevice->getRootDeviceEnvironment())); +GEN9TEST_F(GfxCoreHelperTestGen9, WhenGettingPitchAlignmentForImageThenCorrectValueIsReturned) { + auto &gfxCoreHelper = getHelper(); + EXPECT_EQ(4u, gfxCoreHelper.getPitchAlignmentForImage(pDevice->getRootDeviceEnvironment())); } -GEN9TEST_F(HwHelperTestGen9, WhenAdjustingDefaultEngineTypeThenEngineTypeIsSet) { +GEN9TEST_F(GfxCoreHelperTestGen9, WhenAdjustingDefaultEngineTypeThenEngineTypeIsSet) { auto engineType = hardwareInfo.capabilityTable.defaultEngineType; - auto &coreHelper = getHelper(); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + auto &gfxCoreHelper = getHelper(); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(engineType, hardwareInfo.capabilityTable.defaultEngineType); } -GEN9TEST_F(HwHelperTestGen9, givenDebuggingActiveWhenSipKernelTypeIsQueriedThenDbgCsrLocalTypeIsReturned) { - auto &coreHelper = getHelper(); +GEN9TEST_F(GfxCoreHelperTestGen9, givenDebuggingActiveWhenSipKernelTypeIsQueriedThenDbgCsrLocalTypeIsReturned) { + auto &gfxCoreHelper = getHelper(); - auto sipType = coreHelper.getSipKernelType(true); + auto sipType = gfxCoreHelper.getSipKernelType(true); EXPECT_EQ(SipKernelType::DbgCsrLocal, sipType); } -GEN9TEST_F(HwHelperTestGen9, whenGetGpgpuEnginesThenReturnThreeRcsEngines) { +GEN9TEST_F(GfxCoreHelperTestGen9, whenGetGpgpuEnginesThenReturnThreeRcsEngines) { whenGetGpgpuEnginesThenReturnTwoRcsEngines(pDevice->getHardwareInfo()); EXPECT_EQ(3u, pDevice->allEngines.size()); } -GEN9TEST_F(HwHelperTestGen9, givenGen9WhenCallIsTimestampShiftRequiredThenFalseIsReturned) { - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - EXPECT_FALSE(hwHelper.isTimestampShiftRequired()); +GEN9TEST_F(GfxCoreHelperTestGen9, givenGen9WhenCallIsTimestampShiftRequiredThenFalseIsReturned) { + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.isTimestampShiftRequired()); } using MemorySynchronizatiopCommandsTestsGen9 = ::testing::Test; diff --git a/shared/test/unit_test/gen9/test_device_caps_gen9.cpp b/shared/test/unit_test/gen9/test_device_caps_gen9.cpp index df63eacd34..b3dc2a1e41 100644 --- a/shared/test/unit_test/gen9/test_device_caps_gen9.cpp +++ b/shared/test/unit_test/gen9/test_device_caps_gen9.cpp @@ -26,19 +26,19 @@ GEN9TEST_F(Gen9DeviceCaps, WhenCheckingCompressionThenItIsDisabled) { GEN9TEST_F(Gen9DeviceCaps, givenHwInfoWhenRequestedComputeUnitsUsedForScratchThenReturnValidValue) { const auto &hwInfo = pDevice->getHardwareInfo(); - auto &coreHelper = getHelper(); + auto &gfxCoreHelper = getHelper(); uint32_t expectedValue = hwInfo.gtSystemInfo.MaxSubSlicesSupported * hwInfo.gtSystemInfo.MaxEuPerSubSlice * hwInfo.gtSystemInfo.ThreadCount / hwInfo.gtSystemInfo.EUCount; - EXPECT_EQ(expectedValue, coreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment())); + EXPECT_EQ(expectedValue, gfxCoreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment())); EXPECT_EQ(expectedValue, pDevice->getDeviceInfo().computeUnitsUsedForScratch); } GEN9TEST_F(Gen9DeviceCaps, givenHwInfoWhenRequestedMaxFrontEndThreadsThenReturnValidValue) { const auto &hwInfo = pDevice->getHardwareInfo(); - EXPECT_EQ(HwHelper::getMaxThreadsForVfe(hwInfo), pDevice->getDeviceInfo().maxFrontEndThreads); + EXPECT_EQ(GfxCoreHelper::getMaxThreadsForVfe(hwInfo), pDevice->getDeviceInfo().maxFrontEndThreads); } GEN9TEST_F(Gen9DeviceCaps, givenHwInfoWhenSlmSizeIsRequiredThenReturnCorrectValue) { diff --git a/shared/test/unit_test/gen9/test_preamble_gen9.cpp b/shared/test/unit_test/gen9/test_preamble_gen9.cpp index 174e96d483..d03044aaf4 100644 --- a/shared/test/unit_test/gen9/test_preamble_gen9.cpp +++ b/shared/test/unit_test/gen9/test_preamble_gen9.cpp @@ -73,7 +73,7 @@ GEN9TEST_F(Gen9L3Config, GivenSlmWhenProgrammingL3ThenProgrammingIsCorrect) { using ThreadArbitration = PreambleFixture; GEN9TEST_F(ThreadArbitration, GivenDefaultWhenProgrammingPreambleThenArbitrationPolicyIsRoundRobin) { - EXPECT_EQ(ThreadArbitrationPolicy::RoundRobin, HwHelperHw::get().getDefaultThreadArbitrationPolicy()); + EXPECT_EQ(ThreadArbitrationPolicy::RoundRobin, GfxCoreHelperHw::get().getDefaultThreadArbitrationPolicy()); } GEN9TEST_F(ThreadArbitration, whenGetSupportedThreadArbitrationPoliciesIsCalledThenAgeBasedAndRoundRobinAreReturned) { diff --git a/shared/test/unit_test/helpers/engine_node_helper_tests_xehp_and_later.cpp b/shared/test/unit_test/helpers/engine_node_helper_tests_xehp_and_later.cpp index 0c6f46ab02..8f76e7c50a 100644 --- a/shared/test/unit_test/helpers/engine_node_helper_tests_xehp_and_later.cpp +++ b/shared/test/unit_test/helpers/engine_node_helper_tests_xehp_and_later.cpp @@ -73,7 +73,7 @@ HWTEST2_F(EngineNodeHelperTestsXeHPAndLater, givenEnableCmdQRoundRobindBcsEngine int32_t expectedEngineType = aub_stream::EngineType::ENGINE_BCS1; for (int32_t i = 0; i <= 20; i++) { - while (!HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, static_cast(expectedEngineType)) || !hwInfo.featureTable.ftrBcsInfo.test(expectedEngineType - aub_stream::EngineType::ENGINE_BCS1 + 1)) { + while (!GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, static_cast(expectedEngineType)) || !hwInfo.featureTable.ftrBcsInfo.test(expectedEngineType - aub_stream::EngineType::ENGINE_BCS1 + 1)) { expectedEngineType++; if (static_cast(expectedEngineType) > aub_stream::EngineType::ENGINE_BCS8) { expectedEngineType = aub_stream::EngineType::ENGINE_BCS1; @@ -102,9 +102,9 @@ HWTEST2_F(EngineNodeHelperTestsXeHPAndLater, givenEnableCmdQRoundRobindBcsEngine int32_t expectedEngineType = aub_stream::EngineType::ENGINE_BCS; for (int32_t i = 0; i <= 20; i++) { - while (!HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, static_cast(expectedEngineType)) || !hwInfo.featureTable.ftrBcsInfo.test(expectedEngineType == aub_stream::EngineType::ENGINE_BCS - ? 0 - : expectedEngineType - aub_stream::EngineType::ENGINE_BCS1 + 1)) { + while (!GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, static_cast(expectedEngineType)) || !hwInfo.featureTable.ftrBcsInfo.test(expectedEngineType == aub_stream::EngineType::ENGINE_BCS + ? 0 + : expectedEngineType - aub_stream::EngineType::ENGINE_BCS1 + 1)) { if (expectedEngineType == aub_stream::EngineType::ENGINE_BCS) { expectedEngineType = aub_stream::EngineType::ENGINE_BCS1; } else { @@ -142,9 +142,9 @@ HWTEST2_F(EngineNodeHelperTestsXeHPAndLater, givenEnableCmdQRoundRobindBcsEngine int32_t expectedEngineType = aub_stream::EngineType::ENGINE_BCS; for (int32_t i = 0; i <= 20; i++) { - while (!HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, static_cast(expectedEngineType)) || !hwInfo.featureTable.ftrBcsInfo.test(expectedEngineType == aub_stream::EngineType::ENGINE_BCS - ? 0 - : expectedEngineType - aub_stream::EngineType::ENGINE_BCS1 + 1)) { + while (!GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, static_cast(expectedEngineType)) || !hwInfo.featureTable.ftrBcsInfo.test(expectedEngineType == aub_stream::EngineType::ENGINE_BCS + ? 0 + : expectedEngineType - aub_stream::EngineType::ENGINE_BCS1 + 1)) { if (expectedEngineType == aub_stream::EngineType::ENGINE_BCS) { expectedEngineType = aub_stream::EngineType::ENGINE_BCS1; } else { @@ -181,9 +181,9 @@ HWTEST2_F(EngineNodeHelperTestsXeHPAndLater, givenEnableCmdQRoundRobindBcsEngine int32_t expectedEngineType = aub_stream::EngineType::ENGINE_BCS1; for (int32_t i = 0; i <= 20; i++) { - while (!HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, static_cast(expectedEngineType)) || !hwInfo.featureTable.ftrBcsInfo.test(expectedEngineType == aub_stream::EngineType::ENGINE_BCS - ? 0 - : expectedEngineType - aub_stream::EngineType::ENGINE_BCS1 + 1)) { + while (!GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, static_cast(expectedEngineType)) || !hwInfo.featureTable.ftrBcsInfo.test(expectedEngineType == aub_stream::EngineType::ENGINE_BCS + ? 0 + : expectedEngineType - aub_stream::EngineType::ENGINE_BCS1 + 1)) { if (expectedEngineType == aub_stream::EngineType::ENGINE_BCS) { expectedEngineType = aub_stream::EngineType::ENGINE_BCS1; } else { @@ -221,9 +221,9 @@ HWTEST2_F(EngineNodeHelperTestsXeHPAndLater, givenEnableCmdQRoundRobindBcsEngine int32_t expectedEngineType = aub_stream::EngineType::ENGINE_BCS3; for (int32_t i = 0; i <= 20; i++) { - while (!HwHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, static_cast(expectedEngineType)) || !hwInfo.featureTable.ftrBcsInfo.test(expectedEngineType == aub_stream::EngineType::ENGINE_BCS - ? 0 - : expectedEngineType - aub_stream::EngineType::ENGINE_BCS1 + 1)) { + while (!GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).isSubDeviceEngineSupported(hwInfo, deviceBitfield, static_cast(expectedEngineType)) || !hwInfo.featureTable.ftrBcsInfo.test(expectedEngineType == aub_stream::EngineType::ENGINE_BCS + ? 0 + : expectedEngineType - aub_stream::EngineType::ENGINE_BCS1 + 1)) { if (expectedEngineType == aub_stream::EngineType::ENGINE_BCS) { expectedEngineType = aub_stream::EngineType::ENGINE_BCS1; } else { diff --git a/shared/test/unit_test/helpers/get_gpgpu_engines_tests.inl b/shared/test/unit_test/helpers/get_gpgpu_engines_tests.inl index f535e70f5c..39378cdc54 100644 --- a/shared/test/unit_test/helpers/get_gpgpu_engines_tests.inl +++ b/shared/test/unit_test/helpers/get_gpgpu_engines_tests.inl @@ -12,7 +12,7 @@ using namespace NEO; template void whenGetGpgpuEnginesThenReturnTwoRcsEngines(const HardwareInfo &hwInfo) { - auto gpgpuEngines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto gpgpuEngines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, gpgpuEngines.size()); EXPECT_EQ(aub_stream::ENGINE_RCS, gpgpuEngines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, gpgpuEngines[1].first); diff --git a/shared/test/unit_test/helpers/hw_helper_default_tests.cpp b/shared/test/unit_test/helpers/hw_helper_default_tests.cpp index 8428f7ed73..77a6bde40b 100644 --- a/shared/test/unit_test/helpers/hw_helper_default_tests.cpp +++ b/shared/test/unit_test/helpers/hw_helper_default_tests.cpp @@ -10,14 +10,14 @@ #include "shared/test/common/helpers/hw_helper_tests.h" #include "shared/test/common/test_macros/hw_test.h" -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, givenHwHelperWhenAskedForHvAlign4RequiredThenReturnTrue) { - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); - EXPECT_TRUE(hwHelper.hvAlign4Required()); +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, givenGfxCoreHelperWhenAskedForHvAlign4RequiredThenReturnTrue) { + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + EXPECT_TRUE(gfxCoreHelper.hvAlign4Required()); } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, givenHwHelperWhenGettingBindlessSurfaceExtendedMessageDescriptorValueThenCorrectValueIsReturned) { - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); - auto value = hwHelper.getBindlessSurfaceExtendedMessageDescriptorValue(0x200); +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, givenGfxCoreHelperWhenGettingBindlessSurfaceExtendedMessageDescriptorValueThenCorrectValueIsReturned) { + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto value = gfxCoreHelper.getBindlessSurfaceExtendedMessageDescriptorValue(0x200); typename FamilyType::DataPortBindlessSurfaceExtendedMessageDescriptor messageExtDescriptor = {}; messageExtDescriptor.setBindlessSurfaceOffset(0x200); diff --git a/shared/test/unit_test/helpers/hw_helper_tests.cpp b/shared/test/unit_test/helpers/hw_helper_tests.cpp index 9570ce67f2..403a5cdd83 100644 --- a/shared/test/unit_test/helpers/hw_helper_tests.cpp +++ b/shared/test/unit_test/helpers/hw_helper_tests.cpp @@ -25,58 +25,58 @@ #include -TEST(HwHelperSimpleTest, givenDebugVariableWhenAskingForCompressionThenReturnCorrectValue) { +TEST(GfxCoreHelperSimpleTest, givenDebugVariableWhenAskingForCompressionThenReturnCorrectValue) { DebugManagerStateRestore restore; HardwareInfo localHwInfo = *defaultHwInfo; // debug variable not set localHwInfo.capabilityTable.ftrRenderCompressedBuffers = false; localHwInfo.capabilityTable.ftrRenderCompressedImages = false; - EXPECT_FALSE(HwHelper::compressedBuffersSupported(localHwInfo)); - EXPECT_FALSE(HwHelper::compressedImagesSupported(localHwInfo)); + EXPECT_FALSE(GfxCoreHelper::compressedBuffersSupported(localHwInfo)); + EXPECT_FALSE(GfxCoreHelper::compressedImagesSupported(localHwInfo)); localHwInfo.capabilityTable.ftrRenderCompressedBuffers = true; localHwInfo.capabilityTable.ftrRenderCompressedImages = true; - EXPECT_TRUE(HwHelper::compressedBuffersSupported(localHwInfo)); - EXPECT_TRUE(HwHelper::compressedImagesSupported(localHwInfo)); + EXPECT_TRUE(GfxCoreHelper::compressedBuffersSupported(localHwInfo)); + EXPECT_TRUE(GfxCoreHelper::compressedImagesSupported(localHwInfo)); // debug variable set DebugManager.flags.RenderCompressedBuffersEnabled.set(1); DebugManager.flags.RenderCompressedImagesEnabled.set(1); localHwInfo.capabilityTable.ftrRenderCompressedBuffers = false; localHwInfo.capabilityTable.ftrRenderCompressedImages = false; - EXPECT_TRUE(HwHelper::compressedBuffersSupported(localHwInfo)); - EXPECT_TRUE(HwHelper::compressedImagesSupported(localHwInfo)); + EXPECT_TRUE(GfxCoreHelper::compressedBuffersSupported(localHwInfo)); + EXPECT_TRUE(GfxCoreHelper::compressedImagesSupported(localHwInfo)); DebugManager.flags.RenderCompressedBuffersEnabled.set(0); DebugManager.flags.RenderCompressedImagesEnabled.set(0); localHwInfo.capabilityTable.ftrRenderCompressedBuffers = true; localHwInfo.capabilityTable.ftrRenderCompressedImages = true; - EXPECT_FALSE(HwHelper::compressedBuffersSupported(localHwInfo)); - EXPECT_FALSE(HwHelper::compressedImagesSupported(localHwInfo)); + EXPECT_FALSE(GfxCoreHelper::compressedBuffersSupported(localHwInfo)); + EXPECT_FALSE(GfxCoreHelper::compressedImagesSupported(localHwInfo)); } -TEST_F(HwHelperTest, WhenGettingHelperThenValidHelperReturned) { - auto &helper = HwHelper::get(renderCoreFamily); +TEST_F(GfxCoreHelperTest, WhenGettingHelperThenValidHelperReturned) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_NE(nullptr, &helper); } -HWTEST_F(HwHelperTest, givenHwHelperWhenAskingForTimestampPacketAlignmentThenReturnFourCachelines) { - auto &helper = HwHelper::get(renderCoreFamily); +HWTEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenAskingForTimestampPacketAlignmentThenReturnFourCachelines) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); constexpr auto expectedAlignment = MemoryConstants::cacheLineSize * 4; EXPECT_EQ(expectedAlignment, helper.getTimestampPacketAllocatorAlignment()); } -HWTEST2_F(HwHelperTest, givenHwHelperWhenGettingISAPaddingThenCorrectValueIsReturned, IsAtMostXeHpgCore) { - auto &helper = getHelper(); +HWTEST2_F(GfxCoreHelperTest, givenGfxCoreHelperWhenGettingISAPaddingThenCorrectValueIsReturned, IsAtMostXeHpgCore) { + auto &helper = getHelper(); EXPECT_EQ(helper.getPaddingForISAAllocation(), 512u); } -HWTEST_F(HwHelperTest, givenForceExtendedKernelIsaSizeSetWhenGettingISAPaddingThenCorrectValueIsReturned) { +HWTEST_F(GfxCoreHelperTest, givenForceExtendedKernelIsaSizeSetWhenGettingISAPaddingThenCorrectValueIsReturned) { DebugManagerStateRestore restore; - auto &helper = getHelper(); + auto &helper = getHelper(); auto defaultPadding = helper.getPaddingForISAAllocation(); for (int32_t valueToTest : {0, 1, 2, 10}) { @@ -85,21 +85,21 @@ HWTEST_F(HwHelperTest, givenForceExtendedKernelIsaSizeSetWhenGettingISAPaddingTh } } -HWTEST_F(HwHelperTest, WhenSettingRenderSurfaceStateForBufferThenL1CachePolicyIsSet) { +HWTEST_F(GfxCoreHelperTest, WhenSettingRenderSurfaceStateForBufferThenL1CachePolicyIsSet) { using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; using SURFACE_TYPE = typename RENDER_SURFACE_STATE::SURFACE_TYPE; - class MockHwHelperHw : public HwHelperHw { + class MockGfxCoreHelperHw : public GfxCoreHelperHw { public: bool called = false; - using HwHelperHw::HwHelperHw; - MockHwHelperHw() {} + using GfxCoreHelperHw::GfxCoreHelperHw; + MockGfxCoreHelperHw() {} void setL1CachePolicy(bool useL1Cache, typename FamilyType::RENDER_SURFACE_STATE *surfaceState, const HardwareInfo *hwInfo) override { - HwHelperHw::setL1CachePolicy(useL1Cache, surfaceState, hwInfo); + GfxCoreHelperHw::setL1CachePolicy(useL1Cache, surfaceState, hwInfo); called = true; } }; - MockHwHelperHw helper; + MockGfxCoreHelperHw helper; void *stateBuffer = alignedMalloc(sizeof(RENDER_SURFACE_STATE), sizeof(RENDER_SURFACE_STATE)); ASSERT_NE(nullptr, stateBuffer); memset(stateBuffer, 0, sizeof(RENDER_SURFACE_STATE)); @@ -125,16 +125,16 @@ HWTEST_F(HwHelperTest, WhenSettingRenderSurfaceStateForBufferThenL1CachePolicyIs alignedFree(stateBuffer); } -TEST_F(HwHelperTest, givenDebuggingInactiveWhenSipKernelTypeIsQueriedThenCsrTypeIsReturned) { - auto &coreHelper = getHelper(); - EXPECT_NE(nullptr, &coreHelper); +TEST_F(GfxCoreHelperTest, givenDebuggingInactiveWhenSipKernelTypeIsQueriedThenCsrTypeIsReturned) { + auto &gfxCoreHelper = getHelper(); + EXPECT_NE(nullptr, &gfxCoreHelper); - auto sipType = coreHelper.getSipKernelType(false); + auto sipType = gfxCoreHelper.getSipKernelType(false); EXPECT_EQ(SipKernelType::Csr, sipType); } -TEST_F(HwHelperTest, givenEngineTypeRcsWhenCsTraitsAreQueiredThenCorrectNameInTraitsIsReturned) { - auto &helper = HwHelper::get(renderCoreFamily); +TEST_F(GfxCoreHelperTest, givenEngineTypeRcsWhenCsTraitsAreQueiredThenCorrectNameInTraitsIsReturned) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_NE(nullptr, &helper); auto &csTraits = helper.getCsTraits(aub_stream::ENGINE_RCS); @@ -142,16 +142,16 @@ TEST_F(HwHelperTest, givenEngineTypeRcsWhenCsTraitsAreQueiredThenCorrectNameInTr } using isTglLpOrBelow = IsAtMostProduct; -HWTEST2_F(HwHelperTest, givenHwHelperWhenGettingThreadsPerEUConfigsThenNoConfigsAreReturned, isTglLpOrBelow) { - auto &helper = HwHelper::get(renderCoreFamily); +HWTEST2_F(GfxCoreHelperTest, givenGfxCoreHelperWhenGettingThreadsPerEUConfigsThenNoConfigsAreReturned, isTglLpOrBelow) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); auto &configs = helper.getThreadsPerEUConfigs(); EXPECT_EQ(0U, configs.size()); } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, givenHwHelperWhenGetGpuTimeStampInNSIsCalledThenCorrectValueIsReturned) { +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, givenGfxCoreHelperWhenGetGpuTimeStampInNSIsCalledThenCorrectValueIsReturned) { - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); auto timeStamp = 0x00ff'ffff'ffff; auto frequency = 123456.0; auto result = static_cast(timeStamp * frequency); @@ -253,7 +253,7 @@ HWTEST_F(PipeControlHelperTests, givenPostSyncWriteTimestampModeWhenHelperIsUsed EXPECT_TRUE(memcmp(pipeControl, &expectedPipeControl, sizeof(PIPE_CONTROL)) == 0); } -HWTEST_F(PipeControlHelperTests, givenHwHelperwhenAskingForDcFlushThenReturnTrue) { +HWTEST_F(PipeControlHelperTests, givenGfxCoreHelperwhenAskingForDcFlushThenReturnTrue) { EXPECT_TRUE(MemorySynchronizationCommands::getDcFlushEnable(true, *defaultHwInfo)); } @@ -390,7 +390,7 @@ TEST(HwInfoTest, givenNodeOrdinalSetWhenChosenEngineTypeQueriedThenSetValueIsRet EXPECT_EQ(aub_stream::ENGINE_VECS, engineType); } -HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenNoAllocationProvidedThenUseArgumentsasInput) { +HWTEST_F(GfxCoreHelperTest, givenCreatedSurfaceStateBufferWhenNoAllocationProvidedThenUseArgumentsasInput) { using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; using SURFACE_TYPE = typename RENDER_SURFACE_STATE::SURFACE_TYPE; @@ -400,7 +400,7 @@ HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenNoAllocationProvidedThe void *stateBuffer = alignedMalloc(sizeof(RENDER_SURFACE_STATE), sizeof(RENDER_SURFACE_STATE)); ASSERT_NE(nullptr, stateBuffer); memset(stateBuffer, 0, sizeof(RENDER_SURFACE_STATE)); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_EQ(sizeof(RENDER_SURFACE_STATE), helper.getRenderSurfaceStateSize()); size_t size = 0x1000; @@ -457,7 +457,7 @@ HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenNoAllocationProvidedThe alignedFree(stateBuffer); } -HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenAllocationProvidedThenUseAllocationAsInput) { +HWTEST_F(GfxCoreHelperTest, givenCreatedSurfaceStateBufferWhenAllocationProvidedThenUseAllocationAsInput) { using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; using SURFACE_TYPE = typename RENDER_SURFACE_STATE::SURFACE_TYPE; using AUXILIARY_SURFACE_MODE = typename RENDER_SURFACE_STATE::AUXILIARY_SURFACE_MODE; @@ -468,7 +468,7 @@ HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenAllocationProvidedThenU RENDER_SURFACE_STATE *state = reinterpret_cast(stateBuffer); memset(stateBuffer, 0, sizeof(RENDER_SURFACE_STATE)); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); size_t size = 0x1000; SURFACE_STATE_BUFFER_LENGTH length; @@ -496,7 +496,7 @@ HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenAllocationProvidedThenU alignedFree(stateBuffer); } -HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenGmmAndAllocationCompressionEnabledAnNonAuxDisabledThenSetCoherencyToGpuAndAuxModeToCompression) { +HWTEST_F(GfxCoreHelperTest, givenCreatedSurfaceStateBufferWhenGmmAndAllocationCompressionEnabledAnNonAuxDisabledThenSetCoherencyToGpuAndAuxModeToCompression) { using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; using SURFACE_TYPE = typename RENDER_SURFACE_STATE::SURFACE_TYPE; using AUXILIARY_SURFACE_MODE = typename RENDER_SURFACE_STATE::AUXILIARY_SURFACE_MODE; @@ -507,7 +507,7 @@ HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenGmmAndAllocationCompres RENDER_SURFACE_STATE *state = reinterpret_cast(stateBuffer); memset(stateBuffer, 0, sizeof(RENDER_SURFACE_STATE)); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); size_t size = 0x1000; uint64_t addr = 0x2000; @@ -528,7 +528,7 @@ HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenGmmAndAllocationCompres alignedFree(stateBuffer); } -HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenGmmCompressionDisabledAndAllocationEnabledAnNonAuxDisabledThenSetCoherencyToIaAndAuxModeToNone) { +HWTEST_F(GfxCoreHelperTest, givenCreatedSurfaceStateBufferWhenGmmCompressionDisabledAndAllocationEnabledAnNonAuxDisabledThenSetCoherencyToIaAndAuxModeToNone) { using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; using SURFACE_TYPE = typename RENDER_SURFACE_STATE::SURFACE_TYPE; using AUXILIARY_SURFACE_MODE = typename RENDER_SURFACE_STATE::AUXILIARY_SURFACE_MODE; @@ -539,7 +539,7 @@ HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenGmmCompressionDisabledA RENDER_SURFACE_STATE *state = reinterpret_cast(stateBuffer); memset(stateBuffer, 0, sizeof(RENDER_SURFACE_STATE)); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); size_t size = 0x1000; uint64_t addr = 0x2000; @@ -559,7 +559,7 @@ HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenGmmCompressionDisabledA alignedFree(stateBuffer); } -HWTEST_F(HwHelperTest, givenOverrideMocsIndexForScratchSpaceWhenSurfaceStateIsProgrammedForScratchSpaceThenOverrideMocsIndexWithCorrectValue) { +HWTEST_F(GfxCoreHelperTest, givenOverrideMocsIndexForScratchSpaceWhenSurfaceStateIsProgrammedForScratchSpaceThenOverrideMocsIndexWithCorrectValue) { DebugManagerStateRestore restore; DebugManager.flags.OverrideMocsIndexForScratchSpace.set(1); @@ -572,7 +572,7 @@ HWTEST_F(HwHelperTest, givenOverrideMocsIndexForScratchSpaceWhenSurfaceStateIsPr RENDER_SURFACE_STATE *state = reinterpret_cast(stateBuffer); memset(stateBuffer, 0, sizeof(RENDER_SURFACE_STATE)); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); size_t size = 0x1000; uint64_t addr = 0x2000; @@ -593,7 +593,7 @@ HWTEST_F(HwHelperTest, givenOverrideMocsIndexForScratchSpaceWhenSurfaceStateIsPr alignedFree(stateBuffer); } -HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenGmmAndAllocationCompressionEnabledAnNonAuxEnabledThenSetCoherencyToIaAndAuxModeToNone) { +HWTEST_F(GfxCoreHelperTest, givenCreatedSurfaceStateBufferWhenGmmAndAllocationCompressionEnabledAnNonAuxEnabledThenSetCoherencyToIaAndAuxModeToNone) { using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; using SURFACE_TYPE = typename RENDER_SURFACE_STATE::SURFACE_TYPE; using AUXILIARY_SURFACE_MODE = typename RENDER_SURFACE_STATE::AUXILIARY_SURFACE_MODE; @@ -604,7 +604,7 @@ HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenGmmAndAllocationCompres RENDER_SURFACE_STATE *state = reinterpret_cast(stateBuffer); memset(stateBuffer, 0, sizeof(RENDER_SURFACE_STATE)); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); size_t size = 0x1000; uint64_t addr = 0x2000; @@ -625,7 +625,7 @@ HWTEST_F(HwHelperTest, givenCreatedSurfaceStateBufferWhenGmmAndAllocationCompres alignedFree(stateBuffer); } -HWTEST_F(HwHelperTest, DISABLED_profilingCreationOfRenderSurfaceStateVsMemcpyOfCachelineAlignedBuffer) { +HWTEST_F(GfxCoreHelperTest, DISABLED_profilingCreationOfRenderSurfaceStateVsMemcpyOfCachelineAlignedBuffer) { using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; using SURFACE_TYPE = typename RENDER_SURFACE_STATE::SURFACE_TYPE; @@ -661,7 +661,7 @@ HWTEST_F(HwHelperTest, DISABLED_profilingCreationOfRenderSurfaceStateVsMemcpyOfC } auto &rootDeviceEnvironment = pDevice->getRootDeviceEnvironment(); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); size_t size = 0x1000; uint64_t addr = 0x2000; @@ -718,7 +718,7 @@ HWTEST_F(HwHelperTest, DISABLED_profilingCreationOfRenderSurfaceStateVsMemcpyOfC } } -TEST(HwHelperCacheFlushTest, givenEnableCacheFlushFlagIsEnableWhenPlatformDoesNotSupportThenOverrideAndReturnSupportTrue) { +TEST(GfxCoreHelperCacheFlushTest, givenEnableCacheFlushFlagIsEnableWhenPlatformDoesNotSupportThenOverrideAndReturnSupportTrue) { DebugManagerStateRestore restore; DebugManager.flags.EnableCacheFlushAfterWalker.set(1); @@ -726,10 +726,10 @@ TEST(HwHelperCacheFlushTest, givenEnableCacheFlushFlagIsEnableWhenPlatformDoesNo localHwInfo.capabilityTable.supportCacheFlushAfterWalker = false; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&localHwInfo)); - EXPECT_TRUE(HwHelper::cacheFlushAfterWalkerSupported(device->getHardwareInfo())); + EXPECT_TRUE(GfxCoreHelper::cacheFlushAfterWalkerSupported(device->getHardwareInfo())); } -TEST(HwHelperCacheFlushTest, givenEnableCacheFlushFlagIsDisableWhenPlatformSupportsThenOverrideAndReturnSupportFalse) { +TEST(GfxCoreHelperCacheFlushTest, givenEnableCacheFlushFlagIsDisableWhenPlatformSupportsThenOverrideAndReturnSupportFalse) { DebugManagerStateRestore restore; DebugManager.flags.EnableCacheFlushAfterWalker.set(0); @@ -737,10 +737,10 @@ TEST(HwHelperCacheFlushTest, givenEnableCacheFlushFlagIsDisableWhenPlatformSuppo localHwInfo.capabilityTable.supportCacheFlushAfterWalker = true; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&localHwInfo)); - EXPECT_FALSE(HwHelper::cacheFlushAfterWalkerSupported(device->getHardwareInfo())); + EXPECT_FALSE(GfxCoreHelper::cacheFlushAfterWalkerSupported(device->getHardwareInfo())); } -TEST(HwHelperCacheFlushTest, givenEnableCacheFlushFlagIsReadPlatformSettingWhenPlatformDoesNotSupportThenReturnSupportFalse) { +TEST(GfxCoreHelperCacheFlushTest, givenEnableCacheFlushFlagIsReadPlatformSettingWhenPlatformDoesNotSupportThenReturnSupportFalse) { DebugManagerStateRestore restore; DebugManager.flags.EnableCacheFlushAfterWalker.set(-1); @@ -748,10 +748,10 @@ TEST(HwHelperCacheFlushTest, givenEnableCacheFlushFlagIsReadPlatformSettingWhenP localHwInfo.capabilityTable.supportCacheFlushAfterWalker = false; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&localHwInfo)); - EXPECT_FALSE(HwHelper::cacheFlushAfterWalkerSupported(device->getHardwareInfo())); + EXPECT_FALSE(GfxCoreHelper::cacheFlushAfterWalkerSupported(device->getHardwareInfo())); } -TEST(HwHelperCacheFlushTest, givenEnableCacheFlushFlagIsReadPlatformSettingWhenPlatformSupportsThenReturnSupportTrue) { +TEST(GfxCoreHelperCacheFlushTest, givenEnableCacheFlushFlagIsReadPlatformSettingWhenPlatformSupportsThenReturnSupportTrue) { DebugManagerStateRestore restore; DebugManager.flags.EnableCacheFlushAfterWalker.set(-1); @@ -759,45 +759,45 @@ TEST(HwHelperCacheFlushTest, givenEnableCacheFlushFlagIsReadPlatformSettingWhenP localHwInfo.capabilityTable.supportCacheFlushAfterWalker = true; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&localHwInfo)); - EXPECT_TRUE(HwHelper::cacheFlushAfterWalkerSupported(device->getHardwareInfo())); + EXPECT_TRUE(GfxCoreHelper::cacheFlushAfterWalkerSupported(device->getHardwareInfo())); } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, givenHwHelperWhenGettingGlobalTimeStampBitsThenCorrectValueIsReturned) { - auto &helper = HwHelper::get(renderCoreFamily); +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, givenGfxCoreHelperWhenGettingGlobalTimeStampBitsThenCorrectValueIsReturned) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_EQ(helper.getGlobalTimeStampBits(), 36U); } -TEST_F(HwHelperTest, givenEnableLocalMemoryDebugVarAndOsEnableLocalMemoryWhenSetThenGetEnableLocalMemoryReturnsCorrectValue) { +TEST_F(GfxCoreHelperTest, givenEnableLocalMemoryDebugVarAndOsEnableLocalMemoryWhenSetThenGetEnableLocalMemoryReturnsCorrectValue) { DebugManagerStateRestore dbgRestore; VariableBackup orgOsEnableLocalMemory(&OSInterface::osEnableLocalMemory); - auto &coreHelper = getHelper(); + auto &gfxCoreHelper = getHelper(); DebugManager.flags.EnableLocalMemory.set(0); - EXPECT_FALSE(coreHelper.getEnableLocalMemory(hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.getEnableLocalMemory(hardwareInfo)); DebugManager.flags.EnableLocalMemory.set(1); - EXPECT_TRUE(coreHelper.getEnableLocalMemory(hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.getEnableLocalMemory(hardwareInfo)); DebugManager.flags.EnableLocalMemory.set(-1); OSInterface::osEnableLocalMemory = false; - EXPECT_FALSE(coreHelper.getEnableLocalMemory(hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.getEnableLocalMemory(hardwareInfo)); OSInterface::osEnableLocalMemory = true; - EXPECT_EQ(coreHelper.isLocalMemoryEnabled(hardwareInfo), coreHelper.getEnableLocalMemory(hardwareInfo)); + EXPECT_EQ(gfxCoreHelper.isLocalMemoryEnabled(hardwareInfo), gfxCoreHelper.getEnableLocalMemory(hardwareInfo)); } -TEST_F(HwHelperTest, givenAUBDumpForceAllToLocalMemoryDebugVarWhenSetThenGetEnableLocalMemoryReturnsCorrectValue) { +TEST_F(GfxCoreHelperTest, givenAUBDumpForceAllToLocalMemoryDebugVarWhenSetThenGetEnableLocalMemoryReturnsCorrectValue) { DebugManagerStateRestore dbgRestore; std::unique_ptr device(MockDevice::createWithNewExecutionEnvironment(&hardwareInfo)); - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); DebugManager.flags.AUBDumpForceAllToLocalMemory.set(true); EXPECT_TRUE(helper.getEnableLocalMemory(hardwareInfo)); } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, givenVariousCachesRequestThenCorrectMocsIndexesAreReturned) { - auto &helper = HwHelper::get(renderCoreFamily); +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, givenVariousCachesRequestThenCorrectMocsIndexesAreReturned) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); auto gmmHelper = this->pDevice->getGmmHelper(); auto expectedMocsForL3off = gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER_CACHELINE_MISALIGNED) >> 1; auto expectedMocsForL3on = gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER) >> 1; @@ -817,44 +817,44 @@ HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, givenVariousCachesRequestThenCorrectMo } } -HWTEST_F(HwHelperTest, whenQueryingMaxNumSamplersThenReturnSixteen) { - auto &coreHelper = getHelper(); - EXPECT_EQ(16u, coreHelper.getMaxNumSamplers()); +HWTEST_F(GfxCoreHelperTest, whenQueryingMaxNumSamplersThenReturnSixteen) { + auto &gfxCoreHelper = getHelper(); + EXPECT_EQ(16u, gfxCoreHelper.getMaxNumSamplers()); } -HWTEST_F(HwHelperTest, givenDebugVariableSetWhenAskingForAuxTranslationModeThenReturnCorrectValue) { +HWTEST_F(GfxCoreHelperTest, givenDebugVariableSetWhenAskingForAuxTranslationModeThenReturnCorrectValue) { DebugManagerStateRestore restore; HardwareInfo hwInfo = *defaultHwInfo; hwInfo.capabilityTable.blitterOperationsSupported = true; - EXPECT_EQ(UnitTestHelper::requiredAuxTranslationMode, HwHelperHw::getAuxTranslationMode(hwInfo)); + EXPECT_EQ(UnitTestHelper::requiredAuxTranslationMode, GfxCoreHelperHw::getAuxTranslationMode(hwInfo)); - if (HwHelperHw::getAuxTranslationMode(hwInfo) == AuxTranslationMode::Blit) { + if (GfxCoreHelperHw::getAuxTranslationMode(hwInfo) == AuxTranslationMode::Blit) { hwInfo.capabilityTable.blitterOperationsSupported = false; - EXPECT_EQ(AuxTranslationMode::Builtin, HwHelperHw::getAuxTranslationMode(hwInfo)); + EXPECT_EQ(AuxTranslationMode::Builtin, GfxCoreHelperHw::getAuxTranslationMode(hwInfo)); } DebugManager.flags.ForceAuxTranslationMode.set(static_cast(AuxTranslationMode::None)); - EXPECT_EQ(AuxTranslationMode::None, HwHelperHw::getAuxTranslationMode(hwInfo)); + EXPECT_EQ(AuxTranslationMode::None, GfxCoreHelperHw::getAuxTranslationMode(hwInfo)); hwInfo.capabilityTable.blitterOperationsSupported = false; DebugManager.flags.ForceAuxTranslationMode.set(static_cast(AuxTranslationMode::Blit)); - EXPECT_EQ(AuxTranslationMode::Builtin, HwHelperHw::getAuxTranslationMode(hwInfo)); + EXPECT_EQ(AuxTranslationMode::Builtin, GfxCoreHelperHw::getAuxTranslationMode(hwInfo)); hwInfo.capabilityTable.blitterOperationsSupported = true; DebugManager.flags.ForceAuxTranslationMode.set(static_cast(AuxTranslationMode::Blit)); - EXPECT_EQ(AuxTranslationMode::Blit, HwHelperHw::getAuxTranslationMode(hwInfo)); + EXPECT_EQ(AuxTranslationMode::Blit, GfxCoreHelperHw::getAuxTranslationMode(hwInfo)); DebugManager.flags.ForceAuxTranslationMode.set(static_cast(AuxTranslationMode::Builtin)); - EXPECT_EQ(AuxTranslationMode::Builtin, HwHelperHw::getAuxTranslationMode(hwInfo)); + EXPECT_EQ(AuxTranslationMode::Builtin, GfxCoreHelperHw::getAuxTranslationMode(hwInfo)); } -HWTEST_F(HwHelperTest, givenDebugFlagWhenCheckingIfBufferIsSuitableForCompressionThenReturnCorrectValue) { +HWTEST_F(GfxCoreHelperTest, givenDebugFlagWhenCheckingIfBufferIsSuitableForCompressionThenReturnCorrectValue) { DebugManagerStateRestore restore; - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); DebugManager.flags.OverrideBufferSuitableForRenderCompression.set(0); EXPECT_FALSE(helper.isBufferSizeSuitableForCompression(0, *defaultHwInfo)); @@ -867,66 +867,66 @@ HWTEST_F(HwHelperTest, givenDebugFlagWhenCheckingIfBufferIsSuitableForCompressio EXPECT_TRUE(helper.isBufferSizeSuitableForCompression(KB + 1, *defaultHwInfo)); } -HWTEST_F(HwHelperTest, WhenIsBankOverrideRequiredIsCalledThenFalseIsReturned) { - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - EXPECT_FALSE(hwHelper.isBankOverrideRequired(hardwareInfo)); +HWTEST_F(GfxCoreHelperTest, WhenIsBankOverrideRequiredIsCalledThenFalseIsReturned) { + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.isBankOverrideRequired(hardwareInfo)); } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, GivenBarrierEncodingWhenCallingGetBarriersCountFromHasBarrierThenNumberOfBarriersIsReturned) { - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - EXPECT_EQ(0u, hwHelper.getBarriersCountFromHasBarriers(0u)); - EXPECT_EQ(1u, hwHelper.getBarriersCountFromHasBarriers(1u)); +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, GivenBarrierEncodingWhenCallingGetBarriersCountFromHasBarrierThenNumberOfBarriersIsReturned) { + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + EXPECT_EQ(0u, gfxCoreHelper.getBarriersCountFromHasBarriers(0u)); + EXPECT_EQ(1u, gfxCoreHelper.getBarriersCountFromHasBarriers(1u)); } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, GivenVariousValuesWhenCallingCalculateAvailableThreadCountThenCorrectValueIsReturned) { - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - auto result = hwHelper.calculateAvailableThreadCount(hardwareInfo, 0); +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, GivenVariousValuesWhenCallingCalculateAvailableThreadCountThenCorrectValueIsReturned) { + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto result = gfxCoreHelper.calculateAvailableThreadCount(hardwareInfo, 0); EXPECT_EQ(hardwareInfo.gtSystemInfo.ThreadCount, result); } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, GivenModifiedGtSystemInfoWhenCallingCalculateAvailableThreadCountThenCorrectValueIsReturned) { - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, GivenModifiedGtSystemInfoWhenCallingCalculateAvailableThreadCountThenCorrectValueIsReturned) { + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); auto hwInfo = hardwareInfo; for (auto threadCount : {1u, 5u, 9u}) { hwInfo.gtSystemInfo.ThreadCount = threadCount; - auto result = hwHelper.calculateAvailableThreadCount(hwInfo, 0); + auto result = gfxCoreHelper.calculateAvailableThreadCount(hwInfo, 0); EXPECT_EQ(threadCount, result); } } -HWTEST_F(HwHelperTest, givenDefaultHwHelperHwWhenIsOffsetToSkipSetFFIDGPWARequiredCalledThenFalseIsReturned) { +HWTEST_F(GfxCoreHelperTest, givenDefaultGfxCoreHelperHwWhenIsOffsetToSkipSetFFIDGPWARequiredCalledThenFalseIsReturned) { if (hardwareInfo.platform.eRenderCoreFamily == IGFX_GEN12LP_CORE) { GTEST_SKIP(); } - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - EXPECT_FALSE(hwHelper.isOffsetToSkipSetFFIDGPWARequired(hardwareInfo)); + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.isOffsetToSkipSetFFIDGPWARequired(hardwareInfo)); } -HWTEST_F(HwHelperTest, givenDefaultHwHelperHwWhenIsForceDefaultRCSEngineWARequiredCalledThenFalseIsReturned) { +HWTEST_F(GfxCoreHelperTest, givenDefaultGfxCoreHelperHwWhenIsForceDefaultRCSEngineWARequiredCalledThenFalseIsReturned) { if (hardwareInfo.platform.eRenderCoreFamily == IGFX_GEN12LP_CORE) { GTEST_SKIP(); } - EXPECT_FALSE(HwHelperHw::isForceDefaultRCSEngineWARequired(hardwareInfo)); + EXPECT_FALSE(GfxCoreHelperHw::isForceDefaultRCSEngineWARequired(hardwareInfo)); } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, givenDefaultHwHelperHwWhenIsWorkaroundRequiredCalledThenFalseIsReturned) { +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, givenDefaultGfxCoreHelperHwWhenIsWorkaroundRequiredCalledThenFalseIsReturned) { if (hardwareInfo.platform.eRenderCoreFamily == IGFX_GEN12LP_CORE) { GTEST_SKIP(); } - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_FALSE(helper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); } -HWTEST_F(HwHelperTest, givenDefaultHwHelperHwWhenMinimalSIMDSizeIsQueriedThen8IsReturned) { - auto &helper = HwHelper::get(renderCoreFamily); +HWTEST_F(GfxCoreHelperTest, givenDefaultGfxCoreHelperHwWhenMinimalSIMDSizeIsQueriedThen8IsReturned) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_EQ(8u, helper.getMinimalSIMDSize()); } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, WhenIsFusedEuDispatchEnabledIsCalledThenFalseIsReturned) { +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, WhenIsFusedEuDispatchEnabledIsCalledThenFalseIsReturned) { if (hardwareInfo.platform.eRenderCoreFamily == IGFX_GEN12LP_CORE) { GTEST_SKIP(); } - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_FALSE(helper.isFusedEuDispatchEnabled(hardwareInfo, false)); } @@ -995,33 +995,33 @@ HWTEST2_F(HwInfoConfigCommonTest, givenHardwareInfoAndDebugVariableNodeOrdinalEq EXPECT_TRUE(hwInfo.featureTable.flags.ftrRcsNode); } -HWTEST_F(HwHelperTest, givenHwHelperWhenAskingForIsaSystemMemoryPlacementThenReturnFalseIfLocalMemorySupported) { +HWTEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenAskingForIsaSystemMemoryPlacementThenReturnFalseIfLocalMemorySupported) { DebugManagerStateRestore restorer; - HwHelper &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); hardwareInfo.featureTable.flags.ftrLocalMemory = true; - auto localMemoryEnabled = hwHelper.getEnableLocalMemory(hardwareInfo); - EXPECT_NE(localMemoryEnabled, hwHelper.useSystemMemoryPlacementForISA(hardwareInfo)); + auto localMemoryEnabled = gfxCoreHelper.getEnableLocalMemory(hardwareInfo); + EXPECT_NE(localMemoryEnabled, gfxCoreHelper.useSystemMemoryPlacementForISA(hardwareInfo)); hardwareInfo.featureTable.flags.ftrLocalMemory = false; - localMemoryEnabled = hwHelper.getEnableLocalMemory(hardwareInfo); - EXPECT_NE(localMemoryEnabled, hwHelper.useSystemMemoryPlacementForISA(hardwareInfo)); + localMemoryEnabled = gfxCoreHelper.getEnableLocalMemory(hardwareInfo); + EXPECT_NE(localMemoryEnabled, gfxCoreHelper.useSystemMemoryPlacementForISA(hardwareInfo)); DebugManager.flags.EnableLocalMemory.set(true); hardwareInfo.featureTable.flags.ftrLocalMemory = false; - localMemoryEnabled = hwHelper.getEnableLocalMemory(hardwareInfo); - EXPECT_NE(localMemoryEnabled, hwHelper.useSystemMemoryPlacementForISA(hardwareInfo)); + localMemoryEnabled = gfxCoreHelper.getEnableLocalMemory(hardwareInfo); + EXPECT_NE(localMemoryEnabled, gfxCoreHelper.useSystemMemoryPlacementForISA(hardwareInfo)); DebugManager.flags.EnableLocalMemory.set(false); hardwareInfo.featureTable.flags.ftrLocalMemory = true; - localMemoryEnabled = hwHelper.getEnableLocalMemory(hardwareInfo); - EXPECT_NE(localMemoryEnabled, hwHelper.useSystemMemoryPlacementForISA(hardwareInfo)); + localMemoryEnabled = gfxCoreHelper.getEnableLocalMemory(hardwareInfo); + EXPECT_NE(localMemoryEnabled, gfxCoreHelper.useSystemMemoryPlacementForISA(hardwareInfo)); } -TEST_F(HwHelperTest, givenInvalidEngineTypeWhenGettingEngineGroupTypeThenThrow) { - HwHelper &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - EXPECT_ANY_THROW(hwHelper.getEngineGroupType(aub_stream::EngineType::NUM_ENGINES, EngineUsage::Regular, hardwareInfo)); - EXPECT_ANY_THROW(hwHelper.getEngineGroupType(aub_stream::EngineType::ENGINE_VECS, EngineUsage::Regular, hardwareInfo)); +TEST_F(GfxCoreHelperTest, givenInvalidEngineTypeWhenGettingEngineGroupTypeThenThrow) { + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + EXPECT_ANY_THROW(gfxCoreHelper.getEngineGroupType(aub_stream::EngineType::NUM_ENGINES, EngineUsage::Regular, hardwareInfo)); + EXPECT_ANY_THROW(gfxCoreHelper.getEngineGroupType(aub_stream::EngineType::ENGINE_VECS, EngineUsage::Regular, hardwareInfo)); } HWTEST2_F(HwInfoConfigCommonTest, givenDebugFlagSetWhenEnablingBlitterOperationsSupportThenHonorTheFlag, IsAtLeastGen12lp) { @@ -1038,247 +1038,247 @@ HWTEST2_F(HwInfoConfigCommonTest, givenDebugFlagSetWhenEnablingBlitterOperations EXPECT_FALSE(hardwareInfo.capabilityTable.blitterOperationsSupported); } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, GivenVariousValuesWhenAlignSlmSizeIsCalledThenCorrectValueIsReturned) { +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, GivenVariousValuesWhenAlignSlmSizeIsCalledThenCorrectValueIsReturned) { if (::renderCoreFamily == IGFX_GEN8_CORE) { - EXPECT_EQ(0u, HwHelperHw::get().alignSlmSize(0)); - EXPECT_EQ(4096u, HwHelperHw::get().alignSlmSize(1)); - EXPECT_EQ(4096u, HwHelperHw::get().alignSlmSize(1024)); - EXPECT_EQ(4096u, HwHelperHw::get().alignSlmSize(1025)); - EXPECT_EQ(4096u, HwHelperHw::get().alignSlmSize(2048)); - EXPECT_EQ(4096u, HwHelperHw::get().alignSlmSize(2049)); - EXPECT_EQ(4096u, HwHelperHw::get().alignSlmSize(4096)); - EXPECT_EQ(8192u, HwHelperHw::get().alignSlmSize(4097)); - EXPECT_EQ(8192u, HwHelperHw::get().alignSlmSize(8192)); - EXPECT_EQ(16384u, HwHelperHw::get().alignSlmSize(8193)); - EXPECT_EQ(16384u, HwHelperHw::get().alignSlmSize(12288)); - EXPECT_EQ(16384u, HwHelperHw::get().alignSlmSize(16384)); - EXPECT_EQ(32768u, HwHelperHw::get().alignSlmSize(16385)); - EXPECT_EQ(32768u, HwHelperHw::get().alignSlmSize(24576)); - EXPECT_EQ(32768u, HwHelperHw::get().alignSlmSize(32768)); - EXPECT_EQ(65536u, HwHelperHw::get().alignSlmSize(32769)); - EXPECT_EQ(65536u, HwHelperHw::get().alignSlmSize(49152)); - EXPECT_EQ(65536u, HwHelperHw::get().alignSlmSize(65535)); - EXPECT_EQ(65536u, HwHelperHw::get().alignSlmSize(65536)); + EXPECT_EQ(0u, GfxCoreHelperHw::get().alignSlmSize(0)); + EXPECT_EQ(4096u, GfxCoreHelperHw::get().alignSlmSize(1)); + EXPECT_EQ(4096u, GfxCoreHelperHw::get().alignSlmSize(1024)); + EXPECT_EQ(4096u, GfxCoreHelperHw::get().alignSlmSize(1025)); + EXPECT_EQ(4096u, GfxCoreHelperHw::get().alignSlmSize(2048)); + EXPECT_EQ(4096u, GfxCoreHelperHw::get().alignSlmSize(2049)); + EXPECT_EQ(4096u, GfxCoreHelperHw::get().alignSlmSize(4096)); + EXPECT_EQ(8192u, GfxCoreHelperHw::get().alignSlmSize(4097)); + EXPECT_EQ(8192u, GfxCoreHelperHw::get().alignSlmSize(8192)); + EXPECT_EQ(16384u, GfxCoreHelperHw::get().alignSlmSize(8193)); + EXPECT_EQ(16384u, GfxCoreHelperHw::get().alignSlmSize(12288)); + EXPECT_EQ(16384u, GfxCoreHelperHw::get().alignSlmSize(16384)); + EXPECT_EQ(32768u, GfxCoreHelperHw::get().alignSlmSize(16385)); + EXPECT_EQ(32768u, GfxCoreHelperHw::get().alignSlmSize(24576)); + EXPECT_EQ(32768u, GfxCoreHelperHw::get().alignSlmSize(32768)); + EXPECT_EQ(65536u, GfxCoreHelperHw::get().alignSlmSize(32769)); + EXPECT_EQ(65536u, GfxCoreHelperHw::get().alignSlmSize(49152)); + EXPECT_EQ(65536u, GfxCoreHelperHw::get().alignSlmSize(65535)); + EXPECT_EQ(65536u, GfxCoreHelperHw::get().alignSlmSize(65536)); } else { - EXPECT_EQ(0u, HwHelperHw::get().alignSlmSize(0)); - EXPECT_EQ(1024u, HwHelperHw::get().alignSlmSize(1)); - EXPECT_EQ(1024u, HwHelperHw::get().alignSlmSize(1024)); - EXPECT_EQ(2048u, HwHelperHw::get().alignSlmSize(1025)); - EXPECT_EQ(2048u, HwHelperHw::get().alignSlmSize(2048)); - EXPECT_EQ(4096u, HwHelperHw::get().alignSlmSize(2049)); - EXPECT_EQ(4096u, HwHelperHw::get().alignSlmSize(4096)); - EXPECT_EQ(8192u, HwHelperHw::get().alignSlmSize(4097)); - EXPECT_EQ(8192u, HwHelperHw::get().alignSlmSize(8192)); - EXPECT_EQ(16384u, HwHelperHw::get().alignSlmSize(8193)); - EXPECT_EQ(16384u, HwHelperHw::get().alignSlmSize(16384)); - EXPECT_EQ(32768u, HwHelperHw::get().alignSlmSize(16385)); - EXPECT_EQ(32768u, HwHelperHw::get().alignSlmSize(32768)); - EXPECT_EQ(65536u, HwHelperHw::get().alignSlmSize(32769)); - EXPECT_EQ(65536u, HwHelperHw::get().alignSlmSize(65536)); + EXPECT_EQ(0u, GfxCoreHelperHw::get().alignSlmSize(0)); + EXPECT_EQ(1024u, GfxCoreHelperHw::get().alignSlmSize(1)); + EXPECT_EQ(1024u, GfxCoreHelperHw::get().alignSlmSize(1024)); + EXPECT_EQ(2048u, GfxCoreHelperHw::get().alignSlmSize(1025)); + EXPECT_EQ(2048u, GfxCoreHelperHw::get().alignSlmSize(2048)); + EXPECT_EQ(4096u, GfxCoreHelperHw::get().alignSlmSize(2049)); + EXPECT_EQ(4096u, GfxCoreHelperHw::get().alignSlmSize(4096)); + EXPECT_EQ(8192u, GfxCoreHelperHw::get().alignSlmSize(4097)); + EXPECT_EQ(8192u, GfxCoreHelperHw::get().alignSlmSize(8192)); + EXPECT_EQ(16384u, GfxCoreHelperHw::get().alignSlmSize(8193)); + EXPECT_EQ(16384u, GfxCoreHelperHw::get().alignSlmSize(16384)); + EXPECT_EQ(32768u, GfxCoreHelperHw::get().alignSlmSize(16385)); + EXPECT_EQ(32768u, GfxCoreHelperHw::get().alignSlmSize(32768)); + EXPECT_EQ(65536u, GfxCoreHelperHw::get().alignSlmSize(32769)); + EXPECT_EQ(65536u, GfxCoreHelperHw::get().alignSlmSize(65536)); } } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, GivenVariousValuesWhenComputeSlmSizeIsCalledThenCorrectValueIsReturned) { +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, GivenVariousValuesWhenComputeSlmSizeIsCalledThenCorrectValueIsReturned) { auto hwInfo = *defaultHwInfo; if (::renderCoreFamily == IGFX_GEN8_CORE) { - EXPECT_EQ(0u, HwHelperHw::get().computeSlmValues(hwInfo, 0)); - EXPECT_EQ(1u, HwHelperHw::get().computeSlmValues(hwInfo, 1)); - EXPECT_EQ(1u, HwHelperHw::get().computeSlmValues(hwInfo, 1024)); - EXPECT_EQ(1u, HwHelperHw::get().computeSlmValues(hwInfo, 1025)); - EXPECT_EQ(1u, HwHelperHw::get().computeSlmValues(hwInfo, 2048)); - EXPECT_EQ(1u, HwHelperHw::get().computeSlmValues(hwInfo, 2049)); - EXPECT_EQ(1u, HwHelperHw::get().computeSlmValues(hwInfo, 4096)); - EXPECT_EQ(2u, HwHelperHw::get().computeSlmValues(hwInfo, 4097)); - EXPECT_EQ(2u, HwHelperHw::get().computeSlmValues(hwInfo, 8192)); - EXPECT_EQ(4u, HwHelperHw::get().computeSlmValues(hwInfo, 8193)); - EXPECT_EQ(4u, HwHelperHw::get().computeSlmValues(hwInfo, 12288)); - EXPECT_EQ(4u, HwHelperHw::get().computeSlmValues(hwInfo, 16384)); - EXPECT_EQ(8u, HwHelperHw::get().computeSlmValues(hwInfo, 16385)); - EXPECT_EQ(8u, HwHelperHw::get().computeSlmValues(hwInfo, 24576)); - EXPECT_EQ(8u, HwHelperHw::get().computeSlmValues(hwInfo, 32768)); - EXPECT_EQ(16u, HwHelperHw::get().computeSlmValues(hwInfo, 32769)); - EXPECT_EQ(16u, HwHelperHw::get().computeSlmValues(hwInfo, 49152)); - EXPECT_EQ(16u, HwHelperHw::get().computeSlmValues(hwInfo, 65535)); - EXPECT_EQ(16u, HwHelperHw::get().computeSlmValues(hwInfo, 65536)); + EXPECT_EQ(0u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 0)); + EXPECT_EQ(1u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 1)); + EXPECT_EQ(1u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 1024)); + EXPECT_EQ(1u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 1025)); + EXPECT_EQ(1u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 2048)); + EXPECT_EQ(1u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 2049)); + EXPECT_EQ(1u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 4096)); + EXPECT_EQ(2u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 4097)); + EXPECT_EQ(2u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 8192)); + EXPECT_EQ(4u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 8193)); + EXPECT_EQ(4u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 12288)); + EXPECT_EQ(4u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 16384)); + EXPECT_EQ(8u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 16385)); + EXPECT_EQ(8u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 24576)); + EXPECT_EQ(8u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 32768)); + EXPECT_EQ(16u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 32769)); + EXPECT_EQ(16u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 49152)); + EXPECT_EQ(16u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 65535)); + EXPECT_EQ(16u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 65536)); } else { - EXPECT_EQ(0u, HwHelperHw::get().computeSlmValues(hwInfo, 0)); - EXPECT_EQ(1u, HwHelperHw::get().computeSlmValues(hwInfo, 1)); - EXPECT_EQ(1u, HwHelperHw::get().computeSlmValues(hwInfo, 1024)); - EXPECT_EQ(2u, HwHelperHw::get().computeSlmValues(hwInfo, 1025)); - EXPECT_EQ(2u, HwHelperHw::get().computeSlmValues(hwInfo, 2048)); - EXPECT_EQ(3u, HwHelperHw::get().computeSlmValues(hwInfo, 2049)); - EXPECT_EQ(3u, HwHelperHw::get().computeSlmValues(hwInfo, 4096)); - EXPECT_EQ(4u, HwHelperHw::get().computeSlmValues(hwInfo, 4097)); - EXPECT_EQ(4u, HwHelperHw::get().computeSlmValues(hwInfo, 8192)); - EXPECT_EQ(5u, HwHelperHw::get().computeSlmValues(hwInfo, 8193)); - EXPECT_EQ(5u, HwHelperHw::get().computeSlmValues(hwInfo, 16384)); - EXPECT_EQ(6u, HwHelperHw::get().computeSlmValues(hwInfo, 16385)); - EXPECT_EQ(6u, HwHelperHw::get().computeSlmValues(hwInfo, 32768)); - EXPECT_EQ(7u, HwHelperHw::get().computeSlmValues(hwInfo, 32769)); - EXPECT_EQ(7u, HwHelperHw::get().computeSlmValues(hwInfo, 65536)); + EXPECT_EQ(0u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 0)); + EXPECT_EQ(1u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 1)); + EXPECT_EQ(1u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 1024)); + EXPECT_EQ(2u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 1025)); + EXPECT_EQ(2u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 2048)); + EXPECT_EQ(3u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 2049)); + EXPECT_EQ(3u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 4096)); + EXPECT_EQ(4u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 4097)); + EXPECT_EQ(4u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 8192)); + EXPECT_EQ(5u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 8193)); + EXPECT_EQ(5u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 16384)); + EXPECT_EQ(6u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 16385)); + EXPECT_EQ(6u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 32768)); + EXPECT_EQ(7u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 32769)); + EXPECT_EQ(7u, GfxCoreHelperHw::get().computeSlmValues(hwInfo, 65536)); } } -HWTEST_F(HwHelperTest, GivenZeroSlmSizeWhenComputeSlmSizeIsCalledThenCorrectValueIsReturned) { +HWTEST_F(GfxCoreHelperTest, GivenZeroSlmSizeWhenComputeSlmSizeIsCalledThenCorrectValueIsReturned) { using SHARED_LOCAL_MEMORY_SIZE = typename FamilyType::INTERFACE_DESCRIPTOR_DATA::SHARED_LOCAL_MEMORY_SIZE; auto hwInfo = *defaultHwInfo; - auto receivedSlmSize = static_cast(HwHelperHw::get().computeSlmValues(hwInfo, 0)); + auto receivedSlmSize = static_cast(GfxCoreHelperHw::get().computeSlmValues(hwInfo, 0)); EXPECT_EQ(SHARED_LOCAL_MEMORY_SIZE::SHARED_LOCAL_MEMORY_SIZE_ENCODES_0K, receivedSlmSize); } -HWTEST2_F(HwHelperTest, givenHwHelperWhenCheckingSipWaThenFalseIsReturned, isTglLpOrBelow) { - auto &helper = HwHelper::get(renderCoreFamily); +HWTEST2_F(GfxCoreHelperTest, givenGfxCoreHelperWhenCheckingSipWaThenFalseIsReturned, isTglLpOrBelow) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_FALSE(helper.isSipWANeeded(*defaultHwInfo)); } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, givenHwHelperWhenGettingPlanarYuvHeightThenHelperReturnsCorrectValue) { - auto &helper = HwHelper::get(renderCoreFamily); +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, givenGfxCoreHelperWhenGettingPlanarYuvHeightThenHelperReturnsCorrectValue) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_EQ(helper.getPlanarYuvMaxHeight(), 16352u); } -TEST_F(HwHelperTest, WhenGettingIsCpuImageTransferPreferredThenFalseIsReturned) { +TEST_F(GfxCoreHelperTest, WhenGettingIsCpuImageTransferPreferredThenFalseIsReturned) { REQUIRE_IMAGES_OR_SKIP(defaultHwInfo); - auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_FALSE(hwHelper.isCpuImageTransferPreferred(*defaultHwInfo)); + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.isCpuImageTransferPreferred(*defaultHwInfo)); } -TEST_F(HwHelperTest, whenFtrGpGpuMidThreadLevelPreemptFeatureDisabledThenFalseIsReturned) { - HwHelper &hwHelper = HwHelper::get(renderCoreFamily); +TEST_F(GfxCoreHelperTest, whenFtrGpGpuMidThreadLevelPreemptFeatureDisabledThenFalseIsReturned) { + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); FeatureTable featureTable = {}; featureTable.flags.ftrGpGpuMidThreadLevelPreempt = false; - bool result = hwHelper.isAdditionalFeatureFlagRequired(&featureTable); + bool result = gfxCoreHelper.isAdditionalFeatureFlagRequired(&featureTable); EXPECT_FALSE(result); } -HWTEST_F(HwHelperTest, whenGettingNumberOfCacheRegionsThenReturnZero) { - auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_EQ(0u, hwHelper.getNumCacheRegions()); +HWTEST_F(GfxCoreHelperTest, whenGettingNumberOfCacheRegionsThenReturnZero) { + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_EQ(0u, gfxCoreHelper.getNumCacheRegions()); } -HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, whenCheckingForSmallKernelPreferenceThenFalseIsReturned) { - auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_FALSE(hwHelper.preferSmallWorkgroupSizeForKernel(0u, this->pDevice->getHardwareInfo())); - EXPECT_FALSE(hwHelper.preferSmallWorkgroupSizeForKernel(20000u, this->pDevice->getHardwareInfo())); +HWCMDTEST_F(IGFX_GEN8_CORE, GfxCoreHelperTest, whenCheckingForSmallKernelPreferenceThenFalseIsReturned) { + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.preferSmallWorkgroupSizeForKernel(0u, this->pDevice->getHardwareInfo())); + EXPECT_FALSE(gfxCoreHelper.preferSmallWorkgroupSizeForKernel(20000u, this->pDevice->getHardwareInfo())); } -HWTEST_F(HwHelperTest, whenSetCompressedFlagThenProperFlagSet) { - auto &hwHelper = HwHelper::get(renderCoreFamily); +HWTEST_F(GfxCoreHelperTest, whenSetCompressedFlagThenProperFlagSet) { + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); auto gmm = std::make_unique(pDevice->getGmmHelper()); gmm->resourceParams.Flags.Info.RenderCompressed = 0; - hwHelper.applyRenderCompressionFlag(*gmm, 1); + gfxCoreHelper.applyRenderCompressionFlag(*gmm, 1); EXPECT_EQ(1u, gmm->resourceParams.Flags.Info.RenderCompressed); - hwHelper.applyRenderCompressionFlag(*gmm, 0); + gfxCoreHelper.applyRenderCompressionFlag(*gmm, 0); EXPECT_EQ(0u, gmm->resourceParams.Flags.Info.RenderCompressed); } -HWTEST_F(HwHelperTest, whenAdjustPreemptionSurfaceSizeIsCalledThenCsrSizeDoesntChange) { - auto &hwHelper = HwHelper::get(renderCoreFamily); +HWTEST_F(GfxCoreHelperTest, whenAdjustPreemptionSurfaceSizeIsCalledThenCsrSizeDoesntChange) { + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); size_t csrSize = 1024; size_t oldCsrSize = csrSize; - hwHelper.adjustPreemptionSurfaceSize(csrSize); + gfxCoreHelper.adjustPreemptionSurfaceSize(csrSize); EXPECT_EQ(oldCsrSize, csrSize); } -HWTEST_F(HwHelperTest, whenSetSipKernelDataIsCalledThenSipKernelDataDoesntChange) { - auto &hwHelper = HwHelper::get(renderCoreFamily); +HWTEST_F(GfxCoreHelperTest, whenSetSipKernelDataIsCalledThenSipKernelDataDoesntChange) { + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); uint32_t *sipKernelBinary = nullptr; uint32_t *oldSipKernelBinary = sipKernelBinary; size_t kernelBinarySize = 1024; size_t oldKernelBinarySize = kernelBinarySize; - hwHelper.setSipKernelData(sipKernelBinary, kernelBinarySize); + gfxCoreHelper.setSipKernelData(sipKernelBinary, kernelBinarySize); EXPECT_EQ(oldKernelBinarySize, kernelBinarySize); EXPECT_EQ(oldSipKernelBinary, sipKernelBinary); } -HWTEST_F(HwHelperTest, whenIsSipKernelAsHexadecimalArrayPreferredIsCalledThenReturnFalse) { - auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_FALSE(hwHelper.isSipKernelAsHexadecimalArrayPreferred()); +HWTEST_F(GfxCoreHelperTest, whenIsSipKernelAsHexadecimalArrayPreferredIsCalledThenReturnFalse) { + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.isSipKernelAsHexadecimalArrayPreferred()); } using isXeHpCoreOrBelow = IsAtMostProduct; -HWTEST2_F(HwHelperTest, givenXeHPAndBelowPlatformWhenCheckingIfUnTypedDataPortCacheFlushRequiredThenReturnFalse, isXeHpCoreOrBelow) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_FALSE(hwHelper.unTypedDataPortCacheFlushRequired()); +HWTEST2_F(GfxCoreHelperTest, givenXeHPAndBelowPlatformWhenCheckingIfUnTypedDataPortCacheFlushRequiredThenReturnFalse, isXeHpCoreOrBelow) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.unTypedDataPortCacheFlushRequired()); } -HWTEST2_F(HwHelperTest, givenXeHPAndBelowPlatformPlatformWhenCheckingIfEngineTypeRemappingIsRequiredThenReturnFalse, isXeHpCoreOrBelow) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_FALSE(hwHelper.isEngineTypeRemappingToHwSpecificRequired()); +HWTEST2_F(GfxCoreHelperTest, givenXeHPAndBelowPlatformPlatformWhenCheckingIfEngineTypeRemappingIsRequiredThenReturnFalse, isXeHpCoreOrBelow) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.isEngineTypeRemappingToHwSpecificRequired()); } -HWTEST2_F(HwHelperTest, givenAtMostGen12lpPlatformiWhenCheckingIfScratchSpaceSurfaceStateAccessibleThenFalseIsReturned, IsAtMostGen12lp) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_FALSE(hwHelper.isScratchSpaceSurfaceStateAccessible()); +HWTEST2_F(GfxCoreHelperTest, givenAtMostGen12lpPlatformiWhenCheckingIfScratchSpaceSurfaceStateAccessibleThenFalseIsReturned, IsAtMostGen12lp) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.isScratchSpaceSurfaceStateAccessible()); } -HWTEST2_F(HwHelperTest, givenAtLeastXeHpPlatformWhenCheckingIfScratchSpaceSurfaceStateAccessibleTheniTrueIsReturned, IsAtLeastXeHpCore) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_TRUE(hwHelper.isScratchSpaceSurfaceStateAccessible()); +HWTEST2_F(GfxCoreHelperTest, givenAtLeastXeHpPlatformWhenCheckingIfScratchSpaceSurfaceStateAccessibleTheniTrueIsReturned, IsAtLeastXeHpCore) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_TRUE(gfxCoreHelper.isScratchSpaceSurfaceStateAccessible()); } -HWTEST_F(HwHelperTest, givenGetRenderSurfaceStateBaseAddressCalledThenCorrectValueIsReturned) { +HWTEST_F(GfxCoreHelperTest, givenGetRenderSurfaceStateBaseAddressCalledThenCorrectValueIsReturned) { using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; RENDER_SURFACE_STATE renderSurfaceState; uint64_t expectedBaseAddress = 0x1122334455667788; renderSurfaceState.setSurfaceBaseAddress(expectedBaseAddress); - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_EQ(expectedBaseAddress, hwHelper.getRenderSurfaceStateBaseAddress(&renderSurfaceState)); + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_EQ(expectedBaseAddress, gfxCoreHelper.getRenderSurfaceStateBaseAddress(&renderSurfaceState)); } -HWTEST_F(HwHelperTest, givenGetRenderSurfaceStatePitchCalledThenCorrectValueIsReturned) { +HWTEST_F(GfxCoreHelperTest, givenGetRenderSurfaceStatePitchCalledThenCorrectValueIsReturned) { using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; RENDER_SURFACE_STATE renderSurfaceState; uint32_t expectedPitch = 0x400; renderSurfaceState.setSurfacePitch(expectedPitch); - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_EQ(expectedPitch, hwHelper.getRenderSurfaceStatePitch(&renderSurfaceState)); + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_EQ(expectedPitch, gfxCoreHelper.getRenderSurfaceStatePitch(&renderSurfaceState)); } -TEST(HwHelperTests, whenBlitterSupportIsDisabledThenDontExposeAnyBcsEngine) { +TEST(GfxCoreHelperTests, whenBlitterSupportIsDisabledThenDontExposeAnyBcsEngine) { auto hwInfo = *defaultHwInfo; hwInfo.capabilityTable.blitterOperationsSupported = false; hwInfo.featureTable.ftrBcsInfo.set(0); - const auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - auto engineUsageTypes = hwHelper.getGpgpuEngineInstances(hwInfo); + const auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto engineUsageTypes = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); for (auto &engineUsageType : engineUsageTypes) { EXPECT_FALSE(EngineHelpers::isBcs(engineUsageType.first)); } } -HWTEST2_F(HwHelperTest, givenNotXeHpOrXeHpgCoreWhenDisableL3ForDebugCalledThenFalseIsReturned, IsNotXeHpOrXeHpgCore) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_FALSE(hwHelper.disableL3CacheForDebug(*defaultHwInfo)); +HWTEST2_F(GfxCoreHelperTest, givenNotXeHpOrXeHpgCoreWhenDisableL3ForDebugCalledThenFalseIsReturned, IsNotXeHpOrXeHpgCore) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.disableL3CacheForDebug(*defaultHwInfo)); } -HWTEST2_F(HwHelperTest, givenXeHpOrXeHpgCoreWhenDisableL3ForDebugCalledThenTrueIsReturned, IsXeHpOrXeHpgCore) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_TRUE(hwHelper.disableL3CacheForDebug(*defaultHwInfo)); +HWTEST2_F(GfxCoreHelperTest, givenXeHpOrXeHpgCoreWhenDisableL3ForDebugCalledThenTrueIsReturned, IsXeHpOrXeHpgCore) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_TRUE(gfxCoreHelper.disableL3CacheForDebug(*defaultHwInfo)); } -HWTEST_F(HwHelperTest, givenHwHelperWhenGettingIfRevisionSpecificBinaryBuiltinIsRequiredThenFalseIsReturned) { - auto &hwHelper = NEO::HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - EXPECT_FALSE(hwHelper.isRevisionSpecificBinaryBuiltinRequired()); +HWTEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenGettingIfRevisionSpecificBinaryBuiltinIsRequiredThenFalseIsReturned) { + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.isRevisionSpecificBinaryBuiltinRequired()); } -HWTEST2_F(HwHelperTest, givenDG2HwHelperWhenGettingIsPlatformFlushTaskEnabledThenTrueIsReturned, IsDG2) { - auto &hwHelper = NEO::HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - EXPECT_TRUE(hwHelper.isPlatformFlushTaskEnabled(*defaultHwInfo)); +HWTEST2_F(GfxCoreHelperTest, givenDG2GfxCoreHelperWhenGettingIsPlatformFlushTaskEnabledThenTrueIsReturned, IsDG2) { + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + EXPECT_TRUE(gfxCoreHelper.isPlatformFlushTaskEnabled(*defaultHwInfo)); } -HWTEST2_F(HwHelperTest, givenPvcHwHelperWhenGettingIsPlatformFlushTaskEnabledThenTrueIsReturned, IsPVC) { - auto &hwHelper = NEO::HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - EXPECT_TRUE(hwHelper.isPlatformFlushTaskEnabled(*defaultHwInfo)); +HWTEST2_F(GfxCoreHelperTest, givenPvcGfxCoreHelperWhenGettingIsPlatformFlushTaskEnabledThenTrueIsReturned, IsPVC) { + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + EXPECT_TRUE(gfxCoreHelper.isPlatformFlushTaskEnabled(*defaultHwInfo)); } -HWTEST2_F(HwHelperTest, givenAtMostGen12lpHwHelperWhenGettingIsPlatformFlushTaskEnabledThenFalseIsReturned, IsAtMostGen12lp) { - auto &hwHelper = NEO::HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - EXPECT_TRUE(hwHelper.isPlatformFlushTaskEnabled(*defaultHwInfo)); +HWTEST2_F(GfxCoreHelperTest, givenAtMostGen12lpGfxCoreHelperWhenGettingIsPlatformFlushTaskEnabledThenFalseIsReturned, IsAtMostGen12lp) { + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + EXPECT_TRUE(gfxCoreHelper.isPlatformFlushTaskEnabled(*defaultHwInfo)); } struct CoherentWANotNeeded { @@ -1289,10 +1289,10 @@ struct CoherentWANotNeeded { return !TestTraits::get()>::forceGpuNonCoherent; } }; -HWTEST2_F(HwHelperTest, givenHwInfoConfigWhenCheckingForceNonGpuCoherencyWAThenPassedValueReturned, CoherentWANotNeeded) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_TRUE(hwHelper.forceNonGpuCoherencyWA(true)); - EXPECT_FALSE(hwHelper.forceNonGpuCoherencyWA(false)); +HWTEST2_F(GfxCoreHelperTest, givenHwInfoConfigWhenCheckingForceNonGpuCoherencyWAThenPassedValueReturned, CoherentWANotNeeded) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_TRUE(gfxCoreHelper.forceNonGpuCoherencyWA(true)); + EXPECT_FALSE(gfxCoreHelper.forceNonGpuCoherencyWA(false)); } struct ForceNonCoherentMode { @@ -1304,67 +1304,67 @@ struct ForceNonCoherentMode { } }; -HWTEST2_F(HwHelperTest, givenHwInfoConfigWhenCheckingForceNonGpuCoherencyWAThenFalseIsReturned, ForceNonCoherentMode) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_FALSE(hwHelper.forceNonGpuCoherencyWA(true)); - EXPECT_FALSE(hwHelper.forceNonGpuCoherencyWA(false)); +HWTEST2_F(GfxCoreHelperTest, givenHwInfoConfigWhenCheckingForceNonGpuCoherencyWAThenFalseIsReturned, ForceNonCoherentMode) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.forceNonGpuCoherencyWA(true)); + EXPECT_FALSE(gfxCoreHelper.forceNonGpuCoherencyWA(false)); } -HWTEST_F(HwHelperTest, GivenHwInfoWhenGetBatchBufferEndSizeCalledThenCorrectSizeReturned) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_EQ(hwHelper.getBatchBufferEndSize(), sizeof(typename FamilyType::MI_BATCH_BUFFER_END)); +HWTEST_F(GfxCoreHelperTest, GivenHwInfoWhenGetBatchBufferEndSizeCalledThenCorrectSizeReturned) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_EQ(gfxCoreHelper.getBatchBufferEndSize(), sizeof(typename FamilyType::MI_BATCH_BUFFER_END)); } -HWTEST_F(HwHelperTest, GivenHwInfoWhenGetBatchBufferEndReferenceCalledThenCorrectPtrReturned) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_EQ(hwHelper.getBatchBufferEndReference(), reinterpret_cast(&FamilyType::cmdInitBatchBufferEnd)); +HWTEST_F(GfxCoreHelperTest, GivenHwInfoWhenGetBatchBufferEndReferenceCalledThenCorrectPtrReturned) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_EQ(gfxCoreHelper.getBatchBufferEndReference(), reinterpret_cast(&FamilyType::cmdInitBatchBufferEnd)); } -HWTEST_F(HwHelperTest, givenHwHelperWhenPassingCopyEngineTypeThenItsCopyOnly) { +HWTEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenPassingCopyEngineTypeThenItsCopyOnly) { EXPECT_TRUE(EngineHelper::isCopyOnlyEngineType(EngineGroupType::Copy)); } -HWTEST_F(HwHelperTest, givenHwHelperWhenPassingLinkedCopyEngineTypeThenItsCopyOnly) { +HWTEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenPassingLinkedCopyEngineTypeThenItsCopyOnly) { EXPECT_TRUE(EngineHelper::isCopyOnlyEngineType(EngineGroupType::LinkedCopy)); } -HWTEST_F(HwHelperTest, givenHwHelperWhenPassingComputeEngineTypeThenItsNotCopyOnly) { +HWTEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenPassingComputeEngineTypeThenItsNotCopyOnly) { EXPECT_FALSE(EngineHelper::isCopyOnlyEngineType(EngineGroupType::Compute)); } -HWTEST_F(HwHelperTest, givenHwHelperWhenAskingForRelaxedOrderingSupportThenReturnFalse) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_FALSE(hwHelper.isRelaxedOrderingSupported()); +HWTEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenAskingForRelaxedOrderingSupportThenReturnFalse) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.isRelaxedOrderingSupported()); } -HWTEST2_F(HwHelperTest, givenHwHelperWhenCallCopyThroughLockedPtrEnabledThenReturnFalse, IsNotXeHpgOrXeHpcCore) { - HwHelper &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - EXPECT_FALSE(hwHelper.copyThroughLockedPtrEnabled(*defaultHwInfo)); +HWTEST2_F(GfxCoreHelperTest, givenGfxCoreHelperWhenCallCopyThroughLockedPtrEnabledThenReturnFalse, IsNotXeHpgOrXeHpcCore) { + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.copyThroughLockedPtrEnabled(*defaultHwInfo)); } -HWTEST2_F(HwHelperTest, givenHwHelperWhenCallGetAmountOfAllocationsToFillThenReturnFalse, IsNotXeHpcCore) { - HwHelper &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - EXPECT_EQ(hwHelper.getAmountOfAllocationsToFill(), 0u); +HWTEST2_F(GfxCoreHelperTest, givenGfxCoreHelperWhenCallGetAmountOfAllocationsToFillThenReturnFalse, IsNotXeHpcCore) { + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + EXPECT_EQ(gfxCoreHelper.getAmountOfAllocationsToFill(), 0u); } -HWTEST_F(HwHelperTest, givenHwHelperWhenFlagSetAndCallCopyThroughLockedPtrEnabledThenReturnCorrectValue) { +HWTEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenFlagSetAndCallCopyThroughLockedPtrEnabledThenReturnCorrectValue) { DebugManagerStateRestore restorer; - HwHelper &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); DebugManager.flags.ExperimentalCopyThroughLock.set(0); - EXPECT_FALSE(hwHelper.copyThroughLockedPtrEnabled(*defaultHwInfo)); + EXPECT_FALSE(gfxCoreHelper.copyThroughLockedPtrEnabled(*defaultHwInfo)); DebugManager.flags.ExperimentalCopyThroughLock.set(1); - EXPECT_TRUE(hwHelper.copyThroughLockedPtrEnabled(*defaultHwInfo)); + EXPECT_TRUE(gfxCoreHelper.copyThroughLockedPtrEnabled(*defaultHwInfo)); } -HWTEST_F(HwHelperTest, givenHwHelperWhenFlagSetAndCallGetAmountOfAllocationsToFillThenReturnCorrectValue) { +HWTEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenFlagSetAndCallGetAmountOfAllocationsToFillThenReturnCorrectValue) { DebugManagerStateRestore restorer; - HwHelper &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); DebugManager.flags.SetAmountOfReusableAllocations.set(0); - EXPECT_EQ(hwHelper.getAmountOfAllocationsToFill(), 0u); + EXPECT_EQ(gfxCoreHelper.getAmountOfAllocationsToFill(), 0u); DebugManager.flags.SetAmountOfReusableAllocations.set(1); - EXPECT_EQ(hwHelper.getAmountOfAllocationsToFill(), 1u); + EXPECT_EQ(gfxCoreHelper.getAmountOfAllocationsToFill(), 1u); } using LogicalStateHelperTest = ::testing::Test; @@ -1373,54 +1373,54 @@ HWTEST_F(LogicalStateHelperTest, whenCreatingLogicalStateHelperThenReturnNullptr EXPECT_EQ(nullptr, LogicalStateHelper::create()); } -HWTEST2_F(HwHelperTest, GivenVariousValuesAndXeHpOrXeHpgCoreWhenCallingCalculateAvailableThreadCountThenCorrectValueIsReturned, IsXeHpOrXeHpgCore) { +HWTEST2_F(GfxCoreHelperTest, GivenVariousValuesAndXeHpOrXeHpgCoreWhenCallingCalculateAvailableThreadCountThenCorrectValueIsReturned, IsXeHpOrXeHpgCore) { std::array, 3> grfTestInputs = {{{64, 8}, {128, 8}, {256, 4}}}; const auto &hwInfo = *defaultHwInfo; - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); for (const auto &[grfCount, expectedThreadCountPerEu] : grfTestInputs) { auto expected = expectedThreadCountPerEu * hwInfo.gtSystemInfo.EUCount; - auto result = hwHelper.calculateAvailableThreadCount(hwInfo, grfCount); + auto result = gfxCoreHelper.calculateAvailableThreadCount(hwInfo, grfCount); EXPECT_EQ(expected, result); } } -HWTEST2_F(HwHelperTest, GivenModifiedGtSystemInfoAndXeHpOrXeHpgCoreWhenCallingCalculateAvailableThreadCountThenCorrectValueIsReturned, IsXeHpOrXeHpgCore) { +HWTEST2_F(GfxCoreHelperTest, GivenModifiedGtSystemInfoAndXeHpOrXeHpgCoreWhenCallingCalculateAvailableThreadCountThenCorrectValueIsReturned, IsXeHpOrXeHpgCore) { std::array, 3> testInputs = {{{1, 64, 1}, {5, 128, 5}, {8, 256, 4}}}; - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); auto hwInfo = hardwareInfo; for (const auto &[threadCount, grfCount, expectedThreadCount] : testInputs) { hwInfo.gtSystemInfo.ThreadCount = threadCount; - auto result = hwHelper.calculateAvailableThreadCount(hwInfo, grfCount); + auto result = gfxCoreHelper.calculateAvailableThreadCount(hwInfo, grfCount); EXPECT_EQ(expectedThreadCount, result); } } -HWTEST2_F(HwHelperTest, givenAtMostGen12lpPlatformWhenGettingMinimalScratchSpaceSizeThen1024IsReturned, IsAtMostGen12lp) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_EQ(1024U, hwHelper.getMinimalScratchSpaceSize()); +HWTEST2_F(GfxCoreHelperTest, givenAtMostGen12lpPlatformWhenGettingMinimalScratchSpaceSizeThen1024IsReturned, IsAtMostGen12lp) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_EQ(1024U, gfxCoreHelper.getMinimalScratchSpaceSize()); } -HWTEST2_F(HwHelperTest, givenAtLeastXeHpPlatformWhenGettingMinimalScratchSpaceSizeThen64IsReturned, IsAtLeastXeHpCore) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_EQ(64U, hwHelper.getMinimalScratchSpaceSize()); +HWTEST2_F(GfxCoreHelperTest, givenAtLeastXeHpPlatformWhenGettingMinimalScratchSpaceSizeThen64IsReturned, IsAtLeastXeHpCore) { + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_EQ(64U, gfxCoreHelper.getMinimalScratchSpaceSize()); } -TEST(HwHelperTests, whenIsDynamicallyPopulatedisFalseThengetHighestEnabledSliceReturnsMaxSlicesSupported) { +TEST(GfxCoreHelperTests, whenIsDynamicallyPopulatedisFalseThengetHighestEnabledSliceReturnsMaxSlicesSupported) { auto hwInfo = *defaultHwInfo; hwInfo.gtSystemInfo.IsDynamicallyPopulated = false; hwInfo.gtSystemInfo.MaxSlicesSupported = 4; - const auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - auto maxSlice = hwHelper.getHighestEnabledSlice(hwInfo); + const auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto maxSlice = gfxCoreHelper.getHighestEnabledSlice(hwInfo); EXPECT_EQ(maxSlice, hwInfo.gtSystemInfo.MaxSlicesSupported); } -TEST(HwHelperTests, whenIsDynamicallyPopulatedisTrueThengetHighestEnabledSliceReturnsHighestEnabledSliceInfo) { +TEST(GfxCoreHelperTests, whenIsDynamicallyPopulatedisTrueThengetHighestEnabledSliceReturnsHighestEnabledSliceInfo) { auto hwInfo = *defaultHwInfo; hwInfo.gtSystemInfo.IsDynamicallyPopulated = true; @@ -1429,7 +1429,7 @@ TEST(HwHelperTests, whenIsDynamicallyPopulatedisTrueThengetHighestEnabledSliceRe hwInfo.gtSystemInfo.SliceInfo[i].Enabled = false; } hwInfo.gtSystemInfo.SliceInfo[6].Enabled = true; - const auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - auto maxSlice = hwHelper.getHighestEnabledSlice(hwInfo); + const auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto maxSlice = gfxCoreHelper.getHighestEnabledSlice(hwInfo); EXPECT_EQ(maxSlice, 7u); } diff --git a/shared/test/unit_test/helpers/hw_helper_tests_dg2_and_later.cpp b/shared/test/unit_test/helpers/hw_helper_tests_dg2_and_later.cpp index 1518d82ee5..05a2207401 100644 --- a/shared/test/unit_test/helpers/hw_helper_tests_dg2_and_later.cpp +++ b/shared/test/unit_test/helpers/hw_helper_tests_dg2_and_later.cpp @@ -16,13 +16,13 @@ using namespace NEO; -using HwHelperDg2AndLaterTest = ::testing::Test; +using GfxCoreHelperDg2AndLaterTest = ::testing::Test; -HWTEST2_F(HwHelperDg2AndLaterTest, GivenUseL1CacheAsTrueWhenCallSetL1CachePolicyThenL1CachePolicyL1CacheControlIsSetProperly, IsAtLeastXeHpgCore) { +HWTEST2_F(GfxCoreHelperDg2AndLaterTest, GivenUseL1CacheAsTrueWhenCallSetL1CachePolicyThenL1CachePolicyL1CacheControlIsSetProperly, IsAtLeastXeHpgCore) { using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; using SURFACE_TYPE = typename RENDER_SURFACE_STATE::SURFACE_TYPE; - auto &helper = reinterpret_cast &>(HwHelperHw::get()); + auto &helper = reinterpret_cast &>(GfxCoreHelperHw::get()); RENDER_SURFACE_STATE surfaceState = FamilyType::cmdInitRenderSurfaceState; bool useL1Cache = true; @@ -30,14 +30,14 @@ HWTEST2_F(HwHelperDg2AndLaterTest, GivenUseL1CacheAsTrueWhenCallSetL1CachePolicy EXPECT_EQ(RENDER_SURFACE_STATE::L1_CACHE_POLICY_WB, surfaceState.getL1CachePolicyL1CacheControl()); } -HWTEST2_F(HwHelperDg2AndLaterTest, GivenOverrideL1CacheControlInSurfaceStateForScratchSpaceWhenCallSetL1CachePolicyThenL1CachePolicyL1CacheControlIsSetProperly, IsAtLeastXeHpgCore) { +HWTEST2_F(GfxCoreHelperDg2AndLaterTest, GivenOverrideL1CacheControlInSurfaceStateForScratchSpaceWhenCallSetL1CachePolicyThenL1CachePolicyL1CacheControlIsSetProperly, IsAtLeastXeHpgCore) { DebugManagerStateRestore restore; DebugManager.flags.OverrideL1CacheControlInSurfaceStateForScratchSpace.set(1); using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; using SURFACE_TYPE = typename RENDER_SURFACE_STATE::SURFACE_TYPE; - auto &helper = reinterpret_cast &>(HwHelperHw::get()); + auto &helper = reinterpret_cast &>(GfxCoreHelperHw::get()); RENDER_SURFACE_STATE surfaceState = FamilyType::cmdInitRenderSurfaceState; bool useL1Cache = true; @@ -45,11 +45,11 @@ HWTEST2_F(HwHelperDg2AndLaterTest, GivenOverrideL1CacheControlInSurfaceStateForS EXPECT_EQ(RENDER_SURFACE_STATE::L1_CACHE_POLICY_UC, surfaceState.getL1CachePolicyL1CacheControl()); } -HWTEST2_F(HwHelperDg2AndLaterTest, GivenUseL1CacheAsFalseWhenCallSetL1CachePolicyThenL1CachePolicyL1CacheControlIsNotSet, IsAtLeastXeHpgCore) { +HWTEST2_F(GfxCoreHelperDg2AndLaterTest, GivenUseL1CacheAsFalseWhenCallSetL1CachePolicyThenL1CachePolicyL1CacheControlIsNotSet, IsAtLeastXeHpgCore) { using RENDER_SURFACE_STATE = typename FamilyType::RENDER_SURFACE_STATE; using SURFACE_TYPE = typename RENDER_SURFACE_STATE::SURFACE_TYPE; - auto &helper = reinterpret_cast &>(HwHelperHw::get()); + auto &helper = reinterpret_cast &>(GfxCoreHelperHw::get()); RENDER_SURFACE_STATE surfaceState = FamilyType::cmdInitRenderSurfaceState; bool useL1Cache = false; helper.setL1CachePolicy(useL1Cache, &surfaceState, defaultHwInfo.get()); @@ -188,15 +188,15 @@ HWTEST2_F(PipeControlHelperTestsDg2AndLater, givenDebugDisableCacheFlushWhenProg EXPECT_FALSE(pipeControl->getCompressionControlSurfaceCcsFlush()); } -HWTEST2_F(HwHelperDg2AndLaterTest, givenXeHPGAndLaterPlatformWhenCheckingIfUnTypedDataPortCacheFlushRequiredThenReturnTrue, IsAtLeastXeHpgCore) { - auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_TRUE(hwHelper.unTypedDataPortCacheFlushRequired()); +HWTEST2_F(GfxCoreHelperDg2AndLaterTest, givenXeHPGAndLaterPlatformWhenCheckingIfUnTypedDataPortCacheFlushRequiredThenReturnTrue, IsAtLeastXeHpgCore) { + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_TRUE(gfxCoreHelper.unTypedDataPortCacheFlushRequired()); } -HWTEST2_F(HwHelperDg2AndLaterTest, givenHwHelperWhenCheckIsUpdateTaskCountFromWaitSupportedThenReturnsTrue, IsAtLeastXeHpgCore) { - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); +HWTEST2_F(GfxCoreHelperDg2AndLaterTest, givenGfxCoreHelperWhenCheckIsUpdateTaskCountFromWaitSupportedThenReturnsTrue, IsAtLeastXeHpgCore) { + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - EXPECT_TRUE(hwHelper.isUpdateTaskCountFromWaitSupported()); + EXPECT_TRUE(gfxCoreHelper.isUpdateTaskCountFromWaitSupported()); } using HwInfoConfigTestDg2AndLater = ::testing::Test; diff --git a/shared/test/unit_test/helpers/hw_helper_tests_dg2_or_below.cpp b/shared/test/unit_test/helpers/hw_helper_tests_dg2_or_below.cpp index 6c2c7ba6be..2769158adc 100644 --- a/shared/test/unit_test/helpers/hw_helper_tests_dg2_or_below.cpp +++ b/shared/test/unit_test/helpers/hw_helper_tests_dg2_or_below.cpp @@ -11,10 +11,10 @@ using namespace NEO; -using HwHelperDg2OrBelowTests = ::testing::Test; +using GfxCoreHelperDg2OrBelowTests = ::testing::Test; using isDG2OrBelow = IsAtMostProduct; -HWTEST2_F(HwHelperDg2OrBelowTests, WhenGettingIsKmdMigrationSupportedThenFalseIsReturned, isDG2OrBelow) { - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - EXPECT_FALSE(hwHelper.isKmdMigrationSupported(*defaultHwInfo)); +HWTEST2_F(GfxCoreHelperDg2OrBelowTests, WhenGettingIsKmdMigrationSupportedThenFalseIsReturned, isDG2OrBelow) { + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.isKmdMigrationSupported(*defaultHwInfo)); } \ No newline at end of file diff --git a/shared/test/unit_test/helpers/hw_helper_tests_pvc_and_later.cpp b/shared/test/unit_test/helpers/hw_helper_tests_pvc_and_later.cpp index ed826a1646..a61aad9c4e 100644 --- a/shared/test/unit_test/helpers/hw_helper_tests_pvc_and_later.cpp +++ b/shared/test/unit_test/helpers/hw_helper_tests_pvc_and_later.cpp @@ -14,12 +14,12 @@ #include "shared/test/common/helpers/mock_hw_info_config_hw.h" #include "shared/test/common/test_macros/hw_test.h" -using HwHelperTestPvcAndLater = HwHelperTest; +using GfxCoreHelperTestPvcAndLater = GfxCoreHelperTest; -HWTEST2_F(HwHelperTestPvcAndLater, givenVariousCachesRequestsThenProperMocsIndexesAreBeingReturned, IsAtLeastXeHpcCore) { +HWTEST2_F(GfxCoreHelperTestPvcAndLater, givenVariousCachesRequestsThenProperMocsIndexesAreBeingReturned, IsAtLeastXeHpcCore) { DebugManagerStateRestore restore; - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); auto gmmHelper = this->pDevice->getRootDeviceEnvironment().getGmmHelper(); auto expectedMocsForL3off = gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER_CACHELINE_MISALIGNED) >> 1; auto expectedMocsForL3on = gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER) >> 1; @@ -34,11 +34,11 @@ HWTEST2_F(HwHelperTestPvcAndLater, givenVariousCachesRequestsThenProperMocsIndex EXPECT_EQ(expectedMocsForL3on, mocsIndex); } -HWTEST2_F(HwHelperTestPvcAndLater, givenRenderEngineWhenRemapCalledThenUseCccs, IsAtLeastXeHpcCore) { +HWTEST2_F(GfxCoreHelperTestPvcAndLater, givenRenderEngineWhenRemapCalledThenUseCccs, IsAtLeastXeHpcCore) { hardwareInfo.featureTable.flags.ftrCCSNode = false; - auto &coreHelper = getHelper(); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + auto &gfxCoreHelper = getHelper(); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(aub_stream::EngineType::ENGINE_CCCS, EngineHelpers::remapEngineTypeToHwSpecific(aub_stream::EngineType::ENGINE_RCS, hardwareInfo)); EXPECT_EQ(aub_stream::EngineType::ENGINE_CCCS, EngineHelpers::remapEngineTypeToHwSpecific(aub_stream::EngineType::ENGINE_CCCS, hardwareInfo)); @@ -46,42 +46,42 @@ HWTEST2_F(HwHelperTestPvcAndLater, givenRenderEngineWhenRemapCalledThenUseCccs, EXPECT_EQ(aub_stream::EngineType::ENGINE_BCS, EngineHelpers::remapEngineTypeToHwSpecific(aub_stream::EngineType::ENGINE_BCS, hardwareInfo)); } -HWTEST2_F(HwHelperTestPvcAndLater, GivenVariousValuesAndPvcAndLaterPlatformsWhenCallingCalculateAvailableThreadCountThenCorrectValueIsReturned, IsAtLeastXeHpcCore) { +HWTEST2_F(GfxCoreHelperTestPvcAndLater, GivenVariousValuesAndPvcAndLaterPlatformsWhenCallingCalculateAvailableThreadCountThenCorrectValueIsReturned, IsAtLeastXeHpcCore) { std::array, 6> grfTestInputs = {{{64, 16}, {96, 10}, {128, 8}, {160, 6}, {192, 5}, {256, 4}}}; - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); for (const auto &[grfCount, expectedThreadCountPerEu] : grfTestInputs) { auto expected = expectedThreadCountPerEu * hardwareInfo.gtSystemInfo.EUCount; - auto result = hwHelper.calculateAvailableThreadCount(hardwareInfo, grfCount); + auto result = gfxCoreHelper.calculateAvailableThreadCount(hardwareInfo, grfCount); EXPECT_EQ(expected, result); } } -HWTEST2_F(HwHelperTestPvcAndLater, GivenModifiedGtSystemInfoAndPvcAndLaterPlatformsWhenCallingCalculateAvailableThreadCountThenCorrectValueIsReturned, IsAtLeastXeHpcCore) { +HWTEST2_F(GfxCoreHelperTestPvcAndLater, GivenModifiedGtSystemInfoAndPvcAndLaterPlatformsWhenCallingCalculateAvailableThreadCountThenCorrectValueIsReturned, IsAtLeastXeHpcCore) { std::array, 3> testInputs = {{{64, 256}, {96, 384}, {128, 512}}}; - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); auto hwInfo = hardwareInfo; for (const auto &[euCount, expectedThreadCount] : testInputs) { hwInfo.gtSystemInfo.EUCount = euCount; - auto result = hwHelper.calculateAvailableThreadCount(hwInfo, 256); + auto result = gfxCoreHelper.calculateAvailableThreadCount(hwInfo, 256); EXPECT_EQ(expectedThreadCount, result); } } -HWTEST2_F(HwHelperTestPvcAndLater, givenHwHelperWhenCheckIsUpdateTaskCountFromWaitSupportedThenReturnsTrue, IsAtLeastXeHpcCore) { - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); +HWTEST2_F(GfxCoreHelperTestPvcAndLater, givenGfxCoreHelperWhenCheckIsUpdateTaskCountFromWaitSupportedThenReturnsTrue, IsAtLeastXeHpcCore) { + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); - EXPECT_TRUE(hwHelper.isUpdateTaskCountFromWaitSupported()); + EXPECT_TRUE(gfxCoreHelper.isUpdateTaskCountFromWaitSupported()); } -HWTEST2_F(HwHelperTestPvcAndLater, givenComputeEngineAndCooperativeUsageWhenGetEngineGroupTypeIsCalledThenCooperativeComputeGroupTypeIsReturned, IsAtLeastXeHpcCore) { - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); +HWTEST2_F(GfxCoreHelperTestPvcAndLater, givenComputeEngineAndCooperativeUsageWhenGetEngineGroupTypeIsCalledThenCooperativeComputeGroupTypeIsReturned, IsAtLeastXeHpcCore) { + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); auto hwInfo = *::defaultHwInfo; hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 4; aub_stream::EngineType engineTypes[] = {aub_stream::EngineType::ENGINE_CCS, aub_stream::EngineType::ENGINE_CCS1, @@ -91,21 +91,21 @@ HWTEST2_F(HwHelperTestPvcAndLater, givenComputeEngineAndCooperativeUsageWhenGetE for (auto engineType : engineTypes) { for (auto engineUsage : engineUsages) { if (engineUsage == EngineUsage::Cooperative) { - EXPECT_EQ(EngineGroupType::CooperativeCompute, hwHelper.getEngineGroupType(engineType, engineUsage, hwInfo)); + EXPECT_EQ(EngineGroupType::CooperativeCompute, gfxCoreHelper.getEngineGroupType(engineType, engineUsage, hwInfo)); } else { - EXPECT_EQ(EngineGroupType::Compute, hwHelper.getEngineGroupType(engineType, engineUsage, hwInfo)); + EXPECT_EQ(EngineGroupType::Compute, gfxCoreHelper.getEngineGroupType(engineType, engineUsage, hwInfo)); } } } } -HWTEST2_F(HwHelperTestPvcAndLater, givenPVCAndLaterPlatformWhenCheckingIfEngineTypeRemappingIsRequiredThenReturnTrue, IsAtLeastXeHpcCore) { - const auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - EXPECT_TRUE(hwHelper.isEngineTypeRemappingToHwSpecificRequired()); +HWTEST2_F(GfxCoreHelperTestPvcAndLater, givenPVCAndLaterPlatformWhenCheckingIfEngineTypeRemappingIsRequiredThenReturnTrue, IsAtLeastXeHpcCore) { + const auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + EXPECT_TRUE(gfxCoreHelper.isEngineTypeRemappingToHwSpecificRequired()); } -HWTEST2_F(HwHelperTestPvcAndLater, WhenIsRcsAvailableIsCalledThenCorrectValueIsReturned, IsAtLeastXeHpcCore) { - auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); +HWTEST2_F(GfxCoreHelperTestPvcAndLater, WhenIsRcsAvailableIsCalledThenCorrectValueIsReturned, IsAtLeastXeHpcCore) { + auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); auto hwInfo = *::defaultHwInfo; aub_stream::EngineType defaultEngineTypes[] = {aub_stream::EngineType::ENGINE_RCS, aub_stream::EngineType::ENGINE_CCCS, aub_stream::EngineType::ENGINE_BCS, aub_stream::EngineType::ENGINE_BCS2, @@ -117,16 +117,16 @@ HWTEST2_F(HwHelperTestPvcAndLater, WhenIsRcsAvailableIsCalledThenCorrectValueIsR if (ftrRcsNode || (defaultEngineType == aub_stream::EngineType::ENGINE_RCS) || (defaultEngineType == aub_stream::EngineType::ENGINE_CCCS)) { - EXPECT_TRUE(hwHelper.isRcsAvailable(hwInfo)); + EXPECT_TRUE(gfxCoreHelper.isRcsAvailable(hwInfo)); } else { - EXPECT_FALSE(hwHelper.isRcsAvailable(hwInfo)); + EXPECT_FALSE(gfxCoreHelper.isRcsAvailable(hwInfo)); } } } } -HWTEST2_F(HwHelperTestPvcAndLater, WhenIsCooperativeDispatchSupportedThenCorrectValueIsReturned, IsAtLeastXeHpcCore) { - struct MockHwHelper : NEO::HwHelperHw { +HWTEST2_F(GfxCoreHelperTestPvcAndLater, WhenIsCooperativeDispatchSupportedThenCorrectValueIsReturned, IsAtLeastXeHpcCore) { + struct MockGfxCoreHelper : NEO::GfxCoreHelperHw { bool isRcsAvailable(const HardwareInfo &hwInfo) const override { return isRcsAvailableValue; } @@ -138,16 +138,16 @@ HWTEST2_F(HwHelperTestPvcAndLater, WhenIsCooperativeDispatchSupportedThenCorrect VariableBackup hwInfoConfigFactoryBackup{&NEO::hwInfoConfigFactory[static_cast(hwInfo.platform.eProductFamily)]}; hwInfoConfigFactoryBackup = &hwInfoConfig; - MockHwHelper hwHelper{}; + MockGfxCoreHelper gfxCoreHelper{}; for (auto isCooperativeEngineSupported : ::testing::Bool()) { hwInfoConfig.isCooperativeEngineSupportedValue = isCooperativeEngineSupported; for (auto isRcsAvailable : ::testing::Bool()) { - hwHelper.isRcsAvailableValue = isRcsAvailable; + gfxCoreHelper.isRcsAvailableValue = isRcsAvailable; for (auto engineGroupType : {EngineGroupType::RenderCompute, EngineGroupType::Compute, EngineGroupType::CooperativeCompute}) { - auto isCooperativeDispatchSupported = hwHelper.isCooperativeDispatchSupported(engineGroupType, hwInfo); + auto isCooperativeDispatchSupported = gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, hwInfo); if (isCooperativeEngineSupported) { switch (engineGroupType) { case EngineGroupType::RenderCompute: @@ -167,12 +167,12 @@ HWTEST2_F(HwHelperTestPvcAndLater, WhenIsCooperativeDispatchSupportedThenCorrect } } -HWTEST2_F(HwHelperTestPvcAndLater, givenHwHelperWhenGettingISAPaddingThenCorrectValueIsReturned, IsAtLeastXeHpcCore) { - auto &helper = getHelper(); +HWTEST2_F(GfxCoreHelperTestPvcAndLater, givenGfxCoreHelperWhenGettingISAPaddingThenCorrectValueIsReturned, IsAtLeastXeHpcCore) { + auto &helper = getHelper(); EXPECT_EQ(helper.getPaddingForISAAllocation(), 0xE00u); } -HWTEST2_F(HwHelperTestPvcAndLater, givenForceBCSForInternalCopyEngineVariableSetWhenGetGpgpuEnginesCalledThenForceInternalBCSEngineIndex, IsAtLeastXeHpcCore) { +HWTEST2_F(GfxCoreHelperTestPvcAndLater, givenForceBCSForInternalCopyEngineVariableSetWhenGetGpgpuEnginesCalledThenForceInternalBCSEngineIndex, IsAtLeastXeHpcCore) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.ftrBcsInfo = maxNBitValue(9); hwInfo.capabilityTable.blitterOperationsSupported = true; @@ -182,7 +182,7 @@ HWTEST2_F(HwHelperTestPvcAndLater, givenForceBCSForInternalCopyEngineVariableSet auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_GE(engines.size(), 9u); bool found = false; @@ -194,12 +194,12 @@ HWTEST2_F(HwHelperTestPvcAndLater, givenForceBCSForInternalCopyEngineVariableSet EXPECT_TRUE(found); } -using HwHelperTestCooperativeEngine = HwHelperTestPvcAndLater; -HWTEST2_F(HwHelperTestCooperativeEngine, givenCooperativeContextSupportedWhenGetEngineInstancesThenReturnCorrectAmountOfCooperativeCcs, IsXeHpcCore) { +using GfxCoreHelperTestCooperativeEngine = GfxCoreHelperTestPvcAndLater; +HWTEST2_F(GfxCoreHelperTestCooperativeEngine, givenCooperativeContextSupportedWhenGetEngineInstancesThenReturnCorrectAmountOfCooperativeCcs, IsXeHpcCore) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 2; hwInfo.featureTable.flags.ftrCCSNode = true; - auto &hwHelper = HwHelperHw::get(); + auto &gfxCoreHelper = GfxCoreHelperHw::get(); auto &hwInfoConfig = *HwInfoConfig::get(hwInfo.platform.eProductFamily); uint32_t revisions[] = {REVISION_A0, REVISION_B}; @@ -209,7 +209,7 @@ HWTEST2_F(HwHelperTestCooperativeEngine, givenCooperativeContextSupportedWhenGet continue; } hwInfo.platform.usRevId = hwRevId; - auto engineInstances = hwHelper.getGpgpuEngineInstances(hwInfo); + auto engineInstances = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); size_t ccsCount = 0u; size_t cooperativeCcsCount = 0u; for (auto &engineInstance : engineInstances) { diff --git a/shared/test/unit_test/helpers/kernel_helpers_tests.cpp b/shared/test/unit_test/helpers/kernel_helpers_tests.cpp index 1d82ef7f20..9a3cadea60 100644 --- a/shared/test/unit_test/helpers/kernel_helpers_tests.cpp +++ b/shared/test/unit_test/helpers/kernel_helpers_tests.cpp @@ -95,8 +95,8 @@ TEST_F(KernelHelperTest, GivenScratchSizeGreaterThanGlobalSizeWhenCheckingIfTher auto globalSize = pDevice->getDeviceInfo().globalMemSize; KernelDescriptor::KernelAttributes attributes = {}; attributes.perThreadScratchSize[0] = (static_cast((globalSize + pDevice->getDeviceInfo().computeUnitsUsedForScratch) / pDevice->getDeviceInfo().computeUnitsUsedForScratch)) + 100; - auto &hwHelper = NEO::HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); - if (attributes.perThreadScratchSize[0] > hwHelper.getMaxScratchSize()) { + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + if (attributes.perThreadScratchSize[0] > gfxCoreHelper.getMaxScratchSize()) { EXPECT_EQ(KernelHelper::checkIfThereIsSpaceForScratchOrPrivate(attributes, pDevice), KernelHelper::ErrorCode::INVALID_KERNEL); } else { EXPECT_EQ(KernelHelper::checkIfThereIsSpaceForScratchOrPrivate(attributes, pDevice), KernelHelper::ErrorCode::OUT_OF_DEVICE_MEMORY); @@ -107,8 +107,8 @@ TEST_F(KernelHelperTest, GivenScratchPrivateSizeGreaterThanGlobalSizeWhenCheckin auto globalSize = pDevice->getDeviceInfo().globalMemSize; KernelDescriptor::KernelAttributes attributes = {}; attributes.perThreadScratchSize[1] = (static_cast((globalSize + pDevice->getDeviceInfo().computeUnitsUsedForScratch) / pDevice->getDeviceInfo().computeUnitsUsedForScratch)) + 100; - auto &hwHelper = NEO::HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); - if (attributes.perThreadScratchSize[1] > hwHelper.getMaxScratchSize()) { + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + if (attributes.perThreadScratchSize[1] > gfxCoreHelper.getMaxScratchSize()) { EXPECT_EQ(KernelHelper::checkIfThereIsSpaceForScratchOrPrivate(attributes, pDevice), KernelHelper::ErrorCode::INVALID_KERNEL); } else { EXPECT_EQ(KernelHelper::checkIfThereIsSpaceForScratchOrPrivate(attributes, pDevice), KernelHelper::ErrorCode::OUT_OF_DEVICE_MEMORY); @@ -120,8 +120,8 @@ TEST_F(KernelHelperTest, GivenScratchAndPrivateSizeLessThanGlobalSizeWhenCheckin KernelDescriptor::KernelAttributes attributes = {}; auto size = (static_cast((globalSize + pDevice->getDeviceInfo().computeUnitsUsedForScratch) / pDevice->getDeviceInfo().computeUnitsUsedForScratch)) - 100; attributes.perHwThreadPrivateMemorySize = size; - auto &coreHelper = pDevice->getRootDeviceEnvironment().getHelper(); - uint32_t maxScratchSize = coreHelper.getMaxScratchSize(); + auto &gfxCoreHelper = pDevice->getRootDeviceEnvironment().getHelper(); + uint32_t maxScratchSize = gfxCoreHelper.getMaxScratchSize(); attributes.perThreadScratchSize[0] = (size > maxScratchSize) ? maxScratchSize : size; attributes.perThreadScratchSize[1] = (size > maxScratchSize) ? maxScratchSize : size; EXPECT_EQ(KernelHelper::checkIfThereIsSpaceForScratchOrPrivate(attributes, pDevice), KernelHelper::ErrorCode::SUCCESS); @@ -129,8 +129,8 @@ TEST_F(KernelHelperTest, GivenScratchAndPrivateSizeLessThanGlobalSizeWhenCheckin TEST_F(KernelHelperTest, GivenScratchSizeGreaterThanMaxScratchSizeWhenCheckingIfThereIsEnaughSpaceThenInvalidKernelIsReturned) { KernelDescriptor::KernelAttributes attributes = {}; - auto &coreHelper = pDevice->getRootDeviceEnvironment().getHelper(); - uint32_t maxScratchSize = coreHelper.getMaxScratchSize(); + auto &gfxCoreHelper = pDevice->getRootDeviceEnvironment().getHelper(); + uint32_t maxScratchSize = gfxCoreHelper.getMaxScratchSize(); attributes.perHwThreadPrivateMemorySize = 0x10; attributes.perThreadScratchSize[0] = maxScratchSize + 1; attributes.perThreadScratchSize[1] = 0x10; @@ -139,8 +139,8 @@ TEST_F(KernelHelperTest, GivenScratchSizeGreaterThanMaxScratchSizeWhenCheckingIf TEST_F(KernelHelperTest, GivenScratchPrivateSizeGreaterThanMaxScratchSizeWhenCheckingIfThereIsEnaughSpaceThenInvalidKernelIsReturned) { KernelDescriptor::KernelAttributes attributes = {}; - auto &coreHelper = pDevice->getRootDeviceEnvironment().getHelper(); - uint32_t maxScratchSize = coreHelper.getMaxScratchSize(); + auto &gfxCoreHelper = pDevice->getRootDeviceEnvironment().getHelper(); + uint32_t maxScratchSize = gfxCoreHelper.getMaxScratchSize(); attributes.perHwThreadPrivateMemorySize = 0x10; attributes.perThreadScratchSize[0] = 0x10; attributes.perThreadScratchSize[1] = maxScratchSize + 1; diff --git a/shared/test/unit_test/helpers/timestamp_packet_tests.cpp b/shared/test/unit_test/helpers/timestamp_packet_tests.cpp index 0008bd98e2..5cfe1675d4 100644 --- a/shared/test/unit_test/helpers/timestamp_packet_tests.cpp +++ b/shared/test/unit_test/helpers/timestamp_packet_tests.cpp @@ -276,15 +276,15 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, DeviceTimestampPacketTests, givenInvalidDebugFlagSe HWTEST_F(DeviceTimestampPacketTests, givenTagAlignmentWhenCreatingAllocatorThenGpuAddressIsAligned) { auto csr = executionEnvironment->memoryManager->getRegisteredEngines()[0].commandStreamReceiver; - auto &hwHelper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); auto allocator = csr->getTimestampPacketAllocator(); auto tag1 = allocator->getTag(); auto tag2 = allocator->getTag(); - EXPECT_TRUE(isAligned(tag1->getGpuAddress(), hwHelper.getTimestampPacketAllocatorAlignment())); - EXPECT_TRUE(isAligned(tag2->getGpuAddress(), hwHelper.getTimestampPacketAllocatorAlignment())); + EXPECT_TRUE(isAligned(tag1->getGpuAddress(), gfxCoreHelper.getTimestampPacketAllocatorAlignment())); + EXPECT_TRUE(isAligned(tag2->getGpuAddress(), gfxCoreHelper.getTimestampPacketAllocatorAlignment())); } HWTEST_F(DeviceTimestampPacketTests, givenDebugFlagSetWhenCreatingTimestampPacketAllocatorThenDisableReusingAndLimitPoolSize) { diff --git a/shared/test/unit_test/memory_manager/memory_manager_allocate_in_device_pool_tests.cpp b/shared/test/unit_test/memory_manager/memory_manager_allocate_in_device_pool_tests.cpp index ee086eb490..75e901e2d0 100644 --- a/shared/test/unit_test/memory_manager/memory_manager_allocate_in_device_pool_tests.cpp +++ b/shared/test/unit_test/memory_manager/memory_manager_allocate_in_device_pool_tests.cpp @@ -260,8 +260,8 @@ HWTEST_F(MemoryManagerTests, givenEnabledLocalMemoryWhenAllocatingDebugAreaThenH mockDeviceBitfield}; properties.flags.use32BitFrontWindow = true; - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - auto systemMemoryPlacement = hwHelper.useSystemMemoryPlacementForISA(*defaultHwInfo); + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + auto systemMemoryPlacement = gfxCoreHelper.useSystemMemoryPlacementForISA(*defaultHwInfo); HeapIndex expectedHeap = HeapIndex::TOTAL_HEAPS; HeapIndex baseHeap = HeapIndex::TOTAL_HEAPS; @@ -489,7 +489,7 @@ TEST(MemoryManagerTest, givenOsAgnosticMemoryManagerWhenGetLocalMemoryIsCalledTh auto hwInfo = executionEnvironment.rootDeviceEnvironments[0]->getHardwareInfo(); - auto subDevicesCount = HwHelper::getSubDevicesCount(hwInfo); + auto subDevicesCount = GfxCoreHelper::getSubDevicesCount(hwInfo); uint32_t deviceMask = static_cast(maxNBitValue(subDevicesCount)); EXPECT_EQ(AubHelper::getPerTileLocalMemorySize(hwInfo) * subDevicesCount, memoryManager.getLocalMemorySize(0u, deviceMask)); diff --git a/shared/test/unit_test/memory_manager/memory_manager_allocate_in_preferred_pool_tests.cpp b/shared/test/unit_test/memory_manager/memory_manager_allocate_in_preferred_pool_tests.cpp index 27ba7c144a..f9d6c2aaf5 100644 --- a/shared/test/unit_test/memory_manager/memory_manager_allocate_in_preferred_pool_tests.cpp +++ b/shared/test/unit_test/memory_manager/memory_manager_allocate_in_preferred_pool_tests.cpp @@ -1022,7 +1022,7 @@ TEST(MemoryManagerTest, givenPropertiesWithOsContextWhenGetAllocationDataIsCalle MockMemoryManager mockMemoryManager; AllocationProperties properties{0, 1, AllocationType::DEBUG_CONTEXT_SAVE_AREA, mockDeviceBitfield}; - MockOsContext osContext(0u, EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0])); + MockOsContext osContext(0u, EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0])); properties.osContext = &osContext; diff --git a/shared/test/unit_test/memory_manager/surface_tests.cpp b/shared/test/unit_test/memory_manager/surface_tests.cpp index 409505f3f1..c42146ba46 100644 --- a/shared/test/unit_test/memory_manager/surface_tests.cpp +++ b/shared/test/unit_test/memory_manager/surface_tests.cpp @@ -61,7 +61,7 @@ HWTEST_TYPED_TEST(SurfaceTest, GivenSurfaceWhenInterfaceIsUsedThenSurfaceBehaves DeviceBitfield deviceBitfield(1); auto csr = std::make_unique>(execStamp, *executionEnvironment, 0, deviceBitfield); auto hwInfo = *defaultHwInfo; - auto engine = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0]; + auto engine = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0]; auto osContext = executionEnvironment->memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(engine, PreemptionHelper::getDefaultPreemptionMode(hwInfo))); csr->setupContext(*osContext); @@ -115,7 +115,7 @@ HWTEST_F(GeneralSurfaceTest, givenGeneralSurfaceWhenMigrationNeededThenMoveToGpu DeviceBitfield deviceBitfield(1); auto csr = std::make_unique>(execStamp, *executionEnvironment, 0, deviceBitfield); auto hwInfo = *defaultHwInfo; - auto engine = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0]; + auto engine = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0]; auto osContext = executionEnvironment->memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(engine, PreemptionHelper::getDefaultPreemptionMode(hwInfo))); csr->setupContext(*osContext); @@ -137,7 +137,7 @@ HWTEST_F(GeneralSurfaceTest, givenGeneralSurfaceWhenMigrationNotNeededThenMoveTo DeviceBitfield deviceBitfield(1); auto csr = std::make_unique>(execStamp, *executionEnvironment, 0, deviceBitfield); auto hwInfo = *defaultHwInfo; - auto engine = HwHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0]; + auto engine = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0]; auto osContext = executionEnvironment->memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(engine, PreemptionHelper::getDefaultPreemptionMode(hwInfo))); csr->setupContext(*osContext); diff --git a/shared/test/unit_test/os_interface/device_uuid_tests.cpp b/shared/test/unit_test/os_interface/device_uuid_tests.cpp index b63dbefaa1..7d66905edb 100644 --- a/shared/test/unit_test/os_interface/device_uuid_tests.cpp +++ b/shared/test/unit_test/os_interface/device_uuid_tests.cpp @@ -179,7 +179,7 @@ HWTEST2_F(DeviceUuidEnablementTest, GivenEnableChipsetUniqueUUIDIsDefaultWhenDev EXPECT_EQ(true, deviceFactory->rootDevices[0]->getUuid(uuid)); - if (HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).isChipsetUniqueUUIDSupported()) { + if (GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).isChipsetUniqueUUIDSupported()) { EXPECT_TRUE(0 == std::memcmp(uuid.data(), expectedUuid.data(), 16)); } else { EXPECT_FALSE(0 == std::memcmp(uuid.data(), expectedUuid.data(), 16)); @@ -198,7 +198,7 @@ HWTEST2_F(DeviceUuidEnablementTest, GivenEnableChipsetUniqueUUIDIsEnabledWhenDev const auto deviceFactory = createDevices(pciBusInfo, 2); EXPECT_EQ(true, deviceFactory->rootDevices[0]->getUuid(uuid)); - if (HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).isChipsetUniqueUUIDSupported()) { + if (GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).isChipsetUniqueUUIDSupported()) { EXPECT_TRUE(0 == std::memcmp(uuid.data(), expectedUuid.data(), 16)); } else { EXPECT_FALSE(0 == std::memcmp(uuid.data(), expectedUuid.data(), 16)); diff --git a/shared/test/unit_test/os_interface/linux/drm_cache_info_tests.cpp b/shared/test/unit_test/os_interface/linux/drm_cache_info_tests.cpp index 762147973d..f8ad16abfe 100644 --- a/shared/test/unit_test/os_interface/linux/drm_cache_info_tests.cpp +++ b/shared/test/unit_test/os_interface/linux/drm_cache_info_tests.cpp @@ -21,14 +21,14 @@ TEST(DrmCacheInfoTest, givenCacheRegionsExistsWhenCallingSetUpCacheInfoThenCache auto executionEnvironment = std::make_unique(); DrmQueryMock drm(*executionEnvironment->rootDeviceEnvironments[0]); - auto &hwHelper = HwHelper::get(drm.context.hwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(drm.context.hwInfo->platform.eRenderCoreFamily); drm.setupCacheInfo(*defaultHwInfo.get()); auto cacheInfo = drm.getCacheInfo(); EXPECT_NE(nullptr, cacheInfo); - if (hwHelper.getNumCacheRegions() == 0) { + if (gfxCoreHelper.getNumCacheRegions() == 0) { EXPECT_EQ(0u, cacheInfo->getMaxReservationCacheSize()); EXPECT_EQ(0u, cacheInfo->getMaxReservationNumCacheRegions()); EXPECT_EQ(0u, cacheInfo->getMaxReservationNumWays()); @@ -40,7 +40,7 @@ TEST(DrmCacheInfoTest, givenCacheRegionsExistsWhenCallingSetUpCacheInfoThenCache constexpr uint16_t maxReservationNumWays = std::min(globalReservationLimit, clientReservationLimit); const size_t totalCacheSize = gtSysInfo->L3CacheSizeInKb * MemoryConstants::kiloByte; const size_t maxReservationCacheSize = (totalCacheSize * maxReservationNumWays) / maxNumWays; - const size_t maxReservationNumCacheRegions = hwHelper.getNumCacheRegions() - 1; + const size_t maxReservationNumCacheRegions = gfxCoreHelper.getNumCacheRegions() - 1; EXPECT_EQ(maxReservationCacheSize, cacheInfo->getMaxReservationCacheSize()); EXPECT_EQ(maxReservationNumCacheRegions, cacheInfo->getMaxReservationNumCacheRegions()); diff --git a/shared/test/unit_test/os_interface/linux/drm_command_stream_tests_1.cpp b/shared/test/unit_test/os_interface/linux/drm_command_stream_tests_1.cpp index 15fb9c2926..096074dd05 100644 --- a/shared/test/unit_test/os_interface/linux/drm_command_stream_tests_1.cpp +++ b/shared/test/unit_test/os_interface/linux/drm_command_stream_tests_1.cpp @@ -175,7 +175,7 @@ HWTEST_TEMPLATED_F(DrmCommandStreamTest, givenDrmContextIdWhenFlushingThenSetIdT mock->storedDrmContextId = expectedDrmContextId; osContext = std::make_unique(*mock, csr->getRootDeviceIndex(), 1, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); osContext->ensureContextInitialized(); csr->setupContext(*osContext); diff --git a/shared/test/unit_test/os_interface/linux/drm_command_stream_xehp_and_later_prelim_tests.cpp b/shared/test/unit_test/os_interface/linux/drm_command_stream_xehp_and_later_prelim_tests.cpp index 71bdc0a86d..b8ec6b731a 100644 --- a/shared/test/unit_test/os_interface/linux/drm_command_stream_xehp_and_later_prelim_tests.cpp +++ b/shared/test/unit_test/os_interface/linux/drm_command_stream_xehp_and_later_prelim_tests.cpp @@ -294,9 +294,9 @@ class DrmCommandStreamForceTileTest : public ::testing::Test { executionEnvironment.rootDeviceEnvironments[0]->memoryOperationsInterface = DrmMemoryOperationsHandler::create(*mock, 0u); executionEnvironment.rootDeviceEnvironments[0]->initGmm(); - mock->createVirtualMemoryAddressSpace(HwHelper::getSubDevicesCount(hwInfo)); + mock->createVirtualMemoryAddressSpace(GfxCoreHelper::getSubDevicesCount(hwInfo)); osContext = std::make_unique(*mock, rootDeviceIndex, 0, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*hwInfo), DeviceBitfield(3))); osContext->ensureContextInitialized(); @@ -398,7 +398,7 @@ struct DrmImplicitScalingCommandStreamTest : ::testing::Test { constexpr int mockFd = 33; drm = new DrmMock(mockFd, *executionEnvironment->rootDeviceEnvironments[0]); drm->setupIoctlHelper(hwInfo->platform.eProductFamily); - drm->createVirtualMemoryAddressSpace(HwHelper::getSubDevicesCount(hwInfo.get())); + drm->createVirtualMemoryAddressSpace(GfxCoreHelper::getSubDevicesCount(hwInfo.get())); executionEnvironment->rootDeviceEnvironments[0]->setHwInfo(hwInfo.get()); executionEnvironment->rootDeviceEnvironments[0]->osInterface = std::make_unique(); executionEnvironment->rootDeviceEnvironments[0]->osInterface->setDriverModel(std::unique_ptr(drm)); @@ -406,7 +406,7 @@ struct DrmImplicitScalingCommandStreamTest : ::testing::Test { executionEnvironment->rootDeviceEnvironments[0]->initGmm(); osContext = std::make_unique(*drm, 0, 0u, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo), DeviceBitfield(0b11))); osContext->ensureContextInitialized(); @@ -503,7 +503,7 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, DrmImplicitScalingCommandStreamTest, whenForceExecu }; auto osContext = std::make_unique(*drm, 0, 0u, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo))); osContext->ensureContextInitialized(); auto csr = std::make_unique(*executionEnvironment, 0, osContext->getDeviceBitfield(), diff --git a/shared/test/unit_test/os_interface/linux/drm_memory_info_prelim_tests.cpp b/shared/test/unit_test/os_interface/linux/drm_memory_info_prelim_tests.cpp index f5391eb01b..8a7d1c9e28 100644 --- a/shared/test/unit_test/os_interface/linux/drm_memory_info_prelim_tests.cpp +++ b/shared/test/unit_test/os_interface/linux/drm_memory_info_prelim_tests.cpp @@ -308,7 +308,7 @@ TEST_F(MultiTileMemoryInfoPrelimTest, givenMemoryInfoWithRegionsWhenGettingMemor DebugManager.flags.OverrideDrmRegion.set(-1); DebugManager.flags.ForceMemoryBankIndexOverride.set(1); - auto &helper = HwHelper::get(pHwInfo->platform.eRenderCoreFamily); + auto &helper = GfxCoreHelper::get(pHwInfo->platform.eRenderCoreFamily); regionClassAndInstance = memoryInfo->getMemoryRegionClassAndInstance(MemoryBanks::getBankForLocalMemory(1), *pHwInfo); if (helper.isBankOverrideRequired(*pHwInfo)) { EXPECT_EQ(regionInfo[1].region.memoryInstance, regionClassAndInstance.memoryInstance); diff --git a/shared/test/unit_test/os_interface/linux/drm_memory_info_tests.cpp b/shared/test/unit_test/os_interface/linux/drm_memory_info_tests.cpp index a732f9ca06..08aac2c1ad 100644 --- a/shared/test/unit_test/os_interface/linux/drm_memory_info_tests.cpp +++ b/shared/test/unit_test/os_interface/linux/drm_memory_info_tests.cpp @@ -203,7 +203,7 @@ TEST(MemoryInfo, givenMemoryInfoWithRegionsWhenGettingMemoryRegionClassAndInstan DebugManager.flags.OverrideDrmRegion.set(-1); DebugManager.flags.ForceMemoryBankIndexOverride.set(1); - auto &helper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + auto &helper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); regionClassAndInstance = memoryInfo->getMemoryRegionClassAndInstance(MemoryBanks::getBankForLocalMemory(1), *defaultHwInfo); if (helper.isBankOverrideRequired(*defaultHwInfo)) { EXPECT_EQ(regionInfo[1].region.memoryClass, regionClassAndInstance.memoryClass); diff --git a/shared/test/unit_test/os_interface/linux/drm_memory_manager_tests.cpp b/shared/test/unit_test/os_interface/linux/drm_memory_manager_tests.cpp index b5c1969e77..ef3b07ca81 100644 --- a/shared/test/unit_test/os_interface/linux/drm_memory_manager_tests.cpp +++ b/shared/test/unit_test/os_interface/linux/drm_memory_manager_tests.cpp @@ -3785,7 +3785,7 @@ TEST_F(DrmAllocationTests, givenDrmAllocationWhenCacheRegionIsSetSuccessfullyThe MockDrmAllocation allocation(AllocationType::BUFFER, MemoryPool::LocalMemory); - if ((HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getNumCacheRegions() == 0) && + if ((GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getNumCacheRegions() == 0) && HwInfoConfig::get(defaultHwInfo->platform.eProductFamily)->isVmBindPatIndexProgrammingSupported()) { EXPECT_ANY_THROW(allocation.setCacheAdvice(&drm, 1024, CacheRegion::Region1)); } else { @@ -3802,7 +3802,7 @@ TEST_F(DrmAllocationTests, givenDrmAllocationWhenCacheRegionIsSetSuccessfullyThe MockDrmAllocation allocation(AllocationType::BUFFER, MemoryPool::LocalMemory); allocation.bufferObjects[0] = &bo; - if ((HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getNumCacheRegions() == 0) && + if ((GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getNumCacheRegions() == 0) && HwInfoConfig::get(defaultHwInfo->platform.eProductFamily)->isVmBindPatIndexProgrammingSupported()) { EXPECT_ANY_THROW(allocation.setCacheAdvice(&drm, 1024, CacheRegion::Region1)); } else { @@ -3883,7 +3883,7 @@ TEST_F(DrmAllocationTests, givenBoWhenMarkingForCaptureThenBosAreMarked) { } TEST_F(DrmMemoryManagerTest, givenDrmAllocationWithHostPtrWhenItIsCreatedWithCacheRegionThenSetRegionInBufferObject) { - if (HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getNumCacheRegions() == 0) { + if (GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getNumCacheRegions() == 0) { GTEST_SKIP(); } mock->ioctl_expected.total = -1; diff --git a/shared/test/unit_test/os_interface/linux/drm_residency_handler_prelim_tests.cpp b/shared/test/unit_test/os_interface/linux/drm_residency_handler_prelim_tests.cpp index a61b5c0649..5b2a417ddc 100644 --- a/shared/test/unit_test/os_interface/linux/drm_residency_handler_prelim_tests.cpp +++ b/shared/test/unit_test/os_interface/linux/drm_residency_handler_prelim_tests.cpp @@ -876,10 +876,10 @@ HWTEST_F(DrmMemoryOperationsHandlerBindTest, givenPatIndexProgrammingEnabledWhen auto osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor()); csr->setupContext(*osContext); - auto &hwHelper = HwHelper::get(executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo()->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo()->platform.eRenderCoreFamily); auto hwInfoConfig = HwInfoConfig::get(executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo()->platform.eProductFamily); - bool closSupported = (hwHelper.getNumCacheRegions() > 0); + bool closSupported = (gfxCoreHelper.getNumCacheRegions() > 0); bool patIndexProgrammingSupported = hwInfoConfig->isVmBindPatIndexProgrammingSupported(); uint64_t gpuAddress = 0x123000; @@ -935,9 +935,9 @@ HWTEST_F(DrmMemoryOperationsHandlerBindTest, givenPatIndexErrorAndUncachedDebugF auto csr = std::make_unique>(*executionEnvironment, 0, DeviceBitfield(1)); auto osContext = memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor()); csr->setupContext(*osContext); - auto &hwHelper = HwHelper::get(executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo()->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo()->platform.eRenderCoreFamily); auto hwInfoConfig = HwInfoConfig::get(executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo()->platform.eProductFamily); - bool closSupported = (hwHelper.getNumCacheRegions() > 0); + bool closSupported = (gfxCoreHelper.getNumCacheRegions() > 0); bool patIndexProgrammingSupported = hwInfoConfig->isVmBindPatIndexProgrammingSupported(); if (!closSupported || !patIndexProgrammingSupported) { GTEST_SKIP(); @@ -996,9 +996,9 @@ HWTEST_F(DrmMemoryOperationsHandlerBindTest, givenDebugFlagSetWhenVmBindCalledTh auto timestampStorageAlloc = csr->getTimestampPacketAllocator()->getTag()->getBaseGraphicsAllocation()->getDefaultGraphicsAllocation(); - auto &hwHelper = HwHelper::get(executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo()->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo()->platform.eRenderCoreFamily); - if (hwHelper.getNumCacheRegions() == 0) { + if (gfxCoreHelper.getNumCacheRegions() == 0) { GTEST_SKIP(); } @@ -1022,9 +1022,9 @@ TEST_F(DrmMemoryOperationsHandlerBindTest, givenClosEnabledAndAllocationToBeCach mock->cacheInfo.reset(new CacheInfo(*mock, 64 * MemoryConstants::kiloByte, 2, 32)); - auto &hwHelper = HwHelper::get(executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo()->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo()->platform.eRenderCoreFamily); - if (hwHelper.getNumCacheRegions() == 0) { + if (gfxCoreHelper.getNumCacheRegions() == 0) { GTEST_SKIP(); } @@ -1036,7 +1036,7 @@ TEST_F(DrmMemoryOperationsHandlerBindTest, givenClosEnabledAndAllocationToBeCach mock->context.receivedVmBindPatIndex.reset(); operationHandler->makeResident(device, ArrayRef(&allocation, 1)); - auto patIndex = hwHelper.getPatIndex(cacheRegion, CachePolicy::WriteBack); + auto patIndex = gfxCoreHelper.getPatIndex(cacheRegion, CachePolicy::WriteBack); EXPECT_EQ(patIndex, mock->context.receivedVmBindPatIndex.value()); @@ -1050,26 +1050,26 @@ TEST_F(DrmMemoryOperationsHandlerBindTest, givenClosEnabledAndAllocationToBeCach } TEST(DrmResidencyHandlerTests, givenClosIndexAndMemoryTypeWhenAskingForPatIndexThenReturnCorrectValue) { - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - if (hwHelper.getNumCacheRegions() == 0) { - EXPECT_ANY_THROW(hwHelper.getPatIndex(CacheRegion::Default, CachePolicy::Uncached)); - EXPECT_ANY_THROW(hwHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteBack)); + if (gfxCoreHelper.getNumCacheRegions() == 0) { + EXPECT_ANY_THROW(gfxCoreHelper.getPatIndex(CacheRegion::Default, CachePolicy::Uncached)); + EXPECT_ANY_THROW(gfxCoreHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteBack)); } else { - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Default, CachePolicy::Uncached)); - EXPECT_EQ(1u, hwHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteCombined)); - EXPECT_EQ(2u, hwHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteThrough)); - EXPECT_EQ(3u, hwHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteBack)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Default, CachePolicy::Uncached)); + EXPECT_EQ(1u, gfxCoreHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteCombined)); + EXPECT_EQ(2u, gfxCoreHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteThrough)); + EXPECT_EQ(3u, gfxCoreHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteBack)); - EXPECT_ANY_THROW(hwHelper.getPatIndex(CacheRegion::Region1, CachePolicy::Uncached)); - EXPECT_ANY_THROW(hwHelper.getPatIndex(CacheRegion::Region1, CachePolicy::WriteCombined)); - EXPECT_EQ(4u, hwHelper.getPatIndex(CacheRegion::Region1, CachePolicy::WriteThrough)); - EXPECT_EQ(5u, hwHelper.getPatIndex(CacheRegion::Region1, CachePolicy::WriteBack)); + EXPECT_ANY_THROW(gfxCoreHelper.getPatIndex(CacheRegion::Region1, CachePolicy::Uncached)); + EXPECT_ANY_THROW(gfxCoreHelper.getPatIndex(CacheRegion::Region1, CachePolicy::WriteCombined)); + EXPECT_EQ(4u, gfxCoreHelper.getPatIndex(CacheRegion::Region1, CachePolicy::WriteThrough)); + EXPECT_EQ(5u, gfxCoreHelper.getPatIndex(CacheRegion::Region1, CachePolicy::WriteBack)); - EXPECT_ANY_THROW(hwHelper.getPatIndex(CacheRegion::Region2, CachePolicy::Uncached)); - EXPECT_ANY_THROW(hwHelper.getPatIndex(CacheRegion::Region2, CachePolicy::WriteCombined)); - EXPECT_EQ(6u, hwHelper.getPatIndex(CacheRegion::Region2, CachePolicy::WriteThrough)); - EXPECT_EQ(7u, hwHelper.getPatIndex(CacheRegion::Region2, CachePolicy::WriteBack)); + EXPECT_ANY_THROW(gfxCoreHelper.getPatIndex(CacheRegion::Region2, CachePolicy::Uncached)); + EXPECT_ANY_THROW(gfxCoreHelper.getPatIndex(CacheRegion::Region2, CachePolicy::WriteCombined)); + EXPECT_EQ(6u, gfxCoreHelper.getPatIndex(CacheRegion::Region2, CachePolicy::WriteThrough)); + EXPECT_EQ(7u, gfxCoreHelper.getPatIndex(CacheRegion::Region2, CachePolicy::WriteBack)); } } @@ -1077,26 +1077,26 @@ TEST(DrmResidencyHandlerTests, givenForceAllResourcesUnchashedSetAskingForPatInd DebugManagerStateRestore restorer; DebugManager.flags.ForceAllResourcesUncached.set(1); - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - if (hwHelper.getNumCacheRegions() == 0) { - EXPECT_ANY_THROW(hwHelper.getPatIndex(CacheRegion::Default, CachePolicy::Uncached)); - EXPECT_ANY_THROW(hwHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteBack)); + if (gfxCoreHelper.getNumCacheRegions() == 0) { + EXPECT_ANY_THROW(gfxCoreHelper.getPatIndex(CacheRegion::Default, CachePolicy::Uncached)); + EXPECT_ANY_THROW(gfxCoreHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteBack)); } else { - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Default, CachePolicy::Uncached)); - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteCombined)); - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteThrough)); - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteBack)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Default, CachePolicy::Uncached)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteCombined)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteThrough)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Default, CachePolicy::WriteBack)); - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Region1, CachePolicy::Uncached)); - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Region1, CachePolicy::WriteCombined)); - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Region1, CachePolicy::WriteThrough)); - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Region1, CachePolicy::WriteBack)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Region1, CachePolicy::Uncached)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Region1, CachePolicy::WriteCombined)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Region1, CachePolicy::WriteThrough)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Region1, CachePolicy::WriteBack)); - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Region2, CachePolicy::Uncached)); - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Region2, CachePolicy::WriteCombined)); - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Region2, CachePolicy::WriteThrough)); - EXPECT_EQ(0u, hwHelper.getPatIndex(CacheRegion::Region2, CachePolicy::WriteBack)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Region2, CachePolicy::Uncached)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Region2, CachePolicy::WriteCombined)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Region2, CachePolicy::WriteThrough)); + EXPECT_EQ(0u, gfxCoreHelper.getPatIndex(CacheRegion::Region2, CachePolicy::WriteBack)); } } diff --git a/shared/test/unit_test/os_interface/linux/hw_info_config_linux_tests.cpp b/shared/test/unit_test/os_interface/linux/hw_info_config_linux_tests.cpp index ac16c9b045..98f9de49f6 100644 --- a/shared/test/unit_test/os_interface/linux/hw_info_config_linux_tests.cpp +++ b/shared/test/unit_test/os_interface/linux/hw_info_config_linux_tests.cpp @@ -302,7 +302,7 @@ TEST_F(ProductHelperTestLinux, givenPointerToHwInfoWhenConfigureHwInfoCalledThen int ret = productHelper.configureHwInfoDrm(&pInHwInfo, &outHwInfo, *executionEnvironment->rootDeviceEnvironments[0].get()); EXPECT_EQ(0, ret); auto expectedSize = static_cast(outHwInfo.gtSystemInfo.CsrSizeInMb * MemoryConstants::megaByte); - HwHelper::get(outHwInfo.platform.eRenderCoreFamily).adjustPreemptionSurfaceSize(expectedSize); + GfxCoreHelper::get(outHwInfo.platform.eRenderCoreFamily).adjustPreemptionSurfaceSize(expectedSize); EXPECT_EQ(expectedSize, outHwInfo.capabilityTable.requiredPreemptionSurfaceSize); } diff --git a/shared/test/unit_test/os_interface/windows/device_command_stream_tests.cpp b/shared/test/unit_test/os_interface/windows/device_command_stream_tests.cpp index 49ccce3cc5..1cfed6ec2e 100644 --- a/shared/test/unit_test/os_interface/windows/device_command_stream_tests.cpp +++ b/shared/test/unit_test/os_interface/windows/device_command_stream_tests.cpp @@ -341,7 +341,7 @@ TEST_F(WddmPreemptionHeaderTests, givenWddmCommandStreamReceiverWhenPreemptionIs executionEnvironment->memoryManager.reset(new MemoryManagerCreate(false, false, *executionEnvironment)); csr->overrideDispatchPolicy(DispatchMode::ImmediateDispatch); OsContextWin osContext(*wddm, csr->getRootDeviceIndex(), 0u, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*hwInfo))); csr->setupContext(osContext); @@ -366,7 +366,7 @@ TEST_F(WddmPreemptionHeaderTests, givenWddmCommandStreamReceiverWhenPreemptionIs executionEnvironment->memoryManager.reset(new MemoryManagerCreate(false, false, *executionEnvironment)); csr->overrideDispatchPolicy(DispatchMode::ImmediateDispatch); OsContextWin osContext(*wddm, csr->getRootDeviceIndex(), 0u, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0], PreemptionHelper::getDefaultPreemptionMode(*hwInfo))); csr->setupContext(osContext); diff --git a/shared/test/unit_test/os_interface/windows/hw_info_config_win_tests.cpp b/shared/test/unit_test/os_interface/windows/hw_info_config_win_tests.cpp index 7d6963e49f..2ae09baf7c 100644 --- a/shared/test/unit_test/os_interface/windows/hw_info_config_win_tests.cpp +++ b/shared/test/unit_test/os_interface/windows/hw_info_config_win_tests.cpp @@ -46,7 +46,7 @@ HelperType &HwInfoConfigTestWindows::getHelper() const { } template ProductHelper &HwInfoConfigTestWindows::getHelper() const; -template CoreHelper &HwInfoConfigTestWindows::getHelper() const; +template GfxCoreHelper &HwInfoConfigTestWindows::getHelper() const; using ProductHelperTestWindows = HwInfoConfigTestWindows; diff --git a/shared/test/unit_test/os_interface/windows/os_context_win_tests.cpp b/shared/test/unit_test/os_interface/windows/os_context_win_tests.cpp index 5dccfc1801..b62559b825 100644 --- a/shared/test/unit_test/os_interface/windows/os_context_win_tests.cpp +++ b/shared/test/unit_test/os_interface/windows/os_context_win_tests.cpp @@ -16,7 +16,7 @@ struct OsContextWinTest : public WddmTestWithMockGdiDll { void SetUp() override { WddmTestWithMockGdiDll::SetUp(); preemptionMode = PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo); - engineTypeUsage = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0]; + engineTypeUsage = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0]; init(); } @@ -72,7 +72,7 @@ struct OsContextWinTestNoCleanup : public WddmTestWithMockGdiDllNoCleanup { void SetUp() override { WddmTestWithMockGdiDllNoCleanup::SetUp(); preemptionMode = PreemptionHelper::getDefaultPreemptionMode(*defaultHwInfo); - engineTypeUsage = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0]; + engineTypeUsage = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0]; init(); } diff --git a/shared/test/unit_test/os_interface/windows/os_interface_win_tests.cpp b/shared/test/unit_test/os_interface/windows/os_interface_win_tests.cpp index 3242e292b4..06b03f590b 100644 --- a/shared/test/unit_test/os_interface/windows/os_interface_win_tests.cpp +++ b/shared/test/unit_test/os_interface/windows/os_interface_win_tests.cpp @@ -33,7 +33,7 @@ TEST(OsContextTest, givenWddmWhenCreateOsContextAfterInitWddmThenOsContextIsInit wddm->init(); EXPECT_EQ(0u, wddm->registerTrimCallbackResult.called); auto osContext = std::make_unique(*wddm, 0, 0u, - EngineDescriptorHelper::getDefaultDescriptor(HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], preemptionMode)); + EngineDescriptorHelper::getDefaultDescriptor(GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo)[0], preemptionMode)); osContext->ensureContextInitialized(); EXPECT_EQ(osContext->getWddm(), wddm); EXPECT_EQ(1u, wddm->registerTrimCallbackResult.called); diff --git a/shared/test/unit_test/os_interface/windows/wddm_preemption_tests.cpp b/shared/test/unit_test/os_interface/windows/wddm_preemption_tests.cpp index d34a06d17d..f3709a9924 100644 --- a/shared/test/unit_test/os_interface/windows/wddm_preemption_tests.cpp +++ b/shared/test/unit_test/os_interface/windows/wddm_preemption_tests.cpp @@ -41,7 +41,7 @@ class WddmPreemptionTests : public Test { wddm->init(); hwInfo = executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo(); ASSERT_NE(nullptr, hwInfo); - auto engine = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; + auto engine = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; osContext = std::make_unique(*wddm, 0, 0u, EngineDescriptorHelper::getDefaultDescriptor(engine, preemptionMode)); osContext->ensureContextInitialized(); } diff --git a/shared/test/unit_test/os_interface/windows/wddm_shared_allocations_test.cpp b/shared/test/unit_test/os_interface/windows/wddm_shared_allocations_test.cpp index 38f2471d48..76cf3ce6d6 100644 --- a/shared/test/unit_test/os_interface/windows/wddm_shared_allocations_test.cpp +++ b/shared/test/unit_test/os_interface/windows/wddm_shared_allocations_test.cpp @@ -43,7 +43,7 @@ class WddmSharedTestsFixture : public MockExecutionEnvironmentGmmFixture { wddm->wddmInterface.reset(wddmMockInterface); auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - auto engine = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; + auto engine = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; osContext = std::make_unique(*osInterface->getDriverModel()->as(), 0, 0u, EngineDescriptorHelper::getDefaultDescriptor(engine, preemptionMode)); osContext->ensureContextInitialized(); } diff --git a/shared/test/unit_test/os_interface/windows/wddm_tests.cpp b/shared/test/unit_test/os_interface/windows/wddm_tests.cpp index ea5a0ee908..30a90e4931 100644 --- a/shared/test/unit_test/os_interface/windows/wddm_tests.cpp +++ b/shared/test/unit_test/os_interface/windows/wddm_tests.cpp @@ -409,7 +409,7 @@ struct WddmSkipResourceCleanupFixtureWithMockGdiDll : public GdiDllFixture, publ wddm->wddmInterface.reset(wddmMockInterface); auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - auto engine = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; + auto engine = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; osContext = std::make_unique(*osInterface->getDriverModel()->as(), 0, 0u, EngineDescriptorHelper::getDefaultDescriptor(engine, preemptionMode)); osContext->ensureContextInitialized(); } diff --git a/shared/test/unit_test/preamble/preamble_tests.cpp b/shared/test/unit_test/preamble/preamble_tests.cpp index 8c6bab8278..7ac718ac6b 100644 --- a/shared/test/unit_test/preamble/preamble_tests.cpp +++ b/shared/test/unit_test/preamble/preamble_tests.cpp @@ -186,7 +186,7 @@ HWTEST_F(PreambleTest, givenKernelDebuggingActiveAndMidThreadPreemptionWhenGetAd HWTEST_F(PreambleTest, givenDefaultPreambleWhenGetThreadsMaxNumberIsCalledThenMaximumNumberOfThreadsIsReturned) { const HardwareInfo &hwInfo = *defaultHwInfo; uint32_t threadsPerEU = (hwInfo.gtSystemInfo.ThreadCount / hwInfo.gtSystemInfo.EUCount) + hwInfo.capabilityTable.extraQuantityThreadsPerEU; - uint32_t value = HwHelper::getMaxThreadsForVfe(hwInfo); + uint32_t value = GfxCoreHelper::getMaxThreadsForVfe(hwInfo); uint32_t expected = hwInfo.gtSystemInfo.EUCount * threadsPerEU; EXPECT_EQ(expected, value); @@ -197,7 +197,7 @@ HWTEST_F(PreambleTest, givenMaxHwThreadsPercentDebugVariableWhenGetThreadsMaxNum uint32_t threadsPerEU = (hwInfo.gtSystemInfo.ThreadCount / hwInfo.gtSystemInfo.EUCount) + hwInfo.capabilityTable.extraQuantityThreadsPerEU; DebugManagerStateRestore debugManagerStateRestore; DebugManager.flags.MaxHwThreadsPercent.set(80); - uint32_t value = HwHelper::getMaxThreadsForVfe(hwInfo); + uint32_t value = GfxCoreHelper::getMaxThreadsForVfe(hwInfo); uint32_t expected = int(hwInfo.gtSystemInfo.EUCount * threadsPerEU * 80 / 100.0f); EXPECT_EQ(expected, value); @@ -208,7 +208,7 @@ HWTEST_F(PreambleTest, givenMinHwThreadsUnoccupiedDebugVariableWhenGetThreadsMax uint32_t threadsPerEU = (hwInfo.gtSystemInfo.ThreadCount / hwInfo.gtSystemInfo.EUCount) + hwInfo.capabilityTable.extraQuantityThreadsPerEU; DebugManagerStateRestore debugManagerStateRestore; DebugManager.flags.MinHwThreadsUnoccupied.set(2); - uint32_t value = HwHelper::getMaxThreadsForVfe(hwInfo); + uint32_t value = GfxCoreHelper::getMaxThreadsForVfe(hwInfo); uint32_t expected = hwInfo.gtSystemInfo.EUCount * threadsPerEU - 2; EXPECT_EQ(expected, value); diff --git a/shared/test/unit_test/preemption/preemption_tests.cpp b/shared/test/unit_test/preemption/preemption_tests.cpp index ee30497ed9..d1e1071ef2 100644 --- a/shared/test/unit_test/preemption/preemption_tests.cpp +++ b/shared/test/unit_test/preemption/preemption_tests.cpp @@ -453,7 +453,7 @@ HWTEST_F(MidThreadPreemptionTests, givenMidThreadPreemptionWhenFailingOnCsrSurfa GraphicsAllocation *allocateGraphicsMemoryWithAlignment(const AllocationData &allocationData) override { auto hwInfo = executionEnvironment.rootDeviceEnvironments[allocationData.rootDeviceIndex]->getHardwareInfo(); - if (++allocateGraphicsMemoryCount > HwHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo).size() - 1) { + if (++allocateGraphicsMemoryCount > GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo).size() - 1) { return nullptr; } return OsAgnosticMemoryManager::allocateGraphicsMemoryWithAlignment(allocationData); diff --git a/shared/test/unit_test/xe_hp_core/excludes_xe_hp_core.cpp b/shared/test/unit_test/xe_hp_core/excludes_xe_hp_core.cpp index 91f7a76949..f4bc3738f2 100644 --- a/shared/test/unit_test/xe_hp_core/excludes_xe_hp_core.cpp +++ b/shared/test/unit_test/xe_hp_core/excludes_xe_hp_core.cpp @@ -15,5 +15,5 @@ HWTEST_EXCLUDE_PRODUCT(HwInfoConfigTest, givenHwInfoConfigWhenAskedIfTile64With3 HWTEST_EXCLUDE_PRODUCT(HwInfoConfigTest, givenHwInfoConfigWhenAskedIfBlitterForImagesIsSupportedThenFalseIsReturned, IGFX_XE_HP_CORE); HWTEST_EXCLUDE_PRODUCT(HwInfoConfigTest, givenHwInfoConfigWhenAskedIfPipeControlPriorToNonPipelinedStateCommandsWARequiredThenFalseIsReturned, IGFX_XE_HP_CORE); HWTEST_EXCLUDE_PRODUCT(HwInfoConfigTest, givenHwInfoConfigWhenIsSystolicModeConfigurabledThenFalseIsReturned, IGFX_XE_HP_CORE); -HWTEST_EXCLUDE_PRODUCT(HwHelperTest, whenGettingDefaultRevisionIdThenCorrectValueIsReturned, IGFX_XE_HP_CORE); -HWTEST_EXCLUDE_PRODUCT(HwHelperTest, WhenIsBankOverrideRequiredIsCalledThenFalseIsReturned, IGFX_XE_HP_SDV); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTest, whenGettingDefaultRevisionIdThenCorrectValueIsReturned, IGFX_XE_HP_CORE); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTest, WhenIsBankOverrideRequiredIsCalledThenFalseIsReturned, IGFX_XE_HP_SDV); diff --git a/shared/test/unit_test/xe_hp_core/hw_helper_xe_hp_core_tests.cpp b/shared/test/unit_test/xe_hp_core/hw_helper_xe_hp_core_tests.cpp index ef7483bc2c..0ccc7c09b2 100644 --- a/shared/test/unit_test/xe_hp_core/hw_helper_xe_hp_core_tests.cpp +++ b/shared/test/unit_test/xe_hp_core/hw_helper_xe_hp_core_tests.cpp @@ -11,14 +11,14 @@ #include "shared/test/common/test_macros/hw_test.h" using namespace NEO; -using HwHelperXeHpCoreTest = ::testing::Test; +using GfxCoreHelperXeHpCoreTest = ::testing::Test; -XE_HP_CORE_TEST_F(HwHelperXeHpCoreTest, givenSteppingAorBWhenCheckingSipWAThenTrueIsReturned) { +XE_HP_CORE_TEST_F(GfxCoreHelperXeHpCoreTest, givenSteppingAorBWhenCheckingSipWAThenTrueIsReturned) { HardwareInfo hwInfo = *defaultHwInfo; auto renderCoreFamily = defaultHwInfo->platform.eRenderCoreFamily; auto productFamily = defaultHwInfo->platform.eProductFamily; - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); const auto &hwInfoConfig = *HwInfoConfig::get(productFamily); hwInfo.platform.usRevId = hwInfoConfig.getHwRevIdFromStepping(REVISION_A0, hwInfo); @@ -28,12 +28,12 @@ XE_HP_CORE_TEST_F(HwHelperXeHpCoreTest, givenSteppingAorBWhenCheckingSipWAThenTr EXPECT_TRUE(helper.isSipWANeeded(hwInfo)); } -XE_HP_CORE_TEST_F(HwHelperXeHpCoreTest, givenSteppingCWhenCheckingSipWAThenFalseIsReturned) { +XE_HP_CORE_TEST_F(GfxCoreHelperXeHpCoreTest, givenSteppingCWhenCheckingSipWAThenFalseIsReturned) { HardwareInfo hwInfo = *defaultHwInfo; auto renderCoreFamily = defaultHwInfo->platform.eRenderCoreFamily; auto productFamily = defaultHwInfo->platform.eProductFamily; - auto &helper = HwHelper::get(renderCoreFamily); + auto &helper = GfxCoreHelper::get(renderCoreFamily); const auto &hwInfoConfig = *HwInfoConfig::get(productFamily); hwInfo.platform.usRevId = hwInfoConfig.getHwRevIdFromStepping(REVISION_C, hwInfo); diff --git a/shared/test/unit_test/xe_hpc_core/compute_mode_tests_xe_hpc_core.cpp b/shared/test/unit_test/xe_hpc_core/compute_mode_tests_xe_hpc_core.cpp index 88d695268c..1f4b5e7592 100644 --- a/shared/test/unit_test/xe_hpc_core/compute_mode_tests_xe_hpc_core.cpp +++ b/shared/test/unit_test/xe_hpc_core/compute_mode_tests_xe_hpc_core.cpp @@ -15,7 +15,7 @@ using namespace NEO; using ThreadArbitrationXeHpc = ::testing::Test; HWTEST2_F(ThreadArbitrationXeHpc, givenXeHpcWhenCallgetDefaultThreadArbitrationPolicyThenAgeBasedisReturned, IsXeHpcCore) { - EXPECT_EQ(ThreadArbitrationPolicy::RoundRobinAfterDependency, HwHelperHw::get().getDefaultThreadArbitrationPolicy()); + EXPECT_EQ(ThreadArbitrationPolicy::RoundRobinAfterDependency, GfxCoreHelperHw::get().getDefaultThreadArbitrationPolicy()); } using XeHpcComputeModeRequirements = ComputeModeRequirements; @@ -28,8 +28,8 @@ HWTEST2_F(XeHpcComputeModeRequirements, givenNewRequiredThreadArbitrationPolicyW auto cmdsSize = sizeof(STATE_COMPUTE_MODE); char buff[1024] = {0}; LinearStream stream(buff, 1024); - auto &hwHelper = NEO::HwHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily); - auto newEuThreadSchedulingMode = hwHelper.getDefaultThreadArbitrationPolicy(); + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily); + auto newEuThreadSchedulingMode = gfxCoreHelper.getDefaultThreadArbitrationPolicy(); auto expectedEuThreadSchedulingMode = static_cast(UnitTestHelper::getAppropriateThreadArbitrationPolicy(newEuThreadSchedulingMode)); auto expectedScmCmd = FamilyType::cmdInitStateComputeMode; diff --git a/shared/test/unit_test/xe_hpc_core/excludes_xe_hpc_core.cpp b/shared/test/unit_test/xe_hpc_core/excludes_xe_hpc_core.cpp index 43735e816e..04e85990ad 100644 --- a/shared/test/unit_test/xe_hpc_core/excludes_xe_hpc_core.cpp +++ b/shared/test/unit_test/xe_hpc_core/excludes_xe_hpc_core.cpp @@ -14,11 +14,11 @@ HWTEST_EXCLUDE_PRODUCT(DrmMemoryManagerTest, givenDrmAllocationWithHostPtrWhenIt HWTEST_EXCLUDE_PRODUCT(DrmMemoryManagerTest, givenDrmAllocationWithWithAlignmentFromUserptrWhenItIsCreatedWithIncorrectCacheRegionThenReturnNull, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(WalkerPartitionTests, givenMiAtomicWhenItIsProgrammedThenAllFieldsAreSetCorrectly, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(WalkerPartitionTests, givenProgramBatchBufferStartCommandWhenItIsCalledThenCommandIsProgrammedCorrectly, IGFX_XE_HPC_CORE); -HWTEST_EXCLUDE_PRODUCT(HwHelperTest, givenDefaultHwHelperHwWhenMinimalSIMDSizeIsQueriedThen8IsReturned, IGFX_XE_HPC_CORE); -HWTEST_EXCLUDE_PRODUCT(HwHelperTest, whenQueryingMaxNumSamplersThenReturnSixteen, IGFX_XE_HPC_CORE); -HWTEST_EXCLUDE_PRODUCT(HwHelperTest, givenHwHelperWhenGettingIfRevisionSpecificBinaryBuiltinIsRequiredThenFalseIsReturned, IGFX_XE_HPC_CORE); -HWTEST_EXCLUDE_PRODUCT(HwHelperTest, whenGettingNumberOfCacheRegionsThenReturnZero, IGFX_XE_HPC_CORE); -HWTEST_EXCLUDE_PRODUCT(PipeControlHelperTests, givenHwHelperwhenAskingForDcFlushThenReturnTrue, IGFX_XE_HPC_CORE); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTest, givenDefaultGfxCoreHelperHwWhenMinimalSIMDSizeIsQueriedThen8IsReturned, IGFX_XE_HPC_CORE); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTest, whenQueryingMaxNumSamplersThenReturnSixteen, IGFX_XE_HPC_CORE); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTest, givenGfxCoreHelperWhenGettingIfRevisionSpecificBinaryBuiltinIsRequiredThenFalseIsReturned, IGFX_XE_HPC_CORE); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTest, whenGettingNumberOfCacheRegionsThenReturnZero, IGFX_XE_HPC_CORE); +HWTEST_EXCLUDE_PRODUCT(PipeControlHelperTests, givenGfxCoreHelperwhenAskingForDcFlushThenReturnTrue, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(XeHPAndLaterPreemptionTests, GivenDebuggerUsedWhenProgrammingStateSipThenStateSipIsAdded, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(ComputeModeRequirements, givenComputeModeProgrammingWhenLargeGrfModeDoesntChangeThenSCMIsNotAdded, IGFX_XE_HPC_CORE); HWTEST_EXCLUDE_PRODUCT(ComputeModeRequirements, givenCoherencyWithoutSharedHandlesWhenCommandSizeIsCalculatedThenCorrectCommandSizeIsReturned, IGFX_XE_HPC_CORE); diff --git a/shared/test/unit_test/xe_hpc_core/hw_helper_xe_hpc_core_tests.cpp b/shared/test/unit_test/xe_hpc_core/hw_helper_xe_hpc_core_tests.cpp index 6061774697..094c74f965 100644 --- a/shared/test/unit_test/xe_hpc_core/hw_helper_xe_hpc_core_tests.cpp +++ b/shared/test/unit_test/xe_hpc_core/hw_helper_xe_hpc_core_tests.cpp @@ -14,9 +14,9 @@ #include "hw_cmds_xe_hpc_core_base.h" using namespace NEO; -using HwHelperXeHpcCoreTest = ::testing::Test; +using GfxCoreHelperXeHpcCoreTest = ::testing::Test; -XE_HPC_CORETEST_F(HwHelperXeHpcCoreTest, givenSlmSizeWhenEncodingThenReturnCorrectValues) { +XE_HPC_CORETEST_F(GfxCoreHelperXeHpcCoreTest, givenSlmSizeWhenEncodingThenReturnCorrectValues) { ComputeSlmTestInput computeSlmValuesXeHpcTestsInput[] = { {0, 0 * KB}, {1, 0 * KB + 1}, @@ -43,27 +43,27 @@ XE_HPC_CORETEST_F(HwHelperXeHpcCoreTest, givenSlmSizeWhenEncodingThenReturnCorre {11, 128 * KB}}; auto hwInfo = *defaultHwInfo; - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); for (auto &testInput : computeSlmValuesXeHpcTestsInput) { - EXPECT_EQ(testInput.expected, hwHelper.computeSlmValues(hwInfo, testInput.slmSize)); + EXPECT_EQ(testInput.expected, gfxCoreHelper.computeSlmValues(hwInfo, testInput.slmSize)); } - EXPECT_THROW(hwHelper.computeSlmValues(hwInfo, 129 * KB), std::exception); + EXPECT_THROW(gfxCoreHelper.computeSlmValues(hwInfo, 129 * KB), std::exception); } -XE_HPC_CORETEST_F(HwHelperXeHpcCoreTest, WhenGettingIsCpuImageTransferPreferredThenTrueIsReturned) { - auto &hwHelper = HwHelper::get(renderCoreFamily); - EXPECT_TRUE(hwHelper.isCpuImageTransferPreferred(*defaultHwInfo)); +XE_HPC_CORETEST_F(GfxCoreHelperXeHpcCoreTest, WhenGettingIsCpuImageTransferPreferredThenTrueIsReturned) { + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); + EXPECT_TRUE(gfxCoreHelper.isCpuImageTransferPreferred(*defaultHwInfo)); } -XE_HPC_CORETEST_F(HwHelperXeHpcCoreTest, givenHwHelperWhenGettingIfRevisionSpecificBinaryBuiltinIsRequiredThenTrueIsReturned) { - auto &hwHelper = NEO::HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - EXPECT_TRUE(hwHelper.isRevisionSpecificBinaryBuiltinRequired()); +XE_HPC_CORETEST_F(GfxCoreHelperXeHpcCoreTest, givenGfxCoreHelperWhenGettingIfRevisionSpecificBinaryBuiltinIsRequiredThenTrueIsReturned) { + auto &gfxCoreHelper = NEO::GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + EXPECT_TRUE(gfxCoreHelper.isRevisionSpecificBinaryBuiltinRequired()); } -XE_HPC_CORETEST_F(HwHelperXeHpcCoreTest, givenHwHelperWhenCheckTimestampWaitSupportThenReturnTrue) { - auto &helper = HwHelper::get(renderCoreFamily); +XE_HPC_CORETEST_F(GfxCoreHelperXeHpcCoreTest, givenGfxCoreHelperWhenCheckTimestampWaitSupportThenReturnTrue) { + auto &helper = GfxCoreHelper::get(renderCoreFamily); EXPECT_TRUE(helper.isTimestampWaitSupportedForQueues()); } @@ -74,26 +74,26 @@ XE_HPC_CORETEST_F(ProductHelperTestXeHpcCore, givenProductHelperWhenCheckTimesta EXPECT_TRUE(helper.isTimestampWaitSupportedForEvents()); } -XE_HPC_CORETEST_F(HwHelperXeHpcCoreTest, givenXeHPCPlatformWhenCheckAssignEngineRoundRobinSupportedThenReturnTrue) { +XE_HPC_CORETEST_F(GfxCoreHelperXeHpcCoreTest, givenXeHPCPlatformWhenCheckAssignEngineRoundRobinSupportedThenReturnTrue) { auto hwInfo = *defaultHwInfo; - auto &hwHelper = HwHelperHw::get(); - EXPECT_EQ(hwHelper.isAssignEngineRoundRobinSupported(hwInfo), HwInfoConfig::get(hwInfo.platform.eProductFamily)->isAssignEngineRoundRobinSupported()); + auto &gfxCoreHelper = GfxCoreHelperHw::get(); + EXPECT_EQ(gfxCoreHelper.isAssignEngineRoundRobinSupported(hwInfo), HwInfoConfig::get(hwInfo.platform.eProductFamily)->isAssignEngineRoundRobinSupported()); } -XE_HPC_CORETEST_F(HwHelperTest, givenHwHelperWhenCallCopyThroughLockedPtrEnabledThenReturnTrue) { - auto &hwHelper = HwHelperHw::get(); - EXPECT_TRUE(hwHelper.copyThroughLockedPtrEnabled(*defaultHwInfo)); +XE_HPC_CORETEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenCallCopyThroughLockedPtrEnabledThenReturnTrue) { + auto &gfxCoreHelper = GfxCoreHelperHw::get(); + EXPECT_TRUE(gfxCoreHelper.copyThroughLockedPtrEnabled(*defaultHwInfo)); } -XE_HPC_CORETEST_F(HwHelperTest, givenHwHelperWhenCallGetAmountOfAllocationsToFillThenReturnTrue) { - auto &hwHelper = HwHelperHw::get(); - EXPECT_EQ(hwHelper.getAmountOfAllocationsToFill(), 1u); +XE_HPC_CORETEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenCallGetAmountOfAllocationsToFillThenReturnTrue) { + auto &gfxCoreHelper = GfxCoreHelperHw::get(); + EXPECT_EQ(gfxCoreHelper.getAmountOfAllocationsToFill(), 1u); } -HWTEST_EXCLUDE_PRODUCT(HwHelperTest, givenHwHelperWhenAskingForRelaxedOrderingSupportThenReturnFalse, IGFX_XE_HPC_CORE); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTest, givenGfxCoreHelperWhenAskingForRelaxedOrderingSupportThenReturnFalse, IGFX_XE_HPC_CORE); -XE_HPC_CORETEST_F(HwHelperTest, givenHwHelperWhenAskingForRelaxedOrderingSupportThenReturnTrue) { - auto &hwHelper = HwHelperHw::get(); +XE_HPC_CORETEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenAskingForRelaxedOrderingSupportThenReturnTrue) { + auto &gfxCoreHelper = GfxCoreHelperHw::get(); - EXPECT_TRUE(hwHelper.isRelaxedOrderingSupported()); + EXPECT_TRUE(gfxCoreHelper.isRelaxedOrderingSupported()); } \ No newline at end of file diff --git a/shared/test/unit_test/xe_hpc_core/pvc/engine_node_helper_tests_pvc.cpp b/shared/test/unit_test/xe_hpc_core/pvc/engine_node_helper_tests_pvc.cpp index d67ae15606..f52dae34d5 100644 --- a/shared/test/unit_test/xe_hpc_core/pvc/engine_node_helper_tests_pvc.cpp +++ b/shared/test/unit_test/xe_hpc_core/pvc/engine_node_helper_tests_pvc.cpp @@ -110,7 +110,7 @@ PVCTEST_F(EngineNodeHelperPvcTests, givenCccsDisabledButDebugVariableSetWhenGetG auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(9u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(9u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); @@ -136,7 +136,7 @@ PVCTEST_F(EngineNodeHelperPvcTests, givenCccsDisabledWhenGetGpgpuEnginesCalledTh auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(8u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(8u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); @@ -150,29 +150,29 @@ PVCTEST_F(EngineNodeHelperPvcTests, givenCccsDisabledWhenGetGpgpuEnginesCalledTh } PVCTEST_F(EngineNodeHelperPvcTests, givenCCSEngineWhenCallingIsCooperativeDispatchSupportedThenTrueIsReturned) { - const auto &hwHelper = HwHelper::get(renderCoreFamily); + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); auto hwInfo = *defaultHwInfo; hwInfo.capabilityTable.defaultEngineType = aub_stream::ENGINE_CCS; - auto engineGroupType = hwHelper.getEngineGroupType(pDevice->getDefaultEngine().getEngineType(), - pDevice->getDefaultEngine().getEngineUsage(), hwInfo); - auto retVal = hwHelper.isCooperativeDispatchSupported(engineGroupType, hwInfo); + auto engineGroupType = gfxCoreHelper.getEngineGroupType(pDevice->getDefaultEngine().getEngineType(), + pDevice->getDefaultEngine().getEngineUsage(), hwInfo); + auto retVal = gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, hwInfo); EXPECT_TRUE(retVal); } PVCTEST_F(EngineNodeHelperPvcTests, givenCCCSEngineAndRevisionBWhenCallingIsCooperativeDispatchSupportedThenFalseIsReturned) { const auto &productHelper = getHelper(); - const auto &hwHelper = HwHelper::get(renderCoreFamily); + const auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); auto hwInfo = *defaultHwInfo; hwInfo.capabilityTable.defaultEngineType = aub_stream::ENGINE_CCCS; - auto engineGroupType = hwHelper.getEngineGroupType(pDevice->getDefaultEngine().getEngineType(), - pDevice->getDefaultEngine().getEngineUsage(), hwInfo); - auto retVal = hwHelper.isCooperativeDispatchSupported(engineGroupType, hwInfo); + auto engineGroupType = gfxCoreHelper.getEngineGroupType(pDevice->getDefaultEngine().getEngineType(), + pDevice->getDefaultEngine().getEngineUsage(), hwInfo); + auto retVal = gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, hwInfo); EXPECT_TRUE(retVal); hwInfo.platform.usRevId = productHelper.getHwRevIdFromStepping(REVISION_B, hwInfo); - retVal = hwHelper.isCooperativeDispatchSupported(engineGroupType, hwInfo); + retVal = gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, hwInfo); EXPECT_FALSE(retVal); } @@ -188,7 +188,7 @@ PVCTEST_F(EngineNodeHelperPvcTests, givenBcsDisabledWhenGetEnginesCalledThenDont auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -227,7 +227,7 @@ PVCTEST_F(EngineNodeHelperPvcTests, givenOneBcsEnabledWhenGetEnginesCalledThenCr auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -272,7 +272,7 @@ PVCTEST_F(EngineNodeHelperPvcTests, givenNotAllCopyEnginesWhenSettingEngineTable auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -313,7 +313,7 @@ PVCTEST_F(EngineNodeHelperPvcTests, givenOneCcsEnabledWhenGetEnginesCalledThenCr auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -360,7 +360,7 @@ PVCTEST_F(EngineNodeHelperPvcTests, givenCccsAsDefaultEngineWhenGetEnginesCalled auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -410,7 +410,7 @@ PVCTEST_F(EngineNodeHelperPvcTests, whenGetGpgpuEnginesThenReturnTwoCccsEnginesA auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -460,7 +460,7 @@ PVCTEST_F(EngineNodeHelperPvcTests, whenGetGpgpuEnginesThenReturnTwoCccsEnginesA auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { diff --git a/shared/test/unit_test/xe_hpc_core/pvc/hw_helper_tests_pvc.cpp b/shared/test/unit_test/xe_hpc_core/pvc/hw_helper_tests_pvc.cpp index 81bbc76057..f606472071 100644 --- a/shared/test/unit_test/xe_hpc_core/pvc/hw_helper_tests_pvc.cpp +++ b/shared/test/unit_test/xe_hpc_core/pvc/hw_helper_tests_pvc.cpp @@ -16,9 +16,9 @@ namespace NEO { -using HwHelperTestsPvc = HwHelperTest; +using GfxCoreHelperTestsPvc = GfxCoreHelperTest; -PVCTEST_F(HwHelperTestsPvc, givenRevisionEnumAndPlatformFamilyTypeThenProperValueForIsWorkaroundRequiredIsReturned) { +PVCTEST_F(GfxCoreHelperTestsPvc, givenRevisionEnumAndPlatformFamilyTypeThenProperValueForIsWorkaroundRequiredIsReturned) { uint32_t steppings[] = { REVISION_A0, REVISION_B, @@ -27,44 +27,44 @@ PVCTEST_F(HwHelperTestsPvc, givenRevisionEnumAndPlatformFamilyTypeThenProperValu CommonConstants::invalidStepping, }; - const auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + const auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); const auto &hwInfoConfig = *HwInfoConfig::get(hardwareInfo.platform.eProductFamily); for (auto stepping : steppings) { hardwareInfo.platform.usRevId = hwInfoConfig.getHwRevIdFromStepping(stepping, hardwareInfo); if (stepping == REVISION_A0) { - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); } else if (stepping == REVISION_B) { - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); } else { - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); } - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_C, REVISION_A0, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_C, REVISION_B, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_C, REVISION_A0, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_C, REVISION_B, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_D, REVISION_A0, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A1, REVISION_A0, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_D, REVISION_A0, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A1, REVISION_A0, hardwareInfo)); } } -PVCTEST_F(HwHelperTestsPvc, givenDefaultMemorySynchronizationCommandsWhenGettingSizeForAdditionalSynchronizationThenCorrectValueIsReturned) { +PVCTEST_F(GfxCoreHelperTestsPvc, givenDefaultMemorySynchronizationCommandsWhenGettingSizeForAdditionalSynchronizationThenCorrectValueIsReturned) { using MI_SEMAPHORE_WAIT = typename XeHpcCoreFamily::MI_SEMAPHORE_WAIT; EXPECT_EQ(sizeof(MI_SEMAPHORE_WAIT), MemorySynchronizationCommands::getSizeForAdditonalSynchronization(*defaultHwInfo)); } -PVCTEST_F(HwHelperTestsPvc, givenDebugMemorySynchronizationCommandsWhenGettingSizeForAdditionalSynchronizationThenCorrectValueIsReturned) { +PVCTEST_F(GfxCoreHelperTestsPvc, givenDebugMemorySynchronizationCommandsWhenGettingSizeForAdditionalSynchronizationThenCorrectValueIsReturned) { DebugManagerStateRestore restorer; DebugManager.flags.DisablePipeControlPrecedingPostSyncCommand.set(1); using MI_SEMAPHORE_WAIT = typename XeHpcCoreFamily::MI_SEMAPHORE_WAIT; @@ -72,8 +72,8 @@ PVCTEST_F(HwHelperTestsPvc, givenDebugMemorySynchronizationCommandsWhenGettingSi EXPECT_EQ(2 * sizeof(MI_SEMAPHORE_WAIT), MemorySynchronizationCommands::getSizeForAdditonalSynchronization(*defaultHwInfo)); } -PVCTEST_F(HwHelperTestsPvc, givenRevisionIdWhenGetComputeUnitsUsedForScratchThenReturnValidValue) { - auto &coreHelper = pDevice->getRootDeviceEnvironment().getHelper(); +PVCTEST_F(GfxCoreHelperTestsPvc, givenRevisionIdWhenGetComputeUnitsUsedForScratchThenReturnValidValue) { + auto &gfxCoreHelper = pDevice->getRootDeviceEnvironment().getHelper(); auto &hwInfo = *pDevice->getRootDeviceEnvironment().getMutableHardwareInfo(); hwInfo.gtSystemInfo.EUCount *= 2; @@ -93,11 +93,11 @@ PVCTEST_F(HwHelperTestsPvc, givenRevisionIdWhenGetComputeUnitsUsedForScratchThen for (auto &testInput : testInputs) { hwInfo.platform.usRevId = testInput.revId; - EXPECT_EQ(expectedValue * testInput.expectedRatio, coreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment())); + EXPECT_EQ(expectedValue * testInput.expectedRatio, gfxCoreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment())); } } -PVCTEST_F(HwHelperTestsPvc, givenMemorySynchronizationCommandsWhenAddingSynchronizationThenCorrectMethodIsUsed) { +PVCTEST_F(GfxCoreHelperTestsPvc, givenMemorySynchronizationCommandsWhenAddingSynchronizationThenCorrectMethodIsUsed) { using MI_MEM_FENCE = typename FamilyType::MI_MEM_FENCE; using MI_SEMAPHORE_WAIT = typename FamilyType::MI_SEMAPHORE_WAIT; diff --git a/shared/test/unit_test/xe_hpc_core/test_device_caps_xe_hpc_core.cpp b/shared/test/unit_test/xe_hpc_core/test_device_caps_xe_hpc_core.cpp index 2307d81bae..962f261e03 100644 --- a/shared/test/unit_test/xe_hpc_core/test_device_caps_xe_hpc_core.cpp +++ b/shared/test/unit_test/xe_hpc_core/test_device_caps_xe_hpc_core.cpp @@ -38,9 +38,9 @@ XE_HPC_CORETEST_F(XeHpcCoreDeviceCaps, givenHwInfoWhenSlmSizeIsRequiredThenRetur } XE_HPC_CORETEST_F(XeHpcCoreDeviceCaps, givenDeviceWhenAskingForSubGroupSizesThenReturnCorrectValues) { - const auto &coreHelper = getHelper(); + const auto &gfxCoreHelper = getHelper(); - const auto deviceSubgroups = coreHelper.getDeviceSubGroupSizes(); + const auto deviceSubgroups = gfxCoreHelper.getDeviceSubGroupSizes(); EXPECT_EQ(2u, deviceSubgroups.size()); EXPECT_EQ(16u, deviceSubgroups[0]); diff --git a/shared/test/unit_test/xe_hpc_core/test_encode_xe_hpc_core.cpp b/shared/test/unit_test/xe_hpc_core/test_encode_xe_hpc_core.cpp index 53a8636592..9b2717fab3 100644 --- a/shared/test/unit_test/xe_hpc_core/test_encode_xe_hpc_core.cpp +++ b/shared/test/unit_test/xe_hpc_core/test_encode_xe_hpc_core.cpp @@ -541,8 +541,8 @@ XE_HPC_CORETEST_F(EncodeKernelXeHpcCoreTest, givenMultipleTilesAndImplicitScalin hwInfo.gtSystemInfo.DualSubSliceCount = hwInfo.gtSystemInfo.MaxDualSubSlicesSupported; INTERFACE_DESCRIPTOR_DATA iddArg = FamilyType::cmdInitInterfaceDescriptorData; const uint32_t numGrf = GrfConfig::DefaultGrfNumber; - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); - const uint32_t threadGroupCount = hwHelper.calculateAvailableThreadCount(hwInfo, numGrf) / 32u; + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + const uint32_t threadGroupCount = gfxCoreHelper.calculateAvailableThreadCount(hwInfo, numGrf) / 32u; iddArg.setNumberOfThreadsInGpgpuThreadGroup(64u); EncodeDispatchKernel::adjustInterfaceDescriptorData(iddArg, *pDevice, hwInfo, threadGroupCount, numGrf); @@ -585,9 +585,9 @@ XE_HPC_CORETEST_F(EncodeKernelXeHpcCoreTest, givenDifferentNumGrfWhenCallingAdju hwInfo.platform.usRevId = hwInfoConfig.getHwRevIdFromStepping(REVISION_B, hwInfo); INTERFACE_DESCRIPTOR_DATA iddArg = FamilyType::cmdInitInterfaceDescriptorData; - auto &hwHelper = HwHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); const uint32_t numberOfThreadsInThreadGroup = 1u; - const uint32_t threadGroupCount = hwHelper.calculateAvailableThreadCount(hwInfo, GrfConfig::DefaultGrfNumber); + const uint32_t threadGroupCount = gfxCoreHelper.calculateAvailableThreadCount(hwInfo, GrfConfig::DefaultGrfNumber); { const uint32_t numGrf = GrfConfig::DefaultGrfNumber; diff --git a/shared/test/unit_test/xe_hpc_core/test_preamble_xe_hpc_core.cpp b/shared/test/unit_test/xe_hpc_core/test_preamble_xe_hpc_core.cpp index 5b348e0b9d..8533969ff4 100644 --- a/shared/test/unit_test/xe_hpc_core/test_preamble_xe_hpc_core.cpp +++ b/shared/test/unit_test/xe_hpc_core/test_preamble_xe_hpc_core.cpp @@ -71,7 +71,7 @@ XE_HPC_CORETEST_F(PreambleCfeState, givenNotSetDebugFlagWhenPreambleCfeStateIsPr uint32_t singleDispatchCcsMode = cfeState->getSingleSliceDispatchCcsMode(); uint64_t expectedAddress = 1 << CFE_STATE::SCRATCHSPACEBUFFER_BIT_SHIFT; - uint32_t expectedMaxThreads = HwHelper::getMaxThreadsForVfe(*defaultHwInfo); + uint32_t expectedMaxThreads = GfxCoreHelper::getMaxThreadsForVfe(*defaultHwInfo); auto pVfeCmd = PreambleHelper::getSpaceForVfeState(&linearStream, *defaultHwInfo, EngineGroupType::RenderCompute); StreamProperties emptyProperties{}; PreambleHelper::programVfeState(pVfeCmd, *defaultHwInfo, 0u, expectedAddress, expectedMaxThreads, emptyProperties, nullptr); diff --git a/shared/test/unit_test/xe_hpg_core/dg2/excludes_xe_hpg_core_dg2.cpp b/shared/test/unit_test/xe_hpg_core/dg2/excludes_xe_hpg_core_dg2.cpp index 48bb42045d..470271b5be 100644 --- a/shared/test/unit_test/xe_hpg_core/dg2/excludes_xe_hpg_core_dg2.cpp +++ b/shared/test/unit_test/xe_hpg_core/dg2/excludes_xe_hpg_core_dg2.cpp @@ -29,5 +29,5 @@ HWTEST_EXCLUDE_PRODUCT(MemoryManagerTests, givenEnabledLocalMemoryWhenLinearStre HWTEST_EXCLUDE_PRODUCT(MemoryManagerTests, givenEnabledLocalMemoryWhenAllocateKernelIsaInDevicePoolThenLocalMemoryPoolIsUsed, IGFX_DG2); HWTEST_EXCLUDE_PRODUCT(SbaTest, givenStateBaseAddressAndDebugFlagSetWhenAppendExtraCacheSettingsThenProgramCorrectL1CachePolicy_IsAtLeastXeHpgCore, IGFX_DG2); HWTEST_EXCLUDE_PRODUCT(XeHpgSbaTest, givenSpecificProductFamilyWhenAppendingSbaThenProgramWBPL1CachePolicy, IGFX_DG2); -HWTEST_EXCLUDE_PRODUCT(HwHelperTest, GivenZeroSlmSizeWhenComputeSlmSizeIsCalledThenCorrectValueIsReturned, IGFX_DG2); +HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTest, GivenZeroSlmSizeWhenComputeSlmSizeIsCalledThenCorrectValueIsReturned, IGFX_DG2); HWTEST_EXCLUDE_PRODUCT(ProductHelperTestXeHpgCore, givenProductHelperWhenCheckTimestampWaitSupportForEventsThenReturnFalse, IGFX_DG2); diff --git a/shared/test/unit_test/xe_hpg_core/dg2/hw_helper_tests_dg2.cpp b/shared/test/unit_test/xe_hpg_core/dg2/hw_helper_tests_dg2.cpp index 65427a9888..f0d1a7eefb 100644 --- a/shared/test/unit_test/xe_hpg_core/dg2/hw_helper_tests_dg2.cpp +++ b/shared/test/unit_test/xe_hpg_core/dg2/hw_helper_tests_dg2.cpp @@ -17,17 +17,17 @@ using namespace NEO; -using HwHelperTestDg2 = ::testing::Test; +using GfxCoreHelperTestDg2 = ::testing::Test; -DG2TEST_F(HwHelperTestDg2, whenGetExtensionsIsCalledThenMatrixMultiplyAccumulateExtensionsAreReturned) { - auto &hwHelper = HwHelper::get(defaultHwInfo->platform.eRenderCoreFamily); - auto extensions = hwHelper.getExtensions(*defaultHwInfo); +DG2TEST_F(GfxCoreHelperTestDg2, whenGetExtensionsIsCalledThenMatrixMultiplyAccumulateExtensionsAreReturned) { + auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily); + auto extensions = gfxCoreHelper.getExtensions(*defaultHwInfo); EXPECT_TRUE(hasSubstr(extensions, std::string("cl_intel_subgroup_matrix_multiply_accumulate"))); EXPECT_TRUE(hasSubstr(extensions, std::string("cl_intel_subgroup_split_matrix_multiply_accumulate"))); } -DG2TEST_F(HwHelperTestDg2, givenRcsDisabledWhenGetGpgpuEnginesCalledThenDontSetRcs) { +DG2TEST_F(GfxCoreHelperTestDg2, givenRcsDisabledWhenGetGpgpuEnginesCalledThenDontSetRcs) { HardwareInfo hwInfo = *defaultHwInfo; auto hwInfoConfig = HwInfoConfig::get(productFamily); hwInfo.featureTable.flags.ftrCCSNode = true; @@ -41,7 +41,7 @@ DG2TEST_F(HwHelperTestDg2, givenRcsDisabledWhenGetGpgpuEnginesCalledThenDontSetR auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(8u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(8u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); @@ -54,7 +54,7 @@ DG2TEST_F(HwHelperTestDg2, givenRcsDisabledWhenGetGpgpuEnginesCalledThenDontSetR EXPECT_EQ(aub_stream::ENGINE_BCS, engines[7].first); } -DG2TEST_F(HwHelperTestDg2, givenRcsDisabledButDebugVariableSetWhenGetGpgpuEnginesCalledThenSetRcs) { +DG2TEST_F(GfxCoreHelperTestDg2, givenRcsDisabledButDebugVariableSetWhenGetGpgpuEnginesCalledThenSetRcs) { HardwareInfo hwInfo = *defaultHwInfo; hwInfo.featureTable.flags.ftrCCSNode = true; hwInfo.featureTable.ftrBcsInfo = 1; @@ -69,7 +69,7 @@ DG2TEST_F(HwHelperTestDg2, givenRcsDisabledButDebugVariableSetWhenGetGpgpuEngine auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); EXPECT_EQ(9u, device->allEngines.size()); - auto &engines = HwHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); EXPECT_EQ(9u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); diff --git a/shared/test/unit_test/xe_hpg_core/dg2/hw_info_config_tests_dg2.cpp b/shared/test/unit_test/xe_hpg_core/dg2/hw_info_config_tests_dg2.cpp index 1ef1e8b339..bcb1a30c96 100644 --- a/shared/test/unit_test/xe_hpg_core/dg2/hw_info_config_tests_dg2.cpp +++ b/shared/test/unit_test/xe_hpg_core/dg2/hw_info_config_tests_dg2.cpp @@ -119,17 +119,17 @@ DG2TEST_F(HwInfoConfigTestDg2, whenAdjustingDefaultEngineTypeThenSelectEngineTyp auto hardwareInfo = *defaultHwInfo; hardwareInfo.featureTable.flags.ftrCCSNode = true; - auto &coreHelper = getHelper(); + auto &gfxCoreHelper = getHelper(); auto &productHelper = getHelper(); hardwareInfo.capabilityTable.defaultEngineType = defaultHwInfo->capabilityTable.defaultEngineType; hardwareInfo.platform.usRevId = productHelper.getHwRevIdFromStepping(REVISION_A0, hardwareInfo); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(aub_stream::ENGINE_RCS, hardwareInfo.capabilityTable.defaultEngineType); hardwareInfo.capabilityTable.defaultEngineType = defaultHwInfo->capabilityTable.defaultEngineType; hardwareInfo.platform.usRevId = productHelper.getHwRevIdFromStepping(REVISION_B, hardwareInfo); - coreHelper.adjustDefaultEngineType(&hardwareInfo); + gfxCoreHelper.adjustDefaultEngineType(&hardwareInfo); EXPECT_EQ(aub_stream::ENGINE_CCS, hardwareInfo.capabilityTable.defaultEngineType); } @@ -303,7 +303,7 @@ DG2TEST_F(HwInfoConfigTestDg2, givenRevisionEnumAndPlatformFamilyTypeThenProperV }; auto hardwareInfo = *defaultHwInfo; - const auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + const auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); const auto &hwInfoConfig = *HwInfoConfig::get(hardwareInfo.platform.eProductFamily); for (auto stepping : steppings) { @@ -311,45 +311,45 @@ DG2TEST_F(HwInfoConfigTestDg2, givenRevisionEnumAndPlatformFamilyTypeThenProperV if (stepping <= REVISION_B) { if (stepping == REVISION_A0) { - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A1, REVISION_B, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A1, REVISION_C, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A1, REVISION_B, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A1, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); } else if (stepping == REVISION_A1) { - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A1, REVISION_B, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A1, REVISION_C, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A1, REVISION_B, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A1, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); } else { // REVISION_B - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A1, REVISION_B, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_A1, REVISION_C, hardwareInfo)); - EXPECT_TRUE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A1, REVISION_B, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_A1, REVISION_C, hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); } } else { - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A1, REVISION_B, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A1, REVISION_C, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_A1, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_B, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A1, REVISION_B, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A1, REVISION_C, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_C, hardwareInfo)); } - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A1, REVISION_A0, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_C, REVISION_A0, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_B, REVISION_A1, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_C, REVISION_A1, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_C, REVISION_B, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A1, REVISION_A0, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_A0, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_C, REVISION_A0, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_B, REVISION_A1, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_C, REVISION_A1, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_C, REVISION_B, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); - EXPECT_FALSE(hwHelper.isWorkaroundRequired(REVISION_D, REVISION_A0, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_A0, REVISION_D, hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.isWorkaroundRequired(REVISION_D, REVISION_A0, hardwareInfo)); } } @@ -363,15 +363,15 @@ DG2TEST_F(HwInfoConfigTestDg2, givenRevisionEnumAndDisableL3CacheForDebugCalledT }; auto hardwareInfo = *defaultHwInfo; - const auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); + const auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); const auto &hwInfoConfig = *HwInfoConfig::get(hardwareInfo.platform.eProductFamily); for (auto stepping : steppings) { hardwareInfo.platform.usRevId = hwInfoConfig.getHwRevIdFromStepping(stepping, hardwareInfo); if (stepping < REVISION_B) { - EXPECT_TRUE(hwHelper.disableL3CacheForDebug(hardwareInfo)); + EXPECT_TRUE(gfxCoreHelper.disableL3CacheForDebug(hardwareInfo)); } else { - EXPECT_FALSE(hwHelper.disableL3CacheForDebug(hardwareInfo)); + EXPECT_FALSE(gfxCoreHelper.disableL3CacheForDebug(hardwareInfo)); } } } @@ -408,11 +408,11 @@ DG2TEST_F(HwInfoConfigTestDg2, givenEnabledSliceInNonStandardConfigWhenComputeUn auto subSlicesPerSlice = testSysInfo.MaxSubSlicesSupported / testSysInfo.MaxSlicesSupported; auto maxSubSlice = highestEnabledSlice * subSlicesPerSlice; - auto &coreHelper = getHelper(); + auto &gfxCoreHelper = getHelper(); uint32_t expectedCalculation = maxSubSlice * testSysInfo.MaxEuPerSubSlice * (testSysInfo.ThreadCount / testSysInfo.EUCount); - EXPECT_EQ(expectedCalculation, coreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment())); + EXPECT_EQ(expectedCalculation, gfxCoreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment())); } DG2TEST_F(HwInfoConfigTestDg2, givenNotEnabledSliceWhenComputeUnitsUsedForScratchThenThrowUnrecoverableIf) { @@ -423,9 +423,9 @@ DG2TEST_F(HwInfoConfigTestDg2, givenNotEnabledSliceWhenComputeUnitsUsedForScratc testSysInfo.SliceInfo[i].Enabled = false; } - auto &coreHelper = getHelper(); + auto &gfxCoreHelper = getHelper(); - EXPECT_THROW(coreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment()), std::exception); + EXPECT_THROW(gfxCoreHelper.getComputeUnitsUsedForScratch(pDevice->getRootDeviceEnvironment()), std::exception); } DG2TEST_F(ProductHelperTestDg2, givenDG2WhenCheckingIsTimestampWaitSupportedForEventsThenReturnTrue) { diff --git a/shared/test/unit_test/xe_hpg_core/dg2/test_hw_helper_dg2.cpp b/shared/test/unit_test/xe_hpg_core/dg2/test_hw_helper_dg2.cpp index 59342dda72..1550ec2da0 100644 --- a/shared/test/unit_test/xe_hpg_core/dg2/test_hw_helper_dg2.cpp +++ b/shared/test/unit_test/xe_hpg_core/dg2/test_hw_helper_dg2.cpp @@ -14,20 +14,20 @@ #include "shared/test/common/test_macros/test.h" using namespace NEO; -using HwHelperTestDg2 = ::testing::Test; +using GfxCoreHelperTestDg2 = ::testing::Test; -DG2TEST_F(HwHelperTestDg2, GivenDifferentSteppingWhenComputeSlmSizeIsCalledThenCorrectValueIsReturned) { +DG2TEST_F(GfxCoreHelperTestDg2, GivenDifferentSteppingWhenComputeSlmSizeIsCalledThenCorrectValueIsReturned) { using SHARED_LOCAL_MEMORY_SIZE = typename FamilyType::INTERFACE_DESCRIPTOR_DATA::SHARED_LOCAL_MEMORY_SIZE; __REVID revisions[] = {REVISION_A0, REVISION_B}; - auto &hwHelper = HwHelperHw::get(); + auto &gfxCoreHelper = GfxCoreHelperHw::get(); const auto &hwInfoConfig = *HwInfoConfig::get(productFamily); auto hwInfo = *defaultHwInfo; for (auto revision : revisions) { hwInfo.platform.usRevId = hwInfoConfig.getHwRevIdFromStepping(revision, hwInfo); for (auto &testInput : computeSlmValuesXeHPAndLaterTestsInput) { - EXPECT_EQ(testInput.expected, hwHelper.computeSlmValues(hwInfo, testInput.slmSize)); + EXPECT_EQ(testInput.expected, gfxCoreHelper.computeSlmValues(hwInfo, testInput.slmSize)); } } } diff --git a/shared/test/unit_test/xe_hpg_core/hw_helper_tests_xe_hpg_core.cpp b/shared/test/unit_test/xe_hpg_core/hw_helper_tests_xe_hpg_core.cpp index b06b76f7a6..9ae1ef0eb7 100644 --- a/shared/test/unit_test/xe_hpg_core/hw_helper_tests_xe_hpg_core.cpp +++ b/shared/test/unit_test/xe_hpg_core/hw_helper_tests_xe_hpg_core.cpp @@ -19,25 +19,25 @@ #include "hw_cmds_xe_hpg_core_base.h" -using HwHelperTestXeHpgCore = HwHelperTest; +using GfxCoreHelperTestXeHpgCore = GfxCoreHelperTest; using ProductHelperTestXeHpgCore = Test; -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenDifferentBufferSizesWhenEnableStatelessCompressionThenEveryBufferSizeIsSuitableForCompression) { +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, givenDifferentBufferSizesWhenEnableStatelessCompressionThenEveryBufferSizeIsSuitableForCompression) { DebugManagerStateRestore restore; DebugManager.flags.EnableStatelessCompression.set(1); - auto &coreHelper = getHelper(); + auto &gfxCoreHelper = getHelper(); const size_t sizesToCheck[] = {1, 128, 256, 1024, 2048}; for (size_t size : sizesToCheck) { - EXPECT_TRUE(coreHelper.isBufferSizeSuitableForCompression(size, *defaultHwInfo)); + EXPECT_TRUE(gfxCoreHelper.isBufferSizeSuitableForCompression(size, *defaultHwInfo)); } } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenDebugFlagWhenCheckingIfBufferIsSuitableThenReturnCorrectValue) { +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, givenDebugFlagWhenCheckingIfBufferIsSuitableThenReturnCorrectValue) { DebugManagerStateRestore restore; - auto &coreHelper = getHelper(); + auto &gfxCoreHelper = getHelper(); const size_t sizesToCheck[] = {1, 128, 256, 1024, 2048}; for (int32_t debugFlag : {-1, 0, 1}) { @@ -45,9 +45,9 @@ XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenDebugFlagWhenCheckingIfBufferIsSui for (size_t size : sizesToCheck) { if (debugFlag == 1) { - EXPECT_TRUE(coreHelper.isBufferSizeSuitableForCompression(size, *defaultHwInfo)); + EXPECT_TRUE(gfxCoreHelper.isBufferSizeSuitableForCompression(size, *defaultHwInfo)); } else { - EXPECT_FALSE(coreHelper.isBufferSizeSuitableForCompression(size, *defaultHwInfo)); + EXPECT_FALSE(gfxCoreHelper.isBufferSizeSuitableForCompression(size, *defaultHwInfo)); } } } @@ -95,8 +95,8 @@ XE_HPG_CORETEST_F(LriHelperTestsXeHpgCore, whenProgrammingLriCommandThenExpectMm EXPECT_TRUE(memcmp(lri, &expectedLri, sizeof(MI_LOAD_REGISTER_IMM)) == 0); } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenAllocDataWhenSetExtraAllocationDataThenSetLocalMemForProperTypes) { - auto &hwHelper = HwHelper::get(renderCoreFamily); +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, givenAllocDataWhenSetExtraAllocationDataThenSetLocalMemForProperTypes) { + auto &gfxCoreHelper = GfxCoreHelper::get(renderCoreFamily); for (int type = 0; type < static_cast(AllocationType::COUNT); type++) { AllocationProperties allocProperties(0, 1, static_cast(type), {}); @@ -104,7 +104,7 @@ XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenAllocDataWhenSetExtraAllocationDat allocData.flags.useSystemMemory = true; allocData.flags.requiresCpuAccess = false; - hwHelper.setExtraAllocationData(allocData, allocProperties, *defaultHwInfo); + gfxCoreHelper.setExtraAllocationData(allocData, allocProperties, *defaultHwInfo); if (defaultHwInfo->featureTable.flags.ftrLocalMemory && (allocProperties.allocationType == AllocationType::COMMAND_BUFFER || @@ -119,26 +119,26 @@ XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenAllocDataWhenSetExtraAllocationDat } } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, GivenVariousValuesWhenAlignSlmSizeIsCalledThenCorrectValueIsReturned) { - EXPECT_EQ(0u, HwHelperHw::get().alignSlmSize(0)); - EXPECT_EQ(1024u, HwHelperHw::get().alignSlmSize(1)); - EXPECT_EQ(1024u, HwHelperHw::get().alignSlmSize(1024)); - EXPECT_EQ(2048u, HwHelperHw::get().alignSlmSize(1025)); - EXPECT_EQ(2048u, HwHelperHw::get().alignSlmSize(2048)); - EXPECT_EQ(4096u, HwHelperHw::get().alignSlmSize(2049)); - EXPECT_EQ(4096u, HwHelperHw::get().alignSlmSize(4096)); - EXPECT_EQ(8192u, HwHelperHw::get().alignSlmSize(4097)); - EXPECT_EQ(8192u, HwHelperHw::get().alignSlmSize(8192)); - EXPECT_EQ(16384u, HwHelperHw::get().alignSlmSize(8193)); - EXPECT_EQ(16384u, HwHelperHw::get().alignSlmSize(16384)); - EXPECT_EQ(32768u, HwHelperHw::get().alignSlmSize(16385)); - EXPECT_EQ(32768u, HwHelperHw::get().alignSlmSize(32768)); - EXPECT_EQ(65536u, HwHelperHw::get().alignSlmSize(32769)); - EXPECT_EQ(65536u, HwHelperHw::get().alignSlmSize(65536)); +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, GivenVariousValuesWhenAlignSlmSizeIsCalledThenCorrectValueIsReturned) { + EXPECT_EQ(0u, GfxCoreHelperHw::get().alignSlmSize(0)); + EXPECT_EQ(1024u, GfxCoreHelperHw::get().alignSlmSize(1)); + EXPECT_EQ(1024u, GfxCoreHelperHw::get().alignSlmSize(1024)); + EXPECT_EQ(2048u, GfxCoreHelperHw::get().alignSlmSize(1025)); + EXPECT_EQ(2048u, GfxCoreHelperHw::get().alignSlmSize(2048)); + EXPECT_EQ(4096u, GfxCoreHelperHw::get().alignSlmSize(2049)); + EXPECT_EQ(4096u, GfxCoreHelperHw::get().alignSlmSize(4096)); + EXPECT_EQ(8192u, GfxCoreHelperHw::get().alignSlmSize(4097)); + EXPECT_EQ(8192u, GfxCoreHelperHw::get().alignSlmSize(8192)); + EXPECT_EQ(16384u, GfxCoreHelperHw::get().alignSlmSize(8193)); + EXPECT_EQ(16384u, GfxCoreHelperHw::get().alignSlmSize(16384)); + EXPECT_EQ(32768u, GfxCoreHelperHw::get().alignSlmSize(16385)); + EXPECT_EQ(32768u, GfxCoreHelperHw::get().alignSlmSize(32768)); + EXPECT_EQ(65536u, GfxCoreHelperHw::get().alignSlmSize(32769)); + EXPECT_EQ(65536u, GfxCoreHelperHw::get().alignSlmSize(65536)); } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenHwHelperWhenGettingThreadsPerEUConfigsThenCorrectConfigsAreReturned) { - auto &helper = HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, givenGfxCoreHelperWhenGettingThreadsPerEUConfigsThenCorrectConfigsAreReturned) { + auto &helper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); EXPECT_NE(nullptr, &helper); auto &configs = helper.getThreadsPerEUConfigs(); @@ -148,13 +148,13 @@ XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenHwHelperWhenGettingThreadsPerEUCon EXPECT_EQ(8U, configs[1]); } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, WhenCheckingSipWAThenFalseIsReturned) { - EXPECT_FALSE(HwHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily).isSipWANeeded(pDevice->getHardwareInfo())); +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, WhenCheckingSipWAThenFalseIsReturned) { + EXPECT_FALSE(GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily).isSipWANeeded(pDevice->getHardwareInfo())); } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenXeHPAndLaterPlatformWhenCheckAssignEngineRoundRobinSupportedThenReturnFalse) { - auto &hwHelper = HwHelperHw::get(); - EXPECT_FALSE(hwHelper.isAssignEngineRoundRobinSupported(*defaultHwInfo)); +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, givenXeHPAndLaterPlatformWhenCheckAssignEngineRoundRobinSupportedThenReturnFalse) { + auto &gfxCoreHelper = GfxCoreHelperHw::get(); + EXPECT_FALSE(gfxCoreHelper.isAssignEngineRoundRobinSupported(*defaultHwInfo)); } XE_HPG_CORETEST_F(ProductHelperTestXeHpgCore, givenProductHelperWhenCheckTimestampWaitSupportForEventsThenReturnFalse) { @@ -162,12 +162,12 @@ XE_HPG_CORETEST_F(ProductHelperTestXeHpgCore, givenProductHelperWhenCheckTimesta EXPECT_FALSE(helper.isTimestampWaitSupportedForEvents()); } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenCoreHelperWhenCheckTimestampWaitSupportForQueuesThenReturnFalse) { - auto &helper = getHelper(); +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, givenGfxCoreHelperWhenCheckTimestampWaitSupportForQueuesThenReturnFalse) { + auto &helper = getHelper(); EXPECT_FALSE(helper.isTimestampWaitSupportedForQueues()); } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenDisablePipeControlFlagIsEnabledWhenLocalMemoryIsEnabledThenReturnTrueAndProgramPipeControl) { +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, givenDisablePipeControlFlagIsEnabledWhenLocalMemoryIsEnabledThenReturnTrueAndProgramPipeControl) { using PIPE_CONTROL = typename FamilyType::PIPE_CONTROL; DebugManagerStateRestore restore; DebugManager.flags.DisablePipeControlPrecedingPostSyncCommand.set(1); @@ -184,7 +184,7 @@ XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenDisablePipeControlFlagIsEnabledWhe EXPECT_EQ(sizeof(PIPE_CONTROL), cmdStream.getUsed()); } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenDisablePipeControlFlagIsEnabledWhenLocalMemoryIsDisabledThenReturnFalseAndDoNotProgramPipeControl) { +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, givenDisablePipeControlFlagIsEnabledWhenLocalMemoryIsDisabledThenReturnFalseAndDoNotProgramPipeControl) { DebugManagerStateRestore restore; DebugManager.flags.DisablePipeControlPrecedingPostSyncCommand.set(1); @@ -200,12 +200,12 @@ XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenDisablePipeControlFlagIsEnabledWhe EXPECT_EQ(0u, cmdStream.getUsed()); } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenXeHpgCoreWhenCheckingIfEngineTypeRemappingIsRequiredThenReturnTrue) { - const auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - EXPECT_FALSE(hwHelper.isEngineTypeRemappingToHwSpecificRequired()); +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, givenXeHpgCoreWhenCheckingIfEngineTypeRemappingIsRequiredThenReturnTrue) { + const auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + EXPECT_FALSE(gfxCoreHelper.isEngineTypeRemappingToHwSpecificRequired()); } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, givenDebugFlagAndLocalMemoryIsNotAvailableWhenProgrammingPostSyncPipeControlThenExpectNotAddingWaPipeControl) { using PIPE_CONTROL = typename FamilyType::PIPE_CONTROL; @@ -242,7 +242,7 @@ XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, EXPECT_EQ(immediateValue, pipeControl->getImmediateData()); } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, givenDebugFlagAndLocalMemoryIsAvailableWhenProgrammingPostSyncPipeControlThenExpectAddingWaPipeControl) { using PIPE_CONTROL = typename FamilyType::PIPE_CONTROL; @@ -287,11 +287,11 @@ XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, EXPECT_EQ(immediateValue, pipeControl->getImmediateData()); } -XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenHwHelperWhenCallCopyThroughLockedPtrEnabledThenReturnTrue) { - const auto &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily); - if (hwHelper.isLocalMemoryEnabled(*defaultHwInfo)) { - EXPECT_TRUE(hwHelper.copyThroughLockedPtrEnabled(*defaultHwInfo)); +XE_HPG_CORETEST_F(GfxCoreHelperTestXeHpgCore, givenGfxCoreHelperWhenCallCopyThroughLockedPtrEnabledThenReturnTrue) { + const auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + if (gfxCoreHelper.isLocalMemoryEnabled(*defaultHwInfo)) { + EXPECT_TRUE(gfxCoreHelper.copyThroughLockedPtrEnabled(*defaultHwInfo)); } else { - EXPECT_FALSE(hwHelper.copyThroughLockedPtrEnabled(*defaultHwInfo)); + EXPECT_FALSE(gfxCoreHelper.copyThroughLockedPtrEnabled(*defaultHwInfo)); } } \ No newline at end of file