intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-11 16:45:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: add FileDescriptor class to ensure file descriptor is closed

Browse Source 
Related-To: NEO-9038
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
This commit is contained in:
Mateusz Jablonski
2023-10-09 10:55:30 +00:00
committed by Compute-Runtime-Automation
parent c2d69e5857
commit 099a3f30e3
15 changed files with 139 additions and 217 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
shared/test/unit_test/os_interface/linux/CMakeLists.txt
View File

@@ -35,6 +35,7 @@ set(NEO_CORE_OS_INTERFACE_TESTS_LINUX
${CMAKE_CURRENT_SOURCE_DIR}/product_helper_uuid_tests.cpp
${CMAKE_CURRENT_SOURCE_DIR}/product_helper_linux_tests.cpp
${CMAKE_CURRENT_SOURCE_DIR}/product_helper_linux_tests.h
${CMAKE_CURRENT_SOURCE_DIR}/file_descriptor_tests.cpp
${CMAKE_CURRENT_SOURCE_DIR}/os_context_linux_tests.cpp
${CMAKE_CURRENT_SOURCE_DIR}/os_interface_linux_tests.cpp
${CMAKE_CURRENT_SOURCE_DIR}/os_library_linux_tests.cpp

41
shared/test/unit_test/os_interface/linux/file_descriptor_tests.cpp Normal file
View File

@@ -0,0 +1,41 @@
/*
* Copyright (C) 2023 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
*/
#include "shared/source/os_interface/linux/file_descriptor.h"
#include "shared/test/common/helpers/variable_backup.h"
#include "shared/test/common/os_interface/linux/sys_calls_linux_ult.h"
#include "gtest/gtest.h"
using namespace NEO;
TEST(FileDescriptorTest, whenOpeningFileReturnsNonNegativeFileDescriptorThenCloseIsCalled) {
int mockHandle = 12345;
VariableBackup<decltype(SysCalls::openFuncRetVal)> openRetValBackup(&SysCalls::openFuncRetVal, mockHandle);
VariableBackup<decltype(SysCalls::openFuncCalled)> openCalledBackup(&SysCalls::openFuncCalled, 0u);
VariableBackup<decltype(SysCalls::closeFuncCalled)> closeCalledBackup(&SysCalls::closeFuncCalled, 0u);
{
auto fileDescriptor = FileDescriptor("", 0);
EXPECT_EQ(SysCalls::openFuncRetVal, fileDescriptor);
EXPECT_EQ(1u, SysCalls::openFuncCalled);
SysCalls::closeFuncArgPassed = 0;
}
EXPECT_EQ(1u, SysCalls::closeFuncCalled);
EXPECT_EQ(SysCalls::openFuncRetVal, SysCalls::closeFuncArgPassed);
SysCalls::openFuncRetVal = -1;
{
auto fileDescriptor = FileDescriptor("", 0);
EXPECT_EQ(SysCalls::openFuncRetVal, fileDescriptor);
EXPECT_EQ(2u, SysCalls::openFuncCalled);
SysCalls::closeFuncArgPassed = 0;
}
EXPECT_EQ(1u, SysCalls::closeFuncCalled);
}