diff --git a/opencl/test/unit_test/command_queue/enqueue_kernel_1_tests.cpp b/opencl/test/unit_test/command_queue/enqueue_kernel_1_tests.cpp index e4e53386b4..ee3a6c7543 100644 --- a/opencl/test/unit_test/command_queue/enqueue_kernel_1_tests.cpp +++ b/opencl/test/unit_test/command_queue/enqueue_kernel_1_tests.cpp @@ -310,7 +310,8 @@ TEST_F(EnqueueKernelTest, GivenNullKernelWhenEnqueuingNDCountKernelINTELThenInva using clEnqueueNDCountKernelTests = api_tests; TEST_F(clEnqueueNDCountKernelTests, GivenQueueIncapableWhenEnqueuingNDCountKernelINTELThenInvalidOperationIsReturned) { - auto &gfxCoreHelper = GfxCoreHelper::get(::defaultHwInfo->platform.eRenderCoreFamily); + + auto &gfxCoreHelper = pDevice->getGfxCoreHelper(); auto engineGroupType = gfxCoreHelper.getEngineGroupType(pCommandQueue->getGpgpuEngine().getEngineType(), pCommandQueue->getGpgpuEngine().getEngineUsage(), *::defaultHwInfo); if (!gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, *::defaultHwInfo)) { @@ -344,7 +345,7 @@ TEST_F(EnqueueKernelTest, givenKernelWhenAllArgsAreSetThenClEnqueueNDCountKernel cl_int retVal = CL_SUCCESS; CommandQueue *pCmdQ2 = createCommandQueue(pClDevice); - GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = pDevice->getGfxCoreHelper(); auto engineGroupType = gfxCoreHelper.getEngineGroupType(pCmdQ2->getGpgpuEngine().getEngineType(), pCmdQ2->getGpgpuEngine().getEngineUsage(), hardwareInfo); if (!gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, hardwareInfo)) { @@ -392,7 +393,7 @@ TEST_F(EnqueueKernelTest, givenKernelWhenNotAllArgsAreSetButSetKernelArgIsCalled cl_int retVal = CL_SUCCESS; CommandQueue *pCmdQ2 = createCommandQueue(pClDevice); - GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = pClDevice->getGfxCoreHelper(); auto engineGroupType = gfxCoreHelper.getEngineGroupType(pCmdQ2->getGpgpuEngine().getEngineType(), pCmdQ2->getGpgpuEngine().getEngineUsage(), hardwareInfo); if (!gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, hardwareInfo)) { @@ -440,7 +441,7 @@ TEST_F(EnqueueKernelTest, givenKernelWhenSetKernelArgIsCalledForEachArgButAtLeas cl_int retVal = CL_SUCCESS; CommandQueue *pCmdQ2 = createCommandQueue(pClDevice); - GfxCoreHelper &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = pClDevice->getGfxCoreHelper(); auto engineGroupType = gfxCoreHelper.getEngineGroupType(pCmdQ2->getGpgpuEngine().getEngineType(), pCmdQ2->getGpgpuEngine().getEngineUsage(), hardwareInfo); if (!gfxCoreHelper.isCooperativeDispatchSupported(engineGroupType, hardwareInfo)) { diff --git a/opencl/test/unit_test/device/device_caps_tests.cpp b/opencl/test/unit_test/device/device_caps_tests.cpp index aacc5a8288..3e8607f8ae 100644 --- a/opencl/test/unit_test/device/device_caps_tests.cpp +++ b/opencl/test/unit_test/device/device_caps_tests.cpp @@ -258,7 +258,7 @@ TEST_F(DeviceGetCapsTest, WhenCreatingDeviceThenCapsArePopulatedCorrectly) { HWTEST_F(DeviceGetCapsTest, givenDeviceWhenAskingForSubGroupSizesThenReturnCorrectValues) { auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(defaultHwInfo.get())); - auto &gfxCoreHelper = GfxCoreHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = device->getGfxCoreHelper(); auto deviceSubgroups = gfxCoreHelper.getDeviceSubGroupSizes(); @@ -1109,14 +1109,15 @@ TEST(DeviceGetCaps, givenDebugFlagToUseMaxSimdSizeForWkgCalculationWhenDeviceCap HWTEST_F(DeviceGetCapsTest, givenDeviceThatHasHighNumberOfExecutionUnitsWhenMaxWorkgroupSizeIsComputedThenItIsLimitedTo1024) { REQUIRE_OCL_21_OR_SKIP(defaultHwInfo); - HardwareInfo myHwInfo = *defaultHwInfo; - GT_SYSTEM_INFO &mySysInfo = myHwInfo.gtSystemInfo; - auto &gfxCoreHelper = GfxCoreHelper::get(myHwInfo.platform.eRenderCoreFamily); + MockExecutionEnvironment mockExecutionEnvironment{}; + auto &gfxCoreHelper = mockExecutionEnvironment.rootDeviceEnvironments[0]->getHelper(); + GT_SYSTEM_INFO &mySysInfo = myHwInfo.gtSystemInfo; mySysInfo.EUCount = 32; mySysInfo.SubSliceCount = 2; mySysInfo.ThreadCount = 32 * gfxCoreHelper.getMinimalSIMDSize(); // 128 threads per subslice, in simd 8 gives 1024 + auto device = std::make_unique(MockDevice::createWithNewExecutionEnvironment(&myHwInfo)); EXPECT_EQ(1024u, device->getSharedDeviceInfo().maxWorkGroupSize); @@ -1513,7 +1514,7 @@ HWTEST2_F(DeviceGetCapsTest, givenSysInfoWhenDeviceCreatedThenMaxWorkGroupSizeIs mySysInfo.ThreadCount = 16 * 8; myPlatform.usRevId = 0x4; auto device = std::make_unique(MockDevice::createWithNewExecutionEnvironment(&myHwInfo)); - auto &gfxCoreHelper = GfxCoreHelper::get(myHwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = device->getGfxCoreHelper(); auto minSimd = gfxCoreHelper.getMinimalSIMDSize(); size_t expectedWGSize = (mySysInfo.ThreadCount / mySysInfo.SubSliceCount) * minSimd; @@ -1533,7 +1534,7 @@ HWTEST2_F(DeviceGetCapsTest, givenSysInfoWhenDeviceCreatedThenMaxWorkGroupSizeIs mySysInfo.ThreadCount = 16 * 8; myPlatform.usRevId = 0x4; auto device = std::make_unique(MockDevice::createWithNewExecutionEnvironment(&myHwInfo)); - auto &gfxCoreHelper = GfxCoreHelper::get(myHwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = device->getGfxCoreHelper(); auto minSimd = gfxCoreHelper.getMinimalSIMDSize(); size_t expectedWGSize = (mySysInfo.ThreadCount / mySysInfo.DualSubSliceCount) * minSimd; diff --git a/opencl/test/unit_test/device/device_tests.cpp b/opencl/test/unit_test/device/device_tests.cpp index 07caaac84e..aca8722192 100644 --- a/opencl/test/unit_test/device/device_tests.cpp +++ b/opencl/test/unit_test/device/device_tests.cpp @@ -70,8 +70,8 @@ TEST_F(DeviceTest, givenDeviceWhenAskedForSpecificEngineThenReturnIt) { hwInfo.capabilityTable.blitterOperationsSupported = true; MockClDevice mockClDevice{MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)}; - - auto &engines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); + auto &gfxCoreHelper = mockClDevice.getGfxCoreHelper(); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); for (uint32_t i = 0; i < engines.size(); i++) { auto &deviceEngine = mockClDevice.getEngine(engines[i].first, EngineUsage::Regular); EXPECT_EQ(deviceEngine.osContext->getEngineType(), engines[i].first); @@ -88,7 +88,8 @@ TEST_F(DeviceTest, givenDeviceWhenAskedForSpecificEngineThenReturnIt) { TEST_F(DeviceTest, givenDebugVariableToAlwaysChooseEngineZeroWhenNotExistingEngineSelectedThenIndexZeroEngineIsReturned) { DebugManagerStateRestore restore; DebugManager.flags.OverrideInvalidEngineWithDefault.set(true); - auto &engines = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*defaultHwInfo); + auto &gfxCoreHelper = pDevice->getGfxCoreHelper(); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(*defaultHwInfo); auto &deviceEngine = pDevice->getEngine(engines[0].first, EngineUsage::Regular); auto ¬ExistingEngine = pDevice->getEngine(aub_stream::ENGINE_VCS, EngineUsage::Regular); EXPECT_EQ(¬ExistingEngine, &deviceEngine); @@ -269,7 +270,8 @@ TEST(DeviceCreation, givenDeviceWhenItIsCreatedThenOsContextIsRegistredInMemoryM hwInfo.capabilityTable.blitterOperationsSupported = true; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo)); auto memoryManager = device->getMemoryManager(); - auto numEnginesForDevice = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo).size(); + auto &gfxCoreHelper = device->getGfxCoreHelper(); + auto numEnginesForDevice = gfxCoreHelper.getGpgpuEngineInstances(hwInfo).size(); if (device->getNumGenericSubDevices() > 1) { numEnginesForDevice *= device->getNumGenericSubDevices(); numEnginesForDevice += device->allEngines.size(); @@ -371,7 +373,8 @@ TEST(DeviceCreation, givenMultiRootDeviceWhenTheyAreCreatedThenEachDeviceHasSepe executionEnvironment->rootDeviceEnvironments[i]->getMutableHardwareInfo()->capabilityTable.blitterOperationsSupported = true; } auto hwInfo = *executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo(); - const auto &numGpgpuEngines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo).size(); + auto &gfxCoreHelper = executionEnvironment->rootDeviceEnvironments[0]->getHelper(); + const auto &numGpgpuEngines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo).size(); auto device1 = std::unique_ptr(Device::create(executionEnvironment, 0u)); auto device2 = std::unique_ptr(Device::create(executionEnvironment, 1u)); diff --git a/opencl/test/unit_test/device/sub_device_tests.cpp b/opencl/test/unit_test/device/sub_device_tests.cpp index 105e009b4c..92845561f6 100644 --- a/opencl/test/unit_test/device/sub_device_tests.cpp +++ b/opencl/test/unit_test/device/sub_device_tests.cpp @@ -235,12 +235,14 @@ TEST(SubDevicesTest, givenSubDevicesWhenGettingDeviceByIdZeroThenGetThisSubDevic TEST(RootDevicesTest, givenRootDeviceWithoutSubdevicesWhenCreateEnginesThenDeviceCreatesCorrectNumberOfEngines) { auto hwInfo = *defaultHwInfo; hwInfo.capabilityTable.blitterOperationsSupported = true; - auto &gpgpuEngines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); auto executionEnvironment = new MockExecutionEnvironment; executionEnvironment->rootDeviceEnvironments[0]->setHwInfo(&hwInfo); executionEnvironment->rootDeviceEnvironments[0]->initGmm(); MockDevice device(executionEnvironment, 0); + auto &gfxCoreHelper = device.getGfxCoreHelper(); + auto &gpgpuEngines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); + EXPECT_EQ(0u, device.allEngines.size()); device.createEngines(); EXPECT_EQ(gpgpuEngines.size(), device.allEngines.size()); @@ -367,7 +369,8 @@ struct EngineInstancedDeviceTests : public ::testing::Test { template bool hasAllEngines(MockDeviceT *device) { auto &hwInfo = device->getHardwareInfo(); - auto gpgpuEngines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); + auto &gfxCoreHelper = device->getGfxCoreHelper(); + auto &gpgpuEngines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); for (size_t i = 0; i < gpgpuEngines.size(); i++) { if (device->allEngines[i].getEngineType() != gpgpuEngines[i].first) { @@ -586,7 +589,8 @@ TEST_F(EngineInstancedDeviceTests, givenEngineInstancedSubDeviceWhenEngineCreati auto subDevice = static_cast(rootDevice->getSubDevice(0)); auto &hwInfo = rootDevice->getHardwareInfo(); - auto gpgpuEngines = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo); + auto &gfxCoreHelper = rootDevice->getGfxCoreHelper(); + auto &gpgpuEngines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); subDevice->engineInstanced = true; subDevice->failOnCreateEngine = true; diff --git a/opencl/test/unit_test/event/event_tests.cpp b/opencl/test/unit_test/event/event_tests.cpp index 022ad0a1c1..6e6a1818c6 100644 --- a/opencl/test/unit_test/event/event_tests.cpp +++ b/opencl/test/unit_test/event/event_tests.cpp @@ -829,7 +829,7 @@ TEST_F(InternalsEventTest, givenDeviceTimestampBaseNotEnabledWhenCalculateStartT event.getEventProfilingInfo(CL_PROFILING_COMMAND_START, sizeof(cl_ulong), &start, nullptr); auto resolution = pClDevice->getDevice().getDeviceInfo().profilingTimerResolution; - auto &gfxCoreHelper = GfxCoreHelper::get(pClDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = pClDevice->getGfxCoreHelper(); auto c0 = event.queueTimeStamp.CPUTimeinNS - gfxCoreHelper.getGpuTimeStampInNS(event.queueTimeStamp.GPUTimeStamp, resolution); EXPECT_EQ(start, static_cast(timestamp.GlobalStartTS * resolution) + c0); @@ -888,7 +888,7 @@ TEST_F(InternalsEventTest, givenDeviceTimestampBaseEnabledAndGlobalStartTSSmalle uint64_t start = 0u; event.getEventProfilingInfo(CL_PROFILING_COMMAND_START, sizeof(cl_ulong), &start, nullptr); - auto &gfxCoreHelper = GfxCoreHelper::get(pClDevice->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = pClDevice->getGfxCoreHelper(); auto resolution = pClDevice->getDevice().getDeviceInfo().profilingTimerResolution; auto refStartTime = static_cast(timestamp.GlobalStartTS * resolution + (1ULL << gfxCoreHelper.getGlobalTimeStampBits()) * resolution); EXPECT_EQ(start, refStartTime); diff --git a/opencl/test/unit_test/execution_environment/execution_environment_tests.cpp b/opencl/test/unit_test/execution_environment/execution_environment_tests.cpp index 269366b878..5c9ddb595b 100644 --- a/opencl/test/unit_test/execution_environment/execution_environment_tests.cpp +++ b/opencl/test/unit_test/execution_environment/execution_environment_tests.cpp @@ -158,7 +158,8 @@ TEST(ExecutionEnvironment, givenExecutionEnvironmentWhenInitializeMemoryManagerI const HardwareInfo *hwInfo = defaultHwInfo.get(); auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(hwInfo)); auto executionEnvironment = device->getExecutionEnvironment(); - auto enableLocalMemory = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily).getEnableLocalMemory(*hwInfo); + auto &gfxCoreHelper = device->getGfxCoreHelper(); + auto enableLocalMemory = gfxCoreHelper.getEnableLocalMemory(*hwInfo); executionEnvironment->initializeMemoryManager(); EXPECT_EQ(enableLocalMemory, executionEnvironment->memoryManager->isLocalMemorySupported(device->getRootDeviceIndex())); } @@ -438,7 +439,7 @@ TEST(ExecutionEnvironment, whenCalculateMaxOsContexCountThenGlobalVariableHasPro for (const auto &rootDeviceEnvironment : executionEnvironment.rootDeviceEnvironments) { auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = rootDeviceEnvironment->getHelper(); auto osContextCount = gfxCoreHelper.getGpgpuEngineInstances(*hwInfo).size(); auto subDevicesCount = GfxCoreHelper::getSubDevicesCount(hwInfo); bool hasRootCsr = subDevicesCount > 1; diff --git a/opencl/test/unit_test/fixtures/ult_command_stream_receiver_fixture.h b/opencl/test/unit_test/fixtures/ult_command_stream_receiver_fixture.h index f8722ac26b..6faff10051 100644 --- a/opencl/test/unit_test/fixtures/ult_command_stream_receiver_fixture.h +++ b/opencl/test/unit_test/fixtures/ult_command_stream_receiver_fixture.h @@ -141,7 +141,7 @@ struct UltCommandStreamReceiverTest commandStreamReceiver.lastPreemptionMode = pDevice->getPreemptionMode(); commandStreamReceiver.setMediaVFEStateDirty(false); auto gmmHelper = pDevice->getGmmHelper(); - auto &gfxCoreHelper = GfxCoreHelper::get(defaultHwInfo->platform.eDisplayCoreFamily); + auto &gfxCoreHelper = pDevice->getGfxCoreHelper(); auto mocsIndex = gfxCoreHelper.getMocsIndex(*gmmHelper, true, isL1CacheEnabled); commandStreamReceiver.latestSentStatelessMocsConfig = mocsIndex; diff --git a/opencl/test/unit_test/gmm_helper/gmm_helper_tests.cpp b/opencl/test/unit_test/gmm_helper/gmm_helper_tests.cpp index 856c34c9f2..4378b1b967 100644 --- a/opencl/test/unit_test/gmm_helper/gmm_helper_tests.cpp +++ b/opencl/test/unit_test/gmm_helper/gmm_helper_tests.cpp @@ -202,7 +202,7 @@ TEST_F(GmmTests, WhenQueryingImgParamsThenCorrectValuesAreReturned) { EXPECT_GT(imgInfo.qPitch, 0u); } - auto &gfxCoreHelper = GfxCoreHelper::get(hwinfo->platform.eRenderCoreFamily); + auto &gfxCoreHelper = this->rootDeviceEnvironment->getHelper(); EXPECT_EQ(queryGmm->resourceParams.Type, GMM_RESOURCE_TYPE::RESOURCE_3D); EXPECT_EQ(queryGmm->resourceParams.NoGfxMemory, 1u); diff --git a/opencl/test/unit_test/kernel/kernel_tests.cpp b/opencl/test/unit_test/kernel/kernel_tests.cpp index c3c1317286..dca59f7d4b 100644 --- a/opencl/test/unit_test/kernel/kernel_tests.cpp +++ b/opencl/test/unit_test/kernel/kernel_tests.cpp @@ -2650,7 +2650,8 @@ TEST(KernelTest, whenNullAllocationThenAssignNullPointerToCacheFlushVector) { TEST(KernelTest, givenKernelCompiledWithSimdSizeLowerThanExpectedWhenInitializingThenReturnError) { auto device = clUniquePtr(new MockClDevice(MockDevice::createWithNewExecutionEnvironment(defaultHwInfo.get()))); - auto minSimd = GfxCoreHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily).getMinimalSIMDSize(); + auto &gfxCoreHelper = device->getGfxCoreHelper(); + auto minSimd = gfxCoreHelper.getMinimalSIMDSize(); MockKernelWithInternals kernel(*device); kernel.kernelInfo.kernelDescriptor.kernelAttributes.simdSize = 8; @@ -2964,7 +2965,7 @@ TEST(KernelTest, whenKernelIsInitializedThenThreadArbitrationPolicyIsSetToDefaul MockKernelWithInternals mockKernelWithInternals{*deviceFactory.rootDevices[0], sPatchExecEnv}; auto &mockKernel = *mockKernelWithInternals.mockKernel; - auto &gfxCoreHelper = GfxCoreHelper::get(deviceFactory.rootDevices[0]->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = deviceFactory.rootDevices[0]->getGfxCoreHelper(); EXPECT_EQ(gfxCoreHelper.getDefaultThreadArbitrationPolicy(), mockKernel.getDescriptor().kernelAttributes.threadArbitrationPolicy); } diff --git a/opencl/test/unit_test/memory_manager/mem_obj_surface_tests.cpp b/opencl/test/unit_test/memory_manager/mem_obj_surface_tests.cpp index 3b4d267096..3ad13938b1 100644 --- a/opencl/test/unit_test/memory_manager/mem_obj_surface_tests.cpp +++ b/opencl/test/unit_test/memory_manager/mem_obj_surface_tests.cpp @@ -44,7 +44,8 @@ HWTEST_F(SurfaceTest, GivenSurfaceWhenInterfaceIsUsedThenSurfaceBehavesCorrectly DeviceBitfield deviceBitfield(1); auto csr = std::make_unique>(execStamp, *executionEnvironment, 0, deviceBitfield); auto hwInfo = *defaultHwInfo; - auto engine = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily).getGpgpuEngineInstances(hwInfo)[0]; + auto &gfxCoreHelper = executionEnvironment->rootDeviceEnvironments[0]->getHelper(); + auto engine = gfxCoreHelper.getGpgpuEngineInstances(hwInfo)[0]; auto osContext = executionEnvironment->memoryManager->createAndRegisterOsContext(csr.get(), EngineDescriptorHelper::getDefaultDescriptor(engine, PreemptionHelper::getDefaultPreemptionMode(hwInfo))); csr->setupContext(*osContext); diff --git a/opencl/test/unit_test/os_interface/device_factory_tests.cpp b/opencl/test/unit_test/os_interface/device_factory_tests.cpp index 1e424f29e4..28cb33fbf2 100644 --- a/opencl/test/unit_test/os_interface/device_factory_tests.cpp +++ b/opencl/test/unit_test/os_interface/device_factory_tests.cpp @@ -204,7 +204,7 @@ TEST_F(DeviceFactoryTest, givenPointerToHwInfoWhenGetDevicedCalledThenRequiedSur ASSERT_TRUE(success); auto hwInfo = executionEnvironment->rootDeviceEnvironments[0]->getHardwareInfo(); - const auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo->platform.eRenderCoreFamily); + const auto &gfxCoreHelper = executionEnvironment->rootDeviceEnvironments[0]->getHelper(); auto expextedSize = static_cast(hwInfo->gtSystemInfo.CsrSizeInMb * MemoryConstants::megaByte); gfxCoreHelper.adjustPreemptionSurfaceSize(expextedSize); diff --git a/opencl/test/unit_test/os_interface/linux/cl_mem_cache_clos_tests_xe_hpc.cpp b/opencl/test/unit_test/os_interface/linux/cl_mem_cache_clos_tests_xe_hpc.cpp index f52be19e48..497c3d042f 100644 --- a/opencl/test/unit_test/os_interface/linux/cl_mem_cache_clos_tests_xe_hpc.cpp +++ b/opencl/test/unit_test/os_interface/linux/cl_mem_cache_clos_tests_xe_hpc.cpp @@ -96,7 +96,7 @@ XE_HPC_CORETEST_F(BuffersWithClMemCacheClosTests, givenDrmBuffersWhenTheyAreCrea cl_mem_alloc_flags_intel allocflags = 0; MemoryProperties memoryProperties = ClMemoryPropertiesHelper::createMemoryProperties(flags, flagsIntel, allocflags, device.get()); - auto &gfxCoreHelper = GfxCoreHelper::get(device->getHardwareInfo().platform.eRenderCoreFamily); + auto &gfxCoreHelper = device->getGfxCoreHelper(); auto numCacheRegions = gfxCoreHelper.getNumCacheRegions(); EXPECT_EQ(3u, numCacheRegions); diff --git a/opencl/test/unit_test/os_interface/windows/wddm20_tests.cpp b/opencl/test/unit_test/os_interface/windows/wddm20_tests.cpp index 7e6c00d45b..0b7ccdbe1e 100644 --- a/opencl/test/unit_test/os_interface/windows/wddm20_tests.cpp +++ b/opencl/test/unit_test/os_interface/windows/wddm20_tests.cpp @@ -657,7 +657,8 @@ struct WddmContextSchedulingPriorityTests : public Wddm20WithMockGdiDllTestsWith wddm->wddmInterface.reset(wddmMockInterface); auto hwInfo = rootDeviceEnvironment->getHardwareInfo(); - auto engine = GfxCoreHelper::get(defaultHwInfo->platform.eRenderCoreFamily).getGpgpuEngineInstances(*hwInfo)[0]; + auto &gfxCoreHelper = rootDeviceEnvironment->getHelper(); + auto engine = gfxCoreHelper.getGpgpuEngineInstances(*hwInfo)[0]; auto engineDescriptor = EngineDescriptorHelper::getDefaultDescriptor(engine, preemptionMode); engineDescriptor.engineTypeUsage.second = lowPriority ? EngineUsage::LowPriority : EngineUsage::Regular; @@ -1534,7 +1535,7 @@ TEST_F(WddmTest, GivenResidencyLoggingEnabledWhenMakeResidentSuccessThenExpectSi uint64_t bytesToTrim = 0; wddm->makeResident(&handle, 1, false, &bytesToTrim, 0x1000); - //2 - one for open log, second for allocation size + // 2 - one for open log, second for allocation size EXPECT_EQ(2u, NEO::IoFunctions::mockVfptrinfCalled); EXPECT_TRUE(logger->makeResidentCall); EXPECT_EQ(MockGdi::pagingFenceReturnValue, logger->makeResidentPagingFence); @@ -1562,7 +1563,7 @@ TEST_F(WddmTest, GivenResidencyLoggingEnabledWhenMakeResidentFailThenExpectTrimR wddm->makeResident(&handle, 1, false, &bytesToTrim, 0x1000); - //3 - one for open log, second for report allocations, 3rd for trim size + // 3 - one for open log, second for report allocations, 3rd for trim size EXPECT_EQ(3u, NEO::IoFunctions::mockVfptrinfCalled); EXPECT_FALSE(logger->makeResidentCall); } @@ -1618,7 +1619,7 @@ TEST_F(WddmTest, GivenResidencyLoggingEnabledWhenMakeResidentAndWaitPagingThenEx uint64_t bytesToTrim = 0; wddm->makeResident(&handle, 1, false, &bytesToTrim, 0x1000); - //2 - one for open log, second for allocation size + // 2 - one for open log, second for allocation size EXPECT_EQ(2u, NEO::IoFunctions::mockVfptrinfCalled); EXPECT_TRUE(logger->makeResidentCall); EXPECT_EQ(MockGdi::pagingFenceReturnValue, logger->makeResidentPagingFence); diff --git a/opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp b/opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp index 74c790306a..ba3540e782 100644 --- a/opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp +++ b/opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp @@ -102,7 +102,7 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, whenQueryingMaxNumSamplersThenRet } XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, GivenBarrierEncodingWhenCallingGetBarriersCountFromHasBarrierThenNumberOfBarriersIsReturned) { - auto &gfxCoreHelper = GfxCoreHelper::get(hardwareInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = getHelper(); EXPECT_EQ(0u, gfxCoreHelper.getBarriersCountFromHasBarriers(0u)); EXPECT_EQ(1u, gfxCoreHelper.getBarriersCountFromHasBarriers(1u)); @@ -649,10 +649,9 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenProgramGlobalFenceAsMiMemFen } XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenGfxCoreHelperWhenGettingThreadsPerEUConfigsThenCorrectConfigsAreReturned) { - auto &helper = GfxCoreHelper::get(pDevice->getHardwareInfo().platform.eRenderCoreFamily); - EXPECT_NE(nullptr, &helper); + auto &gfxCoreHelper = getHelper(); - auto &configs = helper.getThreadsPerEUConfigs(); + auto &configs = gfxCoreHelper.getThreadsPerEUConfigs(); EXPECT_EQ(2U, configs.size()); EXPECT_EQ(4U, configs[0]); @@ -729,7 +728,7 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenBdA0WhenBcsSubDeviceSupportI DebugManagerStateRestore restore; HardwareInfo hwInfo = *defaultHwInfo; - auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = getHelper(); auto productHelper = ProductHelper::get(productFamily); constexpr uint8_t bdRev[4] = {0, 0b111001, 0b101001, 0b000101}; @@ -767,7 +766,7 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenBdA0WhenAllocatingOnNonTileZ DebugManagerStateRestore restore; HardwareInfo hwInfo = *defaultHwInfo; - auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = getHelper(); auto productHelper = ProductHelper::get(productFamily); constexpr uint8_t bdRev[4] = {0, 0b111001, 0b101001, 0b000101}; @@ -809,7 +808,7 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenBdA0WhenAllocatingOnNonTileZ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCommandBufferAllocationWhenSetExtraAllocationDataThenUseSystemLocalMemoryOnlyForImplicitScalingCommandBuffers) { HardwareInfo hwInfo = *defaultHwInfo; - auto &gfxCoreHelper = GfxCoreHelper::get(hwInfo.platform.eRenderCoreFamily); + auto &gfxCoreHelper = getHelper(); constexpr DeviceBitfield singleTileBitfield = 0b0100; constexpr DeviceBitfield allTilesBitfield = 0b1111;