diff --git a/unit_tests/command_queue/enqueue_write_buffer_tests.cpp b/unit_tests/command_queue/enqueue_write_buffer_tests.cpp index 8b2b18f29e..8b24b614e8 100644 --- a/unit_tests/command_queue/enqueue_write_buffer_tests.cpp +++ b/unit_tests/command_queue/enqueue_write_buffer_tests.cpp @@ -23,7 +23,7 @@ using namespace NEO; -HWTEST_F(EnqueueWriteBufferTypeTest, null_mem_object) { +HWTEST_F(EnqueueWriteBufferTypeTest, GivenNullBufferWhenWrtingBufferThenInvalidMemObjectErrorIsReturned) { auto data = 1; auto retVal = clEnqueueWriteBuffer( pCmdQ, @@ -39,7 +39,7 @@ HWTEST_F(EnqueueWriteBufferTypeTest, null_mem_object) { EXPECT_EQ(CL_INVALID_MEM_OBJECT, retVal); } -HWTEST_F(EnqueueWriteBufferTypeTest, null_user_pointer) { +HWTEST_F(EnqueueWriteBufferTypeTest, GivenNullUserPointerWhenWritingBufferThenInvalidValueErrorIsReturned) { auto data = 1; auto retVal = clEnqueueWriteBuffer( @@ -56,7 +56,7 @@ HWTEST_F(EnqueueWriteBufferTypeTest, null_user_pointer) { EXPECT_EQ(CL_INVALID_VALUE, retVal); } -HWTEST_F(EnqueueWriteBufferTypeTest, alignsToCSR_Blocking) { +HWTEST_F(EnqueueWriteBufferTypeTest, GivenBlockingEnqueueWhenWritingBufferThenTaskLevelIsNotIncremented) { //this test case assumes IOQ auto &csr = pDevice->getUltCommandStreamReceiver(); csr.taskCount = pCmdQ->taskCount + 100; @@ -69,7 +69,7 @@ HWTEST_F(EnqueueWriteBufferTypeTest, alignsToCSR_Blocking) { EXPECT_EQ(oldCsrTaskLevel, pCmdQ->taskLevel); } -HWTEST_F(EnqueueWriteBufferTypeTest, alignsToCSR_NonBlocking) { +HWTEST_F(EnqueueWriteBufferTypeTest, GivenNonBlockingEnqueueWhenWritingBufferThenTaskLevelIsIncremented) { //this test case assumes IOQ auto &csr = pDevice->getUltCommandStreamReceiver(); csr.taskCount = pCmdQ->taskCount + 100; @@ -80,7 +80,7 @@ HWTEST_F(EnqueueWriteBufferTypeTest, alignsToCSR_NonBlocking) { EXPECT_EQ(csr.peekTaskLevel(), pCmdQ->taskLevel + 1); } -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, GPGPUWalker) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, WhenWritingBufferThenCommandsAreProgrammedCorrectly) { typedef typename FamilyType::GPGPU_WALKER GPGPU_WALKER; srcBuffer->forceDisallowCPUCopy = true; @@ -113,7 +113,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, GPGPUWalker) { } } -HWTEST_F(EnqueueWriteBufferTypeTest, bumpsTaskLevel) { +HWTEST_F(EnqueueWriteBufferTypeTest, WhenWritingBufferThenTaskLevelIsIncremented) { auto taskLevelBefore = pCmdQ->taskLevel; srcBuffer->forceDisallowCPUCopy = true; @@ -121,7 +121,7 @@ HWTEST_F(EnqueueWriteBufferTypeTest, bumpsTaskLevel) { EXPECT_GT(pCmdQ->taskLevel, taskLevelBefore); } -HWTEST_F(EnqueueWriteBufferTypeTest, addsCommands) { +HWTEST_F(EnqueueWriteBufferTypeTest, WhenWritingBufferThenCommandsAreAdded) { auto usedCmdBufferBefore = pCS->getUsed(); srcBuffer->forceDisallowCPUCopy = true; @@ -129,7 +129,7 @@ HWTEST_F(EnqueueWriteBufferTypeTest, addsCommands) { EXPECT_NE(usedCmdBufferBefore, pCS->getUsed()); } -HWTEST_F(EnqueueWriteBufferTypeTest, addsIndirectData) { +HWTEST_F(EnqueueWriteBufferTypeTest, WhenWritingBufferThenIndirectDataIsAdded) { auto dshBefore = pDSH->getUsed(); auto iohBefore = pIOH->getUsed(); auto sshBefore = pSSH->getUsed(); @@ -159,7 +159,7 @@ HWTEST_F(EnqueueWriteBufferTypeTest, addsIndirectData) { } } -HWTEST_F(EnqueueWriteBufferTypeTest, LoadRegisterImmediateL3CNTLREG) { +HWTEST_F(EnqueueWriteBufferTypeTest, WhenWritingBufferThenL3ProgrammingIsCorrect) { srcBuffer->forceDisallowCPUCopy = true; enqueueWriteBuffer(); validateL3Programming(cmdList, itorWalker); @@ -173,7 +173,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, WhenEnqueueIsDoneThenSta pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, MediaInterfaceDescriptorLoad) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, WhenWritingBufferThenMediaInterfaceDescriptorIsCorrect) { typedef typename FamilyType::MEDIA_INTERFACE_DESCRIPTOR_LOAD MEDIA_INTERFACE_DESCRIPTOR_LOAD; typedef typename FamilyType::INTERFACE_DESCRIPTOR_DATA INTERFACE_DESCRIPTOR_DATA; @@ -202,7 +202,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, MediaInterfaceDescriptor FamilyType::PARSE::template validateCommand(cmdList.begin(), itorCmd); } -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, InterfaceDescriptorData) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, WhenWritingBufferThenInterfaceDescriptorDataIsCorrect) { typedef typename FamilyType::MEDIA_INTERFACE_DESCRIPTOR_LOAD MEDIA_INTERFACE_DESCRIPTOR_LOAD; typedef typename FamilyType::STATE_BASE_ADDRESS STATE_BASE_ADDRESS; typedef typename FamilyType::INTERFACE_DESCRIPTOR_DATA INTERFACE_DESCRIPTOR_DATA; @@ -240,14 +240,14 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, InterfaceDescriptorData) EXPECT_NE(0u, IDD.getConstantIndirectUrbEntryReadLength()); } -HWTEST_F(EnqueueWriteBufferTypeTest, PipelineSelect) { +HWTEST_F(EnqueueWriteBufferTypeTest, WhenWritingBufferThenOnePipelineSelectIsProgrammed) { srcBuffer->forceDisallowCPUCopy = true; enqueueWriteBuffer(); int numCommands = getNumberOfPipelineSelectsThatEnablePipelineSelect(); EXPECT_EQ(1, numCommands); } -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, MediaVFEState) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteBufferTypeTest, WhenWritingBufferThenMediaVfeStateIsCorrect) { srcBuffer->forceDisallowCPUCopy = true; enqueueWriteBuffer(); validateMediaVFEState(&pDevice->getHardwareInfo(), cmdMediaVfeState, cmdList, itorMediaVfeState); diff --git a/unit_tests/command_queue/enqueue_write_image_tests.cpp b/unit_tests/command_queue/enqueue_write_image_tests.cpp index fe24426fd8..33bf8b90cf 100644 --- a/unit_tests/command_queue/enqueue_write_image_tests.cpp +++ b/unit_tests/command_queue/enqueue_write_image_tests.cpp @@ -19,7 +19,7 @@ using namespace NEO; -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, gpgpuWalker) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, WhenWritingImageThenCommandsAreProgrammedCorrectly) { typedef typename FamilyType::GPGPU_WALKER GPGPU_WALKER; enqueueWriteImage(); @@ -50,7 +50,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, gpgpuWalker) { } } -HWTEST_F(EnqueueWriteImageTest, alignsToCSR_Blocking) { +HWTEST_F(EnqueueWriteImageTest, GivenBlockingEnqueueWhenWritingImageThenTaskLevelIsNotIncremented) { //this test case assumes IOQ auto &csr = pDevice->getUltCommandStreamReceiver(); csr.taskCount = pCmdQ->taskCount + 100; @@ -62,7 +62,7 @@ HWTEST_F(EnqueueWriteImageTest, alignsToCSR_Blocking) { EXPECT_EQ(oldCsrTaskLevel, pCmdQ->taskLevel); } -HWTEST_F(EnqueueWriteImageTest, alignsToCSR_NonBlocking) { +HWTEST_F(EnqueueWriteImageTest, GivenNonBlockingEnqueueWhenWritingImageThenTaskLevelIsIncremented) { //this test case assumes IOQ auto &csr = pDevice->getUltCommandStreamReceiver(); csr.taskCount = pCmdQ->taskCount + 100; @@ -73,21 +73,21 @@ HWTEST_F(EnqueueWriteImageTest, alignsToCSR_NonBlocking) { EXPECT_EQ(csr.peekTaskLevel(), pCmdQ->taskLevel + 1); } -HWTEST_F(EnqueueWriteImageTest, bumpsTaskLevel) { +HWTEST_F(EnqueueWriteImageTest, WhenWritingImageThenTaskLevelIsIncremented) { auto taskLevelBefore = pCmdQ->taskLevel; EnqueueWriteImageHelper<>::enqueueWriteImage(pCmdQ, dstImage, EnqueueWriteImageTraits::blocking); EXPECT_GT(pCmdQ->taskLevel, taskLevelBefore); } -HWTEST_F(EnqueueWriteImageTest, addsCommands) { +HWTEST_F(EnqueueWriteImageTest, WhenWritingImageThenCommandsAreAdded) { auto usedCmdBufferBefore = pCS->getUsed(); EnqueueWriteImageHelper<>::enqueueWriteImage(pCmdQ, dstImage, EnqueueWriteImageTraits::blocking); EXPECT_NE(usedCmdBufferBefore, pCS->getUsed()); } -HWTEST_F(EnqueueWriteImageTest, addsIndirectData) { +HWTEST_F(EnqueueWriteImageTest, WhenWritingImageThenIndirectDataIsAdded) { auto dshBefore = pDSH->getUsed(); auto iohBefore = pIOH->getUsed(); auto sshBefore = pSSH->getUsed(); @@ -98,7 +98,7 @@ HWTEST_F(EnqueueWriteImageTest, addsIndirectData) { EXPECT_NE(sshBefore, pSSH->getUsed()); } -HWTEST_F(EnqueueWriteImageTest, loadRegisterImmediateL3CNTLREG) { +HWTEST_F(EnqueueWriteImageTest, WhenWritingImageThenL3ProgrammingIsCorrect) { enqueueWriteImage(); validateL3Programming(cmdList, itorWalker); } @@ -110,7 +110,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, WhenEnqueueIsDoneThenStateBas pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu); } -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, mediaInterfaceDescriptorLoad) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, WhenWritingImageThenMediaInterfaceDescriptorIsCorrect) { typedef typename FamilyType::MEDIA_INTERFACE_DESCRIPTOR_LOAD MEDIA_INTERFACE_DESCRIPTOR_LOAD; typedef typename FamilyType::INTERFACE_DESCRIPTOR_DATA INTERFACE_DESCRIPTOR_DATA; @@ -136,7 +136,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, mediaInterfaceDescriptorLoad) FamilyType::PARSE::template validateCommand(cmdList.begin(), itorMediaInterfaceDescriptorLoad); } -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, interfaceDescriptorData) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, WhenWritingImageThenInterfaceDescriptorDataIsCorrect) { typedef typename FamilyType::STATE_BASE_ADDRESS STATE_BASE_ADDRESS; typedef typename FamilyType::INTERFACE_DESCRIPTOR_DATA INTERFACE_DESCRIPTOR_DATA; @@ -162,7 +162,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, interfaceDescriptorData) { EXPECT_NE(kernelStartPointer, interfaceDescriptorData.getBindingTablePointer()); } -HWTEST_F(EnqueueWriteImageTest, surfaceState) { +HWTEST_F(EnqueueWriteImageTest, WhenWritingImageThenSurfaceStateIsProgrammedCorrectly) { typedef typename FamilyType::RENDER_SURFACE_STATE RENDER_SURFACE_STATE; enqueueWriteImage(); @@ -183,13 +183,13 @@ HWTEST_F(EnqueueWriteImageTest, surfaceState) { EXPECT_EQ(dstImage->getGraphicsAllocation()->getGpuAddress(), surfaceState.getSurfaceBaseAddress()); } -HWTEST_F(EnqueueWriteImageTest, pipelineSelect) { +HWTEST_F(EnqueueWriteImageTest, WhenWritingImageThenOnePipelineSelectIsProgrammed) { enqueueWriteImage(); int numCommands = getNumberOfPipelineSelectsThatEnablePipelineSelect(); EXPECT_EQ(1, numCommands); } -HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, mediaVFEState) { +HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueWriteImageTest, WhenWritingImageThenMediaVfeStateIsCorrect) { enqueueWriteImage(); validateMediaVFEState(&pDevice->getHardwareInfo(), cmdMediaVfeState, cmdList, itorMediaVfeState); }