From 0bc5eead84618492f27c2633271f82a97c3afdf0 Mon Sep 17 00:00:00 2001 From: Lukasz Jobczyk Date: Thu, 22 Jun 2023 13:04:04 +0000 Subject: [PATCH] fix: Remove not needed BCS split helper Signed-off-by: Lukasz Jobczyk --- level_zero/core/source/helpers/api_specific_config_l0.cpp | 4 ---- .../sources/helper/api_specific_config_l0_tests.cpp | 4 ---- opencl/source/helpers/api_specific_config_ocl.cpp | 4 ---- .../test/unit_test/helpers/api_specific_config_ocl_tests.cpp | 4 ---- shared/source/device/device.cpp | 1 - shared/source/helpers/api_specific_config.h | 1 - shared/test/unit_test/ult_specific_config.cpp | 3 --- 7 files changed, 21 deletions(-) diff --git a/level_zero/core/source/helpers/api_specific_config_l0.cpp b/level_zero/core/source/helpers/api_specific_config_l0.cpp index 0c0ffd8209..83e75ee53a 100644 --- a/level_zero/core/source/helpers/api_specific_config_l0.cpp +++ b/level_zero/core/source/helpers/api_specific_config_l0.cpp @@ -15,10 +15,6 @@ bool ApiSpecificConfig::isStatelessCompressionSupported() { return false; } -bool ApiSpecificConfig::isBcsSplitWaSupported() { - return true; -} - bool ApiSpecificConfig::getGlobalBindlessHeapConfiguration() { return DebugManager.flags.UseExternalAllocatorForSshAndDsh.get(); } diff --git a/level_zero/core/test/unit_tests/sources/helper/api_specific_config_l0_tests.cpp b/level_zero/core/test/unit_tests/sources/helper/api_specific_config_l0_tests.cpp index 5ec5a00eef..bbd2acb0bc 100644 --- a/level_zero/core/test/unit_tests/sources/helper/api_specific_config_l0_tests.cpp +++ b/level_zero/core/test/unit_tests/sources/helper/api_specific_config_l0_tests.cpp @@ -31,10 +31,6 @@ TEST(ApiSpecificConfigL0Tests, WhenCheckingIfStatelessCompressionIsSupportedThen EXPECT_FALSE(ApiSpecificConfig::isStatelessCompressionSupported()); } -TEST(ApiSpecificConfigL0Tests, WhenCheckingIfBcsSplitWaIsSupportedThenReturnTrue) { - EXPECT_TRUE(ApiSpecificConfig::isBcsSplitWaSupported()); -} - TEST(ApiSpecificConfigL0Tests, givenMaxAllocSizeWhenGettingReducedMaxAllocSizeThenReturnSameValue) { EXPECT_EQ(1024u, ApiSpecificConfig::getReducedMaxAllocSize(1024)); } diff --git a/opencl/source/helpers/api_specific_config_ocl.cpp b/opencl/source/helpers/api_specific_config_ocl.cpp index e4c836273d..917f4ec57e 100644 --- a/opencl/source/helpers/api_specific_config_ocl.cpp +++ b/opencl/source/helpers/api_specific_config_ocl.cpp @@ -15,10 +15,6 @@ bool ApiSpecificConfig::isStatelessCompressionSupported() { return true; } -bool ApiSpecificConfig::isBcsSplitWaSupported() { - return true; -} - bool ApiSpecificConfig::getGlobalBindlessHeapConfiguration() { return false; } diff --git a/opencl/test/unit_test/helpers/api_specific_config_ocl_tests.cpp b/opencl/test/unit_test/helpers/api_specific_config_ocl_tests.cpp index aae4a6373b..55b29bcdf1 100644 --- a/opencl/test/unit_test/helpers/api_specific_config_ocl_tests.cpp +++ b/opencl/test/unit_test/helpers/api_specific_config_ocl_tests.cpp @@ -33,10 +33,6 @@ TEST(ApiSpecificConfigOclTests, WhenCheckingIfStatelessCompressionIsSupportedThe EXPECT_TRUE(ApiSpecificConfig::isStatelessCompressionSupported()); } -TEST(ApiSpecificConfigOclTests, WhenCheckingIfBcsSplitWaIsSupportedThenReturnTrue) { - EXPECT_TRUE(ApiSpecificConfig::isBcsSplitWaSupported()); -} - TEST(ApiSpecificConfigOclTests, givenMaxAllocSizeWhenGettingReducedMaxAllocSizeThenReturnHalfOfThat) { EXPECT_EQ(512u, ApiSpecificConfig::getReducedMaxAllocSize(1024)); } diff --git a/shared/source/device/device.cpp b/shared/source/device/device.cpp index 2fe070d00b..f2313ad654 100644 --- a/shared/source/device/device.cpp +++ b/shared/source/device/device.cpp @@ -438,7 +438,6 @@ uint64_t Device::getProfilingTimerClock() { bool Device::isBcsSplitSupported() { auto &productHelper = getProductHelper(); auto bcsSplit = productHelper.isBlitSplitEnqueueWARequired(getHardwareInfo()) && - ApiSpecificConfig::isBcsSplitWaSupported() && Device::isBlitSplitEnabled(); if (DebugManager.flags.SplitBcsCopy.get() != -1) { diff --git a/shared/source/helpers/api_specific_config.h b/shared/source/helpers/api_specific_config.h index 2801e4cb69..a099ebf10a 100644 --- a/shared/source/helpers/api_specific_config.h +++ b/shared/source/helpers/api_specific_config.h @@ -14,7 +14,6 @@ struct ApiSpecificConfig { enum ApiType { OCL, L0 }; static bool isStatelessCompressionSupported(); - static bool isBcsSplitWaSupported(); static bool getGlobalBindlessHeapConfiguration(); static bool getBindlessMode(); static bool isDeviceAllocationCacheEnabled(); diff --git a/shared/test/unit_test/ult_specific_config.cpp b/shared/test/unit_test/ult_specific_config.cpp index 78426d3212..c5aab79c3f 100644 --- a/shared/test/unit_test/ult_specific_config.cpp +++ b/shared/test/unit_test/ult_specific_config.cpp @@ -37,9 +37,6 @@ bool isStatelessCompressionSupportedForUlts = true; bool ApiSpecificConfig::isStatelessCompressionSupported() { return isStatelessCompressionSupportedForUlts; } -bool ApiSpecificConfig::isBcsSplitWaSupported() { - return false; -} bool ApiSpecificConfig::getGlobalBindlessHeapConfiguration() { return DebugManager.flags.UseExternalAllocatorForSshAndDsh.get(); }