From 1284579ff7f569258d1cf815c98f74c292d42b71 Mon Sep 17 00:00:00 2001 From: Mateusz Jablonski Date: Thu, 15 May 2025 11:41:46 +0000 Subject: [PATCH] refactor: remove not needed link to NEO-12901 Related-To: NEO-12901 Signed-off-by: Mateusz Jablonski --- .../test/unit_test/command_queue/command_queue_tests.cpp | 2 +- .../command_stream/command_stream_receiver_hw_2_tests.cpp | 2 +- .../unit_test/helpers/get_info_status_mapper_tests.cpp | 4 ++-- .../unit_test/offline_compiler/offline_linker_tests.cpp | 2 +- shared/source/device_binary_format/elf/elf_encoder.h | 4 ++-- .../device_binary_format_zebin_tests.cpp | 2 +- .../device_binary_format/zebin_decoder_tests.cpp | 2 +- shared/test/unit_test/helpers/app_resource_tests.cpp | 4 ++-- .../unit_test/helpers/gpu_page_fault_helper_tests.cpp | 8 ++++---- shared/test/unit_test/utilities/logger_tests.cpp | 4 ++-- .../unit_test/utilities/software_tags_manager_tests.cpp | 4 ++-- 11 files changed, 19 insertions(+), 19 deletions(-) diff --git a/opencl/test/unit_test/command_queue/command_queue_tests.cpp b/opencl/test/unit_test/command_queue/command_queue_tests.cpp index 965b242734..4be4fb3348 100644 --- a/opencl/test/unit_test/command_queue/command_queue_tests.cpp +++ b/opencl/test/unit_test/command_queue/command_queue_tests.cpp @@ -2022,7 +2022,7 @@ TEST_F(CsrSelectionCommandQueueWithBlitterTests, givenInvalidTransferDirectionWh MockBuffer dstMemObj{dstGraphicsAllocation}; CsrSelectionArgs args{CL_COMMAND_COPY_BUFFER, &srcMemObj, &dstMemObj, 0u, nullptr}; - args.direction = static_cast(0xFF); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + args.direction = static_cast(0xFF); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) EXPECT_ANY_THROW(queue->selectCsrForBuiltinOperation(args)); } diff --git a/opencl/test/unit_test/command_stream/command_stream_receiver_hw_2_tests.cpp b/opencl/test/unit_test/command_stream/command_stream_receiver_hw_2_tests.cpp index f930538099..510c7f0830 100644 --- a/opencl/test/unit_test/command_stream/command_stream_receiver_hw_2_tests.cpp +++ b/opencl/test/unit_test/command_stream/command_stream_receiver_hw_2_tests.cpp @@ -1769,7 +1769,7 @@ HWTEST_F(BcsTests, givenAuxTranslationRequestWhenBlitCalledThenProgramCommandCor HWTEST_F(BcsTests, givenInvalidBlitDirectionWhenConstructPropertiesThenExceptionIsThrow) { auto &csr = pDevice->getUltCommandStreamReceiver(); - EXPECT_THROW(ClBlitProperties::constructProperties(static_cast(7), csr, {}), std::exception); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + EXPECT_THROW(ClBlitProperties::constructProperties(static_cast(7), csr, {}), std::exception); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) } HWTEST_F(BcsTests, givenBlitterDirectSubmissionEnabledWhenProgrammingBlitterThenExpectRingBufferDispatched) { diff --git a/opencl/test/unit_test/helpers/get_info_status_mapper_tests.cpp b/opencl/test/unit_test/helpers/get_info_status_mapper_tests.cpp index d65b16bec5..dbed11c4e6 100644 --- a/opencl/test/unit_test/helpers/get_info_status_mapper_tests.cpp +++ b/opencl/test/unit_test/helpers/get_info_status_mapper_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2020-2024 Intel Corporation + * Copyright (C) 2020-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -21,6 +21,6 @@ TEST(getInfoStatusMapper, GivenValidGetInfoStatusWhenTranslatingThenExpectedClCo } TEST(getInfoStatusMapper, GivenInvalidGetInfoStatusWhenTranslatingThenClInvalidValueIsReturned) { - auto getInfoStatus = changeGetInfoStatusToCLResultType(static_cast(1)); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + auto getInfoStatus = changeGetInfoStatusToCLResultType(static_cast(1)); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) EXPECT_EQ(CL_INVALID_VALUE, getInfoStatus); } diff --git a/opencl/test/unit_test/offline_compiler/offline_linker_tests.cpp b/opencl/test/unit_test/offline_compiler/offline_linker_tests.cpp index ef3a44dae7..53d1267688 100644 --- a/opencl/test/unit_test/offline_compiler/offline_linker_tests.cpp +++ b/opencl/test/unit_test/offline_compiler/offline_linker_tests.cpp @@ -663,7 +663,7 @@ TEST_F(OfflineLinkerTest, GivenHelpRequestWhenExecuteIsInvokedThenHelpIsPrinted) TEST_F(OfflineLinkerTest, GivenInvalidOperationModeWhenExecuteIsInvokedThenErrorIsIssued) { MockOfflineLinker mockOfflineLinker{&mockArgHelper, std::move(mockOclocIgcFacade)}; - mockOfflineLinker.operationMode = static_cast(7); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + mockOfflineLinker.operationMode = static_cast(7); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) StdoutCapture capture; capture.captureStdout(); diff --git a/shared/source/device_binary_format/elf/elf_encoder.h b/shared/source/device_binary_format/elf/elf_encoder.h index c95e4aec36..0e042631cc 100644 --- a/shared/source/device_binary_format/elf/elf_encoder.h +++ b/shared/source/device_binary_format/elf/elf_encoder.h @@ -95,12 +95,12 @@ struct ElfEncoder { template ElfSectionHeader &appendSection(SectionHeaderEnumT sectionType, ConstStringRef sectionLabel, const ArrayRef sectionData) { - return appendSection(static_cast(sectionType), sectionLabel, sectionData); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + return appendSection(static_cast(sectionType), sectionLabel, sectionData); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) } template ElfSectionHeader &appendSection(SectionHeaderEnumT sectionType, ConstStringRef sectionLabel, const std::string §ionData) { - return appendSection(static_cast(sectionType), sectionLabel, // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + return appendSection(static_cast(sectionType), sectionLabel, // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) ArrayRef(reinterpret_cast(sectionData.c_str()), sectionData.size() + 1)); } diff --git a/shared/test/unit_test/device_binary_format/device_binary_format_zebin_tests.cpp b/shared/test/unit_test/device_binary_format/device_binary_format_zebin_tests.cpp index ca873e3c39..8e23ca765f 100644 --- a/shared/test/unit_test/device_binary_format/device_binary_format_zebin_tests.cpp +++ b/shared/test/unit_test/device_binary_format/device_binary_format_zebin_tests.cpp @@ -178,7 +178,7 @@ TEST(UnpackSingleDeviceBinaryZebin, WhenValidBinaryForDifferentDeviceThenUnpacki zebin.machine = static_cast(IGFX_XE2_HPG_CORE); NEO::Zebin::Elf::ZebinTargetFlags targetFlags; targetDevice.productFamily = IGFX_UNKNOWN; - targetDevice.coreFamily = static_cast(zebin.machine + 1); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + targetDevice.coreFamily = static_cast(zebin.machine + 1); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) targetFlags.machineEntryUsesGfxCoreInsteadOfProductFamily = true; zebin.flags = targetFlags.packed; unpackResult = NEO::unpackSingleDeviceBinary(ArrayRef::fromAny(&zebin, 1U), "", targetDevice, unpackErrors, unpackWarnings); diff --git a/shared/test/unit_test/device_binary_format/zebin_decoder_tests.cpp b/shared/test/unit_test/device_binary_format/zebin_decoder_tests.cpp index c05e0fb0af..24236436bb 100644 --- a/shared/test/unit_test/device_binary_format/zebin_decoder_tests.cpp +++ b/shared/test/unit_test/device_binary_format/zebin_decoder_tests.cpp @@ -6557,7 +6557,7 @@ TEST(ValidateTargetDeviceTests, givenMismatechAotConfigWhenValidatingTargetDevic targetDevice.aotConfig.value = 0x00001234; targetDevice.maxPointerSizeInBytes = 8u; - auto mismatchedAotConfig = static_cast(0x00004321); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + auto mismatchedAotConfig = static_cast(0x00004321); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) Zebin::Elf::ZebinTargetFlags targetMetadata; auto res = validateTargetDevice(targetDevice, Zebin::Elf::EI_CLASS_64, productFamily, renderCoreFamily, mismatchedAotConfig, targetMetadata); EXPECT_FALSE(res); diff --git a/shared/test/unit_test/helpers/app_resource_tests.cpp b/shared/test/unit_test/helpers/app_resource_tests.cpp index 95999e73e2..66452ea182 100644 --- a/shared/test/unit_test/helpers/app_resource_tests.cpp +++ b/shared/test/unit_test/helpers/app_resource_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2021-2024 Intel Corporation + * Copyright (C) 2021-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -32,7 +32,7 @@ struct AppResourceTests : public MockExecutionEnvironmentTagTest { }; TEST_F(AppResourceTests, givenIncorrectGraphicsAllocationTypeWhenGettingResourceTagThenNOTFOUNDIsReturned) { - auto tag = AppResourceHelper::getResourceTagStr(static_cast(999)); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + auto tag = AppResourceHelper::getResourceTagStr(static_cast(999)); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) EXPECT_STREQ(tag, "NOTFOUND"); } diff --git a/shared/test/unit_test/helpers/gpu_page_fault_helper_tests.cpp b/shared/test/unit_test/helpers/gpu_page_fault_helper_tests.cpp index fdf07cc34c..089ace6ea8 100644 --- a/shared/test/unit_test/helpers/gpu_page_fault_helper_tests.cpp +++ b/shared/test/unit_test/helpers/gpu_page_fault_helper_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2024 Intel Corporation + * Copyright (C) 2024-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -14,14 +14,14 @@ TEST(GpuPageFaultHelperTest, givenValidAndInvalidFaultTypesWhenGettingStringRepr EXPECT_EQ(std::string{"NotPresent"}, GpuPageFaultHelpers::faultTypeToString(FaultType::notPresent)); EXPECT_EQ(std::string{"WriteAccessViolation"}, GpuPageFaultHelpers::faultTypeToString(FaultType::writeAccessViolation)); EXPECT_EQ(std::string{"AtomicAccessViolation"}, GpuPageFaultHelpers::faultTypeToString(FaultType::atomicAccessViolation)); - EXPECT_EQ(std::string{"Unknown"}, GpuPageFaultHelpers::faultTypeToString(static_cast(0xcc))); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + EXPECT_EQ(std::string{"Unknown"}, GpuPageFaultHelpers::faultTypeToString(static_cast(0xcc))); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) } TEST(GpuPageFaultHelperTest, givenValidAndInvalidFaultAccessesWhenGettingStringRepresentationThenItIsCorrect) { EXPECT_EQ(std::string{"Read"}, GpuPageFaultHelpers::faultAccessToString(FaultAccess::read)); EXPECT_EQ(std::string{"Write"}, GpuPageFaultHelpers::faultAccessToString(FaultAccess::write)); EXPECT_EQ(std::string{"Atomic"}, GpuPageFaultHelpers::faultAccessToString(FaultAccess::atomic)); - EXPECT_EQ(std::string{"Unknown"}, GpuPageFaultHelpers::faultAccessToString(static_cast(0xcc))); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + EXPECT_EQ(std::string{"Unknown"}, GpuPageFaultHelpers::faultAccessToString(static_cast(0xcc))); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) } TEST(GpuPageFaultHelperTest, givenValidAndInvalidFaultLevelWhenGettingStringRepresentationThenItIsCorrect) { @@ -30,5 +30,5 @@ TEST(GpuPageFaultHelperTest, givenValidAndInvalidFaultLevelWhenGettingStringRepr EXPECT_EQ(std::string{"PDP"}, GpuPageFaultHelpers::faultLevelToString(FaultLevel::pdp)); EXPECT_EQ(std::string{"PML4"}, GpuPageFaultHelpers::faultLevelToString(FaultLevel::pml4)); EXPECT_EQ(std::string{"PML5"}, GpuPageFaultHelpers::faultLevelToString(FaultLevel::pml5)); - EXPECT_EQ(std::string{"Unknown"}, GpuPageFaultHelpers::faultLevelToString(static_cast(0xcc))); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + EXPECT_EQ(std::string{"Unknown"}, GpuPageFaultHelpers::faultLevelToString(static_cast(0xcc))); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) } diff --git a/shared/test/unit_test/utilities/logger_tests.cpp b/shared/test/unit_test/utilities/logger_tests.cpp index d3ab0f65fa..f2d9c5667e 100644 --- a/shared/test/unit_test/utilities/logger_tests.cpp +++ b/shared/test/unit_test/utilities/logger_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2022-2024 Intel Corporation + * Copyright (C) 2022-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -511,7 +511,7 @@ TEST(AllocationTypeLoggingSingle, givenGraphicsAllocationTypeWhenConvertingToStr DebugVariables flags; FullyEnabledFileLogger fileLogger(testFile, flags); - GraphicsAllocation graphicsAllocation(0, 1u /*num gmms*/, static_cast(999), nullptr, 0, 0, MemoryPool::memoryNull, MemoryManager::maxOsContextCount, 0llu); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + GraphicsAllocation graphicsAllocation(0, 1u /*num gmms*/, static_cast(999), nullptr, 0, 0, MemoryPool::memoryNull, MemoryManager::maxOsContextCount, 0llu); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) auto result = getAllocationTypeString(&graphicsAllocation); diff --git a/shared/test/unit_test/utilities/software_tags_manager_tests.cpp b/shared/test/unit_test/utilities/software_tags_manager_tests.cpp index 7545f07580..1d28649803 100644 --- a/shared/test/unit_test/utilities/software_tags_manager_tests.cpp +++ b/shared/test/unit_test/utilities/software_tags_manager_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2021-2024 Intel Corporation + * Copyright (C) 2021-2025 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -239,7 +239,7 @@ TEST_P(SoftwareTagsParametrizedTests, whenGetOpCodeIsCalledThenCorrectValueIsRet } TEST(SoftwareTagsTests, whenGetMarkerNoopIDCalledThenCorectValueIsReturned) { - uint32_t id = SWTags::BaseTag::getMarkerNoopID(static_cast(testOpCode)); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange), NEO-12901 + uint32_t id = SWTags::BaseTag::getMarkerNoopID(static_cast(testOpCode)); // NOLINT(clang-analyzer-optin.core.EnumCastOutOfRange) EXPECT_EQ(testOpCode, id); }