fix: Change default value of EnableCpuCacheForResources debug toggle

This change disables CPU caching for resources
not accessed by CPU for MTL devices.

Related-To: NEO-7194

Signed-off-by: Filip Hazubski <filip.hazubski@intel.com>
This commit is contained in:
Filip Hazubski
2023-07-30 22:29:35 +00:00
committed by Compute-Runtime-Automation
parent 7ea22d0369
commit 12af65a970
7 changed files with 18 additions and 2 deletions

View File

@@ -30,6 +30,7 @@ struct ApiFixture {
void setUp() {
DebugManager.flags.CreateMultipleRootDevices.set(numRootDevices);
DebugManager.flags.EnableCpuCacheForResources.set(true);
executionEnvironment = new ClExecutionEnvironment();
prepareDeviceEnvironments(*executionEnvironment);
for (auto i = 0u; i < executionEnvironment->rootDeviceEnvironments.size(); i++) {

View File

@@ -601,6 +601,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, givenEnqueueReadBufferCalledWhenLockedPtrInT
HWTEST_F(EnqueueReadBufferTypeTest, givenForcedCpuCopyWhenEnqueueReadCompressedBufferThenDontCopyOnCpu) {
DebugManagerStateRestore dbgRestore;
DebugManager.flags.DoCpuCopyOnReadBuffer.set(1);
DebugManager.flags.EnableCpuCacheForResources.set(true);
DebugManager.flags.ForceLocalMemoryAccessMode.set(static_cast<int32_t>(LocalMemoryAccessMode::Default));
MockExecutionEnvironment executionEnvironment(defaultHwInfo.get());

View File

@@ -430,6 +430,7 @@ HWTEST_F(EnqueueWriteBufferTypeTest, givenEnqueueWriteBufferCalledWhenLockedPtrI
HWTEST_F(EnqueueWriteBufferTypeTest, givenForcedCpuCopyWhenEnqueueWriteCompressedBufferThenDontCopyOnCpu) {
DebugManagerStateRestore dbgRestore;
DebugManager.flags.DoCpuCopyOnWriteBuffer.set(1);
DebugManager.flags.EnableCpuCacheForResources.set(true);
DebugManager.flags.ForceLocalMemoryAccessMode.set(static_cast<int32_t>(LocalMemoryAccessMode::Default));
MockExecutionEnvironment executionEnvironment(defaultHwInfo.get());

View File

@@ -21,6 +21,7 @@ typedef EnqueueReadBufferTypeTest ReadWriteBufferCpuCopyTest;
HWTEST_F(ReadWriteBufferCpuCopyTest, givenCompressedGmmWhenAskingForCpuOperationThenDisallow) {
DebugManagerStateRestore restorer;
DebugManager.flags.EnableCpuCacheForResources.set(true);
DebugManager.flags.ForceLocalMemoryAccessMode.set(static_cast<int32_t>(LocalMemoryAccessMode::Default));
cl_int retVal;
auto rootDeviceIndex = context->getDevice(0)->getRootDeviceIndex();

View File

@@ -309,6 +309,9 @@ TEST(MemObj, givenTiledObjectWhenAskedForCpuMappingThenReturnFalse) {
}
TEST(MemObj, givenCompressedGmmWhenAskingForMappingOnCpuThenDisallow) {
DebugManagerStateRestore restore;
DebugManager.flags.EnableCpuCacheForResources.set(true);
MockContext context;
MockMemoryManager memoryManager(*context.getDevice(0)->getExecutionEnvironment());
@@ -327,6 +330,9 @@ TEST(MemObj, givenCompressedGmmWhenAskingForMappingOnCpuThenDisallow) {
}
TEST(MemObj, givenDefaultWhenAskedForCpuMappingThenReturnTrue) {
DebugManagerStateRestore restore;
DebugManager.flags.EnableCpuCacheForResources.set(true);
MockContext context;
MockMemoryManager memoryManager(*context.getDevice(0)->getExecutionEnvironment());
@@ -347,6 +353,9 @@ struct MyMockGmm : Gmm {
using Gmm::preferNoCpuAccess;
};
TEST(MemObj, givenCpuAccessNotAllowedWhenAskedForCpuMappingThenReturnFalse) {
DebugManagerStateRestore dbgRestore;
DebugManager.flags.EnableCpuCacheForResources.set(true);
MockContext context;
MockMemoryManager memoryManager(*context.getDevice(0)->getExecutionEnvironment());
@@ -364,6 +373,9 @@ TEST(MemObj, givenCpuAccessNotAllowedWhenAskedForCpuMappingThenReturnFalse) {
}
TEST(MemObj, givenNonCpuAccessibleMemoryWhenAskingForMappingOnCpuThenDisallow) {
DebugManagerStateRestore restore;
DebugManager.flags.EnableCpuCacheForResources.set(true);
MockContext context;
MockMemoryManager memoryManager(*context.getDevice(0)->getExecutionEnvironment());