intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-11 16:45:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add support for pci_ext_properties_t

Browse Source 
Added API definition in ze_device.cpp, and added function declaration of
getPciProperties() in device.h and device_imp.cpp
Initially returns -1 for all values of ze_pci_speed_ext_t for now, simply
because we do not have function to retrieve the information of the PCI
speed.

Related-To: LOCI-2669
Signed-off-by: Young Jin Yoon <young.jin.yoon@intel.com>
This commit is contained in:
Young Jin Yoon
2021-12-21 08:55:09 +00:00
committed by Compute-Runtime-Automation
parent ade43e29a5
commit 32ccf30c61
8 changed files with 94 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
level_zero/core/test/unit_tests/mocks/mock_device.h
View File

@@ -1,5 +1,5 @@
/*
* Copyright (C) 2020-2021 Intel Corporation
* Copyright (C) 2020-2022 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@@ -40,6 +40,7 @@ struct Mock<Device> : public Device {
ADDMETHOD_NOBASE(getComputeProperties, ze_result_t, ZE_RESULT_SUCCESS, (ze_device_compute_properties_t * pComputeProperties));
ADDMETHOD_NOBASE(getP2PProperties, ze_result_t, ZE_RESULT_SUCCESS, (ze_device_handle_t hPeerDevice, ze_device_p2p_properties_t *pP2PProperties));
ADDMETHOD_NOBASE(getKernelProperties, ze_result_t, ZE_RESULT_SUCCESS, (ze_device_module_properties_t * pKernelProperties));
ADDMETHOD_NOBASE(getPciProperties, ze_result_t, ZE_RESULT_SUCCESS, (ze_pci_ext_properties_t * pPciProperties));
ADDMETHOD_NOBASE(getMemoryProperties, ze_result_t, ZE_RESULT_SUCCESS, (uint32_t * pCount, ze_device_memory_properties_t *pMemProperties));
ADDMETHOD_NOBASE(getMemoryAccessProperties, ze_result_t, ZE_RESULT_SUCCESS, (ze_device_memory_access_properties_t * pMemAccessProperties));
ADDMETHOD_NOBASE(getProperties, ze_result_t, ZE_RESULT_SUCCESS, (ze_device_properties_t * pDeviceProperties));

51
level_zero/core/test/unit_tests/sources/device/test_device.cpp
View File

@@ -1,5 +1,5 @@
/*
* Copyright (C) 2020-2021 Intel Corporation
* Copyright (C) 2020-2022 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@@ -15,6 +15,7 @@
#include "shared/test/common/helpers/debug_manager_state_restore.h"
#include "shared/test/common/mocks/mock_compilers.h"
#include "shared/test/common/mocks/mock_device.h"
#include "shared/test/common/mocks/mock_driver_info.h"
#include "shared/test/common/mocks/mock_memory_manager.h"
#include "shared/test/common/mocks/mock_sip.h"
#include "shared/test/common/mocks/ult_device_factory.h"
@@ -947,6 +948,54 @@ TEST_F(DeviceTest, givenCallToDevicePropertiesThenTimestampValidBitsAreCorrectly
EXPECT_EQ(32u, deviceProps.kernelTimestampValidBits);
}
TEST_F(DeviceTest, givenNullDriverInfowhenPciPropertiesIsCalledThenUninitializedErrorIsReturned) {
auto deviceImp = static_cast<L0::DeviceImp *>(device);
ze_pci_ext_properties_t pciProperties = {};
deviceImp->driverInfo.reset(nullptr);
ze_result_t res = device->getPciProperties(&pciProperties);
EXPECT_EQ(ZE_RESULT_ERROR_UNINITIALIZED, res);
}
TEST_F(DeviceTest, givenValidPciExtPropertiesWhenPciPropertiesIsCalledThenSuccessIsReturned) {
auto deviceImp = static_cast<L0::DeviceImp *>(device);
const NEO::PhysicalDevicePciBusInfo pciBusInfo(0, 1, 2, 3);
NEO::DriverInfoMock *driverInfo = new DriverInfoMock();
ze_pci_ext_properties_t pciProperties = {};
driverInfo->setPciBusInfo(pciBusInfo);
deviceImp->driverInfo.reset(driverInfo);
ze_result_t res = device->getPciProperties(&pciProperties);
EXPECT_EQ(ZE_RESULT_SUCCESS, res);
EXPECT_EQ(pciBusInfo.pciDomain, pciProperties.address.domain);
EXPECT_EQ(pciBusInfo.pciBus, pciProperties.address.bus);
EXPECT_EQ(pciBusInfo.pciDevice, pciProperties.address.device);
EXPECT_EQ(pciBusInfo.pciFunction, pciProperties.address.function);
}
TEST_F(DeviceTest, givenInvalidPciBusInfoWhenPciPropertiesIsCalledThenUninitializedErrorIsReturned) {
constexpr uint32_t INVALID = NEO::PhysicalDevicePciBusInfo::InvalidValue;
auto deviceImp = static_cast<L0::DeviceImp *>(device);
ze_pci_ext_properties_t pciProperties = {};
std::vector<NEO::PhysicalDevicePciBusInfo> pciBusInfos;
pciBusInfos.push_back(NEO::PhysicalDevicePciBusInfo(0, 1, 2, INVALID));
pciBusInfos.push_back(NEO::PhysicalDevicePciBusInfo(0, 1, INVALID, 3));
pciBusInfos.push_back(NEO::PhysicalDevicePciBusInfo(0, INVALID, 2, 3));
pciBusInfos.push_back(NEO::PhysicalDevicePciBusInfo(INVALID, 1, 2, 3));
for (auto pciBusInfo : pciBusInfos) {
NEO::DriverInfoMock *driverInfo = new DriverInfoMock();
driverInfo->setPciBusInfo(pciBusInfo);
deviceImp->driverInfo.reset(driverInfo);
ze_result_t res = device->getPciProperties(&pciProperties);
EXPECT_EQ(ZE_RESULT_ERROR_UNINITIALIZED, res);
}
}
TEST_F(DeviceTest, whenGetExternalMemoryPropertiesIsCalledThenSuccessIsReturnedAndNoPropertiesAreReturned) {
ze_device_external_memory_properties_t externalMemoryProperties;