intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-12-25 21:42:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not enforce LWS in dec order when smaller than half simd

Browse Source 
When generating work group sizes first try with enforcing decremental
order X >= Y >= Z if generated work group size X * Y * Z is smaller
than half the kernel's SIMD size then generate again without
enforcing decremental order.

Signed-off-by: Krystian Chmielewski <krystian.chmielewski@intel.com>
This commit is contained in:
Krystian Chmielewski
2023-01-03 15:28:59 +00:00
committed by Compute-Runtime-Automation
parent 48247cc42f
commit 3731ee89d8
3 changed files with 117 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
opencl/test/unit_test/command_queue/local_work_size_tests.cpp
View File

@@ -947,3 +947,31 @@ TEST_F(LocalWorkSizeTest, givenMaxWorkgroupSizeEqualToSimdSizeWhenLwsIsCalculate
EXPECT_EQ(workGroupSize[1], 1u);
EXPECT_EQ(workGroupSize[2], 1u);
}
TEST_F(LocalWorkSizeTest, givenGwsWithSmallXAndBigYWhenLwsIsCalculatedThenDescendingOrderIsNotEnforced) {
WorkSizeInfo wsInfo(256u, true, 32u, 0u, rootDeviceEnvironment, 0u, 0u, false, false, false);
uint32_t workDim = 3;
size_t workGroup[3] = {2, 1024, 1};
size_t workGroupSize[3];
NEO::choosePrefferedWorkgroupSize(wsInfo, workGroupSize, workGroup, workDim);
EXPECT_EQ(workGroupSize[0], 2u);
EXPECT_EQ(workGroupSize[1], 128u);
EXPECT_EQ(workGroupSize[2], 1u);
// Enforce strict ratio requirement
wsInfo.yTiledSurfaces = true;
NEO::choosePrefferedWorkgroupSize(wsInfo, workGroupSize, workGroup, workDim);
EXPECT_EQ(workGroupSize[0], 2u);
EXPECT_EQ(workGroupSize[1], 128u);
EXPECT_EQ(workGroupSize[2], 1u);
// Enforce ratio requirement
wsInfo.yTiledSurfaces = false;
wsInfo.slmTotalSize = 128U;
NEO::choosePrefferedWorkgroupSize(wsInfo, workGroupSize, workGroup, workDim);
EXPECT_EQ(workGroupSize[0], 2u);
EXPECT_EQ(workGroupSize[1], 128u);
EXPECT_EQ(workGroupSize[2], 1u);
}