diff --git a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_1.cpp b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_1.cpp index c0f659f01f..d13809daa4 100644 --- a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_1.cpp +++ b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_1.cpp @@ -245,7 +245,7 @@ TEST_F(CommandListCreate, givenInvalidProductFamilyThenReturnsNullPointer) { EXPECT_EQ(nullptr, commandList); } -HWTEST_F(CommandListCreate, whenCommandListIsCreatedThenPCAndStateBaseAddressCmdsAreAddedAndCorrectlyProgrammed) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandListCreate, whenCommandListIsCreatedThenPCAndStateBaseAddressCmdsAreAddedAndCorrectlyProgrammed) { using STATE_BASE_ADDRESS = typename FamilyType::STATE_BASE_ADDRESS; using PIPE_CONTROL = typename FamilyType::PIPE_CONTROL; diff --git a/opencl/test/unit_test/api/cl_mem_locally_uncached_resource_tests.cpp b/opencl/test/unit_test/api/cl_mem_locally_uncached_resource_tests.cpp index eb892ce28c..e5e56ddebc 100644 --- a/opencl/test/unit_test/api/cl_mem_locally_uncached_resource_tests.cpp +++ b/opencl/test/unit_test/api/cl_mem_locally_uncached_resource_tests.cpp @@ -59,7 +59,7 @@ const cl_mem_properties_intel propertiesUncacheableInSurfaceState[] = {CL_MEM_FL using clMemLocallyUncachedResourceFixture = Test>; -HWTEST_F(clMemLocallyUncachedResourceFixture, GivenAtLeastOneLocallyUncacheableResourceWhenSettingKernelArgumentsThenKernelIsUncacheable) { +HWCMDTEST_F(IGFX_GEN8_CORE, clMemLocallyUncachedResourceFixture, GivenAtLeastOneLocallyUncacheableResourceWhenSettingKernelArgumentsThenKernelIsUncacheable) { cl_int retVal = CL_SUCCESS; MockKernelWithInternals mockKernel(*this->pClDevice, context, true); mockKernel.kernelInfo.usesSsh = true; @@ -135,7 +135,7 @@ HWTEST_F(clMemLocallyUncachedResourceFixture, GivenAtLeastOneLocallyUncacheableR EXPECT_FALSE(kernel->hasUncacheableStatelessArgs()); } -HWTEST_F(clMemLocallyUncachedResourceFixture, givenBuffersThatAreUncachedInSurfaceStateWhenStatelessIsProgrammedItIsCached) { +HWCMDTEST_F(IGFX_GEN8_CORE, clMemLocallyUncachedResourceFixture, givenBuffersThatAreUncachedInSurfaceStateWhenStatelessIsProgrammedItIsCached) { cl_int retVal = CL_SUCCESS; MockKernelWithInternals mockKernel(*this->pClDevice, context, true); @@ -210,7 +210,7 @@ HWTEST_F(clMemLocallyUncachedResourceFixture, givenBuffersThatAreUncachedInSurfa EXPECT_EQ(mocsCacheable, cmdQueueMocs(pCmdQ)); } -HWTEST_F(clMemLocallyUncachedResourceFixture, givenBuffersThatAreUncachedButKernelDoesntHaveAnyStatelessAccessessThenSurfacesAreNotRecordedAsUncacheable) { +HWCMDTEST_F(IGFX_GEN8_CORE, clMemLocallyUncachedResourceFixture, givenBuffersThatAreUncachedButKernelDoesntHaveAnyStatelessAccessessThenSurfacesAreNotRecordedAsUncacheable) { cl_int retVal = CL_SUCCESS; MockKernelWithInternals mockKernel(*this->pClDevice, context, true); @@ -290,7 +290,7 @@ HWTEST_F(clMemLocallyUncachedResourceFixture, givenBuffersThatAreUncachedButKern EXPECT_FALSE(kernel->hasUncacheableStatelessArgs()); } -HWTEST_F(clMemLocallyUncachedResourceFixture, WhenUnsettingUncacheableResourceFromKernelThanKernelContinuesToCorrectlySetMocs) { +HWCMDTEST_F(IGFX_GEN8_CORE, clMemLocallyUncachedResourceFixture, WhenUnsettingUncacheableResourceFromKernelThanKernelContinuesToCorrectlySetMocs) { cl_int retVal = CL_SUCCESS; MockKernelWithInternals mockKernel(*this->pClDevice, context, true); auto kernel = mockKernel.mockKernel; @@ -355,7 +355,7 @@ HWTEST_F(clMemLocallyUncachedResourceFixture, WhenUnsettingUncacheableResourceFr EXPECT_EQ(mocsUncacheable, cmdQueueMocs(pCmdQ)); } -HWTEST_F(clMemLocallyUncachedResourceFixture, givenBuffersThatAreUncachedInSurfaceStateAndAreNotUsedInStatelessFashionThenThoseResourcesAreNotRegistredAsResourcesForCacheFlush) { +HWCMDTEST_F(IGFX_GEN8_CORE, clMemLocallyUncachedResourceFixture, givenBuffersThatAreUncachedInSurfaceStateAndAreNotUsedInStatelessFashionThenThoseResourcesAreNotRegistredAsResourcesForCacheFlush) { cl_int retVal = CL_SUCCESS; MockKernelWithInternals mockKernel(*this->pClDevice, context, true); diff --git a/opencl/test/unit_test/built_ins/built_in_tests.cpp b/opencl/test/unit_test/built_ins/built_in_tests.cpp index 6ad5afe490..f7e452a14a 100644 --- a/opencl/test/unit_test/built_ins/built_in_tests.cpp +++ b/opencl/test/unit_test/built_ins/built_in_tests.cpp @@ -455,7 +455,7 @@ HWTEST_F(BuiltInTests, givenKernelWithAuxTranslationRequiredWhenEnqueueCalledThe EXPECT_EQ(1u, mockBuiltinKernel->releaseOwnershipCalls); } -HWTEST_F(BuiltInTests, givenAuxTranslationKernelWhenSettingKernelArgsThenSetValidMocs) { +HWCMDTEST_F(IGFX_GEN8_CORE, BuiltInTests, givenAuxTranslationKernelWhenSettingKernelArgsThenSetValidMocs) { if (this->pDevice->areSharedSystemAllocationsAllowed()) { GTEST_SKIP(); } diff --git a/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_1_tests.cpp b/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_1_tests.cpp index 8260cca06e..616f9dabbb 100644 --- a/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_1_tests.cpp +++ b/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_1_tests.cpp @@ -87,15 +87,15 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, taskCountShouldBeUpdated) { EXPECT_EQ(1u, commandStreamReceiver.peekTaskCount()); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, givenconfigureCSRtoNonDirtyStateWhenFlushTaskIsCalledThenNoCommandsAreAdded) { - configureCSRtoNonDirtyState(); +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, givenconfigureCSRtoNonDirtyStateWhenFlushTaskIsCalledThenNoCommandsAreAdded) { + configureCSRtoNonDirtyState(false); auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); flushTask(commandStreamReceiver); EXPECT_EQ(0u, commandStreamReceiver.commandStream.getUsed()); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, givenMultiOsContextCommandStreamReceiverWhenFlushTaskIsCalledThenCommandStreamReceiverStreamIsUsed) { - configureCSRtoNonDirtyState(); +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, givenMultiOsContextCommandStreamReceiverWhenFlushTaskIsCalledThenCommandStreamReceiverStreamIsUsed) { + configureCSRtoNonDirtyState(false); auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); commandStreamReceiver.multiOsContextCapable = true; commandStream.getSpace(4); @@ -106,12 +106,12 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenMultiOsContextCommandStreamRe EXPECT_NE(nullptr, batchBufferStart); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrInBatchingModeWhenTaskIsSubmittedViaCsrThenBbEndCoversPaddingEnoughToFitMiBatchBufferStart) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, givenCsrInBatchingModeWhenTaskIsSubmittedViaCsrThenBbEndCoversPaddingEnoughToFitMiBatchBufferStart) { auto &mockCsr = pDevice->getUltCommandStreamReceiver(); mockCsr.overrideDispatchPolicy(DispatchMode::BatchedDispatch); mockCsr.timestampPacketWriteEnabled = false; - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); mockCsr.getCS(1024u); auto &csrCommandStream = mockCsr.commandStream; @@ -127,13 +127,14 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrInBatchingModeWhenTaskIsSu EXPECT_EQ(expectedUsedSize, mockCsr.commandStream.getUsed()); } + HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrInBatchingModeWhenTaskIsSubmittedViaCommandStreamThenBbEndCoversPaddingEnoughToFitMiBatchBufferStart) { auto &mockCsr = pDevice->getUltCommandStreamReceiver(); mockCsr.overrideDispatchPolicy(DispatchMode::BatchedDispatch); CommandQueueHw commandQueue(nullptr, pClDevice, 0, false); auto &commandStream = commandQueue.getCS(4096u); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); auto fillSize = MemoryConstants::cacheLineSize - sizeof(typename FamilyType::MI_BATCH_BUFFER_END); commandStream.getSpace(fillSize); @@ -236,11 +237,11 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrInDefaultModeAndMidThreadP EXPECT_TRUE(found); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, sameTaskLevelShouldntSendAPipeControl) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, sameTaskLevelShouldntSendAPipeControl) { auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); // Configure the CSR to not need to submit any state or commands. - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); flushTask(commandStreamReceiver); @@ -250,7 +251,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, sameTaskLevelShouldntSendAPipeCont EXPECT_EQ(sizeUsed, 0u); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, givenDeviceWithThreadGroupPreemptionSupportThenDontSendMediaVfeStateIfNotDirty) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, givenDeviceWithThreadGroupPreemptionSupportThenDontSendMediaVfeStateIfNotDirty) { DebugManagerStateRestore dbgRestore; DebugManager.flags.ForcePreemptionMode.set(static_cast(PreemptionMode::ThreadGroup)); @@ -259,7 +260,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenDeviceWithThreadGroupPreempti pDevice->resetCommandStreamReceiver(commandStreamReceiver); // Configure the CSR to not need to submit any state or commands. - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); flushTask(*commandStreamReceiver); @@ -274,7 +275,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, higherTaskLevelShouldSendAPipeCont commandStreamReceiver.isPreambleSent = true; commandStreamReceiver.timestampPacketWriteEnabled = false; - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); commandStreamReceiver.taskLevel = taskLevel / 2; flushTask(commandStreamReceiver); @@ -288,10 +289,10 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, higherTaskLevelShouldSendAPipeCont EXPECT_NE(cmdList.end(), itorPC); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCommandStreamReceiverWithInstructionCacheRequestWhenFlushTaskIsCalledThenPipeControlWithInstructionCacheIsEmitted) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, givenCommandStreamReceiverWithInstructionCacheRequestWhenFlushTaskIsCalledThenPipeControlWithInstructionCacheIsEmitted) { auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); commandStreamReceiver.registerInstructionCacheFlush(); EXPECT_EQ(1u, commandStreamReceiver.recursiveLockCounter); @@ -307,11 +308,11 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCommandStreamReceiverWithInst EXPECT_FALSE(commandStreamReceiver.requiresInstructionCacheFlush); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, givenHigherTaskLevelWhenTimestampPacketWriteIsEnabledThenDontAddPipeControl) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, givenHigherTaskLevelWhenTimestampPacketWriteIsEnabledThenDontAddPipeControl) { auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); commandStreamReceiver.timestampPacketWriteEnabled = true; commandStreamReceiver.isPreambleSent = true; - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); commandStreamReceiver.taskLevel = taskLevel; taskLevel++; // submit with higher taskLevel @@ -323,14 +324,14 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenHigherTaskLevelWhenTimestampP EXPECT_EQ(cmdList.end(), itorPC); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, WhenForcePipeControlPriorToWalkerIsSetThenAddExtraPipeControls) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, WhenForcePipeControlPriorToWalkerIsSetThenAddExtraPipeControls) { DebugManagerStateRestore stateResore; DebugManager.flags.ForcePipeControlPriorToWalker.set(true); DebugManager.flags.FlushAllCaches.set(true); auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); commandStreamReceiver.isPreambleSent = true; - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); commandStreamReceiver.taskLevel = taskLevel; flushTask(commandStreamReceiver); @@ -380,14 +381,14 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, WhenForcePipeControlPriorToWalkerI EXPECT_EQ(counterPC, 2); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, whenSamplerCacheFlushNotRequiredThenDontSendPipecontrol) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, whenSamplerCacheFlushNotRequiredThenDontSendPipecontrol) { auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); NEO::WorkaroundTable *waTable = &pDevice->getRootDeviceEnvironment().getMutableHardwareInfo()->workaroundTable; commandStreamReceiver.isPreambleSent = true; commandStreamReceiver.lastPreemptionMode = pDevice->getPreemptionMode(); commandStreamReceiver.setSamplerCacheFlushRequired(CommandStreamReceiver::SamplerCacheFlushState::samplerCacheFlushNotRequired); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); commandStreamReceiver.taskLevel = taskLevel; waTable->waSamplerCacheFlushBetweenRedescribedSurfaceReads = true; flushTask(commandStreamReceiver); @@ -405,7 +406,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, whenSamplerCacheFlushBeforeThenSen auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); commandStreamReceiver.isPreambleSent = true; commandStreamReceiver.setSamplerCacheFlushRequired(CommandStreamReceiver::SamplerCacheFlushState::samplerCacheFlushBefore); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); commandStreamReceiver.taskLevel = taskLevel; NEO::WorkaroundTable *waTable = &pDevice->getRootDeviceEnvironment().getMutableHardwareInfo()->workaroundTable; @@ -424,11 +425,11 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, whenSamplerCacheFlushBeforeThenSen EXPECT_TRUE(pipeControlCmd->getTextureCacheInvalidationEnable()); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, whenSamplerCacheFlushBeforeAndWaSamplerCacheFlushBetweenRedescribedSurfaceReadsDasabledThenDontSendPipecontrol) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, whenSamplerCacheFlushBeforeAndWaSamplerCacheFlushBetweenRedescribedSurfaceReadsDasabledThenDontSendPipecontrol) { auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); commandStreamReceiver.isPreambleSent = true; commandStreamReceiver.setSamplerCacheFlushRequired(CommandStreamReceiver::SamplerCacheFlushState::samplerCacheFlushBefore); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); commandStreamReceiver.taskLevel = taskLevel; NEO::WorkaroundTable *waTable = &pDevice->getRootDeviceEnvironment().getMutableHardwareInfo()->workaroundTable; @@ -449,7 +450,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, whenSamplerCacheFlushAfterThenSend auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); commandStreamReceiver.isPreambleSent = true; commandStreamReceiver.setSamplerCacheFlushRequired(CommandStreamReceiver::SamplerCacheFlushState::samplerCacheFlushAfter); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); commandStreamReceiver.taskLevel = taskLevel; NEO::WorkaroundTable *waTable = &pDevice->getRootDeviceEnvironment().getMutableHardwareInfo()->workaroundTable; @@ -498,7 +499,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, stateBaseAddressTracking) { EXPECT_FALSE(commandStreamReceiver.sshState.updateAndCheck(&ssh)); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, stateBaseAddressProgrammingShouldMatchTracking) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, stateBaseAddressProgrammingShouldMatchTracking) { typedef typename FamilyType::STATE_BASE_ADDRESS STATE_BASE_ADDRESS; auto gmmHelper = pDevice->getGmmHelper(); auto stateHeapMocs = gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_STATE_HEAP_BUFFER); @@ -525,7 +526,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, stateBaseAddressProgrammingShouldM HWTEST_F(CommandStreamReceiverFlushTaskTests, givenStateBaseAddressWhenItIsRequiredThenThereIsPipeControlPriorToItWithTextureCacheFlush) { typedef typename FamilyType::STATE_BASE_ADDRESS STATE_BASE_ADDRESS; auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); ioh.replaceBuffer(ptrOffset(ioh.getCpuBase(), +1u), ioh.getMaxAvailableSpace() + MemoryConstants::pageSize * 3); flushTask(commandStreamReceiver); @@ -653,7 +654,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, stateBaseAddressShouldBeSentIfSize HWTEST_F(CommandStreamReceiverFlushTaskTests, givenDshHeapChangeWhenFlushTaskIsCalledThenSbaIsReloaded) { auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); dsh.replaceBuffer(nullptr, 0); flushTask(commandStreamReceiver); @@ -665,7 +666,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenDshHeapChangeWhenFlushTaskIsC HWTEST_F(CommandStreamReceiverFlushTaskTests, givenSshHeapChangeWhenFlushTaskIsCalledThenSbaIsReloaded) { auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); ssh.replaceBuffer(nullptr, 0); flushTask(commandStreamReceiver); @@ -677,7 +678,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenSshHeapChangeWhenFlushTaskIsC HWTEST_F(CommandStreamReceiverFlushTaskTests, givenIohHeapChangeWhenFlushTaskIsCalledThenSbaIsReloaded) { auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); ioh.replaceBuffer(nullptr, 0); flushTask(commandStreamReceiver); @@ -946,14 +947,14 @@ HWTEST_F(CommandStreamReceiverCQFlushTaskTests, getCSShouldReturnACSWithEnoughSi } } -HWTEST_F(CommandStreamReceiverFlushTaskTests, blockingFlushTaskWithOnlyPipeControl) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, blockingFlushTaskWithOnlyPipeControl) { typedef typename FamilyType::PIPE_CONTROL PIPE_CONTROL; CommandQueueHw commandQueue(nullptr, pClDevice, 0, false); auto commandStreamReceiver = new MockCsrHw(*pDevice->executionEnvironment, pDevice->getRootDeviceIndex()); pDevice->resetCommandStreamReceiver(commandStreamReceiver); // Configure the CSR to not need to submit any state or commands - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); // Force a PIPE_CONTROL through a blocking flag auto blocking = true; @@ -993,10 +994,10 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, blockingFlushTaskWithOnlyPipeContr EXPECT_EQ(0u, numberOfPC); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, FlushTaskBlockingHasPipeControlWithDCFlush) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, FlushTaskBlockingHasPipeControlWithDCFlush) { using PIPE_CONTROL = typename FamilyType::PIPE_CONTROL; CommandQueueHw commandQueue(nullptr, pClDevice, 0, false); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); auto &commandStreamReceiver = commandQueue.getGpgpuCommandStreamReceiver(); diff --git a/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_2_tests.cpp b/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_2_tests.cpp index c00e1e2968..f988edbf84 100644 --- a/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_2_tests.cpp +++ b/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_2_tests.cpp @@ -1075,14 +1075,14 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrWhenSamplerCacheFlushSentT EXPECT_EQ(sizeof(typename FamilyType::PIPE_CONTROL), difference); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrInNonDirtyStateWhenflushTaskIsCalledThenNoFlushIsCalled) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, givenCsrInNonDirtyStateWhenflushTaskIsCalledThenNoFlushIsCalled) { CommandQueueHw commandQueue(nullptr, pClDevice, 0, false); auto &commandStream = commandQueue.getCS(4096u); auto mockCsr = new MockCsrHw2(*pDevice->executionEnvironment, pDevice->getRootDeviceIndex()); pDevice->resetCommandStreamReceiver(mockCsr); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); DispatchFlags dispatchFlags = DispatchFlagsHelper::createDefaultDispatchFlags(); dispatchFlags.preemptionMode = PreemptionHelper::getDefaultPreemptionMode(pDevice->getHardwareInfo()); @@ -1099,7 +1099,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrInNonDirtyStateWhenflushTa EXPECT_EQ(0, mockCsr->flushCalledCount); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrInNonDirtyStateAndBatchingModeWhenflushTaskIsCalledWithDisabledPreemptionThenSubmissionIsNotRecorded) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, givenCsrInNonDirtyStateAndBatchingModeWhenflushTaskIsCalledWithDisabledPreemptionThenSubmissionIsNotRecorded) { CommandQueueHw commandQueue(nullptr, pClDevice, 0, false); auto &commandStream = commandQueue.getCS(4096u); @@ -1111,7 +1111,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrInNonDirtyStateAndBatching auto mockedSubmissionsAggregator = new mockSubmissionsAggregator(); mockCsr->overrideSubmissionAggregator(mockedSubmissionsAggregator); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); DispatchFlags dispatchFlags = DispatchFlagsHelper::createDefaultDispatchFlags(); dispatchFlags.preemptionMode = PreemptionHelper::getDefaultPreemptionMode(pDevice->getHardwareInfo()); diff --git a/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_3_tests.cpp b/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_3_tests.cpp index 4abfeb75b2..480bd67d12 100644 --- a/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_3_tests.cpp +++ b/opencl/test/unit_test/command_stream/command_stream_receiver_flush_task_3_tests.cpp @@ -345,7 +345,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrInBatchingModeWhenFlushTas EXPECT_GT(cmdBuffer2->batchBuffer.startOffset, cmdBuffer1->batchBuffer.startOffset); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrInBatchingModeWhenRecordedBatchBufferIsBeingSubmittedThenFlushIsCalledWithRecordedCommandBuffer) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, givenCsrInBatchingModeWhenRecordedBatchBufferIsBeingSubmittedThenFlushIsCalledWithRecordedCommandBuffer) { CommandQueueHw commandQueue(nullptr, pClDevice, 0, false); auto &commandStream = commandQueue.getCS(4096u); @@ -357,7 +357,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrInBatchingModeWhenRecorded auto mockedSubmissionsAggregator = new mockSubmissionsAggregator(); mockCsr->overrideSubmissionAggregator(mockedSubmissionsAggregator); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); DispatchFlags dispatchFlags = DispatchFlagsHelper::createDefaultDispatchFlags(); dispatchFlags.preemptionMode = PreemptionHelper::getDefaultPreemptionMode(pDevice->getHardwareInfo()); dispatchFlags.guardCommandBufferWithPipeControl = true; @@ -435,7 +435,7 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenCsrInBatchingModeWhenBlocking auto mockedSubmissionsAggregator = new mockSubmissionsAggregator(); mockCsr->overrideSubmissionAggregator(mockedSubmissionsAggregator); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); DispatchFlags dispatchFlags = DispatchFlagsHelper::createDefaultDispatchFlags(); dispatchFlags.blocking = true; @@ -467,11 +467,11 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenBufferToFlushWhenFlushTaskCal EXPECT_EQ(1, mockCsr->flushCalledCount); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, givenNothingToFlushWhenFlushTaskCalledThenDontFlushStamp) { +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, givenNothingToFlushWhenFlushTaskCalledThenDontFlushStamp) { auto mockCsr = new MockCsrHw2(*pDevice->executionEnvironment, pDevice->getRootDeviceIndex()); pDevice->resetCommandStreamReceiver(mockCsr); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); EXPECT_EQ(0, mockCsr->flushCalledCount); auto previousFlushStamp = mockCsr->flushStamp->peekStamp(); @@ -1423,8 +1423,9 @@ HWTEST_F(CommandStreamReceiverFlushTaskTests, givenDispatchFlagsWithThrottleSetT EXPECT_EQ(cmdBuffer->batchBuffer.throttle, QueueThrottle::HIGH); } -HWTEST_F(CommandStreamReceiverFlushTaskTests, givenEpilogueRequiredFlagWhenTaskIsSubmittedDirectlyThenItPointsBackToCsr) { - configureCSRtoNonDirtyState(); + +HWCMDTEST_F(IGFX_GEN8_CORE, CommandStreamReceiverFlushTaskTests, givenEpilogueRequiredFlagWhenTaskIsSubmittedDirectlyThenItPointsBackToCsr) { + configureCSRtoNonDirtyState(false); auto &commandStreamReceiver = this->pDevice->getUltCommandStreamReceiver(); DispatchFlags dispatchFlags = DispatchFlagsHelper::createDefaultDispatchFlags(); diff --git a/opencl/test/unit_test/fixtures/ult_command_stream_receiver_fixture.h b/opencl/test/unit_test/fixtures/ult_command_stream_receiver_fixture.h index 832bf37b76..9b78b9791e 100644 --- a/opencl/test/unit_test/fixtures/ult_command_stream_receiver_fixture.h +++ b/opencl/test/unit_test/fixtures/ult_command_stream_receiver_fixture.h @@ -108,7 +108,7 @@ struct UltCommandStreamReceiverTest } template - void configureCSRtoNonDirtyState() { + void configureCSRtoNonDirtyState(bool isL1CacheEnabled) { bool slmUsed = false; if (DebugManager.flags.ForceSLML3Config.get()) { slmUsed = true; @@ -122,7 +122,7 @@ struct UltCommandStreamReceiverTest commandStreamReceiver.lastPreemptionMode = pDevice->getPreemptionMode(); commandStreamReceiver.setMediaVFEStateDirty(false); auto gmmHelper = pDevice->getGmmHelper(); - auto mocsIndex = gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER); + auto mocsIndex = isL1CacheEnabled ? gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER_CONST) : gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER); commandStreamReceiver.latestSentStatelessMocsConfig = mocsIndex >> 1; commandStreamReceiver.lastSentL3Config = L3Config; diff --git a/opencl/test/unit_test/gen12lp/command_stream_receiver_hw_tests_gen12lp.inl b/opencl/test/unit_test/gen12lp/command_stream_receiver_hw_tests_gen12lp.inl index 14ccee4dfe..830e0f6216 100644 --- a/opencl/test/unit_test/gen12lp/command_stream_receiver_hw_tests_gen12lp.inl +++ b/opencl/test/unit_test/gen12lp/command_stream_receiver_hw_tests_gen12lp.inl @@ -58,7 +58,7 @@ using CommandStreamReceiverFlushTaskTests = UltCommandStreamReceiverTest; GEN12LPTEST_F(UltCommandStreamReceiverTest, givenStateBaseAddressWhenItIsRequiredThenThereIsPipeControlPriorToItWithTextureCacheFlushAndHdc) { using STATE_BASE_ADDRESS = typename FamilyType::STATE_BASE_ADDRESS; auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver(); - configureCSRtoNonDirtyState(); + configureCSRtoNonDirtyState(false); ioh.replaceBuffer(ptrOffset(ioh.getCpuBase(), +1u), ioh.getMaxAvailableSpace() + MemoryConstants::pageSize * 3); flushTask(commandStreamReceiver); diff --git a/opencl/test/unit_test/helpers/hw_helper_tests.cpp b/opencl/test/unit_test/helpers/hw_helper_tests.cpp index 1ee359b9d3..0d0e5887f4 100644 --- a/opencl/test/unit_test/helpers/hw_helper_tests.cpp +++ b/opencl/test/unit_test/helpers/hw_helper_tests.cpp @@ -739,7 +739,7 @@ TEST_F(HwHelperTest, givenAUBDumpForceAllToLocalMemoryDebugVarWhenSetThenGetEnab EXPECT_TRUE(helper.getEnableLocalMemory(hardwareInfo)); } -TEST_F(HwHelperTest, givenVariousCachesRequestProperMOCSIndexesAreBeingReturned) { +HWCMDTEST_F(IGFX_GEN8_CORE, HwHelperTest, givenVariousCachesRequestProperMOCSIndexesAreBeingReturned) { auto &helper = HwHelper::get(renderCoreFamily); auto gmmHelper = this->pDevice->getGmmHelper(); auto expectedMocsForL3off = gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER_CACHELINE_MISALIGNED) >> 1; diff --git a/opencl/test/unit_test/mem_obj/buffer_tests.cpp b/opencl/test/unit_test/mem_obj/buffer_tests.cpp index 6fcc156f67..337d9ad399 100644 --- a/opencl/test/unit_test/mem_obj/buffer_tests.cpp +++ b/opencl/test/unit_test/mem_obj/buffer_tests.cpp @@ -1198,7 +1198,7 @@ class BufferTests : public ::testing::Test { typedef BufferTests BufferSetSurfaceTests; -HWTEST_F(BufferSetSurfaceTests, givenBufferSetSurfaceThatMemoryPtrAndSizeIsAlignedToCachelineThenL3CacheShouldBeOn) { +HWCMDTEST_F(IGFX_GEN8_CORE, BufferSetSurfaceTests, givenBufferSetSurfaceThatMemoryPtrAndSizeIsAlignedToCachelineThenL3CacheShouldBeOn) { auto size = MemoryConstants::pageSize; auto ptr = (void *)alignedMalloc(size * 2, MemoryConstants::pageSize); @@ -1505,7 +1505,7 @@ HWTEST_F(BufferSetSurfaceTests, givenAlignedCacheableReadOnlyBufferThenChoseOclB alignedFree(ptr); } -HWTEST_F(BufferSetSurfaceTests, givenAlignedCacheableNonReadOnlyBufferThenChooseOclBufferPolicy) { +HWCMDTEST_F(IGFX_GEN8_CORE, BufferSetSurfaceTests, givenAlignedCacheableNonReadOnlyBufferThenChooseOclBufferPolicy) { MockContext context; const auto size = MemoryConstants::pageSize; const auto ptr = (void *)alignedMalloc(size * 2, MemoryConstants::pageSize); diff --git a/opencl/test/unit_test/mocks/mock_gmm_client_context.cpp b/opencl/test/unit_test/mocks/mock_gmm_client_context.cpp index 67d9bf1b2d..02a88a236f 100644 --- a/opencl/test/unit_test/mocks/mock_gmm_client_context.cpp +++ b/opencl/test/unit_test/mocks/mock_gmm_client_context.cpp @@ -10,4 +10,31 @@ namespace NEO { MockGmmClientContext::MockGmmClientContext(OSInterface *osInterface, HardwareInfo *hwInfo) : MockGmmClientContextBase(osInterface, hwInfo) { } + +MEMORY_OBJECT_CONTROL_STATE MockGmmClientContextBase::cachePolicyGetMemoryObject(GMM_RESOURCE_INFO *pResInfo, GMM_RESOURCE_USAGE_TYPE usage) { + MEMORY_OBJECT_CONTROL_STATE retVal = {}; + memset(&retVal, 0, sizeof(MEMORY_OBJECT_CONTROL_STATE)); + switch (usage) { + case GMM_RESOURCE_USAGE_OCL_INLINE_CONST_HDC: + retVal.DwordValue = 32u; + break; + case GMM_RESOURCE_USAGE_OCL_BUFFER: + retVal.DwordValue = 16u; + break; + case GMM_RESOURCE_USAGE_OCL_BUFFER_CONST: + retVal.DwordValue = 8u; + break; + case GMM_RESOURCE_USAGE_OCL_BUFFER_CACHELINE_MISALIGNED: + retVal.DwordValue = 0u; + break; + case GMM_RESOURCE_USAGE_OCL_STATE_HEAP_BUFFER: + retVal.DwordValue = 2u; + break; + default: + retVal.DwordValue = 4u; + break; + } + return retVal; +} + } // namespace NEO diff --git a/opencl/test/unit_test/mocks/mock_gmm_client_context_base.cpp b/opencl/test/unit_test/mocks/mock_gmm_client_context_base.cpp index 2e32205d63..f6725986ed 100644 --- a/opencl/test/unit_test/mocks/mock_gmm_client_context_base.cpp +++ b/opencl/test/unit_test/mocks/mock_gmm_client_context_base.cpp @@ -9,32 +9,6 @@ namespace NEO { -MEMORY_OBJECT_CONTROL_STATE MockGmmClientContextBase::cachePolicyGetMemoryObject(GMM_RESOURCE_INFO *pResInfo, GMM_RESOURCE_USAGE_TYPE usage) { - MEMORY_OBJECT_CONTROL_STATE retVal = {}; - memset(&retVal, 0, sizeof(MEMORY_OBJECT_CONTROL_STATE)); - switch (usage) { - case GMM_RESOURCE_USAGE_OCL_INLINE_CONST_HDC: - retVal.DwordValue = 32u; - break; - case GMM_RESOURCE_USAGE_OCL_BUFFER: - retVal.DwordValue = 16u; - break; - case GMM_RESOURCE_USAGE_OCL_BUFFER_CONST: - retVal.DwordValue = 8u; - break; - case GMM_RESOURCE_USAGE_OCL_BUFFER_CACHELINE_MISALIGNED: - retVal.DwordValue = 0u; - break; - case GMM_RESOURCE_USAGE_OCL_STATE_HEAP_BUFFER: - retVal.DwordValue = 2u; - break; - default: - retVal.DwordValue = 4u; - break; - } - return retVal; -} - GMM_RESOURCE_INFO *MockGmmClientContextBase::createResInfoObject(GMM_RESCREATE_PARAMS *pCreateParams) { return reinterpret_cast(new char[1]); }