From 5f346b57b0248d0dc77f3635ea8bc398fdb19c83 Mon Sep 17 00:00:00 2001 From: Radoslaw Jablonski Date: Thu, 30 Jan 2025 11:46:20 +0000 Subject: [PATCH] performance: enable Direct Submission on PTL Linux Related-To: NEO-12982 Signed-off-by: Radoslaw Jablonski --- .../source/xe3_core/ptl/os_agnostic_product_helper_ptl.inl | 5 +++++ shared/source/xe3_core/windows/product_helper_ptl.cpp | 5 ----- .../test/unit_test/xe3_core/ptl/product_helper_tests_ptl.cpp | 4 ++++ .../ptl/windows/product_helper_tests_ptl_windows.cpp | 4 ---- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/shared/source/xe3_core/ptl/os_agnostic_product_helper_ptl.inl b/shared/source/xe3_core/ptl/os_agnostic_product_helper_ptl.inl index 58f946d19c..eea467397f 100644 --- a/shared/source/xe3_core/ptl/os_agnostic_product_helper_ptl.inl +++ b/shared/source/xe3_core/ptl/os_agnostic_product_helper_ptl.inl @@ -24,4 +24,9 @@ std::optional ProductHelperHw::getPreferr return GfxMemoryAllocationMethod::allocateByKmd; } +template <> +bool ProductHelperHw::isDirectSubmissionSupported(ReleaseHelper *releaseHelper) const { + return true; +} + } // namespace NEO diff --git a/shared/source/xe3_core/windows/product_helper_ptl.cpp b/shared/source/xe3_core/windows/product_helper_ptl.cpp index 7b01c20eab..bb802f5007 100644 --- a/shared/source/xe3_core/windows/product_helper_ptl.cpp +++ b/shared/source/xe3_core/windows/product_helper_ptl.cpp @@ -19,11 +19,6 @@ constexpr static auto gfxProduct = IGFX_PTL; namespace NEO { -template <> -bool ProductHelperHw::isDirectSubmissionSupported(ReleaseHelper *releaseHelper) const { - return true; -} - template <> bool ProductHelperHw::isResolveDependenciesByPipeControlsSupported(const HardwareInfo &hwInfo, bool isOOQ, TaskCountType queueTaskCount, const CommandStreamReceiver &queueCsr) const { const bool enabled = !isOOQ && queueTaskCount == queueCsr.peekTaskCount() && !queueCsr.directSubmissionRelaxedOrderingEnabled(); diff --git a/shared/test/unit_test/xe3_core/ptl/product_helper_tests_ptl.cpp b/shared/test/unit_test/xe3_core/ptl/product_helper_tests_ptl.cpp index a6f48b5248..5266ac4c19 100644 --- a/shared/test/unit_test/xe3_core/ptl/product_helper_tests_ptl.cpp +++ b/shared/test/unit_test/xe3_core/ptl/product_helper_tests_ptl.cpp @@ -40,3 +40,7 @@ PTLTEST_F(PtlProductHelper, givenCompilerProductHelperWhenGetMidThreadPreemption hwInfo.featureTable.flags.ftrWalkerMTP = true; EXPECT_EQ(wmtpSupported, compilerProductHelper->isMidThreadPreemptionSupported(hwInfo)); } + +PTLTEST_F(PtlProductHelper, givenProductHelperWhenCheckDirectSubmissionSupportedThenTrueIsReturned) { + EXPECT_TRUE(productHelper->isDirectSubmissionSupported(releaseHelper)); +} diff --git a/shared/test/unit_test/xe3_core/ptl/windows/product_helper_tests_ptl_windows.cpp b/shared/test/unit_test/xe3_core/ptl/windows/product_helper_tests_ptl_windows.cpp index 9b26e13087..0d0939d665 100644 --- a/shared/test/unit_test/xe3_core/ptl/windows/product_helper_tests_ptl_windows.cpp +++ b/shared/test/unit_test/xe3_core/ptl/windows/product_helper_tests_ptl_windows.cpp @@ -18,10 +18,6 @@ using namespace NEO; using PtlProductHelperWindows = ProductHelperTest; -PTLTEST_F(PtlProductHelperWindows, givenProductHelperWhenCheckDirectSubmissionSupportedThenTrueIsReturned) { - EXPECT_TRUE(productHelper->isDirectSubmissionSupported(releaseHelper)); -} - PTLTEST_F(PtlProductHelperWindows, givenDebugFlagWhenCheckingIsResolveDependenciesByPipeControlsSupportedThenTheFlagDerivedValueIsReturned) { DebugManagerStateRestore restorer;