intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-09 22:43:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

add pipeline select hw properties support flags

Browse Source 
Related-To: NEO-5019

Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
This commit is contained in:
Zbigniew Zdanowicz
2022-09-12 19:11:56 +00:00
committed by Compute-Runtime-Automation
parent 3ec0ceb2bf
commit 647661e701
36 changed files with 295 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
shared/test/unit_test/command_stream/stream_properties_tests.cpp
View File

@@ -31,4 +31,12 @@ std::vector<StreamProperty *> getAllFrontEndProperties(FrontEndProperties &prope
return allProperties;
}
std::vector<StreamProperty *> getAllPipelineSelectProperties(PipelineSelectProperties &properties) {
std::vector<StreamProperty *> allProperties;
allProperties.push_back(&properties.modeSelected);
allProperties.push_back(&properties.mediaSamplerDopClockGate);
allProperties.push_back(&properties.systolicMode);
return allProperties;
}
} // namespace NEO

68
shared/test/unit_test/command_stream/stream_properties_tests_common.cpp
View File

@@ -22,6 +22,11 @@ struct MockFrontEndProperties : public FrontEndProperties {
using FrontEndProperties::propertiesSupportLoaded;
};
struct MockPipelineSelectProperties : public PipelineSelectProperties {
using PipelineSelectProperties::pipelineSelectPropertiesSupport;
using PipelineSelectProperties::propertiesSupportLoaded;
};
TEST(StreamPropertiesTests, whenPropertyValueIsChangedThenProperStateIsSet) {
NEO::StreamProperty streamProperty;
@@ -191,13 +196,17 @@ void verifyIsDirty() {
}
TEST(StreamPropertiesTests, givenVariousStatesOfStateComputeModePropertiesWhenIsDirtyIsQueriedThenCorrectValueIsReturned) {
verifyIsDirty<StateComputeModeProperties, &getAllStateComputeModeProperties>();
verifyIsDirty<StateComputeModeProperties, getAllStateComputeModeProperties>();
}
TEST(StreamPropertiesTests, givenVariousStatesOfFrontEndPropertiesWhenIsDirtyIsQueriedThenCorrectValueIsReturned) {
verifyIsDirty<FrontEndProperties, getAllFrontEndProperties>();
}
TEST(StreamPropertiesTests, givenVariousStatesOfPipelineSelectPropertiesWhenIsDirtyIsQueriedThenCorrectValueIsReturned) {
verifyIsDirty<PipelineSelectProperties, getAllPipelineSelectProperties>();
}
template <typename PropertiesT, getAllPropertiesFunctionPtr<PropertiesT> getAllProperties>
void verifySettingPropertiesFromOtherStruct() {
PropertiesT propertiesDestination;
@@ -242,6 +251,10 @@ TEST(StreamPropertiesTests, givenOtherFrontEndPropertiesStructWhenSetPropertiesI
verifySettingPropertiesFromOtherStruct<FrontEndProperties, getAllFrontEndProperties>();
}
TEST(StreamPropertiesTests, givenOtherPipelineSelectPropertiesStructWhenSetPropertiesIsCalledThenCorrectValuesAreSet) {
verifySettingPropertiesFromOtherStruct<PipelineSelectProperties, getAllPipelineSelectProperties>();
}
TEST(StreamPropertiesTests, givenSingleDispatchCcsFrontEndPropertyWhenSettingPropertyAndCheckIfSupportedThenExpectCorrectState) {
FrontEndPropertiesSupport fePropertiesSupport{};
auto &hwInfoConfig = *HwInfoConfig::get(defaultHwInfo->platform.eProductFamily);
@@ -269,3 +282,56 @@ TEST(StreamPropertiesTests, givenSingleDispatchCcsFrontEndPropertyWhenSettingPro
EXPECT_TRUE(feProperties.singleSliceDispatchCcsMode.isDirty);
EXPECT_EQ(engineInstancedDevice, feProperties.singleSliceDispatchCcsMode.value);
}
TEST(StreamPropertiesTests, whenSettingPipelineSelectPropertiesThenCorrectValueIsSet) {
StreamProperties properties;
PipelineSelectPropertiesSupport pipelineSelectPropertiesSupport = {};
auto hwInfoConfig = HwInfoConfig::get(defaultHwInfo->platform.eProductFamily);
hwInfoConfig->fillPipelineSelectPropertiesSupportStructure(pipelineSelectPropertiesSupport, *defaultHwInfo);
for (auto modeSelected : ::testing::Bool()) {
for (auto mediaSamplerDopClockGate : ::testing::Bool()) {
for (auto systolicMode : ::testing::Bool()) {
properties.pipelineSelect.setProperties(modeSelected, mediaSamplerDopClockGate, systolicMode, *defaultHwInfo);
if (pipelineSelectPropertiesSupport.modeSelected) {
EXPECT_EQ(modeSelected, properties.pipelineSelect.modeSelected.value);
} else {
EXPECT_EQ(-1, properties.pipelineSelect.modeSelected.value);
}
if (pipelineSelectPropertiesSupport.mediaSamplerDopClockGate) {
EXPECT_EQ(mediaSamplerDopClockGate, properties.pipelineSelect.mediaSamplerDopClockGate.value);
} else {
EXPECT_EQ(-1, properties.pipelineSelect.mediaSamplerDopClockGate.value);
}
if (pipelineSelectPropertiesSupport.systolicMode) {
EXPECT_EQ(systolicMode, properties.pipelineSelect.systolicMode.value);
} else {
EXPECT_EQ(-1, properties.pipelineSelect.systolicMode.value);
}
}
}
}
}
TEST(StreamPropertiesTests, givenModeSelectPipelineSelectPropertyNotSupportedWhenSettingPropertyAndCheckIfDirtyThenExpectCleanState) {
MockPipelineSelectProperties pipeProperties{};
pipeProperties.propertiesSupportLoaded = true;
pipeProperties.pipelineSelectPropertiesSupport.modeSelected = false;
pipeProperties.pipelineSelectPropertiesSupport.mediaSamplerDopClockGate = true;
pipeProperties.pipelineSelectPropertiesSupport.systolicMode = true;
constexpr bool constState = false;
bool changingState = false;
pipeProperties.setProperties(changingState, constState, constState, *defaultHwInfo);
// expect dirty as media and systolic changes from initial registered
EXPECT_TRUE(pipeProperties.isDirty());
changingState = !changingState;
pipeProperties.setProperties(changingState, constState, constState, *defaultHwInfo);
// expect clean as changed modeSelected is not supported
EXPECT_FALSE(pipeProperties.isDirty());
}

4
shared/test/unit_test/command_stream/stream_properties_tests_common.h
View File

@@ -1,5 +1,5 @@
/*
* Copyright (C) 2021 Intel Corporation
* Copyright (C) 2021-2022 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@@ -12,10 +12,12 @@
namespace NEO {
struct FrontEndProperties;
struct PipelineSelectProperties;
struct StateComputeModeProperties;
struct StreamProperty;
std::vector<StreamProperty *> getAllStateComputeModeProperties(StateComputeModeProperties &properties);
std::vector<StreamProperty *> getAllFrontEndProperties(FrontEndProperties &properties);
std::vector<StreamProperty *> getAllPipelineSelectProperties(PipelineSelectProperties &properties);
} // namespace NEO