intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-08 22:12:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory error counter reporting issue

Browse Source 
Buffer allocation of less size to retrieve memory error
count result in failure to get error count.

Add support to igsc interface to get information related to buffer
allocation.

Related-To: LOCI-3667

Signed-off-by: Bellekallu Rajkiran <bellekallu.rajkiran@intel.com>
This commit is contained in:
Bellekallu Rajkiran
2022-11-24 09:23:43 +00:00
committed by Compute-Runtime-Automation
parent d81b0b14a1
commit 6806a0fb36
3 changed files with 102 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

71
level_zero/tools/test/unit_tests/sources/sysman/firmware_util/test_fw_util_helper.cpp
View File

@@ -23,6 +23,7 @@ extern pIgscSetEccConfig setEccConfig;
namespace ult {
std::map<std::string, void *> IFRfuncMap;
constexpr static uint32_t mockMaxTileCount = 2;
int mockDeviceIfrGetStatusExt(struct igsc_device_handle *handle, uint32_t *supportedTests, uint32_t *hwCapabilities, uint32_t *ifrApplied, uint32_t *prevErrors, uint32_t *pendingReset) {
return 0;
@@ -52,6 +53,15 @@ static inline int mockEccConfigSetFailure(struct igsc_device_handle *handle, uin
return -1;
}
static inline int mockCountTiles(struct igsc_device_handle *handle, uint32_t *numOfTiles) {
*numOfTiles = mockMaxTileCount;
return 0;
}
static inline int mockMemoryErrors(struct igsc_device_handle *handle, struct igsc_gfsp_mem_err *tiles) {
return 0;
}
TEST(FwStatusExtTest, GivenIFRWasSetWhenFirmwareUtilChecksIFRThenIFRStatusIsUpdated) {
if (!sysmanUltsEnable) {
@@ -276,5 +286,66 @@ TEST(LinuxFwEccTest, GivenGetProcAddrCallFailsWhenFirmwareUtilChecksEccGetAndSet
delete pFwUtilImp;
}
TEST(FwGetMemErrorCountTest, GivenGetProcAddrCallFailsWhenMemoryErrorCountIsRequestedThenFailureIsReturned) {
if (!sysmanUltsEnable) {
GTEST_SKIP();
}
L0::ult::MockFwUtilOsLibrary::getNonNullProcAddr = false;
FirmwareUtilImp *pFwUtilImp = new FirmwareUtilImp(0, 0, 0, 0);
pFwUtilImp->libraryHandle = static_cast<OsLibrary *>(new MockFwUtilOsLibrary());
zes_ras_error_type_t errorType = ZES_RAS_ERROR_TYPE_CORRECTABLE;
uint32_t subDeviceCount = 1;
uint32_t subDeviceId = 0;
uint64_t errorCount = 0;
auto ret = pFwUtilImp->fwGetMemoryErrorCount(errorType, subDeviceCount, subDeviceId, errorCount);
EXPECT_EQ(ZE_RESULT_ERROR_UNINITIALIZED, ret);
delete pFwUtilImp->libraryHandle;
pFwUtilImp->libraryHandle = nullptr;
delete pFwUtilImp;
}
TEST(FwGetMemErrorCountTest, GivenValidFwUtilMethodWhenMemoryErrorCountIsRequestedThenCorrespondingCallSucceeds) {
if (!sysmanUltsEnable) {
GTEST_SKIP();
}
struct IgscMemErrMockOsLibrary : public OsLibraryUtil {
public:
~IgscMemErrMockOsLibrary() override = default;
void *getProcAddress(const std::string &procName) override {
memErrFuncMap["igsc_gfsp_count_tiles"] = reinterpret_cast<void *>(&mockCountTiles);
memErrFuncMap["igsc_gfsp_memory_errors"] = reinterpret_cast<void *>(&mockMemoryErrors);
auto it = memErrFuncMap.find(procName);
if (memErrFuncMap.end() == it) {
return nullptr;
} else {
return it->second;
}
return nullptr;
}
bool isLoaded() override {
return false;
}
std::map<std::string, void *> memErrFuncMap;
};
FirmwareUtilImp *pFwUtilImp = new FirmwareUtilImp(0, 0, 0, 0);
pFwUtilImp->libraryHandle = static_cast<OsLibrary *>(new IgscMemErrMockOsLibrary());
zes_ras_error_type_t errorType = ZES_RAS_ERROR_TYPE_CORRECTABLE;
uint32_t subDeviceCount = 1;
uint32_t subDeviceId = 0;
uint64_t errorCount = 0;
auto ret = pFwUtilImp->fwGetMemoryErrorCount(errorType, subDeviceCount, subDeviceId, errorCount);
EXPECT_EQ(ZE_RESULT_SUCCESS, ret);
delete pFwUtilImp->libraryHandle;
pFwUtilImp->libraryHandle = nullptr;
delete pFwUtilImp;
}
} // namespace ult
} // namespace L0