refactor: remove not needed function - isDotIntegerProductExtensionSupported

the function always returns true Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2026-01-12 17:33:00 +08:00 · 2025-10-02 13:41:33 +00:00
parent e9af7aee15
commit 69eeaee0eb
22 changed files with 51 additions and 105 deletions
--- a/shared/source/compiler_interface/oclc_extensions.cpp
+++ b/shared/source/compiler_interface/oclc_extensions.cpp
@@ -102,13 +102,11 @@ void getOpenclCFeaturesList(const HardwareInfo &hwInfo, OpenClCFeaturesContainer
        strcpy_s(openClCFeature.name, CL_NAME_VERSION_MAX_NAME_SIZE, "__opencl_c_ext_fp64_local_atomic_min_max");
        openclCFeatures.push_back(openClCFeature);
    }
-    if (compilerProductHelper.isDotIntegerProductExtensionSupported()) {
-        strcpy_s(openClCFeature.name, CL_NAME_VERSION_MAX_NAME_SIZE, "__opencl_c_integer_dot_product_input_4x8bit");
-        openclCFeatures.push_back(openClCFeature);
+    strcpy_s(openClCFeature.name, CL_NAME_VERSION_MAX_NAME_SIZE, "__opencl_c_integer_dot_product_input_4x8bit");
+    openclCFeatures.push_back(openClCFeature);

-        strcpy_s(openClCFeature.name, CL_NAME_VERSION_MAX_NAME_SIZE, "__opencl_c_integer_dot_product_input_4x8bit_packed");
-        openclCFeatures.push_back(openClCFeature);
-    }
+    strcpy_s(openClCFeature.name, CL_NAME_VERSION_MAX_NAME_SIZE, "__opencl_c_integer_dot_product_input_4x8bit_packed");
+    openclCFeatures.push_back(openClCFeature);
    getOpenclCFeaturesListExtra(releaseHelper, openclCFeatures);
 }

--- a/shared/source/gen12lp/enable_compiler_product_helper_adln.cpp
+++ b/shared/source/gen12lp/enable_compiler_product_helper_adln.cpp
@@ -12,7 +12,6 @@
 #include "shared/source/helpers/compiler_product_helper_before_xe_hpc.inl"
 #include "shared/source/helpers/compiler_product_helper_enable_subgroup_local_block_io.inl"
 #include "shared/source/helpers/compiler_product_helper_product_config_default.inl"
-#include "shared/source/helpers/compiler_product_helper_tgllp_and_later.inl"

 #include "compiler_product_helper_adln.inl"
 #include "neo_aot_platforms.h"
--- a/shared/source/gen12lp/enable_compiler_product_helper_adlp.cpp
+++ b/shared/source/gen12lp/enable_compiler_product_helper_adlp.cpp
@@ -12,7 +12,6 @@
 #include "shared/source/helpers/compiler_product_helper_before_xe_hpc.inl"
 #include "shared/source/helpers/compiler_product_helper_enable_subgroup_local_block_io.inl"
 #include "shared/source/helpers/compiler_product_helper_product_config_default.inl"
-#include "shared/source/helpers/compiler_product_helper_tgllp_and_later.inl"

 #include "compiler_product_helper_adlp.inl"
 #include "neo_aot_platforms.h"
--- a/shared/source/gen12lp/enable_compiler_product_helper_adls.cpp
+++ b/shared/source/gen12lp/enable_compiler_product_helper_adls.cpp
@@ -12,7 +12,6 @@
 #include "shared/source/helpers/compiler_product_helper_before_xe_hpc.inl"
 #include "shared/source/helpers/compiler_product_helper_enable_subgroup_local_block_io.inl"
 #include "shared/source/helpers/compiler_product_helper_product_config_default.inl"
-#include "shared/source/helpers/compiler_product_helper_tgllp_and_later.inl"

 #include "neo_aot_platforms.h"

--- a/shared/source/gen12lp/enable_compiler_product_helper_dg1.cpp
+++ b/shared/source/gen12lp/enable_compiler_product_helper_dg1.cpp
@@ -12,7 +12,6 @@
 #include "shared/source/helpers/compiler_product_helper_before_xe_hpc.inl"
 #include "shared/source/helpers/compiler_product_helper_enable_subgroup_local_block_io.inl"
 #include "shared/source/helpers/compiler_product_helper_product_config_default.inl"
-#include "shared/source/helpers/compiler_product_helper_tgllp_and_later.inl"

 #include "neo_aot_platforms.h"

--- a/shared/source/gen12lp/enable_compiler_product_helper_rkl.cpp
+++ b/shared/source/gen12lp/enable_compiler_product_helper_rkl.cpp
@@ -12,7 +12,6 @@
 #include "shared/source/helpers/compiler_product_helper_before_xe_hpc.inl"
 #include "shared/source/helpers/compiler_product_helper_enable_subgroup_local_block_io.inl"
 #include "shared/source/helpers/compiler_product_helper_product_config_default.inl"
-#include "shared/source/helpers/compiler_product_helper_tgllp_and_later.inl"

 #include "neo_aot_platforms.h"

--- a/shared/source/gen12lp/enable_compiler_product_helper_tgllp.cpp
+++ b/shared/source/gen12lp/enable_compiler_product_helper_tgllp.cpp
@@ -12,7 +12,6 @@
 #include "shared/source/helpers/compiler_product_helper_before_xe_hpc.inl"
 #include "shared/source/helpers/compiler_product_helper_enable_subgroup_local_block_io.inl"
 #include "shared/source/helpers/compiler_product_helper_product_config_default.inl"
-#include "shared/source/helpers/compiler_product_helper_tgllp_and_later.inl"

 #include "neo_aot_platforms.h"

--- a/shared/source/helpers/CMakeLists.txt
+++ b/shared/source/helpers/CMakeLists.txt
@@ -47,7 +47,6 @@ set(NEO_CORE_HELPERS
    ${CMAKE_CURRENT_SOURCE_DIR}/compiler_product_helper_disable_subgroup_local_block_io.inl
    ${CMAKE_CURRENT_SOURCE_DIR}/compiler_product_helper_enable_subgroup_local_block_io.inl
    ${CMAKE_CURRENT_SOURCE_DIR}/compiler_product_helper_product_config_default.inl
-    ${CMAKE_CURRENT_SOURCE_DIR}/compiler_product_helper_tgllp_and_later.inl
    ${CMAKE_CURRENT_SOURCE_DIR}/compiler_product_helper_xe_hp_and_later.inl
    ${CMAKE_CURRENT_SOURCE_DIR}/compiler_product_helper_xe_hpc_and_later.inl
    ${CMAKE_CURRENT_SOURCE_DIR}/compiler_options_parser.cpp
--- a/shared/source/helpers/compiler_product_helper.h
+++ b/shared/source/helpers/compiler_product_helper.h
@@ -69,7 +69,6 @@ class CompilerProductHelper {
    virtual bool isSubgroupBufferPrefetchSupported() const = 0;
    virtual bool isForceToStatelessRequired() const = 0;
    virtual bool failBuildProgramWithStatefulAccessPreference() const = 0;
-    virtual bool isDotIntegerProductExtensionSupported() const = 0;
    virtual bool isSpirSupported(const ReleaseHelper *releaseHelper) const = 0;
    virtual bool oclocEnforceZebinFormat() const = 0;
    virtual void setProductConfigForHwInfo(HardwareInfo &hwInfo, HardwareIpVersion config) const = 0;
@@ -125,7 +124,6 @@ class CompilerProductHelperHw : public CompilerProductHelper {
    bool isSubgroupBufferPrefetchSupported() const override;
    bool isForceToStatelessRequired() const override;
    bool failBuildProgramWithStatefulAccessPreference() const override;
-    bool isDotIntegerProductExtensionSupported() const override;
    bool isSpirSupported(const ReleaseHelper *releaseHelper) const override;
    bool oclocEnforceZebinFormat() const override;
    void setProductConfigForHwInfo(HardwareInfo &hwInfo, HardwareIpVersion config) const override;
--- a/shared/source/helpers/compiler_product_helper_base.inl
+++ b/shared/source/helpers/compiler_product_helper_base.inl
@@ -90,7 +90,8 @@ std::string CompilerProductHelperHw<gfxProduct>::getDeviceExtensions(const Hardw
                             "cl_khr_suggested_local_work_size "
                             "cl_intel_split_work_group_barrier "
                             "cl_khr_int64_base_atomics "
-                             "cl_khr_int64_extended_atomics ";
+                             "cl_khr_int64_extended_atomics "
+                             "cl_khr_integer_dot_product ";

    auto supportsFp64 = hwInfo.capabilityTable.ftrSupportsFP64;
    if (debugManager.flags.OverrideDefaultFP64Settings.get() != -1) {
@@ -188,9 +189,6 @@ std::string CompilerProductHelperHw<gfxProduct>::getDeviceExtensions(const Hardw
    if (isSubgroupBufferPrefetchSupported()) {
        extensions += "cl_intel_subgroup_buffer_prefetch ";
    }
-    if (isDotIntegerProductExtensionSupported()) {
-        extensions += "cl_khr_integer_dot_product ";
-    }
    if (isSpirSupported(releaseHelper)) {
        extensions += "cl_khr_spir ";
    }
--- a/shared/source/helpers/compiler_product_helper_tgllp_and_later.inl
+++ b/shared/source/helpers/compiler_product_helper_tgllp_and_later.inl
@@ -1,16 +0,0 @@
-/*
- * Copyright (C) 2023-2025 Intel Corporation
- *
- * SPDX-License-Identifier: MIT
- *
- */
-
-#include "shared/source/helpers/compiler_product_helper.h"
-
-namespace NEO {
-template <PRODUCT_FAMILY gfxProduct>
-bool CompilerProductHelperHw<gfxProduct>::isDotIntegerProductExtensionSupported() const {
-    return true;
-}
-
-} // namespace NEO
--- a/shared/source/xe2_hpg_core/enable_compiler_product_helper_bmg.cpp
+++ b/shared/source/xe2_hpg_core/enable_compiler_product_helper_bmg.cpp
@@ -9,7 +9,6 @@
 #include "shared/source/helpers/compiler_product_helper_base.inl"
 #include "shared/source/helpers/compiler_product_helper_enable_subgroup_local_block_io.inl"
 #include "shared/source/helpers/compiler_product_helper_mtl_and_later.inl"
-#include "shared/source/helpers/compiler_product_helper_tgllp_and_later.inl"
 #include "shared/source/helpers/compiler_product_helper_xe_hp_and_later.inl"
 #include "shared/source/helpers/compiler_product_helper_xe_hpc_and_later.inl"

--- a/shared/source/xe2_hpg_core/enable_compiler_product_helper_lnl.cpp
+++ b/shared/source/xe2_hpg_core/enable_compiler_product_helper_lnl.cpp
@@ -9,7 +9,6 @@
 #include "shared/source/helpers/compiler_product_helper_base.inl"
 #include "shared/source/helpers/compiler_product_helper_enable_subgroup_local_block_io.inl"
 #include "shared/source/helpers/compiler_product_helper_mtl_and_later.inl"
-#include "shared/source/helpers/compiler_product_helper_tgllp_and_later.inl"
 #include "shared/source/helpers/compiler_product_helper_xe_hp_and_later.inl"
 #include "shared/source/helpers/compiler_product_helper_xe_hpc_and_later.inl"

--- a/shared/source/xe3_core/enable_compiler_product_helper_ptl.cpp
+++ b/shared/source/xe3_core/enable_compiler_product_helper_ptl.cpp
@@ -9,7 +9,6 @@
 #include "shared/source/helpers/compiler_product_helper_base.inl"
 #include "shared/source/helpers/compiler_product_helper_enable_subgroup_local_block_io.inl"
 #include "shared/source/helpers/compiler_product_helper_mtl_and_later.inl"
-#include "shared/source/helpers/compiler_product_helper_tgllp_and_later.inl"
 #include "shared/source/helpers/compiler_product_helper_xe_hp_and_later.inl"
 #include "shared/source/helpers/compiler_product_helper_xe_hpc_and_later.inl"

--- a/shared/source/xe_hpc_core/enable_compiler_product_helper_pvc.cpp
+++ b/shared/source/xe_hpc_core/enable_compiler_product_helper_pvc.cpp
@@ -9,7 +9,6 @@
 #include "shared/source/helpers/compiler_product_helper.h"
 #include "shared/source/helpers/compiler_product_helper_base.inl"
 #include "shared/source/helpers/compiler_product_helper_enable_subgroup_local_block_io.inl"
-#include "shared/source/helpers/compiler_product_helper_tgllp_and_later.inl"
 #include "shared/source/helpers/compiler_product_helper_xe_hp_and_later.inl"
 #include "shared/source/helpers/compiler_product_helper_xe_hpc_and_later.inl"
 #include "shared/source/xe_hpc_core/hw_cmds.h"
--- a/shared/source/xe_hpg_core/enable_compiler_product_helper_dg2.cpp
+++ b/shared/source/xe_hpg_core/enable_compiler_product_helper_dg2.cpp
@@ -10,7 +10,6 @@
 #include "shared/source/helpers/compiler_product_helper_base.inl"
 #include "shared/source/helpers/compiler_product_helper_before_xe_hpc.inl"
 #include "shared/source/helpers/compiler_product_helper_enable_subgroup_local_block_io.inl"
-#include "shared/source/helpers/compiler_product_helper_tgllp_and_later.inl"
 #include "shared/source/helpers/compiler_product_helper_xe_hp_and_later.inl"
 #include "shared/source/xe_hpg_core/hw_cmds_dg2.h"

--- a/shared/source/xe_hpg_core/xe_lpg/compiler_product_helper_xe_lpg.inl
+++ b/shared/source/xe_hpg_core/xe_lpg/compiler_product_helper_xe_lpg.inl
@@ -10,7 +10,6 @@
 #include "shared/source/helpers/compiler_product_helper_before_xe_hpc.inl"
 #include "shared/source/helpers/compiler_product_helper_enable_subgroup_local_block_io.inl"
 #include "shared/source/helpers/compiler_product_helper_mtl_and_later.inl"
-#include "shared/source/helpers/compiler_product_helper_tgllp_and_later.inl"
 #include "shared/source/helpers/compiler_product_helper_xe_hp_and_later.inl"

 #include "neo_aot_platforms.h"
--- a/shared/test/common/mocks/mock_compiler_product_helper.h
+++ b/shared/test/common/mocks/mock_compiler_product_helper.h
@@ -31,7 +31,6 @@ class MockCompilerProductHelper : public CompilerProductHelper {
    ADDMETHOD_CONST_NOBASE(isSubgroupBufferPrefetchSupported, bool, false, ());
    ADDMETHOD_CONST_NOBASE(isForceToStatelessRequired, bool, false, ());
    ADDMETHOD_CONST_NOBASE(failBuildProgramWithStatefulAccessPreference, bool, false, ());
-    ADDMETHOD_CONST_NOBASE(isDotIntegerProductExtensionSupported, bool, false, ());
    ADDMETHOD_CONST_NOBASE(oclocEnforceZebinFormat, bool, false, ());
    ADDMETHOD_CONST_NOBASE_VOIDRETURN(setProductConfigForHwInfo, (HardwareInfo & hwInfo, HardwareIpVersion config));
    ADDMETHOD_CONST_NOBASE(getCachingPolicyOptions, const char *, nullptr, (bool isDebuggerActive));
--- a/shared/test/unit_test/helpers/compiler_product_helper_tests.cpp
+++ b/shared/test/unit_test/helpers/compiler_product_helper_tests.cpp
@@ -382,12 +382,6 @@ TEST_F(CompilerProductHelperFixture, givenHwInfoWithCLVersion30ThenReportsClKhrE
    EXPECT_FALSE(hasSubstr(extensions, std::string("cl_khr_external_memory")));
 }

-HWTEST2_F(CompilerProductHelperFixture, GivenAtLeastGen12lpDeviceWhenCheckingIfIntegerDotExtensionIsSupportedThenTrueReturned, MatchAny) {
-    auto &compilerProductHelper = pDevice->getCompilerProductHelper();
-
-    EXPECT_TRUE(compilerProductHelper.isDotIntegerProductExtensionSupported());
-}
-
 HWTEST2_F(CompilerProductHelperFixture, givenConfigWhenMatchConfigWithRevIdThenProperConfigIsReturned, IsNotPvcOrDg2) {
    auto &compilerProductHelper = pDevice->getCompilerProductHelper();
    auto &hwInfo = *pDevice->getRootDeviceEnvironment().getMutableHardwareInfo();