intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-12-25 21:42:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: add proper bcs synchronization when marker

Browse Source 
Related-To: NEO-8105
Signed-off-by: Cencelewska, Katarzyna <katarzyna.cencelewska@intel.com>
This commit is contained in:
Cencelewska, Katarzyna
2023-07-21 15:45:45 +00:00
committed by Compute-Runtime-Automation
parent b0761f2b39
commit 6f45574ff9
3 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
opencl/source/command_queue/enqueue_common.h
View File

@@ -289,6 +289,7 @@ cl_int CommandQueueHw<GfxFamily>::enqueueHandler(Surface **surfacesForResidency,
}
if (isMarkerWithPostSyncWrite) {
setStallingCommandsOnNextFlush(true);
flushDependenciesForNonKernelCommand = true;
}

22
opencl/test/unit_test/command_queue/ooq_task_tests.cpp
View File

@@ -8,9 +8,11 @@
#include "shared/test/common/helpers/debug_manager_state_restore.h"
#include "shared/test/common/mocks/mock_csr.h"
#include "shared/test/common/test_macros/test_checks_shared.h"
#include "shared/test/common/utilities/base_object_utils.h"
#include "opencl/test/unit_test/command_queue/enqueue_fixture.h"
#include "opencl/test/unit_test/fixtures/hello_world_fixture.h"
#include "opencl/test/unit_test/mocks/mock_command_queue.h"
using namespace NEO;
@@ -407,4 +409,24 @@ HWTEST_F(OOQTaskTests, givenSkipDcFlushOnBarrierWithoutEventsAndMultiTileContext
EXPECT_TRUE(pCmdQ->isStallingCommandsOnNextFlushRequired());
EXPECT_TRUE(pCmdQ->isDcFlushRequiredOnStallingCommandsOnNextFlush());
}
HWTEST_F(OOQTaskTests, givenEnqueueMarkerWithWaitListWhenIsMarkerWithPostSyncWriteThenBcsTimestapLastBarrierToWaitForIsNotEmpty) {
auto &commandStreamReceiver = pDevice->getUltCommandStreamReceiver<FamilyType>();
if (false == commandStreamReceiver.peekTimestampPacketWriteEnabled()) {
GTEST_SKIP();
}
auto cmdQ = clUniquePtr(new MockCommandQueueHw<FamilyType>(context, pClDevice, nullptr));
cmdQ->setProfilingEnabled();
cmdQ->setOoqEnabled();
cl_event event;
auto retVal = cmdQ->enqueueMarkerWithWaitList(
0,
nullptr,
&event);
EXPECT_EQ(CL_SUCCESS, retVal);
EXPECT_FALSE(cmdQ->bcsTimestampPacketContainers[0].lastBarrierToWaitFor.peekNodes().empty());
clReleaseEvent(event);
}

1
opencl/test/unit_test/mocks/mock_command_queue.h
View File

@@ -254,6 +254,7 @@ class MockCommandQueueHw : public CommandQueueHw<GfxFamily> {
using BaseClass::bcsEngines;
using BaseClass::bcsQueueEngineType;
using BaseClass::bcsStates;
using BaseClass::bcsTimestampPacketContainers;
using BaseClass::blitEnqueueAllowed;
using BaseClass::commandQueueProperties;
using BaseClass::commandStream;