refactor: remove not needed code

Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
This commit is contained in:
Mateusz Jablonski
2024-04-15 13:06:47 +00:00
committed by Compute-Runtime-Automation
parent 1db2bd82c1
commit 704ea18ce3
28 changed files with 36 additions and 198 deletions

View File

@@ -25,7 +25,6 @@ class MockReleaseHelper : public ReleaseHelper {
ADDMETHOD_CONST_NOBASE(isBFloat16ConversionSupported, bool, false, ());
ADDMETHOD_CONST_NOBASE(isAuxSurfaceModeOverrideRequired, bool, false, ());
ADDMETHOD_CONST_NOBASE(getProductMaxPreferredSlmSize, int, 0, (int preferredEnumValue));
ADDMETHOD_CONST_NOBASE(getMediaFrequencyTileIndex, bool, false, (uint32_t & tileIndex));
ADDMETHOD_CONST_NOBASE(isResolvingSubDeviceIDNeeded, bool, false, ());
ADDMETHOD_CONST_NOBASE(shouldAdjustDepth, bool, false, ());
ADDMETHOD_CONST_NOBASE(isDirectSubmissionSupported, bool, false, ());

View File

@@ -697,15 +697,6 @@ HWTEST_F(ProductHelperTest, givenProductHelperWhenIsAdjustWalkOrderAvailableCall
EXPECT_FALSE(productHelper->isAdjustWalkOrderAvailable(releaseHelper));
}
HWTEST_F(ProductHelperTest, givenProductHelperWhenGetMediaFrequencyTileIndexCallThenFalseReturn) {
uint32_t tileIndex = 0;
if (releaseHelper) {
EXPECT_EQ(releaseHelper->getMediaFrequencyTileIndex(tileIndex), productHelper->getMediaFrequencyTileIndex(releaseHelper, tileIndex));
} else {
EXPECT_FALSE(productHelper->getMediaFrequencyTileIndex(releaseHelper, tileIndex));
}
}
HWTEST_F(ProductHelperTest, givenProductHelperWhenIsPrefetcherDisablingInDirectSubmissionRequiredThenTrueIsReturned) {
EXPECT_TRUE(productHelper->isPrefetcherDisablingInDirectSubmissionRequired());
}

View File

@@ -46,10 +46,6 @@ TEST_F(ReleaseHelper1255Tests, whenGettingMaxPreferredSlmSizeThenSizeIsNotModifi
whenGettingMaxPreferredSlmSizeThenSizeIsNotModified();
}
TEST_F(ReleaseHelper1255Tests, whenGettingMediaFrequencyTileIndexThenFalseIsReturned) {
whenGettingMediaFrequencyTileIndexThenFalseIsReturned();
}
TEST_F(ReleaseHelper1255Tests, whenShouldAdjustCalledThenFalseReturned) {
whenShouldAdjustCalledThenFalseReturned();
}

View File

@@ -46,10 +46,6 @@ TEST_F(ReleaseHelper1256Tests, whenGettingMaxPreferredSlmSizeThenSizeIsNotModifi
whenGettingMaxPreferredSlmSizeThenSizeIsNotModified();
}
TEST_F(ReleaseHelper1256Tests, whenGettingMediaFrequencyTileIndexThenFalseIsReturned) {
whenGettingMediaFrequencyTileIndexThenFalseIsReturned();
}
TEST_F(ReleaseHelper1256Tests, whenShouldAdjustCalledThenFalseReturned) {
whenShouldAdjustCalledThenFalseReturned();
}

View File

@@ -46,10 +46,6 @@ TEST_F(ReleaseHelper1257Tests, whenGettingMaxPreferredSlmSizeThenSizeIsNotModifi
whenGettingMaxPreferredSlmSizeThenSizeIsNotModified();
}
TEST_F(ReleaseHelper1257Tests, whenGettingMediaFrequencyTileIndexThenFalseIsReturned) {
whenGettingMediaFrequencyTileIndexThenFalseIsReturned();
}
TEST_F(ReleaseHelper1257Tests, whenShouldAdjustCalledThenFalseReturned) {
whenShouldAdjustCalledThenFalseReturned();
}

View File

@@ -65,10 +65,6 @@ TEST_F(ReleaseHelper1270Tests, whenGettingMaxPreferredSlmSizeThenSizeSizeIsLimit
}
}
TEST_F(ReleaseHelper1270Tests, whenGettingMediaFrequencyTileIndexThenOneIsReturned) {
whenGettingMediaFrequencyTileIndexThenOneIsReturned();
}
TEST_F(ReleaseHelper1270Tests, whenGettingSupportedNumGrfsThenCorrectValuesAreReturned) {
whenGettingSupportedNumGrfsThenValues128And256Returned();
}

View File

@@ -66,10 +66,6 @@ TEST_F(ReleaseHelper1271Tests, whenGettingMaxPreferredSlmSizeThenSizeSizeIsLimit
}
}
TEST_F(ReleaseHelper1271Tests, whenGettingMediaFrequencyTileIndexThenOneIsReturned) {
whenGettingMediaFrequencyTileIndexThenOneIsReturned();
}
TEST_F(ReleaseHelper1271Tests, whenGettingSupportedNumGrfsThenCorrectValuesAreReturned) {
whenGettingSupportedNumGrfsThenValues128And256Returned();
}

View File

@@ -46,10 +46,6 @@ TEST_F(ReleaseHelper1274Tests, whenGettingMaxPreferredSlmSizeThenSizeIsNotModifi
whenGettingMaxPreferredSlmSizeThenSizeIsNotModified();
}
TEST_F(ReleaseHelper1274Tests, whenGettingMediaFrequencyTileIndexThenOneIsReturned) {
whenGettingMediaFrequencyTileIndexThenOneIsReturned();
}
TEST_F(ReleaseHelper1274Tests, whenShouldAdjustCalledThenFalseReturned) {
whenShouldAdjustCalledThenFalseReturned();
}

View File

@@ -31,31 +31,6 @@ void ReleaseHelperTestsBase::whenGettingMaxPreferredSlmSizeThenSizeIsNotModified
}
}
void ReleaseHelperTestsBase::whenGettingMediaFrequencyTileIndexThenFalseIsReturned() {
for (auto &revision : getRevisions()) {
ipVersion.revision = revision;
releaseHelper = ReleaseHelper::create(ipVersion);
ASSERT_NE(nullptr, releaseHelper);
auto tileIndex = 0u;
auto expectedTileIndex = 0u;
EXPECT_FALSE(releaseHelper->getMediaFrequencyTileIndex(tileIndex));
EXPECT_EQ(expectedTileIndex, tileIndex);
}
}
void ReleaseHelperTestsBase::whenGettingMediaFrequencyTileIndexThenOneIsReturned() {
for (auto &revision : getRevisions()) {
ipVersion.revision = revision;
releaseHelper = ReleaseHelper::create(ipVersion);
ASSERT_NE(nullptr, releaseHelper);
auto tileIndex = 0u;
auto expectedTileIndex = 1u;
EXPECT_TRUE(releaseHelper->getMediaFrequencyTileIndex(tileIndex));
EXPECT_EQ(expectedTileIndex, tileIndex);
}
}
void ReleaseHelperTestsBase::whenShouldAdjustCalledThenTrueReturned() {
for (auto &revision : getRevisions()) {
ipVersion.revision = revision;

View File

@@ -21,9 +21,7 @@ struct ReleaseHelperTestsBase : public ::testing::Test {
ReleaseHelperTestsBase();
~ReleaseHelperTestsBase() override;
void whenGettingMediaFrequencyTileIndexThenFalseIsReturned();
void whenGettingMaxPreferredSlmSizeThenSizeIsNotModified();
void whenGettingMediaFrequencyTileIndexThenOneIsReturned();
void whenShouldAdjustCalledThenTrueReturned();
void whenShouldAdjustCalledThenFalseReturned();
void whenGettingSupportedNumGrfsThenValues128And256Returned();

View File

@@ -23,7 +23,6 @@ HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTest, givenDebugVariableSetWhenAskingForAuxT
HWTEST_EXCLUDE_PRODUCT(ProductHelperTest, givenProductHelperWhenAskedIfPatIndexProgrammingSupportedThenReturnFalse, IGFX_ARROWLAKE);
HWTEST_EXCLUDE_PRODUCT(CommandEncoderTests, givenRequiredWorkGroupOrderWhenCallAdjustWalkOrderThenWalkerIsNotChanged_IsAtMostXeHpcCore, IGFX_ARROWLAKE);
HWTEST_EXCLUDE_PRODUCT(ProductHelperTest, givenProductHelperWhenIsAdjustWalkOrderAvailableCallThenFalseReturn, IGFX_ARROWLAKE);
HWTEST_EXCLUDE_PRODUCT(ProductHelperTest, givenProductHelperWhenGetMediaFrequencyTileIndexCallThenFalseReturn, IGFX_ARROWLAKE);
HWTEST_EXCLUDE_PRODUCT(ProductHelperTest, givenProductHelperWhenCheckBlitEnqueueAllowedThenReturnTrue, IGFX_ARROWLAKE);
HWTEST_EXCLUDE_PRODUCT(ProductHelperTest, whenGettingPreferredAllocationMethodThenNoPreferenceIsReturned, IGFX_ARROWLAKE);
HWTEST_EXCLUDE_PRODUCT(ProductHelperTest, givenBooleanUncachedWhenCallOverridePatIndexThenProperPatIndexIsReturned, IGFX_ARROWLAKE);

View File

@@ -283,12 +283,6 @@ HWTEST2_F(XeLpgProductHelperTests, givenHwIpVersionWhenIsPipeControlPriorToNonPi
}
}
HWTEST2_F(XeLpgProductHelperTests, givenReleaseHelperNullptrWhenCallingGetMediaFrequencyTileIndexThenReturnFalse, IsXeLpg) {
uint32_t tileIndex = 0;
ReleaseHelper *releaseHelper = nullptr;
EXPECT_FALSE(productHelper->getMediaFrequencyTileIndex(releaseHelper, tileIndex));
}
HWTEST2_F(XeLpgProductHelperTests, whenCheckFp64SupportThenReturnTrue, IsXeLpg) {
EXPECT_TRUE(pDevice->getHardwareInfo().capabilityTable.ftrSupportsFP64);
}