Unify flush task getter implementation of product and core helpers

Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
This commit is contained in:
Zbigniew Zdanowicz
2023-02-09 10:00:59 +00:00
committed by Compute-Runtime-Automation
parent 0e1ba33e07
commit 783df81a44
5 changed files with 2 additions and 62 deletions

View File

@@ -21,11 +21,6 @@ bool ProductHelperHw<gfxProduct>::isDcFlushAllowed() const {
return false;
}
template <>
bool ProductHelperHw<gfxProduct>::isFlushTaskAllowed() const {
return true;
}
template <>
bool ProductHelperHw<gfxProduct>::isTimestampWaitSupportedForEvents() const {
return true;

View File

@@ -181,11 +181,6 @@ uint32_t ProductHelperHw<gfxProduct>::computeMaxNeededSubSliceSpace(const Hardwa
return maxSubSlice;
}
template <>
bool ProductHelperHw<gfxProduct>::isFlushTaskAllowed() const {
return true;
}
template <>
bool ProductHelperHw<gfxProduct>::programAllStateComputeCommandFields() const {
return true;

View File

@@ -124,9 +124,4 @@ uint64_t ProductHelperHw<gfxProduct>::overridePatIndex(AllocationType allocation
return patIndex;
}
template <>
bool ProductHelperHw<gfxProduct>::isFlushTaskAllowed() const {
return false;
}
} // namespace NEO

View File

@@ -1278,19 +1278,7 @@ HWTEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenGettingIfRevisionSpecificBinar
EXPECT_FALSE(gfxCoreHelper.isRevisionSpecificBinaryBuiltinRequired());
}
HWTEST2_F(GfxCoreHelperTest, givenDG2GfxCoreHelperWhenGettingIsPlatformFlushTaskEnabledThenTrueIsReturned, IsDG2) {
const auto &gfxCoreHelper = getHelper<GfxCoreHelper>();
auto &productHelper = getHelper<ProductHelper>();
EXPECT_TRUE(gfxCoreHelper.isPlatformFlushTaskEnabled(productHelper));
}
HWTEST2_F(GfxCoreHelperTest, givenPvcGfxCoreHelperWhenGettingIsPlatformFlushTaskEnabledThenTrueIsReturned, IsPVC) {
const auto &gfxCoreHelper = getHelper<GfxCoreHelper>();
auto &productHelper = getHelper<ProductHelper>();
EXPECT_TRUE(gfxCoreHelper.isPlatformFlushTaskEnabled(productHelper));
}
HWTEST2_F(GfxCoreHelperTest, givenAtMostGen12lpGfxCoreHelperWhenGettingIsPlatformFlushTaskEnabledThenFalseIsReturned, IsAtMostGen12lp) {
HWTEST_F(GfxCoreHelperTest, givenGfxCoreHelperWhenGettingIsPlatformFlushTaskEnabledThenTrueIsReturned) {
const auto &gfxCoreHelper = getHelper<GfxCoreHelper>();
auto &productHelper = getHelper<ProductHelper>();
EXPECT_TRUE(gfxCoreHelper.isPlatformFlushTaskEnabled(productHelper));