From 78f505f4f47d80f94cc603be2886c4d3168322e2 Mon Sep 17 00:00:00 2001 From: Lukasz Towarek Date: Fri, 10 Aug 2018 15:30:36 +0200 Subject: [PATCH] Return CL_INVALID_ARG_SIZE instead of CL_INVALID_ARG_VALUE Change-Id: Ia8792035e19a450f1399f8be3287ef46d0d6609d --- runtime/kernel/kernel.cpp | 2 +- unit_tests/mem_obj/buffer_set_arg_tests.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/runtime/kernel/kernel.cpp b/runtime/kernel/kernel.cpp index e723b91f18..7ae40b7495 100644 --- a/runtime/kernel/kernel.cpp +++ b/runtime/kernel/kernel.cpp @@ -1093,7 +1093,7 @@ cl_int Kernel::setArgBuffer(uint32_t argIndex, const void *argVal) { if (argSize != sizeof(cl_mem *)) - return CL_INVALID_ARG_VALUE; + return CL_INVALID_ARG_SIZE; const auto &kernelArgInfo = kernelInfo.kernelArgInfo[argIndex]; auto clMem = reinterpret_cast(argVal); diff --git a/unit_tests/mem_obj/buffer_set_arg_tests.cpp b/unit_tests/mem_obj/buffer_set_arg_tests.cpp index fc3e927c1d..1c156e2d9d 100644 --- a/unit_tests/mem_obj/buffer_set_arg_tests.cpp +++ b/unit_tests/mem_obj/buffer_set_arg_tests.cpp @@ -126,10 +126,10 @@ TEST_F(BufferSetArgTest, setKernelArgBuffer) { EXPECT_EQ((void *)((uintptr_t)buffer->getGraphicsAllocation()->getGpuAddress()), *pKernelArg); } -TEST_F(BufferSetArgTest, setKernelArgBufferWithWrongSizeReturnsInvalidArgValueError) { +TEST_F(BufferSetArgTest, givenInvalidSizeWhenSettingKernelArgBufferThenReturnClInvalidArgSize) { cl_mem arg = buffer; cl_int err = pKernel->setArgBuffer(0, sizeof(cl_mem) + 1, arg); - EXPECT_EQ(CL_INVALID_ARG_VALUE, err); + EXPECT_EQ(CL_INVALID_ARG_SIZE, err); } HWTEST_F(BufferSetArgTest, givenSetArgBufferWhenNullArgStatefulThenProgramNullSurfaceState) {