From 7c7b405219f33aec0967534c2ff2316b788c3dd8 Mon Sep 17 00:00:00 2001 From: "Mrozek, Michal" Date: Tue, 18 Sep 2018 13:40:46 -0700 Subject: [PATCH] Remove makeCoherent from getTagAddress. - if Tag allocation was not yet made resident then makeCoherent will fetch uninitialized data, causing finish to return earlier then it should causing later synchronization issues. - simplify rest of method, remove redundant code. Change-Id: I7bfcbd9f2d7170f41473a97f51856d82671b6638 --- runtime/command_queue/command_queue.cpp | 27 +++---------------------- 1 file changed, 3 insertions(+), 24 deletions(-) diff --git a/runtime/command_queue/command_queue.cpp b/runtime/command_queue/command_queue.cpp index 2012e7d368..8630075680 100644 --- a/runtime/command_queue/command_queue.cpp +++ b/runtime/command_queue/command_queue.cpp @@ -1,23 +1,8 @@ /* - * Copyright (c) 2018, Intel Corporation + * Copyright (C) 2018 Intel Corporation * - * Permission is hereby granted, free of charge, to any person obtaining a - * copy of this software and associated documentation files (the "Software"), - * to deal in the Software without restriction, including without limitation - * the rights to use, copy, modify, merge, publish, distribute, sublicense, - * and/or sell copies of the Software, and to permit persons to whom the - * Software is furnished to do so, subject to the following conditions: + * SPDX-License-Identifier: MIT * - * The above copyright notice and this permission notice shall be included - * in all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS - * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR - * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, - * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR - * OTHER DEALINGS IN THE SOFTWARE. */ #include "runtime/built_ins/builtins_dispatch_builder.h" @@ -135,13 +120,7 @@ uint32_t CommandQueue::getHwTag() const { } volatile uint32_t *CommandQueue::getHwTagAddress() const { - DEBUG_BREAK_IF(!this->device); - auto &commandStreamReceiver = device->getCommandStreamReceiver(); - auto tag_address = commandStreamReceiver.getTagAddress(); - auto allocation = commandStreamReceiver.getTagAllocation(); - UNRECOVERABLE_IF(allocation == nullptr); - commandStreamReceiver.makeCoherent(*allocation); - return tag_address; + return device->getCommandStreamReceiver().getTagAddress(); } bool CommandQueue::isCompleted(uint32_t taskCount) const {