refactor: change additional walker fields encoder 6/n

- change order of members of additional walker struct

Related-To: NEO-12639

Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
This commit is contained in:
Zbigniew Zdanowicz
2024-10-29 22:15:22 +00:00
committed by Compute-Runtime-Automation
parent 5d62be2bea
commit 89b40b7ec4
10 changed files with 60 additions and 20 deletions

View File

@@ -82,6 +82,18 @@ EncodeDispatchKernelArgs CommandEncodeStatesFixture::createDefaultDispatchKernel
return args;
}
EncodeWalkerArgs CommandEncodeStatesFixture::createDefaultEncodeWalkerArgs(const KernelDescriptor &kernelDescriptor) {
EncodeWalkerArgs args{
kernelDescriptor, // kernelDescriptor
NEO::KernelExecutionType::defaultType, // kernelExecutionType
NEO::RequiredDispatchWalkOrder::none, // requiredDispatchWalkOrder
0, // additionalSizeParam
0, // maxFrontEndThreads
false}; // requiredSystemFence
return args;
}
void ScratchProgrammingFixture::setUp() {
NEO::DeviceFixture::setUp();
size_t sizeStream = 512;

View File

@@ -38,6 +38,8 @@ class CommandEncodeStatesFixture : public DeviceFixture {
const void *threadGroupDimensions,
bool requiresUncachedMocs);
static EncodeWalkerArgs createDefaultEncodeWalkerArgs(const KernelDescriptor &kernelDescriptor);
template <typename FamilyType>
EncodeStateBaseAddressArgs<FamilyType> createDefaultEncodeStateBaseAddressArgs(
CommandContainer *container,

View File

@@ -13,6 +13,7 @@
#include "shared/test/common/mocks/mock_execution_environment.h"
#include "shared/test/common/test_macros/header/per_product_test_definitions.h"
#include "shared/test/common/test_macros/test.h"
#include "shared/test/unit_test/fixtures/command_container_fixture.h"
using namespace NEO;
@@ -24,7 +25,9 @@ XE_HPC_CORETEST_F(WalkerDispatchTestsXeHpcCore, givenXeHpcWhenEncodeAdditionalWa
auto walkerCmd = FamilyType::cmdInitGpgpuWalker;
KernelDescriptor kernelDescriptor;
EncodeWalkerArgs walkerArgs{KernelExecutionType::defaultType, true, kernelDescriptor, NEO::RequiredDispatchWalkOrder::none, 0};
EncodeWalkerArgs walkerArgs = CommandEncodeStatesFixture::createDefaultEncodeWalkerArgs(kernelDescriptor);
walkerArgs.requiredSystemFence = true;
{
EncodeDispatchKernel<FamilyType>::encodeComputeDispatchAllWalker(walkerCmd, walkerArgs);
EXPECT_FALSE(walkerCmd.getComputeDispatchAllWalkerEnable());

View File

@@ -16,6 +16,7 @@
#include "shared/test/common/mocks/mock_execution_environment.h"
#include "shared/test/common/test_macros/header/per_product_test_definitions.h"
#include "shared/test/common/test_macros/test.h"
#include "shared/test/unit_test/fixtures/command_container_fixture.h"
using namespace NEO;
@@ -44,7 +45,9 @@ PVCTEST_F(WalkerDispatchTestsPvc, givenPvcWhenEncodeAdditionalWalkerFieldsThenPo
auto &hwInfo = *rootDeviceEnvironment.getMutableHardwareInfo();
KernelDescriptor kernelDescriptor;
EncodeWalkerArgs walkerArgs{KernelExecutionType::defaultType, true, kernelDescriptor, NEO::RequiredDispatchWalkOrder::none, 0};
EncodeWalkerArgs walkerArgs = CommandEncodeStatesFixture::createDefaultEncodeWalkerArgs(kernelDescriptor);
walkerArgs.requiredSystemFence = true;
for (auto &testInput : testInputs) {
for (auto &deviceId : pvcXlDeviceIds) {
hwInfo.platform.usDeviceID = deviceId;
@@ -70,7 +73,7 @@ PVCTEST_F(WalkerDispatchTestsPvc, givenPvcSupportsSystemMemoryFenceWhenNoSystemF
hwInfo.platform.usRevId = 0x3;
KernelDescriptor kernelDescriptor;
EncodeWalkerArgs walkerArgs{KernelExecutionType::defaultType, false, kernelDescriptor, NEO::RequiredDispatchWalkOrder::none, 0};
EncodeWalkerArgs walkerArgs = CommandEncodeStatesFixture::createDefaultEncodeWalkerArgs(kernelDescriptor);
for (auto &deviceId : pvcXlDeviceIds) {
hwInfo.platform.usDeviceID = deviceId;