intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-08 14:02:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Correct programming of horizontal alignment on Xe Hp

Browse Source 
for linear surfaces we should program value of 128

Related-To: NEO-6466
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
This commit is contained in:
Mateusz Jablonski
2022-01-20 16:13:33 +00:00
committed by Compute-Runtime-Automation
parent d9bf1886c2
commit 8e03ce9c54
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shared/source/generated/xe_hp_core/hw_cmds_generated_xe_hp_core.inl
View File

@@ -1353,7 +1353,7 @@ typedef struct tagRENDER_SURFACE_STATE {
SURFACE_HORIZONTAL_ALIGNMENT_HALIGN_32 = 0x1, SURFACE_HORIZONTAL_ALIGNMENT_HALIGN_32 = 0x1,
SURFACE_HORIZONTAL_ALIGNMENT_HALIGN_64 = 0x2, SURFACE_HORIZONTAL_ALIGNMENT_HALIGN_64 = 0x2,
SURFACE_HORIZONTAL_ALIGNMENT_HALIGN_128 = 0x3, SURFACE_HORIZONTAL_ALIGNMENT_HALIGN_128 = 0x3,
SURFACE_HORIZONTAL_ALIGNMENT_HALIGN_DEFAULT = SURFACE_HORIZONTAL_ALIGNMENT_HALIGN_32, SURFACE_HORIZONTAL_ALIGNMENT_HALIGN_DEFAULT = SURFACE_HORIZONTAL_ALIGNMENT_HALIGN_128,
} SURFACE_HORIZONTAL_ALIGNMENT; } SURFACE_HORIZONTAL_ALIGNMENT;
typedef enum tagSURFACE_VERTICAL_ALIGNMENT { typedef enum tagSURFACE_VERTICAL_ALIGNMENT {
SURFACE_VERTICAL_ALIGNMENT_VALIGN_4 = 0x1, SURFACE_VERTICAL_ALIGNMENT_VALIGN_4 = 0x1,

8
shared/test/unit_test/xe_hp_core/hw_cmds_xe_hp_core_tests.cpp
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (C) 2021 Intel Corporation * Copyright (C) 2021-2022 Intel Corporation
* *
* SPDX-License-Identifier: MIT * SPDX-License-Identifier: MIT
* *
@@ -20,6 +20,12 @@ XE_HP_CORE_TEST_F(XeHpCoreHwCmdTest, givenRenderSurfaceStateWhenProgrammingMocsT
EXPECT_EQ(expectedMocsIndex, renderSurfaceState.TheStructure.Common.MemoryObjectControlStateIndexToMocsTables); EXPECT_EQ(expectedMocsIndex, renderSurfaceState.TheStructure.Common.MemoryObjectControlStateIndexToMocsTables);
} }
XE_HP_CORE_TEST_F(XeHpCoreHwCmdTest, givenRenderSurfaceStateThenDefaultHorizontalAlignmentIs128) {
auto defaultHorizontalAlignmentValue = FamilyType::RENDER_SURFACE_STATE::SURFACE_HORIZONTAL_ALIGNMENT_HALIGN_DEFAULT;
auto horizontalAlignment128Value = FamilyType::RENDER_SURFACE_STATE::SURFACE_HORIZONTAL_ALIGNMENT_HALIGN_128;
EXPECT_EQ(defaultHorizontalAlignmentValue, horizontalAlignment128Value);
}
XE_HP_CORE_TEST_F(XeHpCoreHwCmdTest, givenStateBaseAddressWhenProgrammingMocsThenMocsIndexIsSetProperly) { XE_HP_CORE_TEST_F(XeHpCoreHwCmdTest, givenStateBaseAddressWhenProgrammingMocsThenMocsIndexIsSetProperly) {
auto stateBaseAddress = FamilyType::cmdInitStateBaseAddress; auto stateBaseAddress = FamilyType::cmdInitStateBaseAddress;
uint32_t mocs = 4u; uint32_t mocs = 4u;