intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-05 17:20:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Disallow compiling/building program if it has attached Kernels

Browse Source 
allow for creating kernel if the program is built for at least one device

Related-To: NEO-5001
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
This commit is contained in:
Mateusz Jablonski
2020-11-23 13:51:25 +00:00
committed by Compute-Runtime-Automation
parent a5dba1d43c
commit 8fdc35bb4b
6 changed files with 380 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

165
opencl/test/unit_test/api/cl_compile_program_tests.inl
View File

@@ -235,7 +235,7 @@ TEST_F(clCompileProgramTests, GivenValidCallbackInputWhenLinkProgramThenCallback
EXPECT_EQ(CL_SUCCESS, retVal);
}
TEST(clCompileProgramTest, givenMultiDeviceProgramWhenCompilingForInvalidDevicesInputThenInvalidDeviceErrorIsReturned) {
TEST(clCompileProgramTest, givenProgramWhenCompilingForInvalidDevicesInputThenInvalidDeviceErrorIsReturned) {
cl_program pProgram = nullptr;
std::unique_ptr<char[]> pSource = nullptr;
size_t sourceSize = 0;
@@ -328,4 +328,167 @@ TEST(clCompileProgramTest, givenMultiDeviceProgramWhenCompilingForInvalidDevices
retVal = clReleaseProgram(pProgram);
EXPECT_EQ(CL_SUCCESS, retVal);
}
TEST(clCompileProgramTest, givenMultiDeviceProgramWithCreatedKernelWhenCompilingThenInvalidOperationErrorIsReturned) {
MockSpecializedContext context;
cl_program pProgram = nullptr;
size_t sourceSize = 0;
cl_int retVal = CL_INVALID_PROGRAM;
std::string testFile;
testFile.append(clFiles);
testFile.append("copybuffer.cl");
auto pSource = loadDataFromFile(
testFile.c_str(),
sourceSize);
ASSERT_NE(0u, sourceSize);
ASSERT_NE(nullptr, pSource);
const char *sources[1] = {pSource.get()};
pProgram = clCreateProgramWithSource(
&context,
1,
sources,
&sourceSize,
&retVal);
EXPECT_NE(nullptr, pProgram);
ASSERT_EQ(CL_SUCCESS, retVal);
cl_device_id firstSubDevice = context.pSubDevice0;
cl_device_id secondSubDevice = context.pSubDevice1;
retVal = clBuildProgram(
pProgram,
1,
&firstSubDevice,
nullptr,
nullptr,
nullptr);
EXPECT_EQ(CL_SUCCESS, retVal);
auto kernel = clCreateKernel(pProgram, "fullCopy", &retVal);
EXPECT_EQ(CL_SUCCESS, retVal);
retVal = clCompileProgram(
pProgram,
1,
&secondSubDevice,
nullptr,
0,
nullptr,
nullptr,
nullptr,
nullptr);
EXPECT_EQ(CL_INVALID_OPERATION, retVal);
retVal = clReleaseKernel(kernel);
EXPECT_EQ(CL_SUCCESS, retVal);
retVal = clCompileProgram(
pProgram,
1,
&secondSubDevice,
nullptr,
0,
nullptr,
nullptr,
nullptr,
nullptr);
EXPECT_EQ(CL_SUCCESS, retVal);
retVal = clReleaseProgram(pProgram);
EXPECT_EQ(CL_SUCCESS, retVal);
}
TEST(clCompileProgramTest, givenMultiDeviceProgramWithCreatedKernelsWhenCompilingThenInvalidOperationErrorIsReturned) {
MockSpecializedContext context;
cl_program pProgram = nullptr;
size_t sourceSize = 0;
cl_int retVal = CL_INVALID_PROGRAM;
std::string testFile;
testFile.append(clFiles);
testFile.append("copybuffer.cl");
auto pSource = loadDataFromFile(
testFile.c_str(),
sourceSize);
ASSERT_NE(0u, sourceSize);
ASSERT_NE(nullptr, pSource);
const char *sources[1] = {pSource.get()};
pProgram = clCreateProgramWithSource(
&context,
1,
sources,
&sourceSize,
&retVal);
EXPECT_NE(nullptr, pProgram);
ASSERT_EQ(CL_SUCCESS, retVal);
cl_device_id firstSubDevice = context.pSubDevice0;
cl_device_id secondSubDevice = context.pSubDevice1;
retVal = clBuildProgram(
pProgram,
1,
&firstSubDevice,
nullptr,
nullptr,
nullptr);
EXPECT_EQ(CL_SUCCESS, retVal);
size_t numKernels = 0;
retVal = clGetProgramInfo(pProgram, CL_PROGRAM_NUM_KERNELS, sizeof(numKernels), &numKernels, nullptr);
EXPECT_EQ(CL_SUCCESS, retVal);
auto kernels = std::make_unique<cl_kernel[]>(numKernels);
retVal = clCreateKernelsInProgram(pProgram, static_cast<cl_uint>(numKernels), kernels.get(), nullptr);
EXPECT_EQ(CL_SUCCESS, retVal);
retVal = clCompileProgram(
pProgram,
1,
&secondSubDevice,
nullptr,
0,
nullptr,
nullptr,
nullptr,
nullptr);
EXPECT_EQ(CL_INVALID_OPERATION, retVal);
for (auto i = 0u; i < numKernels; i++) {
retVal = clReleaseKernel(kernels[i]);
EXPECT_EQ(CL_SUCCESS, retVal);
}
retVal = clCompileProgram(
pProgram,
1,
&secondSubDevice,
nullptr,
0,
nullptr,
nullptr,
nullptr,
nullptr);
EXPECT_EQ(CL_SUCCESS, retVal);
retVal = clReleaseProgram(pProgram);
EXPECT_EQ(CL_SUCCESS, retVal);
}
} // namespace ULT