From 9bd4878841ef534ae492a883b352383f6e4c2507 Mon Sep 17 00:00:00 2001 From: Jitendra Sharma Date: Tue, 15 Oct 2024 11:39:53 +0000 Subject: [PATCH] feature: update GRF register implementation Related-To: NEO-8314 Signed-off-by: Jitendra Sharma --- .../gfx_core_helpers/l0_gfx_core_helper.h | 2 ++ .../l0_gfx_core_helper_skl_to_tgllp.inl | 5 +++ .../l0_gfx_core_helper_xe_hpg_and_xe_hpc.inl | 10 ++++++ .../l0_gfx_core_helper_xe2_hpg_core.cpp | 10 ++++++ .../test_l0_gfx_core_helper_gen12lp.cpp | 5 +++ .../tools/source/debug/debug_session_imp.cpp | 22 ++----------- .../sources/debug/debug_session_tests.cpp | 31 ----------------- .../sources/debug/test_debug_api.cpp | 4 +-- .../debug_session_tests_xe2_hpg_core.cpp | 33 +++++++++++++++++++ shared/source/helpers/gfx_core_helper.h | 2 -- .../source/helpers/gfx_core_helper_base.inl | 5 --- .../gfx_core_helper_xehp_and_later.inl | 5 --- shared/test/common/helpers/sip_init.cpp | 2 +- .../gen12lp/dg1/gfx_core_helper_tests_dg1.cpp | 5 --- .../gfx_core_helper_tests_xe2_hpg_core.cpp | 5 --- 15 files changed, 71 insertions(+), 75 deletions(-) diff --git a/level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper.h b/level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper.h index 08a2124b2f..97eb2d66b6 100644 --- a/level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper.h +++ b/level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper.h @@ -102,6 +102,7 @@ class L0GfxCoreHelper : public NEO::ApiGfxCoreHelper { virtual ze_rtas_format_exp_t getSupportedRTASFormat() const = 0; virtual bool platformSupportsImmediateComputeFlushTask() const = 0; virtual zet_debug_regset_type_intel_gpu_t getRegsetTypeForLargeGrfDetection() const = 0; + virtual uint32_t getGrfRegisterCount(uint32_t *regPtr) const = 0; virtual uint32_t getCmdListWaitOnMemoryDataSize() const = 0; virtual bool hasUnifiedPostSyncAllocationLayout() const = 0; virtual uint32_t getImmediateWritePostSyncOffset() const = 0; @@ -153,6 +154,7 @@ class L0GfxCoreHelperHw : public L0GfxCoreHelper { ze_rtas_format_exp_t getSupportedRTASFormat() const override; bool platformSupportsImmediateComputeFlushTask() const override; zet_debug_regset_type_intel_gpu_t getRegsetTypeForLargeGrfDetection() const override; + uint32_t getGrfRegisterCount(uint32_t *regPtr) const override; uint32_t getCmdListWaitOnMemoryDataSize() const override; bool hasUnifiedPostSyncAllocationLayout() const override; uint32_t getImmediateWritePostSyncOffset() const override; diff --git a/level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper_skl_to_tgllp.inl b/level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper_skl_to_tgllp.inl index 8a4c643fbd..0cf0c9e277 100644 --- a/level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper_skl_to_tgllp.inl +++ b/level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper_skl_to_tgllp.inl @@ -79,4 +79,9 @@ zet_debug_regset_type_intel_gpu_t L0GfxCoreHelperHw::getRegsetTypeForLar return ZET_DEBUG_REGSET_TYPE_INVALID_INTEL_GPU; } +template +uint32_t L0GfxCoreHelperHw::getGrfRegisterCount(uint32_t *regPtr) const { + return 128; +} + } // namespace L0 diff --git a/level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper_xe_hpg_and_xe_hpc.inl b/level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper_xe_hpg_and_xe_hpc.inl index 74e87edfb2..40a14cb572 100644 --- a/level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper_xe_hpg_and_xe_hpc.inl +++ b/level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper_xe_hpg_and_xe_hpc.inl @@ -14,4 +14,14 @@ zet_debug_regset_type_intel_gpu_t L0GfxCoreHelperHw::getRegsetTypeForLar return ZET_DEBUG_REGSET_TYPE_CR_INTEL_GPU; } +template +uint32_t L0GfxCoreHelperHw::getGrfRegisterCount(uint32_t *regPtr) const { + bool largeGrfModeEnabled = false; + largeGrfModeEnabled = regPtr[0] & 0x2000; + if (largeGrfModeEnabled) { + return 256; + } + return 128; +} + } // namespace L0 diff --git a/level_zero/core/source/xe2_hpg_core/l0_gfx_core_helper_xe2_hpg_core.cpp b/level_zero/core/source/xe2_hpg_core/l0_gfx_core_helper_xe2_hpg_core.cpp index fd1b9ccfc4..843e51fb4e 100644 --- a/level_zero/core/source/xe2_hpg_core/l0_gfx_core_helper_xe2_hpg_core.cpp +++ b/level_zero/core/source/xe2_hpg_core/l0_gfx_core_helper_xe2_hpg_core.cpp @@ -23,6 +23,16 @@ zet_debug_regset_type_intel_gpu_t L0GfxCoreHelperHw::getRegsetTypeForLar return ZET_DEBUG_REGSET_TYPE_SR_INTEL_GPU; } +template +uint32_t L0GfxCoreHelperHw::getGrfRegisterCount(uint32_t *regPtr) const { + bool largeGrfModeEnabled = false; + largeGrfModeEnabled = ((regPtr[1] & 0x6000) == 0x6000); + if (largeGrfModeEnabled) { + return 256; + } + return 128; +} + /* * Xe2 stall sample data item format: * diff --git a/level_zero/core/test/unit_tests/gen12lp/test_l0_gfx_core_helper_gen12lp.cpp b/level_zero/core/test/unit_tests/gen12lp/test_l0_gfx_core_helper_gen12lp.cpp index 4a26138770..36c59a7f55 100644 --- a/level_zero/core/test/unit_tests/gen12lp/test_l0_gfx_core_helper_gen12lp.cpp +++ b/level_zero/core/test/unit_tests/gen12lp/test_l0_gfx_core_helper_gen12lp.cpp @@ -28,6 +28,11 @@ GEN12LPTEST_F(L0GfxCoreHelperTestGen12Lp, GivenGen12LpWhenGetRegsetTypeForLargeG EXPECT_EQ(ZET_DEBUG_REGSET_TYPE_INVALID_INTEL_GPU, l0GfxCoreHelper.getRegsetTypeForLargeGrfDetection()); } +GEN12LPTEST_F(L0GfxCoreHelperTestGen12Lp, GivenGen12LpWhenGetGrfRegisterCountIsCalledThen128IsRetuned) { + auto &l0GfxCoreHelper = getHelper(); + EXPECT_EQ(128u, l0GfxCoreHelper.getGrfRegisterCount(nullptr)); +} + GEN12LPTEST_F(L0GfxCoreHelperTestGen12Lp, GivenGen12LpWhenCheckingL0HelperForCmdListHeapSharingSupportThenReturnTrue) { auto &l0GfxCoreHelper = getHelper(); diff --git a/level_zero/tools/source/debug/debug_session_imp.cpp b/level_zero/tools/source/debug/debug_session_imp.cpp index 7b56096f4f..6dc9d42ef1 100644 --- a/level_zero/tools/source/debug/debug_session_imp.cpp +++ b/level_zero/tools/source/debug/debug_session_imp.cpp @@ -1335,31 +1335,15 @@ void DebugSession::updateGrfRegisterSetProperties(EuThread::ThreadId thread, uin return; } - auto &gfxCoreHelper = this->connectedDevice->getGfxCoreHelper(); - if (!gfxCoreHelper.largeGrfModeSupported()) { - return; - } - - // update GRF, if large GRF is enabled auto &l0GfxCoreHelper = connectedDevice->getNEODevice()->getRootDeviceEnvironment().getHelper(); auto regsetType = l0GfxCoreHelper.getRegsetTypeForLargeGrfDetection(); - bool largeGrfModeEnabled = false; const auto regSize = std::max(getRegisterSize(regsetType), 64u); auto reg = std::make_unique(regSize / sizeof(uint32_t)); memset(reg.get(), 0, regSize); readRegistersImp(thread, regsetType, 0, 1, reg.get()); - auto regPtr = reg.get(); - if (regsetType == ZET_DEBUG_REGSET_TYPE_CR_INTEL_GPU) { - largeGrfModeEnabled = regPtr[0] & 0x2000; - } else if (regsetType == ZET_DEBUG_REGSET_TYPE_SR_INTEL_GPU) { - largeGrfModeEnabled = ((regPtr[1] & 0x6000) == 0x6000); - } - - if (largeGrfModeEnabled) { - for (uint32_t i = 0; i < *pCount; i++) { - if (pRegisterSetProperties[i].type == ZET_DEBUG_REGSET_TYPE_GRF_INTEL_GPU) { - pRegisterSetProperties[i].count = 256; - } + for (uint32_t i = 0; i < *pCount; i++) { + if (pRegisterSetProperties[i].type == ZET_DEBUG_REGSET_TYPE_GRF_INTEL_GPU) { + pRegisterSetProperties[i].count = l0GfxCoreHelper.getGrfRegisterCount(reg.get()); } } } diff --git a/level_zero/tools/test/unit_tests/sources/debug/debug_session_tests.cpp b/level_zero/tools/test/unit_tests/sources/debug/debug_session_tests.cpp index c66dbb7e97..1f212466cd 100644 --- a/level_zero/tools/test/unit_tests/sources/debug/debug_session_tests.cpp +++ b/level_zero/tools/test/unit_tests/sources/debug/debug_session_tests.cpp @@ -2703,37 +2703,6 @@ HWTEST2_F(DebugSessionRegistersAccessTest, EXPECT_EQ(128u, threadRegsetProps[0].count); } -TEST_F(DebugSessionRegistersAccessTest, givenGetThreadRegisterSetPropertiesCalledPropertieAreTheSameAsgetRegisterSetProperties) { - - auto mockBuiltins = new MockBuiltins(); - mockBuiltins->stateSaveAreaHeader = MockSipData::createStateSaveAreaHeader(2); - MockRootDeviceEnvironment::resetBuiltins(neoDevice->executionEnvironment->rootDeviceEnvironments[0].get(), mockBuiltins); - - uint32_t count = 0; - uint32_t threadCount = 0; - ze_device_thread_t thread = stoppedThread; - EXPECT_EQ(ZE_RESULT_SUCCESS, zetDebugGetRegisterSetProperties(session->getConnectedDevice(), &count, nullptr)); - EXPECT_EQ(13u, count); - EXPECT_EQ(ZE_RESULT_SUCCESS, zetDebugGetThreadRegisterSetProperties(session->toHandle(), thread, &threadCount, nullptr)); - ASSERT_EQ(threadCount, count); - - std::vector regsetProps(count); - ASSERT_EQ(ZE_RESULT_SUCCESS, zetDebugGetRegisterSetProperties(session->getConnectedDevice(), &count, regsetProps.data())); - std::vector threadRegsetProps(count); - ASSERT_EQ(ZE_RESULT_SUCCESS, zetDebugGetThreadRegisterSetProperties(session->toHandle(), thread, &count, threadRegsetProps.data())); - - for (size_t i = 0; i < count; i++) { - EXPECT_EQ(regsetProps[i].stype, threadRegsetProps[i].stype); - EXPECT_EQ(regsetProps[i].pNext, threadRegsetProps[i].pNext); - EXPECT_EQ(regsetProps[i].version, threadRegsetProps[i].version); - EXPECT_EQ(regsetProps[i].generalFlags, threadRegsetProps[i].generalFlags); - EXPECT_EQ(regsetProps[i].deviceFlags, threadRegsetProps[i].deviceFlags); - EXPECT_EQ(regsetProps[i].count, threadRegsetProps[i].count); - EXPECT_EQ(regsetProps[i].bitSize, threadRegsetProps[i].bitSize); - EXPECT_EQ(regsetProps[i].byteSize, threadRegsetProps[i].byteSize); - } -} - TEST_F(DebugSessionRegistersAccessTest, givenUnsupportedRegisterTypeWhenReadRegistersCalledThenErrorInvalidArgumentIsReturned) { session->areRequestedThreadsStoppedReturnValue = 1; EXPECT_EQ(ZE_RESULT_ERROR_INVALID_ARGUMENT, zetDebugReadRegisters(session->toHandle(), stoppedThread, 0x12345, 0, 1, nullptr)); diff --git a/level_zero/tools/test/unit_tests/sources/debug/test_debug_api.cpp b/level_zero/tools/test/unit_tests/sources/debug/test_debug_api.cpp index 4f7737d156..11d87d1192 100644 --- a/level_zero/tools/test/unit_tests/sources/debug/test_debug_api.cpp +++ b/level_zero/tools/test/unit_tests/sources/debug/test_debug_api.cpp @@ -374,7 +374,7 @@ TEST_F(DebugApiTest, givenGetRegisterSetPropertiesCalledWithV3HeaderCorrectPrope validateRegsetProps(regsetProps[1], ZET_DEBUG_REGSET_TYPE_ADDR_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE | ZET_DEBUG_REGSET_FLAG_WRITEABLE, 1, 256, 32); validateRegsetProps(regsetProps[2], ZET_DEBUG_REGSET_TYPE_FLAG_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE | ZET_DEBUG_REGSET_FLAG_WRITEABLE, 2, 32, 4); validateRegsetProps(regsetProps[3], ZET_DEBUG_REGSET_TYPE_CE_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE, 1, 32, 4); - validateRegsetProps(regsetProps[4], ZET_DEBUG_REGSET_TYPE_SR_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE | ZET_DEBUG_REGSET_FLAG_WRITEABLE, 2, 128, 16); + validateRegsetProps(regsetProps[4], ZET_DEBUG_REGSET_TYPE_SR_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE | ZET_DEBUG_REGSET_FLAG_WRITEABLE, 2, 160, 20); validateRegsetProps(regsetProps[5], ZET_DEBUG_REGSET_TYPE_CR_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE | ZET_DEBUG_REGSET_FLAG_WRITEABLE, 1, 128, 16); validateRegsetProps(regsetProps[6], ZET_DEBUG_REGSET_TYPE_TDR_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE, 1, 128, 16); validateRegsetProps(regsetProps[7], ZET_DEBUG_REGSET_TYPE_ACC_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE | ZET_DEBUG_REGSET_FLAG_WRITEABLE, 10, 256, 32); @@ -418,7 +418,7 @@ TEST_F(DebugApiTest, givenGetRegisterSetPropertiesCalledWhenV3HeaderHeaplessThen validateRegsetProps(regsetProps[1], ZET_DEBUG_REGSET_TYPE_ADDR_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE | ZET_DEBUG_REGSET_FLAG_WRITEABLE, 1, 256, 32); validateRegsetProps(regsetProps[2], ZET_DEBUG_REGSET_TYPE_FLAG_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE | ZET_DEBUG_REGSET_FLAG_WRITEABLE, 2, 32, 4); validateRegsetProps(regsetProps[3], ZET_DEBUG_REGSET_TYPE_CE_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE, 1, 32, 4); - validateRegsetProps(regsetProps[4], ZET_DEBUG_REGSET_TYPE_SR_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE | ZET_DEBUG_REGSET_FLAG_WRITEABLE, 2, 128, 16); + validateRegsetProps(regsetProps[4], ZET_DEBUG_REGSET_TYPE_SR_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE | ZET_DEBUG_REGSET_FLAG_WRITEABLE, 2, 160, 20); validateRegsetProps(regsetProps[5], ZET_DEBUG_REGSET_TYPE_CR_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE | ZET_DEBUG_REGSET_FLAG_WRITEABLE, 1, 128, 16); validateRegsetProps(regsetProps[6], ZET_DEBUG_REGSET_TYPE_TDR_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE, 1, 128, 16); validateRegsetProps(regsetProps[7], ZET_DEBUG_REGSET_TYPE_ACC_INTEL_GPU, ZET_DEBUG_REGSET_FLAG_READABLE | ZET_DEBUG_REGSET_FLAG_WRITEABLE, 10, 256, 32); diff --git a/level_zero/tools/test/unit_tests/sources/debug/xe2_hpg_core/debug_session_tests_xe2_hpg_core.cpp b/level_zero/tools/test/unit_tests/sources/debug/xe2_hpg_core/debug_session_tests_xe2_hpg_core.cpp index b6940aee59..0e2a4d45ed 100644 --- a/level_zero/tools/test/unit_tests/sources/debug/xe2_hpg_core/debug_session_tests_xe2_hpg_core.cpp +++ b/level_zero/tools/test/unit_tests/sources/debug/xe2_hpg_core/debug_session_tests_xe2_hpg_core.cpp @@ -90,5 +90,38 @@ HWTEST2_F(DebugApiTest, givenDeviceWhenDebugAttachIsAvaialbleThenGetPropertiesRe EXPECT_EQ(ZET_DEVICE_DEBUG_PROPERTY_FLAG_ATTACH, debugProperties.flags); } +using DebugSessionRegistersAccessTestProductSpecfic = Test; +HWTEST2_F(DebugSessionRegistersAccessTestProductSpecfic, GivenGetThreadRegisterSetPropertiesCalledPropertieAreTheSameAsGetRegisterSetProperties, + IsAtMostXe2HpgCore) { + + auto mockBuiltins = new MockBuiltins(); + mockBuiltins->stateSaveAreaHeader = MockSipData::createStateSaveAreaHeader(2); + MockRootDeviceEnvironment::resetBuiltins(neoDevice->executionEnvironment->rootDeviceEnvironments[0].get(), mockBuiltins); + + uint32_t count = 0; + uint32_t threadCount = 0; + ze_device_thread_t thread = stoppedThread; + EXPECT_EQ(ZE_RESULT_SUCCESS, zetDebugGetRegisterSetProperties(session->getConnectedDevice(), &count, nullptr)); + EXPECT_EQ(13u, count); + EXPECT_EQ(ZE_RESULT_SUCCESS, zetDebugGetThreadRegisterSetProperties(session->toHandle(), thread, &threadCount, nullptr)); + ASSERT_EQ(threadCount, count); + + std::vector regsetProps(count); + ASSERT_EQ(ZE_RESULT_SUCCESS, zetDebugGetRegisterSetProperties(session->getConnectedDevice(), &count, regsetProps.data())); + std::vector threadRegsetProps(count); + ASSERT_EQ(ZE_RESULT_SUCCESS, zetDebugGetThreadRegisterSetProperties(session->toHandle(), thread, &count, threadRegsetProps.data())); + + for (size_t i = 0; i < count; i++) { + EXPECT_EQ(regsetProps[i].stype, threadRegsetProps[i].stype); + EXPECT_EQ(regsetProps[i].pNext, threadRegsetProps[i].pNext); + EXPECT_EQ(regsetProps[i].version, threadRegsetProps[i].version); + EXPECT_EQ(regsetProps[i].generalFlags, threadRegsetProps[i].generalFlags); + EXPECT_EQ(regsetProps[i].deviceFlags, threadRegsetProps[i].deviceFlags); + EXPECT_EQ(regsetProps[i].count, threadRegsetProps[i].count); + EXPECT_EQ(regsetProps[i].bitSize, threadRegsetProps[i].bitSize); + EXPECT_EQ(regsetProps[i].byteSize, threadRegsetProps[i].byteSize); + } +} + } // namespace ult } // namespace L0 diff --git a/shared/source/helpers/gfx_core_helper.h b/shared/source/helpers/gfx_core_helper.h index 274e023831..444da0919d 100644 --- a/shared/source/helpers/gfx_core_helper.h +++ b/shared/source/helpers/gfx_core_helper.h @@ -103,7 +103,6 @@ class GfxCoreHelper { virtual uint8_t getBarriersCountFromHasBarriers(uint8_t hasBarriers) const = 0; virtual uint32_t calculateAvailableThreadCount(const HardwareInfo &hwInfo, uint32_t grfCount) const = 0; virtual uint32_t calculateMaxWorkGroupSize(const KernelDescriptor &kernelDescriptor, uint32_t defaultMaxGroupSize) const = 0; - virtual bool largeGrfModeSupported() const = 0; virtual uint32_t alignSlmSize(uint32_t slmSize) const = 0; virtual uint32_t computeSlmValues(const HardwareInfo &hwInfo, uint32_t slmSize) const = 0; @@ -308,7 +307,6 @@ class GfxCoreHelperHw : public GfxCoreHelper { uint32_t calculateAvailableThreadCount(const HardwareInfo &hwInfo, uint32_t grfCount) const override; uint32_t calculateMaxWorkGroupSize(const KernelDescriptor &kernelDescriptor, uint32_t defaultMaxGroupSize) const override; - bool largeGrfModeSupported() const override; uint32_t alignSlmSize(uint32_t slmSize) const override; diff --git a/shared/source/helpers/gfx_core_helper_base.inl b/shared/source/helpers/gfx_core_helper_base.inl index 55fa2ac78d..daa842971b 100644 --- a/shared/source/helpers/gfx_core_helper_base.inl +++ b/shared/source/helpers/gfx_core_helper_base.inl @@ -647,11 +647,6 @@ bool GfxCoreHelperHw::isChipsetUniqueUUIDSupported() const { return false; } -template -bool GfxCoreHelperHw::largeGrfModeSupported() const { - return false; -} - template bool GfxCoreHelperHw::isTimestampShiftRequired() const { return true; diff --git a/shared/source/helpers/gfx_core_helper_xehp_and_later.inl b/shared/source/helpers/gfx_core_helper_xehp_and_later.inl index 7885fb8152..94d2549646 100644 --- a/shared/source/helpers/gfx_core_helper_xehp_and_later.inl +++ b/shared/source/helpers/gfx_core_helper_xehp_and_later.inl @@ -210,11 +210,6 @@ bool GfxCoreHelperHw::isChipsetUniqueUUIDSupported() const { return true; } -template <> -bool GfxCoreHelperHw::largeGrfModeSupported() const { - return true; -} - template uint32_t GfxCoreHelperHw::getKernelPrivateMemSize(const KernelDescriptor &kernelDescriptor) const { const auto &kernelAttributes = kernelDescriptor.kernelAttributes; diff --git a/shared/test/common/helpers/sip_init.cpp b/shared/test/common/helpers/sip_init.cpp index 35e3168181..9d4160ab0b 100644 --- a/shared/test/common/helpers/sip_init.cpp +++ b/shared/test/common/helpers/sip_init.cpp @@ -162,7 +162,7 @@ std::vector createStateSaveAreaHeader(uint32_t version, uint16_t grfNum, u {4096, 1, 256, 32}, // addr {4128, 2, 32, 4}, // flag {4156, 1, 32, 4}, // emask - {4160, 2, 128, 16}, // sr + {4160, 2, 160, 20}, // sr {4192, 1, 128, 16}, // cr {4256, 1, 96, 12}, // notification {4288, 1, 128, 16}, // tdr diff --git a/shared/test/unit_test/gen12lp/dg1/gfx_core_helper_tests_dg1.cpp b/shared/test/unit_test/gen12lp/dg1/gfx_core_helper_tests_dg1.cpp index 97eb8cf987..97808c6f5d 100644 --- a/shared/test/unit_test/gen12lp/dg1/gfx_core_helper_tests_dg1.cpp +++ b/shared/test/unit_test/gen12lp/dg1/gfx_core_helper_tests_dg1.cpp @@ -19,11 +19,6 @@ using GfxCoreHelperTestDg1 = GfxCoreHelperTest; -DG1TEST_F(GfxCoreHelperTestDg1, givenDg1SteppingWhenLargeGrfModeSupportedIsQueriedThenFalseIsReturned) { - auto &gfxCoreHelper = getHelper(); - EXPECT_FALSE(gfxCoreHelper.largeGrfModeSupported()); -} - DG1TEST_F(GfxCoreHelperTestDg1, givenDg1SteppingA0WhenAdjustDefaultEngineTypeCalledThenRcsIsReturned) { auto &gfxCoreHelper = getHelper(); const auto &productHelper = getHelper(); diff --git a/shared/test/unit_test/xe2_hpg_core/gfx_core_helper_tests_xe2_hpg_core.cpp b/shared/test/unit_test/xe2_hpg_core/gfx_core_helper_tests_xe2_hpg_core.cpp index 95874eb8da..cadc79d8d9 100644 --- a/shared/test/unit_test/xe2_hpg_core/gfx_core_helper_tests_xe2_hpg_core.cpp +++ b/shared/test/unit_test/xe2_hpg_core/gfx_core_helper_tests_xe2_hpg_core.cpp @@ -732,11 +732,6 @@ XE2_HPG_CORETEST_F(GfxCoreHelperTestsXe2HpgCore, givenParamsWhenCalculateNumThre } } -XE2_HPG_CORETEST_F(GfxCoreHelperTestsXe2HpgCore, givenXe2HpgWhenLargeGrfModeSupportedIsQueriedThenTrueIsReturned) { - auto &gfxCoreHelper = getHelper(); - EXPECT_TRUE(gfxCoreHelper.largeGrfModeSupported()); -} - XE2_HPG_CORETEST_F(GfxCoreHelperTestsXe2HpgCore, givenGfxCoreHelperWhenFlagSetAndCallGetAmountOfAllocationsToFillThenReturnCorrectValue) { DebugManagerStateRestore restorer; MockExecutionEnvironment mockExecutionEnvironment{};