diff --git a/opencl/test/unit_test/command_queue/command_enqueue_fixture.h b/opencl/test/unit_test/command_queue/command_enqueue_fixture.h index a4f44e0b33..2db7427c1f 100644 --- a/opencl/test/unit_test/command_queue/command_enqueue_fixture.h +++ b/opencl/test/unit_test/command_queue/command_enqueue_fixture.h @@ -1,5 +1,5 @@ /* - * Copyright (C) 2018-2022 Intel Corporation + * Copyright (C) 2018-2023 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -127,7 +127,8 @@ struct CommandQueueStateful : public CommandQueueHw { auto kernel = dispatchInfo.begin()->getKernel(); EXPECT_FALSE(kernel->getKernelInfo().kernelDescriptor.kernelAttributes.supportsBuffersBiggerThan4Gb()); - if (GfxCoreHelperHw::get().isStatelessToStatefulWithOffsetSupported()) { + auto &gfxCoreHelper = kernel->getContext().getDevice(0)->getGfxCoreHelper(); + if (gfxCoreHelper.isStatelessToStatefulWithOffsetSupported()) { EXPECT_TRUE(kernel->allBufferArgsStateful); } diff --git a/opencl/test/unit_test/gen12lp/hw_helper_tests_gen12lp.inl b/opencl/test/unit_test/gen12lp/hw_helper_tests_gen12lp.inl index 3f791ddeee..aa8324d109 100644 --- a/opencl/test/unit_test/gen12lp/hw_helper_tests_gen12lp.inl +++ b/opencl/test/unit_test/gen12lp/hw_helper_tests_gen12lp.inl @@ -110,8 +110,9 @@ GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeNotSetAndBcsInfoSetWhenGe hwInfo.capabilityTable.defaultEngineType = aub_stream::ENGINE_RCS; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(4u, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); EXPECT_EQ(4u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[1].first); @@ -126,8 +127,9 @@ GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeNotSetAndCcsDefualtEngine hwInfo.capabilityTable.defaultEngineType = aub_stream::ENGINE_CCS; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(3u, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[1].first); @@ -141,8 +143,9 @@ GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeNotSetWhenGetGpgpuEngines hwInfo.capabilityTable.defaultEngineType = aub_stream::ENGINE_RCS; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(3u, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[0].first); @@ -157,8 +160,9 @@ GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeSetWhenGetGpgpuEnginesThe hwInfo.capabilityTable.defaultEngineType = aub_stream::ENGINE_CCS; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(4u, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); EXPECT_EQ(4u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[1].first); @@ -174,8 +178,9 @@ GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeSetFtrGpGpuMidThreadLevel hwInfo.capabilityTable.defaultEngineType = aub_stream::ENGINE_CCS; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(3u, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[1].first); @@ -190,8 +195,9 @@ GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeSetFtrGpGpuMidThreadLevel hwInfo.capabilityTable.defaultEngineType = aub_stream::ENGINE_CCS; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(4u, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); EXPECT_EQ(4u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[1].first); @@ -206,8 +212,9 @@ GEN12LPTEST_F(GfxCoreHelperTestGen12Lp, givenFtrCcsNodeSetAndDefaultRcsWhenGetGp hwInfo.capabilityTable.defaultEngineType = aub_stream::ENGINE_RCS; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(3u, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[0].first); EXPECT_EQ(aub_stream::ENGINE_RCS, engines[1].first); diff --git a/opencl/test/unit_test/helpers/test_preamble_xehp_and_later.cpp b/opencl/test/unit_test/helpers/test_preamble_xehp_and_later.cpp index a58505520f..fd36587cb7 100644 --- a/opencl/test/unit_test/helpers/test_preamble_xehp_and_later.cpp +++ b/opencl/test/unit_test/helpers/test_preamble_xehp_and_later.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2021-2022 Intel Corporation + * Copyright (C) 2021-2023 Intel Corporation * * SPDX-License-Identifier: MIT * @@ -25,7 +25,9 @@ using namespace NEO; using ThreadArbitrationXeHPAndLater = PreambleFixture; HWTEST2_F(ThreadArbitrationXeHPAndLater, whenGetDefaultThreadArbitrationPolicyIsCalledThenCorrectPolicyIsReturned, IsXeHpOrXeHpgCore) { - EXPECT_EQ(ThreadArbitrationPolicy::AgeBased, GfxCoreHelperHw::get().getDefaultThreadArbitrationPolicy()); + auto &gfxCoreHelper = getHelper(); + + EXPECT_EQ(ThreadArbitrationPolicy::AgeBased, gfxCoreHelper.getDefaultThreadArbitrationPolicy()); } using ProgramPipelineXeHPAndLater = PreambleFixture; diff --git a/opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp b/opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp index c80545d015..c0f166aeed 100644 --- a/opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp +++ b/opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp @@ -131,9 +131,9 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCccsDisabledButDebugVariable DebugManager.flags.NodeOrdinal.set(static_cast(aub_stream::EngineType::ENGINE_CCCS)); auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); - + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(13u, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); EXPECT_EQ(13u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); @@ -163,9 +163,9 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCccsDisabledWhenIsCooperativ hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 4; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); - + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(12u, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); EXPECT_EQ(12u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCS, engines[0].first); @@ -194,9 +194,9 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenBcsDisabledWhenIsCooperative hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 4; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); - + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -239,9 +239,9 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenOneBcsEnabledWhenIsCooperati hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 4; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); - + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -290,9 +290,9 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenNotAllCopyEnginesWhenIsCoope hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 1; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); - + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -334,9 +334,9 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenOneCcsEnabledWhenIsCooperati hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 1; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); - + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -384,9 +384,9 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCccsAsDefaultEngineWhenIsCoo hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 4; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); - + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -440,9 +440,9 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, whenIsCooperativeEngineSupportedE hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 4; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); - + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -496,9 +496,9 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, whenIsCooperativeEngineSupportedE hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 4; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); - + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(numEngines, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(device->getHardwareInfo()); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(device->getHardwareInfo()); EXPECT_EQ(numEngines, engines.size()); struct EnginePropertiesMap { @@ -547,9 +547,9 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCcsDisabledAndNumberOfCcsEna hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 4; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); - + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(3u, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCCS, engines[0].first); @@ -565,9 +565,9 @@ XE_HPC_CORETEST_F(GfxCoreHelperTestsXeHpcCore, givenCcsDisabledWhenGetGpgpuEngin hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 0; auto device = std::unique_ptr(MockDevice::createWithNewExecutionEnvironment(&hwInfo, 0)); - + auto &gfxCoreHelper = device->getGfxCoreHelper(); EXPECT_EQ(3u, device->allEngines.size()); - auto &engines = GfxCoreHelperHw::get().getGpgpuEngineInstances(hwInfo); + auto &engines = gfxCoreHelper.getGpgpuEngineInstances(hwInfo); EXPECT_EQ(3u, engines.size()); EXPECT_EQ(aub_stream::ENGINE_CCCS, engines[0].first);