Remove default support for DCD

Related-To: NEO-7213
Signed-off-by: Fabian Zwolinski <fabian.zwolinski@intel.com>
This commit is contained in:
Fabian Zwolinski
2023-04-18 22:35:59 +00:00
committed by Compute-Runtime-Automation
parent 21ac5f2835
commit a3e923e359
56 changed files with 377 additions and 212 deletions

View File

@@ -1,5 +1,5 @@
/*
* Copyright (C) 2018-2021 Intel Corporation
* Copyright (C) 2018-2023 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@@ -35,6 +35,9 @@ void *DebuggerLibrary::getProcAddress(const std::string &procName) {
}
OsLibrary *DebuggerLibrary::load(const std::string &name) {
if (interceptor) {
interceptor->loadCalled = true;
}
if (isLibraryAvailable) {
return new DebuggerLibrary();
}

View File

@@ -1,5 +1,5 @@
/*
* Copyright (C) 2018-2022 Intel Corporation
* Copyright (C) 2018-2023 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@@ -36,6 +36,7 @@ struct DebuggerLibraryInterceptor {
bool kernelDebugDataCalled = false;
bool initCalled = false;
bool deviceDestructionCalled = false;
bool loadCalled = false;
int newDeviceRetVal = 0;
int sourceCodeRetVal = 0;

View File

@@ -84,3 +84,21 @@ using IsNotPVC = IsNotWithinProducts<IGFX_PVC, IGFX_PVC>;
using HasStatefulSupport = IsNotAnyGfxCores<IGFX_XE_HPC_CORE>;
using HasNoStatefulSupport = IsAnyGfxCores<IGFX_XE_HPC_CORE>;
using HasSourceLevelDebuggerSupport = IsAnyProducts<IGFX_ELKHARTLAKE,
IGFX_ICELAKE_LP,
IGFX_LAKEFIELD,
IGFX_ALDERLAKE_N,
IGFX_ALDERLAKE_P,
IGFX_ALDERLAKE_S,
IGFX_DG1,
IGFX_ROCKETLAKE,
IGFX_TIGERLAKE_LP,
IGFX_BROXTON,
IGFX_COFFEELAKE,
IGFX_GEMINILAKE,
IGFX_KABYLAKE,
IGFX_SKYLAKE,
IGFX_XE_HP_SDV,
IGFX_DG2,
IGFX_METEORLAKE>;

View File

@@ -22,6 +22,7 @@
#include "shared/test/common/mocks/mock_graphics_allocation.h"
#include "shared/test/common/mocks/mock_modules_zebin.h"
#include "shared/test/common/mocks/ult_device_factory.h"
#include "shared/test/common/test_macros/hw_test.h"
#include "RelocationInfo.h"
#include "gtest/gtest.h"
@@ -1987,10 +1988,9 @@ TEST(LinkerTests, givenImplicitArgRelocationAndStackCallsThenPatchRelocationWith
EXPECT_TRUE(kernelDescriptor.kernelAttributes.flags.requiresImplicitArgs);
}
TEST(LinkerTests, givenImplicitArgRelocationAndEnabledDebuggerThenPatchRelocationWithSizeOfImplicitArgStructAndUpdateKernelDescriptor) {
if (!defaultHwInfo->capabilityTable.debuggerSupported) {
GTEST_SKIP();
}
using LinkerDebuggingSupportedTests = ::testing::Test;
HWTEST2_F(LinkerDebuggingSupportedTests, givenImplicitArgRelocationAndEnabledDebuggerThenPatchRelocationWithSizeOfImplicitArgStructAndUpdateKernelDescriptor, HasSourceLevelDebuggerSupport) {
NEO::LinkerInput linkerInput;
vISA::GenRelocEntry reloc = {};
@@ -2022,7 +2022,10 @@ TEST(LinkerTests, givenImplicitArgRelocationAndEnabledDebuggerThenPatchRelocatio
DebugManagerStateRestore restorer;
DebugManager.flags.EnableMockSourceLevelDebugger.set(1);
UltDeviceFactory deviceFactory{1, 0};
NEO::HardwareInfo hwInfo = *NEO::defaultHwInfo;
hwInfo.capabilityTable.debuggerSupported = true;
auto executionEnvironment = MockDevice::prepareExecutionEnvironment(&hwInfo, 0u);
UltDeviceFactory deviceFactory{1, 0, *executionEnvironment};
auto device = deviceFactory.rootDevices[0];
EXPECT_NE(nullptr, device->getDebugger());
@@ -2149,10 +2152,7 @@ TEST(LinkerTests, givenNoImplicitArgRelocationAndStackCallsThenImplicitArgsAreNo
EXPECT_FALSE(kernelDescriptor.kernelAttributes.flags.requiresImplicitArgs);
}
TEST(LinkerTests, givenNoImplicitArgRelocationAndEnabledDebuggerThenImplicitArgsAreNotRequired) {
if (!defaultHwInfo->capabilityTable.debuggerSupported) {
GTEST_SKIP();
}
HWTEST2_F(LinkerDebuggingSupportedTests, givenNoImplicitArgRelocationAndEnabledDebuggerThenImplicitArgsAreNotRequired, HasSourceLevelDebuggerSupport) {
NEO::LinkerInput linkerInput;
NEO::Linker linker(linkerInput);
@@ -2173,7 +2173,10 @@ TEST(LinkerTests, givenNoImplicitArgRelocationAndEnabledDebuggerThenImplicitArgs
DebugManagerStateRestore restorer;
DebugManager.flags.EnableMockSourceLevelDebugger.set(1);
UltDeviceFactory deviceFactory{1, 0};
NEO::HardwareInfo hwInfo = *NEO::defaultHwInfo;
hwInfo.capabilityTable.debuggerSupported = true;
auto executionEnvironment = MockDevice::prepareExecutionEnvironment(&hwInfo, 0u);
UltDeviceFactory deviceFactory{1, 0, *executionEnvironment};
auto device = deviceFactory.rootDevices[0];
EXPECT_NE(nullptr, device->getDebugger());

View File

@@ -16,6 +16,10 @@ using namespace NEO;
using Gen11DeviceCaps = Test<DeviceFixture>;
GEN11TEST_F(Gen11DeviceCaps, givenGen11ThenDebuggerIsNotSupported) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.debuggerSupported);
}
GEN11TEST_F(Gen11DeviceCaps, GivenDefaultWhenCheckingPreemptionModeThenMidThreadIsReturned) {
EXPECT_TRUE(PreemptionMode::MidThread == pDevice->getHardwareInfo().capabilityTable.defaultPreemptionMode);
}

View File

@@ -16,6 +16,10 @@ using namespace NEO;
using AdlnUsDeviceIdTest = Test<DeviceFixture>;
ADLNTEST_F(AdlnUsDeviceIdTest, givenAdlnThenDebuggerIsNotSupported) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.debuggerSupported);
}
ADLNTEST_F(AdlnUsDeviceIdTest, givenAdlnWhenCheckFtrSupportsInteger64BitAtomicsThenReturnFalse) {
EXPECT_TRUE(pDevice->getHardwareInfo().capabilityTable.ftrSupportsInteger64BitAtomics);
}

View File

@@ -16,6 +16,10 @@ using namespace NEO;
using AdlpUsDeviceIdTest = Test<DeviceFixture>;
ADLPTEST_F(AdlpUsDeviceIdTest, givenADLPThenDebuggerIsNotSupported) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.debuggerSupported);
}
ADLPTEST_F(AdlpUsDeviceIdTest, givenADLPWhenCheckFtrSupportsInteger64BitAtomicsThenReturnFalse) {
EXPECT_TRUE(pDevice->getHardwareInfo().capabilityTable.ftrSupportsInteger64BitAtomics);
}

View File

@@ -16,6 +16,10 @@ using namespace NEO;
using AdlsUsDeviceIdTest = Test<DeviceFixture>;
ADLSTEST_F(AdlsUsDeviceIdTest, givenAdlsThenDebuggerIsNotSupported) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.debuggerSupported);
}
ADLSTEST_F(AdlsUsDeviceIdTest, givenAdlsWhenCheckFtrSupportsInteger64BitAtomicsThenReturnFalse) {
EXPECT_TRUE(pDevice->getHardwareInfo().capabilityTable.ftrSupportsInteger64BitAtomics);
}

View File

@@ -16,6 +16,10 @@ using namespace NEO;
using Dg1DeviceCaps = Test<DeviceFixture>;
DG1TEST_F(Dg1DeviceCaps, givenDg1ThenDebuggerIsNotSupported) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.debuggerSupported);
}
DG1TEST_F(Dg1DeviceCaps, givenDg1WhenCheckSupportCacheFlushAfterWalkerThenFalse) {
EXPECT_TRUE(pDevice->getHardwareInfo().capabilityTable.supportCacheFlushAfterWalker);
}

View File

@@ -14,6 +14,10 @@ using namespace NEO;
using Gen12LpDeviceCaps = Test<DeviceFixture>;
GEN12LPTEST_F(Gen12LpDeviceCaps, givenGen12LpThenDebuggerIsNotSupported) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.debuggerSupported);
}
GEN12LPTEST_F(Gen12LpDeviceCaps, GivenDefaultWhenCheckingPreemptionModeThenMidThreadIsReported) {
EXPECT_EQ(PreemptionMode::MidThread, pDevice->getHardwareInfo().capabilityTable.defaultPreemptionMode);
}

View File

@@ -16,6 +16,10 @@ using namespace NEO;
using Gen8DeviceCaps = Test<DeviceFixture>;
GEN8TEST_F(Gen8DeviceCaps, GivenGen8ThenDebuggerIsNotSupported) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.debuggerSupported);
}
GEN8TEST_F(Gen8DeviceCaps, GivenDefaultWhenCheckingPreemptionModeThenDisabledIsReported) {
EXPECT_TRUE(PreemptionMode::Disabled == pDevice->getHardwareInfo().capabilityTable.defaultPreemptionMode);
}

View File

@@ -17,6 +17,10 @@ using namespace NEO;
using Gen9DeviceCaps = Test<DeviceFixture>;
GEN9TEST_F(Gen9DeviceCaps, givenGen9ThenDebuggerIsNotSupported) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.debuggerSupported);
}
GEN9TEST_F(Gen9DeviceCaps, GivenDefaultWhenCheckingPreemptionModeThenMidThreadIsSupported) {
EXPECT_EQ(PreemptionMode::MidThread, pDevice->getHardwareInfo().capabilityTable.defaultPreemptionMode);
}

View File

@@ -18,6 +18,10 @@ using namespace NEO;
using XeHpcCoreDeviceCaps = Test<DeviceFixture>;
XE_HPC_CORETEST_F(XeHpcCoreDeviceCaps, givenXeHpcCoreThenDebuggerIsNotSupported) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.debuggerSupported);
}
XE_HPC_CORETEST_F(XeHpcCoreDeviceCaps, givenXeHpcCoreWhenCheckFtrSupportsInteger64BitAtomicsThenReturnTrue) {
EXPECT_TRUE(pDevice->getHardwareInfo().capabilityTable.ftrSupportsInteger64BitAtomics);
}

View File

@@ -15,6 +15,10 @@ using namespace NEO;
using Dg2UsDeviceIdTest = Test<DeviceFixture>;
DG2TEST_F(Dg2UsDeviceIdTest, givenDg2ThenDebuggerIsNotSupported) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.debuggerSupported);
}
DG2TEST_F(Dg2UsDeviceIdTest, givenDg2ProductWhenCheckBlitterOperationsSupportThenReturnFalse) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.blitterOperationsSupported);
}

View File

@@ -13,6 +13,10 @@ using namespace NEO;
using MtlUsDeviceIdTest = Test<DeviceFixture>;
MTLTEST_F(MtlUsDeviceIdTest, givenMtlThenDebuggerIsNotSupported) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.debuggerSupported);
}
MTLTEST_F(MtlUsDeviceIdTest, givenMtlProductWhenCheckFp64SupportThenReturnFalse) {
EXPECT_TRUE(pDevice->getHardwareInfo().capabilityTable.ftrSupportsFP64);
}

View File

@@ -18,6 +18,10 @@ using namespace NEO;
using XeHpgCoreDeviceCaps = Test<DeviceFixture>;
XE_HPG_CORETEST_F(XeHpgCoreDeviceCaps, givenXeHpgCoreThenDebuggerIsNotSupported) {
EXPECT_FALSE(pDevice->getHardwareInfo().capabilityTable.debuggerSupported);
}
XE_HPG_CORETEST_F(XeHpgCoreDeviceCaps, givenXeHpgCoreWhenCheckFtrSupportsInteger64BitAtomicsThenReturnTrue) {
EXPECT_TRUE(pDevice->getHardwareInfo().capabilityTable.ftrSupportsInteger64BitAtomics);
}