intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-12-30 01:35:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "fix: Add -emit-lib-compile-errors flag when library compilation is en...

Browse Source 
This reverts commit c9ebf91271.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
This commit is contained in:
Compute-Runtime-Validation
2025-07-13 13:32:48 +02:00
committed by Compute-Runtime-Automation
parent 89ccfa08ae
commit a6149fca1a
3 changed files with 1 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
level_zero/core/source/module/module_imp.cpp
View File

@@ -73,8 +73,6 @@ NEO::ConstStringRef optAutoGrf = "-ze-intel-enable-auto-large-GRF-mode";
NEO::ConstStringRef enableLibraryCompile = "-library-compilation";
NEO::ConstStringRef enableGlobalVariableSymbols = "-ze-take-global-address";
NEO::ConstStringRef enableFP64GenEmu = "-ze-fp64-gen-emu";
NEO::ConstStringRef emitLibCompileErrors = "-ze-emit-lib-compile-errors";
} // namespace BuildOptions
ModuleTranslationUnit::ModuleTranslationUnit(L0::Device *device)
@@ -929,9 +927,6 @@ void ModuleImp::createBuildOptions(const char *pBuildFlags, std::string &apiOpti
moveOptLevelOption(apiOptions, apiOptions);
moveProfileFlagsOption(apiOptions, apiOptions);
this->isFunctionSymbolExportEnabled = moveBuildOption(apiOptions, apiOptions, BuildOptions::enableLibraryCompile, BuildOptions::enableLibraryCompile);
if (this->isFunctionSymbolExportEnabled) {
NEO::CompilerOptions::concatenateAppend(apiOptions, BuildOptions::emitLibCompileErrors.str());
}
this->isGlobalSymbolExportEnabled = moveBuildOption(apiOptions, apiOptions, BuildOptions::enableGlobalVariableSymbols, BuildOptions::enableGlobalVariableSymbols);
if (getDevice()->getNEODevice()->getExecutionEnvironment()->isOneApiPvcWaEnv() == false) {

2
level_zero/core/source/module/module_imp.h
View File

@@ -44,7 +44,7 @@ extern NEO::ConstStringRef optAutoGrf;
extern NEO::ConstStringRef enableLibraryCompile;
extern NEO::ConstStringRef enableGlobalVariableSymbols;
extern NEO::ConstStringRef enableFP64GenEmu;
extern NEO::ConstStringRef emitLibCompileErrors;
} // namespace BuildOptions
struct ModuleTranslationUnit {

29
level_zero/core/test/unit_tests/sources/module/test_module_2.cpp
View File

@@ -478,34 +478,5 @@ TEST_F(ModuleTests, givenFP64EmulationEnabledWhenCreatingModuleThenEnableFP64Gen
EXPECT_TRUE(CompilerOptions::contains(cip->buildInternalOptions, BuildOptions::enableFP64GenEmu));
};
TEST_F(ModuleTests, whenLibraryCompilationFlagIsEnabledThenEmitLibCompileErrorsIsAppendedToApiOptions) {
auto mockModule = std::make_unique<L0::ult::MockModule>(device, nullptr, ModuleType::user);
ASSERT_NE(nullptr, mockModule.get());
{
std::string apiOptions;
std::string internalBuildOptions;
const char *buildFlags = "-library-compilation";
mockModule->createBuildOptions(buildFlags, apiOptions, internalBuildOptions);
EXPECT_TRUE(mockModule->isFunctionSymbolExportEnabled);
EXPECT_TRUE(NEO::CompilerOptions::contains(apiOptions, "-ze-emit-lib-compile-errors"));
EXPECT_TRUE(NEO::CompilerOptions::contains(apiOptions, "-library-compilation"));
}
{
std::string apiOptions;
std::string internalBuildOptions;
const char *buildFlags = "-some-other-flag";
mockModule->createBuildOptions(buildFlags, apiOptions, internalBuildOptions);
EXPECT_FALSE(mockModule->isFunctionSymbolExportEnabled);
EXPECT_FALSE(NEO::CompilerOptions::contains(apiOptions, "-ze-emit-lib-compile-errors"));
EXPECT_FALSE(NEO::CompilerOptions::contains(apiOptions, "-library-compilation"));
}
}
} // namespace ult
} // namespace L0