From a8fbed612033b65843504680dd1637bdc10cd521 Mon Sep 17 00:00:00 2001 From: Mateusz Jablonski Date: Fri, 1 Mar 2024 12:37:42 +0000 Subject: [PATCH] feature: enable dummy blit WA for PVC Related-To: NEO-9996 Signed-off-by: Mateusz Jablonski --- .../xe_hpc_core/pvc/os_agnostic_product_helper_pvc.inl | 5 +++++ .../unit_test/xe_hpc_core/pvc/excludes_xe_hpc_core_pvc.cpp | 1 + .../unit_test/xe_hpc_core/pvc/test_product_helper_pvc.cpp | 4 ++++ 3 files changed, 10 insertions(+) diff --git a/shared/source/xe_hpc_core/pvc/os_agnostic_product_helper_pvc.inl b/shared/source/xe_hpc_core/pvc/os_agnostic_product_helper_pvc.inl index 1bac079e4a..11e25f2d48 100644 --- a/shared/source/xe_hpc_core/pvc/os_agnostic_product_helper_pvc.inl +++ b/shared/source/xe_hpc_core/pvc/os_agnostic_product_helper_pvc.inl @@ -11,6 +11,11 @@ #include "aubstream/product_family.h" namespace NEO { +template <> +bool ProductHelperHw::isDummyBlitWaRequired() const { + return true; +} + template <> bool ProductHelperHw::isMaxThreadsForWorkgroupWARequired(const HardwareInfo &hwInfo) const { return PVC::isXl(hwInfo); diff --git a/shared/test/unit_test/xe_hpc_core/pvc/excludes_xe_hpc_core_pvc.cpp b/shared/test/unit_test/xe_hpc_core/pvc/excludes_xe_hpc_core_pvc.cpp index d9b469abd7..3c64fcc90a 100644 --- a/shared/test/unit_test/xe_hpc_core/pvc/excludes_xe_hpc_core_pvc.cpp +++ b/shared/test/unit_test/xe_hpc_core/pvc/excludes_xe_hpc_core_pvc.cpp @@ -10,3 +10,4 @@ HWTEST_EXCLUDE_PRODUCT(ProductHelperTest, givenProductHelperWhenAskedIfIsBlitSplitEnqueueWARequiredThenReturnFalse, IGFX_PVC); HWTEST_EXCLUDE_PRODUCT(BlitTests, GivenCpuAccessToLocalMemoryWhenGettingMaxBlitSizeThenValuesAreOverriden_BlitPlatforms, IGFX_PVC); HWTEST_EXCLUDE_PRODUCT(GfxCoreHelperTest, GivenCooperativeEngineSupportedAndNotUsedWhenAdjustMaxWorkGroupCountIsCalledThenSmallerValueIsReturned, IGFX_PVC); +HWTEST_EXCLUDE_PRODUCT(ProductHelperTest, givenProductHelperWhenCheckDummyBlitWaRequiredThenReturnFalse, IGFX_PVC); diff --git a/shared/test/unit_test/xe_hpc_core/pvc/test_product_helper_pvc.cpp b/shared/test/unit_test/xe_hpc_core/pvc/test_product_helper_pvc.cpp index 65c18c4fdb..e3edb0ffdf 100644 --- a/shared/test/unit_test/xe_hpc_core/pvc/test_product_helper_pvc.cpp +++ b/shared/test/unit_test/xe_hpc_core/pvc/test_product_helper_pvc.cpp @@ -329,3 +329,7 @@ PVCTEST_F(PvcProductHelper, givenPvcProductHelperAndKernelBinaryFormatsWhenCheck PVCTEST_F(PvcProductHelper, whenQueryingMaxNumSamplersThenReturnZero) { EXPECT_EQ(0u, productHelper->getMaxNumSamplers()); } + +PVCTEST_F(PvcProductHelper, whenCheckingIfDummyBlitWaIsRequiredThenTrueIsReturned) { + EXPECT_TRUE(productHelper->isDummyBlitWaRequired()); +}