refactor: remove unused variable

Signed-off-by: Lukasz Jobczyk <lukasz.jobczyk@intel.com>
This commit is contained in:
Lukasz Jobczyk
2025-09-11 08:17:47 +00:00
committed by Compute-Runtime-Automation
parent d20c9264e5
commit aa74555682
24 changed files with 15 additions and 169 deletions

View File

@@ -43,7 +43,6 @@ set(RUNTIME_SRCS_DLL_LINUX
${NEO_SHARED_DIRECTORY}/dll/linux/drm_neo_create.cpp
${NEO_SHARED_DIRECTORY}/dll/linux${BRANCH_DIR_SUFFIX}/options_linux.cpp
${NEO_SHARED_DIRECTORY}/dll/linux/options_linux.inl
${NEO_SHARED_DIRECTORY}/dll/linux/os_interface.cpp
${NEO_SHARED_DIRECTORY}/dll/devices${BRANCH_DIR_SUFFIX}devices.inl
${NEO_SHARED_DIRECTORY}/dll/devices/devices_base.inl
${NEO_SHARED_DIRECTORY}/os_interface/linux/sys_calls_linux.cpp
@@ -66,7 +65,6 @@ set(RUNTIME_SRCS_DLL_WINDOWS
${NEO_SHARED_DIRECTORY}/dll/windows/debugger_l0_windows.cpp
${NEO_SHARED_DIRECTORY}/dll/windows${BRANCH_DIR_SUFFIX}/options_windows.cpp
${NEO_SHARED_DIRECTORY}/dll/windows/options_windows.inl
${NEO_SHARED_DIRECTORY}/dll/windows/os_interface.cpp
${NEO_SHARED_DIRECTORY}/gmm_helper/windows/gmm_memory.cpp
${NEO_SHARED_DIRECTORY}/os_interface/windows/os_memory_virtual_alloc.cpp
${NEO_SHARED_DIRECTORY}/os_interface/windows/sys_calls.cpp

View File

@@ -1385,9 +1385,6 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, GivenPipeContr
}
HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenProgramWalkerIsCalledThenWalkerPartitionLogicIsExecuted) {
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
using WalkerType = typename FamilyType::DefaultWalkerType;
debugManager.flags.EnableWalkerPartition.set(1u);
@@ -1405,9 +1402,6 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenProgramWal
}
HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenProgramWalkerIsCalledAndForceSynchronizeWalkerInWpariModeThenWalkerPartitionLogicIsExecuted) {
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
using WalkerType = typename FamilyType::DefaultWalkerType;
debugManager.flags.EnableWalkerPartition.set(1u);
@@ -1426,9 +1420,6 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenProgramWal
}
HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenProgramWalkerIsCalledWithPartitionLogicDisabledThenWalkerPartitionLogicIsNotExecuted) {
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
using WalkerType = typename FamilyType::DefaultWalkerType;
debugManager.flags.EnableWalkerPartition.set(0u);
@@ -1446,9 +1437,6 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenProgramWal
}
HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenQueueIsCreatedWithMultiEngineSupportAndEnqueueIsDoneThenWalkerIsPartitioned) {
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
using WalkerType = typename FamilyType::DefaultWalkerType;
debugManager.flags.EnableWalkerPartition.set(1u);
@@ -1468,9 +1456,6 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenQueueIsCre
}
HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenProgramWalkerIsCalledWithDebugRegistryOverridesThenWalkerContainsProperParameters) {
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
debugManager.flags.EnableWalkerPartition.set(1u);
debugManager.flags.ExperimentalSetWalkerPartitionCount.set(2u);
debugManager.flags.ExperimentalSetWalkerPartitionType.set(2u);
@@ -1514,31 +1499,7 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenProgramWal
EXPECT_FALSE(walker->getWorkloadPartitionEnable());
}
HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenThereIsNoLocalMemorySupportThenDoNotPartition) {
debugManager.flags.EnableWalkerPartition.set(1u);
debugManager.flags.ExperimentalSetWalkerPartitionCount.set(2u);
debugManager.flags.ExperimentalSetWalkerPartitionType.set(2u);
VariableBackup<bool> backup(&OSInterface::osEnableLocalMemory, false);
using WalkerType = typename FamilyType::DefaultWalkerType;
auto cmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
size_t gws[] = {1, 1, 1};
cmdQ->enqueueKernel(kernel->mockKernel, 1, nullptr, gws, nullptr, 0, nullptr, nullptr);
ClHardwareParse hwParser;
hwParser.parseCommands<FamilyType>(*cmdQ);
auto walker = genCmdCast<WalkerType *>(hwParser.cmdWalker);
ASSERT_NE(nullptr, walker);
EXPECT_EQ(WalkerType::PARTITION_TYPE::PARTITION_TYPE_DISABLED, walker->getPartitionType());
EXPECT_EQ(0u, walker->getPartitionSize());
EXPECT_FALSE(walker->getWorkloadPartitionEnable());
}
HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenEnqueueIsBlockedOnUserEventThenDoNotPartition) {
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
debugManager.flags.EnableWalkerPartition.set(1u);
debugManager.flags.ExperimentalSetWalkerPartitionCount.set(2u);
debugManager.flags.ExperimentalSetWalkerPartitionType.set(2u);
@@ -1583,9 +1544,6 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, whenDispatchPr
HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTest, givenOpenClWhenEnqueuePartitionWalkerThenExpectNoSelfCleanupSection) {
using MI_STORE_DATA_IMM = typename FamilyType::MI_STORE_DATA_IMM;
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
debugManager.flags.EnableWalkerPartition.set(1u);
using WalkerType = typename FamilyType::DefaultWalkerType;
@@ -1620,9 +1578,6 @@ struct XeHPAndLaterDispatchWalkerBasicTestDynamicPartition : public XeHPAndLater
};
HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTestDynamicPartition, givenDynamicPartitioningWhenEnqueueingKernelThenExpectNoMultipleActivePartitionsSetInCsr) {
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
auto cmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
size_t gws[] = {128, 1, 1};
size_t lws[] = {8, 1, 1};
@@ -1655,9 +1610,6 @@ struct XeHPAndLaterDispatchWalkerBasicTestStaticPartition : public XeHPAndLaterD
};
HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTestStaticPartition, givenStaticPartitioningWhenEnqueueingKernelThenMultipleActivePartitionsAreSetInCsr) {
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
auto cmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
size_t gws[] = {128, 1, 1};
size_t lws[] = {8, 1, 1};
@@ -1681,9 +1633,6 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerBasicTestStaticPartition,
using WalkerType = typename FamilyType::DefaultWalkerType;
using MI_LOAD_REGISTER_MEM = typename FamilyType::MI_LOAD_REGISTER_MEM;
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
auto cmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
size_t gws[] = {129, 1, 1};
size_t lws[] = {8, 1, 1};
@@ -2042,9 +1991,6 @@ struct KernelWithSingleSubdevicePreferences : public MockKernel {
};
HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerTestMultiTileDevice, givenKernelThatPrefersSingleSubdeviceWhenProgramWalkerThenKernelIsExecutedOnSingleTile) {
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
using WalkerType = typename FamilyType::DefaultWalkerType;
auto cmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
@@ -2064,9 +2010,6 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerTestMultiTileDevice, give
}
HWCMDTEST_F(IGFX_XE_HP_CORE, XeHPAndLaterDispatchWalkerTestMultiTileDevice, givenKernelThatDoesntPreferSingleSubdeviceWhenProgramWalkerThenKernelIsExecutedOnAllTiles) {
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
using WalkerType = typename FamilyType::DefaultWalkerType;
auto cmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);

View File

@@ -1,5 +1,5 @@
/*
* Copyright (C) 2021-2024 Intel Corporation
* Copyright (C) 2021-2025 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@@ -20,9 +20,6 @@
struct EnqueueWithWalkerPartitionTests : public ::testing::Test {
void SetUp() override {
if (!OSInterface::osEnableLocalMemory) {
GTEST_SKIP();
}
debugManager.flags.EnableWalkerPartition.set(1u);
debugManager.flags.CreateMultipleSubDevices.set(numberOfTiles);

View File

@@ -31,7 +31,6 @@ add_executable(igdrcl_${target_name}
${NEO_SHARED_DIRECTORY}/dll/linux/drm_neo_create.cpp
${NEO_SHARED_DIRECTORY}/dll/linux${BRANCH_DIR_SUFFIX}/options_linux.cpp
${NEO_SHARED_DIRECTORY}/dll/linux/options_linux.inl
${NEO_SHARED_DIRECTORY}/dll/linux/os_interface.cpp
${NEO_SOURCE_DIR}/opencl/source/dll/command_queue_dll.cpp
${NEO_SOURCE_DIR}/opencl/source/os_interface/linux/platform_teardown_linux.cpp
)

View File

@@ -679,10 +679,6 @@ TEST(DrmMemoryManagerCreate, givenEnableHostPtrValidationSetToZeroWhenCreateDrmM
mockExecutionEnvironment.memoryManager = std::move(drmMemoryManager);
}
TEST(OsInterfaceTests, givenOsInterfaceWhenEnableLocalMemoryIsSpecifiedThenItIsSetToTrueOn64Bit) {
EXPECT_TRUE(OSInterface::osEnableLocalMemory);
}
TEST_F(DrmTests, whenDrmIsCreatedWithMultipleSubDevicesThenCreateMultipleVirtualMemoryAddressSpaces) {
DebugManagerStateRestore restore;
debugManager.flags.CreateMultipleSubDevices.set(2);

View File

@@ -25,7 +25,6 @@ if(WIN32)
${NEO_SHARED_DIRECTORY}/dll/direct_submission_controller_enabled.cpp
${NEO_SHARED_DIRECTORY}/dll/get_devices.cpp
${NEO_SHARED_DIRECTORY}/dll/unified_memory_reuse_cleaner_enabled.cpp
${NEO_SHARED_DIRECTORY}/dll/windows/os_interface.cpp
${NEO_SHARED_DIRECTORY}/dll/create_command_stream.cpp
${NEO_SHARED_DIRECTORY}/dll/wddm/wddm_create.cpp
${NEO_SHARED_TEST_DIRECTORY}/common/mocks/mock_wddm.cpp