intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-04 15:53:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove unused variable

Browse Source 
Signed-off-by: Lukasz Jobczyk <lukasz.jobczyk@intel.com>
This commit is contained in:
Lukasz Jobczyk
2025-09-11 08:17:47 +00:00
committed by Compute-Runtime-Automation
parent d20c9264e5
commit aa74555682
24 changed files with 15 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shared/test/unit_test/encoders/test_encode_dispatch_kernel_xehp_and_later.cpp
View File

@@ -1111,7 +1111,6 @@ template <bool flushTaskUsedForImmediate, bool usePrimaryBuffer>
struct CommandEncodeStatesImplicitScalingFixtureT : public CommandEncodeStatesFixture {
void setUp() {
debugManager.flags.CreateMultipleSubDevices.set(2);
osLocalMemoryBackup = std::make_unique<VariableBackup<bool>>(&OSInterface::osEnableLocalMemory, true);
mockDeviceBackup = std::make_unique<VariableBackup<bool>>(&MockDevice::createSingleDevice, false);
apiSupportBackup = std::make_unique<VariableBackup<bool>>(&ImplicitScaling::apiSupport, true);
@@ -1126,7 +1125,6 @@ struct CommandEncodeStatesImplicitScalingFixtureT : public CommandEncodeStatesFi
}
DebugManagerStateRestore restorer;
std::unique_ptr<VariableBackup<bool>> osLocalMemoryBackup;
std::unique_ptr<VariableBackup<bool>> mockDeviceBackup;
std::unique_ptr<VariableBackup<bool>> apiSupportBackup;
};

13
shared/test/unit_test/encoders/test_implicit_scaling.cpp
View File

@@ -1,5 +1,5 @@
/*
* Copyright (C) 2021-2023 Intel Corporation
* Copyright (C) 2021-2025 Intel Corporation
*
* SPDX-License-Identifier: MIT
*
@@ -26,11 +26,6 @@ TEST_F(ImplicitScalingTests, givenMultiTileAndOsSupportWhenApiDisabledThenFeatur
EXPECT_FALSE(ImplicitScalingHelper::isImplicitScalingEnabled(twoTile, true));
}
TEST_F(ImplicitScalingTests, givenMultiTileAndApiSupportWhenOsDisabledThenFeatureDisabled) {
OSInterface::osEnableLocalMemory = false;
EXPECT_FALSE(ImplicitScalingHelper::isImplicitScalingEnabled(twoTile, true));
}
TEST_F(ImplicitScalingTests, givenSingleTileApiDisabledWhenOsSupportAndForcedOnThenFeatureEnabled) {
debugManager.flags.EnableWalkerPartition.set(1);
ImplicitScaling::apiSupport = false;
@@ -42,12 +37,6 @@ TEST_F(ImplicitScalingTests, givenMultiTileApiAndOsSupportEnabledWhenForcedOffTh
EXPECT_FALSE(ImplicitScalingHelper::isImplicitScalingEnabled(twoTile, true));
}
TEST_F(ImplicitScalingTests, givenMultiTileApiEnabledWhenOsSupportOffAndForcedOnThenFeatureDisabled) {
debugManager.flags.EnableWalkerPartition.set(1);
OSInterface::osEnableLocalMemory = false;
EXPECT_FALSE(ImplicitScalingHelper::isImplicitScalingEnabled(twoTile, true));
}
TEST_F(ImplicitScalingTests, givenDefaultSettingsWhenCheckingAtomicsForSelfCleanupThenExpectFalse) {
EXPECT_FALSE(ImplicitScalingHelper::isAtomicsUsedForSelfCleanup());
}

1
shared/test/unit_test/fixtures/implicit_scaling_fixture.cpp
View File

@@ -17,7 +17,6 @@
void ImplicitScalingFixture::setUp() {
CommandEncodeStatesFixture::setUp();
apiSupportBackup = std::make_unique<VariableBackup<bool>>(&ImplicitScaling::apiSupport, true);
osLocalMemoryBackup = std::make_unique<VariableBackup<bool>>(&OSInterface::osEnableLocalMemory, true);
singleTile = DeviceBitfield(static_cast<uint32_t>(maxNBitValue(1)));
twoTile = DeviceBitfield(static_cast<uint32_t>(maxNBitValue(2)));

20
shared/test/unit_test/helpers/gfx_core_helper_tests.cpp
View File

@@ -911,26 +911,6 @@ HWCMDTEST_F(IGFX_GEN12LP_CORE, GfxCoreHelperTest, givenGfxCoreHelperWhenGettingG
EXPECT_EQ(gfxCoreHelper.getGlobalTimeStampBits(), 36U);
}
TEST_F(GfxCoreHelperTest, givenEnableLocalMemoryDebugVarAndOsEnableLocalMemoryWhenSetThenGetEnableLocalMemoryReturnsCorrectValue) {
DebugManagerStateRestore dbgRestore;
VariableBackup<bool> orgOsEnableLocalMemory(&OSInterface::osEnableLocalMemory);
auto &gfxCoreHelper = getHelper<GfxCoreHelper>();
debugManager.flags.EnableLocalMemory.set(0);
EXPECT_FALSE(gfxCoreHelper.getEnableLocalMemory(hardwareInfo));
debugManager.flags.EnableLocalMemory.set(1);
EXPECT_TRUE(gfxCoreHelper.getEnableLocalMemory(hardwareInfo));
debugManager.flags.EnableLocalMemory.set(-1);
OSInterface::osEnableLocalMemory = false;
EXPECT_FALSE(gfxCoreHelper.getEnableLocalMemory(hardwareInfo));
OSInterface::osEnableLocalMemory = true;
EXPECT_EQ(gfxCoreHelper.isLocalMemoryEnabled(hardwareInfo), gfxCoreHelper.getEnableLocalMemory(hardwareInfo));
}
TEST_F(GfxCoreHelperTest, givenAUBDumpForceAllToLocalMemoryDebugVarWhenSetThenGetEnableLocalMemoryReturnsCorrectValue) {
DebugManagerStateRestore dbgRestore;
std::unique_ptr<MockDevice> device(MockDevice::createWithNewExecutionEnvironment<MockDevice>(&hardwareInfo));

1
shared/test/unit_test/os_interface/linux/drm_command_stream_xehp_and_later_tests.cpp
View File

@@ -37,7 +37,6 @@ struct DrmCommandStreamMultiTileMemExecFixture {
debugManager.flags.CreateMultipleSubDevices.set(2u);
debugManager.flags.EnableImplicitScaling.set(1);
debugManager.flags.EnableForcePin.set(false);
osLocalMemoryBackup = std::make_unique<VariableBackup<bool>>(&OSInterface::osEnableLocalMemory, true);
executionEnvironment = new MockExecutionEnvironment();
executionEnvironment->incRefInternal();

4
shared/test/unit_test/os_interface/windows/os_interface_win_tests.cpp
View File

@@ -58,10 +58,6 @@ TEST_F(OsInterfaceTest, GivenWindowsOsWhenCheckForGpuIdleImplicitFlushSupportThe
EXPECT_FALSE(OSInterface::gpuIdleImplicitFlush);
}
TEST_F(OsInterfaceTest, GivenDefaultOsInterfaceThenLocalMemoryEnabled) {
EXPECT_TRUE(OSInterface::osEnableLocalMemory);
}
TEST(OsInterfaceSimpleTest, GivenOsInterfaceWhenCallingGetAggregatedProcessCountThenCallReturnsZero) {
OSInterface osInterface;
EXPECT_EQ(0u, osInterface.getAggregatedProcessCount());