intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-12-20 08:53:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Correct typo

Browse Source 
Signed-off-by: Kamil Kopryk <kamil.kopryk@intel.com>
This commit is contained in:
Kamil Kopryk
2023-01-20 14:30:59 +00:00
committed by Compute-Runtime-Automation
parent fca74731fb
commit adb3e126b4
11 changed files with 25 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
opencl/test/unit_test/program/program_tests.cpp
View File

@@ -2763,8 +2763,8 @@ struct SpecializationConstantCompilerInterfaceMock : public CompilerInterface {
} }
}; };
struct SpecializationConstantRootDeviceEnvironemnt : public RootDeviceEnvironment { struct SpecializationConstantRootDeviceEnvironment : public RootDeviceEnvironment {
SpecializationConstantRootDeviceEnvironemnt(ExecutionEnvironment &executionEnvironment) : RootDeviceEnvironment(executionEnvironment) { SpecializationConstantRootDeviceEnvironment(ExecutionEnvironment &executionEnvironment) : RootDeviceEnvironment(executionEnvironment) {
compilerInterface.reset(new SpecializationConstantCompilerInterfaceMock()); compilerInterface.reset(new SpecializationConstantCompilerInterfaceMock());
} }
CompilerInterface *getCompilerInterface() override { CompilerInterface *getCompilerInterface() override {

1
opencl/test/unit_test/xe_hpc_core/hw_helper_tests_xe_hpc_core.cpp
View File

@@ -27,7 +27,6 @@
#include "hw_cmds_xe_hpc_core_base.h" #include "hw_cmds_xe_hpc_core_base.h"
using ClGfxCoreHelperTestsXeHpcCore = Test<ClDeviceFixture>; using ClGfxCoreHelperTestsXeHpcCore = Test<ClDeviceFixture>;
;
XE_HPC_CORETEST_F(ClGfxCoreHelperTestsXeHpcCore, givenXeHpcThenAuxTranslationIsNotRequired) { XE_HPC_CORETEST_F(ClGfxCoreHelperTestsXeHpcCore, givenXeHpcThenAuxTranslationIsNotRequired) {
auto &clGfxCoreHelper = getHelper<ClGfxCoreHelper>(); auto &clGfxCoreHelper = getHelper<ClGfxCoreHelper>();

4
shared/source/os_interface/hw_info_config.h
View File

@@ -54,8 +54,8 @@ class ProductHelper {
} }
static constexpr uint32_t uuidSize = 16u; static constexpr uint32_t uuidSize = 16u;
static constexpr uint32_t luidSize = 8u; static constexpr uint32_t luidSize = 8u;
int configureHwInfoWddm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironemnt); int configureHwInfoWddm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironment);
int configureHwInfoDrm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironemnt); int configureHwInfoDrm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironment);
virtual int configureHardwareCustom(HardwareInfo *hwInfo, OSInterface *osIface) const = 0; virtual int configureHardwareCustom(HardwareInfo *hwInfo, OSInterface *osIface) const = 0;
virtual void adjustPlatformForProductFamily(HardwareInfo *hwInfo) = 0; virtual void adjustPlatformForProductFamily(HardwareInfo *hwInfo) = 0;
virtual void adjustSamplerState(void *sampler, const HardwareInfo &hwInfo) const = 0; virtual void adjustSamplerState(void *sampler, const HardwareInfo &hwInfo) const = 0;

8
shared/source/os_interface/linux/hw_info_config_drm.cpp
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (C) 2018-2022 Intel Corporation * Copyright (C) 2018-2023 Intel Corporation
* *
* SPDX-License-Identifier: MIT * SPDX-License-Identifier: MIT
* *
@@ -64,9 +64,9 @@ int configureCacheInfo(HardwareInfo *hwInfo) {
return 0; return 0;
} }
int ProductHelper::configureHwInfoDrm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironemnt) { int ProductHelper::configureHwInfoDrm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironment) {
int ret = 0; int ret = 0;
auto osInterface = rootDeviceEnvironemnt.osInterface.get(); auto osInterface = rootDeviceEnvironment.osInterface.get();
Drm *drm = osInterface->getDriverModel()->as<Drm>(); Drm *drm = osInterface->getDriverModel()->as<Drm>();
*outHwInfo = *inHwInfo; *outHwInfo = *inHwInfo;
@@ -140,7 +140,7 @@ int ProductHelper::configureHwInfoDrm(const HardwareInfo *inHwInfo, HardwareInfo
outHwInfo->capabilityTable.maxRenderFrequency = maxGpuFreq; outHwInfo->capabilityTable.maxRenderFrequency = maxGpuFreq;
outHwInfo->capabilityTable.ftrSvm = featureTable->flags.ftrSVM; outHwInfo->capabilityTable.ftrSvm = featureTable->flags.ftrSVM;
GfxCoreHelper &gfxCoreHelper = rootDeviceEnvironemnt.getHelper<GfxCoreHelper>(); GfxCoreHelper &gfxCoreHelper = rootDeviceEnvironment.getHelper<GfxCoreHelper>();
outHwInfo->capabilityTable.ftrSupportsCoherency = false; outHwInfo->capabilityTable.ftrSupportsCoherency = false;
gfxCoreHelper.adjustDefaultEngineType(outHwInfo); gfxCoreHelper.adjustDefaultEngineType(outHwInfo);

4
shared/source/os_interface/linux/hw_info_config_wddm_stub.cpp
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (C) 2021-2022 Intel Corporation * Copyright (C) 2021-2023 Intel Corporation
* *
* SPDX-License-Identifier: MIT * SPDX-License-Identifier: MIT
* *
@@ -10,7 +10,7 @@
namespace NEO { namespace NEO {
int ProductHelper::configureHwInfoWddm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironemnt) { int ProductHelper::configureHwInfoWddm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironment) {
UNRECOVERABLE_IF(true); UNRECOVERABLE_IF(true);
return {}; return {};
} }

4
shared/source/os_interface/windows/hw_info_config_drm_stub.cpp
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (C) 2021-2022 Intel Corporation * Copyright (C) 2021-2023 Intel Corporation
* *
* SPDX-License-Identifier: MIT * SPDX-License-Identifier: MIT
* *
@@ -11,7 +11,7 @@
namespace NEO { namespace NEO {
int ProductHelper::configureHwInfoDrm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironemnt) { int ProductHelper::configureHwInfoDrm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironment) {
UNRECOVERABLE_IF(true); UNRECOVERABLE_IF(true);
return {}; return {};
} }

10
shared/source/os_interface/windows/hw_info_config_wddm.cpp
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (C) 2020-2022 Intel Corporation * Copyright (C) 2020-2023 Intel Corporation
* *
* SPDX-License-Identifier: MIT * SPDX-License-Identifier: MIT
* *
@@ -18,9 +18,9 @@
namespace NEO { namespace NEO {
int ProductHelper::configureHwInfoWddm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironemnt) { int ProductHelper::configureHwInfoWddm(const HardwareInfo *inHwInfo, HardwareInfo *outHwInfo, const RootDeviceEnvironment &rootDeviceEnvironment) {
auto &gfxCoreHelper = rootDeviceEnvironemnt.getHelper<GfxCoreHelper>(); auto &gfxCoreHelper = rootDeviceEnvironment.getHelper<GfxCoreHelper>();
auto &productHelper = rootDeviceEnvironemnt.getHelper<ProductHelper>(); auto &productHelper = rootDeviceEnvironment.getHelper<ProductHelper>();
auto compilerProductHelper = CompilerProductHelper::get(outHwInfo->platform.eProductFamily); auto compilerProductHelper = CompilerProductHelper::get(outHwInfo->platform.eProductFamily);
outHwInfo->capabilityTable.ftrSvm = outHwInfo->featureTable.flags.ftrSVM; outHwInfo->capabilityTable.ftrSvm = outHwInfo->featureTable.flags.ftrSVM;
@@ -51,7 +51,7 @@ int ProductHelper::configureHwInfoWddm(const HardwareInfo *inHwInfo, HardwareInf
KmdNotifyHelper::overrideFromDebugVariable(DebugManager.flags.OverrideEnableQuickKmdSleepForDirectSubmission.get(), kmdNotifyProperties.enableQuickKmdSleepForDirectSubmission); KmdNotifyHelper::overrideFromDebugVariable(DebugManager.flags.OverrideEnableQuickKmdSleepForDirectSubmission.get(), kmdNotifyProperties.enableQuickKmdSleepForDirectSubmission);
KmdNotifyHelper::overrideFromDebugVariable(DebugManager.flags.OverrideDelayQuickKmdSleepForDirectSubmissionMicroseconds.get(), kmdNotifyProperties.delayQuickKmdSleepForDirectSubmissionMicroseconds); KmdNotifyHelper::overrideFromDebugVariable(DebugManager.flags.OverrideDelayQuickKmdSleepForDirectSubmissionMicroseconds.get(), kmdNotifyProperties.delayQuickKmdSleepForDirectSubmissionMicroseconds);
auto osInterface = rootDeviceEnvironemnt.osInterface.get(); auto osInterface = rootDeviceEnvironment.osInterface.get();
// Product specific config // Product specific config
int ret = configureHardwareCustom(outHwInfo, osInterface); int ret = configureHardwareCustom(outHwInfo, osInterface);
if (ret != 0) { if (ret != 0) {

1
shared/source/program/kernel_info.h
View File

@@ -29,7 +29,6 @@ class DispatchInfo;
struct KernelArgumentType; struct KernelArgumentType;
class GraphicsAllocation; class GraphicsAllocation;
class MemoryManager; class MemoryManager;
struct RootDeviceEnvironemnt;
static const float YTilingRatioValue = 1.3862943611198906188344642429164f; static const float YTilingRatioValue = 1.3862943611198906188344642429164f;

12
shared/source/program/work_size_info.cpp
View File

@@ -17,18 +17,18 @@
namespace NEO { namespace NEO {
WorkSizeInfo::WorkSizeInfo(uint32_t maxWorkGroupSize, bool hasBarriers, uint32_t simdSize, uint32_t slmTotalSize, const RootDeviceEnvironment &rootDeviceEnvironemnt, uint32_t numThreadsPerSubSlice, uint32_t localMemSize, bool imgUsed, bool yTiledSurface, bool disableEUFusion) { WorkSizeInfo::WorkSizeInfo(uint32_t maxWorkGroupSize, bool hasBarriers, uint32_t simdSize, uint32_t slmTotalSize, const RootDeviceEnvironment &rootDeviceEnvironment, uint32_t numThreadsPerSubSlice, uint32_t localMemSize, bool imgUsed, bool yTiledSurface, bool disableEUFusion) {
this->maxWorkGroupSize = maxWorkGroupSize; this->maxWorkGroupSize = maxWorkGroupSize;
this->hasBarriers = hasBarriers; this->hasBarriers = hasBarriers;
this->simdSize = simdSize; this->simdSize = simdSize;
this->slmTotalSize = slmTotalSize; this->slmTotalSize = slmTotalSize;
this->coreFamily = rootDeviceEnvironemnt.getHardwareInfo()->platform.eRenderCoreFamily; this->coreFamily = rootDeviceEnvironment.getHardwareInfo()->platform.eRenderCoreFamily;
this->numThreadsPerSubSlice = numThreadsPerSubSlice; this->numThreadsPerSubSlice = numThreadsPerSubSlice;
this->localMemSize = localMemSize; this->localMemSize = localMemSize;
this->imgUsed = imgUsed; this->imgUsed = imgUsed;
this->yTiledSurfaces = yTiledSurface; this->yTiledSurfaces = yTiledSurface;
setMinWorkGroupSize(rootDeviceEnvironemnt, disableEUFusion); setMinWorkGroupSize(rootDeviceEnvironment, disableEUFusion);
} }
void WorkSizeInfo::setIfUseImg(const KernelInfo &kernelInfo) { void WorkSizeInfo::setIfUseImg(const KernelInfo &kernelInfo) {
@@ -41,7 +41,7 @@ void WorkSizeInfo::setIfUseImg(const KernelInfo &kernelInfo) {
} }
} }
void WorkSizeInfo::setMinWorkGroupSize(const RootDeviceEnvironment &rootDeviceEnvironemnt, bool disableEUFusion) { void WorkSizeInfo::setMinWorkGroupSize(const RootDeviceEnvironment &rootDeviceEnvironment, bool disableEUFusion) {
minWorkGroupSize = 0; minWorkGroupSize = 0;
if (hasBarriers) { if (hasBarriers) {
uint32_t maxBarriersPerHSlice = (coreFamily >= IGFX_GEN9_CORE) ? 32 : 16; uint32_t maxBarriersPerHSlice = (coreFamily >= IGFX_GEN9_CORE) ? 32 : 16;
@@ -55,8 +55,8 @@ void WorkSizeInfo::setMinWorkGroupSize(const RootDeviceEnvironment &rootDeviceEn
minWorkGroupSize = std::max(maxWorkGroupSize / ((localMemSize / slmTotalSize)), minWorkGroupSize); minWorkGroupSize = std::max(maxWorkGroupSize / ((localMemSize / slmTotalSize)), minWorkGroupSize);
} }
const auto &gfxCoreHelper = rootDeviceEnvironemnt.getHelper<GfxCoreHelper>(); const auto &gfxCoreHelper = rootDeviceEnvironment.getHelper<GfxCoreHelper>();
if (gfxCoreHelper.isFusedEuDispatchEnabled(*rootDeviceEnvironemnt.getHardwareInfo(), disableEUFusion)) { if (gfxCoreHelper.isFusedEuDispatchEnabled(*rootDeviceEnvironment.getHardwareInfo(), disableEUFusion)) {
minWorkGroupSize *= 2; minWorkGroupSize *= 2;
} }
} }

2
shared/source/program/work_size_info.h
View File

@@ -33,7 +33,7 @@ struct WorkSizeInfo {
WorkSizeInfo(uint32_t maxWorkGroupSize, bool hasBarriers, uint32_t simdSize, uint32_t slmTotalSize, const RootDeviceEnvironment &rootDeviceEnvironment, uint32_t numThreadsPerSubSlice, uint32_t localMemSize, bool imgUsed, bool yTiledSurface, bool disableEUFusion); WorkSizeInfo(uint32_t maxWorkGroupSize, bool hasBarriers, uint32_t simdSize, uint32_t slmTotalSize, const RootDeviceEnvironment &rootDeviceEnvironment, uint32_t numThreadsPerSubSlice, uint32_t localMemSize, bool imgUsed, bool yTiledSurface, bool disableEUFusion);
void setIfUseImg(const KernelInfo &kernelInfo); void setIfUseImg(const KernelInfo &kernelInfo);
void setMinWorkGroupSize(const RootDeviceEnvironment &rootDeviceEnvironemnt, bool disableEUFusion); void setMinWorkGroupSize(const RootDeviceEnvironment &rootDeviceEnvironment, bool disableEUFusion);
void checkRatio(const size_t workItems[3]); void checkRatio(const size_t workItems[3]);
}; };

2
shared/test/common/test_macros/test_checks_shared.h
View File

@@ -16,7 +16,7 @@ struct HardwareInfo;
struct RootDeviceEnvironment; struct RootDeviceEnvironment;
namespace TestChecks { namespace TestChecks {
bool supportsBlitter(const RootDeviceEnvironment &rootDeviceEnvironemnt); bool supportsBlitter(const RootDeviceEnvironment &rootDeviceEnvironment);
bool fullySupportsBlitter(const RootDeviceEnvironment &rootDeviceEnvironment); bool fullySupportsBlitter(const RootDeviceEnvironment &rootDeviceEnvironment);
bool supportsImages(const HardwareInfo &hardwareInfo); bool supportsImages(const HardwareInfo &hardwareInfo);
bool supportsImages(const std::unique_ptr<HardwareInfo> &pHardwareInfo); bool supportsImages(const std::unique_ptr<HardwareInfo> &pHardwareInfo);