intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-03 06:49:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix UB with std::optional deref in tests

Browse Source 
Accessing optional value with operator-> when it has no value is an UB.

Signed-off-by: Daniel Chabrowski daniel.chabrowski@intel.com
This commit is contained in:
Daniel Chabrowski
2022-03-15 11:17:10 +00:00
committed by Compute-Runtime-Automation
parent 4cde6ea1ce
commit adc5fb30d7
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
shared/test/unit_test/os_interface/linux/drm_debug_prelim_tests.cpp
View File

@@ -315,15 +315,13 @@ HWTEST_F(DrmDebugPrelimTest, givenAddedBindExtHandlesInBoWhenUnbindingThenExtens
OsContextLinux osContext(drm, 0u, EngineDescriptorHelper::getDefaultDescriptor());
osContext.ensureContextInitialized();
bo.bind(&osContext, 0);
EXPECT_NE(0u, drm.context.receivedVmBind->extensions);
drm.context.receivedVmUnbind->extensions = 0;
EXPECT_NE(0u, drm.context.receivedVmBind.value().extensions);
bo.unbind(&osContext, 0);
if (HwHelperHw<FamilyType>::get().getNumCacheRegions() > 0) {
EXPECT_NE(0u, drm.context.receivedVmUnbind->extensions);
EXPECT_NE(0u, drm.context.receivedVmUnbind.value().extensions);
} else {
EXPECT_EQ(0u, drm.context.receivedVmUnbind->extensions);
EXPECT_EQ(0u, drm.context.receivedVmUnbind.value().extensions);
}
EXPECT_EQ(1u, drm.context.vmUnbindCalled);
}