intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-04 07:14:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: add method to arb check encoder to program buffer pointer directly

Browse Source 
Related-To: NEO-15376

Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
This commit is contained in:
Zbigniew Zdanowicz
2025-07-31 12:54:10 +00:00
committed by Compute-Runtime-Automation
parent 1c36fdc9b0
commit b57d0b2544
3 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shared/source/command_container/command_encoder.h
View File

@@ -685,6 +685,10 @@ template <typename GfxFamily>
struct EncodeMiArbCheck {
using MI_ARB_CHECK = typename GfxFamily::MI_ARB_CHECK;
static void program(MI_ARB_CHECK *arbCheckCmd, std::optional<bool> preParserDisable);
static inline void program(void *cmdBuffer, std::optional<bool> preParserDisable) {
program(reinterpret_cast<MI_ARB_CHECK *>(cmdBuffer), preParserDisable);
}
static void program(LinearStream &commandStream, std::optional<bool> preParserDisable);
static size_t getCommandSize();

12
shared/source/command_container/command_encoder.inl
View File

@@ -1098,11 +1098,15 @@ size_t EncodeMiFlushDW<Family>::getCommandSizeWithWa(const EncodeDummyBlitWaArgs
template <typename Family>
void EncodeMiArbCheck<Family>::program(LinearStream &commandStream, std::optional<bool> preParserDisable) {
MI_ARB_CHECK cmd = Family::cmdInitArbCheck;
EncodeMiArbCheck<Family>::adjust(cmd, preParserDisable);
auto miArbCheckStream = commandStream.getSpaceForCmd<MI_ARB_CHECK>();
*miArbCheckStream = cmd;
program(miArbCheckStream, preParserDisable);
}
template <typename Family>
void EncodeMiArbCheck<Family>::program(MI_ARB_CHECK *arbCheckCmd, std::optional<bool> preParserDisable) {
MI_ARB_CHECK cmd = Family::cmdInitArbCheck;
EncodeMiArbCheck<Family>::adjust(cmd, preParserDisable);
*arbCheckCmd = cmd;
}
template <typename Family>

7
shared/test/unit_test/command_container/command_encoder_tests.cpp
View File

@@ -679,9 +679,14 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, CommandEncoderTests, givenDebugFlagSetWhenProgrammi
using MI_ARB_CHECK = typename FamilyType::MI_ARB_CHECK;
alignas(4) uint8_t arbCheckBuffer[sizeof(MI_ARB_CHECK)];
void *arbCheckBufferPtr = arbCheckBuffer;
for (int32_t value : {-1, 0, 1}) {
debugManager.flags.ForcePreParserEnabledForMiArbCheck.set(value);
memset(arbCheckBuffer, 0, sizeof(arbCheckBuffer));
MI_ARB_CHECK buffer[2] = {};
LinearStream linearStream(buffer, sizeof(buffer));
MockExecutionEnvironment executionEnvironment{};
@@ -689,12 +694,14 @@ HWCMDTEST_F(IGFX_XE_HP_CORE, CommandEncoderTests, givenDebugFlagSetWhenProgrammi
rootDeviceEnvironment.initGmm();
EncodeMiArbCheck<FamilyType>::program(linearStream, false);
EncodeMiArbCheck<FamilyType>::program(arbCheckBufferPtr, false);
if (value == 0) {
EXPECT_TRUE(buffer[0].getPreParserDisable());
} else {
EXPECT_FALSE(buffer[0].getPreParserDisable());
}
EXPECT_EQ(0, memcmp(arbCheckBufferPtr, &buffer[0], sizeof(MI_ARB_CHECK)));
}
}