intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-03 06:49:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: require cpu access for syncDispatchToken allocation type

Browse Source 
Related-To: NEO-8171

Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
This commit is contained in:
Bartosz Dunajski
2024-06-05 13:56:55 +00:00
committed by Compute-Runtime-Automation
parent a1ed0f346a
commit b9351f1a38
2 changed files with 29 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
shared/source/memory_manager/graphics_allocation.h
View File

@@ -227,7 +227,8 @@ class GraphicsAllocation : public IDNode<GraphicsAllocation> {
allocationType == AllocationType::debugSbaTrackingBuffer ||
allocationType == AllocationType::gpuTimestampDeviceBuffer ||
allocationType == AllocationType::debugModuleArea ||
allocationType == AllocationType::assertBuffer;
allocationType == AllocationType::assertBuffer ||
allocationType == AllocationType::syncDispatchToken;
}
static bool isLockable(AllocationType allocationType) {
return isCpuAccessRequired(allocationType) ||

64
shared/test/unit_test/memory_manager/graphics_allocation_tests.cpp
View File

@@ -138,44 +138,34 @@ TEST(GraphicsAllocationTest, givenResidentGraphicsAllocationWhenCheckIfResidency
EXPECT_TRUE(graphicsAllocation.isResidencyTaskCountBelow(currentResidencyTaskCount + 1u, 0u));
}
TEST(GraphicsAllocationTest, whenAllocationTypeIsCommandBufferThenCpuAccessIsRequired) {
EXPECT_TRUE(GraphicsAllocation::isCpuAccessRequired(AllocationType::commandBuffer));
}
TEST(GraphicsAllocationTest, givenAllocationTypeWhenCheckingCpuAccessRequiredThenReturnTrue) {
for (uint32_t i = 0; i < static_cast<uint32_t>(AllocationType::count); i++) {
auto allocType = static_cast<AllocationType>(i);
TEST(GraphicsAllocationTest, whenAllocationTypeIsConstantSurfaceThenCpuAccessIsRequired) {
EXPECT_TRUE(GraphicsAllocation::isCpuAccessRequired(AllocationType::constantSurface));
}
TEST(GraphicsAllocationTest, whenAllocationTypeIsGlobalSurfaceThenCpuAccessIsRequired) {
EXPECT_TRUE(GraphicsAllocation::isCpuAccessRequired(AllocationType::globalSurface));
}
TEST(GraphicsAllocationTest, whenAllocationTypeIsInternalHeapThenCpuAccessIsRequired) {
EXPECT_TRUE(GraphicsAllocation::isCpuAccessRequired(AllocationType::internalHeap));
}
TEST(GraphicsAllocationTest, whenAllocationTypeIsKernelIsaThenCpuAccessIsNotRequired) {
EXPECT_FALSE(GraphicsAllocation::isCpuAccessRequired(AllocationType::kernelIsa));
}
TEST(GraphicsAllocationTest, whenAllocationTypeIsKernelIsaInternalThenCpuAccessIsNotRequired) {
EXPECT_FALSE(GraphicsAllocation::isCpuAccessRequired(AllocationType::kernelIsaInternal));
}
TEST(GraphicsAllocationTest, whenAllocationTypeIsLinearStreamThenCpuAccessIsRequired) {
EXPECT_TRUE(GraphicsAllocation::isCpuAccessRequired(AllocationType::linearStream));
}
TEST(GraphicsAllocationTest, whenAllocationTypeIsPipeThenCpuAccessIsRequired) {
EXPECT_TRUE(GraphicsAllocation::isCpuAccessRequired(AllocationType::pipe));
}
TEST(GraphicsAllocationTest, whenAllocationTypeIsTimestampPacketThenCpuAccessIsRequired) {
EXPECT_TRUE(GraphicsAllocation::isCpuAccessRequired(AllocationType::timestampPacketTagBuffer));
}
TEST(GraphicsAllocationTest, whenAllocationTypeIsGpuTimestampDeviceBufferThenCpuAccessIsRequired) {
EXPECT_TRUE(GraphicsAllocation::isCpuAccessRequired(AllocationType::gpuTimestampDeviceBuffer));
switch (allocType) {
case AllocationType::commandBuffer:
case AllocationType::constantSurface:
case AllocationType::globalSurface:
case AllocationType::internalHeap:
case AllocationType::linearStream:
case AllocationType::pipe:
case AllocationType::printfSurface:
case AllocationType::timestampPacketTagBuffer:
case AllocationType::ringBuffer:
case AllocationType::semaphoreBuffer:
case AllocationType::debugContextSaveArea:
case AllocationType::debugSbaTrackingBuffer:
case AllocationType::gpuTimestampDeviceBuffer:
case AllocationType::debugModuleArea:
case AllocationType::assertBuffer:
case AllocationType::syncDispatchToken:
EXPECT_TRUE(GraphicsAllocation::isCpuAccessRequired(allocType));
break;
default:
EXPECT_FALSE(GraphicsAllocation::isCpuAccessRequired(allocType));
break;
}
}
}
TEST(GraphicsAllocationTest, whenAllocationRequiresCpuAccessThenAllocationIsLockable) {