diff --git a/shared/source/xe_hpg_core/dg2/os_agnostic_product_helper_dg2.inl b/shared/source/xe_hpg_core/dg2/os_agnostic_product_helper_dg2.inl index 4f25356e32..d654219845 100644 --- a/shared/source/xe_hpg_core/dg2/os_agnostic_product_helper_dg2.inl +++ b/shared/source/xe_hpg_core/dg2/os_agnostic_product_helper_dg2.inl @@ -67,11 +67,6 @@ bool ProductHelperHw::isGlobalFenceInDirectSubmissionRequired(const return true; } -template <> -bool ProductHelperHw::isDirectSubmissionSupported(const HardwareInfo &hwInfo) const { - return true; -} - template <> bool ProductHelperHw::isAdditionalStateBaseAddressWARequired(const HardwareInfo &hwInfo) const { if (DG2::isG10(hwInfo) && GfxCoreHelper::isWorkaroundRequired(REVISION_B, REVISION_C, hwInfo, *this)) { diff --git a/shared/source/xe_hpg_core/linux/product_helper_dg2.cpp b/shared/source/xe_hpg_core/linux/product_helper_dg2.cpp index 1cb96fa847..d6df57fb37 100644 --- a/shared/source/xe_hpg_core/linux/product_helper_dg2.cpp +++ b/shared/source/xe_hpg_core/linux/product_helper_dg2.cpp @@ -26,6 +26,11 @@ constexpr static auto gfxProduct = IGFX_DG2; namespace NEO { +template <> +bool ProductHelperHw::isDirectSubmissionSupported(const HardwareInfo &hwInfo) const { + return true; +} + template <> int ProductHelperHw::configureHardwareCustom(HardwareInfo *hwInfo, OSInterface *osIface) const { if (allowCompression(*hwInfo)) { diff --git a/shared/source/xe_hpg_core/linux/product_helper_mtl.cpp b/shared/source/xe_hpg_core/linux/product_helper_mtl.cpp index 0066110ef2..8e234218db 100644 --- a/shared/source/xe_hpg_core/linux/product_helper_mtl.cpp +++ b/shared/source/xe_hpg_core/linux/product_helper_mtl.cpp @@ -42,6 +42,11 @@ bool ProductHelperHw::isBlitterForImagesSupported() const { return true; } +template <> +bool ProductHelperHw::isDirectSubmissionSupported(const HardwareInfo &hwInfo) const { + return true; +} + template <> bool ProductHelperHw::isVmBindPatIndexProgrammingSupported() const { return true; diff --git a/shared/source/xe_hpg_core/mtl/os_agnostic_product_helper_mtl.inl b/shared/source/xe_hpg_core/mtl/os_agnostic_product_helper_mtl.inl index ae30601062..731f1cef9d 100644 --- a/shared/source/xe_hpg_core/mtl/os_agnostic_product_helper_mtl.inl +++ b/shared/source/xe_hpg_core/mtl/os_agnostic_product_helper_mtl.inl @@ -73,11 +73,6 @@ bool ProductHelperHw::isEvictionIfNecessaryFlagSupported() const { return true; } -template <> -bool ProductHelperHw::isDirectSubmissionSupported(const HardwareInfo &hwInfo) const { - return true; -} - template <> std::optional ProductHelperHw::getAubStreamProductFamily() const { return aub_stream::ProductFamily::Mtl; diff --git a/shared/test/unit_test/xe_hpg_core/dg2/linux/product_helper_tests_dg2.cpp b/shared/test/unit_test/xe_hpg_core/dg2/linux/product_helper_tests_dg2.cpp index af8a6f83c5..fbfe769d31 100644 --- a/shared/test/unit_test/xe_hpg_core/dg2/linux/product_helper_tests_dg2.cpp +++ b/shared/test/unit_test/xe_hpg_core/dg2/linux/product_helper_tests_dg2.cpp @@ -30,6 +30,10 @@ DG2TEST_F(Dg2ProductHelperLinux, WhenConfiguringHwInfoThenZeroIsReturned) { EXPECT_EQ(0, ret); } +DG2TEST_F(Dg2ProductHelperLinux, givenProductHelperWhenCheckDirectSubmissionSupportedThenTrueIsReturned) { + EXPECT_TRUE(productHelper->isDirectSubmissionSupported(pInHwInfo)); +} + DG2TEST_F(Dg2ProductHelperLinux, GivenDg2WhenConfigureHardwareCustomThenKmdNotifyIsEnabled) { OSInterface osIface; diff --git a/shared/test/unit_test/xe_hpg_core/dg2/test_product_helper_dg2.cpp b/shared/test/unit_test/xe_hpg_core/dg2/test_product_helper_dg2.cpp index ed1208c862..b039777bac 100644 --- a/shared/test/unit_test/xe_hpg_core/dg2/test_product_helper_dg2.cpp +++ b/shared/test/unit_test/xe_hpg_core/dg2/test_product_helper_dg2.cpp @@ -53,10 +53,6 @@ DG2TEST_F(Dg2ProductHelper, givenSteppingWhenAskingForLocalMemoryAccessModeThenD EXPECT_EQ(LocalMemoryAccessMode::Default, productHelper->getLocalMemoryAccessMode(pInHwInfo)); } -DG2TEST_F(Dg2ProductHelper, givenDG2ProductHelperWhenCheckDirectSubmissionSupportedThenTrueIsReturned) { - EXPECT_TRUE(productHelper->isDirectSubmissionSupported(pInHwInfo)); -} - DG2TEST_F(Dg2ProductHelper, givenProductHelperWhenGetCommandsStreamPropertiesSupportThenExpectCorrectValues) { EXPECT_FALSE(productHelper->getScmPropertyThreadArbitrationPolicySupport()); diff --git a/shared/test/unit_test/xe_hpg_core/mtl/linux/product_helper_tests_mtl.cpp b/shared/test/unit_test/xe_hpg_core/mtl/linux/product_helper_tests_mtl.cpp index ffc9734c24..4a589de190 100644 --- a/shared/test/unit_test/xe_hpg_core/mtl/linux/product_helper_tests_mtl.cpp +++ b/shared/test/unit_test/xe_hpg_core/mtl/linux/product_helper_tests_mtl.cpp @@ -53,3 +53,7 @@ MTLTEST_F(MtlProductHelperLinux, givenProductHelperWhenAskedIsPageFaultSupported MTLTEST_F(MtlProductHelperLinux, givenProductHelperWhenAskedIsKmdMigrationsSupportedThenReturnFalse) { EXPECT_FALSE(productHelper->isKmdMigrationSupported()); } + +MTLTEST_F(MtlProductHelperLinux, givenProductHelperWhenCheckDirectSubmissionSupportedThenTrueIsReturned) { + EXPECT_TRUE(productHelper->isDirectSubmissionSupported(pInHwInfo)); +} \ No newline at end of file