From cf8283cc9a7a4b7ada40fb1e4cf5d9cf15dcf3af Mon Sep 17 00:00:00 2001 From: Artur Harasimiuk Date: Wed, 20 Nov 2019 12:23:06 +0100 Subject: [PATCH] clang-tidy improvements and code fixes Related-To: NEO-562 Change-Id: Iab9d1ed35e64c9fce849e1b0654ec65f731302e8 Signed-off-by: Artur Harasimiuk --- .clang-tidy | 3 +-- core/memory_manager/graphics_allocation.h | 2 +- core/unit_tests/.clang-tidy | 4 ++-- core/unit_tests/helpers/debug_manager_state_restore.h | 2 +- core/unit_tests/utilities/.clang-tidy | 6 ++---- core/unit_tests/utilities/base_object_utils.h | 4 ++-- manifests/manifest.yml | 2 +- runtime/instrumentation/.clang-tidy | 2 +- unit_tests/.clang-tidy | 4 ++-- unit_tests/os_interface/linux/.clang-tidy | 5 ++--- unit_tests/utilities/.clang-tidy | 5 ++--- 11 files changed, 17 insertions(+), 22 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 810f5b5e78..fc26a15239 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,7 +1,7 @@ --- Checks: 'clang-diagnostic-*,clang-analyzer-*,google-default-arguments,readability-identifier-naming,modernize-use-override,modernize-use-default-member-init,-clang-analyzer-alpha*' # WarningsAsErrors: '.*' -HeaderFilterRegex: 'runtime/' +HeaderFilterRegex: '/runtime/|/core/|/offline_compiler/|/common/' AnalyzeTemporaryDtors: false CheckOptions: - key: google-readability-braces-around-statements.ShortStatementLines @@ -37,4 +37,3 @@ CheckOptions: - key: modernize-use-default-member-init.UseAssignment value: '1' ... - diff --git a/core/memory_manager/graphics_allocation.h b/core/memory_manager/graphics_allocation.h index e5f7b17c53..eae5e24a45 100644 --- a/core/memory_manager/graphics_allocation.h +++ b/core/memory_manager/graphics_allocation.h @@ -76,7 +76,7 @@ class GraphicsAllocation : public IDNode { WRITE_COMBINED }; - virtual ~GraphicsAllocation(); + ~GraphicsAllocation() override; GraphicsAllocation &operator=(const GraphicsAllocation &) = delete; GraphicsAllocation(const GraphicsAllocation &) = delete; diff --git a/core/unit_tests/.clang-tidy b/core/unit_tests/.clang-tidy index ed97f94d88..43f59e172b 100644 --- a/core/unit_tests/.clang-tidy +++ b/core/unit_tests/.clang-tidy @@ -1,9 +1,9 @@ --- Checks: 'clang-diagnostic-*,clang-analyzer-*,google-default-arguments,modernize-use-override,modernize-use-default-member-init,-clang-analyzer-alpha*,readability-identifier-naming,-clang-analyzer-core.StackAddressEscape,-clang-analyzer-optin.performance.Padding,-clang-analyzer-security.insecureAPI.strcpy,-clang-analyzer-cplusplus.NewDeleteLeaks,-clang-analyzer-core.CallAndMessage,-clang-analyzer-core.uninitialized.Assign,-clang-analyzer-unix.MismatchedDeallocator,-clang-analyzer-core.NonNullParamChecker,-clang-analyzer-core.NullDereference,-clang-analyzer-cplusplus.NewDelete,-clang-analyzer-optin.cplusplus.VirtualCall' # WarningsAsErrors: '.*' -HeaderFilterRegex: 'runtime/' +HeaderFilterRegex: '/runtime/|/core/|/offline_compiler/|/common/' AnalyzeTemporaryDtors: false -CheckOptions: +CheckOptions: - key: google-readability-braces-around-statements.ShortStatementLines value: '1' - key: google-readability-function-size.StatementThreshold diff --git a/core/unit_tests/helpers/debug_manager_state_restore.h b/core/unit_tests/helpers/debug_manager_state_restore.h index d82d7ce0c4..f8d32fc4f0 100644 --- a/core/unit_tests/helpers/debug_manager_state_restore.h +++ b/core/unit_tests/helpers/debug_manager_state_restore.h @@ -39,7 +39,7 @@ class DebugManagerStateRestore { class RegistryReaderMock : public SettingsReader { public: RegistryReaderMock() {} - ~RegistryReaderMock() {} + ~RegistryReaderMock() override {} unsigned int forceRetValue = 1; diff --git a/core/unit_tests/utilities/.clang-tidy b/core/unit_tests/utilities/.clang-tidy index 1a9aa8663b..628f8c0d3a 100644 --- a/core/unit_tests/utilities/.clang-tidy +++ b/core/unit_tests/utilities/.clang-tidy @@ -1,10 +1,9 @@ --- Checks: 'clang-diagnostic-*,clang-analyzer-*,google-default-arguments,modernize-use-override,modernize-use-default-member-init,-clang-analyzer-alpha*,readability-identifier-naming,-clang-analyzer-core.UndefinedBinaryOperatorResult' - # WarningsAsErrors: '.*' -HeaderFilterRegex: 'runtime/' +HeaderFilterRegex: '/runtime/|/core/|/offline_compiler/|/common/' AnalyzeTemporaryDtors: false -CheckOptions: +CheckOptions: - key: google-readability-braces-around-statements.ShortStatementLines value: '1' - key: google-readability-function-size.StatementThreshold @@ -30,4 +29,3 @@ CheckOptions: - key: modernize-use-default-member-init.UseAssignment value: '1' ... - diff --git a/core/unit_tests/utilities/base_object_utils.h b/core/unit_tests/utilities/base_object_utils.h index 3a1e2b4088..87015a8aef 100644 --- a/core/unit_tests/utilities/base_object_utils.h +++ b/core/unit_tests/utilities/base_object_utils.h @@ -28,7 +28,7 @@ static ReleaseableObjectPtr clUniquePtr(T *object) { } template -inline ReleaseableObjectPtr<_Ty> make_releaseable(_Types &&... _Args) { - return (ReleaseableObjectPtr<_Ty>(new _Ty(std::forward<_Types>(_Args)...))); +inline ReleaseableObjectPtr<_Ty> make_releaseable(_Types &&... args) { + return (ReleaseableObjectPtr<_Ty>(new _Ty(std::forward<_Types>(args)...))); } } // namespace NEO diff --git a/manifests/manifest.yml b/manifests/manifest.yml index 962f599352..846287118d 100644 --- a/manifests/manifest.yml +++ b/manifests/manifest.yml @@ -17,7 +17,7 @@ components: branch: infra clean_on_sync: true dest_dir: infra - revision: 1374a9c34e12622c509c5c84e430d68ef6b633d0 + revision: 19ddd18e9bb79d4d0388a317da91c9f4ee4a6826 type: git internal: branch: master diff --git a/runtime/instrumentation/.clang-tidy b/runtime/instrumentation/.clang-tidy index cbbdf133d7..ef415f9e74 100644 --- a/runtime/instrumentation/.clang-tidy +++ b/runtime/instrumentation/.clang-tidy @@ -1,7 +1,7 @@ --- Checks: 'clang-diagnostic-*,clang-analyzer-*,google-default-arguments,readability-identifier-naming,modernize-use-override,modernize-use-default-member-init,-clang-analyzer-alpha*' # WarningsAsErrors: '.*' -HeaderFilterRegex: 'runtime/' +HeaderFilterRegex: '/runtime/|/core/|/offline_compiler/|/common/' AnalyzeTemporaryDtors: false CheckOptions: - key: google-readability-braces-around-statements.ShortStatementLines diff --git a/unit_tests/.clang-tidy b/unit_tests/.clang-tidy index ed97f94d88..43f59e172b 100644 --- a/unit_tests/.clang-tidy +++ b/unit_tests/.clang-tidy @@ -1,9 +1,9 @@ --- Checks: 'clang-diagnostic-*,clang-analyzer-*,google-default-arguments,modernize-use-override,modernize-use-default-member-init,-clang-analyzer-alpha*,readability-identifier-naming,-clang-analyzer-core.StackAddressEscape,-clang-analyzer-optin.performance.Padding,-clang-analyzer-security.insecureAPI.strcpy,-clang-analyzer-cplusplus.NewDeleteLeaks,-clang-analyzer-core.CallAndMessage,-clang-analyzer-core.uninitialized.Assign,-clang-analyzer-unix.MismatchedDeallocator,-clang-analyzer-core.NonNullParamChecker,-clang-analyzer-core.NullDereference,-clang-analyzer-cplusplus.NewDelete,-clang-analyzer-optin.cplusplus.VirtualCall' # WarningsAsErrors: '.*' -HeaderFilterRegex: 'runtime/' +HeaderFilterRegex: '/runtime/|/core/|/offline_compiler/|/common/' AnalyzeTemporaryDtors: false -CheckOptions: +CheckOptions: - key: google-readability-braces-around-statements.ShortStatementLines value: '1' - key: google-readability-function-size.StatementThreshold diff --git a/unit_tests/os_interface/linux/.clang-tidy b/unit_tests/os_interface/linux/.clang-tidy index a83341e8af..d825181b92 100644 --- a/unit_tests/os_interface/linux/.clang-tidy +++ b/unit_tests/os_interface/linux/.clang-tidy @@ -1,10 +1,9 @@ --- Checks: 'clang-diagnostic-*,clang-analyzer-*,google-default-arguments,modernize-use-override,modernize-use-default-member-init,-clang-analyzer-alpha*,readability-identifier-naming,-clang-analyzer-optin.performance.Padding,-clang-analyzer-cplusplus.NewDelete,-clang-analyzer-cplusplus.NewDeleteLeaks,-clang-analyzer-optin.cplusplus.VirtualCall' - # WarningsAsErrors: '.*' -HeaderFilterRegex: 'runtime/' +HeaderFilterRegex: '/runtime/|/core/|/offline_compiler/|/common/' AnalyzeTemporaryDtors: false -CheckOptions: +CheckOptions: - key: google-readability-braces-around-statements.ShortStatementLines value: '1' - key: google-readability-function-size.StatementThreshold diff --git a/unit_tests/utilities/.clang-tidy b/unit_tests/utilities/.clang-tidy index 1a9aa8663b..8435d77e9c 100644 --- a/unit_tests/utilities/.clang-tidy +++ b/unit_tests/utilities/.clang-tidy @@ -1,10 +1,9 @@ --- Checks: 'clang-diagnostic-*,clang-analyzer-*,google-default-arguments,modernize-use-override,modernize-use-default-member-init,-clang-analyzer-alpha*,readability-identifier-naming,-clang-analyzer-core.UndefinedBinaryOperatorResult' - # WarningsAsErrors: '.*' -HeaderFilterRegex: 'runtime/' +HeaderFilterRegex: '/runtime/|/core/|/offline_compiler/|/common/' AnalyzeTemporaryDtors: false -CheckOptions: +CheckOptions: - key: google-readability-braces-around-statements.ShortStatementLines value: '1' - key: google-readability-function-size.StatementThreshold