intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-12-28 08:37:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix for svm pointer arg caching

Browse Source 
Previous version could cause segfaults.

Related-To: NEO-6737

Signed-off-by: Dominik Dabek <dominik.dabek@intel.com>
This commit is contained in:
Dominik Dabek
2022-03-07 17:11:54 +00:00
committed by Compute-Runtime-Automation
parent 865ef4d039
commit d5fedf90c5
3 changed files with 58 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
opencl/source/api/api.cpp
View File

@@ -4877,25 +4877,27 @@ cl_int CL_API_CALL clSetKernelArgSVMPointer(cl_kernel kernel,
return retVal;
}
auto svmManager = pMultiDeviceKernel->getContext().getSVMAllocsManager();
const auto svmManager = pMultiDeviceKernel->getContext().getSVMAllocsManager();
if (argValue != nullptr) {
if (pMultiDeviceKernel->getKernelArguments()[argIndex].allocId > 0 &&
pMultiDeviceKernel->getKernelArguments()[argIndex].value == argValue) {
bool reuseFromCache = false;
if (svmManager->allocationsCounter == pMultiDeviceKernel->getKernelArguments()[argIndex].allocIdMemoryManagerCounter) {
reuseFromCache = true;
} else {
auto svmData = svmManager->getSVMAlloc(argValue);
if (pMultiDeviceKernel->getKernelArguments()[argIndex].allocId == svmData->getAllocId()) {
const auto allocationsCounter = svmManager->allocationsCounter.load();
if (allocationsCounter > 0) {
if (allocationsCounter == pMultiDeviceKernel->getKernelArguments()[argIndex].allocIdMemoryManagerCounter) {
reuseFromCache = true;
pMultiDeviceKernel->storeKernelArgAllocIdMemoryManagerCounter(argIndex, svmManager->allocationsCounter);
} else {
const auto svmData = svmManager->getSVMAlloc(argValue);
if (svmData && pMultiDeviceKernel->getKernelArguments()[argIndex].allocId == svmData->getAllocId()) {
reuseFromCache = true;
pMultiDeviceKernel->storeKernelArgAllocIdMemoryManagerCounter(argIndex, allocationsCounter);
}
}
if (reuseFromCache) {
TRACING_EXIT(clSetKernelArgSVMPointer, &retVal);
return CL_SUCCESS;
}
}
if (reuseFromCache) {
TRACING_EXIT(clSetKernelArgSVMPointer, &retVal);
return CL_SUCCESS;
}
}
}