From dda4beb71913db7e49416a41e721114f99e952b8 Mon Sep 17 00:00:00 2001 From: Compute-Runtime-Validation Date: Fri, 21 Feb 2025 03:25:44 +0100 Subject: [PATCH] Revert "performance: enable Direct Submission on LNL Linux" This reverts commit b7d21b135cf5d8f43de11168ef8301e7fe250c09. Signed-off-by: Compute-Runtime-Validation --- .../xe2_hpg_core/lnl/os_agnostic_product_helper_lnl.inl | 5 ----- shared/source/xe2_hpg_core/windows/product_helper_lnl.cpp | 5 +++++ .../lnl/linux/product_helper_tests_lnl_linux.cpp | 4 ++++ .../unit_test/xe2_hpg_core/lnl/product_helper_tests_lnl.cpp | 4 ---- .../lnl/windows/product_helper_tests_lnl_windows.cpp | 6 +++++- 5 files changed, 14 insertions(+), 10 deletions(-) diff --git a/shared/source/xe2_hpg_core/lnl/os_agnostic_product_helper_lnl.inl b/shared/source/xe2_hpg_core/lnl/os_agnostic_product_helper_lnl.inl index 2234260e42..90f1f6d94f 100644 --- a/shared/source/xe2_hpg_core/lnl/os_agnostic_product_helper_lnl.inl +++ b/shared/source/xe2_hpg_core/lnl/os_agnostic_product_helper_lnl.inl @@ -35,11 +35,6 @@ std::optional ProductHelperHw::getPreferr return GfxMemoryAllocationMethod::allocateByKmd; } -template <> -bool ProductHelperHw::isDirectSubmissionSupported(ReleaseHelper *releaseHelper) const { - return true; -} - template <> bool ProductHelperHw::blitEnqueuePreferred(bool isWriteToImageFromBuffer) const { return isWriteToImageFromBuffer; diff --git a/shared/source/xe2_hpg_core/windows/product_helper_lnl.cpp b/shared/source/xe2_hpg_core/windows/product_helper_lnl.cpp index 20e26e590d..8255664c62 100644 --- a/shared/source/xe2_hpg_core/windows/product_helper_lnl.cpp +++ b/shared/source/xe2_hpg_core/windows/product_helper_lnl.cpp @@ -47,6 +47,11 @@ uint64_t ProductHelperHw::overridePatIndex(bool isUncachedType, uint return patIndex; } +template <> +bool ProductHelperHw::isDirectSubmissionSupported(ReleaseHelper *releaseHelper) const { + return true; +} + template <> bool ProductHelperHw::restartDirectSubmissionForHostptrFree() const { return true; diff --git a/shared/test/unit_test/xe2_hpg_core/lnl/linux/product_helper_tests_lnl_linux.cpp b/shared/test/unit_test/xe2_hpg_core/lnl/linux/product_helper_tests_lnl_linux.cpp index ef984e32b4..4bc92815eb 100644 --- a/shared/test/unit_test/xe2_hpg_core/lnl/linux/product_helper_tests_lnl_linux.cpp +++ b/shared/test/unit_test/xe2_hpg_core/lnl/linux/product_helper_tests_lnl_linux.cpp @@ -60,6 +60,10 @@ LNLTEST_F(LnlProductHelperLinux, givenProductHelperWhenAskedIsKmdMigrationSuppor EXPECT_FALSE(productHelper->isKmdMigrationSupported()); } +LNLTEST_F(LnlProductHelperLinux, givenProductHelperWhenCheckDirectSubmissionSupportedThenFalseIsReturned) { + EXPECT_FALSE(productHelper->isDirectSubmissionSupported(releaseHelper)); +} + LNLTEST_F(LnlProductHelperLinux, givenProductHelperWhenCheckIsCopyBufferRectSplitSupportedThenReturnsTrue) { EXPECT_TRUE(productHelper->isCopyBufferRectSplitSupported()); } diff --git a/shared/test/unit_test/xe2_hpg_core/lnl/product_helper_tests_lnl.cpp b/shared/test/unit_test/xe2_hpg_core/lnl/product_helper_tests_lnl.cpp index b59be69385..9ff4a5d56c 100644 --- a/shared/test/unit_test/xe2_hpg_core/lnl/product_helper_tests_lnl.cpp +++ b/shared/test/unit_test/xe2_hpg_core/lnl/product_helper_tests_lnl.cpp @@ -157,7 +157,3 @@ LNLTEST_F(LnlProductHelper, givenProductHelperWhenCheckingIsDeviceUsmAllocationR LNLTEST_F(LnlProductHelper, givenProductHelperWhenCheckingIsBufferPoolAllocatorSupportedThenCorrectValueIsReturned) { EXPECT_TRUE(productHelper->isBufferPoolAllocatorSupported()); } - -LNLTEST_F(LnlProductHelper, givenProductHelperWhenCheckDirectSubmissionSupportedThenTrueIsReturned) { - EXPECT_TRUE(productHelper->isDirectSubmissionSupported(releaseHelper)); -} diff --git a/shared/test/unit_test/xe2_hpg_core/lnl/windows/product_helper_tests_lnl_windows.cpp b/shared/test/unit_test/xe2_hpg_core/lnl/windows/product_helper_tests_lnl_windows.cpp index df15c8d372..4e49bc7d72 100644 --- a/shared/test/unit_test/xe2_hpg_core/lnl/windows/product_helper_tests_lnl_windows.cpp +++ b/shared/test/unit_test/xe2_hpg_core/lnl/windows/product_helper_tests_lnl_windows.cpp @@ -19,6 +19,10 @@ using namespace NEO; using LnlProductHelperWindows = ProductHelperTest; +LNLTEST_F(LnlProductHelperWindows, givenProductHelperWhenCheckDirectSubmissionSupportedThenTrueIsReturned) { + EXPECT_TRUE(productHelper->isDirectSubmissionSupported(releaseHelper)); +} + LNLTEST_F(LnlProductHelperWindows, givenProductHelperWhenDcFlushMitigationThenReturnFalse) { EXPECT_FALSE(productHelper->mitigateDcFlush()); EXPECT_FALSE(productHelper->isDcFlushMitigated()); @@ -72,4 +76,4 @@ LNLTEST_F(LnlProductHelperWindows, givenProductHelperWhenOverridePatIndexCalledT LNLTEST_F(LnlProductHelperWindows, givenProductHelperWhenCheckIsCopyBufferRectSplitSupportedThenReturnsTrue) { EXPECT_TRUE(productHelper->isCopyBufferRectSplitSupported()); -} +} \ No newline at end of file