intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-07 21:27:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Sysman: Fix few memory leaks

Browse Source 
Invoking FwDeviceInit from several modules without closing
igsc device result in memory leak.

Add support to invoke FwDeviceInit only during creation of fw util
interface.

Related-To: LOCI-3204

Signed-off-by: Bellekallu Rajkiran <bellekallu.rajkiran@intel.com>
This commit is contained in:
Bellekallu Rajkiran
2022-09-06 09:15:54 +00:00
committed by Compute-Runtime-Automation
parent ec619f4259
commit de06d91db8
21 changed files with 50 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
level_zero/tools/source/sysman/firmware/windows/os_firmware_imp.cpp
View File

@@ -32,14 +32,6 @@ ze_result_t WddmFirmwareImp::osFirmwareFlash(void *pImage, uint32_t size) {
return pFwInterface->flashFirmware(osFwType, pImage, size);
}
bool WddmFirmwareImp::isFirmwareSupported(void) {
if (pFwInterface != nullptr) {
isFWInitialized = ((ZE_RESULT_SUCCESS == pFwInterface->fwDeviceInit()) ? true : false);
return this->isFWInitialized;
}
return false;
}
WddmFirmwareImp::WddmFirmwareImp(OsSysman *pOsSysman, const std::string &fwType) : osFwType(fwType) {
WddmSysmanImp *pWddmSysmanImp = static_cast<WddmSysmanImp *>(pOsSysman);
pFwInterface = pWddmSysmanImp->getFwUtilInterface();

2
level_zero/tools/source/sysman/firmware/windows/os_firmware_imp.h
View File

@@ -14,7 +14,6 @@ namespace L0 {
class FirmwareUtil;
class WddmFirmwareImp : public OsFirmware {
public:
bool isFirmwareSupported(void) override;
void osGetFwProperties(zes_firmware_properties_t *pProperties) override;
ze_result_t osFirmwareFlash(void *pImage, uint32_t size) override;
ze_result_t getFirmwareVersion(std::string fwType, zes_firmware_properties_t *pProperties);
@@ -24,7 +23,6 @@ class WddmFirmwareImp : public OsFirmware {
protected:
FirmwareUtil *pFwInterface = nullptr;
bool isFWInitialized = false;
std::string osFwType;
};