From ee08caa4656a32ec8bfd41ae91eb1f63908ea338 Mon Sep 17 00:00:00 2001 From: Compute-Runtime-Validation Date: Wed, 23 Nov 2022 15:18:37 +0100 Subject: [PATCH] Revert "Enable signaling all event packets" This reverts commit 7caf7105084dc253319f0f06079e4e06eb78c8a5. Signed-off-by: Compute-Runtime-Validation --- level_zero/core/source/hw_helpers/l0_hw_helper.cpp | 2 +- .../sources/cmdlist/test_cmdlist_xehp_and_later.cpp | 9 --------- .../unit_tests/sources/helper/l0_hw_helper_tests.cpp | 4 ++-- 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/level_zero/core/source/hw_helpers/l0_hw_helper.cpp b/level_zero/core/source/hw_helpers/l0_hw_helper.cpp index a6b22e0249..2199ddf081 100644 --- a/level_zero/core/source/hw_helpers/l0_hw_helper.cpp +++ b/level_zero/core/source/hw_helpers/l0_hw_helper.cpp @@ -79,7 +79,7 @@ bool L0HwHelper::useSignalAllEventPackets(const NEO::HardwareInfo &hwInfo) { if (NEO::DebugManager.flags.SignalAllEventPackets.get() != -1) { return !!NEO::DebugManager.flags.SignalAllEventPackets.get(); } - return true; + return false; } } // namespace L0 diff --git a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_xehp_and_later.cpp b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_xehp_and_later.cpp index 750d699b61..8b5a35f03f 100644 --- a/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_xehp_and_later.cpp +++ b/level_zero/core/test/unit_tests/sources/cmdlist/test_cmdlist_xehp_and_later.cpp @@ -313,7 +313,6 @@ template struct CommandListAppendLaunchKernelCompactL3FlushEventFixture : public ModuleFixture { void setUp() { DebugManager.flags.CompactL3FlushEventPacket.set(compactL3FlushEventPacket); - DebugManager.flags.SignalAllEventPackets.set(0); if constexpr (multiTile == 1) { DebugManager.flags.CreateMultipleSubDevices.set(2); DebugManager.flags.EnableImplicitScaling.set(1); @@ -338,7 +337,6 @@ struct CommandListAppendLaunchKernelCompactL3FlushEventFixture : public ModuleFi using PIPE_CONTROL = typename FamilyType::PIPE_CONTROL; using POST_SYNC_OPERATION = typename FamilyType::PIPE_CONTROL::POST_SYNC_OPERATION; using OPERATION = typename POSTSYNC_DATA::OPERATION; - using MI_STORE_DATA_IMM = typename FamilyType::MI_STORE_DATA_IMM; Mock<::L0::Kernel> kernel; auto module = std::unique_ptr(new Mock(input.device, nullptr)); @@ -412,13 +410,6 @@ struct CommandListAppendLaunchKernelCompactL3FlushEventFixture : public ModuleFi } EXPECT_EQ(arg.expectedPostSyncPipeControls, postSyncPipeControls); EXPECT_EQ(arg.expectDcFlush, dcFlushFound); - - auto itorStoreDataImm = findAll(cmdList.begin(), cmdList.end()); - if constexpr (multiTile == 1) { - EXPECT_EQ(3u, itorStoreDataImm.size()); - } else { - EXPECT_EQ(0u, itorStoreDataImm.size()); - } } DebugManagerStateRestore restorer; diff --git a/level_zero/core/test/unit_tests/sources/helper/l0_hw_helper_tests.cpp b/level_zero/core/test/unit_tests/sources/helper/l0_hw_helper_tests.cpp index 7ff412c2f3..c8e679c99c 100644 --- a/level_zero/core/test/unit_tests/sources/helper/l0_hw_helper_tests.cpp +++ b/level_zero/core/test/unit_tests/sources/helper/l0_hw_helper_tests.cpp @@ -787,10 +787,10 @@ HWTEST2_F(L0HwHelperEventMultiKernelDisabledL3FlushCompactEnabledTest, EXPECT_EQ(expectedPacket, l0CoreHelper.getEventBaseMaxPacketCount(hwInfo)); } -TEST_F(L0CoreHelperTest, givenL0CoreHelperWhenGettingDefaultValueForSignalAllEventPacketThenReturnTrue) { +TEST_F(L0CoreHelperTest, givenL0CoreHelperWhenGettingDefaultValueForSignalAllEventPacketThenReturnFalse) { auto hwInfo = *NEO::defaultHwInfo.get(); bool defaultValue = L0::L0CoreHelper::useSignalAllEventPackets(hwInfo); - EXPECT_TRUE(defaultValue); + EXPECT_FALSE(defaultValue); } } // namespace ult