intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-03 23:03:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

feature: add Drm-specific memoryBanks computation logic

Browse Source 
Related-To: NEO-9754

Signed-off-by: Maciej Bielski <maciej.bielski@intel.com>
This commit is contained in:
Maciej Bielski
2024-06-24 11:22:43 +00:00
committed by Compute-Runtime-Automation
parent 3dd051c3ee
commit f99846a108
7 changed files with 125 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
shared/test/unit_test/os_interface/linux/drm_memory_manager_tests.cpp
View File

@@ -34,6 +34,7 @@
#include "shared/test/common/mocks/mock_host_ptr_manager.h"
#include "shared/test/common/os_interface/linux/drm_memory_manager_fixture.h"
#include "shared/test/common/os_interface/linux/drm_mock_cache_info.h"
#include "shared/test/common/os_interface/linux/drm_mock_memory_info.h"
#include "shared/test/common/os_interface/linux/sys_calls_linux_ult.h"
#include "shared/test/common/test_macros/hw_test.h"
@@ -5202,6 +5203,83 @@ TEST_F(DrmMemoryManagerWithLocalMemoryTest, givenDrmMemoryManagerWithLocalMemory
memoryManager->unlockResource(&drmAllocation);
}
TEST_F(DrmMemoryManagerWithLocalMemoryTest, givenSingleLocalMemoryWhenParticularSubdeviceIndicatedThenCorrectBankIsSelected) {
auto *memoryInfo = static_cast<MockMemoryInfo *>(mock->memoryInfo.get());
auto &localMemoryRegions = memoryInfo->localMemoryRegions;
localMemoryRegions.resize(1U);
localMemoryRegions[0].tilesMask = 0b11;
AllocationProperties properties{1, true, 4096, AllocationType::buffer, false, {}};
properties.subDevicesBitfield = 0b10;
memoryManager->computeStorageInfoMemoryBanksCalled = 0U;
auto storageInfo = memoryManager->createStorageInfoFromProperties(properties);
constexpr auto expectedMemoryBanks = 0b01;
EXPECT_EQ(storageInfo.memoryBanks, expectedMemoryBanks);
EXPECT_EQ(memoryManager->computeStorageInfoMemoryBanksCalled, 2UL);
}
TEST_F(DrmMemoryManagerWithLocalMemoryTest, givenSingleLocalMemoryWhenAllSubdevicesIndicatedThenCorrectBankIsSelected) {
auto *memoryInfo = static_cast<MockMemoryInfo *>(mock->memoryInfo.get());
auto &localMemoryRegions = memoryInfo->localMemoryRegions;
localMemoryRegions.resize(1U);
localMemoryRegions[0].tilesMask = 0b11;
AllocationProperties properties{1, true, 4096, AllocationType::buffer, false, {}};
properties.subDevicesBitfield = 0b11;
memoryManager->computeStorageInfoMemoryBanksCalled = 0U;
auto storageInfo = memoryManager->createStorageInfoFromProperties(properties);
constexpr auto expectedMemoryBanks = 0b01;
EXPECT_EQ(storageInfo.memoryBanks, expectedMemoryBanks);
EXPECT_EQ(memoryManager->computeStorageInfoMemoryBanksCalled, 2UL);
}
TEST_F(DrmMemoryManagerWithLocalMemoryTest, givenMultipleLocalMemoryRegionsWhenParticularSubdeviceIndicatedThenItIsSelected) {
auto *memoryInfo = static_cast<MockMemoryInfo *>(mock->memoryInfo.get());
auto &localMemoryRegions = memoryInfo->localMemoryRegions;
constexpr auto leastOccupiedBankBitPosition = 1u;
debugManager.flags.OverrideLeastOccupiedBank.set(leastOccupiedBankBitPosition);
localMemoryRegions.resize(2U);
localMemoryRegions[0].tilesMask = 0b01;
localMemoryRegions[1].tilesMask = 0b10;
AllocationProperties properties{1, true, 4096, AllocationType::buffer, false, {}};
properties.subDevicesBitfield = 0b10;
const auto expectedMemoryBanks = properties.subDevicesBitfield;
memoryManager->computeStorageInfoMemoryBanksCalled = 0U;
auto storageInfo = memoryManager->createStorageInfoFromProperties(properties);
EXPECT_EQ(storageInfo.memoryBanks, expectedMemoryBanks);
EXPECT_EQ(memoryManager->computeStorageInfoMemoryBanksCalled, 2UL);
}
TEST_F(DrmMemoryManagerWithLocalMemoryTest, givenMultipleLocalMemoryRegionsWhenAllSubdevicesIndicatedThenTheLeastOccuppiedBankIsSelected) {
auto *memoryInfo = static_cast<MockMemoryInfo *>(mock->memoryInfo.get());
auto &localMemoryRegions = memoryInfo->localMemoryRegions;
constexpr auto leastOccupiedBankBitPosition = 1u;
debugManager.flags.OverrideLeastOccupiedBank.set(leastOccupiedBankBitPosition);
localMemoryRegions.resize(2U);
localMemoryRegions[0].tilesMask = 0b01;
localMemoryRegions[1].tilesMask = 0b10;
AllocationProperties properties{1, true, 4096, AllocationType::buffer, false, {}};
properties.subDevicesBitfield = 0b11;
const auto expectedMemoryBanks = memoryManager->createStorageInfoFromPropertiesGeneric(properties).memoryBanks;
memoryManager->computeStorageInfoMemoryBanksCalled = 0U;
auto storageInfo = memoryManager->createStorageInfoFromProperties(properties);
EXPECT_EQ(storageInfo.memoryBanks, expectedMemoryBanks);
EXPECT_EQ(memoryManager->computeStorageInfoMemoryBanksCalled, 2UL);
}
using DrmMemoryManagerTest = Test<DrmMemoryManagerFixture>;
TEST_F(DrmMemoryManagerTest, givenDrmMemoryManagerWhenCopyMemoryToAllocationThenAllocationIsFilledWithCorrectData) {