Commit Graph

102 Commits

Author SHA1 Message Date
Dominik Dabek
1cbfdbf39a refactor: isFlushBetweenBlitsRequired helper
Moved from miArbCheckWaRequired in blit helper to product helper.

Preparation to remove flushes between blits on compatible platforms.

Related-To: NEO-16925

Signed-off-by: Dominik Dabek <dominik.dabek@intel.com>
2025-12-10 10:40:15 +01:00
Radoslaw Jablonski
44645a3ed6 test: remove flawed blit test
This test naively compares estimated blit command stream sizes instead
of actually checking if a command stream is correctly programmed.

The tested functionality is already covered by
givenMultiRootDeviceSyncNodeWhenFlushBcsTaskThenMiFlushAdded.

Signed-off-by: Radoslaw Jablonski <radoslaw.jablonski@intel.com>
2025-09-29 11:06:11 +02:00
Bartosz Dunajski
1348d62070 Revert "refactor: remove post blit arb_check wa"
This reverts commit 3d865bdea1.

Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2025-09-15 15:21:51 +02:00
Szymon Morek
a31eef9bf5 refactor: add option to retrieve comp format from GMM
Signed-off-by: Szymon Morek <szymon.morek@intel.com>
2025-09-12 15:37:25 +02:00
Bellekallu Rajkiran
dfe623da1f refactor: Unify blitter copy property construction methods
Signed-off-by: Bellekallu Rajkiran <bellekallu.rajkiran@intel.com>
2025-09-10 13:10:15 +02:00
Bellekallu Rajkiran
0557b82586 fix: nullptr dereference for blitProperties allocations
Related-To: NEO-15461

Signed-off-by: Narendra Bagria <narendra.bagria@intel.com>
Signed-off-by: Bellekallu Rajkiran <bellekallu.rajkiran@intel.com>
2025-09-02 12:14:06 +02:00
Narendra Bagria
31bcea128f feature: system allocator support for image APIs
Related-To: NEO-15461

Signed-off-by: Young Jin Yoon <young.jin.yoon@intel.com>
Signed-off-by: Narendra Bagria <narendra.bagria@intel.com>
2025-08-26 09:35:22 +02:00
Compute-Runtime-Validation
82a1d0c81c Revert "feature: system allocator support for image APIs"
This reverts commit 001f3a3816.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2025-08-23 02:06:57 +02:00
Narendra Bagria
001f3a3816 feature: system allocator support for image APIs
Related-To: NEO-15461

Signed-off-by: Young Jin Yoon <young.jin.yoon@intel.com>
Signed-off-by: Narendra Bagria <narendra.bagria@intel.com>
2025-08-22 10:23:15 +02:00
Szymon Morek
9604a9d8f0 performance: change compression format on PTL
Related-To: NEO-14942

Signed-off-by: Szymon Morek <szymon.morek@intel.com>
2025-08-20 14:57:12 +02:00
Bartosz Dunajski
3d865bdea1 refactor: remove post blit arb_check wa
Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2025-08-19 16:34:40 +02:00
Bartosz Dunajski
9ad49331fd fix: add missing bcs cmd stream estimation
Related-To: HSD-18043131946

Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2025-08-18 18:26:27 +02:00
Compute-Runtime-Validation
5fe59104a4 Revert "refactor: remove post blit arb_check wa"
This reverts commit 9dd783e113.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2025-08-15 01:57:27 +02:00
Bartosz Dunajski
9dd783e113 refactor: remove post blit arb_check wa
Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2025-08-14 09:35:55 +02:00
Szymon Morek
de92cd90be refactor: respect comp format debug flags on iGPU
Related-To: NEO-14942

Signed-off-by: Szymon Morek <szymon.morek@intel.com>
2025-08-13 16:09:04 +02:00
Szymon Morek
9f02c72f15 performance: Change compression format on BCS for Xe2
Related-To: NEO-15454

Signed-off-by: Szymon Morek <szymon.morek@intel.com>
2025-07-07 16:23:38 +02:00
Mateusz Jablonski
10e44f531f test: simplify test for blit commands
reduce max blit size to speed-up test execution

Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2025-07-01 13:24:12 +02:00
John Falkowski
23394ad330 test: Add tests for blit code coverage
Related-To: NEO-13697

Signed-off-by: John Falkowski <john.falkowski@intel.com>
2025-06-18 20:50:54 +02:00
Marcel Skierkowski
a52260ce63 test: StreamCapture on pipes
Enhance StreamCapture class to mimic gtest's CaptureStdout/Stderr functionality.
Store data in a pipe instead of a temporary file like gtest
resulting in faster test execution

Signed-off-by: Marcel Skierkowski <marcel.skierkowski@intel.com>
2025-06-11 15:37:01 +02:00
John Falkowski
805a716fe3 feature: Implement appendMemoryCopy/Fill for Shared System USM
Related-To: NEO-13697

Signed-off-by: John Falkowski <john.falkowski@intel.com>
2025-06-09 16:18:56 +02:00
Young Jin Yoon
2773bd8ec0 fix: estimate blitter commands for memory fill
Added getNumberOfBlitsForColorFill, getNumberofBlitsForByteFill,
and getNumberOfBlitsForFill in BlitCommandsHelper to estimate
total number of blitter command generated for
dispatchBlitMemoryColorFill, dispatchBlitMemoryByteFill, and
dispatchBlitMemoryFill, respectively.

Use getNumberOfBlitsForColorFill to determine whether
additionalTimestampNode is required for appendMemoryBlitFill.

Related-To: NEO-13003
Signed-off-by: Young Jin Yoon <young.jin.yoon@intel.com>
2025-05-29 00:21:35 +02:00
Young Jin Yoon
5221b5b00e fix: patch counter values with additional blit properties
Modified BlitCommandsHelper and CommandListHw to patch counter values
when using additional blit properties and in order command list is
enabled.

Related-To: NEO-13003

Signed-off-by: Young Jin Yoon <young.jin.yoon@intel.com>
2025-05-13 04:32:31 +02:00
Young Jin Yoon
eae350bc45 fix: apply additional blit only for first and last blit commands
Modified BlitCommandsHelper object to apply additional blit
properties only to first and last blit commands properly

Related-To: NEO-13003

Signed-off-by: Young Jin Yoon <young.jin.yoon@intel.com>
2025-05-09 07:04:34 +02:00
Young Jin Yoon
415fe245d7 feature: apply or set additional blit properties
Modified appendMemoryCopyBlitRegion, appendCopyImageBlit,
appendMemoryCopyRegion, and appendBlitFill in
CommmandListCoreFamily to change behavior when
useAdditionaBlitProperties is used.
Modified dispatchBlitMemoryFill and
dispatchBlitCommandForImageRegion in BlitCommandHelper to
call applyAdditionalProperties when useAdditionalProperties
is enabled.

Related-To: NEO-13003

Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@intel.com>
Signed-off-by: Young Jin Yoon <young.jin.yoon@intel.com>
2025-05-09 00:04:57 +02:00
Young Jin Yoon
529b89c16a feature: support copy function post-sync [4/n]
Added EncodePostSync to BlitPostSyncProperties, and
applyAdditionalBlitProperties to BlitCommandsHelper.

Related-To: NEO-13003
Signed-off-by: Young Jin Yoon <young.jin.yoon@intel.com>
2025-05-02 00:02:43 +02:00
Compute-Runtime-Validation
0c3b765942 Revert "refactor: add BlitSyncPropertiesExt to BlitSyncProperties"
This reverts commit b5a259aded.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2025-05-01 03:23:53 +02:00
Young Jin Yoon
b5a259aded refactor: add BlitSyncPropertiesExt to BlitSyncProperties
Added BlitSyncPropertiesExt to provide additional information for
different platform and/or blitter commands.

Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@intel.com>
Signed-off-by: Young Jin Yoon <young.jin.yoon@intel.com>
2025-04-30 19:11:34 +02:00
Andrzej Koska
d0871e0e37 fix: Fix copying with blitter
Related-To: NEO-12134, NEO-13874, NEO-14002

Thanks to this change we avoid programming y1 offset for 2D surface
above the maximum allowable value, i.e. 16 kb for blitter for BMG

Signed-off-by: Andrzej Koska <andrzej.koska@intel.com>
2025-02-06 14:11:23 +01:00
Compute-Runtime-Validation
5d3a914849 Revert "fix: Fix copying with blitter"
This reverts commit efcbd3875b.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2025-02-06 02:14:19 +01:00
Andrzej Koska
efcbd3875b fix: Fix copying with blitter
Related-To: NEO-12134, NEO-13874

Thanks to this change we avoid programming y1 offset for 2D surface
above the maximum allowable value, i.e. 16 kb for blitter for BMG

Signed-off-by: Andrzej Koska <andrzej.koska@intel.com>
2025-02-04 19:07:50 +01:00
Bartosz Dunajski
dd1e85a3d4 fix: bcs mem fill pattern alignment
Related-To: NEO-13928

Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2025-02-03 14:43:04 +01:00
Bartosz Dunajski
4846fbe410 refactor: unify blit memory fill methods and pass BlitProperties 2
Related-To: NEO-13003

Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2025-01-30 20:16:10 +01:00
Compute-Runtime-Validation
21021f0340 Revert "refactor: unify blit memory fill methods and pass BlitProperties"
This reverts commit d7ca6568fc.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2025-01-29 02:09:59 +01:00
Bartosz Dunajski
d7ca6568fc refactor: unify blit memory fill methods and pass BlitProperties
Related-To: NEO-13003

Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2025-01-28 17:47:31 +01:00
Mateusz Jablonski
d4e201db86 test: remove not used usings/typedefs/variables in shared tests
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2024-11-29 10:46:10 +01:00
Mateusz Jablonski
4f715c9b6a test: remove not needed tests
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2024-09-16 18:45:46 +02:00
Jaroslaw Warchulski
63da79798d refactor: reduce the number of GraphicsAllocation constructors and derivatives
Signed-off-by: Jaroslaw Warchulski <jaroslaw.warchulski@intel.com>
2024-06-18 21:31:37 +02:00
Mateusz Jablonski
55fad237b8 test: update gtest API usage
use *_TEST_SUITE* instead of *_TEST_CASE*

Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2024-05-28 16:20:06 +02:00
Mateusz Jablonski
614ed7ff5f fix: remove not needed appendBaseAddressOffset method
Related-To: NEO-10623
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2024-03-20 17:46:14 +01:00
Mateusz Jablonski
80aa55a3cb fix: don't program dummy blit prior to MI_FLUSH_DW without postsync
add missing dummy blits before MI_FLUSH_DW with postsync

Related-To: NEO-9996
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2024-03-01 12:36:13 +01:00
Compute-Runtime-Validation
5fce046877 Revert "fix: don't program dummy blit prior to MI_FLUSH_DW without postsync"
This reverts commit d796fb559d.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2024-03-01 01:43:35 +01:00
Mateusz Jablonski
d796fb559d fix: don't program dummy blit prior to MI_FLUSH_DW without postsync
add missing dummy blits before MI_FLUSH_DW with postsync

Related-To: NEO-9996
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2024-02-29 13:30:09 +01:00
Mateusz Jablonski
b6b53daa3f fix: don't program dummy blit prior to MI ARB CHECK
Related-To: NEO-9996
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2024-02-27 15:46:46 +01:00
Compute-Runtime-Validation
0b64240deb Revert "feature: enable dummy blit WA for PVC"
This reverts commit fb9d225495.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2024-02-08 04:27:00 +01:00
Mateusz Jablonski
fb9d225495 feature: enable dummy blit WA for PVC
cleanup redundant implementation for DG2

Related-To: NEO-9996
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2024-02-06 10:17:12 +01:00
Mateusz Jablonski
0f5389b452 refactor: rename alias PARSE -> Parse
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2023-12-21 16:17:15 +01:00
Mateusz Jablonski
01dd503e47 refactor: correct naming of MemoryPool enum values
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2023-12-13 07:51:39 +01:00
Mateusz Jablonski
b182917d9d refactor: correct naming of allocation types
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2023-12-11 16:23:37 +01:00
Mateusz Jablonski
e57d372608 refactor: correct naming of enum class constants
EngineGroupType
BlitDirection
PostBlitMode
WaitStatus

Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2023-12-01 11:53:51 +01:00
Mateusz Jablonski
c9664e6bad refactor: rename global debug manager to debugManager
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2023-11-30 13:00:59 +01:00