Commit Graph

3524 Commits

Author SHA1 Message Date
Zbigniew Zdanowicz
b6e2d2df8b Add multi return points command lists for front end reconfiguration
This change gives fine grain control over front end configuration for each
kernel.
As it gives possible to inject FE command in command queue and return to exact
place in command list.
Programming commands in queue makes patching commands in command lists
not needed as that operation is costly.
And it allows to program context information for each command list too.

Related-To: NEO-5019

Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
2022-09-07 12:53:24 +02:00
Compute-Runtime-Validation
c0ce477f85 Revert "Enable BCS split WA in OCL"
This reverts commit abfcaf1265.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2022-09-06 20:42:57 +02:00
Naklicki, Mateusz
f7332fc30b Change order of EncodeDispatchKernelArgs members
Order members by their size

Signed-off-by: Naklicki, Mateusz <mateusz.naklicki@intel.com>
2022-09-06 16:49:48 +02:00
Dunajski, Bartosz
84872812f2 Remove not used helper
Signed-off-by: Dunajski, Bartosz <bartosz.dunajski@intel.com>
2022-09-06 16:02:56 +02:00
Patryk Wrobel
53c127e64c Remove superfluous const_casts
Signed-off-by: Patryk Wrobel <patryk.wrobel@intel.com>
2022-09-06 13:34:01 +02:00
Dunajski, Bartosz
16d9000429 Add option to change GRF mode
Signed-off-by: Dunajski, Bartosz <bartosz.dunajski@intel.com>
2022-09-06 13:00:17 +02:00
Wrobel, Patryk
334802c9ba Use correct format string in ocloc_validator
Signed-off-by: Wrobel, Patryk <patryk.wrobel@intel.com>
2022-09-06 12:25:19 +02:00
Kacper Nowak
b41eed8438 CMake: correct test kernels naming + minor improvements
- For test kernels compiled with options passed, change their naming to
following convention:
{basename}_{options_passed}_{suffix}.
- Correct CMake variables naming.
- Refactor logic of retrieving test kernels' data (also in compilers
mock)
- In relation to previous changes: do not generate unnecessary
.gen binary for L0 test kernel

Related-To: NEO-7285
Signed-off-by: Kacper Nowak <kacper.nowak@intel.com>
2022-09-06 11:19:46 +02:00
Dominik Dabek
16798467ac Add api specific config for allocation cache
Currently disabled for both opencl and level zero

Related-To: NEO-6893

Signed-off-by: Dominik Dabek <dominik.dabek@intel.com>
2022-09-05 21:15:18 +02:00
Patryk Wrobel
09bb0766e2 Remove undefined behavior from debug_settings_manager.cpp
It is undefined behavior to add definition of function overload to std
namespace.

Signed-off-by: Patryk Wrobel <patryk.wrobel@intel.com>
2022-09-05 21:04:16 +02:00
Yates, Brandon
12c7f32679 L0 Win Debugger - implement thread control
Resolves: NEO-6722

Signed-off-by: Yates, Brandon <brandon.yates@intel.com>
Signed-off-by: Igor Venevtsev <igor.venevtsev@intel.com>
2022-09-05 19:26:14 +02:00
Szymon Morek
403b49e987 Append additional fill kernel for left leftover
Related-To: NEO-7287

Signed-off-by: Szymon Morek <szymon.morek@intel.com>
2022-09-05 18:08:26 +02:00
Wrobel, Patryk
a8db8b852a Fix undefined behaviors discovered in tests
This change removes the following UBs:
- calling std::vector::insert() with source range, which comes
from the destination vector; when vector needs to grow then
the source iterators are invalid
- comparison of singular (default-constructed) iterators is
disallowed

Signed-off-by: Wrobel, Patryk <patryk.wrobel@intel.com>
2022-09-05 15:24:58 +02:00
Warchulski, Jaroslaw
57da7ad307 Don't generate gen file by default
Related-To: NEO-6613
Signed-off-by: Warchulski, Jaroslaw <jaroslaw.warchulski@intel.com>
2022-09-05 15:00:48 +02:00
Lukasz Jobczyk
abfcaf1265 Enable BCS split WA in OCL
Signed-off-by: Lukasz Jobczyk <lukasz.jobczyk@intel.com>
2022-09-05 13:34:11 +02:00
Katarzyna Cencelewska
7faf861408 Call setupHardwareInfoBase inside setupHardwareInfo on pvc
Signed-off-by: Katarzyna Cencelewska <katarzyna.cencelewska@intel.com>
2022-09-05 13:15:33 +02:00
Lukasz Jobczyk
0d6bef0753 Add BCS split to api specific config
Signed-off-by: Lukasz Jobczyk <lukasz.jobczyk@intel.com>
2022-09-05 11:13:10 +02:00
Compute-Runtime-Validation
3e7276cdf8 Revert "Call setupHardwareInfoBase inside setupHardwareInfo on pvc"
This reverts commit 11374b83af.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2022-09-03 21:55:53 +02:00
Compute-Runtime-Validation
20f49481f2 Revert "Enable BCS split WA in OCL"
This reverts commit d672920121.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2022-09-03 20:25:10 +02:00
Compute-Runtime-Validation
c8975e14fe Revert "Fix printf for type BYTE and SHORT"
This reverts commit b04c226767.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2022-09-03 14:11:26 +02:00
Compute-Runtime-Validation
c3fffcc8c0 Revert "Default L0 Function & Global Symbols with fallback build"
This reverts commit 2157f15594.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2022-09-03 07:08:52 +02:00
Neil R Spruit
2157f15594 Default L0 Function & Global Symbols with fallback build
- Enabled default setting of Program & Global Symbols to be generated by
IGC when building L0 Modules with the ability to fallback to previous
behavior thru build failure checks.

- Enabled selective disable of default program or global symbol
generation thru debug variables.

Signed-off-by: Neil R Spruit <neil.r.spruit@intel.com>
2022-09-02 19:16:40 +02:00
Jitendra Sharma
3212a71760 Debugger L0 Win: Attention event handling from UMD
Related-To: NEO-7261

Signed-off-by: Jitendra Sharma <jitendra.sharma@intel.com>
2022-09-02 18:22:41 +02:00
Dunajski, Bartosz
22fb71a268 Walker partition: Improve barrier programming
Signed-off-by: Dunajski, Bartosz <bartosz.dunajski@intel.com>
2022-09-02 18:09:38 +02:00
Mateusz Jablonski
e1c7e194ee ULT: remove gmock WA from opencl/shared tests
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2022-09-02 17:58:08 +02:00
Krystian Chmielewski
bb2967d2c6 Add handling for invalid kernel attribute
This commit adds handling for "invalid_kernel" kernel's attribute.
This attribute is present when kernel is invalid e.g. could not be
correctly compiled due to missing feature.

Signed-off-by: Krystian Chmielewski <krystian.chmielewski@intel.com>
2022-09-02 17:51:22 +02:00
Zbigniew Zdanowicz
18af46296d Optimize programming of front end by selecting correct hardware
Related-To: NEO-5019

Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
2022-09-02 17:41:37 +02:00
Zbigniew Zdanowicz
a4b9b3b837 Extend encode class for start and end hw commands
Related-To: NEO-5019

Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
2022-09-02 16:29:36 +02:00
Dunajski, Bartosz
3c8c09634f Add fallback path to query L3 size
Signed-off-by: Dunajski, Bartosz <bartosz.dunajski@intel.com>
2022-09-02 15:32:16 +02:00
Zbigniew Zdanowicz
2d8324c954 add front end command query methods to unit test helpers
Related-To: NEO-5019

Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
2022-09-02 15:07:49 +02:00
Patryk Wrobel
e0b686a538 Remove possible out-of-bound array access from Drm::registerResource()
Signed-off-by: Patryk Wrobel <patryk.wrobel@intel.com>
2022-09-02 14:05:02 +02:00
Dominik Dabek
485ba234f3 Revert change DG2 l1 cache policy
This reverts cache policy back to WBP,
due to functional regressions

Related-To: NEO-7003

Signed-off-by: Dominik Dabek <dominik.dabek@intel.com>
2022-09-02 12:02:14 +02:00
Krystian Chmielewski
b04c226767 Fix printf for type BYTE and SHORT
Generated instructions writing to printf buffer require destination
address to be DWORD aligned. Because of that values of type BYTE (1B)
and SHORT (2B) need to be written as 4B value.
This change adds support for this. When trying to read value of type
BYTE or SHORT four bytes are actually read to be aligned with compiler
implementation.

Signed-off-by: Krystian Chmielewski <krystian.chmielewski@intel.com>
2022-09-01 17:58:31 +02:00
Patryk Wrobel
90ba50bf52 Warn when RAII lock returned from function is discarded
Discarding RAII lock returned from function almost always
is a bug. This change introduces usage of [[no_discard]]
attribute from C++17 to prevent such misues.

Signed-off-by: Patryk Wrobel <patryk.wrobel@intel.com>
2022-09-01 16:53:03 +02:00
Lukasz Jobczyk
d672920121 Enable BCS split WA in OCL
Signed-off-by: Lukasz Jobczyk <lukasz.jobczyk@intel.com>
2022-09-01 16:26:00 +02:00
Katarzyna Cencelewska
11374b83af Call setupHardwareInfoBase inside setupHardwareInfo on pvc
Signed-off-by: Katarzyna Cencelewska <katarzyna.cencelewska@intel.com>
2022-09-01 15:41:14 +02:00
Szymon Morek
25f4b06258 Use uint4 type instead of char in builtin kernel
Related-To: NEO-7287

Signed-off-by: Szymon Morek <szymon.morek@intel.com>
2022-09-01 14:58:56 +02:00
Mateusz Jablonski
e110f51fa3 Move tests from opencl to shared
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2022-09-01 09:38:40 +02:00
Compute-Runtime-Validation
84f19a1b93 Revert "Use uint4 type instead of char in builtin kernel"
This reverts commit a39bc7e7b3.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2022-09-01 05:35:54 +02:00
ocldev
6e5c0141b5 Brand string update
Updating device brand strings
Based on public support in Windows driver 31.0.101.3222
https://www.intel.com/content/www/us/en/download/19344

Signed-off-by: ocldev <ocldev@intel.com>
2022-08-31 22:16:40 +02:00
Zbigniew Zdanowicz
c3f7e40a8d Rename special pipeline select mode to systolic
Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
2022-08-31 22:16:26 +02:00
Lukasz Jobczyk
399758ef17 Change default engines for BCS split
Signed-off-by: Lukasz Jobczyk <lukasz.jobczyk@intel.com>
2022-08-31 21:34:36 +02:00
Szymon Morek
a39bc7e7b3 Use uint4 type instead of char in builtin kernel
Related-To: NEO-7287

Signed-off-by: Szymon Morek <szymon.morek@intel.com>
2022-08-31 16:04:22 +02:00
Dominik Dabek
8cc0177f1c Change DG2 l1 cache policy to WB
With compiler LSC WAs this gives better performance.

If debugger is active, policy will not be changed ie.
will be WBP.

Related-To: NEO-7003

Signed-off-by: Dominik Dabek <dominik.dabek@intel.com>
2022-08-31 14:31:23 +02:00
Artur Harasimiuk
6118e41741 do not load FCL in Level Zero runtime
Signed-off-by: Artur Harasimiuk <artur.harasimiuk@intel.com>
2022-08-31 13:51:23 +02:00
Dunajski, Bartosz
2102117e12 Fix data race for TLB flush check
Signed-off-by: Dunajski, Bartosz <bartosz.dunajski@intel.com>
2022-08-31 12:27:48 +02:00
Maciej Plewka
fe73c06b59 Disable overdispatch for specific Arc devices
Signed-off-by: Maciej Plewka <maciej.plewka@intel.com>
2022-08-31 12:09:54 +02:00
Mateusz Jablonski
f42e012bd8 Retry calling ioctl when getting -EBUSY from ioctl call
Related-To: NEO-7195
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2022-08-31 11:55:36 +02:00
Zbigniew Zdanowicz
a7af94496b Remove RMV from programming of command buffers
Signed-off-by: Zbigniew Zdanowicz <zbigniew.zdanowicz@intel.com>
2022-08-31 11:44:27 +02:00
Mateusz Hoppe
75b117b82f L0Debug - fixes for ZE AFFINITY MASK
- pass correct deviceIndex when notifying cmdQs
- fix allocating debug surface - single tile allocation when single
bit set in storageInfo

Related-To: NEO-6980

Signed-off-by: Mateusz Hoppe <mateusz.hoppe@intel.com>
2022-08-31 11:43:19 +02:00